Reviewed-by: Oscar Mateo oscar.ma...@intel.com
(sorry, I forgot about this one)
-Original Message-
From: intel-gfx-boun...@lists.freedesktop.org [mailto:intel-gfx-
boun...@lists.freedesktop.org] On Behalf Of joao.san...@intel.com
Sent: Thursday, January 23, 2014 6:30 PM
To:
On Tue, Jan 28, 2014 at 10:06:05AM -0200, Rodrigo Vivi wrote:
I agree that spec is strange, but following the spec correctly result
for this and next patch would be only this:
if (IS_IVB_GT1(dev))
I915_WRITE(GEN7_HALF_SLICE_CHICKEN1,
I have a machine here which hits this (a g33):
[ 13.368536] excessive driver sleep timeout (DSPL) 1024
Apparently people love pot numbers, and one second isn't that
unreasonable (for a bios writer at least) I guess.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
On Fri, Jan 31, 2014 at 10:31:16AM +0100, Daniel Vetter wrote:
I have a machine here which hits this (a g33):
[ 13.368536] excessive driver sleep timeout (DSPL) 1024
Apparently people love pot numbers, and one second isn't that
unreasonable (for a bios writer at least) I guess.
On Fri, Jan 31, 2014 at 09:36:25AM +, Barbalho, Rafael wrote:
The patch is incomplete. If you change these macros in the tests
directory then why does it not need to be changed in the tools
directory also?
I have a patch that refactors these macros into a third file, I'll
send it up for
Since dma_buf_vunmap() procedes blithely on ignorant of whether the
driver failed to actually unmap the backing storage for the dma-buf, we
need to make a best-effort to do so. This involves not allowing
ourselves to be susceptible to signals causing us to leak the storage.
This should have been
There are quite alot of nasty things happening inside the
seemingly bening intel_ring_begin() if seqno wrap happens.
Warn the reader about it.
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com
---
drivers/gpu/drm/i915/intel_ringbuffer.c |8 +++-
1 file changed, 7 insertions(+), 1
On Fri, Jan 31, 2014 at 01:04:21PM +0200, Mika Kuoppala wrote:
There are quite alot of nasty things happening inside the
seemingly bening intel_ring_begin() if seqno wrap happens.
Warn the reader about it.
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com
---
EFAULT will be a possible return code where backing storage is
transient, such after it is purged by madvise. As such it is to be
expected and so should not trigger a WARN inside i915_gem_fault() but be
converted silently to SIGBUS.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
Since a purged buffer is one without any associated pages, attempting to
use it should generate EFAULT rather than EINVAL, as it is not strictly
an invalid parameter.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
drivers/gpu/drm/i915/i915_gem.c | 6 +++---
1 file changed, 3
The WARN is a bit too verbose, make it a DRM_INFO that gets printed
once.
While at it, fix the typo in DSLP.
Suggested-by: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
drivers/gpu/drm/i915/intel_opregion.c |6 +-
1 file changed, 5
On Fri, 31 Jan 2014, Daniel Vetter daniel.vet...@ffwll.ch wrote:
I have a machine here which hits this (a g33):
[ 13.368536] excessive driver sleep timeout (DSPL) 1024
Apparently people love pot numbers, and one second isn't that
unreasonable (for a bios writer at least) I guess.
Both registers must be programmed for the Mode bit to be valid. DevIVB:GT2 ...
So I also agree ;)
Maybe you should improve the commit message now that we are sure, but anyway:
Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com
On Fri, Jan 31, 2014 at 4:28 AM, Ville Syrjälä
On Fri, Jan 31, 2014 at 01:55:47PM +0200, Jani Nikula wrote:
On Fri, 31 Jan 2014, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Fri, Jan 31, 2014 at 01:41:08PM +0200, Jani Nikula wrote:
The WARN is a bit too verbose, make it a DRM_INFO that gets printed
once.
While at it, fix the
On Fri, 31 Jan 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Fri, Jan 31, 2014 at 01:41:08PM +0200, Jani Nikula wrote:
The WARN is a bit too verbose, make it a DRM_INFO that gets printed
once.
While at it, fix the typo in DSLP.
Suggested-by: Chris Wilson
Found with smatch.
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com
---
drivers/gpu/drm/i915/i915_gem.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 08331e1..feedef9 100644
---
Found with smatch
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com
---
drivers/gpu/drm/i915/i915_gem_context.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
b/drivers/gpu/drm/i915/i915_gem_context.c
index 985c1ed..19fd362 100644
---
On Fri, 31 Jan 2014, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Fri, Jan 31, 2014 at 01:41:08PM +0200, Jani Nikula wrote:
The WARN is a bit too verbose, make it a DRM_INFO that gets printed
once.
While at it, fix the typo in DSLP.
Suggested-by: Chris Wilson ch...@chris-wilson.co.uk
On Fri, Jan 31, 2014 at 03:21:27PM +0200, Jani Nikula wrote:
On Fri, 31 Jan 2014, Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Fri, Jan 31, 2014 at 01:41:08PM +0200, Jani Nikula wrote:
The WARN is a bit too verbose, make it a DRM_INFO that gets printed
once.
While at it, fix
From: Rafael Barbalho rafael.barba...@intel.com
The lib directory should really be compiled as a static library on its own
and be re-used by any tests or tools that require it.
Signed-off-by: Rafael Barbalho rafael.barba...@intel.com
---
lib/Android.mk | 31 +++
1
From: Jeff McGee jeff.mc...@intel.com
The load helper can be set to HIGH or LOW. HIGH is the original mode
of sending continuous dword store commands. LOW adds a pause between
each command to reduce throughput.
Signed-off-by: Jeff McGee jeff.mc...@intel.com
---
tests/pm_rps.c | 35
From: Jeff McGee jeff.mc...@intel.com
Test that RPS functions as expected after a gpu reset.
Signed-off-by: Jeff McGee jeff.mc...@intel.com
---
tests/pm_rps.c | 62 ++
1 file changed, 62 insertions(+)
diff --git a/tests/pm_rps.c
From: Sagar Kamble sagar.a.kam...@intel.com
DRM will not propagate the set_property call for bitmask drm
properties if they are not supported by underlying driver.
Signed-off-by: Sagar Kamble sagar.a.kam...@intel.com
Tested-by: Sagar Kamble sagar.a.kam...@intel.com
---
From: Jeff McGee jeff.mc...@intel.com
This patch set is dependent on set Add two new subtests to pm_rps.
Jeff McGee (4):
pm_rps: Add stop rings injection utility
pm_rps: Load helper should stall for last write
pm_rps: Add variable load support to load helper
pm_rps: New subtest for gpu
From: Rafael Barbalho rafael.barba...@intel.com
Not all versions of Android have the mmap64 call, thus a suitable alternative
must be called.
Signed-off-by: Rafael Barbalho rafael.barba...@intel.com
---
lib/intel_gpu_tools.h | 11 +++
1 file changed, 11 insertions(+)
diff --git
On Fri, Jan 31, 2014 at 01:41:08PM +0200, Jani Nikula wrote:
The WARN is a bit too verbose, make it a DRM_INFO that gets printed
once.
While at it, fix the typo in DSLP.
Suggested-by: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
From: Sagar Kamble sagar.a.kam...@intel.com
Use the new drm_mode_create_rotation_property() in omapdrm.
Signed-off-by: Ville Syrjala ville.syrj...@linux.intel.com
---
drivers/gpu/drm/omapdrm/omap_plane.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git
From: Sagar Kamble sagar.a.kam...@intel.com
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
Signed-off-by: Uma Shankar uma.shan...@intel.com
Signed-off-by: Sagar Kamble sagar.a.kam...@intel.com
Tested-by: Sagar Kamble sagar.a.kam...@intel.com
---
On Thu, Jan 30, 2014 at 11:08:16PM +0530, deepa...@intel.com wrote:
From: Deepak S deepa...@intel.com
When we enter RC6 and GFX Clocks are off, the voltage remains higher
than Vmin. When we try to set the freq to RPn, it might fail since the
Gfx clocks are down. So to fix this in Gfx idle,
From: Sagar Kamble sagar.a.kam...@intel.com
drm_rotation_simplify() can be used to eliminate unsupported rotation
flags. It will check if any unsupported flags are present, and if so
it will modify the rotation to an alternate form by adding 180 degrees
to rotation angle, and flipping the reflect
From: Rafael Barbalho rafael.barba...@intel.com
All the Android.mk files had the same directives to find the path of
libdrm libpciaccess. These are no longer required as the android system
now allows the libraries being used to export include paths to dependant
modules programs.
Signed-off-by:
From: Sagar Kamble sagar.a.kam...@intel.com
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
The upper layers are not yet plugged in.
Signed-off-by: Ville
From: Sagar Kamble sagar.a.kam...@intel.com
The rotation property stuff should be standardized among all drivers.
Move the bits to drm_crtc.h from omap_drv.h.
Signed-off-by: Ville Syrjala ville.syrj...@linux.intel.com
---
drivers/gpu/drm/omapdrm/omap_drv.h | 7 ---
include/drm/drm_crtc.h
From: Sagar Kamble sagar.a.kam...@intel.com
Add some helper functions to move drm_rects between different rotated
coordinate spaces. One function does the forward transform and
another does the inverse.
Signed-off-by: Ville Syrjala ville.syrj...@linux.intel.com
---
drivers/gpu/drm/drm_rect.c |
Reviewed-by: Rodrigo Vivi rodrigo.v...@gmail.com
I think this was the last wa patch to be reviewed yet. Please let me
know if I' m still missing any.
On Wed, Jan 22, 2014 at 2:32 PM, ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
Both Bspec and the
From: Sagar Kamble sagar.a.kam...@intel.com
This test will verify the 180 degree rotation of sprite and crtc planes.
It will allow user to control rotation separately for crtc and sprite
planes.
Signed-off-by: Sagar Kamble sagar.a.kam...@intel.com
---
demos/Makefile.am | 1 +
On Fri, Jan 31, 2014 at 03:49:08PM +0200, Jani Nikula wrote:
The WARN_ONCE is a bit too verbose, make it a DRM_INFO_ONCE.
While at it, add a #define for MAX_DSLP and make the message a bit more
informative.
v2: use DRM_INFO_ONCE, add MAX_DSLP, pimp the message.
Suggested-by: Chris
Just like DRM_INFO(), but only do it once.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
include/drm/drmP.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 04086c5be930..04a7f31301f8 100644
--- a/include/drm/drmP.h
+++
From: Deepak S deepa...@intel.com
When we enter RC6 and GFX Clocks are off, the voltage remains higher
than Vmin. When we try to set the freq to RPn, it might fail since the
Gfx clocks are down. So to fix this in Gfx idle, Bring the GFX clock up
and set the freq to RPn then move GFx down.
v2:
From: Rafael Barbalho rafael.barba...@intel.com
The lib directory is used by all the tests tools so it should really be
the place where the generate files are created.
Signed-off-by: Rafael Barbalho rafael.barba...@intel.com
---
lib/Android.mk | 33 +
1 file
The WARN_ONCE is a bit too verbose, make it a DRM_INFO_ONCE.
While at it, add a #define for MAX_DSLP and make the message a bit more
informative.
v2: use DRM_INFO_ONCE, add MAX_DSLP, pimp the message.
Suggested-by: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Jani Nikula
From: Sagar Kamble sagar.a.kam...@intel.com
With these patches 180 degree rotation for crtc and sprite planes will be
exposed through drm rotation properties implemented by Ville few days back.
I have added CRTC rotation support on top of Ville's 9 patches that includes
sprite rotation. Omapdrm
From: Rafael Barbalho rafael.barba...@intel.com
Instead of recompiling the lib directory for every tool or tests we can just
re-use the static library. This also has the nice side effect of fixing the
android mm command to allow android users to only rebuild the local changes
in either the test
From: Sagar Kamble sagar.a.kam...@intel.com
Add a function to create a standards compliant rotation property.
Signed-off-by: Ville Syrjala ville.syrj...@linux.intel.com
Tested-by: Sagar Kamble sagar.a.kam...@intel.com
---
drivers/gpu/drm/drm_crtc.c | 18 ++
From: Sagar Kamble sagar.a.kam...@intel.com
Sprite planes support 180 degree rotation. The lower layers are now in
place, so hook in the standard rotation property to expose the feature
to the users.
Signed-off-by: Ville Syrjala ville.syrj...@linux.intel.com
Tested-by: Sagar Kamble
From: Jeff McGee jeff.mc...@intel.com
Signed-off-by: Jeff McGee jeff.mc...@intel.com
---
tests/pm_rps.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index 709e341..a6807d2 100644
--- a/tests/pm_rps.c
+++
On Sat, Feb 01, 2014 at 12:40:36AM +0530, sagar.a.kam...@intel.com wrote:
From: Sagar Kamble sagar.a.kam...@intel.com
With these patches 180 degree rotation for crtc and sprite planes will be
exposed through drm rotation properties implemented by Ville few days back.
I have added CRTC
On Sat, Feb 01, 2014 at 12:40:41AM +0530, sagar.a.kam...@intel.com wrote:
From: Sagar Kamble sagar.a.kam...@intel.com
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
On Sat, Feb 01, 2014 at 12:40:46AM +0530, sagar.a.kam...@intel.com wrote:
From: Sagar Kamble sagar.a.kam...@intel.com
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
Signed-off-by: Uma Shankar uma.shan...@intel.com
Signed-off-by: Sagar Kamble
From: Jeff McGee jeff.mc...@intel.com
RPS manual mode disables/ignores load-based inputs and allows render
performance state to be controlled externally. The enabling of manual
mode and setting of desired frequency is done through debugfs.
i915_rps_manual:
'0' - RPS controlled normally using
From: Jeff McGee jeff.mc...@intel.com
i915_sr_disable:
'0' - CxSR enabled normally per device and settings.
'1' - CxSR explicitly disabled.
Signed-off-by: Jeff McGee jeff.mc...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 43 +
From: Jeff McGee jeff.mc...@intel.com
i915_fbc_disable:
'0' - FBC enabled normally per device and settings.
'1' - FBC explicitly disabled.
Signed-off-by: Jeff McGee jeff.mc...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 50 +
From: Jeff McGee jeff.mc...@intel.com
i915_ips_disable:
'0' - IPS enabled normally per device and settings.
'1' - IPS explicitly disabled.
Signed-off-by: Jeff McGee jeff.mc...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 47
From: Jeff McGee jeff.mc...@intel.com
This series has recently been accepted into the Haswell Android kernel and
helps with debugging and profiling these power features. I would like it
to be considered for upstream incorporation. The patches here have been
rebased (minimal changes required) and
From: Jeff McGee jeff.mc...@intel.com
i915_rc6_disable:
'0' - RC6 states used normally per device and settings.
'1' - RC6 states explicitly disabled.
Supports Gen6+ except Valleyview and Broadwell.
Signed-off-by: Jeff McGee jeff.mc...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 49
55 matches
Mail list logo
