[Intel-gfx] [PATCH 3/3] drm/i915: sdvo: add i2c sysfs symlink to the connector's directory

This is the same what we do for DP connectors, so make things more consistent. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_sdvo.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index e

[Intel-gfx] [PATCH 1/3] drm/i915: dp: fix order of dp aux i2c device cleanup

Atm we set the parent of the dp i2c device to be the correspondig connector device. During driver cleanup we first remove the connector device through intel_modeset_cleanup()->drm_sysfs_connector_remove() and only after that the i2c device through the encoder's destroy callback. This order is not s

[Intel-gfx] [PATCH 2/3] drm/i915: sdvo: fix error path in sdvo_connector_init

Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_sdvo.c | 49 +++ 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 95bdfb3..e9a2680 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 1/2] drm: expose subpixel order name routine v2

Just like we have for connector type etc. v2: drop static array (Chris) Signed-off-by: Jesse Barnes --- drivers/gpu/drm/drm_crtc.c | 16 include/drm/drm_crtc.h |1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.

[Intel-gfx] [PATCH 2/2] drm/i915: add a display info file to debugfs v2

Can be expanded up on to include all sorts of things (HDMI infoframe data, more DP status, etc). Should be useful for bug reports to get a baseline on the display config and info. v2: use seq_putc (Rodrigo) describe mode field names (Rodrigo) Reviewed-by: Rodrigo Vivi Signed-off-by: Jesse B

[Intel-gfx] [PATCH 5/9] drm/i915: Short-circuit no-op vga_set_state()

From: Chris Wilson Touching the VGA registers risks a hard machine hang, at least on this ivb machine after removing a conflicting efifb. This is more than likely related to the discovery that VGA IO decode on the more recent PCH platforms is terminally broken. Signed-off-by: Chris Wilson Cc: V

[Intel-gfx] [PATCH 7/9] drm/i915: Bring UP Power Wells before disabling RC6.

From: Deepak S We need do forcewake before Disabling RC6, This is what the BIOS expects while going into suspend. v2: updated commit message. (Daniel) Signed-off-by: Deepak S Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 6 ++ 1 file changed, 6 insertions(+) diff --g

[Intel-gfx] [PATCH 3/9] drm/i915: make crtc enable/disable asynchronous

From: Jesse Barnes The intent is to get back to userspace as quickly as possible so it can start doing drawing or whatever. It should also allow our suspend/resume/init time to improve a lot. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_irq.c | 10 +- drivers/gpu/drm

[Intel-gfx] [PATCH 2/9] drm/i915: wrap crtc enable/disable

From: Jesse Barnes This allows us to hide queuing of enable/disable later. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/intel_display.c | 83 +--- drivers/gpu/drm

[Intel-gfx] [PATCH 6/9] drm/i915: Verify address field of PCBR register.

From: Deepak S RC6 should be enabled only if the PCBR register is programmed properly either BIOS or Gfx. This patches address the case where PCBR allocation fails due buggy BIOS or due to stolen memory allocation failed. v2: Add #define for magic numbers (Daniel) v3: Use VLV_PCBR_ADDR_SHIFT in

[Intel-gfx] [PATCH 8/9] drm/i915: Flush GPU rendering with a lockless wait during a pagefault

From: Chris Wilson Arjan van de Ven reported that on his test machine that he was seeing stalls of greater than 1 frame greatly impacting the user experience. He tracked this down to being the locked flush during a pagefault as being the culprit hogging the struct_mutex and so blocking any other

[Intel-gfx] [PATCH 0/9] drm-intel-collector - update

This is another drm-intel-collector updated notice: http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector Here goes the update list in order for better reviewers assignment: Patch drm/i915: Propagate errors on failed PPGTT - Reviewer: Patch drm/i915: wrap crtc enable/

[Intel-gfx] [PATCH 1/9] drm/i915: Propagate errors on failed PPGTT

From: Ben Widawsky Clean up the return values/error handling so it's obvious what is going on. This was tripped over in the PPGTT branch where code was added to do a ret = foo() near the top, and this ended up bypassing some error cases later. These errors shouldn't exist with today's code, but

[Intel-gfx] [PATCH 9/9] drm/i915: PF CRC may not work on HSW

From: Ville Syrjälä When using pipe A and transcoder EDP w/o panel fitter on HSW, the PF CRC isn't available as the panel fitter is entirely bypassed. Check for this and refuse to give out CRCs. Signed-off-by: Ville Syrjälä Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_debugfs.c |

[Intel-gfx] [PATCH 4/9] drm/i915: Propagate PCI read/write errors during vga_set_state()

From: Chris Wilson This has very little effect other than log the errors in case of failure, and we then hope for the best. Signed-off-by: Chris Wilson Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) di

[Intel-gfx] [PATCH 1/6] drm/i915: split aligned height calculation out v2

For use by get_plane_config. v2: cleanup tile_height bits (Chris) Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_displa

[Intel-gfx] [PATCH 3/6] drm/i915: get_plane_config support for ILK+

This should allow BIOS fb inheritance to work on ILK+ machines too. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 92 ++ 1 file changed, 92 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_di

[Intel-gfx] [PATCH 4/6] drm/i915: alloc intel_fb in the intel_fbdev struct

Allocate this struct instead, so we can re-use another allocated elsewhere if needed. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c |4 ++-- drivers/gpu/drm/i915/intel_drv.h |2 +- drivers/gpu/drm/i915/intel_fbdev.c | 27 +++ 3 files

[Intel-gfx] [PATCH 5/6] drm/i915: allow re-use BIOS connector config for initial fbdev config

The BIOS or boot loader will generally create an initial display configuration for us that includes some set of active pipes and displays. This routine tries to figure out which pipes and connectors are active and stuffs them into the crtcs and modes array given to us by the drm_fb_helper code. S

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Disable SF pipelined attribute fetch for SNB

On 02/04/2014 11:59 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > According to Bspec we need to disable SF pipelined attribute fetch > whenever SF outputs exceed 16 and normal clip mode is used. A quick > glance at Mesa suggests that these conditions could happen. So let's >

[Intel-gfx] [PATCH 6/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v10

Retrieve current framebuffer config info from the regs and create an fb object for the buffer the BIOS or boot loader left us. This should allow for smooth transitions to userspace apps once we finish the initial configuration construction. v2: check for non-native modes and adjust (Jesse) fi

[Intel-gfx] [PATCH 2/6] drm/i915: get_plane_config for i9xx v10

Read out the current plane configuration at init time into a new plane_config structure. This allows us to track any existing framebuffers attached to the plane and potentially re-use them in our fbdev code for a smooth handoff. v2: update for new pitch_for_width function (Jesse) comment how

Re: [Intel-gfx] [PATCH 1/2] drm/i915: HSW PSR fix inverted sink DP_PSR_CFG link setup.

On Fri, Feb 7, 2014 at 5:14 PM, Ville Syrjälä wrote: > On Fri, Feb 07, 2014 at 04:09:47PM -0200, Rodrigo Vivi wrote: >> As pointed out by Ville we were using inverted logic here. >> According to spec: >> For link standby mode set 170h[1] = 1. >> For full link disabling set 170h[1] = 0. >> >> Cc: V

Re: [Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail

On Fri, Feb 07, 2014 at 09:56:29PM +0530, Vijay Purushothaman wrote: > On 2/7/2014 9:28 PM, Ville Syrjälä wrote: > > On Fri, Feb 07, 2014 at 08:43:12PM +0530, Vijay Purushothaman wrote: > >> B-spec says the FIFO total size is 512. So fix this to 512. > >> > >> Signed-off-by: Vijay Purushothaman >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: PSR HSW: update after enabling sprite.

On Fri, Feb 7, 2014 at 5:17 PM, Ville Syrjälä wrote: > On Fri, Feb 07, 2014 at 04:09:48PM -0200, Rodrigo Vivi wrote: >> On the current structure HSW doesn't support PSR with sprites enabled >> but sprites can be enabled after PSR was enabled what would cause >> user to miss screen updates. >> >> C

Re: [Intel-gfx] [PATCH 1/2] drm/i915: HSW PSR fix inverted sink DP_PSR_CFG link setup.

On Fri, Feb 07, 2014 at 04:09:47PM -0200, Rodrigo Vivi wrote: > As pointed out by Ville we were using inverted logic here. > According to spec: > For link standby mode set 170h[1] = 1. > For full link disabling set 170h[1] = 0. > > Cc: Ville Syrjälä > Signed-off-by: Rodrigo Vivi > --- > drivers

Re: [Intel-gfx] [PATCH 2/2] drm/i915: PSR HSW: update after enabling sprite.

On Fri, Feb 07, 2014 at 04:09:48PM -0200, Rodrigo Vivi wrote: > On the current structure HSW doesn't support PSR with sprites enabled > but sprites can be enabled after PSR was enabled what would cause > user to miss screen updates. > > Cc: Ville Syrjälä > Signed-off-by: Rodrigo Vivi > --- > dr

[Intel-gfx] [PATCH 3/8] drm/i915: Move num_plane to the intel_device_info structure

And rename it to num_sprites as this value doesn't count the primary plane. This limit lives with num_pipes really, and now that dev_priv->info is writable we can put it there instead. While at it, introduce a intel_device_info_runtime_init() where we'll be able to gather the device info fields a

[Intel-gfx] [PATCH 5/8] drm/i915: Disable display when fused off

FUSE_STRAP has a bit to inform us that the display has been fused off. Use it to setup the definitive number of pipes at run-time. v2: actually tweak num_pipes, not num_planes v3: also tests SFUSE_STRAP bit 7 v4: rebase on top of drm-nightly use DRM_INFO() for the message telling display is fu

[Intel-gfx] [PATCH 2/8] drm/i915: Make the intel_device_info structure kept in dev_priv writable

Turns out it'd be nice to change some device information at run-time or simply have some code to fill in the info struct instead of having to declare the values in 30+ structures. What prompted this change is handling fused out display/pipe and tweaking num_pipes at run-time, but I'm quite sure we

[Intel-gfx] Supporting fused display configurations v5

Follow up of v4: http://lists.freedesktop.org/archives/intel-gfx/2014-January/037913.html The major changes are: - we try to be cunning on CPT/PPT and look at the fuses lock bit of SFUSE_STRAP to detect if PCH display reads are being dropped - we provide a module parameter to forcefully

[Intel-gfx] [PATCH 4/8] drm/i915: Consolidate FUSE_STRAP in one set of defines

We had 2 set of defines for the same register, so make it one. Reviewed-by: Mika Kuoppala Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 18 -- drivers/gpu/drm/i915/intel_ddi.c | 2 +- drivers/gpu/drm/i915/intel_display.

[Intel-gfx] [PATCH 1/8] drm/i915: Always use INTEL_INFO() to access the device_info structure

If we make sure that all the dev_priv->info usages are wrapped by INTEL_INFO(), we can easily modify the ->info field to be structure and not a pointer while keeping the const protection in the INTEL_INFO() macro. v2: Rebased onto latest drm-nightly Suggested-by: Ville Syrjälä Signed-off-by: Dam

[Intel-gfx] [PATCH 7/8] drm/i915: Reorder i915_params fields to not create holes

Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 80ff7df..b1e91c3 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/

[Intel-gfx] [PATCH 6/8] drm/i915: Use I915_MAX_PIPES in the pipe/plane_to_crtc_mapping definitions

Reviewed-by: Mika Kuoppala Reviewed-by: Ville Syrjälä Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 36ea189..80ff7df 100644 --- a/d

[Intel-gfx] [PATCH 8/8] drm/i915: Provide a command line option to disable display

If we can't actually determine at run-time we have a fused-off display, provide at least an option to disable it. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_dma.c| 3 ++- drivers/gpu/drm/i915/i915_drv.h| 1 + drivers/gpu/drm/i915/i915_params.c | 4 3 files changed,

Re: [Intel-gfx] [PATCH 2/2] drm/i915: PSR HSW: update after enabling sprite.

On Fri, Feb 07, 2014 at 04:09:48PM -0200, Rodrigo Vivi wrote: > On the current structure HSW doesn't support PSR with sprites enabled > but sprites can be enabled after PSR was enabled what would cause > user to miss screen updates. > > Cc: Ville Syrjälä > Signed-off-by: Rodrigo Vivi Have you c

Re: [Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail

On Fri, Feb 07, 2014 at 05:58:16PM +0200, Ville Syrjälä wrote: > On Fri, Feb 07, 2014 at 08:43:12PM +0530, Vijay Purushothaman wrote: > > B-spec says the FIFO total size is 512. So fix this to 512. > > > > Signed-off-by: Vijay Purushothaman > > --- > > drivers/gpu/drm/i915/i915_reg.h |2 +- >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Baytrail PSR Support.

On Fri, Feb 07, 2014 at 04:05:26PM -0200, Rodrigo Vivi wrote: > On Fri, Feb 7, 2014 at 3:24 PM, Ville Syrjälä > wrote: > > On Wed, Feb 05, 2014 at 05:04:31PM -0200, Rodrigo Vivi wrote: > >> This patch adds PSR Support to Baytrail. > >> > >> Baytrail cannot easily detect screen updates and force PS

[Intel-gfx] [PATCH 2/2] drm/i915: PSR HSW: update after enabling sprite.

On the current structure HSW doesn't support PSR with sprites enabled but sprites can be enabled after PSR was enabled what would cause user to miss screen updates. Cc: Ville Syrjälä Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_sprite.c | 2 ++ 1 file changed, 2 insertions(+) dif

[Intel-gfx] [PATCH 1/2] drm/i915: HSW PSR fix inverted sink DP_PSR_CFG link setup.

As pointed out by Ville we were using inverted logic here. According to spec: For link standby mode set 170h[1] = 1. For full link disabling set 170h[1] = 0. Cc: Ville Syrjälä Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 8 1 file changed, 4 insertions(+), 4 deleti

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Baytrail PSR Support.

On Fri, Feb 7, 2014 at 3:24 PM, Ville Syrjälä wrote: > On Wed, Feb 05, 2014 at 05:04:31PM -0200, Rodrigo Vivi wrote: >> This patch adds PSR Support to Baytrail. >> >> Baytrail cannot easily detect screen updates and force PSR exit. >> So we inactivate it on {busy_ioctl, set_domain, sw_finish and m

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_seqno_wrap: fix over allocation of buffers

> [PATCH i-g-t 3/3] tests/gem_seqno_wrap: fix over allocation of buffers For clarity, this should probably be "fix over allocation of arrays", since the arrays were being allocated as an array of buffers instead of an array of pointers to buffers. Regards, Thomas

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add Baytrail PSR Support.

On Wed, Feb 05, 2014 at 05:04:31PM -0200, Rodrigo Vivi wrote: > This patch adds PSR Support to Baytrail. > > Baytrail cannot easily detect screen updates and force PSR exit. > So we inactivate it on {busy_ioctl, set_domain, sw_finish and mark_busy} > and update to enable it back on next display ma

[Intel-gfx] [PATCH i-g-t 2/3] assembler: fix condition for printing a warning

Signed-off-by: Thomas Wood --- assembler/gram.y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assembler/gram.y b/assembler/gram.y index ad4cb29..f4145bd 100644 --- a/assembler/gram.y +++ b/assembler/gram.y @@ -351,7 +351,7 @@ static bool validate_src_reg(struct brw_program_i

[Intel-gfx] [PATCH i-g-t 3/3] tests/gem_seqno_wrap: fix over allocation of buffers

Signed-off-by: Thomas Wood --- tests/gem_seqno_wrap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/gem_seqno_wrap.c b/tests/gem_seqno_wrap.c index 40c6227..e37365f 100644 --- a/tests/gem_seqno_wrap.c +++ b/tests/gem_seqno_wrap.c @@ -207,13 +207,13 @@ static int

[Intel-gfx] [PATCH i-g-t 0/3] Various small fixes

The following patches fix various issues in intel-gpu-tools that were found by static analysis and compiler warnings. Thomas Wood (3): debugger: fix the -p option assembler: fix condition for printing a warning tests/gem_seqno_wrap: fix over allocation of buffers assembler/gram.y | 2

[Intel-gfx] [PATCH i-g-t 1/3] debugger: fix the -p option

Signed-off-by: Thomas Wood --- debugger/eudb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debugger/eudb.c b/debugger/eudb.c index ff77e42..4cbc2d7 100644 --- a/debugger/eudb.c +++ b/debugger/eudb.c @@ -538,7 +538,7 @@ int main(int argc, char* argv[]) { }

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, 2014-02-07 at 16:49 +0100, Borislav Petkov wrote: > On Fri, Feb 07, 2014 at 05:32:06PM +0200, Imre Deak wrote: > > I just realized it's a different issue, since it's on the init path. > > Also we set the drm device as the parent for the sdvo i2c adapter as > > opposed to the dp i2c adapter

[Intel-gfx] [PATCH] tests/gem_gtt_hog: Fix for BDW

Update XY_COLOR_BLT command for Broadwell. v2: stash devid and remove ugly double allocation. (by Chris). v3: fix inverted blt command size and stash fd, devid and intel_gen. v4: improved len calculation and noop between blt commands. (by Chris). Cc: Chris Wilson ch...@chris-wilson.co.uk> Signed-

Re: [Intel-gfx] [PATCH 0/5] Add power feature debugfs disabling

On Thu, Feb 06, 2014 at 05:37:29PM +0100, Daniel Vetter wrote: > On Thu, Feb 6, 2014 at 4:44 PM, Jeff McGee wrote: > > Our Android system validation tests are expecting these interfaces. That's > > not igt, I know, but is supporting downstream test suites a priority? I can > > get our val guys on

Re: [Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail

On 2/7/2014 9:28 PM, Ville Syrjälä wrote: On Fri, Feb 07, 2014 at 08:43:12PM +0530, Vijay Purushothaman wrote: B-spec says the FIFO total size is 512. So fix this to 512. Signed-off-by: Vijay Purushothaman --- drivers/gpu/drm/i915/i915_reg.h |2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [Intel-gfx] [PATCH] tests/gem_gtt_hog: Fix for BDW

On Fri, Feb 07, 2014 at 02:04:56PM -0200, Rodrigo Vivi wrote: > >> for (i = 0; i < 20; i++) { > >> - *b++ = XY_COLOR_BLT_CMD_NOLEN | 4 | > >> - COLOR_BLT_WRITE_ALPHA | XY_COLOR_BLT_WRITE_RGB; > >> + if (data->intel_gen >= 8) { > >> +

[Intel-gfx] Updated drm-intel-testing

Hi all, New -testing cycle with cool stuff: - Yet more steps towards atomic modeset from Ville. - DP panel power sequencing improvements from Paulo. - irq code cleanups from Ville. - 5.4 GHz dp lane clock support for bdw/hsw from Todd. - Clock readout support for hsw/bdw (aka fastboot) from Jesse.

Re: [Intel-gfx] [PATCH] tests/gem_gtt_hog: Fix for BDW

On Fri, Feb 7, 2014 at 7:51 AM, Chris Wilson wrote: > On Thu, Feb 06, 2014 at 07:46:38PM -0200, Rodrigo Vivi wrote: >> Update XY_COLOR_BLT command for Broadwell. >> >> v2: stash devid and remove ugly double allocation. (by Chris). >> v3: fix inverted blt command size and stash fd, devid and intel_

Re: [Intel-gfx] [PATCH] drm/i915: Pair va_copy with va_end in i915_error_vprintf

On Fri, Feb 07, 2014 at 03:50:51PM +, Chris Wilson wrote: > On Fri, Feb 07, 2014 at 05:40:50PM +0200, Mika Kuoppala wrote: > > Each invocation of va_copy() must be matched by a corresponding > > invocation of va_end() in the same function. > > > > Signed-off-by: Mika Kuoppala > Reviewed-by: C

Re: [Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail

On Fri, Feb 07, 2014 at 08:43:12PM +0530, Vijay Purushothaman wrote: > B-spec says the FIFO total size is 512. So fix this to 512. > > Signed-off-by: Vijay Purushothaman > --- > drivers/gpu/drm/i915/i915_reg.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: Pair va_copy with va_end in i915_error_vprintf

On Fri, Feb 07, 2014 at 05:40:50PM +0200, Mika Kuoppala wrote: > Each invocation of va_copy() must be matched by a corresponding > invocation of va_end() in the same function. > > Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Though it looks like it was my fauly anyway. -Chris -- Chr

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, Feb 07, 2014 at 05:32:06PM +0200, Imre Deak wrote: > I just realized it's a different issue, since it's on the init path. > Also we set the drm device as the parent for the sdvo i2c adapter as > opposed to the dp i2c adapter where it's the connector device. So the > above patch won't help i

[Intel-gfx] [PATCH] drm/i915: Pair va_copy with va_end in i915_error_vprintf

Each invocation of va_copy() must be matched by a corresponding invocation of va_end() in the same function. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gpu_error.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, 2014-02-07 at 15:51 +0100, Daniel Vetter wrote: > On Fri, Feb 07, 2014 at 12:28:09PM +0100, Borislav Petkov wrote: > > On Fri, Feb 07, 2014 at 01:12:22PM +0200, Imre Deak wrote: > > > On Fri, 2014-02-07 at 13:04 +0200, Jani Nikula wrote: > > > > Imre, is this the same i2c_del_adapter issue

[Intel-gfx] [PATCH] drm/i915: Fix correct FIFO size for Baytrail

B-spec says the FIFO total size is 512. So fix this to 512. Signed-off-by: Vijay Purushothaman --- drivers/gpu/drm/i915/i915_reg.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index cc3ea04..fb73031 10064

Re: [Intel-gfx] [PATCH 1/2] tests/pm_rps: Round requested freq correctly

On Fri, Feb 07, 2014 at 04:52:30PM +0200, Ville Syrjälä wrote: > On Fri, Feb 07, 2014 at 08:44:14AM -0600, Jeff McGee wrote: > > On Fri, Feb 07, 2014 at 11:15:15AM +0100, Daniel Vetter wrote: > > > On Fri, Feb 7, 2014 at 10:33 AM, Chris Wilson > > > wrote: > > > > On Fri, Feb 07, 2014 at 10:03:33

Re: [Intel-gfx] [PATCH v4 00/11] Enabling 180 degree rotation for sprite and crtc planes

On Fri, Feb 07, 2014 at 07:15:05PM +0530, sagar.a.kam...@intel.com wrote: > From: Sagar Kamble > > These patches will enable 180 degree rotation for CRTC and Sprite planes. > Changelog: > 1. drm/i915: Add 180 degree primary plane rotation support > Addressed review comments for CRTC rotation from

[Intel-gfx] [PATCH igt 27/28] lib/display: Fix assertion in set_plane()

When cycling throuth planes, we still want to reach the cursor plane. We have to special case IGT_PLANE_CURSOR as a shorthand to select the cursor plane (the last plane on the pipe). Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH 02/13] drm/i915: Implement command buffer parsing logic

On Fri, Feb 07, 2014 at 03:58:46PM +0200, Jani Nikula wrote: > On Wed, 29 Jan 2014, bradley.d.vol...@intel.com wrote: > > +static int valid_reg(const u32 *table, int count, u32 addr) > > +{ > > + if (table && count != 0) { > > + int i; > > + > > + for (i = 0; i < count; i++) {

Re: [Intel-gfx] [PATCH 1/2] tests/pm_rps: Round requested freq correctly

On Fri, Feb 07, 2014 at 08:44:14AM -0600, Jeff McGee wrote: > On Fri, Feb 07, 2014 at 11:15:15AM +0100, Daniel Vetter wrote: > > On Fri, Feb 7, 2014 at 10:33 AM, Chris Wilson > > wrote: > > > On Fri, Feb 07, 2014 at 10:03:33AM +0100, Daniel Vetter wrote: > > >> The kernel will round it, so if we

Re: [Intel-gfx] intel_sdvo_init: trying to register non-static key

On Fri, Feb 07, 2014 at 12:28:09PM +0100, Borislav Petkov wrote: > On Fri, Feb 07, 2014 at 01:12:22PM +0200, Imre Deak wrote: > > On Fri, 2014-02-07 at 13:04 +0200, Jani Nikula wrote: > > > Imre, is this the same i2c_del_adapter issue you're looking at? Any > > > patches to try yet? > > > > It loo

[Intel-gfx] [PATCH igt 22/28] kms_pipe_crc_basic: Use kmstest_create_color_fb()

Reducing again the per-test number of lines. Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f4de64f..8a45c5b 100644 --- a/te

[Intel-gfx] [PATCH igt 25/28] lib/display: Print the fb id, not its pointer in the set_fb() log message

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index fbbf6aa..7d74bf8 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1411,8 +1411,8 @@ void igt_plane_set_fb(igt_plane_t *plane, struct kmste

[Intel-gfx] [PATCH igt 07/28] kms_pipe_crc_basic: Use igt_display_get_n_pipes() instead of hardcoding 3

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index 7d48ca6..f4de64f 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -169,7 +169,7

[Intel-gfx] [PATCH igt 16/28] lib/crc: Add a helper to read a single CRC value

In this case, we also take care of starting/stopping the CRC collection. Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c | 14 ++ lib/igt_debugfs.h | 1 + 2 files changed, 15 insertions(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index a0d84bf..4a4a4dd 100644 --- a/li

[Intel-gfx] [PATCH igt 17/28] tests/kms_cursor_crc: Use igt_pipe_crc_collect_crc()

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 76e2845..a386ad9 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -94,7 +94,7 @

[Intel-gfx] [PATCH igt 09/28] lib/display: Fix the SetCrtc disabling log message

We were displaying the value of fb_id (0), when the actual interesting thing about this call it that it'll just down the pipe. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 38ee82b..64f

[Intel-gfx] [PATCH igt 19/28] lib: Introduce a new helper kmstest_create_color_fb()

We need to create fbs of a single color in a few places. Time to abstract that out to a helper function. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 19 +++ lib/igt_kms.h | 4 2 files changed, 23 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 23a7318.

[Intel-gfx] [PATCH igt 11/28] lib/display: Add a way to specify we don't care about the pipe to use

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 12 lib/igt_kms.h | 6 ++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 3b75478..e2413e5 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1226,10 +1226,14 @@ void igt_output

[Intel-gfx] [PATCH igt 26/28] lib/display: Wait for a vblank after SetPlane()

Let's be testing friendly and gently wait for the next vblank before returning from commit() when needed. After igt_display_commit() one can safely look at the CRC. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 8 lib/igt_kms.h | 5 +++-- 2 files changed, 11 insertions(+), 2 deleti

[Intel-gfx] [PATCH igt 23/28] lib: Add a helper to wait for a keypress

Signed-off-by: Damien Lespiau --- lib/drmtest.c | 13 + lib/drmtest.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index f7262d7..f0635d3 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -46,6 +46,7 @@ #include #include #include +#inclu

[Intel-gfx] [PATCH igt 10/28] lib/display: Add support for the cursor plane

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 148 ++ lib/igt_kms.h | 13 +- 2 files changed, 150 insertions(+), 11 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 64fb39a..3b75478 100644 --- a/lib/igt_kms.c +++ b/lib

[Intel-gfx] [PATCH igt 12/28] kms_cursor_crc: Port the test to the new modeset API

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 201 ++--- 1 file changed, 106 insertions(+), 95 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 9ddee06..76e2845 100644 --- a/tests/kms_cursor_crc.c +++ b/tests

[Intel-gfx] [PATCH igt 05/28] kms_pipe_crc_basic: Use for_each_connected_output()

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index fdec077..7d48ca6 100644 --- a/tests/kms_pipe_crc_basic.c +++ b/tests/kms_pipe_crc_basic.c @@ -81,

[Intel-gfx] [PATCH igt 15/28] lib/crc: Factor out reading a single CRC value

Signed-off-by: Damien Lespiau --- lib/igt_debugfs.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 4b96521..a0d84bf 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -301,6 +301,21 @@ static bool pip

[Intel-gfx] [PATCH igt 24/28] lib/display: Add a way to wait at every commit for inspection

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 74e52b6..fbbf6aa 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1368,6 +1368,9 @@ int igt_display_commit(igt_display_t *display) LOG_UNINDENT(di

[Intel-gfx] [PATCH igt 20/28] kms_cursor_crc: Use kmstest_create_color_fb()

Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index a386ad9..6cdb785 100644 --- a/tests/kms_cursor_crc.c +++ b/tests/kms_cursor_crc.c @@ -61,25

[Intel-gfx] [PATCH igt 03/28] lib: Introduce symbolic names for display planes

It'd be nice to have symbolic names for planes instead of using an index in igt_output_get_plane(). We also namespace the enum to not conflict with anyone. Signed-off-by: Damien Lespiau --- lib/igt_display.h | 18 +- lib/igt_kms.c | 18 -- lib/igt_kms.h |

[Intel-gfx] [PATCH igt 06/28] lib/display: Add an accessor to retrieve the number of pipes

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 5 + lib/igt_kms.h | 1 + 2 files changed, 6 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e3e902a..38ee82b 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -934,6 +934,11 @@ void igt_display_set_verbose(igt_display_t *displ

[Intel-gfx] [PATCH igt 08/28] tests/kms_cursor_crc: Move the array of cursor fb_ids to the stack

This array is not used outside ouf create_cursor_fb(). A stack allocated array is enough. Signed-off-by: Damien Lespiau --- tests/kms_cursor_crc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index 38aa1ab..9ddee06

[Intel-gfx] [PATCH igt 18/28] lib/display: Add support for DRM planes

We can now extend our plane support beyond primary and cursor planes. Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 116 +- lib/igt_kms.h | 6 +++ 2 files changed, 120 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/ig

[Intel-gfx] [PATCH igt 14/28] lib/display: Check if we're trying to use the same pipe on 2 outputs

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index c503ebb..1933fa6 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -977,10 +977,34 @@ void igt_display_fini(igt_displa

[Intel-gfx] [PATCH igt 28/28] kms_plane: Start a basic display plane test

We test the sprite plane positionning in there, for now. Signed-off-by: Damien Lespiau --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_plane.c | 247 + 3 files changed, 249 insertions(+) create mode 100644 tests/

[Intel-gfx] [PATCH igt 02/28] kms_pipe_crc_basic: Port to the new modeset API

Signed-off-by: Damien Lespiau --- tests/kms_pipe_crc_basic.c | 126 +++-- 1 file changed, 29 insertions(+), 97 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c index f4a97eb..fdec077 100644 --- a/tests/kms_pipe_crc_basic.c

[Intel-gfx] [PATCH igt 13/28] lib/display: Allow to override the display verbosity with an env variale

Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e2413e5..c503ebb 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -863,6 +863,7 @@ void igt_display_init(igt_display_t *display, int drm_fd) { dr

[Intel-gfx] [PATCH igt 01/28] lib: Introduce a modeset API

The goals here are: - Reduce duplicated code in each KMS test - Provide an API that looks more like what we want for atomic modesets. The hope is then that it'll be easy to switch, at run-time, between the "legacy" path and atomic modesets, keeping the same API for tests. Signed-of

[Intel-gfx] Modeset API for KMS tests

The goal of that series is to introduce a small mode setting API to write our KMS tests, port kms_pipe_crc_basic and kms_cursor_crc to it and introduce a new kms_plane test. To be more precise, the goals are: - Fewer lines per test, - Be able to switch between a "legacy" backend and an "atomic

[Intel-gfx] [PATCH igt 04/28] lib: Introduce a for_each_connected_output() macro

So we can easily cycle through them in tests without knowing too many internal details about how igt_display_t organize its data. Signed-off-by: Damien Lespiau --- lib/igt_kms.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 80cdfb6..1d06767 100644 --

[Intel-gfx] [PATCH igt 21/28] lib: Include drm_fourcc.h from igt_kms.h

This include is needed for the DRM_FORMAT* defines used in the fb creation helpers. Signed-off-by: Damien Lespiau --- lib/igt_kms.h | 1 + tests/kms_cursor_crc.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 8110dad..96dd9e4 10

Re: [Intel-gfx] [PATCH 2/2] drm/i915/vlv: Replaced Blitter ring based flips with MMIO Flips for VLV.

On Fri, Feb 07, 2014 at 11:59:29AM +, Goel, Akash wrote: > Please could you kindly elaborate here, it will help us to proceed further > with this patch. As Chris said, instead of rolling your own code to track when flips are emitted to the ring, simply add a real request (with the add_request

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

On Fri, Feb 07, 2014 at 05:52:12PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Modified programming of following 2 regs in Render ring initialisation fn. > 1. GFX_MODE_GEN7 (Enabling TLB invalidate) > 2. MI_MODE (Enabling MI Flush) > > v2: Removed the enabling of MI_FLUSH (Ville) >

Re: [Intel-gfx] [PATCH] Fix LIBDRM_PATH for top android build

Sorry for late reply, I still have trouble keeping track my patches with this email-patching-way-of-doing-things. Yes, that is correct, the tools should also benefit from the same fix. Joao -Original Message- From: Lespiau, Damien Sent: Friday, January 31, 2014 10:20 AM To: Barbalho

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation

> 1. GFX_MODE_GEN7 (Enabling TLB invalidate) >> The changelog needs to explain why. According to the spec this is a >> pessimisation. Ok, Will look into this. > 2. MI_MODE (Enabling MI Flush) >> And this is out-of-date. Doesn't describe the actual change nor why. Sorry I did not update the comm

  1   2   >