Re: [Intel-gfx] [PATCH v3] drm/i915/opregion: ignore firmware requests for backlight change

2014-07-08 Thread Aaron Lu
On 07/08/2014 08:48 PM, Rafael J. Wysocki wrote: > On Tuesday, July 08, 2014 04:09:25 PM Aaron Lu wrote: >> Some Thinkpad laptops' firmware will initiate a backlight level change >> request through operation region on the events of AC plug/unplug, but >> since we are not using firmware's interface

[Intel-gfx] [PATCH v2 2/5] drm/i915: Use batch pools with the command parser

2014-07-08 Thread bradley . d . volkin
From: Brad Volkin This patch sets up all of the tracking and copying necessary to use batch pools with the command parser, but does not actually dispatch the copied (shadow) batch to the hardware yet. We still aren't quite ready to set the secure bit during dispatch. Note that performance takes

[Intel-gfx] [PATCH v2 5/5] drm/i915: Use batch length instead of object size in command parser

2014-07-08 Thread bradley . d . volkin
From: Brad Volkin Previously we couldn't trust the user-supplied batch length because it came directly from userspace (i.e. untrusted code). It would have affected what commands software parsed without regard to what hardware would actually execute, leaving a potential hole. With the parser now

[Intel-gfx] [PATCH v2 3/5] drm/i915: Add a batch pool debugfs file

2014-07-08 Thread bradley . d . volkin
From: Brad Volkin It provides some useful information about the buffers in the global command parser batch pool. v2: rebase on global pool instead of per-ring pools Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_debugfs.c | 41 + 1 file changed, 4

[Intel-gfx] [PATCH v2 1/5] drm/i915: Implement a framework for batch buffer pools

2014-07-08 Thread bradley . d . volkin
From: Brad Volkin This adds a small module for managing a pool of batch buffers. The only current use case is for the command parser, as described in the kerneldoc in the patch. The code is simple, but separating it out makes it easier to change the underlying algorithms and to extend to future u

[Intel-gfx] [PATCH v2 0/5] Command parser batch buffer copy

2014-07-08 Thread bradley . d . volkin
From: Brad Volkin This is v2 of the series I sent here: http://lists.freedesktop.org/archives/intel-gfx/2014-June/047609.html I believe that I've addressed all of the feedback except * I didn't move the allocation of the shadow batch buffer into parse_cmds(). It didn't seem like it added much

[Intel-gfx] [PATCH v2 4/5] drm/i915: Dispatch the shadow batch buffer

2014-07-08 Thread bradley . d . volkin
From: Brad Volkin This is useful for testing the batch pool code with aliasing PPGTT. It doesn't work with full PPGTT though; the GPU hangs and the whole UI is corrupted. We need fixes for the secure dispatch path to enable this for real. v2: rebase on shadow_batch_obj replacing batch_obj Signe

Re: [Intel-gfx] [PATCH 00/10] drm-intel-collector - update

2014-07-08 Thread Daniel Vetter
On Thu, Jul 03, 2014 at 05:32:56PM -0400, Rodrigo Vivi wrote: > > This is another drm-intel-collector updated notice: > http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector > > It was 4 rounds out of date what made it hard to get old patches. However > Daniel and Jani didn't

Re: [Intel-gfx] [PATCH 07/10] drm/i915: HWS must be in the mappable region for g33

2014-07-08 Thread Daniel Vetter
On Thu, Jul 03, 2014 at 05:33:03PM -0400, Rodrigo Vivi wrote: > From: Chris Wilson > > On g33, the documentation states > > "HWS_PGA: > Format = Bits 28:12 of graphics memory address (bits 31:29 MBZ)." > > which translates to that the address of the HWS must be below 256MiB, > which is conveni

Re: [Intel-gfx] [PATCH 05/10] drm/i915/vlv: WA for Turbo and RC6 to work together.

2014-07-08 Thread Daniel Vetter
On Thu, Jul 03, 2014 at 05:33:01PM -0400, Rodrigo Vivi wrote: > From: Deepak S > > With RC6 enabled, BYT has an HW issue in determining the right > Gfx busyness. > WA for Turbo + RC6: Use SW based Gfx busy-ness detection to decide > on increasing/decreasing the freq. This logic will monitor C0 >

Re: [Intel-gfx] 3.16.0-rcx regression 945GM lower color depth

2014-07-08 Thread Hans de Bruin
On 07/08/2014 09:39 AM, Chris Wilson wrote: On Mon, Jul 07, 2014 at 09:46:14PM +0200, Hans de Bruin wrote: Hi, Since the 3.16.0-rc my laptop displays a lower color depth. Gradient surfaces show a staircase effect where before the gradient was smooth. Daniel turned off dithering... Witch exp

Re: [Intel-gfx] [PATCH 1/5] drm/i915: don't write powered down IRQ registers on Gen 8

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 11:15:03AM -0300, Paulo Zanoni wrote: > 2014-07-07 18:23 GMT-03:00 Daniel Vetter : > > On Fri, Jul 04, 2014 at 11:50:29AM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> If we enable unclaimed register reporting on Gen 8, we will discover > >> that the IRQ regi

Re: [Intel-gfx] [PATCH] drm/i915/vlv: T12 eDP panel timing enforcement during reboot

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 11:06:00AM -0300, Paulo Zanoni wrote: > 2014-07-07 17:01 GMT-03:00 : > > From: Clint Taylor > > > > The panel power sequencer on vlv doesn't appear to accept changes to its > > T12 power down duration during warm reboots. This change forces a delay > > for warm reboots to

[Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj() (v2)

2014-07-08 Thread Matt Roper
This should hopefully simplify the display code slightly and also solves at least one mistake in intel_pipe_set_base() where to_intel_framebuffer(fb)->obj is referenced during local variable initialization, before 'if (!fb)' gets checked. Potential uses of this macro were identified via the follow

Re: [Intel-gfx] [PATCH] drm/i915: Only unbind vgacon, not other console drivers

2014-07-08 Thread Daniel Vetter
On Tue, Jul 8, 2014 at 3:17 PM, David Herrmann wrote: > > On Tue, Jul 8, 2014 at 10:08 AM, Daniel Vetter wrote: >> The console subsystem only provides a function to switch to a given >> console, but we want to actually only switach away from vgacon. >> Unconditionally switching to the dummy conso

Re: [Intel-gfx] [PATCH 1/5] drm/i915: don't write powered down IRQ registers on Gen 8

2014-07-08 Thread Paulo Zanoni
2014-07-07 18:23 GMT-03:00 Daniel Vetter : > On Fri, Jul 04, 2014 at 11:50:29AM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> If we enable unclaimed register reporting on Gen 8, we will discover >> that the IRQ registers for pipes B and C are also on the power well, >> so writes to them w

Re: [Intel-gfx] [PATCH] drm/i915/vlv: T12 eDP panel timing enforcement during reboot

2014-07-08 Thread Paulo Zanoni
2014-07-07 17:01 GMT-03:00 : > From: Clint Taylor > > The panel power sequencer on vlv doesn't appear to accept changes to its > T12 power down duration during warm reboots. This change forces a delay > for warm reboots to the T12 panel timing as defined in the VBT table for > the connected panel

Re: [Intel-gfx] [PATCH] drm/i915: Only unbind vgacon, not other console drivers

2014-07-08 Thread David Herrmann
Hi On Tue, Jul 8, 2014 at 10:08 AM, Daniel Vetter wrote: > The console subsystem only provides a function to switch to a given > console, but we want to actually only switach away from vgacon. > Unconditionally switching to the dummy console resulted in switching > away from fbcon in multi-gpu se

Re: [Intel-gfx] Linux 3.16-rc2

2014-07-08 Thread Jiri Kosina
On Tue, 8 Jul 2014, Chris Wilson wrote: > > Tried on top of current Linus' tree, and no improvement. ring > > initialization failure upon resume, and window redrawing hosed. > > Which error during ring-init are you hitting? It's still the same I reported in bugs.freedesktop.org/show_bug.cgi?id

Re: [Intel-gfx] Linux 3.16-rc2

2014-07-08 Thread Chris Wilson
On Tue, Jul 08, 2014 at 02:46:57PM +0200, Jiri Kosina wrote: > On Tue, 8 Jul 2014, Chris Wilson wrote: > > > > I actually tried to introduce rather large delays between individual > > > I915_WRITE() calls in the ring initialization sequence a couple weeks ago > > > already, but it resulted in co

Re: [Intel-gfx] Linux 3.16-rc2

2014-07-08 Thread Jiri Kosina
On Tue, 8 Jul 2014, Chris Wilson wrote: > > I actually tried to introduce rather large delays between individual > > I915_WRITE() calls in the ring initialization sequence a couple weeks ago > > already, but it resulted in complete machine lockup (which is worse than > > my usual symptoms) duri

Re: [Intel-gfx] [PATCH v3] drm/i915/opregion: ignore firmware requests for backlight change

2014-07-08 Thread Rafael J. Wysocki
On Tuesday, July 08, 2014 04:09:25 PM Aaron Lu wrote: > Some Thinkpad laptops' firmware will initiate a backlight level change > request through operation region on the events of AC plug/unplug, but > since we are not using firmware's interface to do the backlight setting > on these affected laptop

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use mmio flips to change tiling mode on Baytrail

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 10:40:30AM +0100, Chris Wilson wrote: > For whatever reason, MI_DISPLAY_FLIP fails to change tiling mode on > Baytrail, so just use CPU driven mmio flips instead. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76176 > Signed-off-by: Chris Wilson Both merged to

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 11:06:49AM +0100, Chris Wilson wrote: > On Tue, Jul 08, 2014 at 11:51:18AM +0200, Daniel Vetter wrote: > > On Tue, Jul 08, 2014 at 07:47:13AM +0100, Chris Wilson wrote: > > > On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > > > > This should hopefully simplify t

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Extract context backing object allocation

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 10:39:26AM +0100, Chris Wilson wrote: > On Thu, Jul 03, 2014 at 04:27:58PM +0100, oscar.ma...@intel.com wrote: > > From: Oscar Mateo > > > > This is preparatory work for Execlists: we plan to use it later to > > allocate our own context objects (since Logical Ring Contexts

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add kerneldoc comments to the intel_context struct

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 11:29:17AM +0200, Daniel Vetter wrote: > On Thu, Jul 03, 2014 at 03:38:34PM +, Mateo Lozano, Oscar wrote: > > > -Original Message- > > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > > Of oscar.ma...@intel.com > > > Sent: Thursday

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-08 Thread Chris Wilson
On Tue, Jul 08, 2014 at 11:51:18AM +0200, Daniel Vetter wrote: > On Tue, Jul 08, 2014 at 07:47:13AM +0100, Chris Wilson wrote: > > On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > > > This should hopefully simplify the display code slightly and also > > > solves at least one mistake in

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make use of intel_fb_obj()

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 07:47:13AM +0100, Chris Wilson wrote: > On Mon, Jul 07, 2014 at 06:21:48PM -0700, Matt Roper wrote: > > This should hopefully simplify the display code slightly and also > > solves at least one mistake in intel_pipe_set_base() where > > to_intel_framebuffer(fb)->obj is refer

[Intel-gfx] [PATCH 2/2] drm/i915: Use mmio flips to change tiling mode on Baytrail

2014-07-08 Thread Chris Wilson
For whatever reason, MI_DISPLAY_FLIP fails to change tiling mode on Baytrail, so just use CPU driven mmio flips instead. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76176 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 6 ++ 1 file changed, 6 insertions(+)

[Intel-gfx] [PATCH 1/2] drm/i915: Disable RCS flips on Ivybridge

2014-07-08 Thread Chris Wilson
We currently see random GPU hangs when using RCS flips with multiple pipes on Ivybridge. Now that we have mmio flips, we can fairly cheaply fallback to using CPU driven flips instead. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) di

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Extract context backing object allocation

2014-07-08 Thread Chris Wilson
On Thu, Jul 03, 2014 at 04:27:58PM +0100, oscar.ma...@intel.com wrote: > From: Oscar Mateo > > This is preparatory work for Execlists: we plan to use it later to > allocate our own context objects (since Logical Ring Contexts do > not have the same kind of backing objects). > > No functional cha

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add kerneldoc comments to the intel_context struct

2014-07-08 Thread Daniel Vetter
On Thu, Jul 03, 2014 at 03:38:34PM +, Mateo Lozano, Oscar wrote: > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of oscar.ma...@intel.com > > Sent: Thursday, July 03, 2014 4:28 PM > > To: intel-gfx@lists.freedesktop.org > > Subje

Re: [Intel-gfx] [PATCH] intel-gpu-tools: Dont build kms_univeral_plane if no cairo

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 10:04:28AM +0100, tim.g...@intel.com wrote: > From: Tim Gore > > kms_univeral_plane is a new test that requires cairo. > I have added it to the list of tests not to build on > Android unless ANDROID_HAS_CAIRO is set. > > Signed-off-by: Tim Gore Merged, thanks. -Daniel

[Intel-gfx] [PATCH] intel-gpu-tools: Dont build kms_univeral_plane if no cairo

2014-07-08 Thread tim . gore
From: Tim Gore kms_univeral_plane is a new test that requires cairo. I have added it to the list of tests not to build on Android unless ANDROID_HAS_CAIRO is set. Signed-off-by: Tim Gore --- tests/Android.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Android.mk

Re: [Intel-gfx] Linux 3.16-rc2

2014-07-08 Thread Chris Wilson
On Tue, Jul 08, 2014 at 12:15:31AM +0200, Jiri Kosina wrote: > On Mon, 7 Jul 2014, Chris Wilson wrote: > > > > > this patch on top of v3.16-rc3-62-gd92a333 makes the resume from ram > > > > regression go away on my machine: > > > > > > Hm, we could conditionalize this hack on IS_G4X ... Chris, th

Re: [Intel-gfx] Linux 3.16-rc2

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 12:15:31AM +0200, Jiri Kosina wrote: > On Mon, 7 Jul 2014, Chris Wilson wrote: > > > > > this patch on top of v3.16-rc3-62-gd92a333 makes the resume from ram > > > > regression go away on my machine: > > > > > > Hm, we could conditionalize this hack on IS_G4X ... Chris, th

Re: [Intel-gfx] [PATCH] drm/i915: make system freeze support depend on CONFIG_ACPI_SLEEP

2014-07-08 Thread Daniel Vetter
On Tue, Jul 08, 2014 at 01:39:23AM +0200, Rafael J. Wysocki wrote: > On 7/8/2014 1:13 AM, Rafael J. Wysocki wrote: > >On 6/24/2014 5:12 PM, Imre Deak wrote: > >>On Tue, 2014-06-24 at 17:53 +0300, Jani Nikula wrote: > >>>On Tue, 24 Jun 2014, Imre Deak wrote: > On Tue, 2014-06-24 at 16:54 +0300,

Re: [Intel-gfx] [PATCH] drm/i915: Restrict GPU boost to the RCS engine

2014-07-08 Thread Daniel Vetter
On Wed, Jul 09, 2014 at 10:09:00AM +0530, Deepak S wrote: > > On Monday 07 July 2014 02:35 PM, Daniel Vetter wrote: > >On Tue, Jun 24, 2014 at 05:22:17PM +0530, Deepak S wrote: > >>Hi Chris/Daniel, > >> > >>The patch is helping in some of the side-effects due to gpu boost. I > >>still need to get

Re: [Intel-gfx] [PATCH] drm/i915: Only unbind vgacon, not other console drivers

2014-07-08 Thread Chris Wilson
On Tue, Jul 08, 2014 at 10:08:37AM +0200, Daniel Vetter wrote: > The console subsystem only provides a function to switch to a given > console, but we want to actually only switach away from vgacon. > Unconditionally switching to the dummy console resulted in switching > away from fbcon in multi-gp

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Kick out vga console

2014-07-08 Thread Daniel Vetter
On Mon, Jul 07, 2014 at 10:53:16PM -0400, Ed Tomlinson wrote: > Hi Daniel, > > The patch below also works. You can use my Tested By for it. Thanks a lot for testing, patch submitted and should get forwarded asap. > > Thanks > Ed Tomlinson > > PS. I _really_ need to get a serial console workin

[Intel-gfx] [PATCH v3] drm/i915/opregion: ignore firmware requests for backlight change

2014-07-08 Thread Aaron Lu
Some Thinkpad laptops' firmware will initiate a backlight level change request through operation region on the events of AC plug/unplug, but since we are not using firmware's interface to do the backlight setting on these affected laptops, we do not want the firmware to use some arbitrary value fro

[Intel-gfx] [PATCH] drm/i915: Only unbind vgacon, not other console drivers

2014-07-08 Thread Daniel Vetter
The console subsystem only provides a function to switch to a given console, but we want to actually only switach away from vgacon. Unconditionally switching to the dummy console resulted in switching away from fbcon in multi-gpu setups when other gpu drivers are loaded before i915. Then either th

Re: [Intel-gfx] [RFC 03/44] drm/i915: Add extra add_request calls

2014-07-08 Thread Chris Wilson
On Mon, Jul 07, 2014 at 08:41:47PM +0200, Daniel Vetter wrote: > On Mon, Jun 30, 2014 at 02:10:16PM -0700, Jesse Barnes wrote: > > On Thu, 26 Jun 2014 18:23:54 +0100 > > john.c.harri...@intel.com wrote: > > I think "no_flush" would be more in line with some of the other > > functions in the kernel.

Re: [Intel-gfx] 3.16.0-rcx regression 945GM lower color depth

2014-07-08 Thread Chris Wilson
On Mon, Jul 07, 2014 at 09:46:14PM +0200, Hans de Bruin wrote: > Hi, > > Since the 3.16.0-rc my laptop displays a lower color depth. Gradient > surfaces show a staircase effect where before the gradient was > smooth. Daniel turned off dithering... -Chris -- Chris Wilson, Intel Open Source Techn