Re: [Intel-gfx] [PATCH] drm/i915: Don't use WaGsvRC0ResidenncyMethod on chv

On Friday 29 August 2014 04:44 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com WaGsvRC0ResidenncyMethod is for vlv, it doesn't deal with chv appropriately (eg. doesn't limit rps values to even numbers). Fix a typo in the w/a name while at it. Cc:

Re: [Intel-gfx] [PATCH] igt/gem_workarounds: igt to test workaround registers

On Tue, Aug 26, 2014 at 02:50:28PM +0100, Arun Siluvery wrote: + igt_subtest(check-workaround-data-after-suspend-resume) { + if (IS_BROADWELL(devid)) + check_workarounds(SUSPEND_RESUME, num_wa_regs); + else + igt_skip_on(No

Re: [Intel-gfx] [PATCH] igt/gem_workarounds: igt to test workaround registers

On Tue, Aug 26, 2014 at 02:50:28PM +0100, Arun Siluvery wrote: + igt_fixture { [...] + + fd = igt_debugfs_open(intel_wa_registers, O_RDONLY); + igt_assert(fd = 0); This will make the test fail on kernels that don't have your kernel work exposing that debugfs

[Intel-gfx] [PATCH 3/5] drm/i915: Don't silently discard workarounds

If we happen to emit more than I915_MAX_WA_REGS workarounds, we will currently discard them, not even emit the LRI. Not really what we want, so warn loudly. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+),

[Intel-gfx] [PATCH 1/5] drm/i915: Rename intel_wa_registers with a i915_ prefix

Those debugfs files are prefixed by i915, the name of the kernel module, presumably to make the difference with files exposed by core DRM. Also, add a ',' at the end of the last entry. This is to ease the conflict resolution when rebasing internal patches that add a member at the end of the

[Intel-gfx] [PATCH 4/5] drm/i915: Remove unneeded brackets

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index 5ef0f99..f8aadc3 100644 ---

[Intel-gfx] [PATCH 0/5] A few fixes on top of the wa_regs patches

Hi Arun, I've compiled a few patches that I think solve some small-ish issues around your wa_regs series. Could you please have a look at them and comment/give your r-b tag if you judge appropriate? On top of those patches, I'd love some comments on the issues I raised in the other mail and

[Intel-gfx] [PATCH 2/5] drm/i915: Don't overrun the intel_wa_regs array

When entering intel_ring_emit_wa() with num_wa_regs equal to I915_MAX_WA_REGS, we end up indexing the intel_wa_regs array beyond its allocation. Fix the check then. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH igt] gem_workarounds: intel_wa_registers is now prefixed with i915

Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- tests/gem_workarounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_workarounds.c b/tests/gem_workarounds.c index 6826562..32156d2 100644 --- a/tests/gem_workarounds.c +++ b/tests/gem_workarounds.c @@