Re: [Intel-gfx] [PATCH 1/2] drm/i915: clear up wedged transitions

2014-09-03 Thread Chris Wilson
On Thu, Sep 04, 2014 at 08:03:26AM +0200, Daniel Vetter wrote: > On Wed, Sep 3, 2014 at 10:26 PM, Chris Wilson > wrote: > >> @@ -1385,7 +1372,7 @@ out: > >> /* If this -EIO is due to a gpu hang, give the reset code a > >>* chance to clean up the mess. Otherwise retur

Re: [Intel-gfx] [PATCH 1/2] drm/i915: clear up wedged transitions

2014-09-03 Thread Daniel Vetter
On Wed, Sep 3, 2014 at 10:26 PM, Chris Wilson wrote: >> @@ -1385,7 +1372,7 @@ out: >> /* If this -EIO is due to a gpu hang, give the reset code a >>* chance to clean up the mess. Otherwise return the proper >>* SIGBUS. */ >> - if (!atomic_r

[Intel-gfx] [PATCH 3/4] drm/i915: Move PSR w/as to enable source.

2014-09-03 Thread Rodrigo Vivi
Lets reorganize stuff and make sure these W/As are always set. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9414e67..a04b69f 1

[Intel-gfx] [PATCH 1/4] drm/i915: Increase PSR Idle Frame to 2.

2014-09-03 Thread Rodrigo Vivi
With Software tracking we are going to PSR sooner than we should and staying with blank screens in many cases. Using 2 identical frames to detect idleness is safier. Discovered and validated with refactored igt/kms_sink_psr_crc. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c |

[Intel-gfx] [PATCH 2/4] drm/i915: Remove PSR HW tracking.

2014-09-03 Thread Rodrigo Vivi
Now that we are tracking psr states on Software side we don't need HW help anymore. So we can clean up the code a bit and avoid unecessary sets. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 4/4] drm/i915: Rename psr setup vsc function and set it always.

2014-09-03 Thread Rodrigo Vivi
Let's always set VSC header. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index a04b69f..de24e46 100644 --- a/drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH 10/12] tests/kms_psr_sink_crc: Check color ref CRC

2014-09-03 Thread Rodrigo Vivi
Black screen is forbidden on this test. So let's fail if sink crc shows it is back. Also there are many cases where we know for shure it should be all green, so let's check for them. Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 19 +++ 1 file changed, 19 insertions

[Intel-gfx] [PATCH 08/12] tests/kms_psr_sink_crc: Start splitting tests in test_planes and operations.

2014-09-03 Thread Rodrigo Vivi
This will allow us to test input/write oprations on any kind of plane. At this point PLANE_ONOF is just the new name of TEST_SPRITE and PLANE_MOVE is the one for TEST_CURSOR_MOVE. They will be extended and fixed on the following patche(s). Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.

[Intel-gfx] [PATCH 04/12] tests/kms_psr_sink_crc: Fix edp_psr debugfs interface

2014-09-03 Thread Rodrigo Vivi
Tests were broken on platforms that doesn't have psr or on new kernel that contains new interface. A lot more need to be done to get these tests really useful, but for now lets avoid it breaking tests framework. v2: Doesn't duplicate kernel's HAS_PSR. skip based on debugfs output. Signed-off-by

[Intel-gfx] [PATCH 06/12] tests/kms_psr_sink_crc: Removing context tests.

2014-09-03 Thread Rodrigo Vivi
This tests are unecessary. Mainly now with the software tracking for PSR. Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 69 +++- 1 file changed, 3 insertions(+), 66 deletions(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_c

[Intel-gfx] [PATCH 07/12] tests/kms_psr_sink_crc: Cleaning up tests a bit

2014-09-03 Thread Rodrigo Vivi
This is needed to be able to split tests in a matrix that tests different input/write methods and operations for different type of planes. Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 67 1 file changed, 67 deletions(-) diff --git a

[Intel-gfx] [PATCH 12/12] tests/kms_psr_sink_crc: Wait 2 vblanks before grabing the new crc.

2014-09-03 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index c265f3a..59c99ec 100644 --- a/tests/kms_psr_sink_crc.c +++ b/tests/kms_psr_sink_crc.c @@ -246,6 +246,9 @@ stat

[Intel-gfx] [PATCH 01/12] tests/pm_psr: Update pm_psr for new psr debug interface.

2014-09-03 Thread Rodrigo Vivi
v2: Doesn't duplicate kernel's HAS_PSR. skip based on debugfs output. Signed-off-by: Rodrigo Vivi --- tests/pm_psr.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/tests/pm_psr.c b/tests/pm_psr.c index 3ab7e7a..16ec3fa 100644 --- a/tests/pm_ps

[Intel-gfx] [PATCH 03/12] tests/kms_sink_crc_basic: Simplify test by using igt_kms functions

2014-09-03 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi --- tests/kms_sink_crc_basic.c | 150 +++-- 1 file changed, 48 insertions(+), 102 deletions(-) diff --git a/tests/kms_sink_crc_basic.c b/tests/kms_sink_crc_basic.c index 3703dc1..e24220e 100644 --- a/tests/kms_sink_crc_basic.c +

[Intel-gfx] [PATCH 09/12] tests/kms_psr_sink_crc: Fix all testcases.

2014-09-03 Thread Rodrigo Vivi
In order to get all test cases fixed and the matrix planes-operations working it was needed to use the common new igt kms functions for all cases. Previously only sprite testcase was using it. Fixed the fb colors in a way to make tests more clear and be impossible to see black screen during the te

[Intel-gfx] [PATCH 02/12] tests/kms_sink_crc_basic: Use igt_debugfs_fopen

2014-09-03 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi --- tests/kms_sink_crc_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_sink_crc_basic.c b/tests/kms_sink_crc_basic.c index 443f82e..3703dc1 100644 --- a/tests/kms_sink_crc_basic.c +++ b/tests/kms_sink_crc_basic.c @@ -52,7 +52,7 @@

[Intel-gfx] [PATCH 11/12] tests/kms_psr_sink_crc: Fix blt submission

2014-09-03 Thread Rodrigo Vivi
Putting back a missing dword. Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 45d2dd9..c265f3a 100644 --- a/tests/kms_psr_sink_crc.c +++ b/tests/kms_psr_sink_crc.c @@ -125,6 +12

[Intel-gfx] [PATCH 05/12] tests/kms_psr_sink_crc: Adding test debug options

2014-09-03 Thread Rodrigo Vivi
Just to make life easier and be eable to easily test with PSR disabled to know exactly what to expect when running it for real Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/tests/kms_psr_sink_cr

Re: [Intel-gfx] [PATCH 1/2] drm/i915: clear up wedged transitions

2014-09-03 Thread Chris Wilson
On Thu, Nov 15, 2012 at 05:17:22PM +0100, Daniel Vetter wrote: > We have two important transitions of the wedged state in the current > code: > > - 0 -> 1: This means a hang has been detected, and signals to everyone > that they please get of any locks, so that the reset work item can > do its

[Intel-gfx] [PATCH -v3 2/4] drm/i915: split intel_update_plane into check() and commit()

2014-09-03 Thread Gustavo Padovan
From: Gustavo Padovan Due to the upcoming atomic modesetting feature we need to separate some update functions into a check step that can fail and a commit step that should, ideally, never fail. This commit splits intel_update_plane() and its commit part can still fail due to the fb pinning proc

[Intel-gfx] [PATCH -v3 1/4] drm/i915: create struct intel_plane_state

2014-09-03 Thread Gustavo Padovan
From: Gustavo Padovan This new struct will be the storage of src and dst coordinates between the check and commit stages of a plane update. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_drv.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH -v3 4/4] drm/i915: split intel_primary_plane_setplane() into check() and commit()

2014-09-03 Thread Gustavo Padovan
From: Gustavo Padovan As a preparation for atomic updates we need to split the code to check everything we are going to commit first. This patch starts the work to split intel_primary_plane_setplane() into check() and commit() parts. More work is expected on this to get a better split of the two

[Intel-gfx] [PATCH -v3 0/4] split plane's updates functions into check() and commit()

2014-09-03 Thread Gustavo Padovan
From: Gustavo Padovan This is the beginning of the work to prepare i915 for the upcoming atomic modesetting API. Here we split the plane update fucntions in the check and commit states. v2: use struct intel_plane_state to keep states between check and commit stages. v3: take Ville's comments

[Intel-gfx] [PATCH -v3 3/4] drm/i915: split intel_cursor_plane_update() into check() and commit()

2014-09-03 Thread Gustavo Padovan
From: Gustavo Padovan Due to the upcoming atomic modesetting feature we need to separate some update functions into a check step that can fail and a commit step that should, ideally, never fail. The commit part can still fail, but that should be solved in another upcoming patch. Signed-off-by:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: allow sync points within batches

2014-09-03 Thread Jesse Barnes
On Wed, 3 Sep 2014 21:41:02 +0200 Daniel Vetter wrote: > On Wed, Sep 3, 2014 at 9:01 PM, Jesse Barnes wrote: > > On Wed, 3 Sep 2014 17:08:53 +0100 > > Chris Wilson wrote: > >> On Wed, Sep 03, 2014 at 08:41:06AM -0700, Jesse Barnes wrote: > >> > On Wed, 3 Sep 2014 08:01:55 +0100 > >> > Chris Wil

Re: [Intel-gfx] [PATCH 2/2] drm/i915: allow sync points within batches

2014-09-03 Thread Daniel Vetter
On Wed, Sep 3, 2014 at 9:01 PM, Jesse Barnes wrote: > On Wed, 3 Sep 2014 17:08:53 +0100 > Chris Wilson wrote: >> On Wed, Sep 03, 2014 at 08:41:06AM -0700, Jesse Barnes wrote: >> > On Wed, 3 Sep 2014 08:01:55 +0100 >> > Chris Wilson wrote: >> > >> > > These commands are illegal/invalid inside the

[Intel-gfx] [PATCH] drm/i915: Fix unsafe vma iteration in i915_drop_caches

2014-09-03 Thread Chris Wilson
When unbinding, there is a possibility that we drop the active reference on the object, thereby freeing it. If that happens, we may destroy the vm link as well as the object and vma. So iterate carefully. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 17 +++--

[Intel-gfx] [PATCH] igt_core: zero exit_handler_count before forking

2014-09-03 Thread Paulo Zanoni
From: Paulo Zanoni If we don't reset exit_handler_count before forking, we may have a case where the forked process is killed before it even does "exit_handler_count = 0": in that case, it is still finishing forking. When that happens, we may end up calling our exit handlers. On the specific bug

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Android sync points for i915 v2

2014-09-03 Thread Chris Wilson
On Wed, Sep 03, 2014 at 07:41:34PM +0300, Ville Syrjälä wrote: > Also looks quite a bit like my ring notify doohicky from: > http://lists.freedesktop.org/archives/intel-gfx/2014-June/047623.html Indeed, fences look similar :) > Except I kept the list in the driver so you would need to do only on

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Android sync points for i915 v2

2014-09-03 Thread Chris Wilson
On Wed, Sep 03, 2014 at 06:05:42PM +0100, Chris Wilson wrote: > On Wed, Sep 03, 2014 at 07:41:34PM +0300, Ville Syrjälä wrote: > > Also looks quite a bit like my ring notify doohicky from: > > http://lists.freedesktop.org/archives/intel-gfx/2014-June/047623.html > > Indeed, fences look similar :)

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Android sync points for i915 v2

2014-09-03 Thread Ville Syrjälä
On Wed, Sep 03, 2014 at 08:09:01AM +0100, Chris Wilson wrote: > On Tue, Sep 02, 2014 at 02:32:40PM -0700, Jesse Barnes wrote: > > +static int i915_fence_check(wait_queue_t *wait, unsigned mode, int flags, > > + void *key) > > +{ > > + struct i915_fence *intel_fence = wait->p

Re: [Intel-gfx] [PATCH 2/2] drm/i915: allow sync points within batches

2014-09-03 Thread Chris Wilson
On Wed, Sep 03, 2014 at 08:41:06AM -0700, Jesse Barnes wrote: > On Wed, 3 Sep 2014 08:01:55 +0100 > Chris Wilson wrote: > > > These commands are illegal/invalid inside the object, only valid inside > > the ring. > > Hm, we ought to be able to write to no privileged space with > STORE_DWORD, but

Re: [Intel-gfx] [PATCH 2/2] drm/i915: allow sync points within batches

2014-09-03 Thread Jesse Barnes
On Wed, 3 Sep 2014 08:01:55 +0100 Chris Wilson wrote: > On Tue, Sep 02, 2014 at 02:32:41PM -0700, Jesse Barnes wrote: > > Use a new reloc type to allow userspace to insert sync points within > > batches before they're submitted. The corresponding fence fds are > > returned in the offset field of

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the tree

2014-09-03 Thread Mark Brown
Hi all, Today's linux-next merge of the drm-intel tree got a conflict which I'm not really sure of and commit b47d1189da119e ("drm/i915: Use dev_priv as first argument of for_each_pipe()") from the drm-intel tree. I fixed it up (see below) and can carry the fix as necessary (no action is requir

Re: [Intel-gfx] linux-next: manual merge of the drm-intel tree with the tree

2014-09-03 Thread Mark Brown
On Wed, Sep 03, 2014 at 02:31:46PM +0100, Mark Brown wrote: > @@ -3923,7 +3942,9 @@ static void valleyview_irq_uninstall(struct drm_device > *dev) > > I915_WRITE(VLV_MASTER_IER, 0); > > - for_each_pipe(pipe) > + intel_hpd_irq_uninstall(dev_priv); > + > + for_each_pipe(dev_pr

Re: [Intel-gfx] [PATCH] drm/i915: init sprites with univeral plane init function

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 10:38:20AM -0300, Gustavo Padovan wrote: > From: Derek Foreman > > Really just for completeness - old init function ends up making the plane > exactly the same way due to the way the enums are set up. > > Signed-off-by: Derek Foreman > Signed-off-by: Gustavo Padovan Qu

[Intel-gfx] [PATCH] drm/i915: init sprites with univeral plane init function

2014-09-03 Thread Gustavo Padovan
From: Derek Foreman Really just for completeness - old init function ends up making the plane exactly the same way due to the way the enums are set up. Signed-off-by: Derek Foreman Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_sprite.c | 8 1 file changed, 4 insertion

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Check of !HAS_PCH_SPLIT() in PCH transcoder funcs

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 02:09:53PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Check for !HAS_PCH_SPLIT() instead of 'gen < 5' in the PCH transcoder > enable functions. > > Signed-off-by: Ville Syrjälä All four patches from this series merged, thanks. -Daniel > --- >

Re: [Intel-gfx] [PATCH] drm/i915: Remove shadowed local variable 'i' from i915_interrupt_info

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 11:59:36AM +0100, Chris Wilson wrote: > Just a stray local variable, begone. > > Signed-off-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_debugfs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/d

Re: [Intel-gfx] [PATCH] drm/i915: Rename global latency_ns variable

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 02:17:52PM +0300, Ville Syrjälä wrote: > On Wed, Sep 03, 2014 at 11:56:07AM +0100, Chris Wilson wrote: > > We use the variable name latency_ns in both the local lowlevel wm > > calculation routines and at the global level. Rename the global value to > > reduce shadow warning

Re: [Intel-gfx] [PATCH v2] drm/i915: Sysfs interface to get GFX shmem usage stats per process

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 11:49:52AM +, Gupta, Sourab wrote: > On Wed, 2014-09-03 at 10:58 +, Daniel Vetter wrote: > > On Wed, Sep 03, 2014 at 03:39:55PM +0530, sourab.gu...@intel.com wrote: > > > From: Sourab Gupta > > > > > > Currently the Graphics Driver provides an interface through whi

Re: [Intel-gfx] [PATCH] drm/i915: Prevent recursive deadlock on releasing a busy userptr

2014-09-03 Thread Jani Nikula
On Tue, 02 Sep 2014, Daniel Vetter wrote: > Queued for -next, thanks for the patch. Aside: Is there other userptr > stuff outstanding? I've definitely lost track of them :( Picked up for drm-intel-fixes instead. Thanks. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___

[Intel-gfx] [PULL] drm-intel-fixes

2014-09-03 Thread Jani Nikula
Hi Dave, here's a couple of display regression fixes for 3.17. BR, Jani. The following changes since commit bbe1c2740d3a25aa1dbe5d842d2ff09cddcdde0a: drm/i915: Remove bogus __init annotation from DMI callbacks (2014-08-28 09:54:27 +0300) are available in the git repository at: git://anon

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Use IS_BROADWELL() instead of IS_GEN8() in forcewake code

2014-09-03 Thread Deepak S
On Wednesday 03 September 2014 04:39 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä IS_GEN8() is a bad check in the forcewake code due to bdw vs. chv differences. Use IS_BROADWELL() instead. The only actual bug here is that we currently call __gen7_gt_force_wake_mt_reset() on c

Re: [Intel-gfx] [PATCH 15/14] drm/i915: Add comments explaining the vdd on/off functions

2014-09-03 Thread Imre Deak
On Tue, 2014-08-19 at 20:47 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Jani wanted some comments to explain why we call certain vdd on/off > functions in certain places. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_dp.c | 16 >

Re: [Intel-gfx] [PATCH v2] drm/i915: Sysfs interface to get GFX shmem usage stats per process

2014-09-03 Thread Gupta, Sourab
On Wed, 2014-09-03 at 10:58 +, Daniel Vetter wrote: > On Wed, Sep 03, 2014 at 03:39:55PM +0530, sourab.gu...@intel.com wrote: > > From: Sourab Gupta > > > > Currently the Graphics Driver provides an interface through which > > one can get a snapshot of the overall Graphics memory consumption.

Re: [Intel-gfx] [PATCH 14/14] drm/i915: Move DP port disable to post_disable for pch platforms

2014-09-03 Thread Imre Deak
On Mon, 2014-08-18 at 22:16 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We need to turn the DP port off after the pipe, otherwise the pipe won't > turn off properly on certain pch platforms at least (happens on my ILK for > example). This also matches the BSpec modeset

Re: [Intel-gfx] [PATCH] drm/i915: Rename global latency_ns variable

2014-09-03 Thread Ville Syrjälä
On Wed, Sep 03, 2014 at 11:56:07AM +0100, Chris Wilson wrote: > We use the variable name latency_ns in both the local lowlevel wm > calculation routines and at the global level. Rename the global value to > reduce shadow warnings and future confusion. > > Signed-off-by: Chris Wilson This has con

[Intel-gfx] [PATCH 4/4] drm/i915: Check of !HAS_PCH_SPLIT() in PCH transcoder funcs

2014-09-03 Thread ville . syrjala
From: Ville Syrjälä Check for !HAS_PCH_SPLIT() instead of 'gen < 5' in the PCH transcoder enable functions. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/driv

[Intel-gfx] [PATCH 1/4] drm/i915: Don't call gen8_fbc_sw_flush() on chv

2014-09-03 Thread ville . syrjala
From: Ville Syrjälä CHV doesn't have FBC, so don't go calling gen8_fbc_sw_flush() on it. Cc: Rodrigo Vivi Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/g

[Intel-gfx] [PATCH 2/4] drm/i915: Use IS_BROADWELL() instead of IS_GEN8() in forcewake code

2014-09-03 Thread ville . syrjala
From: Ville Syrjälä IS_GEN8() is a bad check in the forcewake code due to bdw vs. chv differences. Use IS_BROADWELL() instead. The only actual bug here is that we currently call __gen7_gt_force_wake_mt_reset() on chv. On the other places we have checked for chv before using IS_GEN8(), but change

[Intel-gfx] [PATCH 3/4] drm/i915: Use HAS_GMCH_DISPLAY un underrun reporting code

2014-09-03 Thread ville . syrjala
From: Ville Syrjälä A few open coded HAS_GMCH_DISPLAY() remain in the underrun reporting code. Convert them over. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --

Re: [Intel-gfx] [PATCH 13/14] drm/i915: Enable DP port earlier

2014-09-03 Thread Imre Deak
On Mon, 2014-08-18 at 22:16 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Bspec says we should enable the DP port before enabling panel power, > and that the port must be enabled with training pattern 1. Do so. > > Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak >

[Intel-gfx] [PATCH] drm/i915: Remove shadowed local variable 'i' from i915_interrupt_info

2014-09-03 Thread Chris Wilson
Just a stray local variable, begone. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 86554dcd520f..f3e40fd9c8a9 100644 --- a/drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH v2] drm/i915: Sysfs interface to get GFX shmem usage stats per process

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 03:39:55PM +0530, sourab.gu...@intel.com wrote: > From: Sourab Gupta > > Currently the Graphics Driver provides an interface through which > one can get a snapshot of the overall Graphics memory consumption. > Also there is an interface available, which provides informatio

[Intel-gfx] [PATCH] drm/i915: Rename global latency_ns variable

2014-09-03 Thread Chris Wilson
We use the variable name latency_ns in both the local lowlevel wm calculation routines and at the global level. Rename the global value to reduce shadow warnings and future confusion. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_pm.c | 36 ++-- 1 fil

[Intel-gfx] [PATCH] NEWS: Updates in anticipation of the next release

2014-09-03 Thread Daniel Vetter
Signed-off-by: Daniel Vetter --- NEWS | 21 + 1 file changed, 21 insertions(+) diff --git a/NEWS b/NEWS index de1f89ec97e2..e0ab2cc0e9e4 100644 --- a/NEWS +++ b/NEWS @@ -19,6 +19,27 @@ Release 1.8 (-xx-xx) - New commit functions for igt_kms to support the new universal p

Re: [Intel-gfx] [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle

2014-09-03 Thread Jani Nikula
On Wed, 03 Sep 2014, Chris Wilson wrote: > On Wed, Sep 03, 2014 at 11:23:09AM +0300, Jani Nikula wrote: >> On Tue, 02 Sep 2014, Chris Wilson wrote: >> > @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, >> > struct i2c_adapter *adapter) >> >return NUL

Re: [Intel-gfx] [PATCH 0/5] A few fixes on top of the wa_regs patches

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 10:18:47AM +0100, Siluvery, Arun wrote: > On 30/08/2014 16:50, Damien Lespiau wrote: > >Hi Arun, > > > >I've compiled a few patches that I think solve some small-ish issues around > >your wa_regs series. Could you please have a look at them and comment/give > >your > >r-b t

Re: [Intel-gfx] [PATCH -v2 1/4] drm/i915: init sprites with univeral plane init function

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 10:38:17AM +0200, Daniel Vetter wrote: > On Wed, Sep 03, 2014 at 11:18:27AM +0300, Ville Syrjälä wrote: > > On Tue, Sep 02, 2014 at 04:23:44PM -0300, Gustavo Padovan wrote: > > > From: Derek Foreman > > > > > > Really just for completeness - old init function ends up makin

[Intel-gfx] [PATCH v2] drm/i915: Sysfs interface to get GFX shmem usage stats per process

2014-09-03 Thread sourab . gupta
From: Sourab Gupta Currently the Graphics Driver provides an interface through which one can get a snapshot of the overall Graphics memory consumption. Also there is an interface available, which provides information about the several memory related attributes of every single Graphics buffer crea

Re: [Intel-gfx] [PATCH 0/5] A few fixes on top of the wa_regs patches

2014-09-03 Thread Siluvery, Arun
On 30/08/2014 16:50, Damien Lespiau wrote: Hi Arun, I've compiled a few patches that I think solve some small-ish issues around your wa_regs series. Could you please have a look at them and comment/give your r-b tag if you judge appropriate? On top of those patches, I'd love some comments on th

Re: [Intel-gfx] [PATCH igt] gem_workarounds: intel_wa_registers is now prefixed with i915

2014-09-03 Thread Siluvery, Arun
On 30/08/2014 22:46, Damien Lespiau wrote: Signed-off-by: Damien Lespiau --- tests/gem_workarounds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_workarounds.c b/tests/gem_workarounds.c index 6826562..32156d2 100644 --- a/tests/gem_workarounds.c +++ b/tests/ge

Re: [Intel-gfx] [PATCH] drm/i915: change CHV write_eld/global_resources function pointers

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 11:52:43AM +0300, Ville Syrjälä wrote: > On Tue, Sep 02, 2014 at 04:53:57PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Currently, CHV is using the same functions as HSW/BDW instead of the > > same functions as VLV. This looks wrong, especially since, for > >

Re: [Intel-gfx] [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle

2014-09-03 Thread Chris Wilson
On Wed, Sep 03, 2014 at 11:23:09AM +0300, Jani Nikula wrote: > On Tue, 02 Sep 2014, Chris Wilson wrote: > > @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, > > struct i2c_adapter *adapter) > > return NULL; > > > > return drm_edid_duplic

Re: [Intel-gfx] [PATCH] drm/i915: change CHV write_eld/global_resources function pointers

2014-09-03 Thread Ville Syrjälä
On Tue, Sep 02, 2014 at 04:53:57PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Currently, CHV is using the same functions as HSW/BDW instead of the > same functions as VLV. This looks wrong, especially since, for > example, valleyview_modeset_global_resouces even has an IS_CHERRYVIEW > ch

Re: [Intel-gfx] [PATCH 4/5] drm/i915/hdmi: Refactor force_audio -> has_audio coupling

2014-09-03 Thread Daniel Vetter
On Tue, Sep 02, 2014 at 08:08:20PM +0100, Chris Wilson wrote: > On Tue, Sep 02, 2014 at 08:04:02PM +0100, Chris Wilson wrote: > > The routines for deciding whether we have audio (depending upon > > force_audio and the associated EDID) are common between detection and > > set-property. Refactor the

Re: [Intel-gfx] [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 11:23:09AM +0300, Jani Nikula wrote: > On Tue, 02 Sep 2014, Chris Wilson wrote: > > @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, > > struct i2c_adapter *adapter) > > return NULL; > > > > return drm_edid_duplic

Re: [Intel-gfx] [PATCH -v2 4/4] drm/i915: split intel_update_plane into check() and commit()

2014-09-03 Thread Ville Syrjälä
On Tue, Sep 02, 2014 at 04:23:47PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Due to the upcoming atomic modesetting feature we need to separate > some update functions into a check step that can fail and a commit > step that should, ideally, never fail. > > This commit splits int

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Reduce horizontal timings for pixel replicated modes

2014-09-03 Thread Daniel Vetter
On Tue, Sep 02, 2014 at 05:03:35PM -0700, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > Pixel replicated modes should be non-2x horizontal timings and pixel > replicated by the HW across the HDMI cable at 2X pixel clock. Current > horizontal resolution of 1440 does not allow pixel du

Re: [Intel-gfx] [PATCH -v2 1/4] drm/i915: init sprites with univeral plane init function

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 11:18:27AM +0300, Ville Syrjälä wrote: > On Tue, Sep 02, 2014 at 04:23:44PM -0300, Gustavo Padovan wrote: > > From: Derek Foreman > > > > Really just for completeness - old init function ends up making the plane > > exactly the same way due to the way the enums are set up.

Re: [Intel-gfx] [PATCH -v2 1/4] drm/i915: init sprites with univeral plane init function

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 11:18:27AM +0300, Ville Syrjälä wrote: > On Tue, Sep 02, 2014 at 04:23:44PM -0300, Gustavo Padovan wrote: > > From: Derek Foreman > > > > Really just for completeness - old init function ends up making the plane > > exactly the same way due to the way the enums are set up.

Re: [Intel-gfx] DVFS in Intel graphic chips

2014-09-03 Thread Daniel Vetter
Adding relevant mailing lists, please don't send me i915 related mails in private. On Tue, Sep 2, 2014 at 11:52 PM, Hadi wrote: > Dear Daniel, > > I am PhD student in UW-Madison. I have a question about Intel i915 and I > was wondering if you could possibly answer it. I have worked with Intel C

Re: [Intel-gfx] [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle

2014-09-03 Thread Jani Nikula
On Tue, 02 Sep 2014, Chris Wilson wrote: > @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, > struct i2c_adapter *adapter) > return NULL; > > return drm_edid_duplicate(intel_connector->edid); > - } > + } else > +

Re: [Intel-gfx] [PATCH -v2 3/4] drm/i915: create struct intel_plane_state

2014-09-03 Thread Ville Syrjälä
On Tue, Sep 02, 2014 at 04:23:46PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > This new struct will be the storage of src and dst coordinates > between the check and commit stages of a plane update. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/i915/intel_drv.h | 20

Re: [Intel-gfx] [PATCH -v2 1/4] drm/i915: init sprites with univeral plane init function

2014-09-03 Thread Ville Syrjälä
On Tue, Sep 02, 2014 at 04:23:44PM -0300, Gustavo Padovan wrote: > From: Derek Foreman > > Really just for completeness - old init function ends up making the plane > exactly the same way due to the way the enums are set up. > > Signed-off-by: Derek Foreman Reviewed-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [drm/i915/3.17] panic in i915_digport_work_func

2014-09-03 Thread Jiri Kosina
On Mon, 1 Sep 2014, Daniel Vetter wrote: > > From d407c946fbf5c48f30160591f5bd71fbe158aeb4 Mon Sep 17 00:00:00 2001 > > From: Dave Airlie > > Date: Mon, 1 Sep 2014 16:58:12 +1000 > > Subject: [PATCH] drm/i915: handle G45/GM45 pulse detection connected state. > > > > In the HPD pulse handler we c

Re: [Intel-gfx] [PATCH 2/2] intel/uxa: add MST support.

2014-09-03 Thread Chris Wilson
On Wed, Sep 03, 2014 at 10:43:21AM +1000, Dave Airlie wrote: > @@ -808,6 +815,11 @@ intel_output_attach_edid(xf86OutputPtr output) > xf86MonPtr mon = NULL; > int i; > > + if (!koutput) { > + xf86OutputSetEDID(output, mon); > + return; > + } > + >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Android sync points for i915 v2

2014-09-03 Thread Chris Wilson
On Tue, Sep 02, 2014 at 02:32:40PM -0700, Jesse Barnes wrote: > +static int i915_fence_check(wait_queue_t *wait, unsigned mode, int flags, > + void *key) > +{ > + struct i915_fence *intel_fence = wait->private; > + struct intel_engine_cs *ring = intel_fence->ring; >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: allow sync points within batches

2014-09-03 Thread Chris Wilson
On Tue, Sep 02, 2014 at 02:32:41PM -0700, Jesse Barnes wrote: > Use a new reloc type to allow userspace to insert sync points within > batches before they're submitted. The corresponding fence fds are > returned in the offset field of the returned reloc tree, and can be > operated on with the sync