[Intel-gfx] [PATCH] uxa: intel_sync_close() is only available when HAVE_DRI3

2014-09-13 Thread Sedat Dilek
With LLVM v3.4.2 I got this error reported: ... intel_driver.c:1182:2: error: implicit declaration of function 'intel_sync_close' is invalid in C99 [-Werror,-Wimplicit-function-declaration] intel_sync_close(screen); ^ In file included from intel_uxa.c:44: ./intel_glamor.h:92:1: war

Re: [Intel-gfx] [PATCH 0/2 xf86-video-intel] Two DRI3/Present bug fixes for UXA

2014-09-13 Thread Keith Packard
Chris Wilson writes: > commit d21d781466785c317131a8a57606925867265dc8 > Author: Daniel Vetter > Date: Tue Feb 22 18:31:44 2011 +0100 > > Fix relaxed tiling on gen2 This one matches libdrm in using 16 for the tile height alignment on gen2. > Try enabling relaxed fencing again. > No. The

Re: [Intel-gfx] intel_driver.c:1182:2: error: implicit declaration of function 'intel_sync_close' is invalid in C99

2014-09-13 Thread Sedat Dilek
On Sat, Sep 13, 2014 at 7:15 PM, Sedat Dilek wrote: > Building intel-ddx from GIT HEAD breaks here with LLVM v3.4.2 like this... > ... > intel_driver.c:1182:2: error: implicit declaration of function > 'intel_sync_close' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > intel

[Intel-gfx] intel_driver.c:1182:2: error: implicit declaration of function 'intel_sync_close' is invalid in C99

2014-09-13 Thread Sedat Dilek
Building intel-ddx from GIT HEAD breaks here with LLVM v3.4.2 like this... ... intel_driver.c:1182:2: error: implicit declaration of function 'intel_sync_close' is invalid in C99 [-Werror,-Wimplicit-function-declaration] intel_sync_close(screen); ^ In file included from intel_uxa.c:

Re: [Intel-gfx] [PATCH 14/19] drm: Don't update vblank timestamp when the counter didn't change

2014-09-13 Thread Mario Kleiner
The current drm-next misses Ville's original Patch 14/19, the one i first objected, then objected to my objection. It is needed to avoid actual regressions. Attached a trivially rebased (v2) of Ville's patch to go on top of drm-next, also as tgz in case my e-mail client mangles the patch again,

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915: Support variable cursor height on ivb+

2014-09-13 Thread Chris Wilson
On Fri, Sep 12, 2014 at 08:53:35PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > IVB introduced the CUR_FBC_CTL register which allows reducing the cursor > height down to 8 lines from the otherwise square cursor dimensions. > Implement support for it. > > Commandeer the o

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915: Skip CURBASE write when nothing changed

2014-09-13 Thread Chris Wilson
On Fri, Sep 12, 2014 at 08:53:34PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Only write CURBASE when something about the cursor changed. Also > eliminate the unnecessary posting read after writing CURCNTR. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Only set CURSOR_PIPE_CSC_ENABLE when cursor is enabled

2014-09-13 Thread Chris Wilson
On Fri, Sep 12, 2014 at 08:53:33PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > It seems cleaner if we keep CURCNTR at 0 when the cursor is disabled, > so don't set the CURSOR_PIPE_CSC_ENABLE bit unless the cursor is > enabled. > > Signed-off-by: Ville Syrjälä Reviewed-

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915: Move the cursor_base setup to i{845, 9xx}_update_cursor()

2014-09-13 Thread Chris Wilson
On Fri, Sep 12, 2014 at 08:53:32PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > To make the code a bit more undestandable move the > intel_crtc->cursor_base assignment into the low level update cursor > routines. That's were we compare the current value with the new one >

Re: [Intel-gfx] [PATCH 0/2 xf86-video-intel] Two DRI3/Present bug fixes for UXA

2014-09-13 Thread Chris Wilson
On Thu, Sep 11, 2014 at 12:53:30PM -0700, Keith Packard wrote: > Chris Wilson writes: > > > That extra alignment is due to gen2 and early gen3 (if > > (!intel->has_relaxed_fencing) covers them). > > Here's the patch which changed the alignment requirment: [snip commits picked at random] This i