[Intel-gfx] [PATCH 8/9] drm/i915: Consolidate top-level .update_plane() handlers

2014-11-24 Thread Matt Roper
Our .update_plane() handlers do the same check/prepare/commit/cleanup steps regardless of plane type. Consolidate them all into a single function that calls check/commit through a vtable. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_display.c | 113 ++

[Intel-gfx] [PATCH 2/9] drm/i915: remove intel_crtc_cursor_set_obj() (v5)

2014-11-24 Thread Matt Roper
From: Gustavo Padovan Merge it into the plane update_plane() callback and make other users use the update_plane() functions instead. The fb != crtc->cursor->fb was already inside intel_crtc_cursor_set_obj() so we fold intel_crtc_cursor_set_obj() inside intel_commit_cursor_plane() and merge both

[Intel-gfx] [PATCH 1/9] drm: add helper to get crtc timings (v4)

2014-11-24 Thread Matt Roper
From: Gustavo Padovan We need to get hdisplay and vdisplay in a few places so create a helper to make our job easier. v2 (by Matt): Use new stereo doubling function (suggested by Ville) v3 (by Matt): - Add missing kerneldoc (Daniel) - Use drm_mode_copy() (Jani) v4 (by Matt): - Drop stereo d

Re: [Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-24 Thread Daniel Vetter
On Mon, Nov 24, 2014 at 4:36 PM, Damien Lespiau wrote: > On Mon, Nov 24, 2014 at 04:23:36PM +0100, Daniel Vetter wrote: >> The crc code doesn't handle anything really that could drop the >> register state (by design so that we have less complexity). Which >> means userspace may only start crc capt

Re: [Intel-gfx] [PATCH v5 3/4] drm/i915/bdw: Pin the context backing objects to GGTT on-demand

2014-11-24 Thread Daniel Vetter
On Mon, Nov 24, 2014 at 6:14 PM, Daniel, Thomas wrote: >> This patch here scored a regression (leak in the module unload path), please >> address it asap. Deadline for regressions should be 1 week, then I'll just >> drop >> the patch or apply the revert. That includes review and everything. >> >>

[Intel-gfx] [PATCH] drm/atomic-helper: Skip vblank waits for unchanged fbs

2014-11-24 Thread Daniel Vetter
Especially with legacy cursor ioctls existing userspace assumes that you can pile up lots of updates in one go. The super-proper way to support this would be a special commit mode which overwrites the last update. But getting there will be quite a bit of work. Meanwhile do what pretty much all the

[Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup code

2014-11-24 Thread Daniel Vetter
The crc code doesn't handle anything really that could drop the register state (by design so that we have less complexity). Which means userspace may only start crc capture once the pipe is fully set up. With an i-g-t patch this will be the case, but there's still the problem that this results in

Re: [Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-24 Thread Daniel Vetter
On Wed, Nov 05, 2014 at 10:56:06AM +0100, Daniel Vetter wrote: > On Wed, Nov 05, 2014 at 08:35:01AM +, Chris Wilson wrote: > > On Tue, Nov 04, 2014 at 03:52:22PM +0100, Daniel Vetter wrote: > > > There's quite a few bug reports with error states where the error > > > reasons makes just about no

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Skip vblank waits for unchanged fbs

2014-11-24 Thread Jasper St. Pierre
With the oops fix: Reviewed-by: Jasper St. Pierre Tested-by: Jasper St. Pierre On Mon, Nov 24, 2014 at 12:42 PM, Daniel Vetter wrote: > Especially with legacy cursor ioctls existing userspace assumes that > you can pile up lots of updates in one go. The super-proper way to > support this woul

Re: [Intel-gfx] [PATCH] drm/locking: Allow NULL crtc in drm_modeset_legacy_acquire_ctx

2014-11-24 Thread Jasper St. Pierre
This still crashes for me: kernel: [ cut here ] kernel: WARNING: at drivers/gpu/drm/drm_modeset_lock.c:219 drm_modeset_legacy_acquire_ctx+0x38/0x40() kernel: Modules linked in: kernel: CPU: 0 PID: 586 Comm: Xorg Not tainted 3.10.33-02454-g1c4eeb3-dirty #196 kernel: [] (unwi

Re: [Intel-gfx] [PATCH] drm/i915: Stop gathering error states for CS error interrupts

2014-11-24 Thread Chris Wilson
On Mon, Nov 24, 2014 at 09:57:32PM +0100, Daniel Vetter wrote: > I looked at this and it gets ugly fast. Given that we seem to have a quite > substantial false-positive (found one more by just reading recent bug > spam) rate and haven't enabled this on gen5+ I've decided to just merge > this one he

Re: [Intel-gfx] [PATCH] intel_error_decode: Inflate compressed error state

2014-11-24 Thread Rodrigo Vivi
both deflate and inflate was listed to -collector but got a hard conflict. If it is still needed please rebase it over -nightly On Fri, Oct 31, 2014 at 4:33 AM, Chris Wilson wrote: > Recent kernels compress the active objects using zlib + ascii85 > encoding. This adapts the tool to decompress tho

[Intel-gfx] [PATCH 1/7] drm/i915: Specify bsd rings through exec flag

2014-11-24 Thread Rodrigo Vivi
From: Zhipeng Gong On Broadwell GT3 we have 2 Video Command Streamers (VCS), but userspace has no control when using VCS1 or VCS2. This patch introduces a mechanism to avoid the default ping-pong mode and use one specific ring through execution flag. v2: fix whitespace (Rodrigo) v3: remove incor

[Intel-gfx] [PATCH 6/7] drm/i915: Add WaCsStallBeforeStateCacheInvalidate:bdw, chv to logical ring

2014-11-24 Thread Rodrigo Vivi
Similar to: commit 02c9f7e3cfe76a7f54ef03438c36aade86cc1c8b Author: Kenneth Graunke Date: Mon Jan 27 14:20:16 2014 -0800 drm/i915: Add the WaCsStallBeforeStateCacheInvalidate:bdw workaround. On Broadwell, any PIPE_CONTROL with the "State Cache Invalidate" bit set must be preceded

[Intel-gfx] [PATCH 3/7] drm/i915: Move the ban period onto the context

2014-11-24 Thread Rodrigo Vivi
From: Chris Wilson This will allow us to set per-file, or even per-context, periods in the future. Signed-off-by: Chris Wilson Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 5 + drivers/gpu/drm/i915/i915_gem.c | 3 ++- drivers/gpu/drm/i915/i915_gem_cont

[Intel-gfx] [PATCH 5/7] drm/i915: Put logical pipe_control emission into a helper.

2014-11-24 Thread Rodrigo Vivi
To be used for a Workaroud. Similar to: commit 884ceacee308f0e4616d0c933518af2639f7b1d8 Author: Kenneth Graunke Date: Sat Jun 28 02:04:20 2014 +0300 drm/i915: Refactor Broadwell PIPE_CONTROL emission into a helper. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_lrc.c | 35 ++

[Intel-gfx] [PATCH 0/7] drm-intel-collector - update

2014-11-24 Thread Rodrigo Vivi
This is another drm-intel-collector updated notice: http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector Here goes the update list in order for better reviewers assignment: Patch drm/i915: Specify bsd rings through exec flag - Reviewed Patch drm/i915: add I915_PARAM_H

[Intel-gfx] [PATCH 4/7] drm/i915: Add ioctl to set per-context parameters

2014-11-24 Thread Rodrigo Vivi
From: Chris Wilson Sometimes we wish to tweak how an individual context behaves. Since we always create a context for every filp, this means that individual processes can fine tune their behaviour even if they do not explicitly create a context. The first example parameter here is to enable mult

[Intel-gfx] [PATCH 2/7] drm/i915: add I915_PARAM_HAS_BSD2 to i915_getparam

2014-11-24 Thread Rodrigo Vivi
From: Zhipeng Gong This will let userland only try to use the new ring when the appropriate kernel is present Signed-off-by: Zhipeng Gong Signed-off-by: Rodrigo Vivi Reviewed--by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_dma.c | 3 +++ include/uapi/drm/i915_drm.h | 1 + 2 files changed

[Intel-gfx] [PATCH 7/7] drm/i915: Broaden application of set-domain(GTT)

2014-11-24 Thread Rodrigo Vivi
From: Chris Wilson Previously, this was restricted to only operate on bound objects - to make pointer access through the GTT to the object coherent with writes to and from the GPU. A second usecase is drm_intel_bo_wait_rendering() which at present does not function unless the object also happens

Re: [Intel-gfx] [PATCH] drm/i915: Handle runtime pm in the CRC setup

2014-11-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 367/367

Re: [Intel-gfx] [PATCH] drm/i915: Drop vblank wait from

2014-11-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 367/367

Re: [Intel-gfx] [PATCH] drm/i915: More cautious with pch fifo underruns

2014-11-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 367/367

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Skip vblank waits for

2014-11-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 367/367

[Intel-gfx] [PATCH] drm/i915/skl: Update in Gen9 multi-engine forcewake range

2014-11-24 Thread akash . goel
From: Akash Goel Updates in forcewake range for Render/Media/Common power wells for Gen9. Signed-off-by: Akash Goel Signed-off-by: Zhe Wang --- drivers/gpu/drm/i915/intel_uncore.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncor

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make all plane disables use

2014-11-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 367/367 3

<    1   2