Re: [Intel-gfx] [RFC 0/7+1] Add in-kernel vblank delaying mechanism

2014-11-27 Thread Daniel Vetter
On Thu, Nov 27, 2014 at 09:25:15AM +1000, Dave Airlie wrote: --- TL;DR summary: I wrote patches. Help me choose the best implementation and interface. --- So the i915.ko driver could use some mechanism to run functions after a given number of vblanks. Implementations for this

Re: [Intel-gfx] [PATCH 2/2] drm/i915: sanitize RPS resetting during GPU reset

2014-11-27 Thread Imre Deak
On Thu, 2014-11-20 at 23:01 +0200, Imre Deak wrote: Atm, we don't disable RPS interrupts and related work items before resetting the GPU. This may interfere with the following GPU initialization and cause RPS interrupts to show up in PM_IIR too early before calling gen6_enable_rps_interrupts()

[Intel-gfx] [PATCH v3 0/2] Updates to ring freespace calculations

2014-11-27 Thread Dave Gordon
Essentially the same as patch 3/3 from v2 of this set, but split into two patches; one to improve the robustness of the freespace calculation, and then one to update all the various places that calculate free space to call the new improved code. See individual commit messages for more detail.

[Intel-gfx] [PATCH v3 2/2] drm/i915: Consolidate ring freespace calculations

2014-11-27 Thread Dave Gordon
There are numerous places in the code where the driver's idea of how much space is left in a ring is updated using the driver's latest notions of the positions of 'head' and 'tail' for the ring. Among them are some that update one or both of these values before (re)doing the calculation. In

[Intel-gfx] [PATCH v3 1/2] drm/i915: Make ring freespace calculation more robust

2014-11-27 Thread Dave Gordon
The used space in a ring is given by the cyclic distance from the consumer (HEAD) to the producer (TAIL), i.e. ((tail-head) MOD size); conversely, the available space in a ring is the cyclic distance from the producer to the consumer, MINUS the amount reserved for a gap that is supposed to

Re: [Intel-gfx] [RFC PATCH v3 2/4] drm/ipvr: drm driver for VED

2014-11-27 Thread Cheng, Yao
-Original Message- From: Cheng, Yao Sent: Saturday, November 22, 2014 3:07 To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; daniel.vet...@ffwll.ch; Kelley, Sean V; Chehab, John Cc: Jiang, Fei; dh.herrm...@gmail.com; jani.nik...@linux.intel.com;

Re: [Intel-gfx] [PATCH v2 7/6] drm/i915: Deal with video overlay on GPU reset

2014-11-27 Thread Dave Gordon
On 26/11/14 18:10, Daniel Vetter wrote: On Wed, Nov 26, 2014 at 05:07:29PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Clear the video overlay state on GPU reset. Any pending overlay request in the ring has been nuked, and the display itself

[Intel-gfx] [PATCH] drm/i915: Remove unnecessary goto in intel_primary_plane_disable()

2014-11-27 Thread Ander Conselvan de Oliveira
The same logic can be implemented without it, and it even saves a line of code. Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/dp: retry AUX transactions 32 times (v1.1)

2014-11-27 Thread Jani Nikula
On Wed, 26 Nov 2014, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com At least on two MST devices I've tested with, when they are link training downstream, they are totally unable to handle aux ch msgs, so they defer like nuts. I tried 16, it wasn't enough, 32 seems

Re: [Intel-gfx] [PATCH] Revert drm/i915: Disallow pin ioctl completely for kms drivers

2014-11-27 Thread Jani Nikula
On Tue, 25 Nov 2014, Chris Wilson ch...@chris-wilson.co.uk wrote: This reverts commit c211a47c2c28562f8a3fff9e027be1a3ed9e154a. This causes an unwarranteed API break for existing and active userspace. Ville had an interesting observation regarding the commit being reverted:

[Intel-gfx] [PULL] drm-intel-fixes

2014-11-27 Thread Jani Nikula
Hi Dave, a couple of regression fixes from Ville. BR, Jani. The following changes since commit 5d01410fe4d92081f349b013a2e7a95429e4f2c9: Linux 3.18-rc6 (2014-11-23 15:25:20 -0800) are available in the git repository at: git://anongit.freedesktop.org/drm-intel

Re: [Intel-gfx] [PATCH] Revert drm/i915: Disallow pin ioctl completely for kms drivers

2014-11-27 Thread Chris Wilson
On Thu, Nov 27, 2014 at 03:56:38PM +0200, Jani Nikula wrote: On Tue, 25 Nov 2014, Chris Wilson ch...@chris-wilson.co.uk wrote: This reverts commit c211a47c2c28562f8a3fff9e027be1a3ed9e154a. This causes an unwarranteed API break for existing and active userspace. Ville had an interesting

Re: [Intel-gfx] [PATCH 1/9] drm: add helper to get crtc timings (v4)

2014-11-27 Thread Ander Conselvan de Oliveira
On 11/24/2014 09:52 PM, Matt Roper wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk We need to get hdisplay and vdisplay in a few places so create a helper to make our job easier. v2 (by Matt): Use new stereo doubling function (suggested by Ville) v3 (by Matt): - Add missing

[Intel-gfx] [PATCH] drm/i915: Convert pxvid to extvid lookup table

2014-11-27 Thread Mika Kuoppala
to a procedural to save space. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 155 +--- 1 file changed, 18 insertions(+), 137 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c

Re: [Intel-gfx] [PATCH 3/9] drm/i915: remove intel_pipe_set_base() (v4)

2014-11-27 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com On 11/24/2014 09:53 PM, Matt Roper wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk After some refactor intel_primary_plane_setplane() does the same as intel_pipe_set_base() so we can get rid of it and

Re: [Intel-gfx] [PATCH 1/5] drm/i915: s/init()/init_hw()/ in intel_engine_cs

2014-11-27 Thread Dave Gordon
On 19/11/14 23:33, Daniel Vetter wrote: This is (mostly, some exceptions that need fixing) the hw setup function which starts the ring. And not the function which allocates all the resources. Make this clear by giving it a better name. Signed-off-by: Daniel Vetter daniel.vet...@intel.com

[Intel-gfx] [PATCH] drm/i915: Infrastructure for supporting different GGTT views per object

2014-11-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Things like reliable GGTT mappings and mirrored 2d-on-3d display will need to map objects into the same address space multiple times. Added a GGTT view concept and linked it with the VMA to distinguish between multiple instances per address space.

Re: [Intel-gfx] [PATCH 2/5] drm/i915: s/intel_workarouns_ring/intel_render_workarounds/

2014-11-27 Thread Dave Gordon
On 19/11/14 23:33, Daniel Vetter wrote: Since it's not for the rings but engine, and its specifically for render state and workarounds. Note that there's a massive s/ring/engine/ required all over the driver, but that's really not part of this patch here. So I've leaft the paramter names

[Intel-gfx] [PATCH] drm/atomic: Introduce state-obj backpointers

2014-11-27 Thread Daniel Vetter
Useful since this way we can pass around just the state objects and will get ther real object, too. Specifically this allows us to again simplify the parameters for set_crtc_for_plane. v2: msm already has it's own specific plane_reset hook, don't forget that one! Cc: Rob Clark

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make all plane disables use

2014-11-27 Thread Damien Lespiau
Hi Shuang, The threading is still broken in some MUAs. I believe we also need the References: header in addition to in-reply-to: to solve that. HTH, -- Damien On Mon, Nov 24, 2014 at 11:39:48PM -0800, shuang...@intel.com wrote: Tested-By: PRC QA PRTS (Patch Regression Test System Contact:

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Move intel_init_pipe_control out of engine-init_hw

2014-11-27 Thread Dave Gordon
On 19/11/14 23:33, Daniel Vetter wrote: With this all the -init_hw hooks really only set up hw state needed to start the ring, all the software state setup and memory/buffer allocations happen beforehand. v2: We need to call intel_init_pipe_control after the ring init since otherwise

[Intel-gfx] [PATCH] drm/i915: Disable FBC if primary plane is rotated on Haswell

2014-11-27 Thread Chris Wilson
Quoting the workaround database: FBC can show stale data when using 180 degree hardware rotation of the primary display plane. WA: Do not enable FBC when using hardware 180 degree rotation on the primary display plane. References: https://bugs.freedesktop.org/show_bug.cgi?id=86548

Re: [Intel-gfx] [PATCH] drm/i915: Disable FBC if primary plane is rotated on Haswell

2014-11-27 Thread Paulo Zanoni
2014-11-27 14:18 GMT-02:00 Chris Wilson ch...@chris-wilson.co.uk: Quoting the workaround database: FBC can show stale data when using 180 degree hardware rotation of the primary display plane. WA: Do not enable FBC when using hardware 180 degree rotation on the primary display plane.

Re: [Intel-gfx] [PATCH] drm/i915: Disable FBC if primary plane is rotated on Haswell

2014-11-27 Thread Chris Wilson
On Thu, Nov 27, 2014 at 02:40:34PM -0200, Paulo Zanoni wrote: 2014-11-27 14:18 GMT-02:00 Chris Wilson ch...@chris-wilson.co.uk: Quoting the workaround database: FBC can show stale data when using 180 degree hardware rotation of the primary display plane. WA: Do not enable FBC when

Re: [Intel-gfx] [PATCH 2/2] drm/i915: sanitize RPS resetting during GPU reset

2014-11-27 Thread Daniel Vetter
On Thu, Nov 27, 2014 at 01:08:58PM +0200, Imre Deak wrote: On Thu, 2014-11-20 at 23:01 +0200, Imre Deak wrote: Atm, we don't disable RPS interrupts and related work items before resetting the GPU. This may interfere with the following GPU initialization and cause RPS interrupts to show up

Re: [Intel-gfx] [PATCH 2/2] drm/i915: sanitize RPS resetting during GPU reset

2014-11-27 Thread Imre Deak
On Thu, 2014-11-27 at 20:07 +0100, Daniel Vetter wrote: On Thu, Nov 27, 2014 at 01:08:58PM +0200, Imre Deak wrote: On Thu, 2014-11-20 at 23:01 +0200, Imre Deak wrote: Atm, we don't disable RPS interrupts and related work items before resetting the GPU. This may interfere with the

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Consolidate ring freespace

2014-11-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [PATCH] drm/i915: Remove unnecessary goto in

2014-11-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

Re: [Intel-gfx] [PATCH] drm/i915: Convert pxvid to extvid lookup table

2014-11-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 364/364

Re: [Intel-gfx] [PATCH] drm/i915: Infrastructure for supporting

2014-11-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 364/364

Re: [Intel-gfx] [PATCH] drm/i915: Disable FBC if primary plane is

2014-11-27 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 364/364

[Intel-gfx] [QA 11/28 ww48] Testing report for `drm-intel-testing` (was: Updated -next)

2014-11-27 Thread Sun, Yi
Summary We covered the platform: Baswell, Broadwell, Baytrail, Haswell, Ivybridge, SandyBridge In this circle, 4 new bugs are filed: Bug 86770https://bugs.freedesktop.org/show_bug.cgi?id=86770 - [BYT Regression]HDMI monitor unable to light up Bug