Re: [Intel-gfx] [PATCH] drm/i915: Fallback to using CPU relocations for large batch buffers

2015-01-09 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 354/354

Re: [Intel-gfx] [PATCH] intel: Export GT config attributes

2015-01-09 Thread Jeff McGee
On Fri, Jan 09, 2015 at 10:56:16AM +0800, Zhenyu Wang wrote: On 2014.12.18 12:12:33 -0600, jeff.mc...@intel.com wrote: diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 15dd01d..be38adf 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -340,6 +340,10

[Intel-gfx] randconfig build error with next-20150109, in drivers/gpu/drm/i915/intel_display.c

2015-01-09 Thread Jim Davis
Building with the attached random configuration file, drivers/gpu/drm/i915/intel_display.c: In function ‘assert_pll’: drivers/gpu/drm/i915/intel_display.c:1027:2: error: implicit declaration of function ‘__WARN_printf’ [-Werror=implicit-function-declaration] I915_STATE_WARN(cur_state != state,

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make hpd arrays big enough to avoid out of bounds access

2015-01-09 Thread Ville Syrjälä
On Fri, Jan 09, 2015 at 04:41:33PM +0200, Jani Nikula wrote: On Fri, 09 Jan 2015, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com intel_hpd_irq_handler() walks the passed in hpd[] array assuming it contains HPD_NUM_PINS elements. Currently that's not

[Intel-gfx] [PATCH] Add jobserver flag (+) to deb-pkg build commands

2015-01-09 Thread Dave Gordon
This gets rid of some annoying warnings and allows GNU make to parallelise more parts of a deb-pkg build. The message is ... make[3]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. ... so I've added the '+' as suggested. Signed-off-by: Dave Gordon

Re: [Intel-gfx] [PATCH v4 0/6] sanitize hda/i915 interface using the component fw

2015-01-09 Thread Daniel Vetter
On Thu, Jan 08, 2015 at 05:54:12PM +0200, Imre Deak wrote: This is v4 of [1] addressing the review comments from Takashi and Jani. [1] http://lists.freedesktop.org/archives/intel-gfx/2014-December/056992.html Imre Deak (6): drm/i915: add dev_to_i915 helper drm/i915: add component

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add a fallback for unimplemented gen9 w/a

2015-01-09 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -31 363/364

Re: [Intel-gfx] [PATCH v4 0/6] sanitize hda/i915 interface using the component fw

2015-01-09 Thread Takashi Iwai
At Fri, 9 Jan 2015 10:18:45 +0100, Daniel Vetter wrote: On Thu, Jan 08, 2015 at 05:54:12PM +0200, Imre Deak wrote: This is v4 of [1] addressing the review comments from Takashi and Jani. [1] http://lists.freedesktop.org/archives/intel-gfx/2014-December/056992.html Imre Deak (6):

Re: [Intel-gfx] [Announcement] 2015-Q1 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-01-09 Thread Jike Song
Hi all, We're pleased to announce a public update to Intel Graphics Virtualization Technology (Intel GVT-g, formerly known as XenGT). Intel GVT-g is a complete vGPU solution with mediated pass-through, supported today on 4th generation Intel Core(TM) processors with Intel Graphics

Re: [Intel-gfx] [BUG] drm/i915: backlight off after resume

2015-01-09 Thread Jani Nikula
On Fri, 09 Jan 2015, Jeremiah Mahler jmmah...@gmail.com wrote: Jani, all, On a Lenovo X1 Carbon if the display is off when suspend is entered it will be off when it is resumed. A key must be pressed to restore normal brightness. Please file a bug on [1] and attach dmesg with drm.debug=14

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Disable HPD for disabled eDP ports

2015-01-09 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -31 363/364

Re: [Intel-gfx] [PATCH] drm/i915: cleanup lrc engine state when lrc is freed

2015-01-09 Thread Dave Gordon
On 08/01/15 13:40, Mika Kuoppala wrote: i915_gem_validate_context() will check the engine-state to see if it can submit into a ringbuffer. But when we are releasing the context we leave the engine state to a non null value. Thus after a successful hang recovery we might mistakenly submit to a

Re: [Intel-gfx] [PATCH v2] drm/i915: Add the predicate source registers to the register whitelist

2015-01-09 Thread Neil Roberts
Hi, Daniel Vetter dan...@ffwll.ch writes: Ok, I've merged this one, since that means you at least won't get an -EINVAL. But you can't yet enable the feature in mesa since it's still no-opped out. Let's hope that v3 actually starts granting rights (but please don't encode that in any merge

Re: [Intel-gfx] [PATCH v2] drm/i915: Reset CSB read pointer in ring init

2015-01-09 Thread Dave Gordon
On 09/01/15 11:09, Daniel, Thomas wrote: A previous commit enabled execlists by default: commit 27401d126b5b (drm/i915/bdw: Enable execlists by default where supported) This allowed routine testing of execlists which exposed a regression when resuming from suspend. The cause was

[Intel-gfx] [PATCH] drm/i915: Fallback to using CPU relocations for large batch buffers

2015-01-09 Thread Chris Wilson
If the batch buffer is too large to fit into the aperture and we need a GTT mapping for relocations, we currently fail. This only applies to a subset of machines for a subset of environments, quite undesirable. We can simply check after failing to insert the batch into the GTT as to whether we

Re: [Intel-gfx] [PATCH v2] drm/i915: Reset CSB read pointer in ring init

2015-01-09 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV -31 363/364

[Intel-gfx] [PATCH 2/10] drm/i915: Initialize DRRS delayed work

2015-01-09 Thread Vandana Kannan
Add DRRS work function to trigger a switch to low refresh rate when activity is detected on screen. Signed-off-by: Vandana Kannan vandana.kan...@intel.com --- drivers/gpu/drm/i915/intel_dp.c | 36 1 file changed, 28 insertions(+), 8 deletions(-) diff --git

[Intel-gfx] [PATCH 1/10] drm/i915: Modifying structures related to DRRS

2015-01-09 Thread Vandana Kannan
Earlier, DRRS structures were specific to eDP (used only in intel_dp). Since DRRS can be extended to other internal display types (if the panel supports multiple RR), modifying structures to be part of drm_i915_private and have a provision to add display related structs like intel_dp. Also,

[Intel-gfx] [PATCH 9/10] drm/i915: Add debugfs entry for DRRS

2015-01-09 Thread Vandana Kannan
Adding a debugfs entry to determine if DRRS is supported or not Signed-off-by: Vandana Kannan vandana.kan...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [PATCH 8/10] Documentation/drm: DocBook integration for DRRS

2015-01-09 Thread Vandana Kannan
Adding an overview of DRRS in general and the implementation for eDP DRRS. Also, describing the functions related to eDP DRRS. Signed-off-by: Vandana Kannan vandana.kan...@intel.com --- Documentation/DocBook/drm.tmpl | 11 + drivers/gpu/drm/i915/intel_dp.c | 95

[Intel-gfx] [PATCH 3/10] drm/i915: Enable/disable DRRS

2015-01-09 Thread Vandana Kannan
Calling enable/disable DRRS when enable/disable DDI are called. These functions are responsible for setup of drrs data (in enable) and reset of drrs (in disable). has_drrs is true when downclock_mode is found and SEAMLESS_DRRS is set in the VBT. A check has been added for has_drrs in these

[Intel-gfx] [PATCH 4/10] drm/i915: DRRS calls based on frontbuffer

2015-01-09 Thread Vandana Kannan
Calls have been added to invalidate/flush DRRS whenever invalidate/flush is called as part of frontbuffer tracking. Apart from calls as a result of GEM tracking to fb invalidate/flush, a call has been added to invalidate fb obj from crtc_page_flip as well. This is to track busyness through flip

[Intel-gfx] [PATCH 7/10] drm/i915: Enable eDP DRRS for CHV

2015-01-09 Thread Vandana Kannan
From: Durgadoss R durgados...@intel.com This patch enables eDP DRRS for CHV by adding the required IS_CHERRYVIEW() checks. CHV uses the same register bit as VLV. [Vandana]: Since CHV has 2 sets of M_N registers, it will follow the same code path as gen 8. Added CHV check in dp_set_m_n()

[Intel-gfx] [PATCH v3 0/10] eDP DRRS based on frontbuffer tracking

2015-01-09 Thread Vandana Kannan
This patch series inserts DRRS into frontbuffer tracking mechanism. 1. Previous submission for this feature was designed considering only eDP DRRS. In this series, apart from following fb tracking, changes have been made to make structures generic so that it can be of use to any other code

[Intel-gfx] [PATCH 5/10] drm/i915/bdw: Add support for DRRS to switch RR

2015-01-09 Thread Vandana Kannan
For Broadwell, there is one instance of Transcoder MN values per transcoder. For dynamic switching between multiple refreshr rates, M/N values may be reprogrammed on the fly. Link N programming triggers update of all data and link M N registers and the new M/N values will be used in the next

[Intel-gfx] [PATCH 6/10] drm/i915: Support for RR switching on VLV

2015-01-09 Thread Vandana Kannan
Definition of VLV RR switch bit and corresponding toggling in set_drrs function. Signed-off-by: Vandana Kannan vandana.kan...@intel.com Signed-off-by: Uma Shankar uma.shan...@intel.com Reviewed-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 1 +

[Intel-gfx] [PATCH 10/10] kms_drrs: Test DRRS entry and exit

2015-01-09 Thread Vandana Kannan
This test just display a frame on screen, waits for 1 second to enter DRRS and displays another frame to exit DRRS. TODO:- Notify the user about which refresh rate was used at different stages. Signed-off-by: Vandana Kannan vandana.kan...@intel.com --- tests/Makefile.sources | 1 +

Re: [Intel-gfx] [PATCH] Add jobserver flag (+) to deb-pkg build commands

2015-01-09 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 354/354

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Refactor work that can sleep out of commit (v7)

2015-01-09 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira conselv...@gmail.com On 12/24/2014 05:59 PM, Matt Roper wrote: Once we integrate our work into the atomic pipeline, plane commit operations will need to happen with interrupts disabled, due to vblank evasion. Our commit functions today include sleepable

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Move vblank evasion to commit (v4)

2015-01-09 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira conselv...@gmail.com On 12/23/2014 08:41 PM, Matt Roper wrote: Move the vblank evasion up from the low-level, hw-specific update_plane() handlers to the general plane commit operation. Everything inside commit should now be non-sleeping, so this brings

[Intel-gfx] [PATCH 3/7] drm/i915: Don't register HDMI connectors for eDP ports on VLV/CHV

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com If we determine that a specific port is eDP, don't register the HDMI connector/encoder for it. The reason being that we want to disable HPD interrupts for eDP ports when the display is off, but the presence of the extra HDMI connector would demand

[Intel-gfx] [PATCH 2/7] drm/i915: Remove I915_HAS_HOTPLUG() check from i915_hpd_irq_setup()

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com The dev_priv-display.hpd_irq_setup hook is optional, so we can move the I915_HAS_HOTPLUG() check out of i915_hpd_irq_setup() and only set up the hook when hotplug support is present. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com ---

[Intel-gfx] [PATCH 1/7] drm/i915: Make hpd arrays big enough to avoid out of bounds access

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com intel_hpd_irq_handler() walks the passed in hpd[] array assuming it contains HPD_NUM_PINS elements. Currently that's not true as we don't specify an explicit size for the arrays when initializing them. Avoid the out of bounds accesses by

[Intel-gfx] [PATCH 0/7] drm/i915: Disable hpd for disabled eDP ports

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com My BSW has a nasty problem where it generates tons of spurious hpd interrupts when the eDP display is disabled. The best solution seems to be to disable hpd for eDP ports when the port is disabled since we don't care about long hpds anyway and

[Intel-gfx] [PATCH 6/7] drm/i915: Unify hpd setup between init and hpd storm handling

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Handle things the same way when initializing hpd support and re-enabling hpd interrupts after recovering from an interrupt storm. Later on we'll share the same code also when togglind hpd on/off for inidividual eDP connectors. Signed-off-by:

[Intel-gfx] [PATCH 5/7] drm/i915: Set intel_connector-polled to DRM_CONNECTOR_POLL_HPD when appropriate

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com In order to toggle hpd support on/off per-connector during runtime, we need to track the desired hpd state for each connector. Currently we're being lazy and only setting up intel_connector-polled when we wish to use polling instead of hpd, so a

[Intel-gfx] [PATCH 7/7] drm/i915: Disable HPD for disabled eDP ports

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com My BSW likes to generate tons of HPD interrupts while the eDP port is disabled. I guess it leaves the HPD like floating and then stuff like CPU activity can cause noise on the line leading to tons of spurious interrupts. To combat this, disable

[Intel-gfx] [PATCH 4/7] drm/i915: Don't pretend SDVO hotplug works on 915

2015-01-09 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com 915 doens't support hotplug at all, so we shouldn't try to pretend otherwise in the SDVO code. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_sdvo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Clarify sprite plane function names (v4)

2015-01-09 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira conselv...@gmail.com On 12/23/2014 08:41 PM, Matt Roper wrote: A few of the sprite-related function names in i915 are very similar (e.g., intel_enable_planes() vs intel_crtc_enable_planes()) and don't make it clear whether they only operate on sprite

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Move to atomic plane helpers (v9)

2015-01-09 Thread Ander Conselvan de Oliveira
Reviewed-by: Ander Conselvan de Oliveira conselv...@gmail.com On 12/23/2014 08:41 PM, Matt Roper wrote: Switch plane handling to use the atomic plane helpers. This means that rather than provide our own implementations of .update_plane() and .disable_plane(), we expose the lower-level

Re: [Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-09 Thread Jani Nikula
On Fri, 02 Jan 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: For scenarios where OF is not available, we can use panel identification by name. Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com --- drivers/gpu/drm/drm_panel.c | 18 ++ include/drm/drm_panel.h | 3

Re: [Intel-gfx] [RFC v2 3/4] drm/panel: Add new panel driver based on crystal cove pmic

2015-01-09 Thread Jani Nikula
On Fri, 02 Jan 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: This driver provides support for the crystal_cove_panel cell device. On BYT-T pmic has to be used to enable/disable panel. This needs to be sent to dri-devel. With the comments below addressed, and with the disclaimer that I

Re: [Intel-gfx] [RFC v2 4/4] drm/i915: Enable DSI panel enable/disable based on PMIC

2015-01-09 Thread Jani Nikula
On Fri, 02 Jan 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: This allows for proper PPS during enable/disable of BYT-T platforms where these signals are routed through PMIC. Needs DRM_PANEL to be selected by default as well Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com ---

Re: [Intel-gfx] [RFC v2 0/4] Crystal Cove PMIC based Panel and Backlight Control

2015-01-09 Thread Jani Nikula
On Fri, 02 Jan 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: Hi All Please find modifed set of patches. Sending as a separate thread as initial patches were a crude implementation to trigger discussion, but these have been tested and also do not need intel_soc_pmic_writeb/readb

[Intel-gfx] [PATCH v2] drm/i915: Reset CSB read pointer in ring init

2015-01-09 Thread Thomas Daniel
A previous commit enabled execlists by default: commit 27401d126b5b (drm/i915/bdw: Enable execlists by default where supported) This allowed routine testing of execlists which exposed a regression when resuming from suspend. The cause was tracked down the to recent changes to the ring

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Make hpd arrays big enough to avoid out of bounds access

2015-01-09 Thread Jani Nikula
On Fri, 09 Jan 2015, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com intel_hpd_irq_handler() walks the passed in hpd[] array assuming it contains HPD_NUM_PINS elements. Currently that's not true as we don't specify an explicit size for the arrays when

Re: [Intel-gfx] [PATCH i-g-t] lib/Android.mk: add -DHAVE_LINUX_KD_H to fix android build

2015-01-09 Thread Thomas Wood
On 8 January 2015 at 14:18, tim.g...@intel.com wrote: From: Tim Gore tim.g...@intel.com A recent change to igt_kms.c reqires HAVE_LINUX_KD_H to be set in order to pick up the kd.h header file. Could you include a bit more detail about which commit introduced this change and why?

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Remove I915_HAS_HOTPLUG() check from i915_hpd_irq_setup()

2015-01-09 Thread Jani Nikula
On Fri, 09 Jan 2015, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com The dev_priv-display.hpd_irq_setup hook is optional, so we can move the I915_HAS_HOTPLUG() check out of i915_hpd_irq_setup() and only set up the hook when hotplug support is present.

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Don't register HDMI connectors for eDP ports on VLV/CHV

2015-01-09 Thread Jani Nikula
On Fri, 09 Jan 2015, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com If we determine that a specific port is eDP, don't register the HDMI connector/encoder for it. The reason being that we want to disable HPD interrupts for eDP ports when the display is

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Don't pretend SDVO hotplug works on 915

2015-01-09 Thread Jani Nikula
On Fri, 09 Jan 2015, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com 915 doens't support hotplug at all, so we shouldn't try to pretend otherwise in the SDVO code. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com Reviewed-by: Jani Nikula