Re: [Intel-gfx] [PATCH 2/3] drm/i915/skl: Declare that GT3 has a second VCS

2015-02-03 Thread Rodrigo Vivi
On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau damien.lesp...@intel.com wrote: Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/i915_drv.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c

Re: [Intel-gfx] [PATCH 3/3] drm/i915/skl: Remove the check enforcing VCS2 to be gen8 only

2015-02-03 Thread Rodrigo Vivi
Good catch! Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau damien.lesp...@intel.com wrote: Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 8 +--- 1 file changed, 1 insertion(+), 7

Re: [Intel-gfx] [RFC v3 2/4] mfd: Add a new cell device for panel controlled by crystal cove pmic

2015-02-03 Thread Shobhit Kumar
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/03/2015 06:35 PM, Thierry Reding wrote: On Wed, Jan 21, 2015 at 04:48:11PM +0530, Shobhit Kumar wrote: On BYT-T configuration, panel enable/disable signals are routed through PMIC. Add a cell device for the same. Signed-off-by: Shobhit

Re: [Intel-gfx] [RFC v3 3/4] drm/i915: Add new panel driver based on crystal cove pmic

2015-02-03 Thread Shobhit Kumar
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/03/2015 06:46 PM, Thierry Reding wrote: On Wed, Jan 21, 2015 at 04:48:12PM +0530, Shobhit Kumar wrote: This driver provides support for the crystal_cove_panel cell device. On BYT-T pmic has to be used to enable/disable panel. v2: Addressed

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 01:36:00PM +, Damien Lespiau wrote: On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: Spell all the PCI IDs out to be able to quickly grep for the IDs. No functional changes. Signed-off-by: Jani Nikula jani.nik...@intel.com --- I tested

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Be consistent on printing seqnos

2015-02-03 Thread Jani Nikula
On Wed, 28 Jan 2015, shuang...@intel.com wrote: Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5645 -Summary- Platform Delta drm-intel-nightly

[Intel-gfx] [PATCH 1/2] drm/i915: Detect eDRAM with the enabled bit only

2015-02-03 Thread Damien Lespiau
At the moment we compare the whole EDRAM_PRESENT/EDRAMCAP register value to 1 while EDRAM_PRESENT is only bit 0 (the rest may be used to describe eDRAM capabilities). To be more future proof, only look at bit 0 to detect eDRAM presence. Signed-off-by: Damien Lespiau damien.lesp...@intel.com ---

[Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between close and invalidate

2015-02-03 Thread Michał Winiarski
It was possible for invalidate range start mmu notifier callback to race with releasing userptr object. If the object is released prior to taking a spinlock in the callback, we'll encounter a null pointer dereference. Cc: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Michał Winiarski

Re: [Intel-gfx] [PATCH] drm/i915: Correct the variable holding the value for EOT to write

2015-02-03 Thread Jani Nikula
On Tue, 03 Feb 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: This isuue got introduced in - commit 24ee0e64909bf7f1953d87d3e1e29d93eafcad73 Author: Gaurav K Singh gaurav.k.si...@intel.com Date: Fri Dec 5 14:24:21 2014 +0530 drm/i915: Update the DSI enable path to support dual

Re: [Intel-gfx] Heavy black flickering with Intel graphics after VT switching from X

2015-02-03 Thread Jani Nikula
On Tue, 03 Feb 2015, William Hua william@canonical.com wrote: The downstream Ubuntu bug report is https://bugs.launchpad.net/mir/+bug/1409133. And the upstream one is at https://bugs.freedesktop.org/show_bug.cgi?id=88944 -- Jani Nikula, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH] drm/i915: Prevent use-after-free in invalidate_range_start callback

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 03:48:17PM +0100, Michał Winiarski wrote: It's possible for invalidate_range_start mmu notifier callback to race against userptr object release. If the gem object was released prior to obtaining the spinlock in invalidate_range_start we're hitting null pointer

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-02-03 Thread Thierry Reding
On Fri, Jan 30, 2015 at 05:08:23PM +0100, Daniel Vetter wrote: From: Rob Clark robdcl...@gmail.com In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to

Re: [Intel-gfx] [PATCH i-g-t] kms_cursor_crc: Kernel now checks for integer overflow

2015-02-03 Thread Jani Nikula
On Tue, 03 Feb 2015, Matt Roper matthew.d.ro...@intel.com wrote: As of kernel commit commit a679064a7e9e8799177a64a31668a34a1bc6a4f1 Author: Matt Roper matthew.d.ro...@intel.com Date: Fri Jan 30 16:22:37 2015 -0800 drm/i915: Switch planes from transitional helpers to

[Intel-gfx] [PATCH] drm/i915: Prevent use-after-free in invalidate_range_start callback

2015-02-03 Thread Michał Winiarski
It's possible for invalidate_range_start mmu notifier callback to race against userptr object release. If the gem object was released prior to obtaining the spinlock in invalidate_range_start we're hitting null pointer dereference. Testcase: igt/gem_userptr_blits/stress-mm-invalidate-close

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between close and invalidate

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 03:39:17PM +0100, Michał Winiarski wrote: It was possible for invalidate range start mmu notifier callback to race with releasing userptr object. If the object is released prior to taking a spinlock in the callback, we'll encounter a null pointer dereference. Cc:

Re: [Intel-gfx] [PATCH i-g-t] kms_cursor_crc: Kernel now checks for integer overflow

2015-02-03 Thread Matt Roper
On Tue, Feb 03, 2015 at 04:33:51PM +0200, Jani Nikula wrote: On Tue, 03 Feb 2015, Matt Roper matthew.d.ro...@intel.com wrote: As of kernel commit commit a679064a7e9e8799177a64a31668a34a1bc6a4f1 Author: Matt Roper matthew.d.ro...@intel.com Date: Fri Jan 30 16:22:37 2015

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 12:14:18PM +0100, Daniel Vetter wrote: On Tue, Feb 03, 2015 at 11:00:56AM +, Chris Wilson wrote: On Tue, Feb 03, 2015 at 11:49:00AM +0100, Daniel Vetter wrote: You can _never_ assert that a lock is not held, except in some very restricted corner cases where

Re: [Intel-gfx] [PATCH 1/4] drm/irq: Add drm_crtc_vblank_reset

2015-02-03 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Tuesday 03 February 2015 11:30:11 Daniel Vetter wrote: At driver load we need to tell the vblank code about the state of the pipes, so that the logic around reject vblank_get when the pipe is off works correctly. Thus far i915 used drm_vblank_off, but

Re: [Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 10:41:49AM +, Tvrtko Ursulin wrote: On 02/02/2015 08:17 PM, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 05:30:36PM +, Tvrtko Ursulin wrote: On 02/02/2015 05:15 PM, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 10:36:30AM +, Tvrtko Ursulin wrote: On

[Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Jani Nikula
Spell all the PCI IDs out to be able to quickly grep for the IDs. No functional changes. Signed-off-by: Jani Nikula jani.nik...@intel.com --- I tested this by comparing the results of $ make drivers/gpu/drm/i915/i915_drv.s $ make arch/x86/kernel/early-quirks.s before and after the patch. No

Re: [Intel-gfx] [PATCH] drm/i915: Prevent use-after-free in invalidate_range_start callback

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 03:08:17PM +, Chris Wilson wrote: On Tue, Feb 03, 2015 at 03:48:17PM +0100, Michał Winiarski wrote: It's possible for invalidate_range_start mmu notifier callback to race against userptr object release. If the gem object was released prior to obtaining the

Re: [Intel-gfx] [PATCH] tests/gem_userptr_blits: Race between close and invalidate

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 03:01:38PM +, Chris Wilson wrote: On Tue, Feb 03, 2015 at 03:39:17PM +0100, Michał Winiarski wrote: It was possible for invalidate range start mmu notifier callback to race with releasing userptr object. If the object is released prior to taking a spinlock in the

Re: [Intel-gfx] [PATCH] drm/i915: Skip Stolen Memory first page.

2015-02-03 Thread Siluvery, Arun
On 01/08/2014 17:34, Jesse Barnes wrote: On Thu, 31 Jul 2014 12:08:20 -0700 Rodrigo Vivi rodrigo.v...@intel.com wrote: WA to skip the first page of stolen memory due to sporadic HW write on *CS Idle v2: Improve variable names and fix allocated size. Reviewed-by: Ben Widawsky

Re: [Intel-gfx] [PATCH] drm/i915: Correct the variable holding the value for EOT to write

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 04:40:42PM +0200, Jani Nikula wrote: On Tue, 03 Feb 2015, Shobhit Kumar shobhit.ku...@intel.com wrote: This isuue got introduced in - commit 24ee0e64909bf7f1953d87d3e1e29d93eafcad73 Author: Gaurav K Singh gaurav.k.si...@intel.com Date: Fri Dec 5 14:24:21 2014

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-03 Thread Matt Roper
On Tue, Feb 03, 2015 at 12:57:31PM +0100, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 03:38:16PM -0800, Rodrigo Vivi wrote: frontbuffer bits must be updated during commit times not on atomica prepare one, otherwise we have a risk of false positive. Cc Daniel Vetter daniel.vet...@ffwll.ch

Re: [Intel-gfx] [PATCH 1/4] drm/irq: Add drm_crtc_vblank_reset

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 01:31:34PM +0200, Laurent Pinchart wrote: Hi Daniel, Thank you for the patch. On Tuesday 03 February 2015 11:30:11 Daniel Vetter wrote: At driver load we need to tell the vblank code about the state of the pipes, so that the logic around reject vblank_get when

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 03:05:05PM +0200, Jani Nikula wrote: On Tue, 03 Feb 2015, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: Spell all the PCI IDs out to be able to quickly grep for the IDs. No functional changes. On the

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Damien Lespiau
On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: Spell all the PCI IDs out to be able to quickly grep for the IDs. No functional changes. Signed-off-by: Jani Nikula jani.nik...@intel.com --- I tested this by comparing the results of $ make drivers/gpu/drm/i915/i915_drv.s

Re: [Intel-gfx] [PATCH] drm/i915: Don't bail out early on i915_handle_error

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 02:27:25PM +0200, Mika Kuoppala wrote: If we bail out from handling the error, we never wake up the waiters, resulting in a stuck processes. This regression was introduced in: commit b8d24a06568368076ebd5a858a011699a97bfa42 Author: Mika Kuoppala

Re: [Intel-gfx] [RFC v3 2/4] mfd: Add a new cell device for panel controlled by crystal cove pmic

2015-02-03 Thread Thierry Reding
On Wed, Jan 21, 2015 at 04:48:11PM +0530, Shobhit Kumar wrote: On BYT-T configuration, panel enable/disable signals are routed through PMIC. Add a cell device for the same. Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com --- drivers/mfd/intel_soc_pmic_crc.c | 3 +++ 1 file changed, 3

Re: [Intel-gfx] [RFC v3 3/4] drm/i915: Add new panel driver based on crystal cove pmic

2015-02-03 Thread Thierry Reding
On Wed, Jan 21, 2015 at 04:48:12PM +0530, Shobhit Kumar wrote: This driver provides support for the crystal_cove_panel cell device. On BYT-T pmic has to be used to enable/disable panel. v2: Addressed Jani's comments - Moved inside i915 - Correct licensing - Remove unused stuff

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

2015-02-03 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5702 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915: Remove nested work in gpu error handling

2015-02-03 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: On Mon, Feb 02, 2015 at 10:38:19AM +0100, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 09:17:14AM +, Chris Wilson wrote: On Wed, Jan 28, 2015 at 05:03:14PM +0200, Mika Kuoppala wrote: @@ -2616,6 +2612,9 @@ void i915_handle_error(struct

Re: [Intel-gfx] [PATCH v2] drm/i915: Introduce intel_set_rps()

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 01:36:50PM +, Chris Wilson wrote: On Mon, Feb 02, 2015 at 07:09:50PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Replace the valleyview_set_rps() and gen6_set_rps() calls with intel_set_rps() which itself does

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: Spell all the PCI IDs out to be able to quickly grep for the IDs. No functional changes. On the other hand this is a loss of contextual information in the header file. -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH v2] drm/i915: Introduce intel_set_rps()

2015-02-03 Thread Chris Wilson
On Mon, Feb 02, 2015 at 07:09:50PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Replace the valleyview_set_rps() and gen6_set_rps() calls with intel_set_rps() which itself does the IS_VALLEYVIEW() check. The code becomes simpler since the

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-03 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 03:38:16PM -0800, Rodrigo Vivi wrote: frontbuffer bits must be updated during commit times not on atomica prepare one, otherwise we have a risk of false positive. Cc Daniel Vetter daniel.vet...@ffwll.ch Cc: Sonika Jindal sonika.jin...@intel.com Signed-off-by: Rodrigo

Re: [Intel-gfx] [PATCH] drm/i915: Track old framebuffer instead of object

2015-02-03 Thread Daniel Vetter
On Mon, Feb 02, 2015 at 03:44:15PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Daniel Vetter spotted a bug while reviewing some of my refactoring in this are of the code. I'll quote: @@ -9764,6 +9768,7 @@ static int intel_crtc_page_flip(struct drm_crtc

Re: [Intel-gfx] [PATCH] drm/i915: Don't bail out early on i915_handle_error

2015-02-03 Thread Jani Nikula
On Tue, 03 Feb 2015, Mika Kuoppala mika.kuopp...@linux.intel.com wrote: If we bail out from handling the error, we never wake up the waiters, resulting in a stuck processes. This regression was introduced in: commit b8d24a06568368076ebd5a858a011699a97bfa42 Author: Mika Kuoppala

Re: [Intel-gfx] [RFC v3 1/4] drm: Add support to find drm_panel by name

2015-02-03 Thread Thierry Reding
On Wed, Jan 21, 2015 at 04:48:10PM +0530, Shobhit Kumar wrote: For scenarios where OF is not available, we can use panel identification by name. Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com --- drivers/gpu/drm/drm_panel.c | 18 ++ include/drm/drm_panel.h | 3

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread Jani Nikula
On Tue, 03 Feb 2015, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote: Spell all the PCI IDs out to be able to quickly grep for the IDs. No functional changes. On the other hand this is a loss of contextual information in the header

Re: [Intel-gfx] [PATCH] drm/i915: Don't bail out early on i915_handle_error

2015-02-03 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5702 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

[Intel-gfx] [PATCH] drm/i915: Don't bail out early on i915_handle_error

2015-02-03 Thread Mika Kuoppala
If we bail out from handling the error, we never wake up the waiters, resulting in a stuck processes. This regression was introduced in: commit b8d24a06568368076ebd5a858a011699a97bfa42 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Wed Jan 28 17:03:14 2015 +0200 drm/i915:

[Intel-gfx] Heavy black flickering with Intel graphics after VT switching from X

2015-02-03 Thread William Hua
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [1.] One line summary of the problem: Switching from an X VT to a Mir VT with Intel graphics causes heavy black flickering. [2.] Full description of the problem/report: This is a regression caused by

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Also detect eDRAM on SKL

2015-02-03 Thread Damien Lespiau
Suggested-by: Daniel Vetter dan...@ffwll.ch Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_uncore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index

[Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Start using frame buffer modifiers instead of object tiling mode for display purposes. To ensure compatibility with old userspace which is using set_tiling and does not know about frame buffer modifiers, the latter are faked internally when tile

[Intel-gfx] [RFC v2 0/4] Use framebuffer modifiers for tiled display

2015-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Instead of using driver private set tiling ioctl, use the proposed addfb2 ioctl extension to tell the driver about display buffer special formatting. Lightly tested only with a hacked up igt/testdisplay. v2: * Refactor the series to use

[Intel-gfx] [PATCH 2/4] drm/i915: Add tiled framebuffer modifiers

2015-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com To be used from the new addfb2 extension. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com --- include/uapi/drm/i915_drm.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/uapi/drm/i915_drm.h

[Intel-gfx] [PATCH 1/4] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-02-03 Thread Tvrtko Ursulin
From: Rob Clark robdcl...@gmail.com In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra flags.

[Intel-gfx] [PATCH 4/4] drm/i915: Announce support for framebuffer modifiers

2015-02-03 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Let the DRM core know we can handle it. v2: Change to boolean true. (Daniel Vetter) Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

2015-02-03 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5706 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -5 283/283

Re: [Intel-gfx] [PATCH] drm/i915: Skip Stolen Memory first page.

2015-02-03 Thread Ville Syrjälä
On Tue, Feb 03, 2015 at 04:11:05PM +, Siluvery, Arun wrote: On 01/08/2014 17:34, Jesse Barnes wrote: On Thu, 31 Jul 2014 12:08:20 -0700 Rodrigo Vivi rodrigo.v...@intel.com wrote: WA to skip the first page of stolen memory due to sporadic HW write on *CS Idle v2: Improve

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-03 Thread Rodrigo Vivi
On Tue, Feb 3, 2015 at 8:21 AM, Matt Roper matthew.d.ro...@intel.com wrote: On Tue, Feb 03, 2015 at 12:57:31PM +0100, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 03:38:16PM -0800, Rodrigo Vivi wrote: frontbuffer bits must be updated during commit times not on atomica prepare one, otherwise

Re: [Intel-gfx] sna: Experimental support for write-combining mmaps (wc-mmap)

2015-02-03 Thread Sedat Dilek
Ping? - Sedat - On Fri, Nov 14, 2014 at 11:04 AM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 13, 2014 at 04:28:46PM +0100, Sedat Dilek wrote: Hi, what is the status of drm-intel-wc-mmap patchset (#2 + #3)? I have refreshed them on top of drm-intel-coherent-phys-gtt patch (#1).

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-03 Thread Matt Roper
On Tue, Feb 03, 2015 at 10:46:49AM -0800, Rodrigo Vivi wrote: On Tue, Feb 3, 2015 at 8:21 AM, Matt Roper matthew.d.ro...@intel.com wrote: On Tue, Feb 03, 2015 at 12:57:31PM +0100, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 03:38:16PM -0800, Rodrigo Vivi wrote: frontbuffer bits must be

[Intel-gfx] [PATCH v2] tests/gem_userptr_blits: Race between close and invalidate

2015-02-03 Thread Michał Winiarski
It was possible for invalidate range start mmu notifier callback to race with releasing userptr object. If the object is released prior to taking a spinlock in the callback, we'll encounter a null pointer dereference. v2: Moved expressions inside igt_assert(), added mem barrier (Chris) Cc: Chris

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 11:14:10AM -0800, Matt Roper wrote: On Tue, Feb 03, 2015 at 10:46:49AM -0800, Rodrigo Vivi wrote: On Tue, Feb 3, 2015 at 8:21 AM, Matt Roper matthew.d.ro...@intel.com wrote: On Tue, Feb 03, 2015 at 12:57:31PM +0100, Daniel Vetter wrote: On Mon, Feb 02, 2015 at

Re: [Intel-gfx] [PATCH] drm/i915: Skip Stolen Memory first page.

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 07:40:21PM +0200, Ville Syrjälä wrote: On Tue, Feb 03, 2015 at 04:11:05PM +, Siluvery, Arun wrote: On 01/08/2014 17:34, Jesse Barnes wrote: On Thu, 31 Jul 2014 12:08:20 -0700 Rodrigo Vivi rodrigo.v...@intel.com wrote: WA to skip the first page of stolen

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 08:21:33AM -0800, Matt Roper wrote: On Tue, Feb 03, 2015 at 12:57:31PM +0100, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 03:38:16PM -0800, Rodrigo Vivi wrote: frontbuffer bits must be updated during commit times not on atomica prepare one, otherwise we have a

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 10:46:49AM -0800, Rodrigo Vivi wrote: On Tue, Feb 3, 2015 at 8:21 AM, Matt Roper matthew.d.ro...@intel.com wrote: On Tue, Feb 03, 2015 at 12:57:31PM +0100, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 03:38:16PM -0800, Rodrigo Vivi wrote: frontbuffer bits must be

Re: [Intel-gfx] sna: Experimental support for write-combining mmaps (wc-mmap)

2015-02-03 Thread Sedat Dilek
On Tue, Feb 3, 2015 at 8:24 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Feb 03, 2015 at 07:57:34PM +0100, Sedat Dilek wrote: Ping? It's upstream and enabled by default for kernel v3.20+. Thanks, I have looked into Linux-next (next-20150203) and see both patches: commit

[Intel-gfx] [regression in linux-next] i915: broken graphics on laptop

2015-02-03 Thread Andrey Skvortsov
Hi, tested next-20150202. System boots, but graphic output is broken (empty black screen). Booted five times the same kernel, always got the same result. The system works with 3.19-rc7. This is the first warning in the log: WARNING: CPU: 0 PID: 855 at drivers/gpu/drm/i915/intel_uncore.c:169

Re: [Intel-gfx] sna: Experimental support for write-combining mmaps (wc-mmap)

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 07:57:34PM +0100, Sedat Dilek wrote: Ping? It's upstream and enabled by default for kernel v3.20+. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] memcg, shmem: fix shmem migration to use lrucare. (was: Re: memcontrol.c BUG)

2015-02-03 Thread Johannes Weiner
On Mon, Feb 02, 2015 at 04:00:51PM +0100, Michal Hocko wrote: From: Michal Hocko mho...@suse.cz Date: Mon, 2 Feb 2015 15:22:19 +0100 Subject: [PATCH] memcg, shmem: fix shmem migration to use lrucare. It has been reported that 965GM might trigger VM_BUG_ON_PAGE(!lrucare PageLRU(oldpage),

[Intel-gfx] DELL Latitude e5540 Intel 4400 3rd display problem

2015-02-03 Thread Gergely Nógrádi
Dear Developers/Support! I can't configure the 2nd or 3rd display on my Dell Latitude e5540 notebook and Dell NB Port Replicator. I tried to connect DVI, DP and VGA to Port Replicator and it is working only in mirror mode. The only way to use 2 external display if I connect the DVI or DP to Port

[Intel-gfx] Multiple declarations for intel_fbc_enabled

2015-02-03 Thread Ed Maste
A FreeBSD developer discovered that intel_fbc_enabled has a declaration in two headers: sys/dev/drm2/i915/i915_drv.h:extern bool intel_fbc_enabled(struct drm_device *dev); sys/dev/drm2/i915/intel_drv.h:extern bool intel_fbc_enabled(struct drm_device *dev); We have a slightly older version of the

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use frame buffer modifiers for tiled display

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 05:22:31PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Start using frame buffer modifiers instead of object tiling mode for display purposes. To ensure compatibility with old userspace which is using set_tiling and does not know about

Re: [Intel-gfx] [regression in linux-next] i915: broken graphics on laptop

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 10:15:47PM +0300, Andrey Skvortsov wrote: Hi, tested next-20150202. System boots, but graphic output is broken (empty black screen). Booted five times the same kernel, always got the same result. The system works with 3.19-rc7. Those two warnings are more or less

Re: [Intel-gfx] [PATCH v2] tests/gem_userptr_blits: Race between close and invalidate

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 08:13:56PM +0100, Michał Winiarski wrote: It was possible for invalidate range start mmu notifier callback to race with releasing userptr object. If the object is released prior to taking a spinlock in the callback, we'll encounter a null pointer dereference. v2:

[Intel-gfx] [PATCH] drm/i915: Ensure plane-state-fb stays in sync with plane-fb

2015-02-03 Thread Matt Roper
plane-state-fb and plane-fb should always reference the same FB so that atomic and legacy codepaths have the same view of display state. In commit commit db068420560511de80ac59222644f2bdf278c3d5 Author: Matt Roper matthew.d.ro...@intel.com Date: Fri Jan 30 16:22:36 2015

[Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

2015-02-03 Thread Daniel Vetter
You can _never_ assert that a lock is not held, except in some very restricted corner cases where it's guranteed that your code is running single-threade (e.g. driver load before you've published any pointers leading to that lock). In addition the early return breaks a bunch of testcases since

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 11:49:00AM +0100, Daniel Vetter wrote: Aside: It is possible to check whether a given task doesn't hold a lock, but only when lockdep is enabled, using the lockdep_assert_held stuff. Bah. That's what I said, but a certain Daniel insists on using WARN_ON(). -Chris --

[Intel-gfx] [PATCH 2/4] drm/i915: Drop pipe_enable checks in vblank funcs

2015-02-03 Thread Daniel Vetter
With Ville's rework to use drm_crtc_vblank_on/off the core will take care of rejecting drm_vblank_get calls when the pipe is off. Also the core won't call the get_vblank_counter hooks in that case either. And since we've dropped ums support recently we can now remove these hacks, yay! Noticed

[Intel-gfx] [PATCH 4/4] drm/i915: Switch to drm_crtc variants of vblank functions

2015-02-03 Thread Daniel Vetter
Where possible right now. Just a small step towards nirvana ... Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 9 + drivers/gpu/drm/i915/intel_sprite.c | 4 ++-- 3 files changed, 8

[Intel-gfx] [PATCH 1/4] drm/irq: Add drm_crtc_vblank_reset

2015-02-03 Thread Daniel Vetter
At driver load we need to tell the vblank code about the state of the pipes, so that the logic around reject vblank_get when the pipe is off works correctly. Thus far i915 used drm_vblank_off, but one of the side-effects of it is that it also saves the vblank counter. And for that it calls down

[Intel-gfx] [PATCH 3/4] drm/i915: Flatten DRIVER_MODESET checks in i915_irq.c

2015-02-03 Thread Daniel Vetter
UMS is no more! Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 36 +++- 1 file changed, 11 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

2015-02-03 Thread Chris Wilson
On Tue, Feb 03, 2015 at 11:49:00AM +0100, Daniel Vetter wrote: You can _never_ assert that a lock is not held, except in some very restricted corner cases where it's guranteed that your code is running single-threade (e.g. driver load before you've published any pointers leading to that lock).

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 10:50:27AM +, Chris Wilson wrote: On Tue, Feb 03, 2015 at 11:49:00AM +0100, Daniel Vetter wrote: Aside: It is possible to check whether a given task doesn't hold a lock, but only when lockdep is enabled, using the lockdep_assert_held stuff. Bah. That's what I

Re: [Intel-gfx] [PATCH] drm/i915: Remove bogus locking check in the hangcheck code

2015-02-03 Thread Daniel Vetter
On Tue, Feb 03, 2015 at 11:00:56AM +, Chris Wilson wrote: On Tue, Feb 03, 2015 at 11:49:00AM +0100, Daniel Vetter wrote: You can _never_ assert that a lock is not held, except in some very restricted corner cases where it's guranteed that your code is running single-threade (e.g. driver

Re: [Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-02-03 Thread Tvrtko Ursulin
On 02/02/2015 08:17 PM, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 05:30:36PM +, Tvrtko Ursulin wrote: On 02/02/2015 05:15 PM, Daniel Vetter wrote: On Mon, Feb 02, 2015 at 10:36:30AM +, Tvrtko Ursulin wrote: On 02/02/2015 09:54 AM, Daniel Vetter wrote: On Fri, Jan 30, 2015 at

Re: [Intel-gfx] [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-02-03 Thread Daniel Thompson
On 28/01/15 12:54, Sumit Semwal wrote: At present, dma_buf_export() takes a series of parameters, which makes it difficult to add any new parameters for exporters, if required. Make it simpler by moving all these parameters into a struct, and pass the struct * as parameter to

Re: [Intel-gfx] [PATCH] drm/i915: Correct the variable holding the value for EOT to write

2015-02-03 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5700 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-02-03 Thread Rodrigo Vivi
On Thu, Jan 29, 2015 at 6:13 AM, Damien Lespiau damien.lesp...@intel.com wrote: We need to have a separate GT3 struct intel_device_info to declare they have a second VCS. Let's start by splitting the PCI ids per-GT. Signed-off-by: Damien Lespiau damien.lesp...@intel.com ---