Re: [Intel-gfx] [PATCH 5/9] drm/i915: also do frontbuffer tracking on pwrites

2015-02-12 Thread Paulo Zanoni
2015-02-11 6:30 GMT-02:00 Daniel Vetter dan...@ffwll.ch: On Mon, Feb 09, 2015 at 07:41:17PM +0100, Daniel Vetter wrote: On Mon, Feb 09, 2015 at 02:46:31PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com We need this for FBC, and possibly for PSR too. Reviewed-by:

[Intel-gfx] [PATCH v2 07/12] drm/i915: Read out display FIFO size on VLV/CHV

2015-02-12 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com VLV/CHV have similar DSPARB registers as older platforms, just more of them due to more planes. Add a bit of code to read out the current FIFO split from the registers. Will be useful later when we improve the WM calculations. v2: Add

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Add a hack to fix link training errors on pipe A+port B on CHV

2015-02-12 Thread Ville Syrjälä
On Wed, Feb 11, 2015 at 04:59:48PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com For some reason link training fails when port B is being driven by pipe A, and was previously driven by port B or the common lane was previously powered off.

[Intel-gfx] [RFC 2/2] drm/i915: Clean-up PPGTT on context destruction

2015-02-12 Thread rafael . barbalho
From: Rafael Barbalho rafael.barba...@intel.com With full PPGTT enabled an object's VMA entry into a PPGTT VM needs to be cleaned up so that the PPGTT PDE PTE allocations can be freed. This problem only shows up with full PPGTT because an object's VMA is only cleaned-up when the object is

[Intel-gfx] [RFC 0/2] Contain PPGTT memory leak/usage in true PPGTT mode

2015-02-12 Thread rafael . barbalho
From: Rafael Barbalho rafael.barba...@intel.com This particular memory leak, if I can call it that, shows itself when i915 is in true PPGTT mode and you share a buffer object to another hardware context using flink. In the failure case harware context A creates an object does some rendering to

[Intel-gfx] [RFC 1/2] drm/i915: Export active PPGTTs in debugfs

2015-02-12 Thread rafael . barbalho
From: Rafael Barbalho rafael.barba...@intel.com It's possible to gather up basic information on all active VMs. Signed-off-by: Rafael Barbalho rafael.barba...@intel.com Cc: Daniel Vetter dan...@ffwll.ch Cc: Jon Bloomfield jon.bloomfi...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 41

Re: [Intel-gfx] [PATCH] drm/i915: Add process identifier to requests

2015-02-12 Thread Chris Wilson
On Thu, Feb 12, 2015 at 10:26:02AM +0200, Mika Kuoppala wrote: We use the pid of the process which opened our device when we track which was the culprit of the gpu hang. But as that file descriptor might get inherited, we might blame the wrong process when we record the error state. Track

Re: [Intel-gfx] [PATCH] drm/i915: Check obj-vma_list under the struct_mutex

2015-02-12 Thread Chris Wilson
On Thu, Feb 12, 2015 at 10:43:44AM +0100, Daniel Vetter wrote: On Thu, Feb 12, 2015 at 07:53:18AM +, Chris Wilson wrote: When we walk the list of vma, or even for protecting against concurrent framebuffer creation, we must hold the struct_mutex or else a second thread can corrupt the

[Intel-gfx] [PATCH] drm/i915: Add process identifier to requests

2015-02-12 Thread Mika Kuoppala
We use the pid of the process which opened our device when we track which was the culprit of the gpu hang. But as that file descriptor might get inherited, we might blame the wrong process when we record the error state. Track process identifiers in requests to always find the correct offender.

Re: [Intel-gfx] [PATCH] drm/i915: Check obj-vma_list under the struct_mutex

2015-02-12 Thread Daniel Vetter
On Thu, Feb 12, 2015 at 07:53:18AM +, Chris Wilson wrote: When we walk the list of vma, or even for protecting against concurrent framebuffer creation, we must hold the struct_mutex or else a second thread can corrupt the list as we walk it. Fixes regression from commit

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Flatten DRIVER_MODESET checks in i915_irq.c

2015-02-12 Thread Imre Deak
On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: UMS is no more! Signed-off-by: Daniel Vetter daniel.vet...@intel.com Reviewed-by: Imre Deak imre.d...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 36 +++- 1 file changed, 11 insertions(+), 25

Re: [Intel-gfx] [PATCH 1/4] drm/irq: Add drm_crtc_vblank_reset

2015-02-12 Thread Imre Deak
On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: At driver load we need to tell the vblank code about the state of the pipes, so that the logic around reject vblank_get when the pipe is off works correctly. Thus far i915 used drm_vblank_off, but one of the side-effects of it is that

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Switch to drm_crtc variants of vblank functions

2015-02-12 Thread Imre Deak
On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: Where possible right now. Just a small step towards nirvana ... Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 9 +

Re: [Intel-gfx] [RFC 2/2] drm/i915: Clean-up PPGTT on context destruction

2015-02-12 Thread Chris Wilson
On Thu, Feb 12, 2015 at 08:05:02PM +, rafael.barba...@intel.com wrote: From: Rafael Barbalho rafael.barba...@intel.com With full PPGTT enabled an object's VMA entry into a PPGTT VM needs to be cleaned up so that the PPGTT PDE PTE allocations can be freed. This problem only shows up

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Drop pipe_enable checks in vblank funcs

2015-02-12 Thread Imre Deak
On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: With Ville's rework to use drm_crtc_vblank_on/off the core will take care of rejecting drm_vblank_get calls when the pipe is off. Also the core won't call the get_vblank_counter hooks in that case either. And since we've dropped ums

[Intel-gfx] [RFC 02/12] drm/i915/config: Introduce intel_output_name

2015-02-12 Thread Bob Paauwe
Human readable name for each output type to correspond with names used in the ACPI property tables. Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 57 drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed,

[Intel-gfx] [RFC 01/12] drm/i915/config: Initial framework

2015-02-12 Thread Bob Paauwe
This adds an init-time configuration framework that parses configuration data from an ACPI property table. The table is assumed to have well defined sub-device property tables that correspond to the various driver components. Initially the following sub-device tables are defined: CRTC (CRTC)

[Intel-gfx] [RFC 12/12] drm/i915/config: Add ACPI device examples for VBT configuration.

2015-02-12 Thread Bob Paauwe
Add VBT device sections with sample data to test the VBT parsing. Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/i915-properties.asl | 140 +++ drivers/gpu/drm/i915/i915-properties.hex | 622 +++ 2 files changed, 533 insertions(+), 229

[Intel-gfx] [RFC 05/12] drm/i915/config: Set general connector properties using config.

2015-02-12 Thread Bob Paauwe
Set the initial value of the force audio and broadcast rgb properties using property values found in the init-time configuration. Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/intel_modes.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [RFC 10/12] drm/i915/config: Introduce a test table and code to make use of it.

2015-02-12 Thread Bob Paauwe
Modify the table loading function to accept an included property table as a last resort. This can be used to create test cases. It may also be used to provide a static, compiled in configuration. A sample test table (source and compiled HEX version) are included in this commit. Signed-off-by:

[Intel-gfx] [RFC 08/12] drm/i915/config: Use workarounds list from configuration.

2015-02-12 Thread Bob Paauwe
If there are ACPI table based workarounds for a platform, use those instead of the built-in driver list when doing the workaround init. Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 19 +++ 1 file changed, 11 insertions(+), 8

[Intel-gfx] [RFC 04/12] drm/i915/config: Set dp panel fitter property based on init-time config.

2015-02-12 Thread Bob Paauwe
Use the init-time configuration setting for scaling_mode to set the initial value of the scaling_mode connector property. Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/intel_dp.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [RFC 11/12] drm/i915/config: Add workaround properties to ACPI table.

2015-02-12 Thread Bob Paauwe
Add the various workarounds as properties in the ACPI table. How these get processed and used is still TBD. Added broadwell and cherrytrail workarounds as examples. Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/i915-properties.asl | 50 +

[Intel-gfx] [RFC 07/12] drm/i915/config: Get workaround information from configuration.

2015-02-12 Thread Bob Paauwe
Add ability to parse a list of workarounds from the ACPI table. Initially, this expects all workarounds listed to be valid and they replace the hard coded list initialized in init_workarounds_ring(). The main benefit of this is the ability to add/remove workarounds at runtime. It may also be

[Intel-gfx] [RFC 06/12] drm/i915/config: Split out allocation of list nodes.

2015-02-12 Thread Bob Paauwe
We'll reduce some duplicate code if we move the list node allocation to its own function when we start processing future config items like workaround or vbt information. Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/intel_config.c | 49

[Intel-gfx] [RFC 03/12] drm/i915/config: Add init-time configuration of bits per color.

2015-02-12 Thread Bob Paauwe
Allow the init-time configuration to specify the bits per color value that gets used if bits per color is not present in EDID data (or if EDID is not present). Signed-off-by: Bob Paauwe bob.j.paa...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 14 ++ 1 file changed, 14

[Intel-gfx] [RFC 00/12] i915 init-time configuration.

2015-02-12 Thread Bob Paauwe
Background: This capability is targeted at deeply embedded appliance like devices that make use of Intel integrated graphics. There are a few use cases that are not currently supported by the i915 driver. For example, they may not be running userspace code that is capable of querying and

[Intel-gfx] [RFC 09/12] drm/i915/config: Add VBT settings configuration.

2015-02-12 Thread Bob Paauwe
Add a new section with subsections to the ACPI configuration table that mimics much of the information typically stored in the VBT/option ROM. This allows for a way to override incorrect VBT data or to provide the configuration if VBT is not present. Lack of VBT is common in embedded systems.

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-12 Thread Rodrigo Vivi
No, we had solved old frontbuffer false positives... some missing flush somewhere at that time... So, I added a bunch of printk and I insist that it is conceptually wrong to set intel_crtc_atomic_commit on check times when you do memset(intel_crtc-atomic, 0, sizeof(intel_crtc-atomic)); on every

Re: [Intel-gfx] [PATCH] drm/i915: Add process identifier to requests

2015-02-12 Thread Daniel Vetter
On Thu, Feb 12, 2015 at 08:51:20AM +, Chris Wilson wrote: On Thu, Feb 12, 2015 at 10:26:02AM +0200, Mika Kuoppala wrote: We use the pid of the process which opened our device when we track which was the culprit of the gpu hang. But as that file descriptor might get inherited, we might

Re: [Intel-gfx] [PATCH v2] drm/i915/skl: Implement WaDisableHBR2

2015-02-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5762 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 282/282

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Switch to drm_crtc variants of vblank functions

2015-02-12 Thread Daniel Vetter
On Fri, Feb 13, 2015 at 12:57:12AM +0200, Imre Deak wrote: On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: Where possible right now. Just a small step towards nirvana ... Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +-

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Drop pipe_enable checks in vblank funcs

2015-02-12 Thread Daniel Vetter
On Fri, Feb 13, 2015 at 12:37:27AM +0200, Imre Deak wrote: On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: With Ville's rework to use drm_crtc_vblank_on/off the core will take care of rejecting drm_vblank_get calls when the pipe is off. Also the core won't call the

Re: [Intel-gfx] [PATCH 1/4] drm/irq: Add drm_crtc_vblank_reset

2015-02-12 Thread Daniel Vetter
On Thu, Feb 12, 2015 at 11:56:50PM +0200, Imre Deak wrote: On Tue, 2015-02-03 at 11:30 +0100, Daniel Vetter wrote: At driver load we need to tell the vblank code about the state of the pipes, so that the logic around reject vblank_get when the pipe is off works correctly. Thus far i915

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Use a LRI for WaDisableDgMirrorFixInHalfSliceChicken5

2015-02-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5763 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915: More DPIO magic for CHV HDMI DP

2015-02-12 Thread Purushothaman, Vijay A
On 1/30/2015 4:39 PM, Ville Syrjälä wrote: On Fri, Jan 30, 2015 at 12:01:53AM +0530, Vijay Purushothaman wrote: This patch implements latest changes in Gain, lock threshold and integer co-efficient values using sideband r/w. Without these changes there will be signal integrity issues for both

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Use a LRI for WaDisableDgMirrorFixInHalfSliceChicken5

2015-02-12 Thread Nick Hoath
On 11/02/2015 18:21, Lespiau, Damien wrote: I have no idea how that crept in, but we need to do the write from the ring and this is a masked register. Two fixes in 1! Cc: Nick Hoath nicholas.ho...@intel.com Signed-off-by: Damien Lespiau damien.lesp...@intel.com Reviewed-by: Nick Hoath

Re: [Intel-gfx] [PATCH 5/9] drm/i915: also do frontbuffer tracking on pwrites

2015-02-12 Thread Jani Nikula
On Wed, 11 Feb 2015, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Feb 09, 2015 at 07:41:17PM +0100, Daniel Vetter wrote: On Mon, Feb 09, 2015 at 02:46:31PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com We need this for FBC, and possibly for PSR too.

[Intel-gfx] [PATCH] drm/i915: Fix an incorrect free rather than derefence issue.

2015-02-12 Thread Nick Hoath
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88652 Signed-off-by: Nick Hoath nicholas.ho...@intel.com --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_gem.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH] drm/i915: More DPIO magic for CHV HDMI DP

2015-02-12 Thread Purushothaman, Vijay A
On 2/10/2015 6:13 PM, Jani Nikula wrote: On Thu, 29 Jan 2015, Vijay Purushothaman vijay.a.purushotha...@linux.intel.com wrote: This patch implements latest changes in Gain, lock threshold and integer co-efficient values using sideband r/w. Without these changes there will be signal integrity

Re: [Intel-gfx] [PATCH 1/2] drm/i915/skl: Fix always true comparison in a revision id check

2015-02-12 Thread Nick Hoath
On 11/02/2015 18:21, Lespiau, Damien wrote: It's always a good idea to keep static analysis happy (also because it prompts doing the check like I proposed :), this time smatch complains: drivers/gpu/drm/i915/intel_ringbuffer.c:891 gen9_init_workarounds() warn: always true condition

Re: [Intel-gfx] [PATCH 07/18] drm/i915/skl: Implement WaSetDisablePixMaskCammingAndRhwoInCommonSliceChicken

2015-02-12 Thread Nick Hoath
On 09/02/2015 19:33, Damien Lespiau wrote: Signed-off-by: Damien Lespiau damien.lesp...@intel.com Reviewed-by: Nick Hoath nicholas.ho...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 4 drivers/gpu/drm/i915/intel_ringbuffer.c | 8 2 files changed, 12 insertions(+)

Re: [Intel-gfx] [PATCH 09/18] drm/i915/skl: Implement WaEnableLbsSlaRetryTimerDecrement

2015-02-12 Thread Nick Hoath
On 09/02/2015 19:33, Damien Lespiau wrote: This W/A is put in a gen9 specific function because it may well be needed on other gen9 platforms. Signed-off-by: Damien Lespiau damien.lesp...@intel.com Reviewed-by: Nick Hoath nicholas.ho...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 3

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Work around DISPLAY_PHY_CONTROL register corruption on CHV

2015-02-12 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5761 -Summary- Platform Delta drm-intel-nightly Series Applied PNV