Re: [Intel-gfx] [PATCH] drm/i915: Remove duplicated intel_fbc_update calls.

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6034 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 275/275

Re: [Intel-gfx] [PATCH 11/21 v2] drm/i915: Ensure planes begin with no scaler.

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:32PM -0700, Chandra Konduru wrote: > Signed-off-by: Chandra Konduru I'd squash this into patch 4, when you first added this field. Matt > --- > drivers/gpu/drm/i915/intel_display.c |2 ++ > drivers/gpu/drm/i915/intel_sprite.c |1 + > 2 files changed, 3 i

Re: [Intel-gfx] [PATCH 10/21 v2] drm/i915: Helper function to detach a scaler from a plane or crtc

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:31PM -0700, Chandra Konduru wrote: > This function is called from commit path of a plane or crtc. > It programs scaler registers to detach (aka. unbinds) scaler > from requested plane or crtc if it isn't in use. It also resets > scaler_id in crtc/plane state. > > v2:

Re: [Intel-gfx] [PATCH 09/21 v2] drm/i915: Add atomic function to setup scalers scalers for a crtc.

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:30PM -0700, Chandra Konduru wrote: > intel_atomic_setup_scalers sets up scalers based on staged scaling > requests coming from a crtc and its planes. This function should be > called from crtc level check path. > > If staged requests are supportable, function assigns

Re: [Intel-gfx] [PATCH 08/21 v2] drm/i915: Add helper function to update scaler_users in crtc_state

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:29PM -0700, Chandra Konduru wrote: > This helper function stages a scaler request for a plane/crtc into > crtc_state->scaler_users (which is a bit field). It also performs > required checks before staging any change into scaler_state. > > v2: > -updates to use single

Re: [Intel-gfx] [PATCH 04/21 v2] drm/i915: skylake scaler structure definitions

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:25PM -0700, Chandra Konduru wrote: > skylake scaler structure definitions. scalers live in crtc_state as > they are pipe resources. They can be used either as plane scaler or > panel fitter. > > scaler assigned to either plane (for plane scaling) or crtc (for panel >

Re: [Intel-gfx] [PATCH 07/21 v2] drm/i915: Helper function to update skylake scaling ratio.

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:28PM -0700, Chandra Konduru wrote: > Helper function updates supported scaling ratios based on cdclk and > crtc clocks. > > v2: > -update single copy of scaling ratios (Matt) > > Signed-off-by: Chandra Konduru > --- > drivers/gpu/drm/i915/intel_display.c | 25 +++

Re: [Intel-gfx] [PATCH 05/21 v2] drm/i915: Initialize skylake scalers

2015-03-24 Thread Matt Roper
On Fri, Mar 20, 2015 at 05:04:26PM -0700, Chandra Konduru wrote: > Initializing scalers with supported values during crtc init. > > v2: > -initialize single copy of min/max values (Matt) > > Signed-off-by: Chandra Konduru > --- > drivers/gpu/drm/i915/intel_display.c | 53 > ++

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Xi Ruoyao
On 03/25/2015 at 12:54 AM, Josh Boyer wrote: On Tue, Mar 24, 2015 at 12:49 PM, Daniel Vetter wrote: On Tue, Mar 24, 2015 at 05:48:31PM +0100, Daniel Vetter wrote: On Tue, Mar 24, 2015 at 12:10:28PM -0400, Josh Boyer wrote: On Tue, Mar 24, 2015 at 10:46 AM, Josh Boyer wrote: On Tue, Mar 24

Re: [Intel-gfx] [PATCH] drm/i915: make unsupported fb modifier message DRM_DEBUG

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6033 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 275/275

Re: [Intel-gfx] [PATCH i-g-t 1/2 v2] lib: Add media spin

2015-03-24 Thread He, Shuang
(He Shuang on behalf of Liu Lei) Tested-by: Lei,Liu lei.a@intel.com I-G-T test result: ./pm_sseu IGT-Version: 1.9-g07be8fe (x86_64) (Linux: 4.0.0-rc3_drm-intel-nightly_c09a3b_20150310+ x86_64) Subtest full-enable: SUCCESS (0.010s) Manually test result: SSEU Device Info Available Slice Total:

Re: [Intel-gfx] [PATCH 2/2] drm/i915/drrs: debugfs for notifying the fb status change

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6032 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 275/275

Re: [Intel-gfx] [PATCH] drm/i915: kill i915.powersave

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6044 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 269/269

Re: [Intel-gfx] [PATCH] drm/i915: PSR: Fix DP_PSR_NO_TRAIN_ON_EXIT logic

2015-03-24 Thread Runyan, Arthur J
I think there may be a restriction that we cannot set 0us to all the training patterns. I'll check on that. -Original Message- From: Rodrigo Vivi [mailto:rodrigo.v...@gmail.com] Sent: Tuesday, March 24, 2015 8:30 AM To: Vivi, Rodrigo Cc: intel-gfx; Runyan, Arthur J Subject: Re: [Intel-

[Intel-gfx] [PATCH i-g-t 2/2 v3] tests/pm_sseu: Create new test pm_sseu

2015-03-24 Thread jeff . mcgee
From: Jeff McGee New test pm_sseu is intended for any subtest related to the slice/subslice/EU power gating feature. The sole initial subtest, 'full-enable', confirms that the slice/subslice/EU state is at full enablement when the render engine is active. Starting with Gen9 SKL, the render power

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only enabled DRRS if PRS won't be enabled on this pipe.

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6043 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 269/269

Re: [Intel-gfx] [PATCH 2/2] drm/i915: eDP DRRS limited to only one panel at a time

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6031 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 275/275

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Enable PSR by default.

2015-03-24 Thread ch...@chris-wilson.co.uk
On Tue, Mar 24, 2015 at 08:55:04PM +, Vivi, Rodrigo wrote: > On Tue, 2015-03-24 at 10:08 +, Chris Wilson wrote: > > On Tue, Mar 24, 2015 at 11:03:30AM +0100, Daniel Vetter wrote: > > > On Mon, Mar 23, 2015 at 01:20:07PM -0700, Rodrigo Vivi wrote: > > > > Hi Daniel, > > > > > > > > Is somet

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix i915_dma_map_single positive error code

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6041 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 269/269

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix i915_dma_map_single positive error code

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6041 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 269/269

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Enable PSR by default.

2015-03-24 Thread Vivi, Rodrigo
On Tue, 2015-03-24 at 10:08 +, Chris Wilson wrote: > On Tue, Mar 24, 2015 at 11:03:30AM +0100, Daniel Vetter wrote: > > On Mon, Mar 23, 2015 at 01:20:07PM -0700, Rodrigo Vivi wrote: > > > Hi Daniel, > > > > > > Is something missing to enable it by default? > > > > Patch 1 has a small comment

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix race when clearing RPS IIR bits

2015-03-24 Thread Imre Deak
On Tue, 2015-03-24 at 09:24 +, Chris Wilson wrote: > On Tue, Mar 24, 2015 at 10:14:03AM +0100, Daniel Vetter wrote: > > On Mon, Mar 23, 2015 at 09:10:15PM +, Chris Wilson wrote: > > > On Mon, Mar 23, 2015 at 07:11:34PM +0200, Imre Deak wrote: > > > > When disabling RPS interrupts there is a

Re: [Intel-gfx] [PATCH] drm/i915: kill i915.powersave

2015-03-24 Thread Chris Wilson
On Tue, Mar 24, 2015 at 12:40:09PM -0700, Rodrigo Vivi wrote: > This flag was being mostly used as a meta flag in some > cases and not covering other cases. > > One of the risks is that it was masking some frontbuffer > trackings without disabling PSR. > > So, better to kill this at once and avoi

Re: [Intel-gfx] [PATCH 2/2] drm/i915: move clearing of RPS interrupt bits from disable to reset time

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6030 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 275/275

Re: [Intel-gfx] [PATCH v2 3/4] cpuidle: menu: use DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Rafael J. Wysocki
On Tuesday, March 24, 2015 02:03:44 PM Javi Merino wrote: > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > implementation and use the kernel one. Can you please CC patch [1/4] to me too at least, so I can see how the new macro is defined without digging it up from the en

[Intel-gfx] [PATCH] drm/i915: kill i915.powersave

2015-03-24 Thread Rodrigo Vivi
This flag was being mostly used as a meta flag in some cases and not covering other cases. One of the risks is that it was masking some frontbuffer trackings without disabling PSR. So, better to kill this at once and avoid umbrella parameters. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 2/2] drm/i915: Only enabled DRRS if PRS won't be enabled on this pipe.

2015-03-24 Thread Rodrigo Vivi
With PSR enabled being pre computed on pipe_config we can now prevent DRRS to be enabled along with PSR. Cc: Ramalingam C Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.

[Intel-gfx] [PATCH 1/2] drm/i915: Add psr_enabled on pipe_config

2015-03-24 Thread Rodrigo Vivi
Let's pre-compute it on pipe_config compute to let it exported there but also to use to see if we can enable DRRS. Cc: Chris Wilson Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 35 +++ drivers/gpu/drm/i915/intel_drv.h | 2 ++ driver

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add dynamic page trace events

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6040 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -3 269/269

Re: [Intel-gfx] [PATCH v2] i-g-t: Adding test case to test background color.

2015-03-24 Thread Konduru, Chandra
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Monday, March 02, 2015 9:54 AM > To: Konduru, Chandra > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v2] i-g-t: Adding test case to test background > colo

[Intel-gfx] Issues with Atomic Modesetting on Sandybridge

2015-03-24 Thread Mike Lothian
Hi Since [31c946e85ce6b48ce0f25e3cdca8362e4fe8b300] drm: If available use atomic state in getcrtc ioctl, X doesn't start correctly on my Sandybridge machine I've tried reverting this commit and my X session still starts up blank It only works again when I pass i915.nuclear_pageflip=0 - I realise

[Intel-gfx] [PATCH i-g-t] tests/drv_getparams: Skip instead of fail on EINVAL

2015-03-24 Thread jeff . mcgee
From: Jeff McGee Avoid failing on older kernels where the GETPARAM interfaces don't exist. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89669 Signed-off-by: Jeff McGee --- tests/drv_getparams.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/drv_g

Re: [Intel-gfx] [PATCH v2] drm/i915: Compare GGTT view structs instead of types

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6029 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 275/275

Re: [Intel-gfx] [Linux v4.0-rc5] Warnings in drm_framebuffer_reference() and drm_atomic_check_only()

2015-03-24 Thread Sedat Dilek
On Mon, Mar 23, 2015 at 9:25 AM, Daniel Vetter wrote: > On Mon, Mar 23, 2015 at 07:25:27AM +0100, Sedat Dilek wrote: >> Hi, >> >> I did my weekly update of the Linux RC (here: v4.0-rc5) and fell over >> some warning in the drm area. >> >> Please have a look... > Hi Daniel, > Just to confirm: Bot

Re: [Intel-gfx] [PATCH v2 2/4] clk: bcm/kona: use DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Alex Elder
On 03/24/2015 09:03 AM, Javi Merino wrote: > Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal > implementation and use the kernel one. > > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: Alex Elder Acked-by: Alex Elder > Signed-off-by: Javi Merino > --- > drivers/clk/bcm

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix up positive error code

2015-03-24 Thread Tvrtko Ursulin
On 03/24/2015 02:44 PM, Jani Nikula wrote: On Tue, 24 Mar 2015, Tvrtko Ursulin wrote: On 03/24/2015 01:16 PM, Jani Nikula wrote: On Tue, 24 Mar 2015, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It should have been negative since it is returned with ERR_PTR(). Please always reference the

[Intel-gfx] [PATCH v3] drm/i915: Fix i915_dma_map_single positive error code

2015-03-24 Thread Michel Thierry
i915_dma_map_single relies on dma_mapping_error, which returns positive error codes. Found by static checker. Introduced by commit 678d96fbb3b5995a2fdff2bca5e1ab4a40b7e968 ("drm/i915: Track GEN6 page table usage"). v2: Return negative error code and renamed commit title. (Dan) v3: Missing reporte

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Josh Boyer
On Tue, Mar 24, 2015 at 12:49 PM, Daniel Vetter wrote: > On Tue, Mar 24, 2015 at 05:48:31PM +0100, Daniel Vetter wrote: >> On Tue, Mar 24, 2015 at 12:10:28PM -0400, Josh Boyer wrote: >> > On Tue, Mar 24, 2015 at 10:46 AM, Josh Boyer >> > wrote: >> > > On Tue, Mar 24, 2015 at 10:34 AM, Daniel Vet

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix i915_dma_map_single positive error code

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 04:44:38PM +, Michel Thierry wrote: > i915_dma_map_single relies on dma_mapping_error, which returns positive > error codes. Found by static checker. > > Introduced by commit 678d96fbb3b5995a2fdff2bca5e1ab4a40b7e968 > ("drm/i915: Track GEN6 page table usage"). > > v2:

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix up positive error code

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6037 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 269/269

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 05:48:31PM +0100, Daniel Vetter wrote: > On Tue, Mar 24, 2015 at 12:10:28PM -0400, Josh Boyer wrote: > > On Tue, Mar 24, 2015 at 10:46 AM, Josh Boyer > > wrote: > > > On Tue, Mar 24, 2015 at 10:34 AM, Daniel Vetter wrote: > > >> On Tue, Mar 24, 2015 at 10:22:30AM -0400, J

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 12:10:28PM -0400, Josh Boyer wrote: > On Tue, Mar 24, 2015 at 10:46 AM, Josh Boyer > wrote: > > On Tue, Mar 24, 2015 at 10:34 AM, Daniel Vetter wrote: > >> On Tue, Mar 24, 2015 at 10:22:30AM -0400, Josh Boyer wrote: > >>> On Tue, Mar 24, 2015 at 9:57 AM, Josh Boyer > >>

[Intel-gfx] [PATCH v2] drm/i915: Fix i915_dma_map_single positive error code

2015-03-24 Thread Michel Thierry
i915_dma_map_single relies on dma_mapping_error, which returns positive error codes. Found by static checker. Introduced by commit 678d96fbb3b5995a2fdff2bca5e1ab4a40b7e968 ("drm/i915: Track GEN6 page table usage"). v2: Return negative error code and rename commit title. (Dan) Cc: Dan Carpenter

Re: [Intel-gfx] [PATCH 2/5] drm/i915: i915_dma_map_single returns positive error codes

2015-03-24 Thread Michel Thierry
On 3/24/2015 4:03 PM, Dan Carpenter wrote: On Tue, Mar 24, 2015 at 06:57:13PM +0300, Dan Carpenter wrote: diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 645c363..79ade6f 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Josh Boyer
On Tue, Mar 24, 2015 at 10:46 AM, Josh Boyer wrote: > On Tue, Mar 24, 2015 at 10:34 AM, Daniel Vetter wrote: >> On Tue, Mar 24, 2015 at 10:22:30AM -0400, Josh Boyer wrote: >>> On Tue, Mar 24, 2015 at 9:57 AM, Josh Boyer >>> wrote: >>> > On Tue, Mar 24, 2015 at 9:40 AM, Daniel Vetter wrote: >>>

Re: [Intel-gfx] [PATCH 2/5] drm/i915: i915_dma_map_single returns positive error codes

2015-03-24 Thread Dan Carpenter
On Tue, Mar 24, 2015 at 06:57:13PM +0300, Dan Carpenter wrote: > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > > b/drivers/gpu/drm/i915/i915_gem_gtt.c > > index 645c363..79ade6f 100644 > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > > @@ -348,7

Re: [Intel-gfx] [PATCH 7/7] drm/i915/skl: Take 90/270 rotation into account in watermark calculations

2015-03-24 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6028 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 275/275

Re: [Intel-gfx] [PATCH 2/5] drm/i915: i915_dma_map_single returns positive error codes

2015-03-24 Thread Dan Carpenter
On Tue, Mar 24, 2015 at 03:46:20PM +, Michel Thierry wrote: > i915_dma_map_single relies on dma_mapping_error, which returns positive > error codes. Found by static checker. > > Introduced by commit 678d96fbb3b5995a2fdff2bca5e1ab4a40b7e968 > ("drm/i915: Track GEN6 page table usage"). > Pleas

[Intel-gfx] [PATCH 2/5] drm/i915: i915_dma_map_single returns positive error codes

2015-03-24 Thread Michel Thierry
i915_dma_map_single relies on dma_mapping_error, which returns positive error codes. Found by static checker. Introduced by commit 678d96fbb3b5995a2fdff2bca5e1ab4a40b7e968 ("drm/i915: Track GEN6 page table usage"). Cc: Dan Carpenter Cc: Mika Kuoppala Signed-off-by: Michel Thierry --- drivers/

[Intel-gfx] [PATCH 3/5] drm/i915: Remove unnecessary gen6_ppgtt_unmap_pages

2015-03-24 Thread Michel Thierry
We are already unmapping them in gen6_ppgtt_free. This function became redundant since commit 06fda602dbca9c59d87db7da71192e4b54c9f5ff ("drm/i915: Create page table allocators"). Cc: Mika Kuoppala Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/i915_gem_gtt.c | 11 --- 1 file cha

[Intel-gfx] [PATCH 4/5] drm/i915: Finish gen6/7 dynamic page table allocation

2015-03-24 Thread Michel Thierry
This patch continues on the idea from "Track GEN6 page table usage". From here on, in the steady state, PDEs are all pointing to the scratch page table (as recommended in the spec). When an object is allocated in the VA range, the code will determine if we need to allocate a page for the page table

[Intel-gfx] [PATCH 5/5] drm/i915: Add dynamic page trace events

2015-03-24 Thread Michel Thierry
Traces for page directories and tables allocation and map. v2: Removed references to teardown. v3: bitmap_scnprintf has been deprecated. v4: Replace bitmap_scnprintf with scnprintf correctly, and get right range lengths. (Mika) Cc: Mika Kuoppala Signed-off-by: Michel Thierry --- drivers/gpu/dr

[Intel-gfx] [PATCH 1/5] drm/i915: Prevent out of range pt in gen6_for_each_pde

2015-03-24 Thread Michel Thierry
Found by static analysis tool, this was harmless as the pt was not used out of scope though. Introduced by commit 678d96fbb3b5995a2fdff2bca5e1ab4a40b7e968 ("drm/i915: Track GEN6 page table usage"). Cc: Mika Kuoppala Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/i915_gem_gtt.h | 6 +++-

[Intel-gfx] [PATCH 0/5] Finish gen6/7 ppgtt dynamic page allocations

2015-03-24 Thread Michel Thierry
The first 2 patches are fixes from the previous patchset, reported by static analysis tools, while the last 2 patches complete the required work for gen6/7. I've also started changing the authorship of the patches as suggested by Daniel. Michel Thierry (5): drm/i915: Prevent out of range pt in

Re: [Intel-gfx] [PATCH] drm/i915: PSR: Fix DP_PSR_NO_TRAIN_ON_EXIT logic

2015-03-24 Thread Rodrigo Vivi
Hi Durga, are you ok with this one? Hi Art, do you believe there is any risk of avoiding TP when panel tells DP_PSR_NO_TRAIN_ON_EXIT and link is disabled? I believe on the other discussion we conluded that DP_PSR_NO_TRAIN_ON_EXIT was only responsible for TP configurations regardless links standby

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Josh Boyer
On Tue, Mar 24, 2015 at 10:34 AM, Daniel Vetter wrote: > On Tue, Mar 24, 2015 at 10:22:30AM -0400, Josh Boyer wrote: >> On Tue, Mar 24, 2015 at 9:57 AM, Josh Boyer >> wrote: >> > On Tue, Mar 24, 2015 at 9:40 AM, Daniel Vetter wrote: >> >> On Tue, Mar 24, 2015 at 09:15:32AM -0400, Josh Boyer wro

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix up positive error code

2015-03-24 Thread Jani Nikula
On Tue, 24 Mar 2015, Tvrtko Ursulin wrote: > On 03/24/2015 01:16 PM, Jani Nikula wrote: >> On Tue, 24 Mar 2015, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> It should have been negative since it is returned with ERR_PTR(). >> >> Please always reference the commit that introduced the is

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 10:22:30AM -0400, Josh Boyer wrote: > On Tue, Mar 24, 2015 at 9:57 AM, Josh Boyer wrote: > > On Tue, Mar 24, 2015 at 9:40 AM, Daniel Vetter wrote: > >> On Tue, Mar 24, 2015 at 09:15:32AM -0400, Josh Boyer wrote: > >>> On Tue, Mar 24, 2015 at 3:32 AM, Daniel Vetter wrote:

Re: [Intel-gfx] [PATCH] drm/i915: make unsupported fb modifier message DRM_DEBUG

2015-03-24 Thread Jesse Barnes
On 03/24/2015 04:23 AM, Tvrtko Ursulin wrote: > > On 03/23/2015 07:43 PM, Jesse Barnes wrote: >> Or users can just spam the log all they want. >> >> References: https://bugs.freedesktop.org/show_bug.cgi?id=89628 >> Signed-off-by: Jesse Barnes >> --- >> drivers/gpu/drm/i915/intel_display.c | 4 +

Re: [Intel-gfx] [PATCH v2 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-24 Thread Jeff Epler
[for just patch 1/4; I didn't look as closely at the others] Reviewed-by: Jeff Epler ...with one half of a caveat (rounded up?): Like most or all of the originals, and like DIV_ROUND_CLOSEST just above it in kernel.h, the new code gives an incorrect answer if the temporary overflows at + un

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Josh Boyer
On Tue, Mar 24, 2015 at 9:57 AM, Josh Boyer wrote: > On Tue, Mar 24, 2015 at 9:40 AM, Daniel Vetter wrote: >> On Tue, Mar 24, 2015 at 09:15:32AM -0400, Josh Boyer wrote: >>> On Tue, Mar 24, 2015 at 3:32 AM, Daniel Vetter wrote: >>> > On Mon, Mar 23, 2015 at 02:34:27PM -0400, Josh Boyer wrote: >>

[Intel-gfx] [PATCH i-g-t] tests/gem_tiled_fence_blits: split into subtests

2015-03-24 Thread tim . gore
From: Tim Gore The gem_tiled_fence_blits test tends to get oom killed on low memory (< 4GB) Android systems. This is because the test tries to allocate (sysinfo.totalram * 9 / 10) in buffer objects and the remaining 10% of memory is not always enough for the Android system. As with a similar issu

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix up positive error code

2015-03-24 Thread Tvrtko Ursulin
On 03/24/2015 01:16 PM, Jani Nikula wrote: On Tue, 24 Mar 2015, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It should have been negative since it is returned with ERR_PTR(). Please always reference the commit that introduced the issue. Is there some more precisely defined criteria for "al

[Intel-gfx] [PATCH v2 4/4] media: cxd2820r: use DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Javi Merino
Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: Mauro Carvalho Chehab Acked-by: Antti Palosaari Reviewed-by: Antti Palosaari Signed-off-by: Javi Merino --- drivers/media/dvb-frontends/cxd2820r_c.c| 2 +- drivers/media/dvb-

[Intel-gfx] [PATCH v2 3/4] cpuidle: menu: use DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Javi Merino
Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: "Rafael J. Wysocki" Cc: Mel Gorman Cc: Stephen Hemminger Signed-off-by: Javi Merino --- drivers/cpuidle/governors/menu.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions

[Intel-gfx] [PATCH v2 2/4] clk: bcm/kona: use DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Javi Merino
Now that the kernel provides DIV_ROUND_CLOSEST_ULL(), drop the internal implementation and use the kernel one. Cc: Mike Turquette Cc: Stephen Boyd Cc: Alex Elder Signed-off-by: Javi Merino --- drivers/clk/bcm/clk-kona.c | 28 +++- drivers/clk/bcm/clk-kona.h | 1 - 2 f

[Intel-gfx] [PATCH v2 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-24 Thread Javi Merino
We have grown a number of different implementations of DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to kernel.h so that it can be reused. Cc: Jani Nikula Cc: David Airlie Cc: Guenter Roeck Cc: Andrew Morton Acked-by: Daniel Vetter Signed-off-by: Javi Merino --- drivers/gp

[Intel-gfx] [PATCH v2 0/4] Consolidate DIV_ROUND_CLOSEST_ULL()

2015-03-24 Thread Javi Merino
The kernel has grown a number of different implementations of DIV_ROUND_CLOSEST_ULL(). That is, a macro that does the same as DIV_ROUND_CLOSEST() but with the first operand being an unsigned long long. That means that you have to do the division using do_div() instead of using the C division oper

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Josh Boyer
On Tue, Mar 24, 2015 at 9:40 AM, Daniel Vetter wrote: > On Tue, Mar 24, 2015 at 09:15:32AM -0400, Josh Boyer wrote: >> On Tue, Mar 24, 2015 at 3:32 AM, Daniel Vetter wrote: >> > On Mon, Mar 23, 2015 at 02:34:27PM -0400, Josh Boyer wrote: >> >> On Mon, Mar 23, 2015 at 11:33 AM, Josh Boyer >> >>

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 09:15:32AM -0400, Josh Boyer wrote: > On Tue, Mar 24, 2015 at 3:32 AM, Daniel Vetter wrote: > > On Mon, Mar 23, 2015 at 02:34:27PM -0400, Josh Boyer wrote: > >> On Mon, Mar 23, 2015 at 11:33 AM, Josh Boyer > >> wrote: > >> > >> > >> > >> >> Xi Ruoyao (1): > >> >> d

[Intel-gfx] *ERROR* Hangcheck timer elapsed... render ring idle

2015-03-24 Thread Chris
I am hoping that by joining this list I can get some kind of assistance with this bug in the subject line. Every one to one and a half days my system will just lockup with a black screen and only the mouse cursor shown. It can be moved but will not go to the desktop. I can CTRL>ALT>F1 to a terminal

Re: [Intel-gfx] [git pull] drm fixes

2015-03-24 Thread Josh Boyer
On Tue, Mar 24, 2015 at 3:32 AM, Daniel Vetter wrote: > On Mon, Mar 23, 2015 at 02:34:27PM -0400, Josh Boyer wrote: >> On Mon, Mar 23, 2015 at 11:33 AM, Josh Boyer >> wrote: >> >> >> >> >> Xi Ruoyao (1): >> >> drm/i915: Ensure plane->state->fb stays in sync with plane->fb >> >> Turns out

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix up positive error code

2015-03-24 Thread Jani Nikula
On Tue, 24 Mar 2015, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It should have been negative since it is returned with ERR_PTR(). Please always reference the commit that introduced the issue. commit 50470bb011c4be278097670bea92462f4e8c8945 Author: Tvrtko Ursulin Date: Mon Mar 23 11:10:

Re: [Intel-gfx] [PATCH] drm/i915: Add fault address to error state for gen8 and gen9

2015-03-24 Thread Michel Thierry
On 3/24/2015 12:54 PM, Mika Kuoppala wrote: The faulting virtual address is >32bits and has been moved to different registers. Add to error state and output upper register first, in the same line for easy reconstruction of the fault address. v2: correct gen masking (Michel) v3: s/TBL/TLB (Ville)

[Intel-gfx] [PATCH] drm/i915: Add fault address to error state for gen8 and gen9

2015-03-24 Thread Mika Kuoppala
The faulting virtual address is >32bits and has been moved to different registers. Add to error state and output upper register first, in the same line for easy reconstruction of the fault address. v2: correct gen masking (Michel) v3: s/TBL/TLB (Ville) Signed-off-by: Mika Kuoppala --- drivers/g

Re: [Intel-gfx] [PATCH v2] drm/i915: Compare GGTT view structs instead of types

2015-03-24 Thread Joonas Lahtinen
The patch could be committed then with the R-B. On ma, 2015-03-23 at 13:39 +, Tvrtko Ursulin wrote: > On 03/23/2015 12:51 PM, Joonas Lahtinen wrote: > > Preparatory code to decrease amount of conflicts between rotated and > > partial views code. > > > > To allow for views where the view type i

Re: [Intel-gfx] [PATCH] drm/i915: Add fault address to error state for gen8 and gen9

2015-03-24 Thread Ville Syrjälä
On Tue, Mar 24, 2015 at 02:06:57PM +0200, Mika Kuoppala wrote: > The faulting virtual address is >32bits and has been moved > to different registers. Add to error state and output upper > register first, in the same line for easy reconstruction of > the fault address. > > v2: correct gen masking (

[Intel-gfx] [PATCH] drm/i915: Add fault address to error state for gen8 and gen9

2015-03-24 Thread Mika Kuoppala
The faulting virtual address is >32bits and has been moved to different registers. Add to error state and output upper register first, in the same line for easy reconstruction of the fault address. v2: correct gen masking (Michel) Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH i-g-t] quick_dump/skl: Add power well registers

2015-03-24 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tools/quick_dump/skl_powerwells.txt | 4 tools/quick_dump/skylake| 1 + 2 files changed, 5 insertions(+) create mode 100644 tools/quick_dump/skl_powerwells.txt diff --git a/tools/quick_dump/skl_powerwells.txt b/tools/quick_dump/skl_powerwells.

Re: [Intel-gfx] [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

2015-03-24 Thread Javi Merino
On Mon, Mar 23, 2015 at 05:04:16PM +, Javi Merino wrote: > On Mon, Mar 23, 2015 at 12:34:04PM +, Jeff Epler wrote: > > On Fri, Mar 20, 2015 at 11:14:40AM +, Javi Merino wrote: > > > +/* > > > + * Same as above but for u64 dividends. divisor must be a 32-bit > > > + * number. > > > + */

Re: [Intel-gfx] [PATCH] drm/i915: make unsupported fb modifier message DRM_DEBUG

2015-03-24 Thread Tvrtko Ursulin
On 03/23/2015 07:43 PM, Jesse Barnes wrote: Or users can just spam the log all they want. References: https://bugs.freedesktop.org/show_bug.cgi?id=89628 Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915/skl: Fix up positive error code

2015-03-24 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It should have been negative since it is returned with ERR_PTR(). Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_

Re: [Intel-gfx] drm/i915: Initialize all contexts

2015-03-24 Thread Dan Carpenter
Ugh... Sorry for that. Smatch is supposed to do cross function analysis but I seem to have broken something. I will investigate and silence this false positive. regards, dan carpenter ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use the CRC gpio for panel enable/disable

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 11:16 AM, Linus Walleij wrote: > On Tue, Mar 24, 2015 at 10:50 AM, Daniel Vetter wrote: >> On Tue, Mar 24, 2015 at 10:35:32AM +0100, Linus Walleij wrote: > >>> Some stuff may be needed to associate the regulator with the right >>> device indeed but nothing horribly complic

[Intel-gfx] [PATCH] drm/i915: Skip allocating shadow batch for 0-length batches

2015-03-24 Thread Chris Wilson
Since commit 17cabf571e50677d980e9ab2a43c5f11213003ae Author: Chris Wilson Date: Wed Jan 14 11:20:57 2015 + drm/i915: Trim the command parser allocations we may then try to allocate a zero-sized object and attempt to extract its pages. Understandably this fails. Testcase: igt/gem_exe

Re: [Intel-gfx] [PATCH 0/3] Hack to test DRRS, independent of front buffer tracking

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 03:17:35PM +0530, Ramalingam C wrote: > > On Tuesday 24 March 2015 03:05 PM, Daniel Vetter wrote: > >On Mon, Mar 23, 2015 at 11:14:41PM +0530, Ramalingam C wrote: > >>These patches removes the dependancy of DRRS with front buffer tracking. > >>This will help us to test the

Re: [Intel-gfx] [PATCH 49/49] drm/i915/bxt: Update max level of vswing

2015-03-24 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On 3/17/2015 3:10 PM, Imre Deak wrote: From: Vandana Kannan Broxton supports 3 voltage swing levels on all DP ports. Max level of pre-emphasis will be taken care with the existing code. v2: Patch rebased v3: (imre) - keep existing behavior for other plat

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use the CRC gpio for panel enable/disable

2015-03-24 Thread Linus Walleij
On Tue, Mar 24, 2015 at 10:50 AM, Daniel Vetter wrote: > On Tue, Mar 24, 2015 at 10:35:32AM +0100, Linus Walleij wrote: >> Some stuff may be needed to associate the regulator with the right >> device indeed but nothing horribly complicated. > > Nack, really. We've had an epic discussion at ks two

Re: [Intel-gfx] drm/i915: Initialize all contexts

2015-03-24 Thread Mika Kuoppala
Daniel Vetter writes: > On Mon, Mar 23, 2015 at 06:54:52PM +0300, Dan Carpenter wrote: >> Hello Ben Widawsky, >> >> This is a semi-automatic email about new static checker warnings. > > Adding Michel and Mika. > -Daniel > >> >> The patch 6702cf16e0ba: "drm/i915: Initialize all contexts" from Ma

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Enable PSR by default.

2015-03-24 Thread Chris Wilson
On Tue, Mar 24, 2015 at 11:03:30AM +0100, Daniel Vetter wrote: > On Mon, Mar 23, 2015 at 01:20:07PM -0700, Rodrigo Vivi wrote: > > Hi Daniel, > > > > Is something missing to enable it by default? > > Patch 1 has a small comment from me and latest version of patch 2 lacks an > r-b afaict. Hence wh

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Enable PSR by default.

2015-03-24 Thread Daniel Vetter
On Mon, Mar 23, 2015 at 01:20:07PM -0700, Rodrigo Vivi wrote: > Hi Daniel, > > Is something missing to enable it by default? Patch 1 has a small comment from me and latest version of patch 2 lacks an r-b afaict. Hence why I didn't pull in the series yet. But it's also a longer discussion, so ca y

Re: [Intel-gfx] [PATCH 0/3] Hack to test DRRS, independent of front buffer tracking

2015-03-24 Thread Ramalingam C
On Tuesday 24 March 2015 03:05 PM, Daniel Vetter wrote: On Mon, Mar 23, 2015 at 11:14:41PM +0530, Ramalingam C wrote: These patches removes the dependancy of DRRS with front buffer tracking. This will help us to test the DRRS and the IGT app for DRRS. As we have some functional issues with fro

Re: [Intel-gfx] [PATCH 1/2] gpio/crystalcove: Export Panel and backlight en/disable signals as GPIO

2015-03-24 Thread Linus Walleij
On Wed, Mar 18, 2015 at 2:27 PM, Daniel Vetter wrote: > On Wed, Mar 18, 2015 at 12:50:51PM +0100, Linus Walleij wrote: >> This is not a GPIO, this is a special purpose thing and IMO >> it should be modeled directly as a regulator. > > The idea behind reusing gpio was that we can reuse the dynamic

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use the CRC gpio for panel enable/disable

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 10:35:32AM +0100, Linus Walleij wrote: > On Tue, Mar 24, 2015 at 9:32 AM, Daniel Vetter wrote: > > > The crystalcove pmic thing here really is just a dumb gpio line that for > > the reference design gets routed to the panel (and hence has that as the > > usual name). > >

Re: [Intel-gfx] [RFC v5 1/9] drivers/mfd: Add lookup table for Panel Control as GPIO signal

2015-03-24 Thread Linus Walleij
On Thu, Mar 12, 2015 at 5:31 PM, Shobhit Kumar wrote: > On some Intel SoC platforms, the panel enable/disable signals are > controlled by CRC PMIC. Add those control as a new GPIO in a lookup > table for gpio-crystalcove chip during CRC driver load > > CC: Samuel Ortiz > Cc: Linus Walleij > Cc:

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Use the CRC gpio for panel enable/disable

2015-03-24 Thread Linus Walleij
On Tue, Mar 24, 2015 at 9:32 AM, Daniel Vetter wrote: > The crystalcove pmic thing here really is just a dumb gpio line that for > the reference design gets routed to the panel (and hence has that as the > usual name). So obviously the refman calls this register at offset 0x52 PANEL_EN/DISABLE n

Re: [Intel-gfx] [PATCH 0/3] Hack to test DRRS, independent of front buffer tracking

2015-03-24 Thread Daniel Vetter
On Mon, Mar 23, 2015 at 11:14:41PM +0530, Ramalingam C wrote: > These patches removes the dependancy of DRRS with front buffer tracking. > This will help us to test the DRRS and the IGT app for DRRS. > > As we have some functional issues with front buffer tracking, We are > adding a debugfs, so th

Re: [Intel-gfx] [PATCH 2/2] drm/i915: eDP DRRS limited to only one panel at a time

2015-03-24 Thread Daniel Vetter
On Tue, Mar 24, 2015 at 11:15:00AM +0530, Ramalingam C wrote: > Hi Siva, > > Since the same structure will be used to implement DRRS on DSI also we have > placed it at i915_dev_priv. > I am working on the RFC for the DRRS on DSI. I think a better approach would be to make an array of dev_priv->dr

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix race when clearing RPS IIR bits

2015-03-24 Thread Chris Wilson
On Tue, Mar 24, 2015 at 10:14:03AM +0100, Daniel Vetter wrote: > On Mon, Mar 23, 2015 at 09:10:15PM +, Chris Wilson wrote: > > On Mon, Mar 23, 2015 at 07:11:34PM +0200, Imre Deak wrote: > > > When disabling RPS interrupts there is a race where we disable RPS > > > inerrupts while the interrupt

Re: [Intel-gfx] [PATCH 48/49] drm/i915/bxt: VSwing programming sequence

2015-03-24 Thread Sivakumar Thulasimani
On 3/17/2015 3:10 PM, Imre Deak wrote: From: Vandana Kannan VSwing programming sequence as specified in the updated BXT BSpec ... ... +void bxt_ddi_vswing_sequence(struct drm_device *dev, u32 level, +enum port port, int type) +{ + struct drm_i915_private

  1   2   >