Re: [Intel-gfx] [PATCH] drm/i915: Fix build warning on 32-bit

2015-08-14 Thread Chris Wilson
On Fri, Aug 14, 2015 at 12:35:23PM +0200, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com The gtt.stolen_size field is of type size_t, and so should be printed using %zu to avoid build warnings on either 32-bit and 64-bit builds. Or better would be to convert stolen.size to u32

Re: [Intel-gfx] [PATCH 1/2] Revert drm/i915: Add eDP intermediate frequencies for CHV

2015-08-14 Thread Jani Nikula
On Wed, 12 Aug 2015, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Aug 12, 2015 at 04:02:17PM +0300, Ville Syrjälä wrote: On Wed, Aug 12, 2015 at 05:31:55PM +0530, Sivakumar Thulasimani wrote: On 8/12/2015 5:02 PM, Ville Syrjälä wrote: On Fri, Jul 31, 2015 at 11:32:52AM +0530,

Re: [Intel-gfx] [PATCH 1/2] Revert drm/i915: Add eDP intermediate frequencies for CHV

2015-08-14 Thread Sivakumar Thulasimani
On 8/14/2015 12:29 PM, Jani Nikula wrote: On Wed, 12 Aug 2015, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Aug 12, 2015 at 04:02:17PM +0300, Ville Syrjälä wrote: On Wed, Aug 12, 2015 at 05:31:55PM +0530, Sivakumar Thulasimani wrote: On 8/12/2015 5:02 PM, Ville Syrjälä wrote: On Fri, Jul

[Intel-gfx] [PATCH] drm/i915/skl: WaIgnoreDDIAStrap is forever, always init DDI A

2015-08-14 Thread Jani Nikula
There is currently conflicting documentation on which steppings the workaround is needed, up to C vs. forever. However there is post-C stepping hardware that doesn't report port presence on DDI A, leading to black screen on eDP. Assume the strap isn't connected, and try to enable DDI A on these

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Adding break for one case

2015-08-14 Thread Jani Nikula
On Thu, 13 Aug 2015, Xiong Zhang xiong.y.zh...@intel.com wrote: Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com Even for a small patch like this, your commit message is inadequate. First, it's obvious from the code that you're adding a break for one case. Instead, you should explain what bug

Re: [Intel-gfx] [PATCH] drm/i915: fix typo causing bad memory access in ring init

2015-08-14 Thread Chris Wilson
On Fri, Aug 14, 2015 at 12:13:04PM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This is validating from the wrong index. testing with KASAN found it. Reported-by: Dave Jones da...@codemonkey.org.uk Signed-off-by: Dave Airlie airl...@redhat.com ---

Re: [Intel-gfx] [PATCH v4 04/11] drm/i915: LVDS pixel clock check

2015-08-14 Thread Mika Kahola
On Fri, 2015-08-14 at 16:09 +0300, Ville Syrjälä wrote: On Fri, Aug 14, 2015 at 01:03:24PM +0300, Mika Kahola wrote: It is possible the we request to have a mode that has higher pixel clock than our HW can support. This patch checks if requested pixel clock is lower than the one supported

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bxt: work around HW coherency issue for cached GEM mappings

2015-08-14 Thread Imre Deak
On pe, 2015-08-14 at 14:11 +0100, Chris Wilson wrote: On Fri, Aug 14, 2015 at 03:38:57PM +0300, Imre Deak wrote: Due to a coherency issue on BXT A steppings we can't guarantee a coherent view of cached GPU mappings, so fall back to uncached mappings. Note that this still won't fix cases

Re: [Intel-gfx] [PATCH v2 0/2] drm/i915/bxt: work around HW coherency issue

2015-08-14 Thread Imre Deak
On pe, 2015-08-14 at 13:49 +0100, Chris Wilson wrote: On Fri, Aug 14, 2015 at 03:38:55PM +0300, Imre Deak wrote: This is a v2 of [1]. Since v1 the HW team confirmed that there is an HW issue in A steppings with the GPU/CPU snoop logic, which explains why we need this workaround. I've

Re: [Intel-gfx] [PATCH] drm/dp/mst: Remove port after removing connector.

2015-08-14 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7141 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/bxt: work around HW coherency issue when accessing GPU seqno

2015-08-14 Thread Imre Deak
On pe, 2015-08-14 at 14:12 +0100, Chris Wilson wrote: On Fri, Aug 14, 2015 at 03:38:56PM +0300, Imre Deak wrote: By running igt/store_dword_loop_render on BXT we can hit a coherency problem where the seqno written at GPU command completion time is not seen by the CPU. This results in

Re: [Intel-gfx] [PATCH v2 0/2] drm/i915/bxt: work around HW coherency issue

2015-08-14 Thread Chris Wilson
On Fri, Aug 14, 2015 at 04:26:29PM +0300, Imre Deak wrote: On pe, 2015-08-14 at 13:49 +0100, Chris Wilson wrote: On Fri, Aug 14, 2015 at 03:38:55PM +0300, Imre Deak wrote: This is a v2 of [1]. Since v1 the HW team confirmed that there is an HW issue in A steppings with the GPU/CPU snoop

Re: [Intel-gfx] [PATCH] drm/i915: fix typo causing bad memory access in ring init

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:40:47AM +0100, Chris Wilson wrote: On Fri, Aug 14, 2015 at 12:13:04PM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This is validating from the wrong index. testing with KASAN found it. Reported-by: Dave Jones da...@codemonkey.org.uk

Re: [Intel-gfx] [PATCH v3 03/11] drm/i915: HDMI pixel clock check

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 09:34:54PM +0300, Ville Syrjälä wrote: On Fri, Jul 31, 2015 at 03:13:52PM +0300, Mika Kahola wrote: It is possible the we request to have a mode that has higher pixel clock than our HW can support. This patch checks if requested pixel clock is lower than the one

Re: [Intel-gfx] [PATCH] ACPI / video: Fix circular lock dependency issue in the video-detect code

2015-08-14 Thread Rafael J. Wysocki
On Thursday, August 13, 2015 10:39:08 PM Sedat Dilek wrote: --f46d04447e7fc2306e051d3753a5 Content-Type: text/plain; charset=UTF-8 On Thu, Aug 13, 2015 at 6:53 PM, Hans de Goede hdego...@redhat.com wrote: Before this commit, the following would happen: a)

Re: [Intel-gfx] [PATCH 08/11] drm/i915: Add port A HPD support for IVB/HSW

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 06:44:17PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com As with ILK/SNB wire up the port A HPD on IVB/HSW. This might be more important on HSW with PSR. BSpec tells us that if the automagic link training performed by

Re: [Intel-gfx] [PATCH igt] lib/igt_draw: add support for RGB565 and XRGB2101010

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 06:33:55PM -0300, Paulo Zanoni wrote: We need to test those pixel formats on the FBC code, so let's make sure the drawing library works on them first. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com gtkdoc update seems to be missing for the igt_draw_rect change.

Re: [Intel-gfx] [PATCH v4] mmap on the dma-buf directly

2015-08-14 Thread Thomas Hellstrom
On 08/13/2015 01:29 AM, Tiago Vignatti wrote: Hi, The idea is to create a GEM bo in one process and pass the prime handle of the it to another process, which in turn uses the handle only to map and write. This could be useful for Chrome OS architecture, where the Web content (unpriviledged

Re: [Intel-gfx] [PATCH] drm/i915/skl: WaIgnoreDDIAStrap is forever, always init DDI A

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 10:53:17AM +0300, Jani Nikula wrote: There is currently conflicting documentation on which steppings the workaround is needed, up to C vs. forever. However there is post-C stepping hardware that doesn't report port presence on DDI A, leading to black screen on eDP.

Re: [Intel-gfx] [PATCH] sna: Fix the reduction of xy reflection onto rotations.

2015-08-14 Thread Chris Wilson
On Thu, Aug 13, 2015 at 04:51:37PM -0700, Bob Paauwe wrote: When reducing a xy reflection to a 180 degree rotation, make sure only one rotation bit is set. Also by rotating the bit left, we can support cases where xy reflection happens with 90/270 degree rotation. Signed-off-by: Bob Paauwe

Re: [Intel-gfx] [PATCH 0/7] drm/i915: Move DP link parameters out from intel_dp

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 07:04:22PM +0300, Ville Syrjälä wrote: On Mon, Jul 06, 2015 at 03:09:59PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com While working on CHV DPIO powergating I relized DP .compute_config() was clobbering lane_count

Re: [Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply

2015-08-14 Thread Jindal, Sonika
Looks good to me. Reviewed-by: Sonika Jindal sonika.jin...@intel.com -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Sivakumar Thulasimani Sent: Friday, August 7, 2015 3:15 PM To: dan...@ffwll.ch; intel-gfx@lists.freedesktop.org Subject:

Re: [Intel-gfx] [PATCH v3 08/11] drm/i915: TV pixel clock check

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 09:24:01PM +0300, Ville Syrjälä wrote: On Fri, Jul 31, 2015 at 03:13:57PM +0300, Mika Kahola wrote: It is possible the we request to have a mode that has higher pixel clock than our HW can support. This patch checks if requested pixel clock is lower than the one

Re: [Intel-gfx] [PATCH v3 09/11] drm/i915: DisplayPort-MST pixel clock check

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 09:49:12PM +0300, Ville Syrjälä wrote: On Fri, Jul 31, 2015 at 03:13:58PM +0300, Mika Kahola wrote: It is possible the we request to have a mode that has higher pixel clock than our HW can support. This patch checks if requested pixel clock is lower than the one

Re: [Intel-gfx] [PATCH 1/2 v2 addendum v2] drm/i915: Allow parsing of variable size child device entries from VBT

2015-08-14 Thread Jani Nikula
On Thu, 13 Aug 2015, David Weinehall david.weineh...@linux.intel.com wrote: On Wed, Aug 12, 2015 at 05:19:35PM +0300, Jani Nikula wrote: On Wed, 12 Aug 2015, David Weinehall david.weineh...@linux.intel.com wrote: Some more fixup is needed; the bits from Antti's patch that actually expanded

Re: [Intel-gfx] [PATCH 0/9 v6] Batch submission via GuC

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 07:35:10PM -0700, O'Rourke, Tom wrote: On Wed, Aug 12, 2015 at 07:57:37AM -0700, Gordon, David S wrote: On 12/08/15 15:43, Dave Gordon wrote: This patch series enables command submission via the GuC. In this mode, instead of the host CPU driving the execlist port

Re: [Intel-gfx] [PATCH 1/2 v2 addendum v2] drm/i915: Allow parsing of variable size child device entries from VBT

2015-08-14 Thread Timo Aaltonen
On 13.08.2015 16:14, David Weinehall wrote: On Wed, Aug 12, 2015 at 05:19:35PM +0300, Jani Nikula wrote: On Wed, 12 Aug 2015, David Weinehall david.weineh...@linux.intel.com wrote: Some more fixup is needed; the bits from Antti's patch that actually expanded the struct to fully fit the newer

Re: [Intel-gfx] [PATCH 18/18] gitignore: ignore more files

2015-08-14 Thread Daniel Vetter
On Thu, Aug 13, 2015 at 01:31:41PM -0700, Jesse Barnes wrote: git clean fixes this all, at least over here git status is clean. -Daniel --- .gitignore | 3 +++ tests/.gitignore | 13 + tools/.gitignore | 8 3 files changed, 24 insertions(+) diff --git

Re: [Intel-gfx] [4.2-rc4] acpi|drm|i915: circular locking dependency: acpi_video_get_backlight_type

2015-08-14 Thread Hans de Goede
Hi, On 13-08-15 16:33, Hans de Goede wrote: Hi, On 12-08-15 21:26, Ville Syrjälä wrote: On Mon, Aug 10, 2015 at 08:29:00PM +0200, Sedat Dilek wrote: On Sat, Aug 1, 2015 at 2:23 PM, Sedat Dilek sedat.di...@gmail.com wrote: On Mon, Jul 27, 2015 at 12:33 AM, Sedat Dilek sedat.di...@gmail.com

Re: [Intel-gfx] [PATCH 6/6 v3] drm/i915: Enable HDMI on DDI-E

2015-08-14 Thread Daniel Vetter
On Thu, Aug 13, 2015 at 02:57:38AM +, Zhang, Xiong Y wrote: On Wed, Aug 12, 2015 at 06:39:34PM +0800, Xiong Zhang wrote: DDI-E doesn't have the correspondent GMBUS pin. We rely on VBT to tell us which one it being used instead. The DVI/HDMI on shared port couldn't exist.

Re: [Intel-gfx] [PATCH v1 1/2] drm/i915: Contain the WA_REG macro

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 04:40:03PM +0100, Dave Gordon wrote: On 11/08/15 15:44, Arun Siluvery wrote: From: Mika Kuoppala mika.kuopp...@intel.com Prevent leaking the if scoping by containing the WA_REG macro inside its own scope. Reported-by: Arun Siluvery arun.siluv...@linux.intel.com

Re: [Intel-gfx] [PATCH v1 2/2] drm/i915/gen9: Disable gather at set shader bit

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 04:41:13PM +0100, Dave Gordon wrote: On 11/08/15 15:44, Arun Siluvery wrote: From Gen9, Push constant instruction parsing behaviour varies according to whether set shader is enabled or not. If we want legacy behaviour then it can be achieved by disabling set shader.

Re: [Intel-gfx] [PATCH] lib/rendercopy_gen9: Setup Push constant pointer before sending BTP commands

2015-08-14 Thread Daniel Vetter
On Thu, Aug 13, 2015 at 03:49:35PM -0700, Ben Widawsky wrote: On Thu, Aug 13, 2015 at 10:33:00AM +0300, Joonas Lahtinen wrote: Hi, On ke, 2015-08-12 at 18:35 -0700, Ben Widawsky wrote: On Wed, Aug 12, 2015 at 03:10:18PM +0300, Joonas Lahtinen wrote: On ke, 2015-08-12 at 12:26 +0100,

Re: [Intel-gfx] [PATCH 1/9 v6] drm/i915: GuC-specific firmware loader

2015-08-14 Thread Daniel Vetter
On Wed, Aug 12, 2015 at 03:43:36PM +0100, Dave Gordon wrote: From: Alex Dai yu@intel.com This fetches the required firmware image from the filesystem, then loads it into the GuC's memory via a dedicated DMA engine. This patch is derived from GuC loading work originally done by Vinit

Re: [Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:27:45AM +, Jindal, Sonika wrote: Looks good to me. Reviewed-by: Sonika Jindal sonika.jin...@intel.com Queued for -next, thanks for the patch. -Daniel -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Adding break for one case

2015-08-14 Thread Daniel Vetter
On Thu, Aug 13, 2015 at 01:37:49PM +0300, Timo Aaltonen wrote: On 13.08.2015 13:36, Timo Aaltonen wrote: On 13.08.2015 13:00, Xiong Zhang wrote: Signed-off-by: Xiong Zhang xiong.y.zh...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [Intel-gfx] [PATCH 07/18] tests/gem_ctx_exec: mark lrc lite restore as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:32 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:30PM -0700, Jesse Barnes wrote: Need some LRC tests in the 'basic' subset, and this is a good simple one. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org This is just a testcase for a very specific lrc corner

Re: [Intel-gfx] [PATCH 08/18] tests/gem_mmap: mark basic object creation tests as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:33 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote: We should be able to create small and moderate sized objects quickly and without errors. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org They're all super-fast basic testcases

Re: [Intel-gfx] [PATCH 06/18] tests/drv_suspend: mark sysfs tests as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:29 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:29PM -0700, Jesse Barnes wrote: debugfs may not be mounted, but sysfs should always be restored after suspend or hibernate. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org We already have a suspend/resume

Re: [Intel-gfx] [PATCH 11/18] tests/gem_tiled_pread/pwrite: mark normal tests as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:41 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:34PM -0700, Jesse Barnes wrote: These simple tests should always pass. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org Imo shouldn't be part of the basic set, they thrash the machine quite badly. Especially

[Intel-gfx] [PATCH igt] lib/ioctl_wrappers: handle ENODEV from from GEM_SET_CACHING ioctl

2015-08-14 Thread Imre Deak
The ENODEV return value was introduced to the GEM_SET_CACHING ioctl to mean that the given platform doesn't support the requested caching level (currently only due to a HW issues on BXT A steppings). Handle this as the other cases where we want to skip the related subtests. Signed-off-by: Imre

Re: [Intel-gfx] [PATCH 18/18] gitignore: ignore more files

2015-08-14 Thread Jesse Barnes
git clean updates the .gitignore file? Not having to run git clean is the whole point of this patch... On 08/14/2015 01:09 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:41PM -0700, Jesse Barnes wrote: git clean fixes this all, at least over here git status is clean. -Daniel ---

[Intel-gfx] [PATCH v3 5/7] tests: update core_getversion to run on any platform

2015-08-14 Thread Micah Fedke
--- tests/core_getversion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core_getversion.c b/tests/core_getversion.c index f994315..2f481c9 100644 --- a/tests/core_getversion.c +++ b/tests/core_getversion.c @@ -37,7 +37,7 @@ igt_simple_main int fd;

[Intel-gfx] [PATCH v3 4/7] tests: update core_get_client_auth to run on any platform

2015-08-14 Thread Micah Fedke
--- tests/core_get_client_auth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/core_get_client_auth.c b/tests/core_get_client_auth.c index 92313f9..3518bb7 100644 --- a/tests/core_get_client_auth.c +++ b/tests/core_get_client_auth.c @@ -84,7 +84,7 @@ igt_main {

Re: [Intel-gfx] [PATCH 01/18] tests/gem_storedw_loop: add new store_dword test to unify per-ring ones

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:19 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:24PM -0700, Jesse Barnes wrote: There was a lot of duplication going on... Mark as basic while we're at it as these should never fail. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- tests/Makefile.sources

Re: [Intel-gfx] [PATCH 05/18] tests/drv_getparams: mark EU and subslice fetch as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:27 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:28PM -0700, Jesse Barnes wrote: Fundamental and simple functionality. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org Mark entire testcase as basic instead to catch future extensions? getparams should always

[Intel-gfx] [PATCH v3 1/7] lib: adding drm_open_driver() interface

2015-08-14 Thread Micah Fedke
The drm_open_driver*() functions replace the drm_open_any*() functions and provide the same utility, but in a way that is platform agnostic, not intel-specific. This opens the path for adopting intel-gpu-tools to non-intel platforms. This commit renames the calls and adds the chipset parameter

[Intel-gfx] [PATCH v3 0/7] igt: adding parameter to drm_open_any and drm_open_any_master to allow specification of non-intel GPUs

2015-08-14 Thread Micah Fedke
Changes since last version of patch: Now using the core_* tests as demonstrations rather than drm_read. Micah Fedke (7): lib: adding drm_open_driver() interface convert drm_open_any*() calls to drm_open_driver*(DRIVER_INTEL) calls with cocci lib: remove support for deprecated

[Intel-gfx] [PATCH v3 7/7] tests: update core_getstats to run on any platform

2015-08-14 Thread Micah Fedke
--- tests/core_getstats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core_getstats.c b/tests/core_getstats.c index cdab0e5..6f6a4ee 100644 --- a/tests/core_getstats.c +++ b/tests/core_getstats.c @@ -48,7 +48,7 @@ igt_simple_main int fd, ret;

Re: [Intel-gfx] [PATCH 03/18] tests/drv_module_reload_basic: use linear_blits after module_reload for sanity check

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:22 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:26PM -0700, Jesse Barnes wrote: Reduces runtime a lot... Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- tests/drv_module_reload_basic | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v3 2/7] convert drm_open_any*() calls to drm_open_driver*(DRIVER_INTEL) calls with cocci

2015-08-14 Thread Micah Fedke
Apply the new API to all call sites within the test suite using the following semantic patch: // Semantic patch for replacing drm_open_any* with arch-specific drm_open_driver* calls @@ identifier i =~ \bdrm_open_any\b; @@ - i() + drm_open_driver(DRIVER_INTEL) @@ identifier i =~

[Intel-gfx] [PATCH v3 6/7] tests: update core_getclient to run on any platform

2015-08-14 Thread Micah Fedke
--- tests/core_getclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/core_getclient.c b/tests/core_getclient.c index d82e349..5293741 100644 --- a/tests/core_getclient.c +++ b/tests/core_getclient.c @@ -39,7 +39,7 @@ igt_simple_main int fd, ret;

[Intel-gfx] [PATCH v3 3/7] lib: remove support for deprecated drm_open_any*() calls

2015-08-14 Thread Micah Fedke
Signed-off-by: Micah Fedke micah.fe...@collabora.co.uk --- lib/drmtest.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/drmtest.h b/lib/drmtest.h index dcb0c34..41ddbe7 100644 --- a/lib/drmtest.h +++ b/lib/drmtest.h @@ -41,12 +41,6 @@ #define OPEN_ANY_GPU 0x1 #define DRIVER_INTEL

Re: [Intel-gfx] [PATCH 04/18] tests/drm_import_export: mark flink and prime tests as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:26 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:27PM -0700, Jesse Barnes wrote: They're testing basic functionality and don't involve stress or race induction. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org These are more stress-tests in nature I think. For

[Intel-gfx] [PATCH v3 1/2] drm/i915/bxt: work around HW coherency issue when accessing GPU seqno

2015-08-14 Thread Imre Deak
By running igt/store_dword_loop_render on BXT we can hit a coherency problem where the seqno written at GPU command completion time is not seen by the CPU. This results in __i915_wait_request seeing the stale seqno and not completing the request (not considering the lost interrupt/GPU reset

[Intel-gfx] [PATCH v3 2/2] drm/i915/bxt: don't allow cached GEM mappings on A stepping

2015-08-14 Thread Imre Deak
Due to a coherency issue on BXT A steppings we can't guarantee a coherent view of cached (CPU snooped) GPU mappings, so fail such requests. User space is supposed to fall back to uncached mappings in this case. v2: - limit the WA to A steppings, on later stepping this HW issue is fixed v3: -

Re: [Intel-gfx] [PATCH 13/18] tests/kms_vblank: mark accuracy test as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:44 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:36PM -0700, Jesse Barnes wrote: Need some simple vblank coverage in the BAT list. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org This testcase relies upon fbcon to have enabled pipe 0, which means it

Re: [Intel-gfx] [PATCH 15/18] tests/pm_rpm: mark RTE and D3 tests as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:50 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:38PM -0700, Jesse Barnes wrote: These always need to pass for basic PM functionality. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- tests/pm_rpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Intel-gfx] [PATCH v4 04/11] drm/i915: LVDS pixel clock check

2015-08-14 Thread Lukas Wunner
Hi Mika, On Fri, Aug 14, 2015 at 01:03:24PM +0300, Mika Kahola wrote: It is possible the we request to have a mode that has higher pixel clock than our HW can support. This patch checks if requested pixel clock is lower than the one supported by the HW. The requested mode is discarded if we

[Intel-gfx] [PATCH] drm/i915: Clear PIPE.STAT before IIR on VLV/CHV

2015-08-14 Thread Chris Wilson
The PIPE.STAT register contains some interrupt status bits per pipe, and if assert cause the corresponding bit in the IIR to be asserted (thus raising an interrupt). When handling an interrupt, we should clear the PIPE.STAT generator first before clearing the IIR so that we do not miss events or

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Adding Panel Filter function for DP

2015-08-14 Thread Ville Syrjälä
On Fri, Aug 14, 2015 at 05:12:57AM +, Zhang, Xiong Y wrote: On Mon, Aug 10, 2015 at 03:26:09PM +0800, Xiong Zhang wrote: Only internal eDP, LVDS, DVI screen could set scalling mode, some customers need to set scalling mode for external DP, HDMI, VGA screen. Let's fulfill this.

Re: [Intel-gfx] [PATCH 06/18] tests/drv_suspend: mark sysfs tests as basic

2015-08-14 Thread Jesse Barnes
On 08/14/2015 09:01 AM, Daniel Vetter wrote: On Fri, Aug 14, 2015 at 08:29:40AM -0700, Jesse Barnes wrote: On 08/14/2015 05:29 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:29PM -0700, Jesse Barnes wrote: debugfs may not be mounted, but sysfs should always be restored after suspend

Re: [Intel-gfx] [PATCH 0/4] Add support for Hyperlinks and Markup on kernel-doc

2015-08-14 Thread Danilo Cesar Lemes de Paula
On 08/13/2015 08:20 PM, Jonathan Corbet wrote: On Thu, 13 Aug 2015 20:09:35 -0300 Danilo Cesar Lemes de Paula danilo.ce...@collabora.co.uk wrote: Did you find time to take a look on this? No. Just when I thought things couldn't get crazier, my laptop died.

Re: [Intel-gfx] [PATCH] drm/core: Set mode to NULL when connectors in a set drops to 0.

2015-08-14 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7142 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -2

[Intel-gfx] [PULL] drm-intel-next

2015-08-14 Thread Daniel Vetter
Hi Dave, drm-intel-next-2015-07-31: - kerneldoc for tiling/swizzling/fencing code - bxt hpd port A w/a - various other fixes all over ... not much, everyone's on vacation. Cheers, Daniel The following changes since commit e0548f1979bfee900fb0671a5dd3a2f217dce5df: drm/i915: Update

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/bxt: don't allow cached GEM mappings on A stepping

2015-08-14 Thread Chris Wilson
On Fri, Aug 14, 2015 at 06:43:30PM +0300, Imre Deak wrote: Due to a coherency issue on BXT A steppings we can't guarantee a coherent view of cached (CPU snooped) GPU mappings, so fail such requests. User space is supposed to fall back to uncached mappings in this case. v2: - limit the WA

Re: [Intel-gfx] [PATCH 16/18] tests/kms_flip: add basic tests for flip, flip vs dpms, and flip modeset

2015-08-14 Thread Jesse Barnes
On 08/14/2015 05:56 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:39PM -0700, Jesse Barnes wrote: Simple variants that don't do multiple output or interruptible testing. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- tests/kms_flip.c | 11 ++- 1 file changed, 10

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/bxt: work around HW coherency issue when accessing GPU seqno

2015-08-14 Thread Chris Wilson
On Fri, Aug 14, 2015 at 06:35:27PM +0300, Imre Deak wrote: By running igt/store_dword_loop_render on BXT we can hit a coherency problem where the seqno written at GPU command completion time is not seen by the CPU. This results in __i915_wait_request seeing the stale seqno and not completing

Re: [Intel-gfx] [PATCH 18/18] gitignore: ignore more files

2015-08-14 Thread Jesse Barnes
On 08/14/2015 09:07 AM, Daniel Vetter wrote: On Fri, Aug 14, 2015 at 08:20:22AM -0700, Jesse Barnes wrote: git clean updates the .gitignore file? Not having to run git clean is the whole point of this patch... I looked at this patch first, but later noticed that you have a few renames

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/chv: Ack interrupts before handling them (CHV)

2015-08-14 Thread Chris Wilson
On Mon, Jun 16, 2014 at 04:11:00PM +0100, oscar.ma...@intel.com wrote: From: Oscar Mateo oscar.ma...@intel.com Otherwise, we might receive a new interrupt before we have time to ack the first one, eventually missing it. Without an atomic XCHG operation with mmio space, this patch merely

[Intel-gfx] [PATCH 16/16] drm/i915: reject invalid formats for FBC

2015-08-14 Thread Paulo Zanoni
This commit is essentially a rewrite of drm/i915: Check pixel format for fbc from Ville Syrjälä. The idea is the same, but the code is different due to all the changes that happened since his original patch. So any bugs are due to my bad rewrite. Testcases:

[Intel-gfx] [PATCH 03/16] drm/i915: fix FBC for cases where crtc-base.y is non-zero

2015-08-14 Thread Paulo Zanoni
I only tested this on BDW, but since the register description is the same ever since gen4, let's assume that all gens take the same register format. If that's not true, then hopefully someone will bisect a bug to this patch and we'll fix it. Notice that the wrong fence offset register just means

[Intel-gfx] [PATCH 12/16] drm/i915: apply WaFbcAsynchFlipDisableFbcQueue earlier

2015-08-14 Thread Paulo Zanoni
The spec says the register should have that value for the entire time that FBC is enabled, so apply the WA before we enable FBC. Notice that we also have this WA for ILK/SNB, but it is implemented at init_clock_gating(). I could move the IVB/HSW/BDW WA code to init_clock_gating() too, but since

[Intel-gfx] [PATCH 11/16] drm/i915/bdw: don't enable FBC when pixel rate exceeds 95%

2015-08-14 Thread Paulo Zanoni
BSpec says we shouldn't enable FBC on BDW when the pipe pixel rate exceeds 95% of the core display clock. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_fbc.c | 8 2 files changed, 9 insertions(+) diff --git

[Intel-gfx] [PATCH 09/16] drm/i915: print the correct amount of bytes allocated for the CFB

2015-08-14 Thread Paulo Zanoni
And also print the threshold. I was surprised to see a log message claiming the CFB size was 32mb when there was less than 24mb available for it. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/intel_fbc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-08-14 Thread Paulo Zanoni
Always update the currrent crtc, fb and vertical offset after calling enable_fbc. We were forgetting to do so along the failure paths when enabling fbc synchronously. Fix this with a new helper to enable_fbc() and update the state simultaneously. v2: Improve commit message (Chris).

[Intel-gfx] [PATCH 00/16] FBC bug fixes

2015-08-14 Thread Paulo Zanoni
Hello This series contains tons of bug fixes for FBC. Some of the patches on this series have seen the mailing list a few times already. With this series applied, my BDW machine passes all the FBC tests that are on IGT. This means we could even try to enable FBC on BDW by default, but I won't

Re: [Intel-gfx] [PATCH v1 2/2] drm/i915/gen9: Disable gather at set shader bit

2015-08-14 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7150 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Support DDI lane reversal for DP

2015-08-14 Thread Stéphane Marchesin
On Wed, Aug 5, 2015 at 12:34 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: On Jul 30 2015 or thereabouts, Sivakumar Thulasimani wrote: On 7/29/2015 8:52 PM, Benjamin Tissoires wrote: On Jul 29 2015 or thereabouts, Sivakumar Thulasimani wrote: why not detect reverse in

[Intel-gfx] [PATCH 15/16] Revert drm/i915: Allocate fbcon from stolen memory

2015-08-14 Thread Paulo Zanoni
This reverts commit 0ffb0ff283cca16f72caf29c44496d83b0c291fb. Technology has evolved and now we have eDP panels with 3200x1800 resolution. In the meantime, the BIOS guys didn't change the default 32mb for stolen memory. And we can't assume our users will be able to increase the default stolen

[Intel-gfx] [PATCH 07/16] drm/i915: disable FBC on FIFO underruns

2015-08-14 Thread Paulo Zanoni
If we want to try to enable FBC by default on any platform we need to be on the safe side and disable it in case we get an underrun while FBC is enabled on the corresponding pipe. We currently already have other reasons for FIFO underruns on our driver, but the ones I saw with FBC lead to black

[Intel-gfx] [PATCH 14/16] drm/i915: don't apply WaFbcAsynchFlipDisableFbcQueue on SKL

2015-08-14 Thread Paulo Zanoni
This WA is only for HSW/BDW. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/intel_fbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index b76c19f..5dfe460 100644 ---

[Intel-gfx] [PATCH 06/16] drm/i915: try a little harder to find an FBC CRTC

2015-08-14 Thread Paulo Zanoni
Keep searching in case the candidate has a NULL primary fb. This is only relevant for the platforms that don't have the pipe_a_only restriction. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/intel_fbc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[Intel-gfx] [PATCH 10/16] drm/i915: fix CFB size calculation

2015-08-14 Thread Paulo Zanoni
We were considering the whole framebuffer height, but the spec clearly says that we should only consider the active display height size. On my current testing machine, this moves us from 124 successes and 502 skips to 209 successes and 417 skips on kms_frontbuffer_tracking --fbc-only. The high

[Intel-gfx] [PATCH 01/16] drm/i915: make sure we're not changing the FBC CFB with FBC enabled

2015-08-14 Thread Paulo Zanoni
We used to have this bug in the past, but now that we properly track the size of the CFB, we don't have it anymore. Still, add the WARN just to make sure we don't go back to the bad state. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/intel_fbc.c | 2 ++ 1 file

[Intel-gfx] [PATCH 05/16] drm/i915: check for the supported strides on HSW+ FBC

2015-08-14 Thread Paulo Zanoni
I could only find the restrictions for HSW+, but I think it's safe to assume that the older platforms also can't support the configurations HSW can't support. The older platforms probably have additional restrictions, so we need to figure out those and implement them later. Let's not block HSW+

[Intel-gfx] [PATCH 08/16] drm/i915: avoid the last 8mb of stolen on BDW/SKL

2015-08-14 Thread Paulo Zanoni
The FBC hardware for these platforms doesn't have access to the bios_reserved range, so it always assumes the maximum (8mb) is used. So avoid this range while allocating. This solves a bunch of FIFO underruns that happen if you end up putting the CFB in that memory range. On my machine, with 32mb

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Adding DDI_E power well domain

2015-08-14 Thread Rodrigo Vivi
Sorry, but I don't get how this enables power_well_2 as well. I just see it enabling ddi A/E as the other. Maybe Paulo or Imre are the best one to review this. On Thu, Aug 13, 2015 at 2:54 AM Xiong Zhang xiong.y.zh...@intel.com wrote: From B spec, DDI_E port belong to PowerWell 2, but DDI_E

Re: [Intel-gfx] [PATCH 1/7] prime_mmap: Add new test for calling mmap() on dma-buf fds

2015-08-14 Thread Tiago Vignatti
Hi Daniel, On 08/13/2015 04:04 AM, Daniel Vetter wrote: On Wed, Aug 12, 2015 at 08:29:14PM -0300, Tiago Vignatti wrote: + /* Map too big */ + handle = gem_create(fd, BO_SIZE); + fill_bo(handle, BO_SIZE); + dma_buf_fd = prime_handle_to_fd(fd, handle); +

Re: [Intel-gfx] [PATCH] drm/dp/mst: Remove port after removing connector.

2015-08-14 Thread Dave Airlie
On 11 August 2015 at 17:54, Maarten Lankhorst maarten.lankho...@linux.intel.com wrote: The port is removed synchronously, but the connector delayed. This causes a use after free which can cause a kernel BUG with slug_debug=FPZU. This is fixed by freeing the port after the connector. Where is

Re: [Intel-gfx] [PATCH v2] drm/i915: clflush on pin_to_display after pwrite to UC bo in LLC

2015-08-14 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7152 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

Re: [Intel-gfx] [PATCH] drm/i915: Only dither on 6bpc panels

2015-08-14 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7155 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

Re: [Intel-gfx] [PATCH 06/18] tests/drv_suspend: mark sysfs tests as basic

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:29:40AM -0700, Jesse Barnes wrote: On 08/14/2015 05:29 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:29PM -0700, Jesse Barnes wrote: debugfs may not be mounted, but sysfs should always be restored after suspend or hibernate. Signed-off-by: Jesse

Re: [Intel-gfx] [PATCH 07/18] tests/gem_ctx_exec: mark lrc lite restore as basic

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:31:01AM -0700, Jesse Barnes wrote: On 08/14/2015 05:32 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:30PM -0700, Jesse Barnes wrote: Need some LRC tests in the 'basic' subset, and this is a good simple one. Signed-off-by: Jesse Barnes

Re: [Intel-gfx] [PATCH 15/18] tests/pm_rpm: mark RTE and D3 tests as basic

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:48:42AM -0700, Jesse Barnes wrote: On 08/14/2015 05:50 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:38PM -0700, Jesse Barnes wrote: These always need to pass for basic PM functionality. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org ---

Re: [Intel-gfx] [PATCH 08/18] tests/gem_mmap: mark basic object creation tests as basic

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:31:53AM -0700, Jesse Barnes wrote: On 08/14/2015 05:33 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote: We should be able to create small and moderate sized objects quickly and without errors. Signed-off-by: Jesse Barnes

Re: [Intel-gfx] [PATCH 18/18] gitignore: ignore more files

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:20:22AM -0700, Jesse Barnes wrote: git clean updates the .gitignore file? Not having to run git clean is the whole point of this patch... I looked at this patch first, but later noticed that you have a few renames where you don't update the .gitignore. On

Re: [Intel-gfx] [PATCH 01/18] tests/gem_storedw_loop: add new store_dword test to unify per-ring ones

2015-08-14 Thread Daniel Vetter
On Fri, Aug 14, 2015 at 08:21:12AM -0700, Jesse Barnes wrote: On 08/14/2015 05:19 AM, Daniel Vetter wrote: On Thu, Aug 13, 2015 at 01:31:24PM -0700, Jesse Barnes wrote: There was a lot of duplication going on... Mark as basic while we're at it as these should never fail. Signed-off-by:

[Intel-gfx] [PATCH] drm/i915: Fix build warning on 32-bit

2015-08-14 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The gtt.stolen_size field is of type size_t, and so should be printed using %zu to avoid build warnings on either 32-bit and 64-bit builds. Signed-off-by: Thierry Reding tred...@nvidia.com --- drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +- 1 file changed,

Re: [Intel-gfx] [PATCH 6/6 v3] drm/i915: Enable HDMI on DDI-E

2015-08-14 Thread Zhang, Xiong Y
On Thu, Aug 13, 2015 at 02:57:38AM +, Zhang, Xiong Y wrote: On Wed, Aug 12, 2015 at 06:39:34PM +0800, Xiong Zhang wrote: DDI-E doesn't have the correspondent GMBUS pin. We rely on VBT to tell us which one it being used instead. The DVI/HDMI on shared port couldn't

  1   2   >