Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 01/11] drm/i915: Adding the parsing logic for the i2c element

2015-09-21 Thread Deepak, M
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, September 17, 2015 2:48 PM >To: Deepak, M; intel-gfx@lists.freedesktop.org >Cc: Deepak, M >Subject: Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 01/11] drm/i915: Adding >the parsing logic for the i2

Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 03/11] drm/i915: Parsing VBT if size of VBT exceeds 6KB

2015-09-21 Thread Deepak, M
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, September 17, 2015 5:41 PM >To: Deepak, M; intel-gfx@lists.freedesktop.org >Cc: Deepak, M >Subject: Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 03/11] drm/i915: Parsing >VBT if size of VBT exceeds

Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 04/11] drm/i915: Using the approprite vbt size if vbt is not in mailbox4 of opregion

2015-09-21 Thread Deepak, M
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, September 17, 2015 5:48 PM >To: Deepak, M; intel-gfx@lists.freedesktop.org >Cc: Deepak, M >Subject: Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 04/11] drm/i915: Using >the approprite vbt size if vb

Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 05/11] drm/i915: Added support the v3 mipi sequence block

2015-09-21 Thread Deepak, M
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, September 17, 2015 8:09 PM >To: Deepak, M; intel-gfx@lists.freedesktop.org >Cc: Deepak, M >Subject: Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 05/11] drm/i915: Added >support the v3 mipi sequence

Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 04/11] drm/i915: Using the approprite vbt size if vbt is not in mailbox4 of opregion

2015-09-21 Thread Deepak, M
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, September 17, 2015 7:01 PM >To: Deepak, M; intel-gfx@lists.freedesktop.org >Cc: Deepak, M >Subject: Re: [Intel-gfx] [MIPI SEQ PARSING v2 PATCH 04/11] drm/i915: Using >the approprite vbt size if vb

[Intel-gfx] [PATCH] drm/fbdev: Update legacy plane->fb refcounting for atomic restore

2015-09-21 Thread Matt Roper
Starting with commit commit 28cc504e8d52248962f5b485bdc65f539e3fe21d Author: Rob Clark Date: Tue Aug 25 15:36:00 2015 -0400 drm/i915: enable atomic fb-helper I've been seeing some panics on i915 when the DRM master shuts down that appear to be caused by usi

[Intel-gfx] [PATCH 8/9] drm/i915: reject invalid formats for FBC

2015-09-21 Thread Paulo Zanoni
This commit is essentially a rewrite of "drm/i915: Check pixel format for fbc" from Ville Syrjälä. The idea is the same, but the code is different due to all the changes that happened since his original patch. So any bugs are due to my bad rewrite. v2: - Drop the alpha formats (Ville). v3: - D

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: WaRsUseTimeoutMode

2015-09-21 Thread O'Rourke, Tom
Hello, This change looks good but incomplete. When changing RC6 from EI mode to TO mode, should the time value in GEN6_RC6_THRESHOLD be changed to hold the timeout value instead of the evaluation interval period? Should the workaround name be included in a comment? While this workaround is unname

Re: [Intel-gfx] [PULL] topic/drm-misc

2015-09-21 Thread Dave Airlie
On 17 September 2015 at 00:45, Daniel Vetter wrote: > On Mon, Sep 14, 2015 at 8:22 AM, Daniel Vetter wrote: >> Hi Dave, >> >> -rc1 is out the door and here's my first pull request for drm-next. It's >> all over: >> - better atomic helpers for runtime pm drivers >> - atomic fbdev > > David Herrman

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915: WaRsDoubleRc6WrlWithCoarsePowerGating

2015-09-21 Thread Yu Dai
Looks good to me. Reviewed-by: Alex Dai On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: Cc: Tom O'Rourke Cc: Akash Goel Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_pm.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/int

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915: Program GuC MAX IDLE Count

2015-09-21 Thread Yu Dai
Looks good to me. Reviewed-by: Alex Dai On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: Cc: Alex Dai Cc: Tom O'Rourke Cc: Akash Goel Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/i915_guc_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertio

Re: [Intel-gfx] [PATCH v2 1/7] drm/i915: Add IS_SKL_GT3 and IS_SKL_GT4 macro.

2015-09-21 Thread Yu Dai
Looks good to me. Reviewed-by: Alex Dai On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: It will be usefull to specify w/a that affects only SKL GT3 and GT4. Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/i915_drv.h | 5 + 1 file changed, 5 insertions(+) diff --git a/driver

Re: [Intel-gfx] [PATCH v2 7/7] drm/i915/bxt: WaGsvDisableTurbo

2015-09-21 Thread Yu Dai
Looks good to me. Reviewed-by: Alex Dai On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: Disable Turbo on steppings prior to B0 on BXT due to hangs seen during GT CPD exit. Change-Id: I50c5c03f59f5ba092db19e17234951d89db42c6c Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH v2 2/7] drm/i915: WaRsDisableCoarsePowerGating

2015-09-21 Thread Yu Dai
Looks good to me. Reviewed-by: Alex Dai On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: WaRsDisableCoarsePowerGating: Coarse Power Gating (CPG) needs to be disabled for platforms prior to BXT B0 and SKL GT3/GT4 till E0. v2: Added GT3/GT4 Check. Change-Id: Ia3c4c16e050c88d3e259f601054875c812d

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Direct all DE interrupts to host.

2015-09-21 Thread O'Rourke, Tom
On Fri, Sep 11, 2015 at 05:44:32AM -0700, Kamble, Sagar A wrote: > Due to flip interrupts routed to GuC, GuC stays awake always and GT does not > enter RC6. > GuC firmware should re-direct to GuC those interrupts that it can handle. > > v2: Commit message change and routing all interrupts to host

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/guc: Notify coarse power gating configuration to GuC properly

2015-09-21 Thread Yu Dai
This one can be discarded and I will amend a fix to my other patch series. Thanks, Alex On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: From: Alex Dai GuC expects two bits for Render and Media domain separately when driver sends data via host2guc SAMPLE_FORCEWAKE when full coarse power gatin

Re: [Intel-gfx] [PATCH v2 3/7] drm/i915: WaRsUseTimeoutMode

2015-09-21 Thread Yu Dai
Looks good to me. Reviewed-by: Alex Dai On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: Enable TO mode for RC6 for SKL till D0 and BXT till A0. Cc: Tom O'Rourke Cc: Akash Goel Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_pm.c | 13 ++--- 1 file changed, 10 ins

Re: [Intel-gfx] [git pull] drm for 4.3

2015-09-21 Thread Dave Jones
On Mon, Sep 07, 2015 at 02:45:59PM -0400, Dave Jones wrote: > On Fri, Sep 04, 2015 at 11:40:53PM +0100, Dave Airlie wrote: > > > > Hi Linus, > > > > This is the main pull request for the drm for 4.3. Nouveau is probably > the biggest > > amount of changes in here, since it missed 4.2

[Intel-gfx] [PATCH] drm/i915/skl+: Fix Watermark calculation for Broxton

2015-09-21 Thread Kumar, Mahesh
In case of Y-Tiling, "plane_blocks_per_line" calculation is different than X/None-Tiling case. This patch corrects this calculation according to Bspec. plane blocks per line = Plane memory format is Y tile ? ceiling[4 * plane bytes per line / 512]/4 : ceiling

[Intel-gfx] [PATCH] drm/i915/skl: Correct other-pipe watermark update condition check

2015-09-21 Thread Kumar, Mahesh
If ddb allocation for planes in current CRTC is changed, that doesn't lead to ddb allocation change for other CRTCs, because our DDB allocation is not dynamic according to plane parameters, ddb is allocated according to number of CRTC enabled, & divided equally among CTRC's. In current condition c

Re: [Intel-gfx] [PATCH 2/2] drm/i915/bxt: eDP low vswing support

2015-09-21 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On 9/18/2015 2:11 PM, Sonika Jindal wrote: Adding voltage swing table for edp to support low vswings. Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_ddi.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bxt: Set oscaledcompmethod to enable scale value

2015-09-21 Thread Sivakumar Thulasimani
Reviewed-by: Sivakumar Thulasimani On 9/18/2015 2:11 PM, Sonika Jindal wrote: Bspec update tells that we have to enable oscaledcompmethod instead of ouniqetrangenmethod for enabling scale value during swing programming. Also, scale value is 'don't care' for other levels except the last entry tr

Re: [Intel-gfx] [PATCH 3/5] drm/i915: WaRsDisableCoarsePowerGating

2015-09-21 Thread Yu Dai
On 08/23/2015 05:22 AM, Sagar Arun Kamble wrote: WaRsDisableCoarsePowerGating: Coarse Power Gating (CPG) needs to be disabled for platforms prior to BXT B0 and till SKL E0. Change-Id: Ia3c4c16e050c88d3e259f601054875c812d69c3a Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_p

Re: [Intel-gfx] [PATCH 35/43] drm/i915: Move __raw_i915_read8() & co. into i915_drv.h

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 21, 2015 at 09:26:11AM -0700, Jesse Barnes wrote: > On 09/18/2015 12:26 PM, Ville Syrjälä wrote: > > On Fri, Sep 18, 2015 at 07:44:34PM +0100, Chris Wilson wrote: > > Yeah I guess that was a crappy example. Trying to think of a better one, > > I figure execlist status could be read from

Re: [Intel-gfx] [PATCH 2/5] drm/i915/bxt: WaGsvDisableTurbo

2015-09-21 Thread Yu Dai
Looks fine to me. Reviewed by: Alex Dai . On 08/23/2015 05:22 AM, Sagar Arun Kamble wrote: Disable Turbo on steppings prior to B0 on BXT due to hangs seen during GT CPD exit. Change-Id: I50c5c03f59f5ba092db19e17234951d89db42c6c Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Increase maximum polling time to 50ms for forcewake request/clear ack

2015-09-21 Thread Yu Dai
Looks fine to me. Reviewed by: Alex Dai . On 08/23/2015 05:22 AM, Sagar Arun Kamble wrote: On BXT, We Observe timeout for forcewake request completion with 2ms polling period as given here: [drm:fw_domains_get] ERROR render: timed out waiting for forcewake ack request. Polling for 50ms is recom

Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/guc: Notify coarse power gating configuration to GuC properly

2015-09-21 Thread Yu Dai
On 09/11/2015 09:47 PM, Sagar Arun Kamble wrote: From: Alex Dai GuC expects two bits for Render and Media domain separately when driver sends data via host2guc SAMPLE_FORCEWAKE when full coarse power gating is enabled. Bit 0 is for Render and bit 1 is for Media domain. Signed-off-by: Alex Da

Re: [Intel-gfx] [PATCH 35/43] drm/i915: Move __raw_i915_read8() & co. into i915_drv.h

2015-09-21 Thread Jesse Barnes
On 09/21/2015 09:53 AM, Ville Syrjälä wrote: > On Mon, Sep 21, 2015 at 09:26:11AM -0700, Jesse Barnes wrote: >> On 09/18/2015 12:26 PM, Ville Syrjälä wrote: >>> On Fri, Sep 18, 2015 at 07:44:34PM +0100, Chris Wilson wrote: >>> Yeah I guess that was a crappy example. Trying to think of a better one,

Re: [Intel-gfx] [PATCH 04/23] drm: Add drm structures for palette color property

2015-09-21 Thread Ville Syrjälä
On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote: > From: Kausal Malladi > > This patch adds new structures in DRM layer for Palette color > correction.These structures will be used by user space agents > to configure appropriate number of samples and Palette LUT for > a platform.

Re: [Intel-gfx] [PATCH 35/43] drm/i915: Move __raw_i915_read8() & co. into i915_drv.h

2015-09-21 Thread Jesse Barnes
On 09/18/2015 12:26 PM, Ville Syrjälä wrote: > On Fri, Sep 18, 2015 at 07:44:34PM +0100, Chris Wilson wrote: > Yeah I guess that was a crappy example. Trying to think of a better one, > I figure execlist status could be read from memory, but apparently > that's just mmio. I guess the context update

Re: [Intel-gfx] [PATCH 09/15] drm/i915: Add NV12 support to intel_framebuffer_init

2015-09-21 Thread Konduru, Chandra
> > > > + if (mode_cmd->modifier[1] == I915_FORMAT_MOD_Y_TILED > > && > > > > + ((mode_cmd->offsets[1] / mode_cmd->pitches[1]) % > > 4)) { > > > > + DRM_DEBUG("tile-Y uv offset 0x%x isn't 4-line > > aligned\n", > > > > +

[Intel-gfx] [PATCH v2] drm/i915: Clean up associated VMAs on context destruction

2015-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Prevent leaking VMAs and PPGTT VMs when objects are imported via flink. Scenario is that any VMAs created by the importer will be left dangling after the importer exits, or destroys the PPGTT context with which they are associated. This is caused by object destruction not r

[Intel-gfx] [PATCH v2 04/43] drm/i915: Parametrize fence registers

2015-09-21 Thread ville . syrjala
From: Ville Syrjälä v2: Hide the 945 vs. rest of gen2/3 difference in the macro Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_gem_fence.c | 41 +++ drivers/gpu/drm/i915/i915_gpu_error.c | 21 +++--- drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH 9/9] drm/i915: fix FBC for cases where crtc->base.y is non-zero

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 14, 2015 at 03:20:03PM -0300, Paulo Zanoni wrote: > I only tested this on BDW and SKL, but since the register description > is the same ever since gen4, let's assume that all gens take the same > register format. If that's not true, then hopefully someone will > bisect a bug to this pat

Re: [Intel-gfx] [PATCH 8/9] drm/i915: reject invalid formats for FBC

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 14, 2015 at 03:20:02PM -0300, Paulo Zanoni wrote: > This commit is essentially a rewrite of "drm/i915: Check pixel format > for fbc" from Ville Syrjälä. The idea is the same, but the code is > different due to all the changes that happened since his original > patch. So any bugs are due

Re: [Intel-gfx] [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result

2015-09-21 Thread Jani Nikula
On Mon, 21 Sep 2015, Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 > > Signed-off-by: Andr

Re: [Intel-gfx] [PATCH 5/9] drm/i915: don't enable FBC when pixel rate exceeds 95% on HSW/BDW

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 14, 2015 at 03:19:59PM -0300, Paulo Zanoni wrote: > BSpec says we shouldn't enable FBC on HSW/BDW when the pipe pixel rate > exceeds 95% of the core display clock. > > v2: > - HSW also needs the WA (Ville). > - Add the WA name (Ville). > - Use the current cdclk (Ville). > > Sign

Re: [Intel-gfx] [PATCH 3/9] drm/i915: avoid the last 8mb of stolen on BDW/SKL

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 14, 2015 at 03:19:57PM -0300, Paulo Zanoni wrote: > The FBC hardware for these platforms doesn't have access to the > bios_reserved range, so it always assumes the maximum (8mb) is used. > So avoid this range while allocating. > > This solves a bunch of FIFO underruns that happen if yo

Re: [Intel-gfx] [PATCH] drm/i915/skl: Don't clear all watermarks when updating. (v2)

2015-09-21 Thread Damien Lespiau
On Tue, Jul 21, 2015 at 10:42:53AM -0700, Bob Paauwe wrote: > Clearing the watermarks for all pipes/planes when updating the > watermarks for a single CRTC change seems like the wrong thing to > do here. As is, this code will ony update any pipe/plane watermarks > that need updating and leave the r

Re: [Intel-gfx] [PATCH 2/9] drm/i915: check for the supported strides on HSW+ FBC

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 14, 2015 at 03:19:56PM -0300, Paulo Zanoni wrote: > Don't allow FBC for cases where the spec says we can't FBC. > > v2: > - Just WARN_ON() the strides that should have been caught earlier > (Daniel) > - Make it a new function since I expect this to grow more. > v3: > - Docume

[Intel-gfx] [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result

2015-09-21 Thread Andrzej Hajda
The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/intel_lrc.c | 7 +++

[Intel-gfx] [PATCH 00/38] Fixes related to incorrect usage of unsigned types

2015-09-21 Thread Andrzej Hajda
Hi, This is set of independent patches. The only connection between them is that they try to address problems spotted by proposed coccinelle semantic patch unsigned_lesser_than_zero.cocci[1]. Semantic patch finds comparisons of types: unsigned < 0 unsigned >= 0 The former is always false,

Re: [Intel-gfx] [PATCH] drm/i915: Remove extraneous request cancel.

2015-09-21 Thread Tvrtko Ursulin
On 09/21/2015 02:02 PM, Nick Hoath wrote: Remove extraneous request cancel in request allocation failure path in intel_lr_context_deferred_alloc (Tvrtko Ursulin) Signed-off-by: Nick Hoath Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 1 - 1 file changed, 1 deletion(-) diff --

Re: [Intel-gfx] [PATCH 04/43] drm/i915: Parametrize fence registers

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 21, 2015 at 03:33:00PM +0300, Ville Syrjälä wrote: > On Mon, Sep 21, 2015 at 10:45:46AM +0300, Jani Nikula wrote: > > On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > Signed-off-by: Ville Syrjälä > > > --- > > > drivers/gpu/drm/i915/i915

[Intel-gfx] [PATCH] drm/i915: Only disable visible planes in intel_crtc_disable_planes

2015-09-21 Thread Maarten Lankhorst
This is fix for a regression introduced by 27321ae88c70104df "drm/i915: Use the disable callback for disabling planes." Disabling invisible planes may cause recalculation of watermarks, which is a problem because the software state is not yet in sync with the hardware state. This may result in a b

[Intel-gfx] [PATCH] drm/i915: Remove extraneous request cancel.

2015-09-21 Thread Nick Hoath
Remove extraneous request cancel in request allocation failure path in intel_lr_context_deferred_alloc (Tvrtko Ursulin) Signed-off-by: Nick Hoath Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/driver

Re: [Intel-gfx] Revert "sna: Coldplug unknown connections as well"

2015-09-21 Thread Chris Wilson
On Mon, Sep 21, 2015 at 02:48:03PM +0200, Sedat Dilek wrote: > On Mon, Sep 21, 2015 at 11:42 AM, Chris Wilson > wrote: > > On Sun, Sep 20, 2015 at 08:20:21PM +0200, Sedat Dilek wrote: > >> Hi, > >> > >> I am here on Ubuntu/precise AMD64 with libdrm v2.4.65 and mesa v10.6.8. > >> > >> I cannot see

Re: [Intel-gfx] Revert "sna: Coldplug unknown connections as well"

2015-09-21 Thread Sedat Dilek
On Mon, Sep 21, 2015 at 11:42 AM, Chris Wilson wrote: > On Sun, Sep 20, 2015 at 08:20:21PM +0200, Sedat Dilek wrote: >> Hi, >> >> I am here on Ubuntu/precise AMD64 with libdrm v2.4.65 and mesa v10.6.8. >> >> I cannot see my LightDM login-manager, my system hangs in VT-1. >> >> When I revert... >>

Re: [Intel-gfx] [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us

2015-09-21 Thread Imre Deak
On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote: > From: Akash Goel > > Signed-off-by: Ankitprasad Sharma > Signed-off-by: Akash Goel > Signed-off-by: Sagar Arun Kamble > --- > drivers/gpu/drm/i915/i915_reg.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --gi

Re: [Intel-gfx] [PATCH 04/43] drm/i915: Parametrize fence registers

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 21, 2015 at 10:45:46AM +0300, Jani Nikula wrote: > On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/i915_gem_fence.c | 42 > > +-- > > drivers/gpu/d

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move scanline_offset and timestamping constant setup to intel_modeset_readout_hw_state()

2015-09-21 Thread Maarten Lankhorst
Hey, Op 14-09-15 om 16:23 schreef Ville Syrjälä: > On Mon, Sep 14, 2015 at 01:57:45PM +0200, Maarten Lankhorst wrote: >> Op 10-09-15 om 17:59 schreef ville.syrj...@linux.intel.com: >>> From: Ville Syrjälä >>> >>> intel_modeset_readout_hw_state() seems like the more appropriate place >>> for popul

Re: [Intel-gfx] [PATCH] drm/i915/bxt: Update revision id for BXT C0

2015-09-21 Thread Imre Deak
On pe, 2015-09-18 at 17:52 +0100, Arun Siluvery wrote: > Cc: Nick Hoath > Cc: Imre Deak > Signed-off-by: Arun Siluvery Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/dr

Re: [Intel-gfx] [PATCH 0/4] NV12 rotation GTT handling prep work

2015-09-21 Thread Ville Syrjälä
On Mon, Sep 21, 2015 at 10:45:31AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > GTT page remapping logic for 90/270 rotation needs some > extensions to support NV12 90/270 rotation work which is > currently underway. > > Main thing is really to support building of the rotated > page m

[Intel-gfx] [PATCH v3 1/1] drm/i915/bxt: WaGsvDisableTurbo

2015-09-21 Thread Sagar Arun Kamble
Disable Turbo on steppings prior to B0 on BXT due to hangs seen during GT CPD exit. v3: Explicitly clear the Turbo control register (Akash) Change-Id: I50c5c03f59f5ba092db19e17234951d89db42c6c Signed-off-by: Akash Goel Signed-off-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_pm.c | 20

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Enable querying offset of UV plane with intel_plane_obj_offset

2015-09-21 Thread Joonas Lahtinen
On ma, 2015-09-21 at 10:45 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > v2: Rebase. > > Signed-off-by: Tvrtko Ursulin > Reviewed-by: Joonas Lahtinen > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 2 ++ > drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + > drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Support NV12 in rotated GGTT mapping

2015-09-21 Thread Joonas Lahtinen
On ma, 2015-09-21 at 10:45 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Just adding the rotated UV plane at the end of the rotated Y plane. > > v2: Rebase. > > > Signed-off-by: Tvrtko Ursulin > One comment below, otherwise. Reviewed-by: Joonas Lahtinen > --- > drivers/gpu/drm

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Mon, Sep 21, 2015 at 12:43:36PM +0200, Patrik Jakobsson wrote: > On Thu, Sep 17, 2015 at 02:14:37PM +0300, Ville Syrjälä wrote: > > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > > > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > > > > We need to be able to

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Support appending to the rotated pages mapping

2015-09-21 Thread Joonas Lahtinen
Hi, On ma, 2015-09-21 at 10:45 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > By providing a start offset into the source array of pages, and > returning the > end position in the scatter-gather table, we will be able to append > the UV > plane to the rotated mapping in later patches. >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Support planar formats in tile height calculations

2015-09-21 Thread Joonas Lahtinen
On ma, 2015-09-21 at 10:45 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This will be needed for NV12 support. > > v2: Rebase. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Joonas Lahtinen > --- > drivers/gpu/drm/i915/intel_display.c | 10 +- > drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Thu, Sep 17, 2015 at 02:14:37PM +0300, Ville Syrjälä wrote: > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > > > We need to be able to control if DC6 is allowed or not. Much like > > > requesting power to a s

Re: [Intel-gfx] [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in CRTC modeset

2015-09-21 Thread Shankar, Uma
>-Original Message- >From: Nikula, Jani >Sent: Friday, September 18, 2015 7:48 PM >To: Shankar, Uma; intel-gfx@lists.freedesktop.org >Cc: Kumar, Shobhit; Deak, Imre; Sharma, Shashank; Shankar, Uma >Subject: Re: [BXT MIPI PATCH v3 05/14] drm/i915/bxt: DSI encoder support in >CRTC modeset >

Re: [Intel-gfx] [BXT MIPI PATCH v3 11/14] drm/i915/bxt: Modify BXT BLC according to VBT changes

2015-09-21 Thread Shankar, Uma
>-Original Message- >From: Nikula, Jani >Sent: Friday, September 18, 2015 7:21 PM >To: Shankar, Uma; intel-gfx@lists.freedesktop.org >Cc: Kumar, Shobhit; Deak, Imre; Kamath, Sunil; Kannan, Vandana; Shankar, Uma >Subject: Re: [BXT MIPI PATCH v3 11/14] drm/i915/bxt: Modify BXT BLC >accordin

Re: [Intel-gfx] [PATCH] drm/i915: Split alloc from init for lrc

2015-09-21 Thread Tvrtko Ursulin
Hi, On 09/11/2015 12:53 PM, Nick Hoath wrote: > Extend init/init_hw split to context init. > - Move context initialisation in to i915_gem_init_hw > - Move one off initialisation for render ring to > i915_gem_validate_context > - Move default context initialisation to logical_

Re: [Intel-gfx] [BXT MIPI PATCH v3 14/14] drm/i915: Added BXT DSI backlight support

2015-09-21 Thread Shankar, Uma
>-Original Message- >From: Nikula, Jani >Sent: Friday, September 18, 2015 7:08 PM >To: Shankar, Uma; intel-gfx@lists.freedesktop.org >Cc: Kumar, Shobhit; Deak, Imre; Shankar, Uma >Subject: Re: [BXT MIPI PATCH v3 14/14] drm/i915: Added BXT DSI backlight >support > >On Tue, 01 Sep 2015, Uma

Re: [Intel-gfx] [BXT MIPI PATCH v3 12/14] drm/i915/bxt: Program Backlight PWM frequency

2015-09-21 Thread Shankar, Uma
>-Original Message- >From: Nikula, Jani >Sent: Friday, September 18, 2015 7:03 PM >To: Shankar, Uma; intel-gfx@lists.freedesktop.org >Cc: Kumar, Shobhit; Deak, Imre; Shankar, Uma >Subject: Re: [BXT MIPI PATCH v3 12/14] drm/i915/bxt: Program Backlight PWM >frequency > >On Tue, 01 Sep 2015,

Re: [Intel-gfx] [BXT MIPI PATCH v3 07/14] drm/i915/bxt: Program Tx Rx and Dphy clocks

2015-09-21 Thread Shankar, Uma
>-Original Message- >From: Nikula, Jani >Sent: Friday, September 18, 2015 6:58 PM >To: Shankar, Uma; intel-gfx@lists.freedesktop.org >Cc: Kumar, Shobhit; Deak, Imre; Sharma, Shashank; Shankar, Uma >Subject: Re: [BXT MIPI PATCH v3 07/14] drm/i915/bxt: Program Tx Rx and Dphy >clocks > >On T

Re: [Intel-gfx] [PATCH] drm/i915/skl: handle port E in cpt_digital_port_connected

2015-09-21 Thread Jani Nikula
On Mon, 21 Sep 2015, Mika Kuoppala wrote: > Jani Nikula writes: > >> SKL port E handling was added in >> >> commit 26951caf55d73ceb1967b0bf12f6d0b96853508e >> Author: Xiong Zhang >> Date: Mon Aug 17 15:55:50 2015 +0800 >> >> drm/i915/skl: enable DDI-E hotplug >> >> but the whole function w

[Intel-gfx] [PATCH 3/4] drm/i915: Support NV12 in rotated GGTT mapping

2015-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just adding the rotated UV plane at the end of the rotated Y plane. v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 37 ++-- drivers/gpu/drm/i915/i915_gem_gtt.h | 3 +++ drivers/gpu/drm/i915/intel_disp

[Intel-gfx] [PATCH 2/4] drm/i915: Support appending to the rotated pages mapping

2015-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By providing a start offset into the source array of pages, and returning the end position in the scatter-gather table, we will be able to append the UV plane to the rotated mapping in later patches. v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 1/4] drm/i915: Support planar formats in tile height calculations

2015-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This will be needed for NV12 support. v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 10 +- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 3 files changed, 7 insertions(+), 7 deleti

[Intel-gfx] [PATCH 4/4] drm/i915: Enable querying offset of UV plane with intel_plane_obj_offset

2015-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 ++ drivers/gpu/drm/i915/i915_gem_gtt.h | 1 + drivers/gpu/drm/i915/intel_display.c | 26 +- drivers/gpu/drm/i915/intel_drv.h | 4 +++- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 0/4] NV12 rotation GTT handling prep work

2015-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin GTT page remapping logic for 90/270 rotation needs some extensions to support NV12 90/270 rotation work which is currently underway. Main thing is really to support building of the rotated page mapping from two planes instead of one, and adding appropriate calculations for t

Re: [Intel-gfx] Revert "sna: Coldplug unknown connections as well"

2015-09-21 Thread Chris Wilson
On Sun, Sep 20, 2015 at 08:20:21PM +0200, Sedat Dilek wrote: > Hi, > > I am here on Ubuntu/precise AMD64 with libdrm v2.4.65 and mesa v10.6.8. > > I cannot see my LightDM login-manager, my system hangs in VT-1. > > When I revert... > > commit 650da13c7257019728cfca361dfcbe34a6c526ef > "sna: Col

Re: [Intel-gfx] [BXT MIPI PATCH v3 06/14] drm/i915/bxt: DSI enable for BXT

2015-09-21 Thread Shankar, Uma
On 9/18/2015 6:47 PM, Jani Nikula wrote: On Tue, 01 Sep 2015, Uma Shankar wrote: From: Shashank Sharma This patch contains following changes: 1. MIPI device ready changes to support dsi_pre_enable. Changes are specific to BXT device ready sequence. Added check for ULPS mode(No effec

Re: [Intel-gfx] [PATCH] drm/i915/skl: handle port E in cpt_digital_port_connected

2015-09-21 Thread Mika Kuoppala
Jani Nikula writes: > SKL port E handling was added in > > commit 26951caf55d73ceb1967b0bf12f6d0b96853508e > Author: Xiong Zhang > Date: Mon Aug 17 15:55:50 2015 +0800 > > drm/i915/skl: enable DDI-E hotplug > > but the whole function was moved in a another branch in > > commit b93433ccf648

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Mon, Sep 21, 2015 at 11:26:06AM +0300, Jani Nikula wrote: > On Mon, 21 Sep 2015, Patrik Jakobsson > wrote: > > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > >> On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > >> > We need to be able to control if DC6 is al

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Notify user about outdated dmc firmware

2015-09-21 Thread Mika Kuoppala
Jani Nikula writes: > On Fri, 18 Sep 2015, Mika Kuoppala wrote: >> If csr/dmc firmware is known to be outdated, notify >> user. > > What would break if we requested a firmware version that works? Or we've > made it so that we only request the major version because there's not > supposed to be ch

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Jani Nikula
On Mon, 21 Sep 2015, Patrik Jakobsson wrote: > On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: >> On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: >> > We need to be able to control if DC6 is allowed or not. Much like >> > requesting power to a specific piece of the

Re: [Intel-gfx] [RFC PATCH] drm/i915/skl: Add DC6 disabling as a power well

2015-09-21 Thread Patrik Jakobsson
On Wed, Sep 16, 2015 at 11:10:07PM +0300, Ville Syrjälä wrote: > On Fri, Sep 11, 2015 at 01:55:22PM +0200, Patrik Jakobsson wrote: > > We need to be able to control if DC6 is allowed or not. Much like > > requesting power to a specific piece of the hardware we need to be able > > to request that we

Re: [Intel-gfx] [PATCH 09/43] drm/i915: Parametrize DDI_BUF_TRANS registers

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > FIXME: Should there be a WARN(i != 9) or something, or what does the > entry 9 comment mean? Either the code, the comment, or both are bust. Needs to be checked. However, this patch does not change that part for

Re: [Intel-gfx] [PATCH 08/43] drm/i915: Parametrize TV luma/chroma filter registers

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 12 > drivers/gpu/drm/i915/intel_tv.c | 8 > 2 files changed, 8 insertions(+), 12 deletio

Re: [Intel-gfx] [PATCH 07/43] drm/i915: Replace raw numbers with the approproate register name in ILK turbo code

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_pm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/d

Re: [Intel-gfx] [PATCH 06/43] drm/i915: Parametrize ILK turbo registers

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 10 +- > drivers/gpu/drm/i915/intel_pm.c | 14 +++--- > 2 files changed, 12 insertions(+), 12 de

Re: [Intel-gfx] [PATCH 05/43] drm/i915: Parametrize FBC_TAG registers

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > drivers/gpu/drm/i915/intel_fbc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --

Re: [Intel-gfx] [PATCH 04/43] drm/i915: Parametrize fence registers

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_gem_fence.c | 42 > +-- > drivers/gpu/drm/i915/i915_gpu_error.c | 21 -- > drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH 02/43] drm/i915: Parametrize LRC registers

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_debugfs.c | 8 > drivers/gpu/drm/i915/intel_lrc.c| 8 +++- > drivers/gpu/drm/i915/intel_lrc.h| 6 ++

Re: [Intel-gfx] [PATCH 03/43] drm/i915: Parametrize GEN7_GT_SCRATCH and GEN7_LRA_LIMITS

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.c | 8 > drivers/gpu/drm/i915/i915_reg.h | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > d

Re: [Intel-gfx] [PATCH 01/43] drm/i915: Don't pass sdvo_reg to intel_sdvo_select_{ddc, i2c}_bus()

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_sdvo_select_ddc_bus() and intel_sdvo_select_i2c_bus() have no used > for the passed in 'reg', so just drop it. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/inte

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Notify user about outdated dmc firmware

2015-09-21 Thread Jani Nikula
On Fri, 18 Sep 2015, Mika Kuoppala wrote: > If csr/dmc firmware is known to be outdated, notify > user. What would break if we requested a firmware version that works? Or we've made it so that we only request the major version because there's not supposed to be changes like this between minor ver