Re: [Intel-gfx] [PATCH 3/4] drm/i915: Instrument PSR parameter for possible quirks with link standby.

2016-01-20 Thread Thulasimani, Sivakumar
On 1/20/2016 10:32 PM, Zanoni, Paulo R wrote: Em Sex, 2015-12-11 às 08:39 -0800, Rodrigo Vivi escreveu: Unfortunately we don't know all panels and platforms out there and we found internal prototypes without VBT proper set but where only link in standby worked well. :) if it is internal i assu

[Intel-gfx] [RFC 22/22] drm/i915/slpc: Add has_slpc to skylake info

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i915_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 975af35..9e37a98 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915

[Intel-gfx] [RFC 12/22] drm/i915/slpc: Send shutdown event

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Send SLPC shutdown event during disable, suspend, and reset operations. Sending shutdown event while already shutdown is OK. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_slpc.c | 45 --- 1 file changed, 42 insertions(+), 3 d

[Intel-gfx] [RFC 21/22] drm/i915/slpc: Add enable/disable debugfs for slpc

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Adds debugfs hooks for each slpc task. The enable/disable debugfs files are i915_slpc_dfps, i915_slpc_turbo, and i915_slpc_dcc. Each of these can take the values: "default", "enabled", or "disabled" Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i915_debugfs.c | 251

[Intel-gfx] [RFC 20/22] drm/i915/slpc: Add slpc support for max/min freq

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Update sysfs and debugfs functions to set SLPC parameters when setting max/min frequency. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i915_debugfs.c | 6 ++ drivers/gpu/drm/i915/i915_sysfs.c | 8 2 files changed, 14 insertions(+) diff --git a/drivers

[Intel-gfx] [RFC 08/22] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data

2016-01-20 Thread tom . orourke
From: Tom O'Rourke SLPC shared data is used to pass information to/from SLPC firmware. For Skylake, platform sku type and slice count are identified from device id and fuse values. Support for other platforms needs to be added. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_guc.h

[Intel-gfx] [RFC 04/22] drm/i915/slpc: Use intel_slpc_* functions if supported

2016-01-20 Thread tom . orourke
From: Tom O'Rourke On platforms with SLPC support: call intel_slpc_*() functions from corresponding intel_*_gt_powersave() functions; and do not use rps functions. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/Makefile | 5 +-- drivers/gpu/drm/i915/intel_pm.c | 36 +++

[Intel-gfx] [RFC 14/22] drm/i915/slpc: Notification of Display mode change

2016-01-20 Thread tom . orourke
From: Sagar Arun Kamble GuC SLPC need to be sent data related to Active pipes, refresh rates, widi pipes, fullscreen pipes related via host to GuC display mode change event. This patch defines the event and implements trigger of the event. Signed-off-by: Sagar Arun Kamble Acked-by: Tom O'Rourke

[Intel-gfx] [RFC 07/22] drm/i915/slpc: Enable SLPC in guc if supported

2016-01-20 Thread tom . orourke
From: Tom O'Rourke If HAS_SLPC, then add enable SLPC flag to guc control parameter during guc load. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_guc_loader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/int

[Intel-gfx] [RFC 06/22] drm/i915/slpc: If using SLPC, do not set frequency

2016-01-20 Thread tom . orourke
From: Tom O'Rourke When frequency requests are made by SLPC, host driver should not attempt to make frequency requests due to potential conflicts. Host-based turbo operations are already avoided when SLPC is used. This change covers other frequency requests such as from sysfs or debugfs interfa

[Intel-gfx] [RFC 19/22] drm/i915/slpc: Add parameter unset/set/get functions

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Add slcp_param_id enum values. Add events for setting/unsetting parameters. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_slpc.c | 127 ++ drivers/gpu/drm/i915/intel_slpc.h | 22 +++ 2 files changed, 149 insertions(+) di

[Intel-gfx] [RFC 05/22] drm/i915/slpc: Enable/Disable RC6 in SLPC flows

2016-01-20 Thread tom . orourke
From: Sagar Arun Kamble Signed-off-by: Sagar Arun Kamble Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 27713ab..ec1868b 100644 --- a/drivers/gpu/drm/i

[Intel-gfx] [RFC 09/22] drm/i915/slpc: Setup rps frequency values during SLPC init

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 2 +- drivers/gpu/drm/i915/intel_slpc.c | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/

[Intel-gfx] [RFC 01/22] drm/i915: Enable GuC submission, where supported

2016-01-20 Thread tom . orourke
From: Dave Gordon Signed-off-by: Dave Gordon v5: Rebased Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 8d90c25..2ca46

[Intel-gfx] [RFC 18/22] drm/i915/slpc: Add dfps task info to i915_slpc_info

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i915_debugfs.c | 12 drivers/gpu/drm/i915/intel_slpc.c | 31 +++ drivers/gpu/drm/i915/intel_slpc.h | 1 + 3 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm/i915/i9

[Intel-gfx] [RFC 17/22] drm/i915/slpc: Add i915_slpc_info to debugfs

2016-01-20 Thread tom . orourke
From: Tom O'Rourke i915_slpc_info shows the contents of SLPC shared data parsed into text format. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i915_debugfs.c | 161 1 file changed, 161 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c

[Intel-gfx] [RFC 15/22] drm/i915/slpc: Notification of Refresh Rate change

2016-01-20 Thread tom . orourke
From: Sagar Arun Kamble This patch will inform GuC SLPC about changes in the refresh rate due to Seamless DRRS. Refresh rate changes due to Static DRRS will be notified via commit path. Signed-off-by: Sagar Arun Kamble Acked-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_dp.c | 2 ++ driv

[Intel-gfx] [RFC 03/22] drm/i915/slpc: Expose guc functions for use with SLPC

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Expose host2guc_action for use by SLPC in intel_slpc.c. Expose functions to allocate and release objects used by GuC to be used for SLPC shared memory object. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i915_guc_submission.c | 6 +++--- drivers/gpu/drm/i915/intel_g

[Intel-gfx] [RFC 16/22] drm/i915/slpc: Add slpc_status enum values

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_slpc.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_slpc.h b/drivers/gpu/drm/i915/intel_slpc.h index bb1d12e..e7ff4a0 100644 --- a/drivers/gpu/drm/i915/in

[Intel-gfx] [RFC 13/22] drm/i915/slpc: Add Display mode event related data structures

2016-01-20 Thread tom . orourke
From: Sagar Arun Kamble Signed-off-by: Sagar Arun Kamble Acked-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_slpc.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_slpc.h b/drivers/gpu/drm/i915/intel_slpc.h index 7287c65

[Intel-gfx] [RFC 11/22] drm/i915/slpc: Send reset event

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Add host2guc SLPC reset event and send reset event during enable. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_slpc.c | 30 +- drivers/gpu/drm/i915/intel_slpc.h | 14 ++ 2 files changed, 43 insertions(+), 1 deletion(-) d

[Intel-gfx] [RFC 10/22] drm/i915/slpc: Update current requested frequency

2016-01-20 Thread tom . orourke
From: Tom O'Rourke When SLPC is controlling requested frequency, the rps.cur_freq value is not used to make the frequency request. Before using rps.cur_freq in sysfs or debugfs, read requested frequency from register to get the value most recently requested by SLPC firmware. Signed-off-by: Tom

[Intel-gfx] [RFC 02/22] drm/i915/slpc: Add has_slpc capability flag

2016-01-20 Thread tom . orourke
From: Tom O'Rourke Add has_slpc capablity flag to indicate GuC firmware supports single loop power control (SLPC). SLPC is a replacement for some host-based power management features. Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ 1 file changed, 2 insertions(+) diff

[Intel-gfx] [RFC 00/22] Add support for GuC-based SLPC

2016-01-20 Thread tom . orourke
From: Tom O'Rourke SLPC (Single Loop Power Controller) is a replacement for some host-based power management features. The SLPC implemenation runs in firmware on GuC. This series is a first request for comments. This series is not expected to be merged. After changes based on comments, a late

Re: [Intel-gfx] [PATCH 4/9] drm: Add an blend_color property

2016-01-20 Thread Matt Roper
On Mon, Jan 18, 2016 at 08:45:38PM +0530, Vandita Kulkarni wrote: > From: Damien Lespiau > > Add blend color property and update the > documentation for the same > > V2: Add blend color support in get property. It would be good to describe in a bit more detail what "blend color" means. It's un

Re: [Intel-gfx] [PATCH 3/9] drm: Introduce DRM_MODE_COLOR()

2016-01-20 Thread Matt Roper
On Mon, Jan 18, 2016 at 08:45:37PM +0530, Vandita Kulkarni wrote: > From: Damien Lespiau > > In the hope of expressing colors in the KMS API in a consitant want, > let's introduce a ARGB 16161616 color and a few convinience macros > around it. > > Signed-off-by: Damien Lespiau This is somewhat

Re: [Intel-gfx] [PATCH 2/9] drm/i915/skl: Add blend_func to SKL/BXT sprite planes

2016-01-20 Thread Matt Roper
On Mon, Jan 18, 2016 at 08:45:36PM +0530, Vandita Kulkarni wrote: > From: Damien Lespiau > > This patch adds the blend functions, and as per the > blend function, updates the plane control register values > > V2: Add blend support for all RGB formats > Fix the reg writes on plane_ctl_alpha b

Re: [Intel-gfx] [PATCH 1/9] drm: Introduce the blend-func property

2016-01-20 Thread Matt Roper
On Mon, Jan 18, 2016 at 08:45:35PM +0530, Vandita Kulkarni wrote: > From: Damien Lespiau > > We'd like to be able to program the blending modes of display planes. > Ville suggested to use something similar to the GL blend states, which > does seem like a good idea. > > For now, we only consider

Re: [Intel-gfx] [PATCH i-g-t 2/2] lib/ioctl_wrappers: Add gem_has_softpin

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 06:48:26PM +0100, Michał Winiarski wrote: > We can move it from softpin test into lib, and since softpin support is > highly unlikely to go away in-between getparam ioctl calls, let's just > do a single call and store the value. > > Signed-off-by: Michał Winiarski Reviewed

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/ioctl_wrappers: Add gem_gtt_type exposing raw HAS_ALIASING_PPGTT param

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 06:48:25PM +0100, Michał Winiarski wrote: > No functional changes. > While I'm here, let's also rename gem_uses_aliasing_ppgtt (since it's > being used to indicate if we are using ANY kind of ppgtt) and introduce > gem_uses_full_ppgtt and gem_uses_full_48b_ppgtt to drop some

Re: [Intel-gfx] [PATCH 14/18] drm/i915: Embed rotation_info under intel_framebuffer

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 09:05:35PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Instead of repopulatin the rotation_info struct for the fb every time > we try to use the fb, we can just populate it once when creating the fb, > and later we can just copy the pre-populate s

[Intel-gfx] [PATCH igt] tools: add intel_residency

2016-01-20 Thread Paulo Zanoni
After the recent discussions regarding the effects of the vblank disabling policies on PC state residencies, I started running some experiments to reevaluate some non-intuitive conclusions I had reached. In order to help me do this, I decided to write this tool. The idea is very simple: the tool p

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_fbc_crc.c: No longer dependant on Cairo A setup function that used to use Cairo to draw 2 rectangles covering the whole screen has been changed to use igt_draw

2016-01-20 Thread Zanoni, Paulo R
Hi In our IGT/Kernel culture, patch commit titles (here, presented as the email subject) are usually small (under 70-80 chars) providing a quick summary of what the change does. Also, we try to make each patch contain a single logical and complete change. So, for example, one approach you could h

[Intel-gfx] [PATCH v2 18/18] drm/i915: Make sure fb offset is (macro)pixel aligned

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä We convert the fb->offsets[] into x/y offsets, so they must be (macro)pixel aligned. Check for this, and if things look good allow fb->offsets[] != 0 when creating fbs since we now handle them correctly. v2: Move to last place in the series and improve the commit message Sig

[Intel-gfx] [PATCH 13/18] drm/i915: Move the NULL sg handling out from rotate_pages()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä rotate_pages() checks to see if it got called with a NULL sg, and then goes to extract it from sg->sgl. It always gets called with a NULL sg for the first plane, so moving the initial 'sg=st->sgl' assignment out into intel_rotate_fb_obj_pages() seems less special-casey. Signe

[Intel-gfx] [PATCH 05/18] drm/i915: Standardize on 'cpp' for bytes per pixel

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä We more or less randomly call the "bytes per pixel" value 'cpp', 'bytes_per_pixel', 'pixel_size', or even 'bpp'. Let's just pick one and stick to it. I've chosen 'cpp'. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 22 +++--- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 17/18] drm/i915: Pass around plane_state instead of fb+rotation

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä intel_compute_tile_offset() and intel_add_fb_offsets() get passed the fb and the rotation. As both of those come from the plane state we can just pass that in instead. For extra consitency pass the plane state to intel_fb_xy_to_linear() as well even though it only really need

[Intel-gfx] [PATCH v2 10/18] drm/i915: Don't pass plane+plane_state to intel_pin_and_fence_fb_obj()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä intel_pin_and_fence_fb_obj() only needs the framebuffer, and the desird rotation (to find the right GTT view for it), so no need to pass all kinds of plane stuff. The main motivation is to get rid of the uggy NULL plane_state handling due to fbdev. v2: Add a note why I reall

[Intel-gfx] [PATCH v3 08/18] drm/i915: Pass 90/270 vs. 0/180 rotation info for intel_gen4_compute_page_offset()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä The page aligned surface address calculation needs to know which way things are rotated. The contract now says that the caller must pass the rotate x/y coordinates, as well as the tile_height aligned stride in the tile_height direction. This will make it fairly simple to deal

[Intel-gfx] [PATCH 14/18] drm/i915: Embed rotation_info under intel_framebuffer

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä Instead of repopulatin the rotation_info struct for the fb every time we try to use the fb, we can just populate it once when creating the fb, and later we can just copy the pre-populate struct into the gtt_view. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_d

[Intel-gfx] [PATCH 11/18] drm/i915: Pass drm_frambuffer to intel_compute_page_offset()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä intel_compute_page_offsets() gets passed a bunch of the framebuffer metadate sepearately. Just pass the framebuffer itself to make life simpler for the caller, and make it less likely they would make a mistake in the order of the arguments (as most as just unsigned ints and su

[Intel-gfx] [PATCH v2 16/18] drm/i915: Don't pass pitch to intel_compute_page_offset()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä intel_compute_page_offset() can dig up the correct pitch from the fb itself, no need for the caller to pass it in. A bit of extra care is needed for the lower level _intel_compute_page_offset() since that one gets called before the rotated pitch under intel_fb is populated. N

[Intel-gfx] [PATCH v2 09/18] drm/i915: Support for extra alignment for tiled surfaces

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä SKL+ needs >4K alignment for tiled surfaces, so make intel_compute_page_offset() handle it. The way we do it is first we compute the closest tile boundary as before, and then figure out how many tiles we need to go to reach the desired alignment. The difference in the offset

[Intel-gfx] [PATCH v3 15/18] drm/i915: Rewrite fb rotation GTT handling

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä Redo the fb rotation handling in order to: - eliminate the NV12 special casing - handle fb->offsets[] properly - make the rotation handling reasier for the plane code To achieve these goals we reduce intel_rotation_info to only contain (for each plane) the rotated view width,

[Intel-gfx] [PATCH 12/18] drm/i915: Reorganize intel_rotation_info

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä Throw out a bunch of unnecessary stuff from struct intel_rotation_info, and pull most of the remaining stuff to live under an array of per-color plane sub-structures. What still remains outside the sub-structure will be reorgranized later as well, but that requires more work

[Intel-gfx] [PATCH v2 06/18] drm: Add drm_format_plane_width() and drm_format_plane_height()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä Add a few helpers to get the dimensions of the chroma plane(s). v2: Add kernel-doc (Daniel) Cc: dri-de...@lists.freedesktop.org Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter --- include/drm/drm_crtc.h | 30 ++ 1 file changed, 30 inser

[Intel-gfx] [PATCH 07/18] drm/i915: Fix intel_tile_width() parameters

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä The fb_modifiers and cpp arguments passed to intel_tile_width() in intel_fill_fb_ggtt_view() got accidentally swapped around. I'm pretty sure I fixed this already, but could be I lost the fix accidentally during some rebases or something. Anyway, fix it up for real. Fixes: d9

[Intel-gfx] [PATCH 01/18] drm/i915: Rename the rotated gtt view member to 'rotated'

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä Also rename 'rotation_info' to 'rotated' to match the view type exactly, this should avoid confusion which union members is valid for each view type. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 +-

[Intel-gfx] [PATCH 04/18] drm/i915: Make display gtt offsets u32

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä Using 'unsigned long' for ggtt offsets doesn't make much sense. Use 'u32' instead since we've not yet seen a >4GiB ggtt. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 22 ++ drivers/gpu/drm/i915/intel_drv.h | 12 ++--

[Intel-gfx] [PATCH v2 00/18] drm/i915: Handle fb->offsets[] and rewrite fb rotation handling to be more generic (v2)

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä This is the new version of [1]. I already sent a bunch of the earlir patches as separate prep series [2] and [3]. [2] was already pushed fully, but most of the patches from [3] didn't get reviewed yet, so I've included them in this series so that the CI machinery might actuall

[Intel-gfx] [PATCH 02/18] drm/i915: Pass stride to rotate_pages()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä Pass stride in addition to width and height to rotate_pages(). For now width and stride are the same, but once framebuffer offsets enter the scene that may no longer be the case. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 +-- 1 file change

[Intel-gfx] [PATCH 03/18] drm/i915: Pass rotation_info to intel_rotate_fb_obj_pages()

2016-01-20 Thread ville . syrjala
From: Ville Syrjälä intel_rotate_fb_obj_pages() doens't need the entire gtt view, just the rotation info suffices. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c

Re: [Intel-gfx] [PATCH igt] igt/gem_softpin: Remove false dependencies on esoteric features

2016-01-20 Thread Belgaumkar, Vinay
Hi Chris, These tests were developed for testing buffered SVM(using userptr and soft pinning API). I think Dan wanted me to rename the tests to gem_softpin, since they were being checked in as tests which validated the softpin kernel patches. Can we rename the existing tests to gem_buffered_

[Intel-gfx] [PATCH i-g-t v3] tests/gem_userptr_blits: subtests for MAP_FIXED mappings of regular BO

2016-01-20 Thread Michał Winiarski
When the memory backing the userptr object is freed by the user, but the BO itself is not closed, it's possible to trigger recursive deadlock caused by operations done on different BO mapped in that region. Testcases are simulating such behaviour by using MAP_FIXED mmap flag. v2: Grammar/naming fi

[Intel-gfx] [PATCH i-g-t 1/2] lib/ioctl_wrappers: Add gem_gtt_type exposing raw HAS_ALIASING_PPGTT param

2016-01-20 Thread Michał Winiarski
No functional changes. While I'm here, let's also rename gem_uses_aliasing_ppgtt (since it's being used to indicate if we are using ANY kind of ppgtt) and introduce gem_uses_full_ppgtt and gem_uses_full_48b_ppgtt to drop some unnecessary code from tests that were previously calling getparam directl

[Intel-gfx] [PATCH i-g-t 2/2] lib/ioctl_wrappers: Add gem_has_softpin

2016-01-20 Thread Michał Winiarski
We can move it from softpin test into lib, and since softpin support is highly unlikely to go away in-between getparam ioctl calls, let's just do a single call and store the value. Signed-off-by: Michał Winiarski --- lib/ioctl_wrappers.c | 29 + lib/ioctl_wrappers.h |

Re: [Intel-gfx] [PATCH 2/3] drm/i915: resize the GuC WOPCM for rc6

2016-01-20 Thread Jeff McGee
On Fri, Jan 08, 2016 at 03:03:53PM +, Peter Antoine wrote: > This patch resizes the GuC WOPCM to so that the GuC and the RC6 memory > spaces do not overlap. > > Issue: https://jira01.devtools.intel.com/browse/VIZ-6638 > Signed-off-by: Peter Antoine > --- > drivers/gpu/drm/i915/i915_guc_reg.h

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for improve handling of the driver's default (kernel) context

2016-01-20 Thread Dave Gordon
On 20/01/16 07:49, Patchwork wrote: == Summary == Built on 7d26528d30b0d8119c858115b6e5e22deb74ec71 drm-intel-nightly: 2016y-01m-19d-19h-38m-52s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: pass -> DMESG-WARN (bdw-nuci7) UNSTABLE http

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Instrument PSR parameter for possible quirks with link standby.

2016-01-20 Thread Zanoni, Paulo R
Em Sex, 2015-12-11 às 08:39 -0800, Rodrigo Vivi escreveu: > Unfortunately we don't know all panels and platforms out there and we > found internal prototypes without VBT proper set but where only > link in standby worked well. > > So, before enable PSR by default let's instrument the PSR parameter

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Add PSR main link standby support back

2016-01-20 Thread Zanoni, Paulo R
Em Sex, 2015-12-11 às 08:39 -0800, Rodrigo Vivi escreveu: > Link standby support has been deprecated with 'commit 89251b177 > ("drm/i915: PSR: deprecate link_standby support for core > platforms.")' > > The reason for that is that main link in full off offers more power > savings and on HSW and BD

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Use ordered seqno write interrupt generation on gen8+ execlists

2016-01-20 Thread Patchwork
== Summary == Built on e9545b0b60b73d8be3d41048af5b8f2c1e2fc4c1 drm-intel-nightly: 2016y-01m-20d-13h-55m-37s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: dmesg-warn -> PASS (bdw-ultra) UNSTABLE Test gem_sync: Subgroup basic-render:

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 02:50:47PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In GuC mode LRC pinning lifetime depends exclusively on the > request liftime. Since that is terminated by the seqno update > that opens up a race condition between GPU finishing writing > out the context i

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kms: Add COMIT_ATOMIC to igt_display_commit2()

2016-01-20 Thread Daniel Stone
Hi, On 20 January 2016 at 14:52, Maarten Lankhorst wrote: > Op 15-01-16 om 10:06 schreef Marius Vlad: >> + /* populate plane req */ >> + igt_atomic_populate_plane_req(req, plane, IGT_PLANE_CRTC_ID, >> crtc_id); > Set crtc_id and fb_id to 0 when disabling plane. >> +

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_kms: Add COMIT_ATOMIC to igt_display_commit2()

2016-01-20 Thread Maarten Lankhorst
Op 15-01-16 om 10:06 schreef Marius Vlad: > So far, we had only COMMIT_UNIVERSAL and COMMIT_LEGACY, using > drmModeSetPlane()/drmSetCrtc(). This patch adds COMMIT_ATOMIC > to igt_display_commit2() that makes use of drmModeAtomicCommit(). > > Signed-off-by: Marius Vlad > --- > lib/igt_kms.c | 190

[Intel-gfx] [PATCH v2] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In GuC mode LRC pinning lifetime depends exclusively on the request liftime. Since that is terminated by the seqno update that opens up a race condition between GPU finishing writing out the context image and the driver unpinning the LRC. To extend the LRC lifetime we will e

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Make LRC (un)pinning work on context and engine

2016-01-20 Thread Patchwork
== Summary == Built on e9545b0b60b73d8be3d41048af5b8f2c1e2fc4c1 drm-intel-nightly: 2016y-01m-20d-13h-55m-37s UTC integration manifest Test kms_pipe_crc_basic: Subgroup read-crc-pipe-a-frame-sequence: dmesg-warn -> PASS (skl-i5k-2) bdw-nuci7total:143 pass:1

Re: [Intel-gfx] [PATCH 5/5] drm/i915: force full detect on sink count change

2016-01-20 Thread Ander Conselvan De Oliveira
On Tue, 2016-01-19 at 16:07 +0530, Shubhangi Shrivastava wrote: > This patch checks for changes in sink count between short pulse > hpds and forces full detect when there is a change. > > This will allow both detection of hotplug and unplug of panels > through dongles that give only short pulse fo

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Save sink_count for tracking changes to it and read sink_count dpcd always

2016-01-20 Thread Ander Conselvan De Oliveira
The patch summary is now too long. Just use the one from patch 5 ("read sink_count dpcd always"). You can mention in the commit message that the value of sink count is now stored in struct intel_dp, but that doesn't need to be in the summary. One more comment below. On Tue, 2016-01-19 at 16:07 +05

[Intel-gfx] [PATCH v3] drm/i915/skl/kbl: Add support for pipe fusing

2016-01-20 Thread Patrik Jakobsson
On SKL and KBL we can have pipe A/B/C disabled by fuse settings. The pipes must be fused in descending order (e.g. C, B+C, A+B+C). We simply decrease info->num_pipes if we find a valid fused out config. v2: Don't store the pipe disabled mask in device info (Damien) v3: Don't check FUSE_STRAP regi

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Nick Hoath
On 20/01/2016 14:06, Tvrtko Ursulin wrote: On 20/01/16 13:55, Chris Wilson wrote: On Wed, Jan 20, 2016 at 01:40:57PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In GuC mode LRC pinning lifetime depends exclusively on the request liftime. Since that is terminated by the seqno update tha

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 02:06:43PM +, Tvrtko Ursulin wrote: > > On 20/01/16 13:55, Chris Wilson wrote: > >On Wed, Jan 20, 2016 at 01:40:57PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>In GuC mode LRC pinning lifetime depends exclusively on the > >>request liftime. Since th

Re: [Intel-gfx] [PATCH 1/4] drm/i915: PSR Fix standby logic for PSR on non DDI-A for certain platforms.

2016-01-20 Thread Zanoni, Paulo R
Em Sex, 2015-12-11 às 08:39 -0800, Rodrigo Vivi escreveu: > Current platforms that support PSR on other port than A only support > link > standby mode. > > The logic here was wrong since 'commit 89251b177b ("drm/i915: PSR: > deprecate link_standby support for core platforms.") What's wrong/broken

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Tvrtko Ursulin
On 20/01/16 13:55, Chris Wilson wrote: On Wed, Jan 20, 2016 at 01:40:57PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In GuC mode LRC pinning lifetime depends exclusively on the request liftime. Since that is terminated by the seqno update that opens up a race condition between GPU fini

Re: [Intel-gfx] [PATCH] drm/i915: Fix NULL plane->fb oops on SKL

2016-01-20 Thread Ville Syrjälä
On Tue, Jan 19, 2016 at 09:28:03PM +0100, Daniel Vetter wrote: > On Tue, Jan 19, 2016 at 06:23:17PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > In this atomic age, we can't trust the plane->fb pointer anymore. > > It might get update too late. Instead we are suppos

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Make LRC (un)pinning work on context and engine

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 01:40:55PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Previously intel_lr_context_(un)pin were operating on requests > which is in conflict with their names. > > If we make them take a context and an engine, it makes the names > make more sense and it also ma

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 01:40:57PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In GuC mode LRC pinning lifetime depends exclusively on the > request liftime. Since that is terminated by the seqno update > that opens up a race condition between GPU finishing writing > out the context i

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make LRC pinning own a reference to the context

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 01:40:56PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Will simplify the following fix and sounds logical. > > Signed-off-by: Tvrtko Ursulin > Cc: Chris Wilson > Cc: Nick Hoath > --- > drivers/gpu/drm/i915/intel_lrc.c | 2 ++ > 1 file changed, 2 insertions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Limit the auto arming of mmio debugs on vlv/chv

2016-01-20 Thread Patchwork
== Summary == Built on a84f26193f3fd63600b2f4c280c0046e4a191322 drm-intel-nightly: 2016y-01m-20d-12h-56m-53s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: pass -> DMESG-WARN (skl-i5k-2) UNSTABLE dmesg-warn -> PASS (skl-

[Intel-gfx] [PATCH] drm/i915: Use ordered seqno write interrupt generation on gen8+ execlists

2016-01-20 Thread Mika Kuoppala
From: Chris Wilson Broadwell and later currently use the same unordered command sequence to update the seqno in the HWS status page and then assert the user interrupt. We should apply the w/a from legacy (where we do an mmio read to delay the seqno read after the interrupt), but this is not enoug

[Intel-gfx] [PATCH 3/3] drm/i915: Fix premature LRC unpin in GuC mode

2016-01-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In GuC mode LRC pinning lifetime depends exclusively on the request liftime. Since that is terminated by the seqno update that opens up a race condition between GPU finishing writing out the context image and the driver unpinning the LRC. To extend the LRC lifetime we will e

[Intel-gfx] [PATCH 1/3] drm/i915: Make LRC (un)pinning work on context and engine

2016-01-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Previously intel_lr_context_(un)pin were operating on requests which is in conflict with their names. If we make them take a context and an engine, it makes the names make more sense and it also makes future fixes possible. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson C

[Intel-gfx] [PATCH 2/3] drm/i915: Make LRC pinning own a reference to the context

2016-01-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Will simplify the following fix and sounds logical. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson Cc: Nick Hoath --- drivers/gpu/drm/i915/intel_lrc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.

Re: [Intel-gfx] [PATCH v4 07/38] drm/i915: Start of GPU scheduler

2016-01-20 Thread Joonas Lahtinen
Hi, Comments below this pre text. Many of the comments are related to the indent and style of the code. That stuff is important to fix for future maintainability. In order for the future review to be more effective, I'd like to next see a v5 of the series where the code quality concerns have been

Re: [Intel-gfx] [PATCH v4] drm/i915: edp resume/On time optimization.

2016-01-20 Thread Ville Syrjälä
On Wed, Jan 20, 2016 at 03:29:00PM +0530, Kumar, Shobhit wrote: > On 01/20/2016 02:30 PM, Daniel Vetter wrote: > > On Tue, Jan 19, 2016 at 02:37:55PM -0800, Kumar, Abhay wrote: > >> > >> > >> On 1/12/2016 5:57 PM, Kumar, Abhay wrote: > >>> From: Abhay Kumar > >>> > >>> Make resume/on codepath not

Re: [Intel-gfx] [PATCH] drm/i915: Sink CRC: tune down error message at stop to debug_kms.

2016-01-20 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 12:37:39PM +, Zanoni, Paulo R wrote: > Em Ter, 2016-01-19 às 22:21 +, Vivi, Rodrigo escreveu: > > On Tue, 2016-01-19 at 17:46 +, Zanoni, Paulo R wrote: > > > Em Qua, 2016-01-13 às 14:05 -0800, Rodrigo Vivi escreveu: > > > > When we stop the sink CRC calculation w

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/doc: add power management section to documentation

2016-01-20 Thread Patchwork
== Summary == Built on c783b5011894af49992f2095cb2848b6cf8ebc57 drm-intel-nightly: 2016y-01m-20d-10h-12m-03s UTC integration manifest Test gem_sync: Subgroup basic-render: pass -> DMESG-FAIL (bdw-nuci7) Test kms_force_connector_basic: Subgroup force-connecto

Re: [Intel-gfx] [PATCH] drm/i915: Sink CRC: tune down error message at stop to debug_kms.

2016-01-20 Thread Zanoni, Paulo R
Em Ter, 2016-01-19 às 22:21 +, Vivi, Rodrigo escreveu: > On Tue, 2016-01-19 at 17:46 +, Zanoni, Paulo R wrote: > > Em Qua, 2016-01-13 às 14:05 -0800, Rodrigo Vivi escreveu: > > > When we stop the sink CRC calculation we wait a while until the > > > counter > > > is reset to zero and return

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable GuC Loading on Kabylake (rev2)

2016-01-20 Thread Patchwork
== Summary == Built on c783b5011894af49992f2095cb2848b6cf8ebc57 drm-intel-nightly: 2016y-01m-20d-10h-12m-03s UTC integration manifest Test gem_sync: Subgroup basic-render: pass -> DMESG-FAIL (bdw-nuci7) Test kms_flip: Subgroup basic-flip-vs-modeset:

Re: [Intel-gfx] [PATCH] drm/i915: Tune down "GT register while GT waking disabled" message

2016-01-20 Thread Mika Kuoppala
Daniel Vetter writes: > We've had this since forever, and's randomly reporting issues and as > such causing piles&piles of CI noise. Mika is working on proper debug > infrastructure for this, and on fixing this properly. > > Meanwhile make CI more useful for everyone else. > > Cc: Mika Kuoppala

Re: [Intel-gfx] [PATCH] drm/i915: Don't do pre plane update on disabled crtcs

2016-01-20 Thread Ville Syrjälä
On Wed, Jan 20, 2016 at 08:18:03AM +0100, Maarten Lankhorst wrote: > Op 19-01-16 om 20:22 schreef Ville Syrjälä: > > On Mon, Jan 18, 2016 at 11:23:21AM +0100, Maarten Lankhorst wrote: > >> Op 14-01-16 om 17:52 schreef Ville Syrjälä: > >>> On Thu, Jan 14, 2016 at 06:32:10PM +0200, Mika Kuoppala wrot

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add DPI FIFO empty status check

2016-01-20 Thread Mika Kahola
On Fri, 2015-12-04 at 19:47 +0530, Deepak M wrote: > From: Gaurav K Singh > > After sending SHUTDOWN or TURN ON packet,check the DPI > FIFO empty status. > Tested-by: Mika Kahola > Signed-off-by: Gaurav K Singh > --- > drivers/gpu/drm/i915/intel_dsi.c | 6 ++ > 1 file changed, 6 insertion

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use init power domain during reset

2016-01-20 Thread Daniel Vetter
On Tue, Jan 19, 2016 at 09:50:09PM +0200, Mika Kuoppala wrote: > If we have driver failure in our power well and/or dc > state keeping, we might try to reset without powers. > > Evidence shows that resetting the chip with dc6 enabled > don't lead to desired results. The dmc kept it's enabled > dc6

Re: [Intel-gfx] [PATCH] drm/i915: Limit the auto arming of mmio debugs on vlv/chv

2016-01-20 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 12:32:23PM +0200, Mika Kuoppala wrote: > The capability to detect unclaimed register access was > recently introduced for vlv/chv platforms. Apparently > there are plenty of unclaimed access on these platforms, > resulting in new dmesg warns. But as we are trying to form > a

Re: [Intel-gfx] [PATCH] drm/i915/doc: add power management section to documentation

2016-01-20 Thread Daniel Vetter
On Wed, Jan 20, 2016 at 12:03:37PM +0200, Jani Nikula wrote: > Just include the RC6 paragraph and functions from intel_pm.c, nothing > fancy. > > Signed-off-by: Jani Nikula Assuming kernel CI doesn't complain about new warnings when we do this. Reviewed-by: Daniel Vetter > --- > Documentation

Re: [Intel-gfx] [PATCH] drm/i915/doc: add power management section to documentation

2016-01-20 Thread kbuild test robot
Hi Jani, [auto build test WARNING on v4.4-rc8] [also build test WARNING on next-20160120] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-doc-add-power-management-section

[Intel-gfx] [PATCH] drm/i915: Limit the auto arming of mmio debugs on vlv/chv

2016-01-20 Thread Mika Kuoppala
The capability to detect unclaimed register access was recently introduced for vlv/chv platforms. Apparently there are plenty of unclaimed access on these platforms, resulting in new dmesg warns. But as we are trying to form a beachhead for CI/Bat, all new warns are adding to the noise and thus not

Re: [Intel-gfx] [PATCH] igt/gem_trtt: Exercise the TRTT hardware

2016-01-20 Thread Goel, Akash
On 1/11/2016 6:02 PM, Chris Wilson wrote: On Sat, Jan 09, 2016 at 05:01:30PM +0530, akash.g...@intel.com wrote: +static void* mmap_bo(int fd, uint32_t handle, uint64_t size) +{ + uint32_t *ptr = gem_mmap__cpu(fd, handle, 0, size, PROT_READ); + gem_set_domain(fd, handle, I915_GEM_DO

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915: simplify allocation of driver-internal requests

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 09:56:10AM +, Tvrtko Ursulin wrote: > > Hi, > > On 19/01/16 19:02, Dave Gordon wrote: > >There are a number of places where the driver needs a request, but isn't > >working on behalf of any specific user or in a specific context. At > >present, we associate them with t

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Stop using DC states if firmware disagrees on the state

2016-01-20 Thread Chris Wilson
On Wed, Jan 20, 2016 at 11:49:51AM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Tue, Jan 19, 2016 at 09:50:08PM +0200, Mika Kuoppala wrote: > >> Sometimes we get dmesg warnings claiming that DC6 was already > >> enabled prior to our enabling. Investigations using readback of > >> t

Re: [Intel-gfx] [PATCH] drm/i915: Do not put big intel_crtc_state on the stack

2016-01-20 Thread Tvrtko Ursulin
On 19/01/16 20:22, Daniel Vetter wrote: On Tue, Jan 19, 2016 at 03:25:17PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having this on stack triggers the -Wframe-larger-than=1024 and is not nice to put such big things on the kernel stack anyway. This required a little bit of refactoring

  1   2   >