Re: [Intel-gfx] [PATCH v4.1 6/8] drm/i915: Nuke fbc members from intel_crtc->atomic, v3.

2016-03-01 Thread Maarten Lankhorst
Op 29-02-16 om 22:06 schreef Zanoni, Paulo R: > Em Seg, 2016-02-29 às 10:58 +0100, Maarten Lankhorst escreveu: >> Whenever there's an update to the primary plane, >> fbc_pre_update and fbc_post_update are called. Kill off >> intel_crtc->atomic.update_fbc and now that intel_crtc->atomic >> is empty,

[Intel-gfx] Problems in intel_panel_fitter.1

2016-03-01 Thread esr
This is automatically generated email about markup problems in a man page for which you appear to be responsible. If you are not the right person or list, please tell me so I can correct my database. See http://catb.org/~esr/doclifter/bugs.html for details on how and why these patches were genera

Re: [Intel-gfx] [PATCH v5 10/35] drm/i915: Added scheduler hook when closing DRM file handles

2016-03-01 Thread Joonas Lahtinen
On to, 2016-02-18 at 14:26 +, john.c.harri...@intel.com wrote: > From: John Harrison > > The scheduler decouples the submission of batch buffers to the driver > with submission of batch buffers to the hardware. Thus it is possible > for an application to close its DRM file handle while there

Re: [Intel-gfx] [PATCH v5 11/35] drm/i915: Added scheduler hook into i915_gem_request_notify()

2016-03-01 Thread Joonas Lahtinen
On to, 2016-02-18 at 14:26 +, john.c.harri...@intel.com wrote: > From: John Harrison > > The scheduler needs to know when requests have completed so that it > can keep its own internal state up to date and can submit new requests > to the hardware from its queue. > > v2: Updated due to chang

Re: [Intel-gfx] [PATCH v5 12/35] drm/i915: Added deferred work handler for scheduler

2016-03-01 Thread Joonas Lahtinen
On to, 2016-02-18 at 14:27 +, john.c.harri...@intel.com wrote: > From: John Harrison > > The scheduler needs to do interrupt triggered work that is too complex > to do in the interrupt handler. Thus it requires a deferred work > handler to process such tasks asynchronously. > > v2: Updated t

Re: [Intel-gfx] [PATCH v5 17/35] drm/i915: Added scheduler support to __wait_request() calls

2016-03-01 Thread Joonas Lahtinen
On to, 2016-02-18 at 14:27 +, john.c.harri...@intel.com wrote: > From: John Harrison > > The scheduler can cause batch buffers, and hence requests, to be > submitted to the ring out of order and asynchronously to their > submission to the driver. Thus at the point of waiting for the > complet

[Intel-gfx] [PATCH 2/2] drm/i915: Only recalculate wm's for planes part of the state, v2.

2016-03-01 Thread Maarten Lankhorst
Only planes that are part of the state should be used for recalculating watermarks. For planes not part of the state the previous patch allows us to re-use the old values since they're calculated even for levels that are not actively used. Changes since v1: - Remove big if from intel_crtc_atomic_c

[Intel-gfx] [PATCH 1/2] drm/i915: Allow preservation of watermarks.

2016-03-01 Thread Maarten Lankhorst
As Paulo has noted we can help bisectability by separating computing watermarks on a noop in 2 separate commits. This patch no longer clears the crtc watermark state, but recalculates it completely. Regardless whether a level is used the full values for each level are calculated. If a level is inv

Re: [Intel-gfx] [PATCH v4 7/8] drm/i915: Do not compute watermarks on a noop.

2016-03-01 Thread Maarten Lankhorst
Op 18-02-16 om 21:51 schreef Zanoni, Paulo R: > Em Qua, 2016-02-10 às 13:49 +0100, Maarten Lankhorst escreveu: >> No atomic state should be included after all validation when nothing >> has >> changed. During modeset all active planes will be added to the state, >> while disabled planes won't chang

Re: [Intel-gfx] [PATCH v6 3/7] drm/i915: introduce and use i915_gem_object_vmap_range()

2016-03-01 Thread Tvrtko Ursulin
On 29/02/16 21:16, Dave Gordon wrote: From: Alex Dai There are several places inside driver where a GEM object is mapped to kernel virtual space. The mapping may be done either for the whole object or only a subset of it. This patch introduces a function i915_gem_object_vmap_range() to implem

Re: [Intel-gfx] [PATCH v4] drm/i915: Execlists small cleanups and micro-optimisations

2016-03-01 Thread Tvrtko Ursulin
On 29/02/16 11:59, Tvrtko Ursulin wrote: On 29/02/16 11:48, Chris Wilson wrote: On Mon, Feb 29, 2016 at 11:40:37AM +, Tvrtko Ursulin wrote: On 29/02/16 11:13, Chris Wilson wrote: On Mon, Feb 29, 2016 at 11:01:49AM +, Tvrtko Ursulin wrote: On 29/02/16 10:53, Chris Wilson wrote:

Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > The assert check for c->bo should be done before DBG, > else it will hit memory access violation when c->bo > is null. > > Signed-off-by: Lim Siew Hoon > Reviewed-by: Matt Roper Pardon? With a r-b? -Chris -- Chris Wilson, Intel

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib/igt_bb_factory: Add igt_bb_factory library

2016-03-01 Thread Morton, Derek J
> > >-Original Message- >From: Ceraolo Spurio, Daniele >Sent: Wednesday, February 17, 2016 9:48 AM >To: Morton, Derek J ; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH i-g-t 1/4] lib/igt_bb_factory: Add >igt_bb_factory library > > > >On 12/02/16 09:38, Derek Morton wrot

Re: [Intel-gfx] [PATCH v4] drm/i915: Execlists small cleanups and micro-optimisations

2016-03-01 Thread Chris Wilson
On Mon, Feb 29, 2016 at 11:59:26AM +, Tvrtko Ursulin wrote: > > > On 29/02/16 11:48, Chris Wilson wrote: > >On Mon, Feb 29, 2016 at 11:40:37AM +, Tvrtko Ursulin wrote: > >> > >> > >>On 29/02/16 11:13, Chris Wilson wrote: > >>>On Mon, Feb 29, 2016 at 11:01:49AM +, Tvrtko Ursulin wrote:

Re: [Intel-gfx] [PATCH v4] drm/i915: Execlists small cleanups and micro-optimisations

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 10:21:45AM +, Tvrtko Ursulin wrote: > > > On 29/02/16 11:59, Tvrtko Ursulin wrote: > > > > > >On 29/02/16 11:48, Chris Wilson wrote: > >>On Mon, Feb 29, 2016 at 11:40:37AM +, Tvrtko Ursulin wrote: > >>> > >>> > >>>On 29/02/16 11:13, Chris Wilson wrote: > On Mon

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add missing NULL check before calling initial_watermarks (rev2)

2016-03-01 Thread Imre Deak
On Tue, 2016-03-01 at 07:24 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add missing NULL check before calling > initial_watermarks (rev2) > URL   : https://patchwork.freedesktop.org/series/3930/ > State : failure > > == Summary == > > Series 3930v2 drm/i915: Add missing

Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Lim, Siew Hoon
> > On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > > The assert check for c->bo should be done before DBG, else it will hit > > memory access violation when c->bo is null. > > > > Signed-off-by: Lim Siew Hoon > > Reviewed-by: Matt Roper > > Pardon? With a r-b? What is a r-b?

Re: [Intel-gfx] [PATCH v3 9/9] drm/i915/error: Capture WA ctx batch in error state

2016-03-01 Thread Tvrtko Ursulin
On 26/02/16 16:06, Arun Siluvery wrote: From Gen8 onwards we apply ctx workarounds using special batch buffers that execute during save/restore, good to have them in error state. v2: use wa_ctx->size and print only size values (Mika) v3: simplify conditions when recording and freeing object

Re: [Intel-gfx] [PATCH v4] drm/i915: Execlists small cleanups and micro-optimisations

2016-03-01 Thread Tvrtko Ursulin
On 01/03/16 10:32, Chris Wilson wrote: On Tue, Mar 01, 2016 at 10:21:45AM +, Tvrtko Ursulin wrote: On 29/02/16 11:59, Tvrtko Ursulin wrote: On 29/02/16 11:48, Chris Wilson wrote: On Mon, Feb 29, 2016 at 11:40:37AM +, Tvrtko Ursulin wrote: On 29/02/16 11:13, Chris Wilson wrote:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add missing NULL check before calling initial_watermarks (rev2)

2016-03-01 Thread Imre Deak
On Tue, 2016-03-01 at 12:32 +0200, Imre Deak wrote: > On Tue, 2016-03-01 at 07:24 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Add missing NULL check before calling > > initial_watermarks (rev2) > > URL   : https://patchwork.freedesktop.org/series/3930/ > > State : fa

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add missing NULL check before calling initial_watermarks (rev2)

2016-03-01 Thread Ville Syrjälä
On Tue, Mar 01, 2016 at 12:32:53PM +0200, Imre Deak wrote: > On Tue, 2016-03-01 at 07:24 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Add missing NULL check before calling > > initial_watermarks (rev2) > > URL   : https://patchwork.freedesktop.org/series/3930/ > > Sta

Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 10:33:12AM +, Lim, Siew Hoon wrote: > > > > On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > > > The assert check for c->bo should be done before DBG, else it will hit > > > memory access violation when c->bo is null. > > > > > > Signed-off-by: Lim Siew

[Intel-gfx] [PATCH] drm/i915: add spam for force-load-detect

2016-03-01 Thread Maarten Lankhorst
Patch to force CI to reveal why force-load-detect test fails. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH v4] drm/i915: Execlists small cleanups and micro-optimisations

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 10:41:26AM +, Tvrtko Ursulin wrote: > What about your patch to move it all to a bottom handler? Are we > going to progress that one? I looked for the regressions and found an interesting slowdown in single nop batches (almost 2x as slow). Another one that should not hap

Re: [Intel-gfx] [PATCH 09/21] drm/i915: Embed rotation_info under intel_framebuffer

2016-03-01 Thread Ville Syrjälä
On Mon, Feb 15, 2016 at 10:54:47PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Instead of repopulatin the rotation_info struct for the fb every time > we try to use the fb, we can just populate it once when creating the fb, > and later we can just copy the pre-populate s

[Intel-gfx] [PATCH i-g-t v4 2/2] tests/drv_hangman: test for acthd increasing through invalid VM space

2016-03-01 Thread daniele . ceraolospurio
From: Daniele Ceraolo Spurio The hangcheck logic will not flag an hang if acthd keeps increasing. However, if a malformed batch jumps to an invalid offset in the ppgtt it can potentially continue executing through the whole address space without triggering the hangcheck mechanism. This patch add

[Intel-gfx] [PATCH i-g-t v4 1/2] lib: move i915_wedged_set to ig_gt.c

2016-03-01 Thread daniele . ceraolospurio
From: Daniele Ceraolo Spurio Upcoming tests will call it to recover from bad states caused by hangcheck bugs.the function was renamed to igt_force_gpu_reset to have a naming closer to other hang-related functions in the same file. The value written to the debugfs has also been changed to -1; thi

Re: [Intel-gfx] [PATCH 0/6] drm/i915: Some FDI related dotclock stuff

2016-03-01 Thread Ville Syrjälä
On Wed, Feb 17, 2016 at 09:41:07PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Imre's SNB had a crappy BIOS that failed to configure the hardware > correctly when hooked up to a 4K monitor, which then resulted in > lots of noise from i915 when it was trying to make sense

[Intel-gfx] [PATCH] drm/i915/error: Capture WA ctx batch in error state

2016-03-01 Thread Arun Siluvery
From Gen8 onwards we apply ctx workarounds using special batch buffers that execute during context save/restore, good to have them in error state. v2: use wa_ctx->size and print only size values (Mika) v3: simplify conditions when recording and freeing object (Chris) v4: resolve checkpatch errors

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Add missing NULL check before calling initial_watermarks (rev2)

2016-03-01 Thread Imre Deak
On ti, 2016-03-01 at 12:45 +0200, Ville Syrjälä wrote: > On Tue, Mar 01, 2016 at 12:32:53PM +0200, Imre Deak wrote: > > On Tue, 2016-03-01 at 07:24 +, Patchwork wrote: > > > == Series Details == > > > > > > Series: drm/i915: Add missing NULL check before calling > > > initial_watermarks (rev2)

[Intel-gfx] [PATCH i-g-t 2/3] kms_crtc_background_color: Update to match kernel interface

2016-03-01 Thread Lionel Landwerlin
From: Matt Roper Update the existing test to use the current kernel interface, but leave the test logic untouched. As the test is written at the moment it's only really useful for manual testing...it will happily return success even if we fail to set the background color (or misprogram the HW wi

[Intel-gfx] [PATCH i-g-t 3/3] tests: kms_crtc_background_color: add CRC based test

2016-03-01 Thread Lionel Landwerlin
Add an additional test using the CRC unit on the pipe to verify setting the background color on the pipe produces the same CRCs as setting a plane with cairo colored pixels. Also only requires the CRC support for that test. Signed-off-by: Lionel Landwerlin --- tests/kms_crtc_background_color.c

[Intel-gfx] [PATCH i-g-t 0/3] Background color tests

2016-03-01 Thread Lionel Landwerlin
Hi, Here is an update based on Matt Roper's series to update the background color tests. This update adds CRC based tests. This is related to the series enabling background color support on i915/gen9 : https://patchwork.freedesktop.org/series/3265/ Cheers, Lionel Lionel Landwerlin (1): test

[Intel-gfx] [PATCH i-g-t 1/3] igt_kms: Set atomic capability bit

2016-03-01 Thread Lionel Landwerlin
From: Matt Roper Tell the kernel that we understand atomic and want to have access to atomic-only properties. If the kernel doesn't support atomic for i915 yet (and i915.nuclear_pageflip=1 isn't passed on the kernel command line) this will silently fail, but won't cause any problems. We wrap th

Re: [Intel-gfx] [PATCH] sna: move up the assert check before DBG print message

2016-03-01 Thread Lim, Siew Hoon
> On Tue, Mar 01, 2016 at 10:33:12AM +, Lim, Siew Hoon wrote: > > > > > > On Tue, Mar 01, 2016 at 09:49:21AM +0800, Lim Siew Hoon wrote: > > > > The assert check for c->bo should be done before DBG, else it will > > > > hit memory access violation when c->bo is null. > > > > > > > > Signed-off-

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/4] drm/i915/skl: Fix power domain suspend sequence

2016-03-01 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915/skl: Fix power domain suspend sequence URL : https://patchwork.freedesktop.org/series/3931/ State : warning == Summary == Series 3931v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/3931/revision

[Intel-gfx] ✗ Fi.CI.BAT: warning for Reorganise calls to vmap() GEM objects (rev4)

2016-03-01 Thread Patchwork
== Series Details == Series: Reorganise calls to vmap() GEM objects (rev4) URL : https://patchwork.freedesktop.org/series/3688/ State : warning == Summary == Series 3688v4 Reorganise calls to vmap() GEM objects http://patchwork.freedesktop.org/api/1.0/series/3688/revisions/4/mbox/ Test kms_fl

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/gen9: Sanitize handling of allowed DC states

2016-03-01 Thread Patrik Jakobsson
On Mon, Feb 29, 2016 at 10:49:03PM +0200, Imre Deak wrote: > We can simplify the conditions selecting the target DC state during > runtime by calculating the allowed DC states in advance during driver > loading. This also makes it easier to disable DC states depending on the > i915.disable_power_we

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/gen9: Disable DC states if power well support is disabled

2016-03-01 Thread Patrik Jakobsson
On Mon, Feb 29, 2016 at 10:49:04PM +0200, Imre Deak wrote: > If power well support is disabled via the i915.disable_power_well module > option we should never enable DC states. Currently we would enable DC > states even in this case during system suspend, where we need to disable > all power wells

Re: [Intel-gfx] [PATCH v6 3/7] drm/i915: introduce and use i915_gem_object_vmap_range()

2016-03-01 Thread Dave Gordon
On 01/03/16 10:12, Tvrtko Ursulin wrote: On 29/02/16 21:16, Dave Gordon wrote: From: Alex Dai There are several places inside driver where a GEM object is mapped to kernel virtual space. The mapping may be done either for the whole object or only a subset of it. This patch introduces a funct

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Allow preservation of watermarks.

2016-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Allow preservation of watermarks. URL : https://patchwork.freedesktop.org/series/3958/ State : failure == Summary == Series 3958v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/3958/revisions/1/mbox

[Intel-gfx] [PATCH] drm/i915: Move CSB MMIO reads out of the execlists lock

2016-03-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By reading the CSB (slow MMIO accesses) into a temporary local buffer we can decrease the duration of holding the execlist lock. Main advantage is that during heavy batch buffer submission we reduce the execlist lock contention, which should decrease the latency and CPU usag

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: add spam for force-load-detect

2016-03-01 Thread Patchwork
== Series Details == Series: drm/i915: add spam for force-load-detect URL : https://patchwork.freedesktop.org/series/3964/ State : warning == Summary == Series 3964v1 drm/i915: add spam for force-load-detect http://patchwork.freedesktop.org/api/1.0/series/3964/revisions/1/mbox/ Test kms_flip:

[Intel-gfx] [PATCH v2.1 3/6] drm/atomic: Always call steal_encoder, v2.

2016-03-01 Thread Maarten Lankhorst
There's no need to have a separate function to get the crtc which is stolen, this can already be found when actually stealing the encoder. drm_for_each_connector already checks for connection_mutex, so use that macro now. Changes since v1: - Do not check for NULL crtc in connector_state, this m

[Intel-gfx] [PATCH v2] drm/i915: Disable FDI RX before DDI_BUF_CTL

2016-03-01 Thread ville . syrjala
From: Ville Syrjälä Bspec is confused w.r.t. the HSW/BDW FDI disable sequence. It lists FDI RX disable both as step 13 and step 18 in the sequence. But I dug up an old BUN mail from Art that moved the FDI RX disable to happen before DDI_BUF_CTL disable. That BUN did not renumber the steps and jus

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/error: Capture WA ctx batch in error state

2016-03-01 Thread Patchwork
== Series Details == Series: drm/i915/error: Capture WA ctx batch in error state URL : https://patchwork.freedesktop.org/series/3968/ State : warning == Summary == Series 3968v1 drm/i915/error: Capture WA ctx batch in error state http://patchwork.freedesktop.org/api/1.0/series/3968/revisions/1

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Move CSB MMIO reads out of the execlists lock

2016-03-01 Thread Patchwork
== Series Details == Series: drm/i915: Move CSB MMIO reads out of the execlists lock URL : https://patchwork.freedesktop.org/series/3973/ State : warning == Summary == Series 3973v1 drm/i915: Move CSB MMIO reads out of the execlists lock http://patchwork.freedesktop.org/api/1.0/series/3973/rev

Re: [Intel-gfx] [PATCH v5 10/35] drm/i915: Added scheduler hook when closing DRM file handles

2016-03-01 Thread John Harrison
On 01/03/2016 08:59, Joonas Lahtinen wrote: On to, 2016-02-18 at 14:26 +, john.c.harri...@intel.com wrote: From: John Harrison The scheduler decouples the submission of batch buffers to the driver with submission of batch buffers to the hardware. Thus it is possible for an application to c

Re: [Intel-gfx] [PATCH i-g-t v4 2/2] tests/drv_hangman: test for acthd increasing through invalid VM space

2016-03-01 Thread Mika Kuoppala
daniele.ceraolospu...@intel.com writes: > From: Daniele Ceraolo Spurio > > The hangcheck logic will not flag an hang if acthd keeps increasing. > However, if a malformed batch jumps to an invalid offset in the ppgtt it > can potentially continue executing through the whole address space > without

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/error: Capture WA ctx batch in error state

2016-03-01 Thread Arun Siluvery
On 01/03/2016 14:01, Patchwork wrote: == Series Details == Series: drm/i915/error: Capture WA ctx batch in error state URL : https://patchwork.freedesktop.org/series/3968/ State : warning == Summary == Series 3968v1 drm/i915/error: Capture WA ctx batch in error state http://patchwork.freedes

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/error: Capture WA ctx batch in error state

2016-03-01 Thread Tvrtko Ursulin
On 01/03/16 15:05, Arun Siluvery wrote: On 01/03/2016 14:01, Patchwork wrote: == Series Details == Series: drm/i915/error: Capture WA ctx batch in error state URL : https://patchwork.freedesktop.org/series/3968/ State : warning == Summary == Series 3968v1 drm/i915/error: Capture WA ctx bat

Re: [Intel-gfx] [PATCH v5 12/35] drm/i915: Added deferred work handler for scheduler

2016-03-01 Thread John Harrison
On 01/03/2016 09:16, Joonas Lahtinen wrote: On to, 2016-02-18 at 14:27 +, john.c.harri...@intel.com wrote: From: John Harrison The scheduler needs to do interrupt triggered work that is too complex to do in the interrupt handler. Thus it requires a deferred work handler to process such tas

Re: [Intel-gfx] [PATCH v2 1/6] drm/atomic: Clean up update_output_state.

2016-03-01 Thread Ville Syrjälä
On Wed, Feb 24, 2016 at 09:37:28AM +0100, Maarten Lankhorst wrote: > With the addition of crtc_state->connector_mask other connectors from > different crtc's aren't needed any more to determine if a crtc has > connectors, so only call add_affected_connectors on the target crtc. > This allows a clea

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable FDI RX before DDI_BUF_CTL (rev2)

2016-03-01 Thread Patchwork
== Series Details == Series: drm/i915: Disable FDI RX before DDI_BUF_CTL (rev2) URL : https://patchwork.freedesktop.org/series/1582/ State : failure == Summary == Series 1582v2 drm/i915: Disable FDI RX before DDI_BUF_CTL http://patchwork.freedesktop.org/api/1.0/series/1582/revisions/2/mbox/ T

Re: [Intel-gfx] [PATCH v6 4/7] drm/i915: Delay the freeing of requests until retire time

2016-03-01 Thread Maarten Lankhorst
Hey, Op 18-02-16 om 15:24 schreef john.c.harri...@intel.com: > From: John Harrison > > The request structure is reference counted. When the count reached > zero, the request was immediately freed and all associated objects > were unrefereced/unallocated. This meant that the driver mutex lock > mu

Re: [Intel-gfx] [PATCH v2 2/6] drm/atomic: Pass connector and state to update_connector_routing.

2016-03-01 Thread Ville Syrjälä
On Wed, Feb 24, 2016 at 09:37:29AM +0100, Maarten Lankhorst wrote: > Minor cleanup, connector and connector_state are always non-NULL here. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_atomic_helper.c | 15 +-- > 1 file changed, 5 ins

[Intel-gfx] [PATCH 2/2] man: update intel_reg.rst to be more in line with the others

2016-03-01 Thread Jani Nikula
Use the definitions and formatting used in other man pages, etc. Signed-off-by: Jani Nikula --- man/intel_reg.rst | 106 ++ 1 file changed, 42 insertions(+), 64 deletions(-) diff --git a/man/intel_reg.rst b/man/intel_reg.rst index d90c307d8379

[Intel-gfx] [PATCH 1/2] man: rewrite manual pages in reStructuredText

2016-03-01 Thread Jani Nikula
intel_reg.rst was the first man page written in reStructuredText. Follow suit with the rest of the man pages. Add a generated defs.rst include file for definitions such as intel-gpu-tools version. This replaces the MAN_SUBSTS sed script substitutions from xorg-macros for old man pages. Signed-off

Re: [Intel-gfx] [PATCH i-g-t 2/4] tests/gem_scheduler: Add gem_scheduler test

2016-03-01 Thread Morton, Derek J
> > >-Original Message- >From: Ceraolo Spurio, Daniele >Sent: Wednesday, February 17, 2016 12:37 PM >To: Morton, Derek J ; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH i-g-t 2/4] tests/gem_scheduler: Add >gem_scheduler test > >Hi, > >first round of comments inline. A f

Re: [Intel-gfx] [PATCH v5 25/35] drm/i915: Added scheduler queue throttling by DRM file handle

2016-03-01 Thread John Harrison
On 23/02/2016 21:02, Jesse Barnes wrote: On 02/18/2016 06:27 AM, john.c.harri...@intel.com wrote: From: John Harrison The scheduler decouples the submission of batch buffers to the driver from their subsequent submission to the hardware. This means that an application which is continuously sub

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable FDI RX before DDI_BUF_CTL (rev2)

2016-03-01 Thread Ville Syrjälä
On Tue, Mar 01, 2016 at 02:55:54PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Disable FDI RX before DDI_BUF_CTL (rev2) > URL : https://patchwork.freedesktop.org/series/1582/ > State : failure > > == Summary == > > Series 1582v2 drm/i915: Disable FDI RX before DDI_BUF_

[Intel-gfx] [PATCH] drm/i915: Do not return unknown status when load detection is tested.

2016-03-01 Thread Maarten Lankhorst
This fixes the IGT test, which interprets unknown status as failed to acquire load detect pipe. Cc: Gabriel Feceoru Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_crt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.14

2016-03-01 Thread Marius Vlad
A new intel-gpu-tools quarterly release is available with the following changes: - New test: gem_create validate parameters for GEM_CREATE ioctl (Ankitprasad Sharma) - New test: gem_softpin exercise the userptr ioctl to create shared buffers between CPU and GPU (Vinay Belgaumkar) - New tests: pr

[Intel-gfx] [PATCH] drm/i915: Avoid snooping with userptr where not supported

2016-03-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin commit e5756c10d841ddb448293c849392f3d6b809561f Author: Imre Deak Date: Fri Aug 14 18:43:30 2015 +0300 drm/i915/bxt: don't allow cached GEM mappings on A stepping Added an exception of disallowing snooping for Broxton A stepping hardware but userptr was s

[Intel-gfx] [PATCH v7 7/7] drm: add parameter-order checking to drm memory allocators

2016-03-01 Thread Dave Gordon
After the recent addition of drm_malloc_gfp(), it was noticed that some callers of these functions has swapped the parameters in the call - it's supposed to be 'number of members' and 'sizeof(element)', but a few callers had got the size first and the count second. This isn't otherwise detected bec

[Intel-gfx] [PATCH v7 5/7] drm/i915: optimise i915_gem_object_vmap_range() for small objects

2016-03-01 Thread Dave Gordon
We're using this function for ringbuffers and other "small" objects, so it's worth avoiding an extra malloc()/free() cycle if the page array is small enough to put on the stack. Here we've chosen an arbitrary cutoff of 32 (4k) pages, which is big enough for a ringbuffer (4 pages) or a context image

[Intel-gfx] [PATCH v7 3/7] drm,i915: introduce drm_malloc_gfp()

2016-03-01 Thread Dave Gordon
From: Chris Wilson I have instances where I want to use drm_malloc_ab() but with a custom gfp mask. And with those, where I want a temporary allocation, I want to try a high-order kmalloc() before using a vmalloc(). So refactor my usage into drm_malloc_gfp(). Signed-off-by: Chris Wilson Cc: dr

[Intel-gfx] [PATCH v7 0/7] Reorganise calls to vmap() GEM objects

2016-03-01 Thread Dave Gordon
Alex Dai and Chris Wilson have both recently posted patches to rationalise the use of vmap() for mapping GEM objects into kernel virtual space. However, they addressed different areas, with Alex's patch being derived from the copy_batch() code, whereas Chris' patch refactored the dma-buf and ringbu

[Intel-gfx] [PATCH v7 4/7] drm/i915: introduce and use i915_gem_object_vmap_range()

2016-03-01 Thread Dave Gordon
From: Alex Dai There are several places inside driver where a GEM object is mapped to kernel virtual space. The mapping may be done either for the whole object or only a subset of it. This patch introduces a function i915_gem_object_vmap_range() to implement the common functionality. The code it

[Intel-gfx] [PATCH v7 2/7] drm/i915: move locking in i915_gem_unmap_dma_buf()

2016-03-01 Thread Dave Gordon
From: Chris Wilson The struct_mutex doesn't need to be (and therefore shouldn't be) held around the various non-i915 operations in this function. We only need the struct_mutex when we get to the unpin_pages() call. Extracted from Chris Wilson's patch: drm/i915: Refactor duplicate object vmap

[Intel-gfx] [PATCH v7 6/7] drm/i915: refactor duplicate object vmap functions (the final rework?)

2016-03-01 Thread Dave Gordon
This is essentially Chris Wilson's patch of a similar name, reworked on top of Alex Dai's recent patch: | drm/i915: Add i915_gem_object_vmap to map GEM object to virtual space Chris' original commentary said: | We now have two implementations for vmapping a whole object, one for | dma-buf and one

[Intel-gfx] [PATCH v7 1/7] drm/i915: deduplicate intel_pin_and_map_ringbuffer_obj() error handling

2016-03-01 Thread Dave Gordon
From: Chris Wilson Replace multiple "unpin(); return errno;" sequences with a branch to a single common label for all the error paths. Extracted from Chris Wilson's patch: drm/i915: Refactor duplicate object vmap functions in preparation for the reimplementation of the same. Signed-off-by:

[Intel-gfx] [PATCH i-g-t 2/2] lib/igt_fb: Fix gen2 and 915 Y tile sizes

2016-03-01 Thread ville . syrjala
From: Ville Syrjälä gen2 tile dimensions are 128x32 for both X and Y tiling 915 tile dimensions are 512x8 for both X and Y tiling Fix igt_get_fb_tile_size() to return the correct Y tile dimensions for these platforms. X tile was fine already. Cc: Paulo Zanoni Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH i-g-t 1/2] lib/igt_kms: Fix igt_fb_set_size() debug message

2016-03-01 Thread ville . syrjala
From: Ville Syrjälä The debug message in igt_fb_set_size() was copy pasted from igt_fb_set_position() and not adjusted to say the right thing. Fix it up. Signed-off-by: Ville Syrjälä --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_k

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Use a crtc mask instead of a refcount for dpll functions.

2016-03-01 Thread R, Durgadoss
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Maarten Lankhorst >Sent: Monday, February 29, 2016 6:22 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 1/4] drm/i915: Use a crtc mask instead of a >refcount for dpll f

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Do not return unknown status when load detection is tested.

2016-03-01 Thread Patchwork
== Series Details == Series: drm/i915: Do not return unknown status when load detection is tested. URL : https://patchwork.freedesktop.org/series/3978/ State : failure == Summary == Series 3978v1 drm/i915: Do not return unknown status when load detection is tested. http://patchwork.freedeskto

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Perform dpll commit first.

2016-03-01 Thread R, Durgadoss
Hi Maarten, >-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Maarten Lankhorst >Sent: Monday, February 29, 2016 6:22 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 2/4] drm/i915: Perform dpll commit first. > >Warn fo

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Move pll power state to crtc power domains.

2016-03-01 Thread R, Durgadoss
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Maarten Lankhorst >Sent: Monday, February 29, 2016 6:22 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 3/4] drm/i915: Move pll power state to crtc power >domains. > >S

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add locking to pll updates.

2016-03-01 Thread R, Durgadoss
Hi Maarten, >-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Maarten Lankhorst >Sent: Monday, February 29, 2016 6:22 PM >To: intel-gfx@lists.freedesktop.org >Subject: [Intel-gfx] [PATCH 4/4] drm/i915: Add locking to pll updates. > >With a

Re: [Intel-gfx] [PATCH] drm/i915: Avoid snooping with userptr where not supported

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 04:29:35PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > >commit e5756c10d841ddb448293c849392f3d6b809561f >Author: Imre Deak >Date: Fri Aug 14 18:43:30 2015 +0300 > >drm/i915/bxt: don't allow cached GEM mappings on A stepping > > Added an e

[Intel-gfx] [PATCH 2/2] drm/i915/guc: Reset GuC and retry on firmware load failure

2016-03-01 Thread Arun Siluvery
Due to timing issues in the HW some of the status bits required for GuC authentication doesn't get set occassionally, when that happens, GuC cannot be initialized and we will be left with a wedged GPU. The WA suggested is to perform a soft reset of GuC and attempt to reload the fw again for few tim

[Intel-gfx] [PATCH 1/2] drm/i915/tdr: Add helper function to perform Engine reset

2016-03-01 Thread Arun Siluvery
This patch only adds a function to reset an engine and it is in preparation for the complete engine reset feature. At the moment this is only made available from Gen8 onwards. v2: use indexed initialization and keep everything under forcewake (Dave) Cc: Dave Gordon Cc: Mika Kuoppala Signed-off

[Intel-gfx] [PATCH 0/2] Reset GuC and retry on fw load failure

2016-03-01 Thread Arun Siluvery
Below changes add a mechanism to reset GuC and retry fw loading if the initial load fails. There are cetain HW issues because of which fw load can fail and the WA is to retry after resetting GuC. A patch from engine reset series (which are under review) is sneaked in here as this changes reuses so

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid snooping with userptr where not supported

2016-03-01 Thread Patchwork
== Series Details == Series: drm/i915: Avoid snooping with userptr where not supported URL : https://patchwork.freedesktop.org/series/3979/ State : failure == Summary == Series 3979v1 drm/i915: Avoid snooping with userptr where not supported http://patchwork.freedesktop.org/api/1.0/series/3979

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/4] drm/i915/skl: Fix power domain suspend sequence

2016-03-01 Thread Imre Deak
On ti, 2016-03-01 at 12:14 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/4] drm/i915/skl: Fix power domain > suspend sequence > URL   : https://patchwork.freedesktop.org/series/3931/ > State : warning > > == Summary == > > Series 3931v1 Series without cove

Re: [Intel-gfx] [PATCH v2 5/6] drm/atomic: Handle encoder assignment conflicts in a separate check.

2016-03-01 Thread Ville Syrjälä
On Wed, Feb 24, 2016 at 09:37:32AM +0100, Maarten Lankhorst wrote: > The current check doesn't handle the case where we don't steal an > encoder, but keep it on the current connector. If we repurpose > disable_conflicting_encoders to do the checking, we just have > to reject the ones that conflict.

Re: [Intel-gfx] [PATCH] drm/i915: Avoid snooping with userptr where not supported

2016-03-01 Thread Tvrtko Ursulin
On 01/03/16 17:14, Chris Wilson wrote: On Tue, Mar 01, 2016 at 04:29:35PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin commit e5756c10d841ddb448293c849392f3d6b809561f Author: Imre Deak Date: Fri Aug 14 18:43:30 2015 +0300 drm/i915/bxt: don't allow cached GEM mappi

[Intel-gfx] The mysterious case of IRQs, failed DP aux ch transactions, and Skylake

2016-03-01 Thread Lyude
Hi! Daniel Vetter referred me to you since you're a hardware guy, and also suggested I include the whole intel-gfx list on this. So as of late I've been testing the mainline kernel on some new production Skylake machines. While it worked perfectly on most of them, I've been stumped with a weird is

Re: [Intel-gfx] [PATCH] drm/i915: Do not return unknown status when load detection is tested.

2016-03-01 Thread Ville Syrjälä
On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote: > This fixes the IGT test, which interprets unknown status as failed to > acquire load detect pipe. Change the expectation of the test? But more importantly, how can it fail to find a pipe when there's kmstest_unset_all_crtcs() in

Re: [Intel-gfx] [PATCH] drm/i915: Avoid snooping with userptr where not supported

2016-03-01 Thread Chris Wilson
On Tue, Mar 01, 2016 at 05:21:49PM +, Tvrtko Ursulin wrote: > > On 01/03/16 17:14, Chris Wilson wrote: > >On Tue, Mar 01, 2016 at 04:29:35PM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>commit e5756c10d841ddb448293c849392f3d6b809561f > >>Author: Imre Deak > >>Da

Re: [Intel-gfx] [PATCH v7 4/7] drm/i915: introduce and use i915_gem_object_vmap_range()

2016-03-01 Thread Tvrtko Ursulin
On 01/03/16 16:33, Dave Gordon wrote: From: Alex Dai There are several places inside driver where a GEM object is mapped to kernel virtual space. The mapping may be done either for the whole object or only a subset of it. This patch introduces a function i915_gem_object_vmap_range() to imple

Re: [Intel-gfx] [PATCH] drm/i915: Do not return unknown status when load detection is tested.

2016-03-01 Thread Maarten Lankhorst
Op 01-03-16 om 18:27 schreef Ville Syrjälä: > On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote: >> This fixes the IGT test, which interprets unknown status as failed to >> acquire load detect pipe. > Change the expectation of the test? > > But more importantly, how can it fail to f

Re: [Intel-gfx] [PATCH v2 5/6] drm/atomic: Handle encoder assignment conflicts in a separate check.

2016-03-01 Thread Maarten Lankhorst
Op 01-03-16 om 18:21 schreef Ville Syrjälä: > On Wed, Feb 24, 2016 at 09:37:32AM +0100, Maarten Lankhorst wrote: >> The current check doesn't handle the case where we don't steal an >> encoder, but keep it on the current connector. If we repurpose >> disable_conflicting_encoders to do the checking,

Re: [Intel-gfx] [PATCH v2 5/6] drm/atomic: Handle encoder assignment conflicts in a separate check.

2016-03-01 Thread Ville Syrjälä
On Tue, Mar 01, 2016 at 06:45:53PM +0100, Maarten Lankhorst wrote: > Op 01-03-16 om 18:21 schreef Ville Syrjälä: > > On Wed, Feb 24, 2016 at 09:37:32AM +0100, Maarten Lankhorst wrote: > >> The current check doesn't handle the case where we don't steal an > >> encoder, but keep it on the current con

Re: [Intel-gfx] [PATCH] drm/i915: Do not return unknown status when load detection is tested.

2016-03-01 Thread Ville Syrjälä
On Tue, Mar 01, 2016 at 06:46:51PM +0100, Maarten Lankhorst wrote: > Op 01-03-16 om 18:27 schreef Ville Syrjälä: > > On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote: > >> This fixes the IGT test, which interprets unknown status as failed to > >> acquire load detect pipe. > > Chang

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Only recalculate wm's for planes part of the state, v2.

2016-03-01 Thread Matt Roper
On Tue, Mar 01, 2016 at 11:07:22AM +0100, Maarten Lankhorst wrote: > Only planes that are part of the state should be used for recalculating > watermarks. For planes not part of the state the previous patch allows > us to re-use the old values since they're calculated even for levels > that are not

[Intel-gfx] [PATCH i-g-t v2] tests: Adding kms_dp_aux_dev test.

2016-03-01 Thread Rafael Antognolli
This new test makes some basic testing on the proposed drm_dp_aux_dev interface. If the feature is enabled and the drm_dp_aux_dev class is present, it will check for available DP aux channels and test them for: - basic seek to 0 and read 1 byte - seek to the last address and read, t

[Intel-gfx] [PATCH] drm/i915: Treat cursor plane as another sprite plane for BSW

2016-03-01 Thread Dhinakaran Pandiyan
From: Maarten Lankhorst Work around the CHV pipe C FIFO underruns that cause display failure by enabling sprite plane for cursor. This patch for BSW is based on Maarten Lankhorst's work that enables universal plane support. Signed-off-by: Maarten Lankhorst Signed-off-by: Kalyan Kondapally Sig

[Intel-gfx] [PATCH] intel: Adding missing Broxton PCI IDs.

2016-03-01 Thread Rodrigo Vivi
These IDs were already part of the kernel since: kernel commit 985dd4360fdf2533fe48a33a4a2094f2e4718dc0 Author: Imre Deak Date: Thu Jan 28 16:04:12 2016 +0200 drm/i915/bxt: update list of PCIIDs Signed-off-by: Rodrigo Vivi Cc: Venkateswarlu Vinjamuri --- intel/intel_chipset.h | 6 +

[Intel-gfx] [PATCH] drm/i915: add audio_ptr pointer check

2016-03-01 Thread libin . yang
From: Libin Yang check to make sure audio_ptr is not NULL before using it. Signed-off-by: Libin Yang --- drivers/gpu/drm/i915/intel_audio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 3

  1   2   >