[Intel-gfx] [PATCH] drm/i915/csr: Allow matching unknown HW steppings with generic firmware

2016-03-07 Thread Chris Wilson
If the firmware is generic and has a run-anywhere mode, enable it rather than completely failing on unknown HW revisions. Signed-off-by: Chris Wilson Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Cc: Daniel Vetter Cc: Animesh Manna Cc: Jani Nikula --- This is probably stable@ material s

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen9: fix DMC firmware initialization (rev2)

2016-03-07 Thread Imre Deak
On ma, 2016-03-07 at 11:23 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen9: fix DMC firmware initialization (rev2) > URL   : https://patchwork.freedesktop.org/series/4121/ > State : failure > > == Summary == > > Series 4121v2 drm/i915/gen9: fix DMC firmware initializatio

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Wait until after wm optimization to drop runtime PM reference

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Wait until after wm optimization to drop runtime PM reference URL : https://patchwork.freedesktop.org/series/4135/ State : failure == Summary == Series 4135v1 drm/i915: Wait until after wm optimization to drop runtime PM reference http://patchwork.freede

Re: [Intel-gfx] [PATCH v5 23/35] drm/i915: Defer seqno allocation until actual hardware submission time

2016-03-07 Thread Joonas Lahtinen
On to, 2016-02-18 at 14:27 +, john.c.harri...@intel.com wrote: > From: John Harrison > > The seqno value is now only used for the final test for completion of > a request. It is no longer used to track the request through the > software stack. Thus it is no longer necessary to allocate the se

Re: [Intel-gfx] [PATCH] drm/i915: Fix bogus dig_port_map[] assignment for pre-HSW

2016-03-07 Thread Martin Kepplinger
Am 2016-03-03 um 16:05 schrieb Takashi Iwai: > On Mon, 29 Feb 2016 15:39:53 +0100, > Jani Nikula wrote: >> >> On Mon, 29 Feb 2016, Martin Kepplinger wrote: >>> Am 2016-02-26 um 20:59 schrieb Takashi Iwai: Sorry, Cc to Jani was missing mistakenly. Please check this. It's a regressio

[Intel-gfx] ✗ Fi.CI.BAT: failure for HDMI Audio support on Atom w/o HDAUdio

2016-03-07 Thread Patchwork
== Series Details == Series: HDMI Audio support on Atom w/o HDAUdio URL : https://patchwork.freedesktop.org/series/4142/ State : failure == Summary == Series 4142v1 HDMI Audio support on Atom w/o HDAUdio http://patchwork.freedesktop.org/api/1.0/series/4142/revisions/1/mbox/ Test kms_flip:

Re: [Intel-gfx] [PATCH v5 27/35] drm/i915: Added debug state dump facilities to scheduler

2016-03-07 Thread Joonas Lahtinen
Hi, On to, 2016-02-18 at 14:27 +, john.c.harri...@intel.com wrote: > From: John Harrison > > When debugging batch buffer submission issues, it is useful to be able > to see what the current state of the scheduler is. This change adds > functions for decoding the internal scheduler state and

Re: [Intel-gfx] [PATCH i-g-t v2 2/7] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks

2016-03-07 Thread Dave Gordon
On 07/03/16 11:56, Dave Gordon wrote: On 02/03/16 18:10, Derek Morton wrote: Some platforms have ring BSD available but no BSD2. Because of the current verification, tests involving ring BSD1 will be skipped if no BSD2 is available. Decoupling the checks will allow running the BSD1 specific tes

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9: Fix DMC firmware initialization

2016-03-07 Thread Mika Kuoppala
Imre Deak writes: > [ text/plain ] > In commit 1e657ad7 we moved the last step of firmware initialization to > skl_display_core_init(), where it will be run only during system resume, > but not during driver loading. Since this init step needs to be done > whenever we program the firmware fix thi

Re: [Intel-gfx] [PATCH i-g-t v2 4/7] tests/gem_scheduler: Add gem_scheduler test

2016-03-07 Thread Dave Gordon
On 02/03/16 20:15, Chris Wilson wrote: +static struct ring { + const char *name; + int id; + bool exists; +} rings[] = { + { "render", I915_EXEC_RENDER, false }, + { "bsd1",I915_EXEC_BSD | 1<<13, false }, + { "bsd2",I915_EXEC_BSD | 2<<13, false }, Thi

[Intel-gfx] ✗ Fi.CI.BAT: failure for Haswell Command Parser updates for Vulkan

2016-03-07 Thread Patchwork
== Series Details == Series: Haswell Command Parser updates for Vulkan URL : https://patchwork.freedesktop.org/series/4168/ State : failure == Summary == Series 4168v1 Haswell Command Parser updates for Vulkan http://patchwork.freedesktop.org/api/1.0/series/4168/revisions/1/mbox/ Test kms_fli

Re: [Intel-gfx] [PATCH i-g-t v7] lib/igt_kms: Add COMMIT_ATOMIC to igt_display_commit2()

2016-03-07 Thread Lionel Landwerlin
Hi Pratik, I'm really looking forward to get this merged. Just a few comments on the plane commit part below. Cheers, - Lionel On 07/03/16 10:18, Pratik Vishwakarma wrote: From: Mayuresh Gharpure Co-Author : Marius Vlad Co-Author : Pratik Vishwakarma So far we have had only two commit st

Re: [Intel-gfx] [PATCH i-g-t v7] lib/igt_kms: Add COMMIT_ATOMIC to igt_display_commit2()

2016-03-07 Thread Lionel Landwerlin
Hi Pratik, I'm really looking forward to get this merged. Just a few comments on the plane commit part below. Cheers, - Lionel On 07/03/16 10:18, Pratik Vishwakarma wrote: From: Mayuresh Gharpure Co-Author : Marius Vlad Co-Author : Pratik Vishwakarma So far we have had only two commit st

[Intel-gfx] [PATCH 3/3] drm/i915: Add backlight Control using DPCD registers for DP connectors

2016-03-07 Thread Yetunde Adebisi
This patch enables support for DPCD backlight control for DP connectors. The VESA spec defines DPCD backlight control only for eDP but some add-on cards like the Chrontel CH7511B DP-LVDS cards have the display control DPCD registers enabled. This patch registers a backlight device exposed via sysfs

[Intel-gfx] [PATCH 2/3] drm/i915: Add Backlight Control using DPCD for eDP connectors (v7)

2016-03-07 Thread Yetunde Adebisi
This patch adds support for eDP backlight control using DPCD registers to backlight hooks in intel_panel. It checks for backlight control over AUX channel capability and sets up function pointers to get and set the backlight brightness level if supported. v2: Moved backlight functions from intel_

[Intel-gfx] [PATCH 0/3] DPCD Backlight Control

2016-03-07 Thread Yetunde Adebisi
These patches add support for Backlight Control using DPCD registers on eDP displays. - Patch 1 adds macro for DPCD registers capability size to drm_dp_helper.h A copy of this patch has also been sent to dri-devel list. - Patch 2 Implements functionaly for DPCD Backlight Control - Patch 3 Impl

[Intel-gfx] [PATCH 1/3] drm/dp: Add definition for Display Control DPCD Registers capability size

2016-03-07 Thread Yetunde Adebisi
This is used when reading Display Control capability Registers on the sink device. cc: Jani Nikula Signed-off-by: Yetunde Adebisi --- include/drm/drm_dp_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 1252108..92d9a52

Re: [Intel-gfx] [PATCH] drm/i915/csr: Allow matching unknown HW steppings with generic firmware

2016-03-07 Thread Imre Deak
On ma, 2016-03-07 at 12:05 +, Chris Wilson wrote: > If the firmware is generic and has a run-anywhere mode, enable it rather > than completely failing on unknown HW revisions. > Signed-off-by: Chris Wilson > Cc: Damien Lespiau > Cc: Imre Deak > Cc: Sunil Kamath > Cc: Daniel Vetter > Cc: An

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen9: fix DMC firmware initialization (rev2)

2016-03-07 Thread Imre Deak
On ma, 2016-03-07 at 14:09 +0200, Imre Deak wrote: > On ma, 2016-03-07 at 11:23 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/gen9: fix DMC firmware initialization (rev2) > > URL   : https://patchwork.freedesktop.org/series/4121/ > > State : failure > > > > == Summary

Re: [Intel-gfx] [PATCH] drm/i915/csr: Allow matching unknown HW steppings with generic firmware

2016-03-07 Thread Chris Wilson
On Mon, Mar 07, 2016 at 03:12:40PM +0200, Imre Deak wrote: > On ma, 2016-03-07 at 12:05 +, Chris Wilson wrote: > > If the firmware is generic and has a run-anywhere mode, enable it rather > > than completely failing on unknown HW revisions. > > Signed-off-by: Chris Wilson > > Cc: Damien Lespia

[Intel-gfx] [PATCH igt] igt/pm_rpm: Wait for PCI D3

2016-03-07 Thread Chris Wilson
The transition to PCI device state D3 is not instantaneous and only started when runtime suspended. Allow the driver/hardware a little bit of time to complete the transition before declaring a test failure. References: https://bugs.freedesktop.org/show_bug.cgi?id=93123 Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

2016-03-07 Thread Ville Syrjälä
On Fri, Mar 04, 2016 at 03:49:02PM -0800, Matt Roper wrote: > On Fri, Mar 04, 2016 at 12:52:41PM +0200, Ville Syrjälä wrote: > > On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > > > If all pipes are off, then we may have entered runtime suspend and > > > writing these registers will ha

[Intel-gfx] [drm-intel:drm-intel-nightly 1/9] drivers/gpu/drm/i915/intel_runtime_pm.c:510:13: error: redefinition of 'gen9_write_dc_state'

2016-03-07 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly head: f49783f8d8ee8d80539c7c2cf3c64f0dc6c230c6 commit: e71a6789aadcab1dc6c0180b52f59b901ca099f4 [1/9] Merge remote-tracking branch 'origin/drm-intel-next-queued' into drm-intel-nightly config: x86_64-rhel (attached as .config) rep

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Some GT freq stuff

2016-03-07 Thread Ville Syrjälä
On Mon, Mar 07, 2016 at 10:34:26AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Some GT freq stuff > URL : https://patchwork.freedesktop.org/series/4129/ > State : failure > > == Summary == > > Series 4129v1 drm/i915: Some GT freq stuff > http://patchwork.freedesktop.or

[Intel-gfx] [PATCH i-g-t] scripts: Adapt run-tests.sh to the piglit changes

2016-03-07 Thread Gabriel Feceoru
Piglit changed its behaviour to prevent overwriting the results directory unless explicitly specified with -o Added -o flag in run-tests.sh to keep user experience. Signed-off-by: Gabriel Feceoru --- scripts/run-tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/script

Re: [Intel-gfx] [PATCH igt] igt/pm_rpm: Wait for PCI D3

2016-03-07 Thread Patrik Jakobsson
On Mon, Mar 07, 2016 at 02:19:10PM +, Chris Wilson wrote: > The transition to PCI device state D3 is not instantaneous and only > started when runtime suspended. Allow the driver/hardware a little bit > of time to complete the transition before declaring a test failure. > > References: https:/

Re: [Intel-gfx] [PATCH] drm/i915/csr: Allow matching unknown HW steppings with generic firmware

2016-03-07 Thread Imre Deak
On ma, 2016-03-07 at 13:39 +, Chris Wilson wrote: > On Mon, Mar 07, 2016 at 03:12:40PM +0200, Imre Deak wrote: > > On ma, 2016-03-07 at 12:05 +, Chris Wilson wrote: > > > If the firmware is generic and has a run-anywhere mode, enable it > > > rather > > > than completely failing on unknown

[Intel-gfx] [PATCH 1/4] drm/i915: Actually retry with bit-banging after GMBUS timeout

2016-03-07 Thread ville . syrjala
From: Ville Syrjälä After the GMBUS transfer times out, we set force_bit=1 and return -EAGAIN expecting the i2c core to call the .master_xfer hook again so that we will retry the same transfer via bit-banging. This is in case the gmbus hardware is somehow faulty. Unfortunately we left adapter->r

[Intel-gfx] [PATCH 2/4] drm/i915: Protect force_bit with gmbus_mutex

2016-03-07 Thread ville . syrjala
From: Ville Syrjälä Extend the protection of gmbus_mutex around the force_bit RMW in intel_gmbus_force_bit(), in case someone gets the idea of calling it from a separate thread while there's other stuff happening on the same bus. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_i2c.

[Intel-gfx] [PATCH 4/4] drm/i915: Make GMBUS timeout message DRM_DEBUG_KMS

2016-03-07 Thread ville . syrjala
From: Ville Syrjälä There's no real reason the user should care that we're about to fall back to bitbanging, so let's change the message from DRM_INFO to DRM_DEBUG_KMS. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH 0/4] drm/i915: GMBUS fixes and whatnot

2016-03-07 Thread ville . syrjala
From: Ville Syrjälä While I was frobbing around with DP++ dongles I noticed that out GMBUS bit-banging fallbacks weren't working as I was expecting, so after a bit of digging around I came up wit these patches. Ville Syrjälä (4): drm/i915: Actually retry with bit-banging after GMBUS timeout

[Intel-gfx] [PATCH 3/4] drm/i915: Restore GMBUS operation after a failed bit-banging fallback

2016-03-07 Thread ville . syrjala
From: Ville Syrjälä When the GMBUS based i2c transfer times out, we try to fall back to bit-banging and retry the operation that way. However if the bit-banging attempt also fails, we should probably go back to the GMBUS method for the next attempt. Maybe there simply wasn't anyone one the bus at

Re: [Intel-gfx] [i-g-t PATCH v1 12/14] kms_addfb_basic: Split tiling_tests off

2016-03-07 Thread Tomeu Vizoso
On 03/05/2016 01:33 PM, Daniel Vetter wrote: > On Wed, Mar 02, 2016 at 03:00:19PM +0100, Tomeu Vizoso wrote: >> Move tests requiring tiled BOs to the end so they don't cause unrelated >> subtests to be skipped when testing drivers with only dumb buffer >> support. > > This uncovers a deficiency in

Re: [Intel-gfx] [PATCH] drm/i915: Wait until after wm optimization to drop runtime PM reference

2016-03-07 Thread Matt Roper
On Sat, Mar 05, 2016 at 03:25:05AM +0200, Imre Deak wrote: > Hi Matt, > > On Fri, 2016-03-04 at 15:59 -0800, Matt Roper wrote: > > At the end of an atomic commit, we currently wait for vblanks to > > complete, call put() on the various runtime PM references, and then > > try > > to optimize our wa

Re: [Intel-gfx] [PATCH igt] igt/pm_rpm: Wait for PCI D3

2016-03-07 Thread Chris Wilson
On Mon, Mar 07, 2016 at 04:41:55PM +0100, Patrik Jakobsson wrote: > On Mon, Mar 07, 2016 at 02:19:10PM +, Chris Wilson wrote: > > The transition to PCI device state D3 is not instantaneous and only > > started when runtime suspended. Allow the driver/hardware a little bit > > of time to complet

Re: [Intel-gfx] [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions

2016-03-07 Thread Tomeu Vizoso
On 03/05/2016 01:30 PM, Daniel Vetter wrote: > On Wed, Mar 02, 2016 at 03:00:15PM +0100, Tomeu Vizoso wrote: >> igt_create_bo_with_dimensions() is intended to abstract differences >> between drivers in buffer object creation. >> >> The driver-specific ioctls will be called if the driver that is bei

Re: [Intel-gfx] [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions

2016-03-07 Thread Ville Syrjälä
On Sat, Mar 05, 2016 at 01:30:34PM +0100, Daniel Vetter wrote: > On Wed, Mar 02, 2016 at 03:00:15PM +0100, Tomeu Vizoso wrote: > > igt_create_bo_with_dimensions() is intended to abstract differences > > between drivers in buffer object creation. > > > > The driver-specific ioctls will be called if

Re: [Intel-gfx] [PATCH] drm/i915: Wait until after wm optimization to drop runtime PM reference

2016-03-07 Thread Matt Roper
On Mon, Mar 07, 2016 at 12:53:38PM +0100, Maarten Lankhorst wrote: > Op 05-03-16 om 00:59 schreef Matt Roper: > > At the end of an atomic commit, we currently wait for vblanks to > > complete, call put() on the various runtime PM references, and then try > > to optimize our watermarks (on platforms

Re: [Intel-gfx] [PATCH] drm/i915: Wait until after wm optimization to drop runtime PM reference

2016-03-07 Thread Imre Deak
On ma, 2016-03-07 at 08:10 -0800, Matt Roper wrote: > On Sat, Mar 05, 2016 at 03:25:05AM +0200, Imre Deak wrote: > > Hi Matt, > > > > On Fri, 2016-03-04 at 15:59 -0800, Matt Roper wrote: > > > At the end of an atomic commit, we currently wait for vblanks to > > > complete, call put() on the variou

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/csr: Allow matching unknown HW steppings with generic firmware

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915/csr: Allow matching unknown HW steppings with generic firmware URL : https://patchwork.freedesktop.org/series/4173/ State : failure == Summary == Series 4173v1 drm/i915/csr: Allow matching unknown HW steppings with generic firmware http://patchwork.freede

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Actually retry with bit-banging after GMBUS timeout

2016-03-07 Thread Jani Nikula
On Mon, 07 Mar 2016, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > After the GMBUS transfer times out, we set force_bit=1 and > return -EAGAIN expecting the i2c core to call the .master_xfer > hook again so that we will retry the same transfer via bit-banging. > This is in case th

Re: [Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

2016-03-07 Thread Pierre-Louis Bossart
On 3/5/16 7:42 AM, Ville Syrjälä wrote: On Fri, Mar 04, 2016 at 08:50:37PM -0600, Pierre-Louis Bossart wrote: When HDaudio is not enabled or fused-out, an alternate hardware interface can be used to provide audio data to the display/HDMI controller on Atom platforms. The code to control this in

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Some GT freq stuff

2016-03-07 Thread Ville Syrjälä
On Mon, Mar 07, 2016 at 05:07:51PM +0200, Ville Syrjälä wrote: > On Mon, Mar 07, 2016 at 10:34:26AM -, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Some GT freq stuff > > URL : https://patchwork.freedesktop.org/series/4129/ > > State : failure > > > > == Summary == >

Re: [Intel-gfx] [PATCH] drm/i915: Fix bogus dig_port_map[] assignment for pre-HSW

2016-03-07 Thread Jani Nikula
On Mon, 07 Mar 2016, Martin Kepplinger wrote: > This still isn't merged but still fixes a serious regression in v4.5. > What's going on? Bumps in the CI road. Now pushed to drm-intel-next-queued and cherry-picked to drm-intel-fixes, en route to v4.5. Thanks for the patch, review, and testing. BR

Re: [Intel-gfx] [RFC 01/15] drm: i915: fix inversion of definitions for LPE_PIPE_A/B

2016-03-07 Thread Pierre-Louis Bossart
On 3/5/16 7:27 AM, Ville Syrjälä wrote: On Fri, Mar 04, 2016 at 08:50:38PM -0600, Pierre-Louis Bossart wrote: Definitions for I915_LPE_PIPE_A_INTERRUPT and I915_LPE_PIPE_B_INTERRUPT are inverted. Not according to the docs. Are the docs wrong? Possibly. I compared with the Android code and fl

Re: [Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

2016-03-07 Thread Ville Syrjälä
On Mon, Mar 07, 2016 at 11:54:28AM -0600, Pierre-Louis Bossart wrote: > On 3/5/16 7:42 AM, Ville Syrjälä wrote: > > On Fri, Mar 04, 2016 at 08:50:37PM -0600, Pierre-Louis Bossart wrote: > >> When HDaudio is not enabled or fused-out, an alternate hardware > >> interface can be used to provide audio

Re: [Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

2016-03-07 Thread Pierre-Louis Bossart
Not sure why you skirt around calling the thing by its name. It's called LPE isn't it? No. LPE aka SST is the path to the audio dsp subsystem. This path to HDMI has nothing to do with the audio dsp. Not a single gate is shared. The why are the interrupt bits called LPE_somethingsomething? An

[Intel-gfx] ✗ Fi.CI.BAT: failure for DPCD Backlight Control (rev4)

2016-03-07 Thread Patchwork
== Series Details == Series: DPCD Backlight Control (rev4) URL : https://patchwork.freedesktop.org/series/1864/ State : failure == Summary == Series 1864v4 DPCD Backlight Control http://patchwork.freedesktop.org/api/1.0/series/1864/revisions/4/mbox/ Test kms_flip: Subgroup basic-flip-

Re: [Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

2016-03-07 Thread Ville Syrjälä
On Mon, Mar 07, 2016 at 12:12:32PM -0600, Pierre-Louis Bossart wrote: > > >>> Not sure why you skirt around calling the thing by its name. It's > >>> called LPE isn't it? > >> > >> No. LPE aka SST is the path to the audio dsp subsystem. > >> This path to HDMI has nothing to do with the audio dsp.

[Intel-gfx] [PATCH 4/3] drm/i915: Read RPS frequencies earlier on non-VLV/CHV

2016-03-07 Thread ville . syrjala
From: Ville Syrjälä Read out the RPS frequencies already in intel_init_gt_powersave() on all the platforms. So far we only did that on VLV/CHV, and the rest of the platforms read them out at rps enable time, which happens asynchronously from a workqueue. Reading them out earlier prevents userspac

[Intel-gfx] [PATCH i-g-t] tests/pm_rps: Fix assert for sysfs writes

2016-03-07 Thread ville . syrjala
From: Ville Syrjälä fprintf() returns a negative value on error. Fix the assert to catch that. Signed-off-by: Ville Syrjälä --- tests/pm_rps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/pm_rps.c b/tests/pm_rps.c index 72e47e728e2c..74bbdc852167 100644 --- a/tests

Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

2016-03-07 Thread Matt Roper
On Mon, Mar 07, 2016 at 04:29:04PM +0200, Ville Syrjälä wrote: > On Fri, Mar 04, 2016 at 03:49:02PM -0800, Matt Roper wrote: > > On Fri, Mar 04, 2016 at 12:52:41PM +0200, Ville Syrjälä wrote: > > > On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > > > > If all pipes are off, then we may

Re: [Intel-gfx] [PATCH 4/3] drm/i915: Read RPS frequencies earlier on non-VLV/CHV

2016-03-07 Thread O'Rourke, Tom
On Mon, Mar 07, 2016 at 08:57:09PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Read out the RPS frequencies already in intel_init_gt_powersave() > on all the platforms. So far we only did that on VLV/CHV, and the > rest of the platforms read them out at rps enable time,

[Intel-gfx] [PATCH 0/8] SKL WM fixes and Arbitrated Display Bandwidth WA

2016-03-07 Thread Matt Roper
This series of patches was mostly written by Mahesh and Shobhit; the last iteration posted was by Shobhit here: https://patchwork.freedesktop.org/series/2881/ I believe they've been busy recently and haven't had time to revisit this work, so I've rebased their patches to the latest upstre

[Intel-gfx] [PATCH 3/8] drm/i915/skl+: calculate plane pixel rate (v3)

2016-03-07 Thread Matt Roper
From: "Kumar, Mahesh" Don't use pipe pixel rate for plane pixel rate. Calculate plane pixel according to formula adjusted plane_pixel_rate = adjusted pipe_pixel_rate * downscale ammount downscale amount = max[1, src_h/dst_h] * max[1, src_w/dst_w] if 90/270 rotation use rotated width & height v

[Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h

2016-03-07 Thread Matt Roper
A couple of the EDAC drivers have a nice memdev_dmi_entry structure for decoding DMI memory device entries. Move the structure definition to dmi.h so that it can be shared between those drivers and also other parts of the kernel; the i915 graphics driver is going to need to use this structure soon

[Intel-gfx] [PATCH 1/8] drm/i915/skl+: Use plane size for relative data rate calculation

2016-03-07 Thread Matt Roper
From: "Kumar, Mahesh" Use plane size for relative data rate calculation. don't always use pipe source width & height. adjust height & width according to rotation. use plane size for watermark calculations also. v2: Address Matt's comments. Use intel_plane_state->visible to avoid divide-by-ze

[Intel-gfx] [PATCH 5/8] drm/i915/gen9: Hold wm_mutex around SKL watermark updates

2016-03-07 Thread Matt Roper
SKL watermark code uses a field in dev_priv to hold the watermark results being calculated. If independent commits are submitted against disjoint CRTC's, the watermark updates could race and clobber each other's usage of dev_priv->wm.skl_results. Signed-off-by: Matt Roper --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 8/8] drm/i915/skl: WA for watermark calculation based on Arbitrated Display BW (v4)

2016-03-07 Thread Matt Roper
From: "Kumar, Mahesh" If the arbitary display bandwidth is > 60% of memory bandwith, for x-tile we should increase latency at all levels by 15us. If the arbitary dsplay bandwidth is greater than 20% of memory bandwith in case of y-tile being enabled, double the scan lines v2: Update the co

[Intel-gfx] [PATCH 7/8] drm/i915: Add support to parse DMI table and get platform memory info (v3)

2016-03-07 Thread Matt Roper
From: Shobhit Kumar This is needed for WM computation workaround for arbitrated display bandwidth. v2: Address Matt's review comments - Be more paranoid while dmi decoding - Also add support for decoding speed from configured memory speed if availble in DMI memory entry v3 (by Mat

[Intel-gfx] [PATCH 2/8] drm/i915/skl+: calculate ddb minimum allocation (v3)

2016-03-07 Thread Matt Roper
From: "Kumar, Mahesh" don't always use 8 ddb as minimum, instead calculate using proper algorithm. v2: optimizations as per Matt's comments. v3 (by Matt): - Fix boolean logic for !fb test in skl_ddb_min_alloc() - Adjust negative tiling format comparisons in skl_ddb_min_alloc() to improve r

[Intel-gfx] [PATCH 4/8] drm/i915/skl+: Use scaling amount for plane data rate calculation (v3)

2016-03-07 Thread Matt Roper
From: "Kumar, Mahesh" if downscaling is enabled plane data rate increases according to scaling amount. take scaling amount under consideration while calculating plane data rate v2: Address Matt's comments, where data rate was overridden because of missing else. v3 (by Matt): - Add braces to 'e

Re: [Intel-gfx] Ask for comments of getting guest framebuffer in igvt-g

2016-03-07 Thread Zhiyuan Lv
Hi Joonas, On Mon, Mar 07, 2016 at 12:20:48PM +0200, Joonas Lahtinen wrote: > Hi, > > On pe, 2016-03-04 at 23:38 +0800, Zhiyuan Lv wrote: > > Hi Joonas, > > > > On Fri, Mar 04, 2016 at 04:00:27PM +0200, Joonas Lahtinen wrote: > > > > > > Hi, > > > > > > On to, 2016-03-03 at 17:50 +0800, Zhiyua

Re: [Intel-gfx] [iGVT-g] Ask for comments of getting guest framebuffer in igvt-g

2016-03-07 Thread Tian, Kevin
> From: Zhiyuan Lv > Sent: Tuesday, March 08, 2016 9:26 AM > > > > The igvt device model is responsible for injecting vblank interrupts to > > > VMs > > > for i915 running inside. Currently we have a timer for the regular vblank > > > injection. So if needed, host i915 can notify gvt device model

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib: kms: add helpers for color management properties on pipes

2016-03-07 Thread Matt Roper
On Thu, Feb 25, 2016 at 05:16:10PM +, Lionel Landwerlin wrote: > v2: Rename CTM_MATRIX property to CTM > > Signed-off-by: Lionel Landwerlin > --- > lib/igt_kms.c | 74 > +++ > lib/igt_kms.h | 17 +- > 2 files changed, 90 in

Re: [Intel-gfx] Ask for comments of getting guest framebuffer in igvt-g

2016-03-07 Thread Tian, Kevin
> From: Zhiyuan Lv > Sent: Thursday, March 03, 2016 5:51 PM > > Dear i915 developers, > > Here I have one topic hoping to get your comments and suggestions. > Basically it is about graphics virtualization(igvt-g), for the purpose > of host system to get virtual machine's framebuffer. We would lik

Re: [Intel-gfx] [PATCH i-g-t 0/5] New pipe level color management tests V5

2016-03-07 Thread Matt Roper
On Thu, Feb 25, 2016 at 05:16:08PM +, Lionel Landwerlin wrote: > Hi, > > This series enables testing pipe level color management using kernel patches > from this serie : > > https://patchwork.freedesktop.org/series/2720/ > > Most of the tests use pipe CRCs to check the results by comparing t

Re: [Intel-gfx] Ask for comments of getting guest framebuffer in igvt-g

2016-03-07 Thread Zhiyuan Lv
Hi Kevin, On Tue, Mar 08, 2016 at 10:44:39AM +0800, Tian, Kevin wrote: > > From: Zhiyuan Lv > > Sent: Thursday, March 03, 2016 5:51 PM > > > > Dear i915 developers, > > > > Here I have one topic hoping to get your comments and suggestions. > > Basically it is about graphics virtualization(igvt-g

Re: [Intel-gfx] [PATCH 0/8] SKL WM fixes and Arbitrated Display Bandwidth WA

2016-03-07 Thread Kumar, Shobhit
On 03/08/2016 06:35 AM, Matt Roper wrote: This series of patches was mostly written by Mahesh and Shobhit; the last iteration posted was by Shobhit here: https://patchwork.freedesktop.org/series/2881/ I believe they've been busy recently and haven't had time to revisit this work, so I'

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: GMBUS fixes and whatnot

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: GMBUS fixes and whatnot URL : https://patchwork.freedesktop.org/series/4178/ State : warning == Summary == Series 4178v1 drm/i915: GMBUS fixes and whatnot http://patchwork.freedesktop.org/api/1.0/series/4178/revisions/1/mbox/ Test kms_flip: Subgr

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro

2016-03-07 Thread Bastien Nocera
On Sat, 2016-03-05 at 15:16 +0100, Lukas Wunner wrote: > Hi Bastien, > > On Fri, Mar 04, 2016 at 04:12:27PM +, Bastien Nocera wrote: > > > > Lukas Wunner wunner.de> writes: > > > > > > Enable GPU switching on the pre-retina MacBook Pro (2008 - 2013), > > > v5. > > I've tested your patchset

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina?MacBook Pro

2016-03-07 Thread Bastien Nocera
On Sat, 2016-03-05 at 15:16 +0100, Lukas Wunner wrote: > Hi Bastien, > > On Fri, Mar 04, 2016 at 04:12:27PM +, Bastien Nocera wrote: > > > > Lukas Wunner wunner.de> writes: > > > > > > Enable GPU switching on the pre-retina MacBook Pro (2008 - 2013), > > > v5. > > I've tested your patchset

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels URL : https://patchwork.freedesktop.org/series/4078/ State : failure == Summary == Series 4078v1 drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels http://patch

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Only write watermark registers if a pipe is active

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Only write watermark registers if a pipe is active URL : https://patchwork.freedesktop.org/series/4079/ State : failure == Summary == Series 4079v1 drm/i915: Only write watermark registers if a pipe is active http://patchwork.freedesktop.org/api/1.0/serie

Re: [Intel-gfx] [PATCH 08/13] drm/i915: Refactor platform specifics out of intel_get_shared_dpll()

2016-03-07 Thread Maarten Lankhorst
Op 04-03-16 om 07:49 schreef Ander Conselvan De Oliveira: > On Thu, 2016-03-03 at 15:08 +0100, Maarten Lankhorst wrote: >> Op 26-02-16 om 14:54 schreef Ander Conselvan de Oliveira: >>> The function intel_get_shared_dpll() had a more or less generic >>> implementation with some platform specific che

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only write watermark registers if a pipe is active

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Only write watermark registers if a pipe is active URL : https://patchwork.freedesktop.org/series/4079/ State : success == Summary == Series 4079v1 drm/i915: Only write watermark registers if a pipe is active http://patchwork.freedesktop.org/api/1.0/serie

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: add sanity check for partial view creation (rev3)

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: add sanity check for partial view creation (rev3) URL : https://patchwork.freedesktop.org/series/3926/ State : failure == Summary == Series 3926v3 drm/i915: add sanity check for partial view creation http://patchwork.freedesktop.org/api/1.0/series/3926/re

[Intel-gfx] [PATCH i-g-t v7] lib/igt_kms: Add COMMIT_ATOMIC to igt_display_commit2()

2016-03-07 Thread Pratik Vishwakarma
From: Mayuresh Gharpure Co-Author : Marius Vlad Co-Author : Pratik Vishwakarma So far we have had only two commit styles, COMMIT_LEGACY and COMMIT_UNIVERSAL. This patch adds another commit style COMMIT_ATOMIC which makes use of drmModeAtomicCommit() v2: (Marius) i)Set CRTC_ID to zero

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix races on fbdev

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix races on fbdev URL : https://patchwork.freedesktop.org/series/4068/ State : failure == Summary == Series 4068v1 drm/i915: Fix races on fbdev http://patchwork.freedesktop.org/api/1.0/series/4068/revisions/1/mbox/ Test kms_pipe_crc_basic: Subgr

[Intel-gfx] [PATCH i-g-t] Adding tests using COMMIT_ATOMIC path

2016-03-07 Thread Pratik Vishwakarma
From: pvishwak Depends on: https://patchwork.freedesktop.org/patch/76040/ Signed-off-by: Pratik Vishwakarma --- tests/kms_rotation_crc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index f94f8f1..be484d3 10

Re: [Intel-gfx] Ask for comments of getting guest framebuffer in igvt-g

2016-03-07 Thread Joonas Lahtinen
Hi, On pe, 2016-03-04 at 23:38 +0800, Zhiyuan Lv wrote: > Hi Joonas, > > On Fri, Mar 04, 2016 at 04:00:27PM +0200, Joonas Lahtinen wrote: > > > > Hi, > > > > On to, 2016-03-03 at 17:50 +0800, Zhiyuan Lv wrote: > > > > > > Dear i915 developers, > > > > > > Here I have one topic hoping to get y

Re: [Intel-gfx] [PATCH] drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels

2016-03-07 Thread Maarten Lankhorst
Op 04-03-16 om 18:47 schreef Ville Syrjälä: > On Fri, Mar 04, 2016 at 09:37:40AM -0800, Matt Roper wrote: >> On Fri, Mar 04, 2016 at 12:45:38PM +0200, Ville Syrjälä wrote: >>> On Thu, Mar 03, 2016 at 02:18:09PM -0800, Matt Roper wrote: As of commit d81f04c5ef ("drm/i915: Allow preservation of

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Some GT freq stuff

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915: Some GT freq stuff URL : https://patchwork.freedesktop.org/series/4129/ State : failure == Summary == Series 4129v1 drm/i915: Some GT freq stuff http://patchwork.freedesktop.org/api/1.0/series/4129/revisions/1/mbox/ Test kms_flip: Subgroup basic-

[Intel-gfx] [PATCH i-g-t] tests/kms_setmode: Fix compilation warnings.

2016-03-07 Thread Marius Vlad
kms_setmode.c:384:30: warning: declaration of ‘drm_fd’ shadows a global declaration [-Wshadow] kms_setmode.c:45:12: note: shadowed declaration is here static int drm_fd; kms_setmode.c:391:38: warning: passing argument 8 of ‘drmModeSetCrtc’ discards ‘const’ qualifier from pointer target type [-Wdi

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_setmode: Fix compilation warnings.

2016-03-07 Thread Maarten Lankhorst
Op 07-03-16 om 11:59 schreef Marius Vlad: > kms_setmode.c:384:30: warning: declaration of ‘drm_fd’ shadows a global > declaration [-Wshadow] > > kms_setmode.c:45:12: note: shadowed declaration is here static int drm_fd; > > kms_setmode.c:391:38: warning: passing argument 8 of ‘drmModeSetCrtc’ > dis

Re: [Intel-gfx] [PATCH v5 19/35] drm/i915: Added scheduler flush calls to ring throttle and idle functions

2016-03-07 Thread Joonas Lahtinen
On to, 2016-02-18 at 14:27 +, john.c.harri...@intel.com wrote: > From: John Harrison > > When requesting that all GPU work is completed, it is now necessary to > get the scheduler involved in order to flush out work that queued and > not yet submitted. > > v2: Updated to add support for flus

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen9: fix DMC firmware initialization (rev2)

2016-03-07 Thread Patchwork
== Series Details == Series: drm/i915/gen9: fix DMC firmware initialization (rev2) URL : https://patchwork.freedesktop.org/series/4121/ State : failure == Summary == Series 4121v2 drm/i915/gen9: fix DMC firmware initialization http://patchwork.freedesktop.org/api/1.0/series/4121/revisions/2/mb

Re: [Intel-gfx] [PATCH] drm/i915: Wait until after wm optimization to drop runtime PM reference

2016-03-07 Thread Maarten Lankhorst
Op 05-03-16 om 00:59 schreef Matt Roper: > At the end of an atomic commit, we currently wait for vblanks to > complete, call put() on the various runtime PM references, and then try > to optimize our watermarks (on platforms that need two-step watermark > programming). This can lead to watermark r

Re: [Intel-gfx] [PATCH i-g-t v2 2/7] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks

2016-03-07 Thread Dave Gordon
On 02/03/16 18:10, Derek Morton wrote: Some platforms have ring BSD available but no BSD2. Because of the current verification, tests involving ring BSD1 will be skipped if no BSD2 is available. Decoupling the checks will allow running the BSD1 specific tests on these platforms. Based on a patc

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9: Fix DMC firmware initialization

2016-03-07 Thread Mika Kuoppala
Imre Deak writes: > [ text/plain ] > In commit 1e657ad7 we moved the last step of firmware initialization to > skl_display_core_init(), where it will be run only during system resume, > but not during driver loading. Since this init step needs to be done > whenever we program the firmware fix thi

Re: [Intel-gfx] [PATCH v2] drm/i915/gen9: Fix DMC firmware initialization

2016-03-07 Thread Imre Deak
On ma, 2016-03-07 at 13:58 +0200, Mika Kuoppala wrote: > Imre Deak writes: > > > [ text/plain ] > > In commit 1e657ad7 we moved the last step of firmware > > initialization to > > skl_display_core_init(), where it will be run only during system > > resume, > > but not during driver loading. Since