Re: [Intel-gfx] drm/i915/slpc: Update freq min/max softlimits

2016-08-21 Thread Chris Wilson
On Sun, Aug 21, 2016 at 11:39:22AM +0530, Kamble, Sagar A wrote: > > > On 8/20/2016 1:32 PM, Chris Wilson wrote: > >On Sat, Aug 20, 2016 at 10:39:25AM +0530, Sagar Arun Kamble wrote: > >>+ obj = dev_priv->guc.slpc.vma->obj; > >>+ if (obj) { > >OOPS. > Fixed in next series. > > > >>+

[Intel-gfx] [PATCH 2/6] drm/i915: Move intel_prepare_plane_fb() and intel_cleanup_plane_fb()

2016-08-21 Thread Chris Wilson
In the next patch, a few rearrangements are made to make these static. First, we move them so the changes are not lost in the noise. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 239 ++- 1 file changed, 120 insertions(+), 119 deletions(-)

[Intel-gfx] [PATCH 3/6] drm/i915: Always prepare planes at the start of an atomic commit

2016-08-21 Thread Chris Wilson
The generic atomic helper likes to skip a prepare_plane_fb() if it decides that the plane->fb is unchanged. This is wrong for us for a couple of reasons: - if the pipe is reconfigured (i.e. a size change) but the framebuffer is untouched, we still have to flush any rendering prior to the re

[Intel-gfx] [PATCH 6/6] drm/i915: Set crtc_state->fb_changed whenever a VMA is changed

2016-08-21 Thread Chris Wilson
Since an fb may have multiple VMA (due to rotations etc), we need to wait a vblank and unpin the old VMA not if the fb itself is changed, but if the underlying VMA is changed. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 10 +++--- 1 file changed, 7 insertions(+), 3

[Intel-gfx] [PATCH 5/6] drm/i915: Quick spring clean of intel_prepare_plane_fb()

2016-08-21 Thread Chris Wilson
Just a quick tidy now to make the next patch neater. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 43 +--- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 1/6] drm/i915: Replace intel_plane->wait_req with plane->fence

2016-08-21 Thread Chris Wilson
Now that we subclass our request from struct fence, we start using the common primitives more freely and so avoid hand-rolling routines already provided for by the helpers. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_atomic_plane.c | 3 -- drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 4/6] drm/i915: Track pinned vma in intel_plane_state

2016-08-21 Thread Chris Wilson
With atomic plane states we are able to track an allocation right from preparation, during use and through to the final free after being swapped out for a new plane. We can couple the VMA we pin for the framebuffer (and its rotation) to this lifetime and avoid all the clumsy lookups in between. Si

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Track pinned vma in intel_plane_state

2016-08-21 Thread Chris Wilson
On Sun, Aug 21, 2016 at 02:15:34PM +0100, Chris Wilson wrote: > intel_cleanup_plane_fb(struct drm_plane *plane, > struct drm_plane_state *old_state) > { > - struct drm_device *dev = plane->dev; > - struct intel_plane_state *old_intel_state; > - struct drm_i915_gem

[Intel-gfx] [PATCH -next] drm/i915: Fix non static symbol warning

2016-08-21 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/i915/intel_hotplug.c:480:6: warning: symbol 'i915_hpd_poll_init_work' was not declared. Should it be static? Also move the '{' to new line. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/intel_hotplug.c | 3 ++- 1 fi

Re: [Intel-gfx] drm/i915/slpc: Update freq min/max softlimits

2016-08-21 Thread Kamble, Sagar A
On 8/21/2016 2:09 PM, Chris Wilson wrote: On Sun, Aug 21, 2016 at 11:39:22AM +0530, Kamble, Sagar A wrote: On 8/20/2016 1:32 PM, Chris Wilson wrote: On Sat, Aug 20, 2016 at 10:39:25AM +0530, Sagar Arun Kamble wrote: + obj = dev_priv->guc.slpc.vma->obj; + if (obj) { OOPS. Fixed

[Intel-gfx] [Regression report] Weekly regression report WW34

2016-08-21 Thread Jairo Miramontes
This week's new regressions +---+---+++ | BugId | Summary | Created on | Bisect | +---+---+++ | 97396 | [drm] stuck on bsd

Re: [Intel-gfx] [PATCH v4 0/3] drm/i915: fix some audio support 4K resolution issues

2016-08-21 Thread Yang, Libin
Any comments? Regards, Libin > -Original Message- > From: libin.y...@linux.intel.com [mailto:libin.y...@linux.intel.com] > Sent: Thursday, August 18, 2016 2:42 PM > To: intel-gfx@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; Vetter, Daniel ; > ti...

Re: [Intel-gfx] drm/i915/slpc: Enable SLPC in guc if supported

2016-08-21 Thread kbuild test robot
Hi Tom, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.8-rc3 next-20160819] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to r

Re: [Intel-gfx] linux-next: manual merge of the jc_docs tree with the drm-misc tree

2016-08-21 Thread Daniel Vetter
On Fri, Aug 19, 2016 at 11:50:09AM -0600, Jonathan Corbet wrote: > On Fri, 19 Aug 2016 11:52:15 +1000 > Stephen Rothwell wrote: > > > Today's linux-next merge of the jc_docs tree got a conflict in: > > > > Documentation/gpu/index.rst > > > > between commit: > > > > b754b35b089d ("vgaarbite