On Thu, Sep 29, 2016 at 04:45:34PM +0300, Jani Nikula wrote:
>
> Oh, the list and Petri seem to have been dropped off the distribution,
> adding back. I don't have an answer on the rest. Petri?
>
> On Thu, 29 Sep 2016, cornel panceac wrote:
> > 2016-09-29 14:53 GMT+02:00 Jani Nikula :
> >
> >> O
Am 13.10.2016 10:55, schrieb Dan Carpenter:
> We want to read 3 bytes here, but because the parenthesis are in the
> wrong place we instead read:
>
> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)
>
> which is one byte.
>
> Fixes: fe5a66f91c88 ("drm/i915: Read PSR caps/intermed
On Mon, Sep 26, 2016 at 06:02:20PM +0300, Jani Nikula wrote:
> On Mon, 26 Sep 2016, Imre Deak wrote:
> > a277ca7dc01d should've been a no-functional-change commit, but it
> > removed the initialization of the dpll_hw_state for HDMI outputs,
> > resulting in state mismatches and a failed modeset wi
Hi,
On Thursday 13 October 2016 04:49 PM, Maarten Lankhorst wrote:
Op 13-10-16 om 12:58 schreef Kumar, Mahesh:
From: Mahesh Kumar
This patch adds IPC support for platforms. This patch enables IPC
only for BXT/KBL platform as for SKL recommendation is to keep is disabled.
IPC (Isochronous Pri
While at it, make debugfs_path point at the debugfs root, not
dri. This'll be handy in future work.
Signed-off-by: Jani Nikula
---
tests/drm_lib.sh | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh
index 113da4c7d645..87e3ad
Hopefully, this will provide more clues for figuring out why
snd_hda_intel unload fails sporadically.
Signed-off-by: Jani Nikula
---
tests/drv_module_reload_basic | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/drv_module_reload_basic b/tests/drv_module_reload_basic
index 93cf7c00563
Test scripts can call hda_dynamic_debug_enable and
hda_dynamic_debug_disable to enable/disable snd_hda_intel and
snd_hda_core debug messages. The dynamic debug will be disabled
automatically at test end by the exit handler.
Signed-off-by: Jani Nikula
---
tests/drm_lib.sh | 22 +++
On Thu, Oct 13, 2016 at 12:29:44PM +0100, Tvrtko Ursulin wrote:
>
> On 13/10/2016 09:55, Chris Wilson wrote:
> >If the user requests a mappable binding to the global GTT, we will first
> >unbind an existing mapping if it doesn't match. We will unbind even if
> >there is no possibility that the obj
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, Oct 13, 2016 at 03:46:04PM +0300, Joonas Lahtinen wrote:
> On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> > @@ -4211,10 +4240,10 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void
> > *data,
> > i915_gem_object_truncate(obj);
> >
> > args->retained = obj->mm.
On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> @@ -4211,10 +4240,10 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void
> *data,
> i915_gem_object_truncate(obj);
>
> args->retained = obj->mm.madv != __I915_MADV_PURGED;
> + mutex_unlock(&obj->mm.lock);
>
> +e
On Thu, Oct 13, 2016 at 02:34:06PM +0300, Imre Deak wrote:
> Currently the display INIT power domain disabling/enabling happens in a
> mismatched way in the suspend/resume_early hooks respectively. This can
> leave display power wells incorrectly disabled in the resume hook if the
> suspend sequenc
On Thu, 13 Oct 2016, Anteja Vuk Macek wrote:
> Hi,
> I work with Fedora 18 and I'm new in linux world. I have problem with emgd
> driver. I put emgd driver in kernel and build kernel. Moduled is build like
> loadable module. But problem is when I load driver , you can see photo
> https://my.syncpl
On Thu, 13 Oct 2016, Imre Deak wrote:
> Currently the display INIT power domain disabling/enabling happens in a
> mismatched way in the suspend/resume_early hooks respectively. This can
> leave display power wells incorrectly disabled in the resume hook if the
> suspend sequence is aborted for som
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Record the current requests
queue for execlists upon hang
URL : https://patchwork.freedesktop.org/series/13716/
State : warning
== Summary ==
Series 13716v1 Series without cover letter
https://patchwork.freedesktop.org/api/1
Hi,
I work with Fedora 18 and I'm new in linux world. I have problem with emgd
driver. I put emgd driver in kernel and build kernel. Moduled is build like
loadable module. But problem is when I load driver , you can see photo
https://my.syncplicity.com/share/skvhanon0sxj5f8/IMG_20161011_104347 . Wh
On Thu, 13 Oct 2016, walter harms wrote:
> Am 13.10.2016 10:55, schrieb Dan Carpenter:
>> We want to read 3 bytes here, but because the parenthesis are in the
>> wrong place we instead read:
>>
>> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)
>>
>> which is one byte.
>>
>> Fixes
On 13/10/2016 12:50, Patchwork wrote:
== Series Details ==
Series: series starting with [CI,1/4] drm/i915: Shrink cxsr_latency_table
URL : https://patchwork.freedesktop.org/series/13715/
State : success
== Summary ==
Series 13715v1 Series without cover letter
https://patchwork.freedesktop.o
We never used any invalid ptes, those were put in place for
a possibility of doing gpu faults. However our batchbuffers are not
restricted in length, so everything needs to be pointing to something
and thus out-of-bounds is pointing to scratch.
Remove the valid flag as it is always true.
v2: Expa
Let's use more top-down approach, where each gen8_ppgtt_clear_* function
is responsible for clearing the struct passed as an argument and calling
relevant clear_range functions on lower-level tables.
Doing this rather than operating on PTE ranges makes the implementation
of shrinking page tables qu
Since "Dynamic page table allocations" were introduced, our page tables
can grow (being dynamically allocated) with address space range usage.
Unfortunately, their lifetime is bound to vm. This is not a huge problem
when we're not using softpin - drm_mm is creating an upper bound on used
range by c
On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> @@ -72,21 +68,18 @@ static struct sg_table *i915_gem_map_dma_buf(struct
> dma_buf_attachment *attachme
> }
>
> if (!dma_map_sg(attachment->dev, st->sgl, st->nents, dir)) {
> - ret =-ENOMEM;
> + ret = -ENO
On Thu, Oct 13, 2016 at 02:17:52PM +0300, Joonas Lahtinen wrote:
> On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> > +/* Per-page copy function for the shmem pwrite fastpath.
> > + * Flushes invalid cachelines before writing to the target if
> > + * needs_clflush_before is set and flushes o
== Series Details ==
Series: series starting with [CI,1/4] drm/i915: Shrink cxsr_latency_table
URL : https://patchwork.freedesktop.org/series/13715/
State : success
== Summary ==
Series 13715v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/13715/revisions/1/mbox/
On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> @@ -1499,25 +1523,40 @@ i915_gem_set_domain_ioctl(struct drm_device *dev,
> void *data,
> MAX_SCHEDULE_TIMEOUT,
> to_rps_client(file));
> if (ret)
> - goto er
Currently the display INIT power domain disabling/enabling happens in a
mismatched way in the suspend/resume_early hooks respectively. This can
leave display power wells incorrectly disabled in the resume hook if the
suspend sequence is aborted for some reason resulting in the
suspend/resume hooks
On 13/10/2016 09:55, Chris Wilson wrote:
If the user requests a mappable binding to the global GTT, we will first
unbind an existing mapping if it doesn't match. We will unbind even if
there is no possibility that the object can fit in the mappable
aperture. This may lead to a ping-pong migratio
> == Series Details ==
>
> Series: Save megabytes of wasted sg entries
> URL : https://patchwork.freedesktop.org/series/13706/
> State : failure
>
> == Summary ==
>
> Series 13706v1 Save megabytes of wasted sg entries
> https://patchwork.freedesktop.org/api/1.0/series/13706/revisions/1/mbox/
>
== Series Details ==
Series: series starting with [CI,01/19] drm/i915: Make HAS_DDI and
HAS_PCH_LPT_LP only take dev_priv
URL : https://patchwork.freedesktop.org/series/13713/
State : failure
== Summary ==
Series 13713v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/se
On 13/10/2016 12:20, Saarinen, Jani wrote:
== Series Details ==
Series: drm/i915: Skip unbinding large unmappable global buffers
URL : https://patchwork.freedesktop.org/series/13702/
State : warning
== Summary ==
Series 13702v1 drm/i915: Skip unbinding large unmappable global buffers
https:
> == Series Details ==
>
> Series: drm/i915: Skip unbinding large unmappable global buffers
> URL : https://patchwork.freedesktop.org/series/13702/
> State : warning
>
> == Summary ==
>
> Series 13702v1 drm/i915: Skip unbinding large unmappable global buffers
> https://patchwork.freedesktop.or
Op 13-10-16 om 12:58 schreef Kumar, Mahesh:
> From: Mahesh Kumar
>
> This patch adds IPC support for platforms. This patch enables IPC
> only for BXT/KBL platform as for SKL recommendation is to keep is disabled.
> IPC (Isochronous Priority Control) is the hardware feature, which
> dynamically con
On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> +/* Per-page copy function for the shmem pwrite fastpath.
> + * Flushes invalid cachelines before writing to the target if
> + * needs_clflush_before is set and flushes out any written cachelines after
> + * writing if needs_clflush is set.
>
On Thu, Oct 13, 2016 at 02:04:18PM +0300, Joonas Lahtinen wrote:
> On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> > @@ -2483,24 +2474,25 @@ i915_gem_object_get_pages(struct
> > drm_i915_gem_object *obj)
> >
> > lockdep_assert_held(&obj->base.dev->struct_mutex);
> >
> > - if (obj
On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> +static inline int __must_check
> +i915_gem_object_pin_pages(struct drm_i915_gem_object *obj)
> {
> - BUG_ON(obj->pages == NULL);
> - obj->pages_pin_count++;
> + lockdep_assert_held(&obj->base.dev->struct_mutex);
\n here.
> +
From: Mahesh Kumar
Current code clears only plane ddb allocation if total ddb allocated to
pipe in zero. y_plane ddb still contains old value, clear that as well.
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_pm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm
From: Mahesh Kumar
This patch changes Watermak calculation to fixed point calculation.
Problem with current calculation is during plane_blocks_per_line
calculation we divide intermediate blocks with min_scanlines and
takes floor of the result because of integer operation.
hence we end-up assignin
From: Mahesh Kumar
This patch adds variable to check for X_tiled & y_tiled planes, instead
of always checking against framebuffer-modifiers.
Changes:
- Created separate patch as per Paulo's comment
- Added x_tiled variable as well
Signed-off-by: Mahesh Kumar
---
drivers/gpu/drm/i915/intel_p
This patch make changes to use linetime latency instead of allocated
DDB size during plane watermark calculation in switch case, This is
required to implement new DDB allocation algorithm.
In New Algorithm DDB is allocated based on WM values, because of which
number of DDB blocks will not be avail
From: Mahesh Kumar
This patch adds IPC support for platforms. This patch enables IPC
only for BXT/KBL platform as for SKL recommendation is to keep is disabled.
IPC (Isochronous Priority Control) is the hardware feature, which
dynamically controles the memory read priority of Display.
When IPC i
From: Mahesh Kumar
This patch implements new DDB allocation algorithm as per HW team
recommendation. This algo takecare of scenario where we allocate less DDB
for the planes with lower relative pixel rate, but they require more DDB
to work.
It also takes care of enabling same watermark level for
This patch adds support to decode system memory bandwidth
which will be used for arbitrated display memory percentage
calculation in GEN9 based system.
Changes from v1:
- Address comments from Paulo
- implement decode function for SKL/KBL also
Signed-off-by: "Kumar, Mahesh"
---
drivers/gpu/dr
From: Mahesh Kumar
This series implements new DDB allocation algorithm to solve the cases,
where we have sufficient DDB available to enable multiple planes, But
due to the current algorithm not dividing it properly among planes, we
end-up failing the flip.
It also takes care of enabling same wate
This patch implemnets Workariunds related to display arbitrated memory
bandwidth. These WA are applicabe for all gen-9 based platforms.
Changes since v1:
- Rebase on top of Paulo's patch series
Changes since v2:
- Rebase/rework after addressing Paulo's comments in previous patch
Signed-off-by:
== Series Details ==
Series: .rodata.str diet (rev2)
URL : https://patchwork.freedesktop.org/series/13583/
State : success
== Summary ==
Series 13583v2 .rodata.str diet
https://patchwork.freedesktop.org/api/1.0/series/13583/revisions/2/mbox/
Test kms_pipe_crc_basic:
Subgroup bad-sourc
On 10/13/2016 1:18 PM, Tvrtko Ursulin wrote:
On 12/10/2016 19:36, Saarinen, Jani wrote:
== Series Details ==
Series: Support for sustained capturing of GuC firmware logs (rev11)
URL : https://patchwork.freedesktop.org/series/7910/
State : warning
== Summary ==
Series 7910v11 Support for
== Series Details ==
Series: Save megabytes of wasted sg entries
URL : https://patchwork.freedesktop.org/series/13706/
State : failure
== Summary ==
Series 13706v1 Save megabytes of wasted sg entries
https://patchwork.freedesktop.org/api/1.0/series/13706/revisions/1/mbox/
Test gem_cs_tlb:
'\n' is supposed to be at the end of the line, not in the middle.
Fixes: cdb324bde570 ("drm/i915: Show bounds of active request in the ring...")
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Reviewed-by: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
1 file changed, 1 insertio
Mika wanted to know what requests were pending at the time of a hang as
we now track which requests we have submitted to the hardware.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Reviewed-by: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_drv.h | 3 +-
drivers/gpu/drm/i915/i915_gpu_error
On Thu, Oct 13, 2016 at 12:51:26PM +0300, Mika Kuoppala wrote:
> Chris Wilson writes:
> > +static void record_request(struct drm_i915_gem_request *request,
> > + struct drm_i915_error_request *erq)
> > +{
> > + erq->context = request->ctx->hw_id;
> > + erq->seqno = request
On Thu, Oct 13, 2016 at 10:55:12AM +0100, Tvrtko Ursulin wrote:
>
> On 13/10/2016 10:20, Chris Wilson wrote:
> >On Thu, Oct 13, 2016 at 10:03:58AM +0100, Tvrtko Ursulin wrote:
> >>From: Tvrtko Ursulin
> >>
> >>In order to reuse the same logic in several places in the driver,
> >>extract the logic
From: Tvrtko Ursulin
unsigned long is too wide - use smaller types in
struct cxsr_latency to save 800-something bytes of .rodata.
v2: All data even fits in u16 for even more saving. (Ville Syrjala)
v3: Move bitfields to the end of the struct. (Joonas Lahtinen)
Signed-off-by: Tvrtko Ursulin
Rev
From: Tvrtko Ursulin
Pack the struct _sdvo_cmd_name to save 736 bytes of .rodata.
This is fine since the name pointers are used only for debug.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/intel_sdvo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
From: Tvrtko Ursulin
Use types of more appropriate size in struct
intel_watermark_params to save 512 bytes of .rodata.
Signed-off-by: Tvrtko Ursulin
Acked-by: Ville Syrjälä
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/intel_drv.h | 10 +-
drivers/gpu/drm/i915/intel_pm.c |
From: Tvrtko Ursulin
Make struct video_levels and struct tv_mode use data types
of sufficient width to save approximately one kilobyte in
the .rodata section.
v2: Do not align struct members. (Jani Nikula, Joonas Lahtinen)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Joonas Lahtinen
---
driver
From: Tvrtko Ursulin
Saves 1320 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i
From: Tvrtko Ursulin
Saves 4472 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i
From: Tvrtko Ursulin
Saves 1520 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Joonas Lahtinen
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_engine_cs.c | 7 ---
1 file changed, 4 i
From: Tvrtko Ursulin
Saves 944 bytes of .rodata strings and 128 bytes of .text.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
From: Tvrtko Ursulin
Saves 472 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i9
From: Tvrtko Ursulin
Saves 968 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i9
From: Tvrtko Ursulin
Saves 1392 bytes of .rodata strings.
Also change a few function/macro prototypes in i915_gem_gtt.c
from dev to dev_priv where it made more sense to do so.
v2: Add parantheses around dev_priv. (Ville Syrjala)
v3: Mention function prototype changes. (David Weinehall)
Signed-
From: Tvrtko Ursulin
Saves 1016 bytes of .rodata strings and couple hundred of .text.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankh
From: Tvrtko Ursulin
Saves 2432 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i
From: Tvrtko Ursulin
More .rodata string saving by avoid __I915__ magic inside WARNs.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankh
From: Tvrtko Ursulin
Saves 1416 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i
From: Tvrtko Ursulin
Saves 944 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i9
From: Tvrtko Ursulin
Saves 472 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i9
From: Tvrtko Ursulin
Saves 848 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i9
From: Tvrtko Ursulin
This saves 1872 bytes of .rodata strings.
v2:
* Rebase.
* Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
From: Tvrtko Ursulin
Saves 1808 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i
From: Tvrtko Ursulin
Saves 864 bytes of .rodata strings and ~100 of .text.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
From: Tvrtko Ursulin
Saves 960 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/drm/i9
From: Tvrtko Ursulin
This saves 3248 bytes of .rodata strings.
v2: Add parantheses around dev_priv. (Ville Syrjala)
Signed-off-by: Tvrtko Ursulin
Reviewed-by: David Weinehall
Acked-by: Daniel Vetter
Acked-by: Jani Nikula
Acked-by: Chris Wilson
Acked-by: Maarten Lankhorst
---
drivers/gpu/
On Thu, Oct 13, 2016 at 12:16:03PM +0300, Jani Nikula wrote:
> On Tue, 11 Oct 2016, Chris Wilson wrote:
> > +#if IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR)
> > {"i915_error_state", &i915_error_state_fops},
> > +#endif
>
> IGT tests/drm_lib.sh tests for existence of i915_error_state to find the
On Thu, Oct 13, 2016 at 10:44:44AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Saves 1392 bytes of .rodata strings.
>
> Also change a few function/macro prototypes in i915_gem_gtt.c
> from dev to dev_priv where it made more sense to do so.
>
> v2: Add parantheses around dev_priv. (V
On Thu, Oct 13, 2016 at 10:01:03AM +0100, Chris Wilson wrote:
> On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote:
> > We want to read 3 bytes here, but because the parenthesis are in the
> > wrong place we instead read:
> >
> > sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dp
On 13/10/2016 10:20, Chris Wilson wrote:
On Thu, Oct 13, 2016 at 10:03:58AM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
In order to reuse the same logic in several places in the driver,
extract the logic which adds pages to the sg list and does the
potential coalescing, into separate fu
Chris Wilson writes:
> Mika wanted to know what requests were pending at the time of a hang as
> we now track which requests we have submitted to the hardware.
>
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 +-
> drivers/gpu/drm/i915/i915
On 13/10/2016 10:23, Chris Wilson wrote:
On Thu, Oct 13, 2016 at 10:04:03AM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
*** BROKEN *** RFC only *** BROKEN ***
In cases where it is hard to know to minimum numbers of ents
table will need to hold at sg_alloc_time, and we end up with
a tab
On 13/10/2016 10:15, Chris Wilson wrote:
On Thu, Oct 13, 2016 at 10:04:02AM +0100, Tvrtko Ursulin wrote:
- src = obj->pages->sgl;
- dst = st->sgl;
- for (i = 0; i < obj->pages->nents; i++) {
- sg_set_page(dst, sg_page(src), src->length, 0);
- dst =
On Thu, Oct 13, 2016 at 12:31:13PM +0300, Abdiel Janulgue wrote:
>
>
> On 10/12/2016 03:07 PM, Chris Wilson wrote:
> > On Wed, Oct 12, 2016 at 02:59:53PM +0300, Abdiel Janulgue wrote:
> >> Signed-off-by: Abdiel Janulgue
> >> ---
> >> tests/gem_wait.c | 77
> >> +
From: Tvrtko Ursulin
Saves 1392 bytes of .rodata strings.
Also change a few function/macro prototypes in i915_gem_gtt.c
from dev to dev_priv where it made more sense to do so.
v2: Add parantheses around dev_priv. (Ville Syrjala)
v3: Mention function prototype changes. (David Weinhall)
Signed-o
Chris Wilson writes:
> '\n' is supposed to be at the end of the line, not in the middle.
>
> Fixes: cdb324bde570 ("drm/i915: Show bounds of active request in the ring...")
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
Oopsie.
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915
On 10/12/2016 03:07 PM, Chris Wilson wrote:
> On Wed, Oct 12, 2016 at 02:59:53PM +0300, Abdiel Janulgue wrote:
>> Signed-off-by: Abdiel Janulgue
>> ---
>> tests/gem_wait.c | 77
>> +---
>> 1 file changed, 12 insertions(+), 65 deletions(-)
>
On Thu, Oct 13, 2016 at 10:04:03AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> *** BROKEN *** RFC only *** BROKEN ***
>
> In cases where it is hard to know to minimum numbers of ents
> table will need to hold at sg_alloc_time, and we end up with
> a table with unused sg entries at it
On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote:
> We want to read 3 bytes here, but because the parenthesis are in the
> wrong place we instead read:
>
> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)
>
> which is one byte.
>
> Fixes: fe5a66f91c88 ("drm/i915: Read
On Thu, Oct 13, 2016 at 10:03:58AM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> In order to reuse the same logic in several places in the driver,
> extract the logic which adds pages to the sg list and does the
> potential coalescing, into separate functions.
>
> Code wanting to build
== Series Details ==
Series: drm/i915: Skip unbinding large unmappable global buffers
URL : https://patchwork.freedesktop.org/series/13702/
State : warning
== Summary ==
Series 13702v1 drm/i915: Skip unbinding large unmappable global buffers
https://patchwork.freedesktop.org/api/1.0/series/137
On ke, 2016-10-12 at 21:32 +0300, Saarinen, Jani wrote:
> > == Series Details ==
> >
> > Series: drm/i915/hsw: Fix GPU hang during resume from S3-devices state
> > URL : https://patchwork.freedesktop.org/series/13654/
> > State : warning
> >
> > == Summary ==
> >
> > Series 13654v1 drm/i915/hs
On Thu, Oct 13, 2016 at 10:04:02AM +0100, Tvrtko Ursulin wrote:
> - src = obj->pages->sgl;
> - dst = st->sgl;
> - for (i = 0; i < obj->pages->nents; i++) {
> - sg_set_page(dst, sg_page(src), src->length, 0);
> - dst = sg_next(dst);
> - src = sg_next(s
On Tue, 11 Oct 2016, Chris Wilson wrote:
> +#if IS_ENABLED(CONFIG_DRM_I915_CAPTURE_ERROR)
> {"i915_error_state", &i915_error_state_fops},
> +#endif
IGT tests/drm_lib.sh tests for existence of i915_error_state to find the
debugfs path for i915. Perhaps not the cleverest thing to do, but I
wo
From: Tvrtko Ursulin
*** BROKEN *** RFC only *** BROKEN ***
In cases where it is hard to know to minimum numbers of ents
table will need to hold at sg_alloc_time, and we end up with
a table with unused sg entries at its end, this function will
trim (free) the unused sg entry blocks and adjust th
From: Tvrtko Ursulin
We can decrease the i915 slab usage by 1-6 MiB* easily by doing
more sg list coalescing and having the tables at the correct size
at the same time.
This series extracts the sg table building code into helper so
that all places in i915 can benefit.
Another problem is that it
From: Tvrtko Ursulin
Simplify the partial view creation loop by using the newly
introduced helpers.
It also allows the list to be coalesced when possbile.
New i915_sg_add_dma helper was added to allow adding just
the DMA address entries to the list.
Signed-off-by: Tvrtko Ursulin
---
drivers/
From: Tvrtko Ursulin
Since most of our callers do not know in advance how many entries
in the sg table they will need, it is beneficial to trim the table
after it has been created.
Use the newly added sg_trim_table to do that when i915_sg_complete
is called.
Before we were wasting between 1-2 M
From: Tvrtko Ursulin
As for the partial view, just simplifies the loop and
enables entry coalescing.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 42 +
1 file changed, 14 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm
From: Tvrtko Ursulin
In order to reuse the same logic in several places in the driver,
extract the logic which adds pages to the sg list and does the
potential coalescing, into separate functions.
Code wanting to build the sg table needs to do the following:
1. Call i915_sg_create to create the
From: Tvrtko Ursulin
As for the earlier ones, it simplifies the loop and
enables entry colaescing.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_gem_dmabuf.c | 45 +++---
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/i
From: Tvrtko Ursulin
Now that we have a helper which builds the sg lists, use it
from the userptr code as well.
To do this we first export the API and add kerneldoc for it.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 33 +
drivers/gpu/drm/i915/i
101 - 200 of 220 matches
Mail list logo
