Re: [Intel-gfx] [PATCH] RFC drm/i915: Add a sunset clause to GPU hang logging

2016-10-17 Thread Daniel Vetter
On Mon, Oct 17, 2016 at 03:33:43PM +0300, Joonas Lahtinen wrote: > On pe, 2016-10-14 at 14:44 +0100, Chris Wilson wrote: > > If the kernel is old, more than a few releases old, chances are that the > > user is using an old kernel for a good reason, despite there being GPU > > hangs. After 180days s

[Intel-gfx] [PATCH] drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-17 Thread Chris Wilson
When handling execbuf relocations, we play a delicate dance with pagefault. We first try to access the user pages underneath our struct_mutex. However, if those pages were inside a GEM object, we may trigger a pagefault and deadlock as i915_gem_fault() tries to recursively acquire struct_mutex. Ins

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: GMBUS don't need no forcewake

2016-10-17 Thread Ville Syrjälä
On Wed, Oct 12, 2016 at 01:49:20PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: GMBUS don't need no forcewake > URL : https://patchwork.freedesktop.org/series/13641/ > State : warning > > == Summary == > > Series 13641v1 drm/i915: GMBUS don't need no forcewake > https:/

Re: [Intel-gfx] [PATCH igt] lib/igt_aux: Improve documentation for igt_system_suspend_autoresume()

2016-10-17 Thread Daniel Vetter
On Fri, Oct 14, 2016 at 05:51:14PM +0300, Imre Deak wrote: > While at it fix the order of states for consistency. > > Suggested by Daniel. > > Cc: Daniel Vetter > Signed-off-by: Imre Deak Going ocd with docs makes me really happy \o/ And I think it does help for new folks to get started in our

Re: [Intel-gfx] [PATCH] RFC drm/i915: Add a sunset clause to GPU hang logging

2016-10-17 Thread Joonas Lahtinen
On ma, 2016-10-17 at 16:10 +0200, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 03:33:43PM +0300, Joonas Lahtinen wrote: > > Maybe we could even explicitly state that bugs should be reported to > > the distro bugzilla because of running an old kernel? > > Distro's already shut down our warnings "

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

2016-10-17 Thread Daniel Vetter
On Mon, Oct 17, 2016 at 02:28:37PM +0300, Mika Kahola wrote: > + for (int i = 0; i < iterations; i++) { > + igt_info("%d/%d: Testing connector %s using pipe %s with %d > planes\n", > + i+1, iterations, igt_output_name(output), > + kmstest_p

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-17 Thread Daniel Vetter
On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote: > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests to > BAT. At the same time remove basic-s4 from the list, which is atm > implicitly disabled via HIBERNATION=n in kconfig. We would need at least > basic S4 coverage prov

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-17 Thread Imre Deak
On ma, 2016-10-17 at 16:32 +0200, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote: > > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests > > to > > BAT. At the same time remove basic-s4 from the list, which is atm > > implicitly disabled via HIBERN

Re: [Intel-gfx] [PATCH v4 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Sharma, Shashank
Regards Shashank On 10/17/2016 7:36 PM, Ville Syrjälä wrote: On Mon, Oct 17, 2016 at 07:10:42PM +0530, Sharma, Shashank wrote: Regards Shashank On 10/17/2016 6:01 PM, Ville Syrjälä wrote: On Mon, Oct 17, 2016 at 05:34:38PM +0530, Shashank Sharma wrote: Current DRM layer functions don't p

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-17 Thread Jani Nikula
On Mon, 17 Oct 2016, Imre Deak wrote: > On ma, 2016-10-17 at 16:32 +0200, Daniel Vetter wrote: >> On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote: >> > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests >> > to >> > BAT. At the same time remove basic-s4 from the list, wh

Re: [Intel-gfx] [PATCH v4 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Ville Syrjälä
On Mon, Oct 17, 2016 at 08:21:21PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 10/17/2016 7:36 PM, Ville Syrjälä wrote: > > On Mon, Oct 17, 2016 at 07:10:42PM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> > >> On 10/17/2016 6:01 PM, Ville Syrjälä wro

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-17 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Imre Deak > Sent: Monday, October 17, 2016 5:47 PM > To: Daniel Vetter > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-17 Thread Imre Deak
On ma, 2016-10-17 at 18:01 +0300, Saarinen, Jani wrote: > HI, > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On > > Behalf > > Of Imre Deak > > Sent: Monday, October 17, 2016 5:47 PM > > To: Daniel Vetter > > Cc: intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH v4 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Sharma, Shashank
Regards Shashank On 10/17/2016 8:30 PM, Ville Syrjälä wrote: On Mon, Oct 17, 2016 at 08:21:21PM +0530, Sharma, Shashank wrote: Regards Shashank On 10/17/2016 7:36 PM, Ville Syrjälä wrote: On Mon, Oct 17, 2016 at 07:10:42PM +0530, Sharma, Shashank wrote: Regards Shashank On 10/17/2016

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Make no_stepping_info an array

2016-10-17 Thread Vivi, Rodrigo
Reviewed-by: Rodrigo Vivi On Fri, 2016-10-14 at 16:56 -0700, Anusha Srivatsa wrote: > Make no_stepping_info an array of structs so that > on plaforms that have only one binary of DMC, we can > iterate through this array by having the same logic > for firmware loads > > Cc: Rodrigo Vivi > Signed

Re: [Intel-gfx] [PATCH 2/2] drm/i915/DMC/KBL: Load DMC on KBL using he no_stepping_info array

2016-10-17 Thread Vivi, Rodrigo
On Fri, 2016-10-14 at 16:56 -0700, Anusha Srivatsa wrote: > Currently, for display there is only one DMC image for KBL. > Remove the stepping_info table for KBL and use the no_stepping_info > for loading the firmware image. > > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa > --- > drivers/g

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Restrict pagefault disabling to just around copy_from_user()

2016-10-17 Thread Patchwork
== Series Details == Series: drm/i915: Restrict pagefault disabling to just around copy_from_user() URL : https://patchwork.freedesktop.org/series/13880/ State : failure == Summary == Series 13880v1 drm/i915: Restrict pagefault disabling to just around copy_from_user() https://patchwork.freed

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-10-17 Thread Ville Syrjälä
On Tue, Oct 11, 2016 at 08:52:47PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that we use the AUX and GMBUS assignment from VBT for all ports, > let's clean up the sanitization of the port information a bit. > Previosuly we only did this for port E, and only complai

[Intel-gfx] [PATCH v3 3/4] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-10-17 Thread ville . syrjala
From: Ville Syrjälä Now that we use the AUX and GMBUS assignment from VBT for all ports, let's clean up the sanitization of the port information a bit. Previosuly we only did this for port E, and only complained about a non-standard assignment for the other ports. But as we know that non-standard

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Trust VBT aux/ddc information (rev2)

2016-10-17 Thread Patchwork
== Series Details == Series: drm/i915: Trust VBT aux/ddc information (rev2) URL : https://patchwork.freedesktop.org/series/13600/ State : failure == Summary == Series 13600v2 drm/i915: Trust VBT aux/ddc information https://patchwork.freedesktop.org/api/1.0/series/13600/revisions/2/mbox/ Test

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: fix watermarks when using the pipe scaler

2016-10-17 Thread Matt Roper
On Fri, Oct 07, 2016 at 05:28:57PM -0300, Paulo Zanoni wrote: > Luckily, the necessary adjustments for when we're using the scaler are > exactly the same as the ones needed on ILK+, so just reuse the > function we already have. > > v2: Invert the patch order so stable backports get easier. > > Cc

[Intel-gfx] [PATCH xf86-video-intel] sna: Reprobe if kernel updates the connector mode list

2016-10-17 Thread Manasi Navare
Output_check_status() should return a false if it detects that the connector mode list has changed so that sna_mode_discover can reprobe. Fixes: eb01cc549d4d (sna: Refresh mode list if the kernel updates) Signed-off-by: Manasi Navare Cc: Chris Wilson Cc: Ville Syrjala --- src/sna/sna_display.

Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property

2016-10-17 Thread Laurent Pinchart
Hi Ville, On Friday 22 Jul 2016 16:43:13 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that all drivers have been converted over to the per-plane rotation > property, we can just nuke the global rotation property. > > Signed-off-by: Ville Syrjälä Stupid question, but how

[Intel-gfx] [drm-intel:for-linux-next 0/3] drivers/gpu/drm/i915/gvt/handlers.c:137: error: request for member 'mmio_base' in something not a structure or union

2016-10-17 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: bfd02b3c557caa083be0d55a3164ede706a446e1 commit: 06a75ace46e2fdd1d93b06228df0e2dfe526cc27 [0/3] Merge tag 'gvt-next-2016-10-14' of https://github.com/01org/gvt-linux into drm-intel-next-queued config: x86_64-randconfig-s0-1018

[Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2016-10-17 Thread Stephen Rothwell
mmio_base' in something not a structure or union (gvt->dev_priv->engine[ring_id].mmio_base + (offset)) ^ drivers/gpu/drm/i915/gvt/execlist.c:798:23: note: in expansion of macro 'execlist_ring_mmio' ctx_

Re: [Intel-gfx] [PATCH] drm/i915: KBL - Recommended buffer translation programming for DisplayPort

2016-10-17 Thread Manasi Navare
On Thu, Oct 06, 2016 at 10:54:01AM -0700, Rodrigo Vivi wrote: > According to spec: "KBL re-uses SKL values, except where > specific KBL values are listed." > > And recently spec has changed adding different table for Display Port only. > But for all SKUs (H,S,U,Y) we have slightly different values

[Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
Change GVT-g code reference for intel_engine_cs from static array to allocated pointer after commit 3b3f1650b1ca ("drm/i915: Allocate intel_engine_cs structure only for the enabled engines"). Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/execlist.c | 2 +- drivers/gpu/drm/i915/gvt/han

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Zhenyu Wang
On 2016.10.17 16:07:50 +0200, Daniel Vetter wrote: > Yeah might be best to have a new branch with upstreaming stuff (now you > need to at least split out bugfixes for the already merged stuff) and > treat that like a mostly stable branch. And the still unmerged features > (vfio and all that) would

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix build failure after intel_engine_cs change URL : https://patchwork.freedesktop.org/series/13910/ State : failure == Summary == Series 13910v1 drm/i915/gvt: Fix build failure after intel_engine_cs change https://patchwork.freedesktop.org/api/1.0/se

[Intel-gfx] [i-g-t PATCH] igt/tools: Update intel_watermark with SKL support

2016-10-17 Thread Dhinakaran Pandiyan
Added support to print SKL watermark and DDB registers. Signed-off-by: Dhinakaran Pandiyan --- tools/intel_watermark.c | 104 +++- 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c index e9

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915/gvt: Fix build failure after intel_engine_cs change > URL : https://patchwork.freedesktop.org/series/13910/ > State : failure > > == Summary == > > Series 13910v1 drm/i915/gvt: Fix build failure after intel_engine_cs change > https://patchwork.freede

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
On 2016.10.18 05:39:11 +, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915/gvt: Fix build failure after intel_engine_cs change > > URL : https://patchwork.freedesktop.org/series/13910/ > > State : failure > > > > == Summary == > > > > Series 13910v1 drm/i915/gvt: Fix

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2016-10-17 Thread Daniel Vetter
&(wa_ctx->indirect_ctx.obj->base)); > ^ > In file included from drivers/gpu/drm/i915/gvt/execlist.c:35:0: > drivers/gpu/drm/i915/i915_drv.h:2344:13: note: declared here > extern void drm_gem_object_unreference(struct drm_gem_object *); > ^ > drivers/gpu/drm/i915/gvt

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Joonas Lahtinen
On ti, 2016-10-18 at 09:40 +0800, Zhenyu Wang wrote: > @@ -134,7 +134,7 @@ static int render_mmio_to_ring_id(struct intel_gvt *gvt, > unsigned int reg) >   >   reg &= ~GENMASK(11, 0); >   for (i = 0; i < I915_NUM_ENGINES; i++) { > - if (gvt->dev_priv->engine[i].mmio_base == reg

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
On 2016.10.18 09:47:56 +0300, Joonas Lahtinen wrote: > On ti, 2016-10-18 at 09:40 +0800, Zhenyu Wang wrote: > > @@ -134,7 +134,7 @@ static int render_mmio_to_ring_id(struct intel_gvt > > *gvt, unsigned int reg) > >   > >   reg &= ~GENMASK(11, 0); > >   for (i = 0; i < I915_NUM_ENGINES; i++) {

<    1   2