[Intel-gfx] ✓ Fi.CI.BAT: success for Track available link bandwidth for DP MST

2016-11-18 Thread Patchwork
== Series Details == Series: Track available link bandwidth for DP MST URL : https://patchwork.freedesktop.org/series/15528/ State : success == Summary == Series 15528v1 Track available link bandwidth for DP MST https://patchwork.freedesktop.org/api/1.0/series/15528/revisions/1/mbox/ fi-bdw-

Re: [Intel-gfx] [PATCH 0/3] drm/i915/opregion: proper handling of DIDL, and some hacks on CADL

2016-11-18 Thread Jani Nikula
On Thu, 17 Nov 2016, Paolo Stivanin wrote: > Hello, > I can confirm that patch 3 is not needed. > I applied only patch 1 and 2 and everything works super fine! Thanks for confirming this. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center

[Intel-gfx] ✗ Fi.CI.BAT: failure for Link Training failure handling during modeset (rev3)

2016-11-18 Thread Patchwork
== Series Details == Series: Link Training failure handling during modeset (rev3) URL : https://patchwork.freedesktop.org/series/15537/ State : failure == Summary == drivers/gpu/drm/i915/intel_drv.h:892:9: error: invalid suffix "bcbb9f2b4bf4246a3a88fbdec7de32f2f6070d6" on integer constant <<

Re: [Intel-gfx] [PATCH] drm: Define drm_mm_for_each_node_in_range()

2016-11-18 Thread Joonas Lahtinen
On to, 2016-11-17 at 14:49 +, Chris Wilson wrote: > Some clients would like to iterate over every node within a certain > range. Make a nice little macro for them to hide the mixing of the > rbtree search and linear walk. > > v2: Blurb > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > C

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Fail DP MST config when there are not enough vcpi slots

2016-11-18 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 06:03:46PM -0800, Dhinakaran Pandiyan wrote: > drm_dp_find_vcpi_slots() returns an error when there is not enough > available bandwidth on a link to support a mode. This error should make > compute_config() to fail. Not returning false could end up in a modeset > which will

Re: [Intel-gfx] [PATCH 3/3] drm/dp/mst: Track available time slots in DP Multi-Stream Transport Packet

2016-11-18 Thread Daniel Vetter
On Fri, Nov 18, 2016 at 06:57:01AM +, Chris Wilson wrote: > On Thu, Nov 17, 2016 at 06:03:48PM -0800, Dhinakaran Pandiyan wrote: > > static int drm_dp_init_vcpi(struct drm_dp_mst_topology_mgr *mgr, > > struct drm_dp_vcpi *vcpi, int pbn) > > { > > - int num_slots; > >

[Intel-gfx] ✓ Fi.CI.BAT: success for MIPI/DSI display support for APL

2016-11-18 Thread Patchwork
== Series Details == Series: MIPI/DSI display support for APL URL : https://patchwork.freedesktop.org/series/15541/ State : success == Summary == Series 15541v1 MIPI/DSI display support for APL https://patchwork.freedesktop.org/api/1.0/series/15541/revisions/1/mbox/ fi-bdw-5557u total:24

Re: [Intel-gfx] [PATCH] drm/vgem: Allow root to inject hanging fences onto dmabufs

2016-11-18 Thread Chris Wilson
On Wed, Jul 20, 2016 at 08:39:43PM +0100, Chris Wilson wrote: > When performing driver testing, one factor we want to test is how we > handle a foreign fence that is never signaled. We can wait on that fence > indefinitely, in which case the driver appears hung, or we can take some > remedial actio

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Mark all non-vma being inserted into the address spaces

2016-11-18 Thread Chris Wilson
On Thu, Nov 17, 2016 at 02:12:19PM +, Chris Wilson wrote: > On Thu, Nov 17, 2016 at 03:31:54PM +0200, Joonas Lahtinen wrote: > > On to, 2016-11-17 at 12:08 +, Chris Wilson wrote: > > > We need to distinguish between full i915_vma structs and simple > > > drm_mm_nodes when considering evicti

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Fail DP MST config when there are not enough vcpi slots

2016-11-18 Thread Daniel Vetter
On Fri, Nov 18, 2016 at 9:43 AM, Daniel Vetter wrote: > On Thu, Nov 17, 2016 at 06:03:46PM -0800, Dhinakaran Pandiyan wrote: >> drm_dp_find_vcpi_slots() returns an error when there is not enough >> available bandwidth on a link to support a mode. This error should make >> compute_config() to fail.

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-18 Thread Joonas Lahtinen
On to, 2016-11-17 at 12:08 +, Chris Wilson wrote:  > -int > -i915_gem_evict_for_vma(struct i915_vma *target) > +int i915_gem_evict_for_vma(struct i915_vma *target, unsigned int flags) >  { > - struct drm_mm_node *node, *next; > + LIST_HEAD(eviction_list); > + struct drm_mm_node *nod

[Intel-gfx] [PATCH 2/3] drm/i915: Complete requests in nop_submit_request

2016-11-18 Thread Chris Wilson
Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer transfer onto execution timeline to actual hw submission") the global seqno advance was deferred until the submit_request callback. After wedging the GPU, we were installing a nop_submit_request handler (to avoid waking up the

[Intel-gfx] [PATCH 3/3] drm/i915: Stop the machine as we install the wedged submit_request handler

2016-11-18 Thread Chris Wilson
In order to prevent a race between the old callback submitting an incomplete request and i915_gem_set_wedged() installing its nop handler, we must ensure that the swap occurs when the machine is idle (stop_machine). Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 25 +++

[Intel-gfx] [PATCH 1/3] drm/i915: Disable hangcheck when wedged

2016-11-18 Thread Chris Wilson
If the gpu reset fails and the machine is terminally wedged, further hangchecks achieve nothing but noise. Disable them, with a corollary that we re-enable hangchecking after a successful GPU reset in case the user is artificially bringing the machine back to life through the debug interface. Sign

Re: [Intel-gfx] [PATCH igt 1/2] igt/gem_exec_reloc: Trivial test for softpin ABI

2016-11-18 Thread Michał Winiarski
On Thu, Nov 17, 2016 at 01:48:35PM +, Chris Wilson wrote: > Signed-off-by: Chris Wilson Reviewed-by: Michał Winiarski -Michał > --- > tests/gem_exec_reloc.c | 35 +++ > 1 file changed, 35 insertions(+) > > diff --git a/tests/gem_exec_reloc.c b/tests/gem_ex

Re: [Intel-gfx] [PATCH] drm/vgem: Allow root to inject hanging fences onto dmabufs

2016-11-18 Thread Daniel Vetter
On Fri, Nov 18, 2016 at 08:49:37AM +, Chris Wilson wrote: > On Wed, Jul 20, 2016 at 08:39:43PM +0100, Chris Wilson wrote: > > When performing driver testing, one factor we want to test is how we > > handle a foreign fence that is never signaled. We can wait on that fence > > indefinitely, in wh

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-11-18 Thread Ander Conselvan De Oliveira
On Thu, 2016-11-17 at 22:01 +, Chris Wilson wrote: > On Mon, Feb 01, 2016 at 11:13:08AM +0200, Ander Conselvan De Oliveira wrote: > > > > On Mon, 2016-02-01 at 11:50 +0530, Thulasimani, Sivakumar wrote: > > > > > > > > > On 1/29/2016 5:33 PM, Ander Conselvan De Oliveira wrote: > > > > > > >

Re: [Intel-gfx] [PATCH] drm/vgem: Allow root to inject hanging fences onto dmabufs

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 10:40:02AM +0100, Daniel Vetter wrote: > On Fri, Nov 18, 2016 at 08:49:37AM +, Chris Wilson wrote: > > On Wed, Jul 20, 2016 at 08:39:43PM +0100, Chris Wilson wrote: > > > When performing driver testing, one factor we want to test is how we > > > handle a foreign fence th

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 11:41:37AM +0200, Ander Conselvan De Oliveira wrote: > On Thu, 2016-11-17 at 22:01 +, Chris Wilson wrote: > > On Mon, Feb 01, 2016 at 11:13:08AM +0200, Ander Conselvan De Oliveira wrote: > > > > > > On Mon, 2016-02-01 at 11:50 +0530, Thulasimani, Sivakumar wrote: > > >

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Mark all non-vma being inserted into the address spaces

2016-11-18 Thread Joonas Lahtinen
On pe, 2016-11-18 at 09:05 +, Chris Wilson wrote: > On Thu, Nov 17, 2016 at 02:12:19PM +, Chris Wilson wrote: > > I've used i915_mm elsewhere as a subclass of struct mm, so a little wary > > of I915_MM. The other users are enum i915_cache_level, but I didn't want > > to imply that this is a

Re: [Intel-gfx] [PATCH] drm/i915: Only dump dp_m2_n2 configuration when drrs is used

2016-11-18 Thread Maarten Lankhorst
Op 17-11-16 om 16:44 schreef Tvrtko Ursulin: > From: Tvrtko Ursulin > > Otherwise it is just an useless empty line. > > Signed-off-by: Tvrtko Ursulin > Suggested-by: Maarten Lankhorst > Cc: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_display.c | 7 --- > 1 file changed, 4 insertio

Re: [Intel-gfx] [PATCH] drm/i915: Only poll DW3_A when init DDI PHY for ports B and C.

2016-11-18 Thread Imre Deak
On to, 2016-11-17 at 11:17 -0800, Rodrigo Vivi wrote: > According to Bspec we need to > "Poll for PORT_REF_DW3_A grc_done == 1b" > only on ports B and C initialization sequence when > copying rcomp from port A. > > So let's follow the spec and only poll for that case > and not on every port A init

[Intel-gfx] [PATCH 2/3] drm/i915: Take runtime pm in i915_gem_resume()

2016-11-18 Thread David Weinehall
In i915_gem_resume(), before calling i915_gem_restore_gtt_mappings(), we want to take the runtime PM reference; this to allow for later optimisation. Signed-off-by: David Weinehall CC: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[Intel-gfx] [PATCH 0/3] Resume time optimisation

2016-11-18 Thread David Weinehall
This patch series aims to reduce the time we spend in i915_gem_restore_gtt_mappings() on resume. Now that we're getting the resume times down a bit this function started to stand out. David Weinehall (3): drm/i915: Cleanup i915_gem_restore_gtt_mappings() drm/i915: Take runtime pm in i915_gem_

[Intel-gfx] [PATCH 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

2016-11-18 Thread David Weinehall
Benchmarking shows that on resume we spend quite a bit of time just taking and dropping these references, leaving us two options; either rewriting the code not to take these references more than once, which would be a rather invasive change since the involved functions are used from other places, o

[Intel-gfx] [PATCH 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-18 Thread David Weinehall
On resume we unbind+bind our VMA-mappings. This patch simplifies this a bit by introducing a rebind() helper. As a nice side-effect this also makes the resume callgraph self-documenting. Patch by Chris. Signed-off-by: David Weinehall CC: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c |

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 11:18:09AM +0200, Joonas Lahtinen wrote: > On to, 2016-11-17 at 12:08 +, Chris Wilson wrote:  > > + if (flags & PIN_NONBLOCK && > > + (i915_vma_is_pinned(vma) || i915_vma_is_active(vma))) { > > + ret = -ENOSPC; > > +

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Disable hangcheck when wedged

2016-11-18 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Disable hangcheck when wedged URL : https://patchwork.freedesktop.org/series/15543/ State : success == Summary == Series 15543v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15543/revisions/1/mbox

Re: [Intel-gfx] [PATCH igt 1/2] igt/gem_exec_reloc: Trivial test for softpin ABI

2016-11-18 Thread Joonas Lahtinen
On pe, 2016-11-18 at 10:39 +0100, Michał Winiarski wrote: > On Thu, Nov 17, 2016 at 01:48:35PM +, Chris Wilson wrote: > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Michał Winiarski > > -Michał I did a review too, but noticed this got merged already. Regards, Joonas -- Joonas Laht

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Protect dev_priv->atomic_cdclk_freq with all the crtc locks

2016-11-18 Thread Maarten Lankhorst
Op 17-11-16 om 16:06 schreef Ville Syrjälä: > On Tue, Nov 15, 2016 at 02:53:00PM +0100, Maarten Lankhorst wrote: >> Op 15-11-16 om 14:41 schreef Ville Syrjälä: >>> On Tue, Nov 15, 2016 at 11:14:29AM +0100, Maarten Lankhorst wrote: Op 14-11-16 om 17:35 schreef ville.syrj...@linux.intel.com: >>>

[Intel-gfx] ✗ Fi.CI.BAT: failure for Resume time optimisation

2016-11-18 Thread Patchwork
== Series Details == Series: Resume time optimisation URL : https://patchwork.freedesktop.org/series/15545/ State : failure == Summary == CC [M] drivers/gpu/drm/i915/gvt/interrupt.o CC [M] drivers/gpu/drm/i915/gvt/gtt.o CC [M] drivers/gpu/drm/i915/gvt/opregion.o CC [M] drivers/gpu/

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-18 Thread Daniel Vetter
On Fri, Nov 18, 2016 at 12:06:01PM +0200, David Weinehall wrote: > On resume we unbind+bind our VMA-mappings. This patch simplifies > this a bit by introducing a rebind() helper. As a nice side-effect > this also makes the resume callgraph self-documenting. > > Patch by Chris. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 12:06:03PM +0200, David Weinehall wrote: > Benchmarking shows that on resume we spend quite a bit of time > just taking and dropping these references, leaving us two options; > either rewriting the code not to take these references more than > once, which would be a rather i

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 12:06:01PM +0200, David Weinehall wrote: > On resume we unbind+bind our VMA-mappings. This patch simplifies > this a bit by introducing a rebind() helper. As a nice side-effect > this also makes the resume callgraph self-documenting. > > Patch by Chris. > > Signed-off-by:

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Take runtime pm in i915_gem_resume()

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 12:06:02PM +0200, David Weinehall wrote: > In i915_gem_resume(), before calling i915_gem_restore_gtt_mappings(), > we want to take the runtime PM reference; this to allow for later > optimisation. ...to hold the rpm wakelocks for the entire duration instead of many short li

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only dump dp_m2_n2 configuration when drrs is used

2016-11-18 Thread Tvrtko Ursulin
On 17/11/2016 17:45, Patchwork wrote: == Series Details == Series: drm/i915: Only dump dp_m2_n2 configuration when drrs is used URL : https://patchwork.freedesktop.org/series/15505/ State : success == Summary == Series 15505v1 drm/i915: Only dump dp_m2_n2 configuration when drrs is used htt

Re: [Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-18 Thread Joonas Lahtinen
On ke, 2016-11-16 at 19:07 +, Chris Wilson wrote: > I tried to avoid having to track the write for every VMA by only > tracking writes to the ggtt. However, for the purposes of frontbuffer > tracking this is insufficient as we need to invalidate around writes not > just to the the ggtt but all

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Pipe config debug dump diet

2016-11-18 Thread Tvrtko Ursulin
On 17/11/2016 16:52, Ville Syrjälä wrote: On Thu, Nov 17, 2016 at 03:13:55PM +, Tvrtko Ursulin wrote: On 17/11/2016 13:16, Patchwork wrote: == Series Details == Series: Pipe config debug dump diet URL : https://patchwork.freedesktop.org/series/15493/ State : success == Summary == Ser

[Intel-gfx] v4.9-rc3: graphical artefacts in X

2016-11-18 Thread Pavel Machek
Hi! With v4.9, if I maximize "nowcast -x" application, I get broken display (as if someone split the window into rectangles and shuffled them a bit). Switching virtual desktops either fixes it or breaks it, depending in how fast I switch. (Yes, strange). pavel@amd:~$ lspci | grep VGA 00:02.0 VGA

Re: [Intel-gfx] v4.9-rc3: graphical artefacts in X

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 12:02:56PM +0100, Pavel Machek wrote: > Hi! > > With v4.9, if I maximize "nowcast -x" application, I get broken > display (as if someone split the window into rectangles and shuffled > them a bit). Switching virtual desktops either fixes it or breaks it, > depending in how

Re: [Intel-gfx] [PATCH 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

2016-11-18 Thread David Weinehall
On Fri, Nov 18, 2016 at 10:37:30AM +, Chris Wilson wrote: > On Fri, Nov 18, 2016 at 12:06:03PM +0200, David Weinehall wrote: > > Benchmarking shows that on resume we spend quite a bit of time > > just taking and dropping these references, leaving us two options; > > either rewriting the code no

[Intel-gfx] [PATCH] drm/i915: Try to group more logically in intel_dump_pipe_config

2016-11-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Keep parameters relating to the pipe and crtc respectively together. Signed-off-by: Tvrtko Ursulin Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dis

Re: [Intel-gfx] [PATCH v5] drm/i915: Be more careful to drop the GT wakeref

2016-11-18 Thread Joonas Lahtinen
On ti, 2016-11-15 at 16:46 +, Chris Wilson wrote: > @@ -218,7 +218,12 @@ static void i915_gem_request_retire(struct > drm_i915_gem_request *request) >    */ >   list_del(&request->ring_link); >   request->ring->last_retired_head = request->postfix; > - request->i915->gt.active_

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-18 Thread Joonas Lahtinen
On pe, 2016-11-18 at 10:14 +, Chris Wilson wrote: > On Fri, Nov 18, 2016 at 11:18:09AM +0200, Joonas Lahtinen wrote: > > i915_vma_is_pinned() being true will exit this loop with -ENOSPC with > > or without NOBLOCK, just skipping the exec_entry test without it. I > > would clarify that. Now it's

Re: [Intel-gfx] [PATCH v5] drm/i915: Be more careful to drop the GT wakeref

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 01:22:11PM +0200, Joonas Lahtinen wrote: > On ti, 2016-11-15 at 16:46 +, Chris Wilson wrote: > > @@ -218,7 +218,12 @@ static void i915_gem_request_retire(struct > > drm_i915_gem_request *request) > >    */ > >   list_del(&request->ring_link); > >   request->ring->

Re: [Intel-gfx] [PATCH] drm/i915: Move frontbuffer CS write tracking from ggtt vma to object

2016-11-18 Thread Chris Wilson
On Wed, Nov 16, 2016 at 05:52:43PM -0200, Paulo Zanoni wrote: > Em Qua, 2016-11-16 às 19:07 +, Chris Wilson escreveu: > > I tried to avoid having to track the write for every VMA by only > > tracking writes to the ggtt. However, for the purposes of frontbuffer > > tracking this is insufficient

[Intel-gfx] [PATCH] drm/i915: Do not log disabled planes in pipe config

2016-11-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It just says "plane X disabled" which does not seem very useful. Signed-off-by: Tvrtko Ursulin Cc: Maarten Lankhorst Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/dr

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Disable hangcheck when wedged

2016-11-18 Thread Mika Kuoppala
Chris Wilson writes: > If the gpu reset fails and the machine is terminally wedged, further > hangchecks achieve nothing but noise. Disable them, with a corollary > that we re-enable hangchecking after a successful GPU reset in case the > user is artificially bringing the machine back to life thr

Re: [Intel-gfx] [PATCH v5] drm/i915: Be more careful to drop the GT wakeref

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 01:22:11PM +0200, Joonas Lahtinen wrote: > On ti, 2016-11-15 at 16:46 +, Chris Wilson wrote: > > @@ -218,7 +218,12 @@ static void i915_gem_request_retire(struct > > drm_i915_gem_request *request) > >    */ > >   list_del(&request->ring_link); > >   request->ring->

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 01:31:57PM +0200, Joonas Lahtinen wrote: > On pe, 2016-11-18 at 10:14 +, Chris Wilson wrote: > > On Fri, Nov 18, 2016 at 11:18:09AM +0200, Joonas Lahtinen wrote: > > > i915_vma_is_pinned() being true will exit this loop with -ENOSPC with > > > or without NOBLOCK, just sk

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 01:31:57PM +0200, Joonas Lahtinen wrote: > On pe, 2016-11-18 at 10:14 +, Chris Wilson wrote: > > On Fri, Nov 18, 2016 at 11:18:09AM +0200, Joonas Lahtinen wrote: > > > I don't quite see why? Are you expecting the iteration to hit same vma > > > twice? Or somebody moving

Re: [Intel-gfx] [PATCH 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

2016-11-18 Thread kbuild test robot
-Weinehall/Resume-time-optimisation/20161118-181301 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-x009-201646 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH

Re: [Intel-gfx] [PATCH v5] drm/i915: Be more careful to drop the GT wakeref

2016-11-18 Thread Imre Deak
On pe, 2016-11-18 at 11:50 +, Chris Wilson wrote: > On Fri, Nov 18, 2016 at 01:22:11PM +0200, Joonas Lahtinen wrote: > > On ti, 2016-11-15 at 16:46 +, Chris Wilson wrote: > > > @@ -218,7 +218,12 @@ static void i915_gem_request_retire(struct > > > drm_i915_gem_request *request) > > >    */ >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Protect dev_priv->atomic_cdclk_freq with all the crtc locks

2016-11-18 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 11:26:18AM +0100, Maarten Lankhorst wrote: > Op 17-11-16 om 16:06 schreef Ville Syrjälä: > > On Tue, Nov 15, 2016 at 02:53:00PM +0100, Maarten Lankhorst wrote: > >> Op 15-11-16 om 14:41 schreef Ville Syrjälä: > >>> On Tue, Nov 15, 2016 at 11:14:29AM +0100, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v5] drm/i915: Be more careful to drop the GT wakeref

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 02:25:20PM +0200, Imre Deak wrote: > On pe, 2016-11-18 at 11:50 +, Chris Wilson wrote: > > On Fri, Nov 18, 2016 at 01:22:11PM +0200, Joonas Lahtinen wrote: > > > On ti, 2016-11-15 at 16:46 +, Chris Wilson wrote: > > > > @@ -218,7 +218,12 @@ static void i915_gem_reque

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Try to group more logically in intel_dump_pipe_config

2016-11-18 Thread Patchwork
== Series Details == Series: drm/i915: Try to group more logically in intel_dump_pipe_config URL : https://patchwork.freedesktop.org/series/15547/ State : failure == Summary == Series 15547v1 drm/i915: Try to group more logically in intel_dump_pipe_config https://patchwork.freedesktop.org/api/

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Complete requests in nop_submit_request

2016-11-18 Thread Tvrtko Ursulin
On 18/11/2016 09:37, Chris Wilson wrote: Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer transfer onto execution timeline to actual hw submission") the global seqno advance was deferred until the submit_request callback. After wedging the GPU, we were installing a nop_sub

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Complete requests in nop_submit_request

2016-11-18 Thread Mika Kuoppala
Tvrtko Ursulin writes: > On 18/11/2016 09:37, Chris Wilson wrote: >> Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer >> transfer onto execution timeline to actual hw submission") the >> global seqno advance was deferred until the submit_request callback. >> After wedging t

[Intel-gfx] [PATCH 2/6] drm/i915: Decouple hang detection from hangcheck period

2016-11-18 Thread Mika Kuoppala
Hangcheck state accumulation has gained more steps along the years, like head movement and more recently the subunit inactivity check. As the subunit sampling is only done if the previous state check showed inactivity, we have added more stages (and time) to reach a hang verdict. Asymmetric engine

[Intel-gfx] [PATCH 5/6] drm/i915: Add per client max context ban limit

2016-11-18 Thread Mika Kuoppala
If we have a bad client submitting unfavourably across different contexts, creating new ones, the per context scoring of badness doesn't remove the root cause, the offending client. To counter, keep track of per client context bans. Deny access if client is responsible for more than 3 context bans

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Do not log disabled planes in pipe config

2016-11-18 Thread Patchwork
== Series Details == Series: drm/i915: Do not log disabled planes in pipe config URL : https://patchwork.freedesktop.org/series/15548/ State : failure == Summary == Series 15548v1 drm/i915: Do not log disabled planes in pipe config https://patchwork.freedesktop.org/api/1.0/series/15548/revisio

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-18 Thread Jani Nikula
On Fri, 18 Nov 2016, Manasi Navare wrote: > If link training fails, then we need to fallback to lower > link rate first and if link training fails at RBR, then > fallback to lower lane count. > This function finds the next lower link rate/lane count > value after link training failure. > > v4: > *

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-18 Thread Jani Nikula
On Fri, 18 Nov 2016, Manasi Navare wrote: > If link training at a link rate optimal for a particular > mode fails during modeset's atomic commit phase, then we > let the modeset complete and then retry. We save the link rate > value at which link training failed, update the link status property >

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Complete requests in nop_submit_request

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 03:03:21PM +0200, Mika Kuoppala wrote: > Tvrtko Ursulin writes: > > > On 18/11/2016 09:37, Chris Wilson wrote: > >> Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer > >> transfer onto execution timeline to actual hw submission") the > >> global seqno

[Intel-gfx] [PATCH v2 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-18 Thread David Weinehall
On resume we unbind+bind our VMA-mappings. This patch simplifies this a bit by introducing a restore_vma() helper. As a nice side-effect this also makes the resume callgraph self-documenting. v2: move the helper to i915_gem_gtt.c since it's only used by i915_gem_restore_gtt_mappings(), rename

[Intel-gfx] [PATCH v2 0/3] Resume time optimisation

2016-11-18 Thread David Weinehall
This patch series aims to reduce the time we spend in i915_gem_restore_gtt_mappings() on resume. Now that we're getting the resume times down a bit this function started to stand out. David Weinehall (3): drm/i915: Cleanup i915_gem_restore_gtt_mappings() drm/i915: Take runtime pm in i915_gem_

[Intel-gfx] [PATCH v2 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

2016-11-18 Thread David Weinehall
Benchmarking shows that on resume we spend quite a bit of time just taking and dropping these references, leaving us two options; either rewriting the code not to take these references more than once, which would be a rather invasive change since the involved functions are used from other places, o

[Intel-gfx] [PATCH v2 2/3] drm/i915: Take runtime pm in i915_gem_resume()

2016-11-18 Thread David Weinehall
In i915_gem_resume(), before calling i915_gem_restore_gtt_mappings(), we want to take the runtime PM wakelocks for the entire duration instead of many short lived wakelocks around each access to the GGTT. We will take it in i915_gem_resume() as any other GEM operation is likely to require the gT po

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-18 Thread Maarten Lankhorst
Op 18-11-16 om 08:13 schreef Manasi Navare: > CRTC state connector_changed needs to be set to true > if connector link status property has changed. This will tell the > driver to do a complete modeset due to change in connector property. > > Acked-by: Harry Wentland > Acked-by: Tony Cheng > Cc: d

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 03:36:45PM +0200, David Weinehall wrote: > On resume we unbind+bind our VMA-mappings. This patch simplifies > this a bit by introducing a restore_vma() helper. As a nice side-effect > this also makes the resume callgraph self-documenting. > > v2: move the helper to i915_ge

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 03:36:47PM +0200, David Weinehall wrote: > Benchmarking shows that on resume we spend quite a bit of time > just taking and dropping these references, leaving us two options; > either rewriting the code not to take these references more than > once, which would be a rather i

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-18 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 02:50:52PM +0100, Maarten Lankhorst wrote: > Op 18-11-16 om 08:13 schreef Manasi Navare: > > CRTC state connector_changed needs to be set to true > > if connector link status property has changed. This will tell the > > driver to do a complete modeset due to change in connec

Re: [Intel-gfx] [PATCH] drm/i915: Do not log disabled planes in pipe config

2016-11-18 Thread Maarten Lankhorst
Op 18-11-16 om 12:40 schreef Tvrtko Ursulin: > From: Tvrtko Ursulin > > It just says "plane X disabled" which does not seem very useful. > > Signed-off-by: Tvrtko Ursulin > Cc: Maarten Lankhorst > Cc: Ville Syrjälä Could we remove plane dumping altogether? It's not safe to do so in the way don

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Split up hangcheck phases (rev3)

2016-11-18 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Split up hangcheck phases (rev3) URL : https://patchwork.freedesktop.org/series/15423/ State : success == Summary == Series 15423v3 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15423/revisions/3/m

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: optimise intel_runtime_pm_{get, put}

2016-11-18 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 02:00:40PM +, Chris Wilson wrote: > On Fri, Nov 18, 2016 at 03:36:47PM +0200, David Weinehall wrote: > > Benchmarking shows that on resume we spend quite a bit of time > > just taking and dropping these references, leaving us two options; > > either rewriting the code no

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Add per-pipe plane identifier

2016-11-18 Thread Paulo Zanoni
Em Qui, 2016-11-17 às 21:43 +0200, Ville Syrjälä escreveu: > On Thu, Nov 17, 2016 at 05:09:38PM -0200, Paulo Zanoni wrote: > > > > Em Ter, 2016-11-08 às 16:47 +0200, ville.syrj...@linux.intel.com > > escreveu: > > > > > > From: Ville Syrjälä > > > > > > As I told people in [1] we really should

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-18 Thread Maarten Lankhorst
Op 18-11-16 om 15:11 schreef Ville Syrjälä: > On Fri, Nov 18, 2016 at 02:50:52PM +0100, Maarten Lankhorst wrote: >> Op 18-11-16 om 08:13 schreef Manasi Navare: >>> CRTC state connector_changed needs to be set to true >>> if connector link status property has changed. This will tell the >>> driver t

Re: [Intel-gfx] [PATCH] drm/i915: Do not log disabled planes in pipe config

2016-11-18 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 03:13:14PM +0100, Maarten Lankhorst wrote: > Op 18-11-16 om 12:40 schreef Tvrtko Ursulin: > > From: Tvrtko Ursulin > > > > It just says "plane X disabled" which does not seem very useful. > > > > Signed-off-by: Tvrtko Ursulin > > Cc: Maarten Lankhorst > > Cc: Ville Syrjäl

[Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-18 Thread Jani Nikula
The platform flags in device info are (mostly) mutually exclusive. Replace the flags with an enum. Add the platform enum also for platforms that previously didn't have a flag, and give them codename logging in dmesg. Pineview remains an exception, the platform being G33 for that. Signed-off-by: J

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Complete requests in nop_submit_request

2016-11-18 Thread Tvrtko Ursulin
On 18/11/2016 13:33, Chris Wilson wrote: On Fri, Nov 18, 2016 at 03:03:21PM +0200, Mika Kuoppala wrote: Tvrtko Ursulin writes: On 18/11/2016 09:37, Chris Wilson wrote: Since the submit/execute split in commit d55ac5bf97c6 ("drm/i915: Defer transfer onto execution timeline to actual hw submi

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Rename the local 'plane' variable to 'plane_id' in primary plane code

2016-11-18 Thread Paulo Zanoni
Em Ter, 2016-11-08 às 16:47 +0200, ville.syrj...@linux.intel.com escreveu: > From: Ville Syrjälä > > Now we've rename the local plane id variable as 'plane_id' everywhere > except the pre-SKL primary plane code. Let's do the rename there as > well > so that we'll free up the name 'plane' for use

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 04:20:32PM +0200, Jani Nikula wrote: > The platform flags in device info are (mostly) mutually > exclusive. Replace the flags with an enum. Add the platform enum also > for platforms that previously didn't have a flag, and give them codename > logging in dmesg. > > Pineview

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-18 Thread Tvrtko Ursulin
On 18/11/2016 14:20, Jani Nikula wrote: The platform flags in device info are (mostly) mutually exclusive. Replace the flags with an enum. Add the platform enum also for platforms that previously didn't have a flag, and give them codename logging in dmesg. It just saddens me a bit that it prev

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Add per-pipe plane identifier

2016-11-18 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 12:17:06PM -0200, Paulo Zanoni wrote: > Em Qui, 2016-11-17 às 21:43 +0200, Ville Syrjälä escreveu: > > On Thu, Nov 17, 2016 at 05:09:38PM -0200, Paulo Zanoni wrote: > > > > > > Em Ter, 2016-11-08 às 16:47 +0200, ville.syrj...@linux.intel.com > > > escreveu: > > > > > > > >

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Rename the local 'plane' variable to 'plane_id' in primary plane code

2016-11-18 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 12:25:30PM -0200, Paulo Zanoni wrote: > Em Ter, 2016-11-08 às 16:47 +0200, ville.syrj...@linux.intel.com > escreveu: > > From: Ville Syrjälä > > > > Now we've rename the local plane id variable as 'plane_id' everywhere > > except the pre-SKL primary plane code. Let's do th

[Intel-gfx] [PATCH] drm/i915: Check that each request phase is completed before retiring

2016-11-18 Thread Chris Wilson
Trying to chase an impossible bug (ivb): [ 207.765411] [drm:i915_reset_and_wakeup [i915]] resetting chip [ 207.765734] [drm:i915_gem_reset [i915]] resetting render ring to restart from tail of request 0x4ee834 [ 207.765791] [drm:intel_print_rc6_info [i915]] Enabling RC6 states: RC6 on RC6p on

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Stop the machine as we install the wedged submit_request handler

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 09:37:08AM +, Chris Wilson wrote: > In order to prevent a race between the old callback submitting an > incomplete request and i915_gem_set_wedged() installing its nop handler, > we must ensure that the swap occurs when the machine is idle > (stop_machine). > > Signed-o

[Intel-gfx] ✗ Fi.CI.BAT: failure for Resume time optimisation (rev2)

2016-11-18 Thread Patchwork
== Series Details == Series: Resume time optimisation (rev2) URL : https://patchwork.freedesktop.org/series/15545/ State : failure == Summary == Series 15545v2 Resume time optimisation https://patchwork.freedesktop.org/api/1.0/series/15545/revisions/2/mbox/ Test pm_rpm: Subgroup basic

[Intel-gfx] [PATCH i-g-t v6 01/21] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-11-18 Thread robert . foss
From: Robert Foss Base functions to help testing the Sync File Framework (explicit fencing mechanism ported from Android). These functions allow you to create, use and destroy timelines and fences. Signed-off-by: Robert Foss Signed-off-by: Gustavo Padovan Reviewed-by: Eric Engestrom --- lib/

[Intel-gfx] [PATCH i-g-t v6 00/21] Implement sw_sync test

2016-11-18 Thread robert . foss
From: Robert Foss This series implements the sw_sync test and the lib/sw_sync helper functions for said test. The sw_sync subtests range from very basic tests of the sw_sync functionality, to stress testing and randomized tests. Changes since v1: Added "Reviewed-by: Eric Engestrom " tag

[Intel-gfx] [PATCH i-g-t v6 03/21] tests/sw_sync: Add subtest test_alloc_fence

2016-11-18 Thread robert . foss
From: Robert Foss Add subtest alloc_fence that verifies that it's possible to allocate a fence on a timeline. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c inde

[Intel-gfx] [PATCH i-g-t v6 05/21] tests/sw_sync: Add subtest test_alloc_merge_fence

2016-11-18 Thread robert . foss
From: Robert Foss This subtest verifies that merging two fences works in the simples possible case. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index f

[Intel-gfx] [PATCH i-g-t v6 07/21] tests/sw_sync: Add subtest test_sync_merge

2016-11-18 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge that tests merging fences and the validity of the resulting merged fence. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 67 + 1 file changed, 67 insertions(+)

[Intel-gfx] [PATCH i-g-t v6 08/21] tests/sw_sync: Add subtest test_sync_merge_same

2016-11-18 Thread robert . foss
From: Robert Foss This subtest verifies merging a fence with itself does not fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index 96dcbff..ada12

[Intel-gfx] [PATCH i-g-t v6 18/21] tests/sw_sync: Add igt_require check for sw_sync feature

2016-11-18 Thread robert . foss
From: Robert Foss Make sure that this test is skipped if the sw_sync feature is missing from the host system. Signed-off-by: Robert Foss --- lib/sw_sync.c | 1 + tests/sw_sync.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/sw_sync.c b/lib/sw_sync.c index 38fe670..ac793ad 10064

[Intel-gfx] [PATCH i-g-t v6 11/21] tests/sw_sync: Add subtest test_sync_random_merge

2016-11-18 Thread robert . foss
From: Robert Foss This subtest verifies that creating many timelines and merging random fences from each timeline with eachother results in merged fences that are fully functional. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 73

[Intel-gfx] [PATCH i-g-t v6 09/21] tests/sw_sync: Add subtest test_sync_multi_consumer

2016-11-18 Thread robert . foss
From: Robert Foss This subtest verifies the access ordering of multiple consumer threads. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 103 1 file changed, 103 insertions(+) diff --git a/tests/sw_sync.c

[Intel-gfx] [PATCH i-g-t v6 12/21] tests/sw_sync: Add subtest test_sync_multi_timeline_wait

2016-11-18 Thread robert . foss
From: Robert Foss This subtest verifies that waiting, timing out on a wait and that counting fences in various states works. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 66 + 1 file changed, 66 insertions

[Intel-gfx] [PATCH i-g-t v6 10/21] tests/sw_sync: Add subtest test_sync_multi_consumer_producer

2016-11-18 Thread robert . foss
From: Robert Foss This test verifies that stressing the kernel by creating multiple consumer/producer threads that wait on a single timeline to be incremented by another conumer/producer thread does not fail. And that the order amongst the threads is maintained. Signed-off-by: Robert Foss Revie

[Intel-gfx] [PATCH i-g-t v6 04/21] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline

2016-11-18 Thread robert . foss
From: Robert Foss This subtests tests that creating fences on negative timelines fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index 8e7764a..f9d4fe9 100644 --- a/te

  1   2   >