On Wed, Nov 23, 2016 at 11:28:21PM -0800, Manasi Navare wrote:
> This is RFC patch for adding a connector link-status property
> and making it atomic by adding it to the drm_connector_state.
> This is to make sure its wired properly in drm_atomic_connector_set_property
> and drm_atomic_connector_ge
On Wed, Nov 23, 2016 at 07:43:21AM +, Tian, Kevin wrote:
> It's also the style how CPU page table is managed...
But it is not the style of how the GPU page table behaves, which is what
the code expects. My only concern here is if the fact that the page is
not idle has further rammifactions.
-C
This is RFC patch for adding a connector link-status property
and making it atomic by adding it to the drm_connector_state.
This is to make sure its wired properly in drm_atomic_connector_set_property
and drm_atomic_connector_get_property functions.
v3:
* Fixed a build error (Jani Saarinen)
v2:
*
On Wed, Nov 23, 2016 at 04:52:38PM -0800, Anusha Srivatsa wrote:
> Remove the enable_guc_loading parameter. Load the GuC on
> plaforms that have GuC. All issues we found so far are related
> to GuC features like the command submission, but no bug is related
> to the guc loading itself.
>
> This ad
Thanks Dan for pointing this code error. Zhenyu, your change looks fine to me.
-Original Message-
From: Zhenyu Wang [mailto:zhen...@linux.intel.com]
Sent: Thursday, November 24, 2016 10:41
To: Dan Carpenter
Cc: Zhang, Pei ; intel-gfx@lists.freedesktop.org;
igvt-g-...@lists.01.org
Subjec
== Series Details ==
Series: GEN-9 Arbitrated Bandwidth WM WA's & IPC (rev2)
URL : https://patchwork.freedesktop.org/series/15562/
State : success
== Summary ==
Series 15562v2 GEN-9 Arbitrated Bandwidth WM WA's & IPC
https://patchwork.freedesktop.org/api/1.0/series/15562/revisions/2/mbox/
fi
== Series Details ==
Series: drm: Add a new connector atomic property for link status (rev3)
URL : https://patchwork.freedesktop.org/series/15781/
State : failure
== Summary ==
CC drivers/acpi/acpica/utpredef.o
CONMK drivers/tty/vt/consolemap_deftbl.c
CC drivers/acpi/acpica/u
This patch adds IPC support for platforms. This patch enables IPC
only for BXT/KBL platform as for SKL recommendation is to keep is disabled.
IPC (Isochronous Priority Control) is the hardware feature, which
dynamically controles the memory read priority of Display.
When IPC is enabled, plane read
If IPC is enabled in BXT, display underruns are observed.
WA: The Line Time programmed in the WM_LINETIME register should be
half of the actual calculated Line Time.
Programmed Line Time = 1/2*Calculated Line Time
Signed-off-by: Mahesh Kumar
Reviewed-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i
This patch changes Watermak calculation to fixed point calculation.
Problem with current calculation is during plane_blocks_per_line
calculation we divide intermediate blocks with min_scanlines and
takes floor of the result because of integer operation.
hence we end-up assigning less blocks than re
This patch Adds a function to extract intel_crtc_state from the
atomic_state, if not available it returns NULL.
Signed-off-by: Mahesh Kumar
Reviewed-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_drv.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/int
This patch implemnets Workariunds related to display arbitrated memory
bandwidth. These WA are applicabe for all gen-9 based platforms.
Changes since v1:
- Rebase on top of Paulo's patch series
Changes since v2:
- Address review comments
- Rebase/rework as per other patch changes in series
Sig
IPC (Isoch Priority Control) may cause underflows.
KBL WA: When IPC is enabled, watermark latency values must be increased
by 4us across all levels. This brings level 0 up to 6us.
Signed-off-by: Mahesh Kumar
Reviewed-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_pm.c | 4
1 file changed
This patch adds variable to check for X_tiled & y_tiled planes, instead
of always checking against framebuffer-modifiers.
Changes:
- Created separate patch as per Paulo's comment
- Added x_tiled variable as well
Changes since V2:
- Incorporate Paulo's comments
- Rebase
Signed-off-by: Mahesh K
This patch adds support to decode system memory bandwidth
which will be used for arbitrated display memory percentage
calculation in GEN9 based system.
Changes from v1:
- Address comments from Paulo
- implement decode function for SKL/KBL also
Changes from v2:
- Rewrite the code as per HW team
This series implements following set of functionality
Implement IPC WA's for Broxton/KBL
Enable IPC in supported platforms
Convert WM calculation to fixed point calculation
Calculation of System memory Bandwidth for SKL/KBL/BXT
Implementation of Arbitrated me
Hi Ander,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20161123]
[cannot apply to v4.9-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ander
On 2016.11.24 01:17:06 +0300, Dan Carpenter wrote:
> Hello Pei Zhang,
>
> The patch 90d27a1b180e: "drm/i915/gvt: fix deadlock in
> workload_thread" from Nov 14, 2016, leads to the following static
> checker warning:
>
> drivers/gpu/drm/i915/gvt/scheduler.c:217 dispatch_workload()
> wa
This is RFC patch for adding a connector link-status property
and making it atomic by adding it to the drm_connector_state.
This is to make sure its wired properly in drm_atomic_connector_set_property
and drm_atomic_connector_get_property functions.
v2:
* Removed connector->link_status (Daniel Vet
On Wed, Nov 23, 2016 at 02:27:43PM -0800, Anusha Srivatsa wrote:
> From: Peter Antoine
>
> This patch will allow for getparams to return the status of the HuC.
> As the HuC has to be validated by the GuC this patch uses the validated
> status to show when the HuC is loaded and ready for use. You
Remove the enable_guc_loading parameter. Load the GuC on
plaforms that have GuC. All issues we found so far are related
to GuC features like the command submission, but no bug is related
to the guc loading itself.
This addresses the case when we need GuC loaded even with no GuC feature
in use, lik
This looks like a mistake in 1f43677f895a88ae880b35f9b18cc7e6869d0ca6.
---
tools/intel_aubdump.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This code still looks really weird. ${foo:bar} means "the value of $foo,
unless it's unset/empty, in which case 'bar'. But if $file is empty...
== Series Details ==
Series: drm/i915: kick out cmd_parser specific structs from i915_drv.h
URL : https://patchwork.freedesktop.org/series/15854/
State : success
== Summary ==
Series 15854v1 drm/i915: kick out cmd_parser specific structs from i915_drv.h
https://patchwork.freedesktop.org/api/1.
On Wed, Nov 23, 2016 at 03:07:30PM +0200, Jani Nikula wrote:
> On Tue, 22 Nov 2016, Manasi Navare wrote:
> > This patch adds support to handle automated DP compliance
> > link training test requests. This patch has been tested with
> > Unigraf DPR-120 DP Compliance device for testing Link
> > Trai
No sense in keeping the cmd_descriptor and cmd_table structs in
i915_drv.h, now that they are no longer referenced externally.
Cc: Chris Wilson
Signed-off-by: Matthew Auld
---
drivers/gpu/drm/i915/i915_cmd_parser.c | 96 ++
drivers/gpu/drm/i915/i915_drv.h
== Series Details ==
Series: HuC Loading Patches
URL : https://patchwork.freedesktop.org/series/15850/
State : success
== Summary ==
Series 15850v1 HuC Loading Patches
https://patchwork.freedesktop.org/api/1.0/series/15850/revisions/1/mbox/
fi-bdw-5557u total:244 pass:229 dwarn:0 dfa
From: Peter Antoine
The HuC authentication is done by host2guc call. The HuC RSA keys
are sent to GuC for authentication.
v2: rebased on top of drm-intel-nightly.
changed name format and upped version 1.7.
v3: rebased on top of drm-intel-nightly.
v4: changed wait_for_automic to wait_for
v5:
From: Peter Antoine
HuC firmware css header has almost exactly same definition as GuC
firmware except for the sw_version. Also, add a new member fw_type
into intel_uc_fw to indicate what kind of fw it is. So, the loader
will pull right sw_version from header.
v2: rebased on-top of drm-intel-nigh
From: Peter Antoine
Add debugfs entry for HuC loading status check.
v2: rebase on-top of drm-intel-nightly.
v3: rebased again.
v7: rebased.
v8: rebased.
v9: rebased.
v10: rebased.
Tested-by: Xiang Haihao
Signed-off-by: Anusha Srivatsa
Signed-off-by: Alex Dai
Signed-off-by: Peter Antoine
Rev
This patch adds the HuC Loading for the BXT by using
the updated file construction.
Version 1.7 of the HuC firmware.
v2: rebased.
Cc: Jeff Mcgee
Signed-off-by: Anusha Srivatsa
Reviewed-by: Jeff McGee
---
drivers/gpu/drm/i915/intel_huc_loader.c | 11 +++
1 file changed, 11 insertions(
From: Peter Antoine
The HuC loading process is similar to GuC. The intel_uc_fw_fetch()
is used for both cases.
HuC loading needs to be before GuC loading. The WOPCM setting must
be done early before loading any of them.
v2: rebased on-top of drm-intel-nightly.
removed if(HAS_GUC()) before t
This patch adds the support to load HuC on KBL
Version 2.0
v2: rebased.
Cc: Jeff Mcgee
Signed-off-by: Anusha Srivatsa
Reviewed-by: Jeff McGee
---
drivers/gpu/drm/i915/intel_huc_loader.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_huc_loader
From: Peter Antoine
This patch will allow for getparams to return the status of the HuC.
As the HuC has to be validated by the GuC this patch uses the validated
status to show when the HuC is loaded and ready for use. You cannot use
the loaded status as with the GuC as the HuC is verified after i
These patches add HuC loading support. The userspace
patches that check for a fully loaded HuC firmware and use
it can be found at:
https://lists.freedesktop.org/archives/libva/2016-September/004554.html
https://lists.freedesktop.org/archives/libva/2016-September/004555.html
v2: rebased.
v3: reba
From: Peter Antoine
Rename some of the GuC fw loading code to make them more general. We
will utilise them for HuC loading as well.
s/intel_guc_fw/intel_uc_fw/g
s/GUC_FIRMWARE/UC_FIRMWARE/g
Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members,
such as 'guc' or 'guc_fw'
Hello Pei Zhang,
The patch 90d27a1b180e: "drm/i915/gvt: fix deadlock in
workload_thread" from Nov 14, 2016, leads to the following static
checker warning:
drivers/gpu/drm/i915/gvt/scheduler.c:217 dispatch_workload()
warn: inconsistent returns 'mutex:&dev_priv->drm.struct_mutex'.
On Mon, Nov 14, 2016 at 06:35:08PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> My little fix for populating intel_state->cdclk with
> dev_priv->atomic_cdclk_freq became a little meatier after I realized
> that we really need to protect it with what is essentially a crtc
On Tue, Nov 22, 2016 at 03:00:14PM +0200, Ville Syrjälä wrote:
> On Mon, Nov 21, 2016 at 02:24:06PM -0800, Bob Paauwe wrote:
> > For BXT, there is only one bit that enables/disables dual-link mode
> > and not different bits depending on which pipe is being used.
> >
> > Signed-off-by: Bob Paauwe
On Tue, Nov 22, 2016 at 06:01:55PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> I ended up tweaking quite a few of the patches (and even adding a new one)
> based on Paulo's review, so figured I'd repost the entire thing.
>
> I didn't do the _ID_ rename thing, at least n
On Wed, Nov 23, 2016 at 11:15:45AM +0100, Maarten Lankhorst wrote:
> Op 22-11-16 om 21:28 schreef Lyude Paul:
> > Reviewed-by: Lyude
> >
> > On Tue, 2016-11-22 at 22:21 +0200, ville.syrj...@linux.intel.com wrote:
> >> From: Ville Syrjälä
> >>
> >> Someone forgot to make skl_write_{plane,cursor}_w
On Wed, Nov 23, 2016 at 11:00:59AM +0100, Daniel Vetter wrote:
> On Tue, Nov 22, 2016 at 05:30:21PM -0800, Manasi Navare wrote:
> > This is RFC patch for adding a connector link-status property
> > and making it atomic by adding it to the drm_connector_state.
> > This is to make sure its wired prop
On Wed, 23 Nov 2016, Daniel Vetter wrote:
> On Tue, Nov 22, 2016 at 09:26:11PM -0800, Hugh Dickins wrote:
> > On Tue, 22 Nov 2016, Matthew Auld wrote:
> > > On 9 November 2016 at 18:36, Hugh Dickins wrote:
> > > > On Wed, 9 Nov 2016, Daniel Vetter wrote:
> > > >>
> > > >> Hi all -mm folks!
> > > >
On Wed, Nov 23, 2016 at 09:48:25PM +0530, Animesh Manna wrote:
> _DSM is added to program HPD_CTL(0x1094) register
> of PMC from i915 driver which will be called
> based on driver feature flag. PMC hpd control register
> programming will enable PMC to get hpd interrupt
> during dc9.
>
> Signed-off
== Series Details ==
Series: HPD support during suspend for BXT/APL.
URL : https://patchwork.freedesktop.org/series/15833/
State : warning
== Summary ==
Series 15833v1 HPD support during suspend for BXT/APL.
https://patchwork.freedesktop.org/api/1.0/series/15833/revisions/1/mbox/
Test drv_mod
== Series Details ==
Series: drm/i915/perf: Wrap 64bit divides in do_div() (rev3)
URL : https://patchwork.freedesktop.org/series/15769/
State : success
== Summary ==
Series 15769v3 drm/i915/perf: Wrap 64bit divides in do_div()
https://patchwork.freedesktop.org/api/1.0/series/15769/revisions/3/
On Wed, Nov 23, 2016 at 09:48:27PM +0530, Animesh Manna wrote:
> While suspending the device hpd related interrupts are enabled
> to get the interrupt when device is in suspend state.
>
> Though display is in DC9 but system can be in S0 or S0i3 state.
> Hot plug during S0 state will generate de_po
On Wed, 2016-11-23 at 21:48 +0530, Animesh Manna wrote:
> While suspending the device hpd related interrupts are enabled
> to get the interrupt when device is in suspend state.
>
> Though display is in DC9 but system can be in S0 or S0i3 state.
> Hot plug during S0 state will generate de_port_inte
== Series Details ==
Series: drm/i915: Pass dev_priv to intel_setup_outputs() (rev2)
URL : https://patchwork.freedesktop.org/series/15820/
State : success
== Summary ==
Series 15820v2 drm/i915: Pass dev_priv to intel_setup_outputs()
https://patchwork.freedesktop.org/api/1.0/series/15820/revisi
On Wed, Nov 23, 2016 at 09:48:23PM +0530, Animesh Manna wrote:
> Guid is changed for bxt platform, so corrected the guid for bxt.
>
> v1: Initial version as RFC.
>
> v2: Based on review comment from Jani and David,
> have kept guid as binary format.
>
> Signed-off-by: Ananth Krishna R
> Signed-
On Wed, Nov 23, 2016 at 05:53:50PM +0200, Abdiel Janulgue wrote:
> +static int at_exit_drm_fd = -1;
> +
> +static void quiescent_gpu_at_exit(int sig)
> +{
> + if (at_exit_drm_fd < 0)
> + return;
> +
> + gem_quiescent_gpu(at_exit_drm_fd);
> + at_exit_drm_fd = -1;
> +}
> +
> +
== Series Details ==
Series: series starting with [1/5] drm: Define drm_mm_for_each_node_in_range()
URL : https://patchwork.freedesktop.org/series/15825/
State : warning
== Summary ==
Series 15825v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/15825/revisions/1/
On Wed, Nov 23, 2016 at 4:52 PM, Jani Nikula
wrote:
>> Take the CDN DP driver in rockchip for example (posted yesterday).
>> There's a worker in the driver that is responsible for handling
>> hpd/extcon events from the USB-C port. Ideally, this worker should
>> just be a thin shell around a kms ue
On Wed, Nov 23, 2016 at 10:52 AM, Jani Nikula
wrote:
> On Wed, 23 Nov 2016, Sean Paul wrote:
>> On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula
>> wrote:
>>> On Wed, 23 Nov 2016, Sean Paul wrote:
On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote:
> On Tue, Nov 22, 2016 at 09:27:35PM
Along with below patches sharing some background details/design.
- On BXT, Display cannot generate an interrupt when in D3.
- Without display in D3, S0ix can be achieved, Power impact will be zero if d3
is blocked. PMCSR for Graphics/Display is irrelevant, as the power management
for them is take
_DSM is added to program HPD_CTL(0x1094) register
of PMC from i915 driver which will be called
based on driver feature flag. PMC hpd control register
programming will enable PMC to get hpd interrupt
during dc9.
Signed-off-by: Animesh Manna
---
drivers/gpu/drm/i915/intel_acpi.c | 44 +
On Wed, Nov 23, 2016 at 10:43 AM, Ville Syrjälä
wrote:
> On Wed, Nov 23, 2016 at 10:32:44AM -0500, Sean Paul wrote:
>> On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula
>> wrote:
>> > On Wed, 23 Nov 2016, Sean Paul wrote:
>> >> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote:
>> >>> On Tue, No
For BXT, display engine can not generate interrupt when in D3.
On the othen hand S0ix can be achieved without display in D3. So,
Display should not put into D3 for HPD to work and will not
have any power impact.
v1: Initial version as RFC.
v2: Based on review comment from David,
condition check f
While suspending the device hpd related interrupts are enabled
to get the interrupt when device is in suspend state.
Though display is in DC9 but system can be in S0 or S0i3 state.
Hot plug during S0 state will generate de_port_interrupt but if
system is in S0i3 state then display driver will get
Guid is changed for bxt platform, so corrected the guid for bxt.
v1: Initial version as RFC.
v2: Based on review comment from Jani and David,
have kept guid as binary format.
Signed-off-by: Ananth Krishna R
Signed-off-by: Bharath K Veera
Signed-off-by: Animesh Manna
---
drivers/gpu/drm/i915/
To support hpd during sleep a new feature flag is
added in vbt and also in dev_priv for enabling/disabling
inside driver. By default this feature will be
disabled and based on oem request this feature can
be enabled by changing vbt feature flag.
v1: Initial version as RFC.
v2: Based on review com
A lot of igt testcases need some GPU workload to make sure a race
window is big enough. Unfortunately having a fixed amount of
workload leads to spurious test failures or overly long runtimes
on some fast/slow platforms. This library contains functionality
to submit GPU workloads that should consum
On Wed, 23 Nov 2016, Sean Paul wrote:
> On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula
> wrote:
>> On Wed, 23 Nov 2016, Sean Paul wrote:
>>> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote:
On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote:
> On Tue, Nov 22, 2016 at 8:30 PM
== Series Details ==
Series: series starting with [1/3] drm: Hold mode_config.lock to prevent
hotplug whilst setting up crtcs
URL : https://patchwork.freedesktop.org/series/15823/
State : success
== Summary ==
Series 15823v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.
On Wed, Nov 23, 2016 at 10:32:44AM -0500, Sean Paul wrote:
> On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula
> wrote:
> > On Wed, 23 Nov 2016, Sean Paul wrote:
> >> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote:
> >>> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote:
> On Tue,
On Wed, Nov 23, 2016 at 10:15 AM, Jani Nikula
wrote:
> On Wed, 23 Nov 2016, Sean Paul wrote:
>> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote:
>>> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote:
On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare
wrote:
> This is RFC
On Wed, Nov 23, 2016 at 03:57:00PM +0100, Maarten Lankhorst wrote:
> In all cases we can now obtain the relevant crtc_state/conn_state
> from the relevant callbacks, which means all the ->config accesses
> can be removed and the code cleaned up.
>
> Changes since v1:
> - cstate -> crtc_state
>
>
On Wed, 23 Nov 2016, Sean Paul wrote:
> On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote:
>> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote:
>>> On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare
>>> wrote:
>>> > This is RFC patch for adding a connector link-status property
>>> > and
Just a couple of naked 64bit divides causing link errors on 32bit
builds, with:
ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!
v2: do_div() is only u64/u32, we need a u32/u64!
v3: div_u64() == u64/u32, div64_u64() == u64/u64
Reported-by: kbuild test robot
Fixes: d79651522e
On Wed, Nov 23, 2016 at 03:17:53PM +0100, Daniel Vetter wrote:
> On Wed, Nov 23, 2016 at 03:58:34PM +0200, Jani Nikula wrote:
> > On Wed, 23 Nov 2016, Ville Syrjälä wrote:
> > > On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote:
> > >> On Tue, 22 Nov 2016, Manasi Navare wrote:
> > >> >
In all cases we can now obtain the relevant crtc_state/conn_state
from the relevant callbacks, which means all the ->config accesses
can be removed and the code cleaned up.
Changes since v1:
- cstate -> crtc_state
Signed-off-by: Maarten Lankhorst
---
diff --git a/drivers/gpu/drm/i915/intel_ddi.c
On Wed, Nov 23, 2016 at 3:09 AM, Daniel Vetter wrote:
> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote:
>> On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare
>> wrote:
>> > This is RFC patch for adding a connector link-status property
>> > and making it atomic by adding it to the drm_conne
On 23/11/2016 10:45, Patchwork wrote:
== Series Details ==
Series: drm/i915/guc: Remove unused intel_guc_fw struct member
URL : https://patchwork.freedesktop.org/series/15803/
State : success
== Summary ==
Series 15803v1 drm/i915/guc: Remove unused intel_guc_fw struct member
https://patchwo
On 23/11/2016 11:15, Patchwork wrote:
== Series Details ==
Series: drm/i915: i915_gem_alloc_context_obj can be static (rev2)
URL : https://patchwork.freedesktop.org/series/15804/
State : success
== Summary ==
Series 15804v2 drm/i915: i915_gem_alloc_context_obj can be static
https://patchwor
Pass dev_priv to intel_setup_outputs() and functions called by it, since
those are all intel i915 specific functions. Also, in the majority of
the functions dev_priv is used more often than dev. In the rare cases
where there are a few calls back into drm core, a local dev variable was
added.
v2: D
On Wed, 23 Nov 2016, Chris Wilson wrote:
> +#define drm_fb_helper_for_each_connector(fbh, i__) \
> + for (({lockdep_assert_held(&(fbh)->dev->mode_config.mutex); 1;}), \
> + i__ = 0; i__ < (fbh)->connector_count; i__++)
No comments on the substance, but just curious, why is that "1;"
On Wed, Nov 23, 2016 at 03:58:34PM +0200, Jani Nikula wrote:
> On Wed, 23 Nov 2016, Ville Syrjälä wrote:
> > On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote:
> >> On Tue, 22 Nov 2016, Manasi Navare wrote:
> >> > The intel_dp_autotest_video_pattern() function gets invoked through the
>
== Series Details ==
Series: drm/i915: Moving scaler numbers to runtime init (rev3)
URL : https://patchwork.freedesktop.org/series/15726/
State : success
== Summary ==
Series 15726v3 drm/i915: Moving scaler numbers to runtime init
https://patchwork.freedesktop.org/api/1.0/series/15726/revision
We can replace a couple of tests with an assertion that the passed in
node is already allocated (as matches the existing call convention) and
by a small bit of refactoring we can bring the line lengths to under
80cols.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_vma.c | 23
Soft-pinning depends upon being able to check for availabilty of an
interval and evict overlapping object from a drm_mm range manager very
quickly. Currently it uses a linear list, and so performance is dire and
not suitable as a general replacement. Worse, the current code will oops
if it tries to
Some clients would like to iterate over every node within a certain
range. Make a nice little macro for them to hide the mixing of the
rbtree search and linear walk.
v2: Blurb
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Joonas Lahtinen
---
dr
We need to distinguish between full i915_vma structs and simple
drm_mm_nodes when considering eviction (i.e. we must be careful not to
treat a mere drm_mm_node as a much larger i915_vma causing memory
corruption, if we are lucky). To do this, color these not-a-vma with -1
(I915_COLOR_UNEVICTABLE).
Use the color_adjust callback when reserving a node to check if
inserting a node into this hole requires any additional space, and so if
that space then conflicts with an existing allocation.
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Reviewed-by: Joonas La
drm_fb_helper_probe_connector_modes() is always called before
drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a
small bit of code compaction.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_fb_helper.c | 37 +++--
1 file changed, 11 insertion
Though we only walk the kernel_fb_helper_list inside a panic (or single
thread debugging), we still need to protect the list manipulation on
creating/removing a framebuffer device in order to prevent list
corruption.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_fb_helper.c | 5 +
1 fi
The fb_helper->connector_count is modified when a new connector is
constructed following a hotplug event (e.g. DP-MST). This causes trouble
for drm_setup_crtcs() and friends that assume that fb_helper is
constant:
[ 1250.872997] BUG: KASAN: slab-out-of-bounds in drm_setup_crtcs+0x320/0xf80 at
add
On Wed, Nov 23, 2016 at 03:48:30PM +0200, Ander Conselvan de Oliveira wrote:
> Pass dev_priv to intel_setup_outputs() and functions called by it, since
> those are all intel i915 specific functions. Also, in the majority of
> the functions dev_priv is used more often than dev. In the rare cases
> w
On Tue, 22 Nov 2016, Manasi Navare wrote:
> +
> +static void get_test_videopattern_data(void)
> +{
> + int count = 0;
> + uint16_t video_pattern_value[3];
> + char video_pattern_attribute[15];
> +
> + if (!test_data_fp)
> + fprintf(stderr, "Invalid Test data File pointe
On Wed, 23 Nov 2016, Ville Syrjälä wrote:
> On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote:
>> On Tue, 22 Nov 2016, Manasi Navare wrote:
>> > The intel_dp_autotest_video_pattern() function gets invoked through the
>> > compliance test handler on a HPD short pulse if the test type is
On Wed, Nov 23, 2016 at 02:35:11PM +0200, Marius Vlad wrote:
> v5:
> - reword gem_info to gem_sanitychecks (Chris Wilson)
> - remove subgroups/subtests for gem_exec_store and gem_sanitycheck
> (Chris Wilson)
>
> v4:
> - adjust test to make use of lib/igt_kmod
> - replaced SW_FINISH with SET_CACHEI
On Wed, Nov 23, 2016 at 02:35:09PM +0200, Marius Vlad wrote:
> +static void
> +igt_show_stat(proc_t *info, const char *fn)
> +{
> + static int display = 0;
> +
> + if (!display) {
> + igt_info("%20.20s%11.11s%21.21s%11.11s%10.10s%22.22s%31.31s\n",
> + "COMM",
Pass dev_priv to intel_setup_outputs() and functions called by it, since
those are all intel i915 specific functions. Also, in the majority of
the functions dev_priv is used more often than dev. In the rare cases
where there are a few calls back into drm core, a local dev variable was
added.
Signe
In future patches, we require greater flexibility in describing
the number of scalers available on each CRTC. To ease that transition
we move the current assignment to intel_device_info. Scaler structure
initialisation is done if scaler is available on the CRTC.
Gen9 check is not required as depen
On Wed, Nov 23, 2016 at 03:37:24PM +0200, Jani Nikula wrote:
> On Tue, 22 Nov 2016, Manasi Navare wrote:
> > The intel_dp_autotest_video_pattern() function gets invoked through the
> > compliance test handler on a HPD short pulse if the test type is
> > set to DP_TEST_VIDEO_PATTERN. This performs
On Tue, 22 Nov 2016, Manasi Navare wrote:
> The intel_dp_autotest_video_pattern() function gets invoked through the
> compliance test handler on a HPD short pulse if the test type is
> set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers
> reads to read the requested test pattern, video
On Wed, Nov 23, 2016 at 02:35:10PM +0200, Marius Vlad wrote:
> v2:
> - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson)
> - do not hard-fail when i915 module could not be loaded/unloaded (Chris
> Wilson)
>
> Signed-off-by: Marius Vlad
> ---
> lib/igt_gvt.c | 37 ++
On Tue, 22 Nov 2016, Manasi Navare wrote:
> Cc: dri-de...@lists.freedesktop.org
> Cc: Jani Nikula
> Cc: Daniel Vetter
> Cc: Ville Syrjala
> Signed-off-by: Manasi Navare
> ---
> include/drm/drm_dp_helper.h | 16 +++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git
On Tue, 22 Nov 2016, Manasi Navare wrote:
> From: Jim Bride
>
> For DP compliance we need to be able to control the output color
> type for the pipe associated with the DP port. When a specific DP
> compliance test is requested with specific BPC value, we read the BPC
> value from the DPCD regist
Avoid setting a framebuffer in a format that the plane doesn't support,
so we have better debug output in IGT and we don't have to dig into
dmesg files to find out what's going on.
I found this issue when kms_plane_scaling tried to use a cursor plane as
a regular one in a Skylake machine with just
Hi,
kms_plane_scaling would happily try to use the cursor plane as if it was an
overlay, and the first signal of it would be the kernel refusing the SetPlane
call because of the pixel format not matching.
To improve this situation, we check the format of the framebuffer before
calling SetPlane (p
The test currently assumes that there are two overlay planes available,
but that's not generally true and from the error that returns the
kernel, it isn't obvious what's going on.
Signed-off-by: Tomeu Vizoso
---
tests/kms_plane_scaling.c | 4
1 file changed, 4 insertions(+)
diff --git a/te
1 - 100 of 137 matches
Mail list logo