[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/3] drm: Add a new connector atomic property for link status

2016-11-29 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm: Add a new connector atomic property for link status URL : https://patchwork.freedesktop.org/series/16150/ State : warning == Summary == Series 16150v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/1615

[Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-11-29 Thread Manasi Navare
At the time userspace does setcrtc, we've already promised the mode would work. The promise is based on the theoretical capabilities of the link, but it's possible we can't reach this in practice. The DP spec describes how the link should be reduced, but we can't reduce the link below the requireme

[Intel-gfx] [PATCH 2/3] drm/i915: Find fallback link rate/lane count

2016-11-29 Thread Manasi Navare
If link training fails, then we need to fallback to lower link rate first and if link training fails at RBR, then fallback to lower lane count. This function finds the next lower link rate/lane count value after link training failure and limits the max link_rate and lane_count values to these fallb

[Intel-gfx] [PATCH 3/3] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-29 Thread Manasi Navare
If link training at a link rate optimal for a particular mode fails during modeset's atomic commit phase, then we let the modeset complete and then retry. We save the link rate value at which link training failed, update the link status property to "BAD" and use a lower link rate to prune the modes

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gen9: Fix PCODE polling during SAGV disabling

2016-11-29 Thread Lyude Paul
One tiny nitpick below On Mon, 2016-11-28 at 13:12 +0200, Imre Deak wrote: > According to the previous patch, it's possible atm that we call > intel_do_sagv_disable() only once during the 1ms period and time out > if > that call fails. As opposed to this the spec says that we need to > keep > retr

[Intel-gfx] [PATCH v2] drm/i915: Move the release of PT page to the upper caller

2016-11-29 Thread Zhi Wang
a PT page will be released if it doesn't contain any meaningful mappings during PPGTT page table shrinking. The PT entry in the upper level will be set to a scratch entry. Normally this works nicely, but in virtualization world, the PPGTT page table is tracked by hypervisor. Releasing the PT page

Re: [Intel-gfx] [PATCH 1/3] drm/i915/debugfs: add dp mst info

2016-11-29 Thread Yang, Libin
>-Original Message- >From: Vivi, Rodrigo >Sent: Wednesday, November 30, 2016 1:22 AM >To: jani.nik...@linux.intel.com >Cc: ville.syrj...@linux.intel.com; intel-gfx@lists.freedesktop.org; Yang, Libin >; Vetter, Daniel ; >ti...@suse.de; Pandiyan, Dhinakaran >Subject: Re: [PATCH 1/3] drm/i91

Re: [Intel-gfx] [PATCH] drm/i915: Fix intel_psr_init() kerneldoc

2016-11-29 Thread kbuild test robot
Hi Ander, [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on v4.9-rc7 next-20161129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ander-Conselvan-de-Oliveira

[Intel-gfx] [PATCH 2/3] assembler: Set 3src options before sources

2016-11-29 Thread Kristian H. Kristensen
Setting the 3src sources will assert align16, but that doesn't get set until we call set_instruction_options(). Call that before setting sources. Signed-off-by: Kristian H. Kristensen --- assembler/gram.y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assembler/gram.y b/asse

[Intel-gfx] [PATCH 3/3] assembler: RSQ is a math function

2016-11-29 Thread Kristian H. Kristensen
Signed-off-by: Kristian H. Kristensen --- assembler/gram.y | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assembler/gram.y b/assembler/gram.y index f370dfa..d6f4a19 100644 --- a/assembler/gram.y +++ b/assembler/gram.y @@ -1985,7 +1985,7 @@ sampler_datatype: ; math_functio

[Intel-gfx] [PATCH 1/3] assembler: Fix assert when setting 3src sources

2016-11-29 Thread Kristian H. Kristensen
We need to map the type to the 3src encoding before comparing to insn->bits1.da3src.src_reg_type, which is 3src encoded. Signed-off-by: Kristian H. Kristensen --- assembler/brw_eu_emit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assembler/brw_eu_emit.c b/assembler/b

Re: [Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Daniel Vetter
On Tue, Nov 29, 2016 at 11:26 PM, Chris Wilson wrote: > On Tue, Nov 29, 2016 at 09:29:06PM +0100, Daniel Vetter wrote: >> On Tue, Nov 29, 2016 at 12:02:16PM +, Chris Wilson wrote: >> > drm_fb_helper_probe_connector_modes() is always called before >> > drm_setup_crtcs(), so just move the call i

Re: [Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Chris Wilson
On Tue, Nov 29, 2016 at 09:29:06PM +0100, Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 12:02:16PM +, Chris Wilson wrote: > > drm_fb_helper_probe_connector_modes() is always called before > > drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a > > small bit of code compaction.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: Enable AUX interrupts for resume time initialization (rev2)

2016-11-29 Thread Patchwork
== Series Details == Series: drm/i915/lspcon: Enable AUX interrupts for resume time initialization (rev2) URL : https://patchwork.freedesktop.org/series/16106/ State : success == Summary == Series 16106v2 drm/i915/lspcon: Enable AUX interrupts for resume time initialization https://patchwork

Re: [Intel-gfx] [PATCH i-g-t v3] lib/debugfs: Support new generic ABI for CRC capture

2016-11-29 Thread Robert Foss
Hi tomeu, This patch does not seem to apply cleanly on upstream/master. Rob. > The kernel has now a new debugfs ABI that can also allow capturing > frame > CRCs for drivers other than i915. > > Add alternative codepaths so the new ABI is used if the kernel is > recent > enough, and fall back t

Re: [Intel-gfx] [PATCH 2/3] drm/dp/mst: Calculate total link bandwidth instead of hardcoding it

2016-11-29 Thread Pandiyan, Dhinakaran
On Tue, 2016-11-29 at 22:58 +0200, Ville Syrjälä wrote: > On Thu, Nov 17, 2016 at 06:03:47PM -0800, Dhinakaran Pandiyan wrote: > > The total or the nominal link bandwidth, which we save in terms of PBN, is > > a factor of link rate and lane count. But, currently we hardcode it to > > 2560 PBN. This

Re: [Intel-gfx] [PATCH v2] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 10:41:45PM +0200, Imre Deak wrote: > On Tue, 2016-11-29 at 22:27 +0200, Ville Syrjälä wrote: > > On Tue, Nov 29, 2016 at 10:14:23PM +0200, Imre Deak wrote: > > > On Tue, 2016-11-29 at 21:55 +0200, Ville Syrjälä wrote: > > > > On Tue, Nov 29, 2016 at 09:40:29PM +0200, Imre De

Re: [Intel-gfx] [PULL] drm-misc-next

2016-11-29 Thread Stephen Rothwell
Hi Daniel, On Tue, 29 Nov 2016 12:17:15 +0100 Daniel Vetter wrote: > > drm-misc has slightly moved around, new branches for you to pull in: > > git://anongit.freedesktop.org/drm/drm-misc for-linux-next-fixes > git://anongit.freedesktop.org/drm/drm-misc for-linux-next > > It's the same aliasing

Re: [Intel-gfx] [PATCH 2/3] drm/dp/mst: Calculate total link bandwidth instead of hardcoding it

2016-11-29 Thread Ville Syrjälä
On Thu, Nov 17, 2016 at 06:03:47PM -0800, Dhinakaran Pandiyan wrote: > The total or the nominal link bandwidth, which we save in terms of PBN, is > a factor of link rate and lane count. But, currently we hardcode it to > 2560 PBN. This results in incorrect computation of total slots. > > E.g, 2 la

Re: [Intel-gfx] [PATCH v2 3/3] drm: Protect fb_helper list manipulation with a mutex

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 7:02 AM, Chris Wilson wrote: > Though we only walk the kernel_fb_helper_list inside a panic (or single > thread debugging), we still need to protect the list manipulation on > creating/removing a framebuffer device in order to prevent list > corruption. > > Signed-off-by: C

Re: [Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 3:29 PM, Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 12:02:16PM +, Chris Wilson wrote: >> drm_fb_helper_probe_connector_modes() is always called before >> drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a >> small bit of code compaction. >> >> Signe

Re: [Intel-gfx] [PATCH v2 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 7:02 AM, Chris Wilson wrote: > The fb_helper->connector_count is modified when a new connector is > constructed following a hotplug event (e.g. DP-MST). This causes trouble > for drm_setup_crtcs() and friends that assume that fb_helper is > constant: > > [ 1250.872997] BUG:

Re: [Intel-gfx] [PATCH i-g-t 0/2] Improve error report when there are less overlays than expected

2016-11-29 Thread Robert Foss
Hi tomeu, This series looks good to me, feel free to add my r-b. Rob. > Hi, > > kms_plane_scaling would happily try to use the cursor plane as if it > was an > overlay, and the first signal of it would be the kernel refusing the > SetPlane > call because of the pixel format not matching. > >

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: More documentation hooked to i915.rst

2016-11-29 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915/perf: More documentation hooked to i915.rst > URL : https://patchwork.freedesktop.org/series/16114/ > State : warning > > == Summary == > > Series 16114v1 drm/i915/perf: More documentation hooked to i915.rst > https://patchwork.freedesktop.org/api/1.

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: More documentation hooked to i915.rst

2016-11-29 Thread Patchwork
== Series Details == Series: drm/i915/perf: More documentation hooked to i915.rst URL : https://patchwork.freedesktop.org/series/16114/ State : warning == Summary == Series 16114v1 drm/i915/perf: More documentation hooked to i915.rst https://patchwork.freedesktop.org/api/1.0/series/16114/revis

Re: [Intel-gfx] [PATCH] drm/i915/perf: use DRM_INFO for userspace issues

2016-11-29 Thread Chris Wilson
On Tue, Nov 29, 2016 at 04:57:59PM +, Robert Bragg wrote: > Avoid using DRM_ERROR for conditions userspace can trigger with a bad > config when opening a stream or from not reading data in a timely > fashion (whereby the OA buffer fills up). These conditions are tested > by i-g-t which treats e

Re: [Intel-gfx] [PATCH v2] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-11-29 Thread Imre Deak
On Tue, 2016-11-29 at 22:27 +0200, Ville Syrjälä wrote: > On Tue, Nov 29, 2016 at 10:14:23PM +0200, Imre Deak wrote: > > On Tue, 2016-11-29 at 21:55 +0200, Ville Syrjälä wrote: > > > On Tue, Nov 29, 2016 at 09:40:29PM +0200, Imre Deak wrote: > > > > For LSPCON initialization during system resume we

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-29 Thread Manasi Navare
On Tue, Nov 29, 2016 at 02:43:55PM -0500, Sean Paul wrote: > On Tue, Nov 29, 2016 at 9:45 AM, Sean Paul wrote: > > On Mon, Nov 28, 2016 at 7:59 PM, Manasi Navare > > wrote: > >> On Wed, Nov 23, 2016 at 09:09:28AM +0100, Daniel Vetter wrote: > >>> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Pau

Re: [Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Daniel Vetter
On Tue, Nov 29, 2016 at 12:02:16PM +, Chris Wilson wrote: > drm_fb_helper_probe_connector_modes() is always called before > drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a > small bit of code compaction. > > Signed-off-by: Chris Wilson > Reviewed-by: Daniel Vetter rb not

Re: [Intel-gfx] [PATCH v2] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 10:14:23PM +0200, Imre Deak wrote: > On Tue, 2016-11-29 at 21:55 +0200, Ville Syrjälä wrote: > > On Tue, Nov 29, 2016 at 09:40:29PM +0200, Imre Deak wrote: > > > For LSPCON initialization during system resume we need AUX > > > functionality, but we call the corresponding enc

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/dp: Validate mode against max. link data rate for DP MST

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 15, 2016 at 12:59:06PM -0800, Dhinakaran Pandiyan wrote: > Not validating the mode rate against max. link rate results in not pruning > invalid modes. For e.g, a HBR2 5.4 Gbps 2-lane configuration does not > support 4k@60Hz. But, we do not reject this mode. > > So, make use of the help

Re: [Intel-gfx] [PATCH v2 1/2] drm/dp/i915: Fix DP link rate math

2016-11-29 Thread Ville Syrjälä
On Mon, Nov 14, 2016 at 01:50:20PM -0800, Dhinakaran Pandiyan wrote: > We store DP link rates as link clock frequencies in kHz, just like all > other clock values. But, DP link rates in the DP Spec. are expressed in > Gbps/lane, which seems to have led to some confusion. > > E.g., for HBR2 > Max.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: use DRM_INFO for userspace issues

2016-11-29 Thread Patchwork
== Series Details == Series: drm/i915/perf: use DRM_INFO for userspace issues URL : https://patchwork.freedesktop.org/series/16112/ State : success == Summary == Series 16112v1 drm/i915/perf: use DRM_INFO for userspace issues https://patchwork.freedesktop.org/api/1.0/series/16112/revisions/1/m

Re: [Intel-gfx] [PATCH v2] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-11-29 Thread Imre Deak
On Tue, 2016-11-29 at 21:55 +0200, Ville Syrjälä wrote: > On Tue, Nov 29, 2016 at 09:40:29PM +0200, Imre Deak wrote: > > For LSPCON initialization during system resume we need AUX > > functionality, but we call the corresponding encoder reset hook with all > > interrupts disabled. Without interrupt

[Intel-gfx] [PATCH i-g-t] lib/igt_aux.h: Cast is confusing old gcc

2016-11-29 Thread Rodrigo Vivi
I noticed in some machines igt compilation was breaking after igt_dummyload was introduced. I don't know exactly why, but it seems this cast seems to let old gcc a bit confused. Without the cast everything works properly. Compilation Error log: CC igt_dummyload.lo In file included from ig

Re: [Intel-gfx] [PATCH v2] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 09:40:29PM +0200, Imre Deak wrote: > For LSPCON initialization during system resume we need AUX > functionality, but we call the corresponding encoder reset hook with all > interrupts disabled. Without interrupts we'll do a poll-wait for AUX > transfer completions, which add

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 9:45 AM, Sean Paul wrote: > On Mon, Nov 28, 2016 at 7:59 PM, Manasi Navare > wrote: >> On Wed, Nov 23, 2016 at 09:09:28AM +0100, Daniel Vetter wrote: >>> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote: >>> > On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare >>> >

[Intel-gfx] [PATCH v2] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-11-29 Thread Imre Deak
For LSPCON initialization during system resume we need AUX functionality, but we call the corresponding encoder reset hook with all interrupts disabled. Without interrupts we'll do a poll-wait for AUX transfer completions, which adds a significant delay if the transfers timeout/need to be retried f

Re: [Intel-gfx] [PATCH] drm/i915: Initialize dev_priv->atomic_cdclk_freq at init time

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 02:40:45PM +, Matthew Auld wrote: > On 29 November 2016 at 14:13, wrote: > > From: Ville Syrjälä > > > > Looks like we're only initializing dev_priv->atomic_cdclk_freq > > at resume and commit times, not at init time. Let's do that as > > well. > > > > We're now hitti

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 04:06:31PM +0200, Ville Syrjälä wrote: > On Tue, Nov 29, 2016 at 02:06:20PM +0100, Hans de Goede wrote: > > Hi, > > > > Thanks for the quick reply. > > > > On 29-11-16 13:48, Ville Syrjälä wrote: > > > On Tue, Nov 29, 2016 at 01:38:57PM +0100, Hans de Goede wrote: > > >> L

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: parse hf-vsdb

2016-11-29 Thread Patchwork
== Series Details == Series: drm: parse hf-vsdb URL : https://patchwork.freedesktop.org/series/16104/ State : failure == Summary == Series 16104v1 drm: parse hf-vsdb https://patchwork.freedesktop.org/api/1.0/series/16104/revisions/1/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Initialize dev_priv->atomic_cdclk_freq at init time

2016-11-29 Thread Patchwork
== Series Details == Series: drm/i915: Initialize dev_priv->atomic_cdclk_freq at init time URL : https://patchwork.freedesktop.org/series/16100/ State : success == Summary == Series 16100v1 drm/i915: Initialize dev_priv->atomic_cdclk_freq at init time https://patchwork.freedesktop.org/api/1.0/

Re: [Intel-gfx] [PATCH 1/3] drm/i915/debugfs: add dp mst info

2016-11-29 Thread Vivi, Rodrigo
On Tue, 2016-11-29 at 11:24 +0200, Jani Nikula wrote: > On Mon, 28 Nov 2016, libin.y...@intel.com wrote: > > From: Libin Yang > > > > Add the DP MST info dump in debugfs. > > > > Signed-off-by: Libin Yang > > Signed-off-by: Dhinakaran Pandiyan > > Reviewed-by: Lyude > > Signed-off-by: Rodrigo V

[Intel-gfx] [PATCH] drm/i915/perf: More documentation hooked to i915.rst

2016-11-29 Thread Robert Bragg
This adds a 'Perf' section to i915.rst with the following sub sections: - Overview - Comparison with Core Perf - i915 Driver Entry Points - i915 Perf Stream - i915 Perf Observation Architecture Stream - All i915 Perf Internals Signed-off-by: Robert Bragg Cc: Daniel Vetter --- Documentation/gpu/

Re: [Intel-gfx] [PATCH v2] drm/i915/glk: Set DCC delay range 2 in PLL enable sequence

2016-11-29 Thread Vivi, Rodrigo
Reviewed-by: Rodrigo Vivi On Tue, 2016-11-29 at 17:48 +0200, Ander Conselvan de Oliveira wrote: > Follow the PLL enable sequence updated in bspec, which requires the DCC > delay range 2 bit to be set. > > v2: Moved from DDI init sequence to PLL enable. > v3: Don't read value from GRP register. (

[Intel-gfx] [PATCH] drm/i915/perf: use DRM_INFO for userspace issues

2016-11-29 Thread Robert Bragg
Avoid using DRM_ERROR for conditions userspace can trigger with a bad config when opening a stream or from not reading data in a timely fashion (whereby the OA buffer fills up). These conditions are tested by i-g-t which treats error messages as failures if using the test runner. This wasn't an iss

Re: [Intel-gfx] [PATCH 2/2] drm/i915/audio: Extend audio sync rate support for DP MST

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 06:33:50PM +0200, Jani Nikula wrote: > On Tue, 15 Nov 2016, libin.y...@intel.com wrote: > > From: Libin Yang > > > > This patch extends the support of audio sample rate > > sync up to DP MST. > > > > Signed-off-by: Libin Yang > > --- > > drivers/gpu/drm/i915/intel_audio.c

Re: [Intel-gfx] [PATCH 1/2] drm/i915/audio: extend get_saved_enc() to support more scenarios

2016-11-29 Thread Jani Nikula
On Tue, 29 Nov 2016, "Yang, Libin" wrote: >>-Original Message- >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >>Sent: Friday, November 25, 2016 10:46 PM >>To: Yang, Libin ; intel-gfx@lists.freedesktop.org; >>ville.syrj...@linux.intel.com; Vetter, Daniel ; >>Pandiyan, Dhinakaran ;

Re: [Intel-gfx] [PATCH 2/2] drm/i915/audio: Extend audio sync rate support for DP MST

2016-11-29 Thread Jani Nikula
On Tue, 15 Nov 2016, libin.y...@intel.com wrote: > From: Libin Yang > > This patch extends the support of audio sample rate > sync up to DP MST. > > Signed-off-by: Libin Yang > --- > drivers/gpu/drm/i915/intel_audio.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dri

[Intel-gfx] [dim PATCH 1/2] dim: fetch Linus' tree again on update-branches

2016-11-29 Thread Jani Nikula
Fixes: 6552af2d32c4 ("dim: fix update-branches to fetch all available nightly repos") Cc: Archit Taneja Signed-off-by: Jani Nikula --- dim | 8 1 file changed, 8 insertions(+) diff --git a/dim b/dim index 3dd2d1dec796..562cbc64c93e 100755 --- a/dim +++ b/dim @@ -1255,6 +1255,14 @@ fun

Re: [Intel-gfx] [RFC PATCH v3 2/7] drm/i915: Add support for audio driver notifications

2016-11-29 Thread Anand, Jerome
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Tuesday, November 29, 2016 1:58 PM > To: Pierre-Louis Bossart > Cc: Ville Syrjälä ; Anand, Jerome > ; intel-gfx@lists.freedesktop.org; alsa- > de...@alsa-project.org; broo...@kernel.org; Ughreja, Rakesh A > > Subje

Re: [Intel-gfx] [PATCH] dim: Add status command

2016-11-29 Thread Jani Nikula
On Tue, 29 Nov 2016, Daniel Vetter wrote: > Useful with our branch proliferation to make sure nothing is stuck (we > now also have drm-misc-next/-next-fixes/-fixes). > > v2: Gracefully handle if some remotes arent' there. > > Acked-by: seanp...@chromium.org > Signed-off-by: Daniel Vetter Acked-b

[Intel-gfx] [dim PATCH 2/2] dim: fetch drm-tip before rebuilding

2016-11-29 Thread Jani Nikula
Without this, my non-git-worktree setup will fail to push (or it takes forever) if the local drm-tip is not up to date. Signed-off-by: Jani Nikula --- dim | 6 ++ 1 file changed, 6 insertions(+) diff --git a/dim b/dim index 562cbc64c93e..6371c95885a8 100755 --- a/dim +++ b/dim @@ -424,6 +42

[Intel-gfx] [dim PATCH 0/2] dim fetch fixes

2016-11-29 Thread Jani Nikula
Fix a couple of issues that probably only plague setups that don't use git-worktree. We should probably consider adding Linus' tree and drm-tip to drm_tip_repos; drm-tip is rebuilt based on drm_tip_config anyway. Anyway, this is the quick fix. BR, Jani. Jani Nikula (2): dim: fetch Linus' tree

Re: [Intel-gfx] [PATCH RFC v3] drm: Add a new connector atomic property for link status

2016-11-29 Thread Manasi Navare
On Tue, Nov 29, 2016 at 09:59:14AM +0100, Daniel Vetter wrote: > On Mon, Nov 28, 2016 at 05:07:52PM -0800, Manasi Navare wrote: > > On Thu, Nov 24, 2016 at 08:51:35AM +0100, Daniel Vetter wrote: > > > On Wed, Nov 23, 2016 at 11:28:21PM -0800, Manasi Navare wrote: > > > > This is RFC patch for addin

Re: [Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 10:34 AM, Chris Wilson wrote: > On Tue, Nov 29, 2016 at 10:28:03AM -0500, Sean Paul wrote: >> On Tue, Nov 29, 2016 at 7:02 AM, Chris Wilson >> wrote: >> > drm_fb_helper_probe_connector_modes() is always called before >> > drm_setup_crtcs(), so just move the call into drm_

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/6] HAX drm/i915: Enable guc submission

2016-11-29 Thread Chris Wilson
On Tue, Nov 29, 2016 at 03:45:23PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/6] HAX drm/i915: Enable guc submission > URL : https://patchwork.freedesktop.org/series/16096/ > State : success > > == Summary == > > Series 16096v1 Series without cover le

Re: [Intel-gfx] [PATCH 1/3] drm/i915/debugfs: add dp mst info

2016-11-29 Thread Jani Nikula
On Tue, 29 Nov 2016, Jani Nikula wrote: > On Mon, 28 Nov 2016, libin.y...@intel.com wrote: >> From: Libin Yang >> >> Add the DP MST info dump in debugfs. >> >> Signed-off-by: Libin Yang >> Signed-off-by: Dhinakaran Pandiyan >> Reviewed-by: Lyude >> Signed-off-by: Rodrigo Vivi > > I don't thin

[Intel-gfx] [PATCH v2] drm/i915/glk: Set DCC delay range 2 in PLL enable sequence

2016-11-29 Thread Ander Conselvan de Oliveira
Follow the PLL enable sequence updated in bspec, which requires the DCC delay range 2 bit to be set. v2: Moved from DDI init sequence to PLL enable. v3: Don't read value from GRP register. (Rodrido) Cc: Rodrigo Vivi Signed-off-by: Ander Conselvan De Oliveira --- drivers/gpu/drm/i915/i915_reg.

[Intel-gfx] [PATCH v3] drm/i915/glk: Reuse broxton code for geminilake

2016-11-29 Thread Ander Conselvan de Oliveira
Geminilake is mostly backwards compatible with broxton, so change most of the IS_BROXTON() checks to IS_GEN9_LP(). Differences between the platforms will be implemented in follow-up patches. v2: Don't reuse broxton's path in intel_update_max_cdclk(). Don't set plane count as in broxton. v3: R

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/6] HAX drm/i915: Enable guc submission

2016-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] HAX drm/i915: Enable guc submission URL : https://patchwork.freedesktop.org/series/16096/ State : success == Summary == Series 16096v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/16096/revisions/1/mbox/

Re: [Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Chris Wilson
On Tue, Nov 29, 2016 at 10:28:03AM -0500, Sean Paul wrote: > On Tue, Nov 29, 2016 at 7:02 AM, Chris Wilson > wrote: > > drm_fb_helper_probe_connector_modes() is always called before > > drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a > > small bit of code compaction. > > > > S

Re: [Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 7:02 AM, Chris Wilson wrote: > drm_fb_helper_probe_connector_modes() is always called before > drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a > small bit of code compaction. > > Signed-off-by: Chris Wilson > Reviewed-by: Daniel Vetter > --- > drivers

Re: [Intel-gfx] [PATCH v2 3/3] drm: Protect fb_helper list manipulation with a mutex

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 7:02 AM, Chris Wilson wrote: > Though we only walk the kernel_fb_helper_list inside a panic (or single > thread debugging), we still need to protect the list manipulation on > creating/removing a framebuffer device in order to prevent list > corruption. > > Signed-off-by: C

Re: [Intel-gfx] [PATCH v2 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

2016-11-29 Thread Sean Paul
On Tue, Nov 29, 2016 at 7:02 AM, Chris Wilson wrote: > The fb_helper->connector_count is modified when a new connector is > constructed following a hotplug event (e.g. DP-MST). This causes trouble > for drm_setup_crtcs() and friends that assume that fb_helper is > constant: > > [ 1250.872997] BUG:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

2016-11-29 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs URL : https://patchwork.freedesktop.org/series/16094/ State : success == Summary == Series 16094v1 Series without cover letter https://patchwork.freedesktop.org/api

Re: [Intel-gfx] [PATCH v6 8/8] drm/i915/gen9: WM memory bandwidth related workaround

2016-11-29 Thread Lankhorst, Maarten
Mahesh Kumar schreef op di 29-11-2016 om 19:17 [+0530]: > > On Tuesday 29 November 2016 03:16 PM, Lankhorst, Maarten wrote: > > > > Mahesh Kumar schreef op di 29-11-2016 om 11:12 [+0530]: > > > > > > Hi, > > > > > > > > > On Thursday 24 November 2016 06:21 PM, Lankhorst, Maarten wrote: > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Pass dev_priv to intel_setup_outputs() (rev3)

2016-11-29 Thread Patchwork
== Series Details == Series: drm/i915: Pass dev_priv to intel_setup_outputs() (rev3) URL : https://patchwork.freedesktop.org/series/15820/ State : success == Summary == Series 15820v3 drm/i915: Pass dev_priv to intel_setup_outputs() https://patchwork.freedesktop.org/api/1.0/series/15820/revisi

[Intel-gfx] [PATCH] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-11-29 Thread Imre Deak
For LSPCON initialization during system resume we need AUX functionality, but we call the corresponding encoder reset hook with all interrupts disabled. Without interrupts we'll do a poll-wait for AUX transfer completions, which adds a significant delay if the transfers timeout/need to be retried f

Re: [Intel-gfx] [PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-29 Thread Sean Paul
On Mon, Nov 28, 2016 at 7:59 PM, Manasi Navare wrote: > On Wed, Nov 23, 2016 at 09:09:28AM +0100, Daniel Vetter wrote: >> On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote: >> > On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare >> > wrote: >> > > This is RFC patch for adding a connector link

[Intel-gfx] [PATCH] drm: parse hf-vsdb

2016-11-29 Thread Shashank Sharma
HDMI 2.0 / CEA-861-F specs define a new CEA extension data block, called hdmi-forum vendor specific data block (HF-VSDB). This block contains information about sink's support for HDMI 2.0 compliant features. These features are: - Deep color YUV 420 support and BPC - 3D flags for - O

Re: [Intel-gfx] [PATCH] drm/i915: Initialize dev_priv->atomic_cdclk_freq at init time

2016-11-29 Thread Matthew Auld
On 29 November 2016 at 14:13, wrote: > From: Ville Syrjälä > > Looks like we're only initializing dev_priv->atomic_cdclk_freq > at resume and commit times, not at init time. Let's do that as > well. > > We're now hitting the 'WARN_ON(intel_state->cdclk == 0)' in > hsw_compute_linetime_wm() on ac

[Intel-gfx] [PATCH] dim: Add status command

2016-11-29 Thread Daniel Vetter
Useful with our branch proliferation to make sure nothing is stuck (we now also have drm-misc-next/-next-fixes/-fixes). v2: Gracefully handle if some remotes arent' there. Acked-by: seanp...@chromium.org Signed-off-by: Daniel Vetter --- dim | 22 ++ dim.rst | 5 + 2

[Intel-gfx] [PATCH] drm/i915: Initialize dev_priv->atomic_cdclk_freq at init time

2016-11-29 Thread ville . syrjala
From: Ville Syrjälä Looks like we're only initializing dev_priv->atomic_cdclk_freq at resume and commit times, not at init time. Let's do that as well. We're now hitting the 'WARN_ON(intel_state->cdclk == 0)' in hsw_compute_linetime_wm() on account of populating intel_state->cdclk from dev_priv-

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 02:06:20PM +0100, Hans de Goede wrote: > Hi, > > Thanks for the quick reply. > > On 29-11-16 13:48, Ville Syrjälä wrote: > > On Tue, Nov 29, 2016 at 01:38:57PM +0100, Hans de Goede wrote: > >> Looking at the ADF code from the Android kernel sources for a > >> cherrytrail t

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix CRC based atomic correctness test

2016-11-29 Thread Mika Kahola
Fixes issues on kms_plane_multiple i-g-t test found when running CI tests v1: - don't use tiling for cursor plane (Ville) - for y/yf tiling check that the platform is at least GEN9 (Ville) Cc: Ville Syrjala Cc: Maarten Lankhorst Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 7

Re: [Intel-gfx] [PATCH v6 8/8] drm/i915/gen9: WM memory bandwidth related workaround

2016-11-29 Thread Mahesh Kumar
On Tuesday 29 November 2016 03:16 PM, Lankhorst, Maarten wrote: Mahesh Kumar schreef op di 29-11-2016 om 11:12 [+0530]: Hi, On Thursday 24 November 2016 06:21 PM, Lankhorst, Maarten wrote: Mahesh Kumar schreef op do 24-11-2016 om 09:31 [+0530]: This patch implemnets Workariunds related to

[Intel-gfx] [drm-intel:drm-intel-next-queued 1/3] drivers/gpu/drm/i915/./i915_trace.h:409:24: error: 'struct i915_address_space' has no member named 'dev'

2016-11-29 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: c6385c947f4d1526d823a16ea25daa93d2897997 commit: 49d73912cbfcaa3eba109a44ee71200c12fa27ef [1/3] drm/i915: Convert vm->dev backpointer to vm->i915 config: i386-defconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-11-29 Thread Hans de Goede
Hi, Thanks for the quick reply. On 29-11-16 13:48, Ville Syrjälä wrote: On Tue, Nov 29, 2016 at 01:38:57PM +0100, Hans de Goede wrote: Looking at the ADF code from the Android kernel sources for a cherrytrail tablet I noticed that it is calling the MIPI_SEQ_ASSERT_RESET sequence from the panel

Re: [Intel-gfx] [PATCH] drm/i915: Fix tracepoint compilation

2016-11-29 Thread Chris Wilson
On Tue, Nov 29, 2016 at 12:42:05PM +, Chris Wilson wrote: > drivers/gpu/drm/i915/./i915_trace.h: In function > ‘trace_event_raw_event_i915_gem_evict’: > drivers/gpu/drm/i915/./i915_trace.h:409:24: error: ‘struct > i915_address_space’ has no member named ‘dev’ >__entry->dev = vm->dev->

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 01:38:58PM +0100, Hans de Goede wrote: > Set the CHV_GPIO_GPIOEN bit when updating GPIOs from chv_exec_gpio. > > Fixes: a0a6d4ffd2ad ("drm/i915/dsi: add support for gpio elements on CHV") > Cc: Jani Nikula > Cc: Ville Syrjälä > Signed-off-by: Hans de Goede > --- > drive

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-11-29 Thread Ville Syrjälä
On Tue, Nov 29, 2016 at 01:38:57PM +0100, Hans de Goede wrote: > Looking at the ADF code from the Android kernel sources for a > cherrytrail tablet I noticed that it is calling the > MIPI_SEQ_ASSERT_RESET sequence from the panel prepare hook. > > Until commit b1cb1bd29189 ("drm/i915/dsi: update re

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: VLV/CHV atomic wm prep work

2016-11-29 Thread Patchwork
== Series Details == Series: drm/i915: VLV/CHV atomic wm prep work URL : https://patchwork.freedesktop.org/series/16049/ State : success == Summary == Series 16049v1 drm/i915: VLV/CHV atomic wm prep work https://patchwork.freedesktop.org/api/1.0/series/16049/revisions/1/mbox/ fi-bdw-5557u

Re: [Intel-gfx] [PATCH] drm/i915: Fix tracepoint compilation

2016-11-29 Thread Michał Winiarski
On Tue, Nov 29, 2016 at 12:42:05PM +, Chris Wilson wrote: > drivers/gpu/drm/i915/./i915_trace.h: In function > ‘trace_event_raw_event_i915_gem_evict’: > drivers/gpu/drm/i915/./i915_trace.h:409:24: error: ‘struct > i915_address_space’ has no member named ‘dev’ >__entry->dev = vm->dev->

[Intel-gfx] [PATCH] drm/i915: Fix tracepoint compilation

2016-11-29 Thread Chris Wilson
drivers/gpu/drm/i915/./i915_trace.h: In function ‘trace_event_raw_event_i915_gem_evict’: drivers/gpu/drm/i915/./i915_trace.h:409:24: error: ‘struct i915_address_space’ has no member named ‘dev’ __entry->dev = vm->dev->primary->index; A couple of macros missed in the s/vm->dev/vm->i915/ co

[Intel-gfx] [PATCH 1/2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-11-29 Thread Hans de Goede
Looking at the ADF code from the Android kernel sources for a cherrytrail tablet I noticed that it is calling the MIPI_SEQ_ASSERT_RESET sequence from the panel prepare hook. Until commit b1cb1bd29189 ("drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks") the mainline i

[Intel-gfx] [PATCH 2/2] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting

2016-11-29 Thread Hans de Goede
Set the CHV_GPIO_GPIOEN bit when updating GPIOs from chv_exec_gpio. Fixes: a0a6d4ffd2ad ("drm/i915/dsi: add support for gpio elements on CHV") Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: Trim i915_guc_info() stack usage

2016-11-29 Thread Tvrtko Ursulin
On 29/11/2016 12:10, Chris Wilson wrote: i915_guc_info() (part of debugfs output) tries to avoid holding struct_mutex for a long period by copying onto the stack. This causes a warning that the stack frame is massive, so stop doing that. We can even forgo holding the struct_mutex here as that do

[Intel-gfx] [PATCH v2 4/6] drm/i915/guc: Initialise doorbell cookie to matching value

2016-11-29 Thread Chris Wilson
Set the initial value of the doorbell cookie from the client. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/

[Intel-gfx] [PATCH v2 2/6] drm/i915: Trim i915_guc_info() stack usage

2016-11-29 Thread Chris Wilson
i915_guc_info() (part of debugfs output) tries to avoid holding struct_mutex for a long period by copying onto the stack. This causes a warning that the stack frame is massive, so stop doing that. We can even forgo holding the struct_mutex here as that doesn't serialise the values being read (and t

[Intel-gfx] [PATCH v2 1/6] HAX drm/i915: Enable guc submission

2016-11-29 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 0e280fbd52f1..ef1e9921a2af 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_p

[Intel-gfx] [PATCH v2 6/6] drm/i915/guc: Split hw submission for replay after GPU reset

2016-11-29 Thread Chris Wilson
Something I missed before sending off the partial series was that the non-scheduler guc reset path was broken (in the full series, this is pushed to the execlists reset handler). The issue is that after a reset, we have to refill the GuC workqueues, which we do by resubmitting the requests. However

[Intel-gfx] [PATCH v2 3/6] drm/i915/guc: Rename client->cookie to match use

2016-11-29 Thread Chris Wilson
The client->cookie is a shadow of the doorbell->cookie value, so rename it to indicate its association with the doorbell, like the doorbell id and offset. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c| 2 +- drivers/gpu/drm/i915/i915_guc

[Intel-gfx] [PATCH v2 5/6] drm/i915/guc: Keep the execbuf client allocated across reset

2016-11-29 Thread Chris Wilson
In order to avoid some complexity in trying to reconstruct the workqueues across reset, remember them instead. The issue comes when we have to handle a reset between request allocation and submission, the request has reserved space in the wq, but is not in any list so we fail to restore the reserve

[Intel-gfx] [PATCH v2 2/3] drm: Pull together probe + setup for drm_fb_helper

2016-11-29 Thread Chris Wilson
drm_fb_helper_probe_connector_modes() is always called before drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a small bit of code compaction. Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 37 +++--

[Intel-gfx] [PATCH v2 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

2016-11-29 Thread Chris Wilson
The fb_helper->connector_count is modified when a new connector is constructed following a hotplug event (e.g. DP-MST). This causes trouble for drm_setup_crtcs() and friends that assume that fb_helper is constant: [ 1250.872997] BUG: KASAN: slab-out-of-bounds in drm_setup_crtcs+0x320/0xf80 at add

[Intel-gfx] [PATCH v2 3/3] drm: Protect fb_helper list manipulation with a mutex

2016-11-29 Thread Chris Wilson
Though we only walk the kernel_fb_helper_list inside a panic (or single thread debugging), we still need to protect the list manipulation on creating/removing a framebuffer device in order to prevent list corruption. Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm

[Intel-gfx] [PATCH] drm/i915: Fix intel_psr_init() kerneldoc

2016-11-29 Thread Ander Conselvan de Oliveira
In commit c39055b072f8 ("drm/i915: Pass dev_priv to intel_setup_outputs()"), I forgot to update the kerneldoc for intel_psr_init() init, leading to warnings when building the documentation: drivers/gpu/drm/i915/intel_psr.c:822: warning: No description found for parameter 'dev_priv' driver

Re: [Intel-gfx] [PATCH] drm/i915: Convert vm->dev backpointer to vm->i915

2016-11-29 Thread Chris Wilson
On Tue, Nov 29, 2016 at 12:54:12PM +0200, Joonas Lahtinen wrote: > On ti, 2016-11-29 at 09:50 +, Chris Wilson wrote: > > 99% of the time we access i915_address_space->dev we want the i915 > > device and not the drm device, so let's store the drm_i915_private > > backpointer instead. The only re

Re: [Intel-gfx] [PULL] drm-misc-next

2016-11-29 Thread Daniel Vetter
Hi Stephen, drm-misc has slightly moved around, new branches for you to pull in: git://anongit.freedesktop.org/drm/drm-misc for-linux-next-fixes git://anongit.freedesktop.org/drm/drm-misc for-linux-next It's the same aliasing branch concept as for drm-intel, to avoid trouble for you around the m

  1   2   >