Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-12-01 Thread Dave Young
On 11/30/16 at 03:25pm, Ville Syrjälä wrote: > On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote: > > On 11/24/16 at 10:53am, Jani Nikula wrote: > > > On Thu, 24 Nov 2016, Dave Young wrote: > > > > I see a lot of below warning: > > > > > > No, we must not hide this under the carpet. Ther

Re: [Intel-gfx] [PATCH 6/6] drm/i915: use platform enum instead of duplicating PCI ID if possible

2016-12-01 Thread Joonas Lahtinen
On ke, 2016-11-30 at 17:43 +0200, Jani Nikula wrote: > Duplicating the PCI ID for IS_FOO checks is redundant for a bunch of > platforms. Simplify. > > Signed-off-by: Jani Nikula This should do pure good when optimizing the checks. Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtin

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-12-01 Thread Dave Young
On 12/01/16 at 04:00pm, Dave Young wrote: > On 11/30/16 at 03:25pm, Ville Syrjälä wrote: > > On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote: > > > On 11/24/16 at 10:53am, Jani Nikula wrote: > > > > On Thu, 24 Nov 2016, Dave Young wrote: > > > > > I see a lot of below warning: > > > >

Re: [Intel-gfx] [PATCH 4/6] drm/i915: add some more "i" in platform names for consistency

2016-12-01 Thread Joonas Lahtinen
On ke, 2016-11-30 at 17:43 +0200, Jani Nikula wrote: > Consistency FTW. > > Signed-off-by: Jani Nikula Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing list Intel-g

[Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread swati . dhingra
From: Swati Dhingra The patch introduces a new pseudo filesystem type, named 'drmfs' which is intended to house the files for the data generated by drm subsystem that cannot be accommodated by any of the existing filesystems. The filesystem is modelled on the lines of existing pseudo-filesystems

[Intel-gfx] [RFC 0/3] Introduce drmfs pseudo filesystem for drm subsystem

2016-12-01 Thread swati . dhingra
From: Swati Dhingra Currently, for the purpose of providing output debug/loggging/crc and various other kinds of data from DRM layer to userspace, we don't have a standard filesystem, which would suffice for all the usecases. The filesystems used currently such as debugfs/sysfs have their own con

[Intel-gfx] [RFC 2/3] drm: Register drmfs filesystem from drm init

2016-12-01 Thread swati . dhingra
From: Swati Dhingra During drm module initialization, drm_core_init initializes the drmfs filesystem and register this with kernel. A driver specific directory is created inside drmfs root, and dentry of this directory is saved for subsequent use by the driver (e.g. i915). The driver can then cre

[Intel-gfx] [RFC 3/3] drm/i915: Creating guc log file in drmfs instead of debugfs

2016-12-01 Thread swati . dhingra
From: Swati Dhingra In the current scenario, the relay API fit well only with debugfs, due to availability of parent dentry. Any other existing filesystem was not feasible for holding guc logs, due to incompatibility with relay. But this makes the guc_log file unavailable on the production kern

Re: [Intel-gfx] [PATCH 3/6] drm/i915: rename BROADWATER and CRESTLINE to I965G and I965GM, respectively

2016-12-01 Thread Joonas Lahtinen
On ke, 2016-11-30 at 17:43 +0200, Jani Nikula wrote: > Add more consistency to our naming. Pineview remains the outlier. Keep > using code names for gen5+. > > Signed-off-by: Jani Nikula Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corpor

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > +int drmfs_init(void) > +{ > + int retval; > + > + retval = sysfs_create_mount_point(kernel_kobj, "drm"); > + if (retval) > + return -EINVAL; > + > + retval = register_filesystem(&drm_fs_type); >

Re: [Intel-gfx] drm-intel split-up and new dim script

2016-12-01 Thread Daniel Vetter
Ok, transition is over, old drm-intel-nightly and rerere-cache is removed. I hope that's enough of a hint to everyone else who missed the memo ;-) -Daniel On Thu, Nov 24, 2016 at 11:48:47AM +0100, Daniel Vetter wrote: > Hi all, > > So it's finally done, drm-misc is split out into a separate repo:

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > diff --git a/fs/Kconfig b/fs/Kconfig > index 4bd03a2..7d0ac20 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -200,6 +200,15 @@ config HUGETLBFS > config HUGETLB_PAGE > def_bool HUGETLBFS > > +config DRMFS > +

Re: [Intel-gfx] [RFC 2/3] drm: Register drmfs filesystem from drm init

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:32:32PM +0530, swati.dhin...@intel.com wrote: > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index 84fcfcb..ead360bd 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -688,6 +688,14 @@ int drm_dev_register(struct drm_d

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread sourab gupta
On Thu, 2016-12-01 at 00:07 -0800, Chris Wilson wrote: > On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > > +int drmfs_init(void) > > +{ > > + int retval; > > + > > + retval = sysfs_create_mount_point(kernel_kobj, "drm"); > > + if (retval) > > + return -EIN

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread sourab gupta
On Thu, 2016-12-01 at 00:11 -0800, Chris Wilson wrote: > On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > > diff --git a/fs/Kconfig b/fs/Kconfig > > index 4bd03a2..7d0ac20 100644 > > --- a/fs/Kconfig > > +++ b/fs/Kconfig > > @@ -200,6 +200,15 @@ config HUGETLBFS > > confi

Re: [Intel-gfx] [RFC 2/3] drm: Register drmfs filesystem from drm init

2016-12-01 Thread sourab gupta
On Thu, 2016-12-01 at 00:15 -0800, Chris Wilson wrote: > On Thu, Dec 01, 2016 at 12:32:32PM +0530, swati.dhin...@intel.com wrote: > > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > > index 84fcfcb..ead360bd 100644 > > --- a/drivers/gpu/drm/drm_drv.c > > +++ b/drivers/gpu/drm/d

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce drmfs pseudo filesystem for drm subsystem (rev2)

2016-12-01 Thread Patchwork
== Series Details == Series: Introduce drmfs pseudo filesystem for drm subsystem (rev2) URL : https://patchwork.freedesktop.org/series/16203/ State : success == Summary == Series 16203v2 Introduce drmfs pseudo filesystem for drm subsystem https://patchwork.freedesktop.org/api/1.0/series/16203/

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 02:01:59PM +0530, sourab gupta wrote: > On Thu, 2016-12-01 at 00:07 -0800, Chris Wilson wrote: > > On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > > > +int drmfs_init(void) > > > +{ > > > + int retval; > > > + > > > + retval = sysfs_create_mount_po

Re: [Intel-gfx] [RFC 0/3] Introduce drmfs pseudo filesystem for drm subsystem

2016-12-01 Thread Jani Nikula
On Thu, 01 Dec 2016, swati.dhin...@intel.com wrote: > Currently, for the purpose of providing output debug/loggging/crc and various > other kinds of data from DRM layer to userspace, we don't have a standard > filesystem, which would suffice for all the usecases. The filesystems used > currently su

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 02:07:19PM +0530, sourab gupta wrote: > On Thu, 2016-12-01 at 00:11 -0800, Chris Wilson wrote: > > On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > > > diff --git a/fs/Kconfig b/fs/Kconfig > > > index 4bd03a2..7d0ac20 100644 > > > --- a/fs/Kconfig >

Re: [Intel-gfx] [RFC 0/3] Introduce drmfs pseudo filesystem for drm subsystem

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 10:48:31AM +0200, Jani Nikula wrote: > On Thu, 01 Dec 2016, swati.dhin...@intel.com wrote: > > Currently, for the purpose of providing output debug/loggging/crc and > > various > > other kinds of data from DRM layer to userspace, we don't have a standard > > filesystem, whi

[Intel-gfx] [PATCH v3] drm/i915: Create a common GEN9_LP_FEATURE.

2016-12-01 Thread Ander Conselvan de Oliveira
From: Rodrigo Vivi The following LP platform inherits a lot of this platform So let's simplify here to re-use this later. v2: Keep ddb_size out of the new macro. v3: Rebase (has_decoupled_mmio). (Imre) Signed-off-by: Rodrigo Vivi Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Imre D

[Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Chris Wilson
Move the GuC invalidation of its ggtt TLB to where we perform the ggtt modification rather than proliferate it into all the callers of the insert (which may or may not in fact have to do the insertion). v2: Just do the guc invalidate unconditionally, (afaict) it has no impact without the guc loade

[Intel-gfx] [PATCH v2 1/2] HAX drm/i915: Enable guc submission

2016-12-01 Thread Chris Wilson
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 0e280fbd52f1..ef1e9921a2af 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_p

[Intel-gfx] [PULL] drm-intel-fixes

2016-12-01 Thread Jani Nikula
Hi Dave, presumably final fixes for 4.9. BR, Jani. The following changes since commit e5517c2a5a49ed5e99047008629f1cd60246ea0e: Linux 4.9-rc7 (2016-11-27 13:08:04 -0800) are available in the git repository at: git://anongit.freedesktop.org/git/drm-intel tags/drm-intel-fixes-2016-12-01 fo

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 09:46, Chris Wilson wrote: Move the GuC invalidation of its ggtt TLB to where we perform the ggtt modification rather than proliferate it into all the callers of the insert (which may or may not in fact have to do the insertion). v2: Just do the guc invalidate unconditionally, (af

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: > > On 01/12/2016 09:46, Chris Wilson wrote: > >Move the GuC invalidation of its ggtt TLB to where we perform the ggtt > >modification rather than proliferate it into all the callers of the > >insert (which may or may not in fact have

Re: [Intel-gfx] [PATCH v3 11/14] HACK drm/i915/scheduler: emulate a scheduler for guc

2016-12-01 Thread Tvrtko Ursulin
On 14/11/2016 08:57, Chris Wilson wrote: This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority requests to gazump their way to the head of the queue, however it nerfs the GuC by converting it back into a si

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 10:26, Chris Wilson wrote: On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: On 01/12/2016 09:46, Chris Wilson wrote: Move the GuC invalidation of its ggtt TLB to where we perform the ggtt modification rather than proliferate it into all the callers of the insert (

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 10:49:31AM +, Tvrtko Ursulin wrote: > > On 01/12/2016 10:26, Chris Wilson wrote: > >On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: > >> > >>On 01/12/2016 09:46, Chris Wilson wrote: > >>>Move the GuC invalidation of its ggtt TLB to where we perform the g

[Intel-gfx] [i-g-t PATCH 1/2] igt_dummyload: clear signal handler on the desructor

2016-12-01 Thread Abdiel Janulgue
Fixes an issue when calling igt_spin_batch_set_timeout and then tearing down the spinner right away before it has the chance to timeout, causes the associated signal handler to linger. Make sure to remove the handler on the destructor as well. Signed-off-by: Abdiel Janulgue --- lib/igt_dummyload

[Intel-gfx] [i-g-t PATCH 2/2] igt/kms_flip: Fix set_dpms called with an idle bo

2016-12-01 Thread Abdiel Janulgue
Signed-off-by: Abdiel Janulgue --- tests/kms_flip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 289335a..f744b3d 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -757,9 +757,9 @@ static unsigned int run_test_step(struct

[Intel-gfx] CentOS and Skylake

2016-12-01 Thread Chris Pemberton
Hello, I'm really enjoying the Intel Skylake graphics in Fedora 24/25 and Archlinux; thanks for all of the great work. I remember the old XIG AcceleratedX drivers from years ago... I would rather get back to using CentOS on my Skylake development laptop; Fedora 25 has failed on my twice in two w

[Intel-gfx] [PATCH i-g-t 2/2] igt/kms_flip.c: Fix timings check

2016-12-01 Thread Dorota Czaplejewicz
Adjust the description and constants in the timing check to match each other. Relax the timing constraint to prevent false positives in vblank interval checking. --- tests/kms_flip.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c i

[Intel-gfx] [PATCH i-g-t 1/2] igt/kms_setmode.c: Tweak timings check constants

2016-12-01 Thread Dorota Czaplejewicz
Add explanations of the checks and note the way the constants were derived. Tweak the constants to reflect their purpose better. --- tests/kms_setmode.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/tests/kms_setmode.c b/tests/kms_setmode

Re: [Intel-gfx] linux-next: problems fetching the drm-intel, etc trees

2016-12-01 Thread Daniel Stone
Hi guys, On Nov 30 2016, at 10:49 pm, Rob Clark wrote: > yeah, {cgit,anongit}.fd.o have been having problems all day.. (the ssh git urls for folks who have push access work fine).. although it has worked for me a couple times today, given enough time. > > (not sure if we have git

Re: [Intel-gfx] [PATCH v6 2/8] drm/i915/bxt: IPC WA for Broxton

2016-12-01 Thread Lankhorst, Maarten
Hey, Mahesh Kumar schreef op ma 28-11-2016 om 18:37 [+0530]: > Hi, > > Will keep WA number in commit message/WA location. > thanks, Sounds good, with that fixed patches 1-5 and 7 look good to me. I think patch 6 will no longer be required since the workaround status will also be kept inside inte

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Invalidate the guc ggtt TLB upon insertion

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 10:57, Chris Wilson wrote: On Thu, Dec 01, 2016 at 10:49:31AM +, Tvrtko Ursulin wrote: On 01/12/2016 10:26, Chris Wilson wrote: On Thu, Dec 01, 2016 at 10:06:25AM +, Tvrtko Ursulin wrote: On 01/12/2016 09:46, Chris Wilson wrote: Move the GuC invalidation of its ggtt T

[Intel-gfx] ✓ Fi.CI.BAT: success for Geminilake enabling (rev8)

2016-12-01 Thread Patchwork
== Series Details == Series: Geminilake enabling (rev8) URL : https://patchwork.freedesktop.org/series/15118/ State : success == Summary == Series 15118v8 Geminilake enabling https://patchwork.freedesktop.org/api/1.0/series/15118/revisions/8/mbox/ fi-bdw-5557u total:245 pass:230 dwarn:

Re: [Intel-gfx] CentOS and Skylake

2016-12-01 Thread Jani Nikula
On Thu, 01 Dec 2016, Chris Pemberton wrote: > Hello, > > I'm really enjoying the Intel Skylake graphics in Fedora 24/25 and > Archlinux; thanks for all of the great work. I remember the old XIG > AcceleratedX drivers from years ago... > > I would rather get back to using CentOS on my Skylake deve

Re: [Intel-gfx] [PATCH v3 11/14] HACK drm/i915/scheduler: emulate a scheduler for guc

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 10:45:51AM +, Tvrtko Ursulin wrote: > > On 14/11/2016 08:57, Chris Wilson wrote: > >This emulates execlists on top of the GuC in order to defer submission of > >requests to the hardware. This deferral allows time for high priority > >requests to gazump their way to the

Re: [Intel-gfx] [i-g-t PATCH 1/2] igt_dummyload: clear signal handler on the desructor

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:58:45PM +0200, Abdiel Janulgue wrote: > Fixes an issue when calling igt_spin_batch_set_timeout and then > tearing down the spinner right away before it has the chance > to timeout, causes the associated signal handler to linger. Make > sure to remove the handler on the de

Re: [Intel-gfx] [i-g-t PATCH 2/2] igt/kms_flip: Fix set_dpms called with an idle bo

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:58:46PM +0200, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > tests/kms_flip.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c > index 289335a..f744b3d 100644 > --- a/tests/kms_flip.c > +

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Geminilake enabling (rev8)

2016-12-01 Thread Ander Conselvan De Oliveira
On Thu, 2016-12-01 at 11:15 +, Patchwork wrote: > == Series Details == > > Series: Geminilake enabling (rev8) > URL   : https://patchwork.freedesktop.org/series/15118/ > State : success I pushed up to patch 4. Thanks for the reviews so far. Ander > > == Summary == > > Series 15118v8 Gemi

Re: [Intel-gfx] [PATCH 08/15] drm/i915: Pass around dev_priv in vlv wm functions

2016-12-01 Thread Maarten Lankhorst
Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > Pasing dev_priv instead of dev is the future. Let's make the vlv/chv wm > functions respect that idea. ^Passing With that fixed, patch 1-10 Reviewed-by: Maarten Lankhorst When I was looking at converting VLV/

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] HAX drm/i915: Enable guc submission

2016-12-01 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] HAX drm/i915: Enable guc submission URL : https://patchwork.freedesktop.org/series/16210/ State : success == Summary == Series 16210v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/16210/revisions/1/mbox/

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Protect DSPARB registers with a spinlock

2016-12-01 Thread Maarten Lankhorst
Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > Each DSPARB register can house bits for two separate pipes, hence > we must protect the registers during reprogramming so that parallel > FIFO reconfigurations happening simultaneosly on multiple pipes won't > co

Re: [Intel-gfx] [PATCH] drm/i915/perf: More documentation hooked to i915.rst

2016-12-01 Thread Jani Nikula
On Wed, 30 Nov 2016, Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 05:00:55PM +, Robert Bragg wrote: >> +.. kernel-doc:: drivers/gpu/drm/i915/i915_perf.c >> + :functions: i915_perf_init >> +.. kernel-doc:: drivers/gpu/drm/i915/i915_perf.c >> + :functions: i915_perf_fini >> +.. kernel-doc:

[Intel-gfx] [PATCH i-g-t 3/4 v7] tests/drv_module_reload: Convert sh script to C version.

2016-12-01 Thread Marius Vlad
v5: - reword gem_info to gem_sanitychecks (Chris Wilson) - remove subgroups/subtests for gem_exec_store and gem_sanitycheck (Chris Wilson) v4: - adjust test to make use of lib/igt_kmod - replaced SW_FINISH with SET_CACHEING (Chris Wilson) v3: - fix passing boolean value as flags to igt_kmod_unloa

[Intel-gfx] [PATCH i-g-t 0/4 v7] Convert sh scripts to C variants.

2016-12-01 Thread Marius Vlad
Latest changes include addressing comments from previous version and include some notes about driver loading/unloading when using in combination to drm_open_driver(). This series adds some library support to help converting sh scripts to C version. Based on that I've converted drv_module_reload_ba

[Intel-gfx] [PATCH i-g-t 1/4 v7] lib/igt_kmod: New library to support driver loading/unloading and additional helpers.

2016-12-01 Thread Marius Vlad
lib/igt_aux: Added igt_pkill and igt_lsof helper. lib/igt_kmod: Added load/unload kmod helpers. v7: - document the case where leaving stray fd from drm_open_driver() might fail reloading the driver. - list also current opened files from /dev/dri in case we could not unload the driver. - convert ig

[Intel-gfx] [PATCH i-g-t 2/4 v7] lib/igt_gvt: Make use of libkmod helpers and fix reading gvt parameter.

2016-12-01 Thread Marius Vlad
v2: - use igt_sysfs_get_boolean() to get gvt status (Chris Wilson) - do not hard-fail when i915 module could not be loaded/unloaded (Chris Wilson) Signed-off-by: Marius Vlad --- lib/igt_gvt.c | 37 ++--- tests/gvt_basic.c | 2 +- 2 files changed, 19 insertion

[Intel-gfx] [PATCH i-g-t 4/4 v7] tests/kms_sysfs_edid_timing: Convert sh to C version.

2016-12-01 Thread Marius Vlad
The debug output for a HSW machine with two connectors (VGA and HDMI): DEBUG: card0-VGA-1: mean.max 12896229,00ns, 12896,23us, 12,90ms, mean.avg 12785055,80ns, 12785,06us, 12,79ms WARNING: card0-VGA-1: probe time exceed 10ms, max=12,90ms, avg=12,79ms DEBUG: card0-HDMI-A-1: mean.max 781433,00ns, 7

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

2016-12-01 Thread Arkadiusz Hiler
On Wed, Nov 30, 2016 at 03:31:28PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > HuC firmware css header has almost exactly same definition as GuC > firmware except for the sw_version. Also, add a new member fw_type > into intel_uc_fw to indicate what kind of fw it is. So, the loader >

Re: [Intel-gfx] [PATCH v3 11/14] HACK drm/i915/scheduler: emulate a scheduler for guc

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 11:18, Chris Wilson wrote: On Thu, Dec 01, 2016 at 10:45:51AM +, Tvrtko Ursulin wrote: On 14/11/2016 08:57, Chris Wilson wrote: This emulates execlists on top of the GuC in order to defer submission of requests to the hardware. This deferral allows time for high priority req

[Intel-gfx] [PATCH v3] drm/i915: replace platform flags with a platform enum

2016-12-01 Thread Jani Nikula
The platform flags in device info are (mostly) mutually exclusive. Replace the flags with an enum. Add the platform enum also for platforms that previously didn't have a flag, and give them codename logging in dmesg. Pineview remains an exception, the platform being G33 for that. v2: Sort enum by

Re: [Intel-gfx] [PATCH v3 11/14] HACK drm/i915/scheduler: emulate a scheduler for guc

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:45:18PM +, Tvrtko Ursulin wrote: > > On 01/12/2016 11:18, Chris Wilson wrote: > >On Thu, Dec 01, 2016 at 10:45:51AM +, Tvrtko Ursulin wrote: > >> > >>On 14/11/2016 08:57, Chris Wilson wrote: > >>>+static bool i915_guc_dequeue(struct intel_engine_cs *engine) > >>>

Re: [Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

2016-12-01 Thread Arkadiusz Hiler
On Wed, Nov 30, 2016 at 03:31:33PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > The HuC authentication is done by host2guc call. The HuC RSA keys > are sent to GuC for authentication. > > v2: rebased on top of drm-intel-nightly. > changed name format and upped version 1.7. > v3: r

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

2016-12-01 Thread Arkadiusz Hiler
On Wed, Nov 30, 2016 at 03:31:34PM -0800, Anusha Srivatsa wrote: > From: Peter Antoine > > This patch will allow for getparams to return the status of the HuC. > As the HuC has to be validated by the GuC this patch uses the validated > status to show when the HuC is loaded and ready for use. You

Re: [Intel-gfx] [PATCH 4/8] drm/i915/huc: Add BXT HuC Loading Support

2016-12-01 Thread Tvrtko Ursulin
On 30/11/2016 23:31, Anusha Srivatsa wrote: This patch adds the HuC Loading for the BXT by using the updated file construction. Version 1.7 of the HuC firmware. v2: rebased. v3: rebased on top of drm-tip Cc: Jeff Mcgee Signed-off-by: Anusha Srivatsa Reviewed-by: Jeff McGee --- drivers/gpu

Re: [Intel-gfx] [PATCH alternative #1] drm/i915/bxt: add bxt dsi gpio element support

2016-12-01 Thread Mika Kahola
On Tue, 2016-11-15 at 14:08 +0200, Jani Nikula wrote: > Request the GPIO by index through the consumer API. For now, use a > quick > hack to store the already requested ones, simply because I have no > idea > whether this actually works or not, and I have no way to test it. > > Cc: Mika Kahola >

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Protect DSPARB registers with a spinlock

2016-12-01 Thread Ville Syrjälä
On Thu, Dec 01, 2016 at 12:56:16PM +0100, Maarten Lankhorst wrote: > Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > Each DSPARB register can house bits for two separate pipes, hence > > we must protect the registers during reprogramming so that parallel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: introduce platform enum (rev2)

2016-12-01 Thread Patchwork
== Series Details == Series: drm/i915: introduce platform enum (rev2) URL : https://patchwork.freedesktop.org/series/16170/ State : success == Summary == Series 16170v2 drm/i915: introduce platform enum https://patchwork.freedesktop.org/api/1.0/series/16170/revisions/2/mbox/ Test gem_exec_flu

Re: [Intel-gfx] [PATCH v2] drm/i915/lspcon: Enable AUX interrupts for resume time initialization

2016-12-01 Thread David Weinehall
On Tue, Nov 29, 2016 at 09:40:29PM +0200, Imre Deak wrote: > For LSPCON initialization during system resume we need AUX > functionality, but we call the corresponding encoder reset hook with all > interrupts disabled. Without interrupts we'll do a poll-wait for AUX > transfer completions, which add

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

2016-12-01 Thread Tvrtko Ursulin
Hi, On 30/11/2016 23:31, Anusha Srivatsa wrote: The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them. v2: rebased on-top of drm-intel-nightly. r

[Intel-gfx] [PATCH i-g-t 2/3] tests/gem_reset_stats: test no progress detection

2016-12-01 Thread Mika Kuoppala
If seqno is not incrementing but head is moving, we declare hang but much slower. Add test to check that this mechanism is working properly. Signed-off-by: Mika Kuoppala --- tests/gem_reset_stats.c | 75 + 1 file changed, 75 insertions(+) diff --g

[Intel-gfx] [PATCH i-g-t 3/3] tests/gem_reset_stats: Add test to check client bans

2016-12-01 Thread Mika Kuoppala
Client will get banned from creating new context if it has managed to get > 3 context banned. Signed-off-by: Mika Kuoppala --- tests/gem_reset_stats.c | 47 ++- 1 file changed, 42 insertions(+), 5 deletions(-) diff --git a/tests/gem_reset_stats.c b/te

[Intel-gfx] [PATCH i-g-t 1/3] tests/gem_reset_stats: Change pending/active assertions

2016-12-01 Thread Mika Kuoppala
Now that we replay the non guilty contexts and always replay the default ctx, even when guilty, the assumptions of how many active and pending batches there was in the time of reset has changed. Driver doesn't increment pending counts for contexts that it considered unaffected by reset. Because it

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: Enable AUX interrupts for resume time initialization (rev2)

2016-12-01 Thread Imre Deak
On ti, 2016-11-29 at 21:53 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/lspcon: Enable AUX interrupts for resume time initialization > (rev2) > URL   : https://patchwork.freedesktop.org/series/16106/ > State : success > > == Summary == > > Series 16106v2 drm/i915/lspcon:

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/gem_reset_stats: Change pending/active assertions

2016-12-01 Thread Chris Wilson
How about a patch 0 to enable hang testing contexts on all rings now? Then exploration of how one ring affects another... You will want to use busy batches to load the engines without hanging, that will be tricky... On Thu, Dec 01, 2016 at 03:31:43PM +0200, Mika Kuoppala wrote: > Now that we repl

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/gem_reset_stats: test no progress detection

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 03:31:44PM +0200, Mika Kuoppala wrote: > If seqno is not incrementing but head is moving, > we declare hang but much slower. Add test to check > that this mechanism is working properly. > > Signed-off-by: Mika Kuoppala > --- > tests/gem_reset_stats.c | 75 > +

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_reset_stats: Add test to check client bans

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 03:31:45PM +0200, Mika Kuoppala wrote: > Client will get banned from creating new context > if it has managed to get > 3 context banned. I'm not thrilled about baking that magic number into an ABI requirement. Just make it N bans, test timing out after say 120s of happines

[Intel-gfx] [PATCH 02/10] drm/i915: Make GEM object create and create from data take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Makes all GEM object constructors consistent. v2: Fix compilation in GVT code. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson (v1) Reviewed-by: Joonas Lahtinen (v1) --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 5 ++--- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 01/10] drm/i915: Make GEM object alloc/free and stolen created take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Where it is more appropriate and also to be consistent with the direction of the driver. v2: Leave out object alloc/free inlining. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v2 00/10] GEM object create and driver init dev_priv cleanups

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Autumn of churn continues. :) This series tidies GEM object construction to take dev_priv instead of dev in all cases and also does a bit of random tidy in the driver load/init code. Basically functions which only need dev_priv are changed to take dev_priv instead of dev. T

[Intel-gfx] [PATCH 07/10] drm/i915: Make gmbus setup take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Simplify the code by passing the right argument in. v2: Commit message. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 4 ++-

[Intel-gfx] [PATCH 04/10] drm/i915: More GEM init dev_priv cleanup

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Simplifies the code to pass the right parameter in. v2: Commit message. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 8 drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 03/10] drm/i915: Make various init functions take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Like GEM init, GUC init, MOCS init and context creation. Enables them to lose dev_priv locals. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c| 31 ++-- drivers/

[Intel-gfx] [PATCH 08/10] drm/i915: Make i915_destroy_error_state take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since it does not need dev at all. Also change the stored pointer in struct i915_error_state_file_priv to i915. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_debugfs.c | 8 drivers/gpu/drm/i

[Intel-gfx] [PATCH 06/10] drm/i915: Unexport VGA switcheroo functions

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin They are only used in i915_drv.c so a forward declaration is enough. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 5 - drivers/gpu/drm/i915/i915_drv.h | 3 --- 2 files changed, 4 insertions

[Intel-gfx] [PATCH 10/10] drm/i915: Make intel_pm_setup take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Function actually wants dev_priv so give it to it. v2: Commit message. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gp

[Intel-gfx] [PATCH 05/10] drm/i915: dev_priv cleanup in bridge/bar/mmio init code

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin dev_priv is more appropriate for these so converting saves some lines of source. v2: Commit message and keep the pdev local variable. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson (v1) Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i91

[Intel-gfx] [PATCH 09/10] drm/i915: Make i915_save/restore_state and intel_i2c_reset take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin dev_priv is more appropriate since it is used much more in these. v2: Commit message and keep the local pdev variable. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-

Re: [Intel-gfx] [PATCH 12/15] drm/i915: Zero out HOWM registers before writing new WM/HOWM register values

2016-12-01 Thread Maarten Lankhorst
Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > On VLV/CHV some of the watermark values are split across two registers: > low order bits in one, and high order bits in another. So we may not be > able to update a single watermark value atomically, and thus we

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Protect DSPARB registers with a spinlock

2016-12-01 Thread Maarten Lankhorst
Op 01-12-16 om 14:13 schreef Ville Syrjälä: > On Thu, Dec 01, 2016 at 12:56:16PM +0100, Maarten Lankhorst wrote: >> Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: >>> From: Ville Syrjälä >>> >>> Each DSPARB register can house bits for two separate pipes, hence >>> we must protect the

[Intel-gfx] ✗ Fi.CI.BAT: warning for GEM object create and driver init dev_priv cleanups (rev2)

2016-12-01 Thread Patchwork
== Series Details == Series: GEM object create and driver init dev_priv cleanups (rev2) URL : https://patchwork.freedesktop.org/series/16162/ State : warning == Summary == Series 16162v2 GEM object create and driver init dev_priv cleanups https://patchwork.freedesktop.org/api/1.0/series/16162/

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Pass crtc state to vlv_compute_wm_level()

2016-12-01 Thread Maarten Lankhorst
Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > Rather than accessing crtc->config in vlv_compute_wm_level() let's > pass in the crtc state explicitly. One step closer to atomic. > > Signed-off-by: Ville Syrjälä Yay. All users of intel_crtc->config have to di

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-12-01 Thread Hans de Goede
Hi, On 29-11-16 14:06, Hans de Goede wrote: p.s. I'm also trying to come up with some patches which properly integrate pwm-lpss with the i915 driver instead of it throwing a "Failed to own the pwm chip" error. But as soon as I hook up things so that pwm_get() returns the pwm-lpss pwm0 I hit:

Re: [Intel-gfx] 4.8.6, NULL pointer in __wake_up_common / drm / i915

2016-12-01 Thread Olaf Hering
On Wed, Nov 16, Olaf Hering wrote: > During boot into a current openSUSE Tumbleweed 20161108 this laptop > starts to hang sometimes with 4.8.x. Today I was able to catch this > crash in __wake_up_common caused by i915 or drm or whatever: > > ... > [ 69.851635] BUG: unable to handle kernel NULL

[Intel-gfx] [PATCH] drm/i915/dsi: Do not clear DPOUNIT_CLOCK_GATE_DISABLE from vlv_init_display_clock_gating

2016-12-01 Thread Hans de Goede
On my Cherrytrail CUBE iwork8 Air tablet PIPE-A would get stuck on loading i915 at boot 1 out of every 3 boots, resulting in a non functional LCD. Once the i915 driver has successfully loaded, the panel can be disabled / enabled without hitting this issue. The getting stuck is caused by vlv_init_d

[Intel-gfx] [PATCH v7 1/8] drm/i915/skl: Add variables to check x_tile and y_tile

2016-12-01 Thread Mahesh Kumar
This patch adds variable to check for X_tiled & y_tiled planes, instead of always checking against framebuffer-modifiers. Changes: - Created separate patch as per Paulo's comment - Added x_tiled variable as well Changes since V2: - Incorporate Paulo's comments - Rebase Signed-off-by: Mahesh K

[Intel-gfx] [PATCH v7 5/8] drm/i915/skl+: change WM calc to fixed point 16.16

2016-12-01 Thread Mahesh Kumar
This patch changes Watermak calculation to fixed point calculation. Problem with current calculation is during plane_blocks_per_line calculation we divide intermediate blocks with min_scanlines and takes floor of the result because of integer operation. hence we end-up assigning less blocks than re

[Intel-gfx] [PATCH v7 4/8] drm/i915/bxt: Enable IPC support

2016-12-01 Thread Mahesh Kumar
This patch adds IPC support for platforms. This patch enables IPC only for BXT/KBL platform as for SKL recommendation is to keep is disabled. IPC (Isochronous Priority Control) is the hardware feature, which dynamically controles the memory read priority of Display. When IPC is enabled, plane read

[Intel-gfx] [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC

2016-12-01 Thread Mahesh Kumar
This series implements following set of functionality Implement IPC WA's for Broxton/KBL Enable IPC in supported platforms Convert WM calculation to fixed point calculation Calculation of System memory Bandwidth for SKL/KBL/BXT Implementation of Arbitrated me

[Intel-gfx] [PATCH v7 7/8] drm/i915: Decode system memory bandwidth

2016-12-01 Thread Mahesh Kumar
This patch adds support to decode system memory bandwidth which will be used for arbitrated display memory percentage calculation in GEN9 based system. Changes from v1: - Address comments from Paulo - implement decode function for SKL/KBL also Changes from v2: - Rewrite the code as per HW team

[Intel-gfx] [PATCH v7 3/8] drm/i915/kbl: IPC workaround for kabylake

2016-12-01 Thread Mahesh Kumar
Display Workarounds #1141 IPC (Isoch Priority Control) may cause underflows. KBL WA: When IPC is enabled, watermark latency values must be increased by 4us across all levels. This brings level 0 up to 6us. Changes since V1: - Add Workaround number in commit & code Signed-off-by: Mahesh Kumar R

[Intel-gfx] [PATCH v7 2/8] drm/i915/bxt: IPC WA for Broxton

2016-12-01 Thread Mahesh Kumar
Display Workarounds #1135 If IPC is enabled in BXT, display underruns are observed. WA: The Line Time programmed in the WM_LINETIME register should be half of the actual calculated Line Time. Programmed Line Time = 1/2*Calculated Line Time Changes since V1: - Add Workaround number in commit & co

[Intel-gfx] [PATCH v7 6/8] drm/i915: Add intel_atomic_get_existing_crtc_state function

2016-12-01 Thread Mahesh Kumar
This patch Adds a function to extract intel_crtc_state from the atomic_state, if not available it returns NULL. Signed-off-by: Mahesh Kumar Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_drv.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH v7 8/8] drm/i915/gen9: WM memory bandwidth related workaround

2016-12-01 Thread Mahesh Kumar
This patch implemnets Workariunds related to display arbitrated memory bandwidth. These WA are applicabe for all gen-9 based platforms. Changes since v1: - Rebase on top of Paulo's patch series Changes since v2: - Address review comments - Rebase/rework as per other patch changes in series Chan

[Intel-gfx] ✓ Fi.CI.BAT: success for GEN-9 Arbitrated Bandwidth WM WA's & IPC (rev3)

2016-12-01 Thread Patchwork
== Series Details == Series: GEN-9 Arbitrated Bandwidth WM WA's & IPC (rev3) URL : https://patchwork.freedesktop.org/series/15562/ State : success == Summary == Series 15562v3 GEN-9 Arbitrated Bandwidth WM WA's & IPC https://patchwork.freedesktop.org/api/1.0/series/15562/revisions/3/mbox/ fi

  1   2   >