Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Move GuC log related functions into dedicated file

2017-01-17 Thread Tvrtko Ursulin
On 13/01/2017 18:23, Patchwork wrote: == Series Details == Series: drm/i915/guc: Move GuC log related functions into dedicated file URL : https://patchwork.freedesktop.org/series/17988/ State : success == Summary == Series 17988v1 drm/i915/guc: Move GuC log related functions into dedicated

Re: [Intel-gfx] [PATCH] drm/i915: Fix a typo in vgt_balloon_space()

2017-01-17 Thread Zhi Wang
It doesn't matter now:P 于 01/17/17 22:37, Chris Wilson: On Tue, Jan 17, 2017 at 10:06:11PM +0800, Zhi Wang wrote: From: Zhenyu Wang Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper") introduces this typo which can cause a driver loading failure in Linux GVT-g gue

Re: [Intel-gfx] [PATCH] drm/i915: Fix a typo in vgt_balloon_space()

2017-01-17 Thread Zhi Wang
Thanks, Will update it in V2 :P 于 01/17/17 22:27, Jani Nikula: On Tue, 17 Jan 2017, Zhi Wang wrote: From: Zhenyu Wang Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper") introduces this typo which can cause a driver loading failure in Linux GVT-g guest. The pro

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: prevent crash with .disable_display parameter

2017-01-17 Thread Patchwork
== Series Details == Series: drm/i915: prevent crash with .disable_display parameter URL : https://patchwork.freedesktop.org/series/18151/ State : success == Summary == Series 18151v1 drm/i915: prevent crash with .disable_display parameter https://patchwork.freedesktop.org/api/1.0/series/18151

[Intel-gfx] [PATCH] drm/i915: prevent crash with .disable_display parameter

2017-01-17 Thread clinton . a . taylor
From: Clint Taylor The .disable_display parameter was causing a fatal crash when fbdev was dereferenced during driver init. Signed-off-by: Clint Taylor --- drivers/gpu/drm/i915/i915_drv.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] ✓ Fi.CI.BAT: success for Add Automation Support for DP Compliance Testing (Rev 4)

2017-01-17 Thread Patchwork
== Series Details == Series: Add Automation Support for DP Compliance Testing (Rev 4) URL : https://patchwork.freedesktop.org/series/18150/ State : success == Summary == Series 18150v1 Add Automation Support for DP Compliance Testing (Rev 4) https://patchwork.freedesktop.org/api/1.0/series/181

[Intel-gfx] [PATCH 2/4] drm/i915: Fixes to support DP Compliance EDID tests

2017-01-17 Thread Manasi Navare
This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Video Mode requested in the EDID test handler for the EDID Read test (CTS 4.2.2.3) should be set to PREFERRED as per the CTS spec. v2: * Added read debugfs data from test_data.e

[Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

2017-01-17 Thread Manasi Navare
v2: * Add all the other DP Complianec TEST register defs (Jani Nikula) Cc: dri-de...@lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- include/drm/drm_dp_helper.h | 58 + 1 file changed, 58 ins

[Intel-gfx] [PATCH 0/4] Add Automation Support for DP Compliance Testing (Rev 4)

2017-01-17 Thread Manasi Navare
This series is a rebased version of the previous series: https://patchwork.freedesktop.org/series/16643/ DP 1.2 compliance testing can be acheived using DPR-120's CTS suite. This compliance unit sends a short pulse to initiate link training and video pattern generation compliance tests and sends a

[Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

2017-01-17 Thread Manasi Navare
This patch adds support to handle automated DP compliance link training test requests. This patch has been tested with Unigraf DPR-120 DP Compliance device for testing Link Training Compliance. After we get a short pulse Compliance test request, test request values are read and hotplug uevent is se

[Intel-gfx] [PATCH 4/4] drm/i915: Add support for DP Video pattern compliance tests

2017-01-17 Thread Manasi Navare
The intel_dp_autotest_video_pattern() function gets invoked through the compliance test handler on a HPD short pulse if the test type is set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers reads to read the requested test pattern, video pattern resolution, frame rate and bits per color v

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Ignore bogus plane coordinates on SKL when the plane is not visible

2017-01-17 Thread Matt Roper
On Tue, Jan 17, 2017 at 02:05:07PM -0800, Matt Roper wrote: > On Mon, Nov 07, 2016 at 10:20:54PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > When the plane is invisible we may have all sorts of bogus stuff > > in the coordinates, which we must ignore or else we mig

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Ignore bogus plane coordinates on SKL when the plane is not visible

2017-01-17 Thread Matt Roper
On Mon, Nov 07, 2016 at 10:20:54PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > When the plane is invisible we may have all sorts of bogus stuff > in the coordinates, which we must ignore or else we might fail the > plane update. This started to happen on SKL when I moved

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Fix compiler warnings for hsw_psr_disable()

2017-01-17 Thread Vivi, Rodrigo
same for the other... dm old gcc... Also my bad here since I asked Vathsala to organize like this... Anyways, for this patch Reviewed-by: Rodrigo Vivi On Mon, 2017-01-16 at 13:06 +, Chris Wilson wrote: > drivers/gpu/drm/i915/intel_psr.c:634 hsw_psr_disable() warn: if statement not > ind

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix compiler warnings for i915_edp_psr_status()

2017-01-17 Thread Vivi, Rodrigo
Apparently new gccs are getting more cases. I wonder if CI also have the old gcc that Vathsala and I have here. Anyways: Reviewed-by: Rodrigo Vivi On Mon, 2017-01-16 at 13:06 +, Chris Wilson wrote: > Appease both the poor reader and the compiler by rewriting the string > lookup for EDP_PS

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

2017-01-17 Thread Manasi Navare
I have verified this patch with the latest drm-tip and it is also absolutely necessary to ensure the link gets properly retrained after link-status is BAD and after anew modeset is triggered by userspace. Without this patch, since intel_dp_long_pulse gets called it resets the link failure values an

Re: [Intel-gfx] [PATCH 06/10] drm/i915/psr: set CHICKEN_TRANS for psr2

2017-01-17 Thread Rodrigo Vivi
On Mon, Jan 16, 2017 at 2:04 AM, Jani Nikula wrote: > On Fri, 13 Jan 2017, Rodrigo Vivi wrote: >> This and all the remaining patches on this series (6,7,8 and 9) got >> merged to dinq. > > Given that this patch series was not properly sent as a thread, I don't > think our CI ran it as a whole, an

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()

2017-01-17 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Move engine reset preparation to i915_gem_reset_prepare() URL : https://patchwork.freedesktop.org/series/18131/ State : success == Summary == Series 18131v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/

Re: [Intel-gfx] regression since v4.9-rcX: "Resetting chip after gpu hang" times out(?) and is repeated every 20th second

2017-01-17 Thread Mark Janes
Bjørn Mork writes: > Hello, > > I've been having occasional GPU HANGs on my Skylake laptop ever since I > got it, originally reported here: > https://bugs.freedesktop.org/show_bug.cgi?id=96894 Several similar bugs have been resolved recently. I apologize for missing this one. I'll update this

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Add comment how we treat hung contexts

2017-01-17 Thread Chris Wilson
On Tue, Jan 17, 2017 at 05:59:07PM +0200, Mika Kuoppala wrote: > Explain in a comment how and why we treat hung > context like we do. > > Cc: Chris Wilson > Cc: Tvrtko Ursulin > Signed-off-by: Mika Kuoppala Series Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technolog

[Intel-gfx] [PATCH 5/7] drm/i915: Tidy up engine reset logic

2017-01-17 Thread Mika Kuoppala
Split engine reset for engine and request specific parts. Cc: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/

[Intel-gfx] [PATCH 7/7] drm/i915: Add comment how we treat hung contexts

2017-01-17 Thread Mika Kuoppala
Explain in a comment how and why we treat hung context like we do. Cc: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 6/7] drm/i915: Detect a failed GPU reset+recovery

2017-01-17 Thread Mika Kuoppala
From: Chris Wilson If we can't recover the GPU after the reset, mark it as wedged to cancel the outstanding tasks and to prevent new users from trying to use the broken GPU. v2: Check the same ring is hung again before declaring the reset broken. v3: use engine_stalled (Mika) Signed-off-by: Chr

[Intel-gfx] [PATCH 4/7] drm/i915: Introduce engine_stalled helper

2017-01-17 Thread Mika Kuoppala
Move the engine stalled/pardoned check into a helper function. Cc: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/

[Intel-gfx] [PATCH 3/7] drm/i915: Cleanup request skip decision

2017-01-17 Thread Mika Kuoppala
Since we now only skip banned contexts, preventing the skip of default contexts is no longer sensible. For a similar argument as before 'commit 7ec73b7e36d0 ("drm/i915: Only skip requests once a context is banned")' we end up with an inconsistent API if we only mark future execbufs from the default

[Intel-gfx] [PATCH 2/7] drm/i915: Introduce engine_skip_context

2017-01-17 Thread Mika Kuoppala
Add a new function for skipping all pending requests for a context in order to make engine reset flow more readable. Cc: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem.c | 59 - 1 file changed, 34 insertion

[Intel-gfx] [PATCH 1/7] drm/i915: Move engine reset preparation to i915_gem_reset_prepare()

2017-01-17 Thread Mika Kuoppala
From: Chris Wilson Now that we have prepare/finish routines for the GEM reset, move the disabling of the engine->irq_tasklet into them to reduce repetition. The device irq enable/disable is split out to ensure it is run first and last always (even if the GPU reset fails). Signed-off-by: Chris Wi

Re: [Intel-gfx] [PATCH] drm/i915: Fix a typo in vgt_balloon_space()

2017-01-17 Thread Chris Wilson
On Tue, Jan 17, 2017 at 04:27:04PM +0200, Jani Nikula wrote: > On Tue, 17 Jan 2017, Zhi Wang wrote: > > From: Zhenyu Wang > > > > Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a > > helper") introduces this typo which can cause a driver loading failure > > in Linux GVT-g g

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix a typo in vgt_balloon_space() (rev2)

2017-01-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix a typo in vgt_balloon_space() (rev2) URL : https://patchwork.freedesktop.org/series/18123/ State : success == Summary == Series 18123v2 drm/i915: Fix a typo in vgt_balloon_space() https://patchwork.freedesktop.org/api/1.0/series/18123/revisions/2/mbox

Re: [Intel-gfx] [PATCH] drm/i915: Fix a typo in vgt_balloon_space()

2017-01-17 Thread Chris Wilson
On Tue, Jan 17, 2017 at 10:06:11PM +0800, Zhi Wang wrote: > From: Zhenyu Wang > > Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a > helper") introduces this typo which can cause a driver loading failure > in Linux GVT-g guest. > > Cc: Joonas Lahtinen > Cc: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Fix a typo in vgt_balloon_space()

2017-01-17 Thread Jani Nikula
On Tue, 17 Jan 2017, Zhi Wang wrote: > From: Zhenyu Wang > > Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a > helper") introduces this typo which can cause a driver loading failure > in Linux GVT-g guest. The proper format for fixes is: Fixes: 625d988acc28 ("drm/i915: E

[Intel-gfx] [PATCH] drm/i915: Re-enable preallocated top level PDPs support

2017-01-17 Thread Zhi Wang
After PPGTT page table is able to be shrinken, the preallocated PDPs and PDE pages can be freed even they are preallocated under 3-level PPGTT mode. This patch re-enables preallocated top level PDPs and PDE pages like before. Cc: Michał Winiarski Cc: Michel Thierry Cc: Joonas Lahtinen Cc: Chris

[Intel-gfx] [PATCH] drm/i915: Fix a typo in vgt_balloon_space()

2017-01-17 Thread Zhi Wang
From: Zhenyu Wang Commit 625d988acc28 ("drm/i915: Extract reserving space in the GTT to a helper") introduces this typo which can cause a driver loading failure in Linux GVT-g guest. Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Zhiyuan Lv Signed-off-by: Zhenyu Wang Signed-off-by: Zhi Wang ---

Re: [Intel-gfx] [PATCH 17/37] drm/i915: Test partial mappings

2017-01-17 Thread Chris Wilson
On Tue, Jan 17, 2017 at 12:12:50PM +, Matthew Auld wrote: > > + for (pitch = 1; pitch <= max_pitch; pitch <<= 1) { > > + tile.stride = tile.width * pitch; > > + err = check_partial_mapping(obj, &tile); > > + if (err

Re: [Intel-gfx] [PATCH 17/37] drm/i915: Test partial mappings

2017-01-17 Thread Matthew Auld
On 11 January 2017 at 21:09, Chris Wilson wrote: > Create partial mappings to cover a large object, investigating tiling > (fenced regions) and VMA reuse. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/selftests/i915_gem_object.c | 252 > +++ > 1 file changed,

[Intel-gfx] [PATCH i-g-t v2 2/2] tests/kms_plane_multiple: Cleanup in favor of library functions

2017-01-17 Thread Mika Kahola
Cleaunup by replacing get_vblank() function with library function kmstest_get_vblank(). Cc: Maarten Lankhorst Reviewed-by: Maarten Lankhorst Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 27 +++ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t v2 0/2] tests/kms_plane_multiple: Fix CI issues

2017-01-17 Thread Mika Kahola
Fixes for issues seen on CI tests. The patches provide relaxed timing requirement for atomic commit as well as general cleanup to favor library functions. v2: fix MAX_CRCS definition Mika Kahola (2): tests/kms_plane_multiple: Relax atomic commit time requirement tests/kms_plane_multiple: Clea

[Intel-gfx] [PATCH i-g-t v2 1/2] tests/kms_plane_multiple: Relax atomic commit time requirement

2017-01-17 Thread Mika Kahola
Relax required time to atomic commits from 1 vblank to 2 vblanks. v2: Increase MAX_CRCS to 2 (Maarten) Reference: Issues seen on BYT CI tests Cc: Maarten Lankhorst Signed-off-by: Mika Kahola --- tests/kms_plane_multiple.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) dif

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915: Remove i915_gem_object_to_ggtt()

2017-01-17 Thread Joonas Lahtinen
On ma, 2017-01-16 at 15:21 +, Chris Wilson wrote: > With the last user of this convenience wrapper gone, we can kill the > wrapper and in the process make the lookup function static. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Sourc