Re: [Intel-gfx] [PATCH] tools: rename intel_bios_reader to intel_vbt_decode

2017-01-30 Thread Jani Nikula
On Tue, 24 Jan 2017, Jani Nikula wrote: > After all these years intel_bios_reader and intel_bios_dumper still > manage to confuse me. Read or dump, which one decodes. Rename > intel_bios_reader to intel_vbt_decode to be in line with the naming of > all the other tools (particularly the closely rel

Re: [Intel-gfx] [PATCH v2 2/3] pwm/core: Try to get the module from pwm_get

2017-01-30 Thread Thierry Reding
On Sun, Jan 22, 2017 at 05:14:08PM +0100, Hans de Goede wrote: > Add a module_name string to the pwm_lookup struct and if specified > and pwmchip_find_by_name() does not find the pwmchip try calling > request_module with the specified name. > > Signed-off-by: Hans de Goede > --- > drivers/pwm/co

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 03:08:45PM +, Chris Wilson wrote: > On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote: > > On Fri, Jan 27, 2017 at 02:31:55PM +, Chris Wilson wrote: > > > On Fri, Jan 27, 2017 at 03:21:29PM +0100, Daniel Vetter wrote: > > > > On Fri, Jan 27, 2017 at 09:30

Re: [Intel-gfx] [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

2017-01-30 Thread Thierry Reding
On Sun, Jan 22, 2017 at 05:14:09PM +0100, Hans de Goede wrote: > On x86 we do not have devicetree to link the PWM controller and > the display controller together. So someone needs to call > pwm_add_table() to create the link, so that the i915 driver's > pwm_get(dev, "pwm_backlight") call returns t

Re: [Intel-gfx] [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

2017-01-30 Thread Rafael J. Wysocki
On Mon, Jan 30, 2017 at 9:18 AM, Thierry Reding wrote: > On Sun, Jan 22, 2017 at 05:14:09PM +0100, Hans de Goede wrote: >> On x86 we do not have devicetree to link the PWM controller and >> the display controller together. So someone needs to call >> pwm_add_table() to create the link, so that the

Re: [Intel-gfx] [PATCH v3] drm/i915/glk: Turn on workarounds that apply to Geminilake too

2017-01-30 Thread Ander Conselvan De Oliveira
On Thu, 2017-01-26 at 14:06 +0200, David Weinehall wrote: > On Thu, Jan 26, 2017 at 11:16:58AM +0200, Ander Conselvan de Oliveira wrote: > > Apply workarounds to Geminilake, and annotate those that are applied > > unconditionally when they apply to GLK based on the workaround database. > > > > v2:

Re: [Intel-gfx] [PATCH v2 2/5] drm/i915/glk: Plane color correction register changes

2017-01-30 Thread Ander Conselvan De Oliveira
On Thu, 2017-01-26 at 13:32 +0200, Ville Syrjälä wrote: > On Thu, Jan 26, 2017 at 01:24:22PM +0200, Ander Conselvan de Oliveira wrote: > > In Geminilake, the bits for enabling pipe csc, pipe gamma and plane > > gamma moved to a new register. So update the plane update functions > > to set the right

Re: [Intel-gfx] [PATCH v3] drm/i915/glk: Program pipe gamma and degamma tables

2017-01-30 Thread Ander Conselvan De Oliveira
On Fri, 2017-01-27 at 16:04 +0200, Ville Syrjälä wrote: > On Fri, Jan 27, 2017 at 11:02:30AM +0200, Ander Conselvan de Oliveira wrote: > > The gamma tables in Geminilake were changed. There is no split-gamma > > mode. Instead, there is a dedicated degamma table that is enabled > > whenever pipe CSC

[Intel-gfx] [PULL] drm-misc-next

2017-01-30 Thread Daniel Vetter
Hi Dave, Another round of -misc stuff: - Noralf debugfs cleanup cleanup (not yet everything, some more driver patches awaiting acks). - More doc work. - edid/infoframe fixes from Ville. - misc 1-patch fixes all over, as usual Noralf needs this for his tinydrm pull request. And as discussed las

Re: [Intel-gfx] [PATCH] drm: Don't race connector registration

2017-01-30 Thread Daniel Vetter
On Thu, Jan 26, 2017 at 12:34:29PM -0800, Dave Hansen wrote: > On 01/25/2017 07:38 AM, Daniel Vetter wrote: > > On Wed, Jan 25, 2017 at 07:20:45AM -0800, Dave Hansen wrote: > >> On 01/24/2017 10:21 PM, Daniel Vetter wrote: > >>> Hi Dave, > >>> > >>> Still waiting for your testing results on this on

Re: [Intel-gfx] [PATCH] drm/i915: Get correct display clock on 945gm

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 09:51:50PM +0200, Ville Syrjälä wrote: > On Fri, Jan 27, 2017 at 06:24:25PM +0100, Arthur Heymans wrote: > > Ville Syrjälä writes: > > > > >> > > >> > Now if someone could figure out where to dig up the DDR and FSB clocks > > >> > we could also fix up the 190 vs. 200 MHz

Re: [Intel-gfx] [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

2017-01-30 Thread Mika Westerberg
On Mon, Jan 30, 2017 at 09:28:09AM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 30, 2017 at 9:18 AM, Thierry Reding > wrote: > > On Sun, Jan 22, 2017 at 05:14:09PM +0100, Hans de Goede wrote: > >> On x86 we do not have devicetree to link the PWM controller and > >> the display controller together

Re: [Intel-gfx] [dinq] Request to merge in padovan's fence fd fix

2017-01-30 Thread Daniel Vetter
On Fri, Jan 27, 2017 at 12:36:11PM -0800, Chad Versace wrote: > Chris just pushed execbuffer fence fds to dinq. Could someone please get the > below fix from airlied/drm-fixes into dinq? (What's the usual method here? > Merge drm-fixes -> dinq, cherry-pick drm-fixes -> dinq, rebase?) For testing,

Re: [Intel-gfx] Oops at shutdown in intel_unpin_fb_obj()

2017-01-30 Thread Daniel Vetter
On Sun, Jan 29, 2017 at 11:42:32AM -0800, Linus Torvalds wrote: > Guys, I've gotten absolutely no response to this, and the problem > seems to still occur. > > I just got a slightly different hang at shutdown, due to a kernel oops > that seems related. It's not identical - the call trace is very >

Re: [Intel-gfx] [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
Regards Shashank On 1/30/2017 2:52 PM, Andrzej Hajda wrote: On 30.01.2017 09:45, Sharma, Shashank wrote: Regards Shashank On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017 06:41, Shashank Sharma wrote: CEA-861-F specs defines new 4k video modes to be used with HDMI 2.0 EDIDs. Thes

Re: [Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages

2017-01-30 Thread Daniel Vetter
Hi all, Ok if we merge the entire series through drm-intel (likely for 4.12, 4.11 is getting a bit late)? We'd like to use this there, and Mauro already reviewed the v4l side ... Thanks, Daniel On Mon, Jan 16, 2017 at 02:12:07PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Scatterli

Re: [Intel-gfx] [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

2017-01-30 Thread Thierry Reding
On Mon, Jan 30, 2017 at 11:33:10AM +0200, Mika Westerberg wrote: > On Mon, Jan 30, 2017 at 09:28:09AM +0100, Rafael J. Wysocki wrote: > > On Mon, Jan 30, 2017 at 9:18 AM, Thierry Reding > > wrote: > > > On Sun, Jan 22, 2017 at 05:14:09PM +0100, Hans de Goede wrote: > > >> On x86 we do not have dev

Re: [Intel-gfx] [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Andrzej Hajda
On 30.01.2017 10:42, Sharma, Shashank wrote: > Regards > > Shashank > > > On 1/30/2017 2:52 PM, Andrzej Hajda wrote: >> On 30.01.2017 09:45, Sharma, Shashank wrote: >>> Regards >>> >>> Shashank >>> >>> >>> On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017 06:41, Shashank Sharma wrote: >

[Intel-gfx] [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

2017-01-30 Thread Chris Wilson
As we add new generations, we should keep detecting new pre-production system development platforms that were temporarily enabled to facilitate initial development and now superseded by production systems. To make it easier to add more platforms, split the if into a series of logical operations. v

[Intel-gfx] [PATCH v2 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines

2017-01-30 Thread Chris Wilson
Extend intel_detect_preproduction_hw() to include BXT A and B steppings. Signed-off-by: Chris Wilson Cc: "Zanoni, Paulo R" Cc: Rodrigo Vivi Cc: Jani Nikula Cc: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_drv.

[Intel-gfx] [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

2017-01-30 Thread Chris Wilson
Preproduction sdv are not supported beyond the release of production hardware, and continued use is ill-advised. Mark the kernel as tainted to reinforce the error. Signed-off-by: Chris Wilson Cc: "Zanoni, Paulo R" Cc: Rodrigo Vivi Cc: Jani Nikula Cc: Ville Syrjälä Acked-by: Jani Nikula ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Create context desc template when context is created

2017-01-30 Thread Patchwork
== Series Details == Series: drm/i915: Create context desc template when context is created URL : https://patchwork.freedesktop.org/series/18677/ State : success == Summary == Series 18677v1 drm/i915: Create context desc template when context is created https://patchwork.freedesktop.org/api/1.

Re: [Intel-gfx] [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
Regards Shashank On 1/30/2017 3:47 PM, Andrzej Hajda wrote: On 30.01.2017 10:42, Sharma, Shashank wrote: Regards Shashank On 1/30/2017 2:52 PM, Andrzej Hajda wrote: On 30.01.2017 09:45, Sharma, Shashank wrote: Regards Shashank On 1/30/2017 1:30 PM, Andrzej Hajda wrote: On 29.01.2017

[Intel-gfx] [PATCH i-g-t] tests: Clean up shell scripts

2017-01-30 Thread Joonas Lahtinen
Convert all scripts to use /bin/sh shebang and fix all shellcheck reported problems. Signed-off-by: Joonas Lahtinen Cc: Petri Latvala Cc: Daniel Vetter Cc: Jani Nikula --- tests/check_drm_clients | 15 + tests/ddx_intel_after_fbdev | 42 ++--- t

[Intel-gfx] [PATCH] drm/i915: Warn when cleanup the plane if the fb doesn't match the vma

2017-01-30 Thread Chris Wilson
We track the plane state's framebuffer and VMA separately, giving us an opportunity to detect if that pair becomes inconsistent when we cleanup after the atomic modeset. Signed-off-by: Chris Wilson Cc: Maarten Lankhorst Cc: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Check fence status after serialising with the spinlock

2017-01-30 Thread Patchwork
== Series Details == Series: drm/i915: Check fence status after serialising with the spinlock URL : https://patchwork.freedesktop.org/series/18678/ State : warning == Summary == Series 18678v1 drm/i915: Check fence status after serialising with the spinlock https://patchwork.freedesktop.org/ap

Re: [Intel-gfx] [PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-30 Thread Sharma, Shashank
I just realized that the CEA spec talks about picking HDMI 2.0/861-F VIC over HDMI14b VIC in case of 3D side-by-side format (not in 2D), In this case, we might have to add a check while loading the VIC filed in AVI IF (as you suggested) Will come back with a V2 (if required), once I have more

[Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Mika Kahola
Validate atomic commit correctness before actual commit. For: VIZ-6956 v2: Add flag to toggle TEST_ONLY for atomic commit. Remove DRM_MODE_PAGE_FLIP_EVENT flag, if enabled, before trying atomic commit with TEST_ONLY flag (Maarten) Cc: Maarten Lankhorst Signed-off-by: Mika Kahola ---

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

2017-01-30 Thread Petri Latvala
NAK. DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable to modeset, unable to render, practically it only supports the vgem-specific tests. See also: lib/drmtest.c, __drm_open_driver(). -- Petri Latvala ___ Intel-gfx mailing list Int

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

2017-01-30 Thread Daniel Stone
Hi, On 30 January 2017 at 11:46, Petri Latvala wrote: > NAK. > > DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable > to modeset, unable to render, practically it only supports the > vgem-specific tests. See also: lib/drmtest.c, __drm_open_driver(). Yeah, I agree with this. It'

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: minor corner case fix to respect user's backlight setting

2017-01-30 Thread Patchwork
== Series Details == Series: drm/i915: minor corner case fix to respect user's backlight setting URL : https://patchwork.freedesktop.org/series/18685/ State : success == Summary == Series 18685v1 drm/i915: minor corner case fix to respect user's backlight setting https://patchwork.freedesktop

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

2017-01-30 Thread Eric Engestrom
On Monday, 2017-01-30 11:50:52 +, Daniel Stone wrote: > Hi, > > On 30 January 2017 at 11:46, Petri Latvala wrote: > > NAK. > > > > DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable > > to modeset, unable to render, practically it only supports the > > vgem-specific tests. S

Re: [Intel-gfx] Oops at shutdown in intel_unpin_fb_obj()

2017-01-30 Thread Maarten Lankhorst
Op 30-01-17 om 10:38 schreef Daniel Vetter: > On Sun, Jan 29, 2017 at 11:42:32AM -0800, Linus Torvalds wrote: >> Guys, I've gotten absolutely no response to this, and the problem >> seems to still occur. >> >> I just got a slightly different hang at shutdown, due to a kernel oops >> that seems rela

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/skl: Add missing SKL ID (rev2)

2017-01-30 Thread Patchwork
== Series Details == Series: drm/i915/skl: Add missing SKL ID (rev2) URL : https://patchwork.freedesktop.org/series/3537/ State : success == Summary == Series 3537v2 drm/i915/skl: Add missing SKL ID https://patchwork.freedesktop.org/api/1.0/series/3537/revisions/2/mbox/ Test kms_pipe_crc_basi

Re: [Intel-gfx] [PATCH] drm/i915: Check fence status after serialising with the spinlock

2017-01-30 Thread Joonas Lahtinen
On pe, 2017-01-27 at 13:06 +, Chris Wilson wrote: > A very rare problem we encounter is that as retire the request we find                                          we -^ > that it appears to not have been yet executed. Other than malevolent hw, > one possible explanation is that the update of t

Re: [Intel-gfx] [PATCH i-g-t 2/2] aubdump: support new ioctl

2017-01-30 Thread Petri Latvala
On Sun, Jan 29, 2017 at 11:35:42PM +, Lionel Landwerlin wrote: > Otherwise we won't log anything with OpenGL applications using a > recent Mesa driver. > > Signed-off-by: Lionel Landwerlin > --- > tools/aubdump.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/too

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

2017-01-30 Thread Joonas Lahtinen
On ma, 2017-01-30 at 10:44 +, Chris Wilson wrote: > Preproduction sdv are not supported beyond the release of production > hardware, and continued use is ill-advised. Mark the kernel as tainted > to reinforce the error. > > Signed-off-by: Chris Wilson > Cc: "Zanoni, Paulo R" > Cc: Rodrigo Vi

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

2017-01-30 Thread Joonas Lahtinen
On ma, 2017-01-30 at 10:44 +, Chris Wilson wrote: > As we add new generations, we should keep detecting new pre-production > system development platforms that were temporarily enabled to facilitate > initial development and now superseded by production systems. To make > it easier to add more p

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines

2017-01-30 Thread Joonas Lahtinen
On ma, 2017-01-30 at 10:44 +, Chris Wilson wrote: > Extend intel_detect_preproduction_hw() to include BXT A and B steppings. > > Signed-off-by: Chris Wilson > Cc: "Zanoni, Paulo R" > Cc: Rodrigo Vivi > Cc: Jani Nikula > Cc: Ville Syrjälä Reviewed-by: Joonas Lahtinen Regards, Joonas --

Re: [Intel-gfx] [PATCH i-g-t 2/2] aubdump: support new ioctl

2017-01-30 Thread Chris Wilson
On Mon, Jan 30, 2017 at 02:29:07PM +0200, Petri Latvala wrote: > On Sun, Jan 29, 2017 at 11:35:42PM +, Lionel Landwerlin wrote: > > Otherwise we won't log anything with OpenGL applications using a > > recent Mesa driver. > > > > Signed-off-by: Lionel Landwerlin > > --- > > tools/aubdump.c |

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check the computed size and base of stolen memory

2017-01-30 Thread Joonas Lahtinen
On pe, 2017-01-27 at 17:20 +, Chris Wilson wrote: > Just do a quick check that the stolen memory address range doesn't > overflow our chosen integer type. > > Signed-off-by: Chris Wilson > @@ -189,7 +189,7 @@ static dma_addr_t i915_stolen_to_dma(struct > drm_i915_private *dev_priv) >  

Re: [Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Maarten Lankhorst
Op 30-01-17 om 12:37 schreef Mika Kahola: > Validate atomic commit correctness before actual commit. > > For: VIZ-6956 > > v2: Add flag to toggle TEST_ONLY for atomic commit. > Remove DRM_MODE_PAGE_FLIP_EVENT flag, if enabled, before trying atomic > commit with TEST_ONLY flag (Maarten) > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/color: un-inline drm_color_lut_extract() (rev2)

2017-01-30 Thread Patchwork
== Series Details == Series: drm/color: un-inline drm_color_lut_extract() (rev2) URL : https://patchwork.freedesktop.org/series/18391/ State : success == Summary == Series 18391v2 drm/color: un-inline drm_color_lut_extract() https://patchwork.freedesktop.org/api/1.0/series/18391/revisions/2/mb

Re: [Intel-gfx] [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > Hi, > > On 01/28/2017 05:25 PM, Hans de Goede wrote: > > Hi, > > > > On 01/27/2017 02:51 PM, Ville Syrjälä wrote: > >> On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: > >>> Make sure the P-Unit or the PMIC i2c bus is n

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

2017-01-30 Thread Jani Nikula
On Mon, 30 Jan 2017, Joonas Lahtinen wrote: > On ma, 2017-01-30 at 10:44 +, Chris Wilson wrote: >> As we add new generations, we should keep detecting new pre-production >> system development platforms that were temporarily enabled to facilitate >> initial development and now superseded by pro

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check the computed size and base of stolen memory

2017-01-30 Thread Chris Wilson
On Mon, Jan 30, 2017 at 02:41:15PM +0200, Joonas Lahtinen wrote: > On pe, 2017-01-27 at 17:20 +, Chris Wilson wrote: > > Just do a quick check that the stolen memory address range doesn't > > overflow our chosen integer type. > > > > Signed-off-by: Chris Wilson > > > > > @@ -189,7 +189,7 @

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

2017-01-30 Thread Chris Wilson
On Mon, Jan 30, 2017 at 03:11:07PM +0200, Jani Nikula wrote: > On Mon, 30 Jan 2017, Joonas Lahtinen wrote: > > On ma, 2017-01-30 at 10:44 +, Chris Wilson wrote: > >> As we add new generations, we should keep detecting new pre-production > >> system development platforms that were temporarily e

Re: [Intel-gfx] [PATCH] tools: rename intel_bios_reader to intel_vbt_decode

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 10:00:54AM +0200, Jani Nikula wrote: > On Tue, 24 Jan 2017, Jani Nikula wrote: > > After all these years intel_bios_reader and intel_bios_dumper still > > manage to confuse me. Read or dump, which one decodes. Rename > > intel_bios_reader to intel_vbt_decode to be in line w

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

2017-01-30 Thread Chris Wilson
On Mon, Jan 30, 2017 at 02:31:57PM +0200, Joonas Lahtinen wrote: > On ma, 2017-01-30 at 10:44 +, Chris Wilson wrote: > > Preproduction sdv are not supported beyond the release of production > > hardware, and continued use is ill-advised. Mark the kernel as tainted > > to reinforce the error. >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use variadic macros and arrays to choose port/pipe based registers

2017-01-30 Thread Patchwork
== Series Details == Series: drm/i915: use variadic macros and arrays to choose port/pipe based registers URL : https://patchwork.freedesktop.org/series/18691/ State : success == Summary == Series 18691v1 drm/i915: use variadic macros and arrays to choose port/pipe based registers https://pa

Re: [Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Mika Kahola
On Mon, 2017-01-30 at 13:43 +0100, Maarten Lankhorst wrote: > Op 30-01-17 om 12:37 schreef Mika Kahola: > > > > Validate atomic commit correctness before actual commit. > > > > For: VIZ-6956 > > > > v2: Add flag to toggle TEST_ONLY for atomic commit. > > Remove DRM_MODE_PAGE_FLIP_EVENT flag,

Re: [Intel-gfx] [PATCH] drm/i915: Sanity check the computed size and base of stolen memory

2017-01-30 Thread Joonas Lahtinen
On ma, 2017-01-30 at 13:15 +, Chris Wilson wrote: >  > if (base == 0 || range_overflows(base, ggtt->stolen_size, U64_MAX /* > DMA_ADDR_MAX */)) > > Bleh. > > #define add_overflows(A, B) __builtin_add_overflow_p((A), (B), (typeof((A) + > (B)))0) > > if (base == 0 || add_overflows(base, ggtt

[Intel-gfx] [PATCH v2] drm/i915: Sanity check the computed size and base of stolen memory

2017-01-30 Thread Chris Wilson
Just do a quick check that the stolen memory address range doesn't overflow our chosen integer type. v2: Add add_overflows() to utils with the promise that gcc7 can do this better than C and then maybe it will have a proper definition in core. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen ---

[Intel-gfx] [PATCH i-g-t v3 00/33] lib/igt_kms: Implement dynamic plane count support

2017-01-30 Thread Robert Foss
This series implements dynamic plane count support in lib/igt_kms and modifies all of the tests that rely on a static plane count. Currently it has has gone through incomplete testing on vc4 (many tests are intel only) and intel (on intel-ci). This series can be found in the branch dyn_n_planes_

[Intel-gfx] [PATCH i-g-t v3 06/33] tests/kms_busy: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_busy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_busy.c b/tests/kms_busy.c index d2be7212..ea35fb0b 100644 --

[Intel-gfx] [PATCH i-g-t v3 05/33] tests/kms_atomic_transition: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_atomic_transition.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/tests/kms_atomic_transition.c b/t

[Intel-gfx] [PATCH i-g-t v3 04/33] lib/igt_kms: Implement dynamic plane count support

2017-01-30 Thread Robert Foss
In upcoming drm-misc-next changes, the number of planes per pipe has been increased as more than one primary plane can be associated with a pipe. The simple fix for this would be to simply bump hardcoded value for number of frames per pipe. But a better solution would be to add support for dynamic

[Intel-gfx] [PATCH i-g-t v3 03/33] lib/igt_kms: Rename kmstest properties nplanes and plane

2017-01-30 Thread Robert Foss
Rename these properties to have them use the same naming convention as the igt_*_t structs. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- lib/igt_kms.c| 16 +--- lib/igt_kms.h| 4 ++-- tests/kms_plane_lowres.c | 10 +- 3 files changed, 16 i

[Intel-gfx] [PATCH i-g-t v3 10/33] tests/kms_cursor_legacy: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_cursor_legacy.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/tests/kms_cursor_legacy.c b/test

[Intel-gfx] [PATCH i-g-t v3 02/33] lib/igt_kms: Avoid depencency on static plane count

2017-01-30 Thread Robert Foss
Rework kmstest_crtc and kmstest_plane structs and their usage to not depend on a static plane count. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- lib/igt_kms.c | 47 ++- lib/igt_kms.h | 4 ++-- 2 files changed, 32 insertions(+), 19 deletio

[Intel-gfx] [PATCH i-g-t v3 01/33] lib/igt_kms: Add index property to kmstest_plane struct

2017-01-30 Thread Robert Foss
Add an index property which helps accessing the corresponding igt_plane_t structure through the igt_*_get_plane() functions. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- lib/igt_kms.c| 12 ++-- lib/igt_kms.h| 1 + tests/kms_plane_lowres.c | 2 +- 3 f

[Intel-gfx] [PATCH i-g-t v3 08/33] tests/kms_crtc_background_color: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_crtc_background_color.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_crtc_background_color.c b/tests/kms_crtc_backgro

[Intel-gfx] [PATCH i-g-t v3 15/33] tests/kms_mmap_write_crc: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_mmap_write_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_mmap_write_crc.c b/tests/kms_mmap_write_crc.c index eb85

[Intel-gfx] [PATCH i-g-t v3 07/33] tests/kms_chv_cursor_fail: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_chv_cursor_fail.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_chv_cursor_fail.c b/tests/kms_chv_cursor_fail.c i

[Intel-gfx] [PATCH i-g-t v3 09/33] tests/kms_cursor_crc: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_cursor_crc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index ff9

[Intel-gfx] [PATCH i-g-t v3 13/33] tests/kms_flip_event_leak: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_flip_event_leak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c index f

[Intel-gfx] [PATCH i-g-t v3 11/33] tests/kms_fbc_crc: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_fbc_crc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index a696e124..96af06

[Intel-gfx] [PATCH i-g-t v3 12/33] tests/kms_fence_pin_leak: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_fence_pin_leak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_fence_pin_leak.c b/tests/kms_fence_pin_leak.c index 6301

[Intel-gfx] [PATCH i-g-t v3 16/33] tests/kms_mmio_vs_cs_flip: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_mmio_vs_cs_flip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_mmio_vs_cs_flip.c b/tests/kms_mmio_vs_cs_flip.c i

[Intel-gfx] [PATCH i-g-t v3 18/33] tests/kms_pipe_color: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_pipe_color.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_pipe_color.c b/tests/kms_pipe_color.c index 1aff7d54..c7

[Intel-gfx] [PATCH i-g-t v3 25/33] tests/kms_rmfb: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_rmfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c index 17a3065a..5753d74c 100644 --- a/te

[Intel-gfx] [PATCH i-g-t v3 14/33] tests/kms_legacy_colorkey: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_legacy_colorkey.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_legacy_colorkey.c b/tests/kms_legacy_colorkey.c inde

[Intel-gfx] [PATCH i-g-t v3 24/33] tests/kms_pwrite_crc: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_pwrite_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_pwrite_crc.c b/tests/kms_pwrite_crc.c index b63afbc6..1e6263

[Intel-gfx] [PATCH i-g-t v3 27/33] tests/kms_sink_crc_basic: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_sink_crc_basic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_sink_crc_basic.c b/tests/kms_sink_crc_basic.c index c332

[Intel-gfx] [PATCH i-g-t v3 32/33] tests/kms_plane_lowres: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_plane_lowres.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/tests/kms_plane_lowres.c b/tests/kms_pl

[Intel-gfx] [PATCH i-g-t v3 26/33] tests/kms_rotation_crc: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_rotation_crc.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/tests/kms_rotatio

[Intel-gfx] [PATCH i-g-t v3 21/33] tests/kms_plane_scaling: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_plane_scaling.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.

[Intel-gfx] [PATCH i-g-t v3 22/33] tests/kms_properties: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_properties.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_properties.c b/tests/kms_properties.c index 2650672d..

[Intel-gfx] [PATCH i-g-t v3 23/33] tests/kms_psr_sink_crc: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_psr_sink_crc.c | 52 +--- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/tests/kms_psr_sin

[Intel-gfx] [PATCH i-g-t v3 19/33] tests/kms_plane: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_plane.c | 96 ++- 1 file changed, 53 insertions(+), 43 deletions(-) diff --git a/tests/kms_plane.c

[Intel-gfx] [PATCH i-g-t v3 29/33] tests/kms_vblank: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_vblank.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c index 122fbc8f..0d250653 10064

[Intel-gfx] [PATCH i-g-t v3 30/33] tests/prime_mmap_kms: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/prime_mmap_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/prime_mmap_kms.c b/tests/prime_mmap_kms.c index a2f85fa7..e7cca5

[Intel-gfx] [PATCH i-g-t v3 33/33] lib/igt_kms: Remove code obsoleted by dyn n_planes implementation

2017-01-30 Thread Robert Foss
Due to the dyn n_planes implementation some attributes and functions were made obsolete and cand be removed. However to keep all of the tests building the obsolete code is removed after all of the tests have been made compatible with the dyn n_planes changes. Signed-off-by: Robert Foss Reviewed-

[Intel-gfx] [PATCH i-g-t v3 20/33] tests/kms_plane_multiple: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_plane_multiple.c | 232 - 1 file changed, 145 insertions(+), 87 deletions(-) diff --git a/tests/kms_plane_

[Intel-gfx] [PATCH i-g-t v3 28/33] tests/kms_universal_plane: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_universal_plane.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/kms_universal_plane.c b/tests/kms_univer

[Intel-gfx] [PATCH i-g-t v3 31/33] tests/kms_ccs: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_ccs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c index 047a3e87..11acda89 100644 --- a/t

[Intel-gfx] [PATCH i-g-t v3 17/33] tests/kms_panel_fitting: Add support for dynamic number of planes

2017-01-30 Thread Robert Foss
Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss Reviewed-by: Mika Kahola --- tests/kms_panel_fitting.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fittin

Re: [Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Maarten Lankhorst
Op 30-01-17 om 14:22 schreef Mika Kahola: > On Mon, 2017-01-30 at 13:43 +0100, Maarten Lankhorst wrote: >> Op 30-01-17 om 12:37 schreef Mika Kahola: >>> Validate atomic commit correctness before actual commit. >>> >>> For: VIZ-6956 >>> >>> v2: Add flag to toggle TEST_ONLY for atomic commit. >>>

Re: [Intel-gfx] [PATCH v2 2/3] pwm/core: Try to get the module from pwm_get

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 09:17, Thierry Reding wrote: On Sun, Jan 22, 2017 at 05:14:08PM +0100, Hans de Goede wrote: Add a module_name string to the pwm_lookup struct and if specified and pwmchip_find_by_name() does not find the pwmchip try calling request_module with the specified name. Signed-off-by:

[Intel-gfx] [PATCH v2 i-g-t] aubdump: support new ioctl

2017-01-30 Thread Lionel Landwerlin
Otherwise we won't log anything with OpenGL applications using a recent Mesa driver. v2: This requires updated uapi headers, hence the libdrm dependency bump (Petri) Signed-off-by: Lionel Landwerlin --- configure.ac| 4 ++-- tools/aubdump.c | 3 ++- 2 files changed, 4 insertions(+), 3 d

Re: [Intel-gfx] [PATCH v2 i-g-t] aubdump: support new ioctl

2017-01-30 Thread Chris Wilson
On Mon, Jan 30, 2017 at 02:20:47PM +, Lionel Landwerlin wrote: > Otherwise we won't log anything with OpenGL applications using a > recent Mesa driver. > > v2: This requires updated uapi headers, hence the libdrm dependency > bump (Petri) > > Signed-off-by: Lionel Landwerlin > --- > con

Re: [Intel-gfx] [PATCH 0/3] drm/i915: Handle hanging during nonblocking modeset correctly.

2017-01-30 Thread Maarten Lankhorst
Op 30-01-17 om 09:17 schreef Daniel Vetter: > On Fri, Jan 27, 2017 at 03:08:45PM +, Chris Wilson wrote: >> On Fri, Jan 27, 2017 at 03:58:08PM +0100, Daniel Vetter wrote: >>> On Fri, Jan 27, 2017 at 02:31:55PM +, Chris Wilson wrote: On Fri, Jan 27, 2017 at 03:21:29PM +0100, Daniel Vette

Re: [Intel-gfx] [PATCH] drm/i915: Create context desc template when context is created

2017-01-30 Thread Mika Kuoppala
Chris Wilson writes: > On Fri, Jan 27, 2017 at 03:03:09PM +0200, Mika Kuoppala wrote: >> Move the invariant parts of context desc setup from execlist init >> to context creation. This is advantageous when we need to >> create different templates based on the context parametrization, >> ie. for sv

Re: [Intel-gfx] [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM, Ville Syrjälä wrote: On Mon, Jan 23, 2017 at 10:09:58PM +0100, Hans de Goede wrote: Make sure the P-Unit o

Re: [Intel-gfx] [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Ville Syrjälä
On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: > Hi, > > On 30-01-17 14:10, Ville Syrjälä wrote: > > On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 01/28/2017 05:25 PM, Hans de Goede wrote: > >>> Hi, > >>> > >>> On 01/27/2017 02:51 PM, Ville Sy

[Intel-gfx] [PATCH i-g-t v1] lib/drmtest: Add comment explaining DRIVER_ANY excluding DRIVER_VGEM

2017-01-30 Thread Robert Foss
Signed-off-by: Robert Foss --- lib/drmtest.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/drmtest.h b/lib/drmtest.h index 19d4bd19..c9c019c0 100644 --- a/lib/drmtest.h +++ b/lib/drmtest.h @@ -42,8 +42,15 @@ #define DRIVER_VC4 (1 << 1) #define DRIVER_VGEM(1 << 2) #defi

[Intel-gfx] [PATCH] drm/i915: Skip modeset locking when atomic pageflips are used.

2017-01-30 Thread Maarten Lankhorst
With the atomic helper for pageflips there are no CS flips when that require resetting, so on most platforms we can completely skip the locking. Because we may end up reverting the page_flip patch add an explicit function pointer check so that if someone reverts the page flip patch there will not

Re: [Intel-gfx] [PATCH v2] drm/i915: Record more information about the hanging contexts

2017-01-30 Thread Mika Kuoppala
Chris Wilson writes: > Include extra information such as the user_handle and hw_id so that > userspace can identify which of their contexts hung, useful if they are > performing self-diagnositics. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings

2017-01-30 Thread Hans de Goede
Hi, On 30-01-17 16:11, Ville Syrjälä wrote: On Mon, Jan 30, 2017 at 04:02:19PM +0100, Hans de Goede wrote: Hi, On 30-01-17 14:10, Ville Syrjälä wrote: On Sat, Jan 28, 2017 at 06:18:45PM +0100, Hans de Goede wrote: Hi, On 01/28/2017 05:25 PM, Hans de Goede wrote: Hi, On 01/27/2017 02:51 PM

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Improve handling of OA tail race (rev2)

2017-01-30 Thread Patchwork
== Series Details == Series: drm/i915/perf: Improve handling of OA tail race (rev2) URL : https://patchwork.freedesktop.org/series/18448/ State : success == Summary == Series 18448v2 drm/i915/perf: Improve handling of OA tail race https://patchwork.freedesktop.org/api/1.0/series/18448/revision

  1   2   >