[Intel-gfx] ✗ Fi.CI.BAT: failure for Try to fix MST regression with DDI IO power domains

2017-02-27 Thread Patchwork
== Series Details == Series: Try to fix MST regression with DDI IO power domains URL : https://patchwork.freedesktop.org/series/20345/ State : failure == Summary == Series 20345v1 Try to fix MST regression with DDI IO power domains https://patchwork.freedesktop.org/api/1.0/series/20345/revisio

Re: [Intel-gfx] [PATCH] drm/i915: Consolidate reporting of "missed breadcrumbs"

2017-02-27 Thread Tvrtko Ursulin
On 27/02/2017 23:41, Chris Wilson wrote: Move the setting of gpu_error->missed_irq_ring bit to a common function so that we can get the debug logging for either path. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 15 --- 1 file chan

Re: [Intel-gfx] [PATCH] drm/i915: Only enable DDI IO power domains after enabling DPLL

2017-02-27 Thread Ander Conselvan De Oliveira
On Mon, 2017-02-27 at 22:38 +0200, Ville Syrjälä wrote: > On Fri, Feb 24, 2017 at 04:19:59PM +0200, Ander Conselvan de Oliveira wrote: > > According to bspec, the DDI IO power domains should be enabled after > > enabling the DPLL and mapping it to the DDI. The current order doesn't > > seem to crea

[Intel-gfx] [PATCH 1/2] drm/i915: Enable DDI IO power domains in the DP MST path

2017-02-27 Thread Ander Conselvan de Oliveira
Commit 62b695662a24 ("drm/i915: Only enable DDI IO power domains after enabling DPLL") changed how the DDI IO power domains get enabled, but neglected the need to enable those domains when enabling a DP connector with MST enabled, leading to Kernel panic - not syncing: Timeout: Not all CPUs en

[Intel-gfx] [PATCH 2/2] drm/i915: Remove duplicate DDI enabling logic from MST path

2017-02-27 Thread Ander Conselvan de Oliveira
The logic to enable a DDI in intel_mst_pre_enable_dp() is essentially the same as in intel_ddi_pre_enable_dp(). So reuse the latter function by calling the post_disable hook on the intel_dig_port instead of duplicating that code. Cc: Ville Syrjälä Signed-off-by: Ander Conselvan de Oliveira ---

[Intel-gfx] [PATCH 0/2] Try to fix MST regression with DDI IO power domains

2017-02-27 Thread Ander Conselvan de Oliveira
Hi, Commit 62b695662a24 ("drm/i915: Only enable DDI IO power domains after enabling DPLL") seems to have broken MST. Here's an untested fix (I don't have the right hardware to test this at the moment). Thanks, Ander Ander Conselvan de Oliveira (2): drm/i915: Enable DDI IO power domains in the

Re: [Intel-gfx] [PATCH] drm/915/glk: Enable pooled EUs for Geminilake

2017-02-27 Thread Yang, Rong R
We suggest GLK could disable pooled EUs for 2x6 configurations too. As I understand, 2x6 a pool must consist of a complete subslice, 12EUs, right? If so, only 64K SLM are valid, I am afraid it may affect some case's performance. > -Original Message- > From: Conselvan De Oliveira, Ander >

Re: [Intel-gfx] [PATCH 01/15] drm/i915: Copy user requested buffers into the error state

2017-02-27 Thread Ben Widawsky
On 17-02-23 16:18:16, Chris Wilson wrote: Introduce a new execobject.flag (EXEC_OBJECT_CAPTURE) that userspace may use to indicate that it wants the contents of this buffer preserved in the error state (/sys/class/drm/cardN/error) following a GPU hang involving this batch. Use this at your discr

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Implement .get_format_info() hook for CCS

2017-02-27 Thread Ben Widawsky
On 17-02-27 17:13:41, Ville Syrjälä wrote: On Sun, Feb 26, 2017 at 02:41:50PM -0800, Chad Versace wrote: On Wed 04 Jan 2017, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > SKL+ display engine can scan out certain kinds of compressed surfaces > produced by the render engine. This

Re: [Intel-gfx] [PATCH v2] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-02-27 Thread Xu, Terrence
>On 02/27/2017 10:13 AM, Xu, Terrence wrote: >> [Xu, Terrence] Yes the root is needed for all our "echo" related commands, >can I suppose the case is running under root privilege? Or need to return >"skip" when it is not under root privilege? >> > >Right, seems I was a bit confused there and there

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force uncached PPAT for debugging purposes.

2017-02-27 Thread Patchwork
== Series Details == Series: drm/i915: Force uncached PPAT for debugging purposes. URL : https://patchwork.freedesktop.org/series/20334/ State : success == Summary == Series 20334v1 drm/i915: Force uncached PPAT for debugging purposes. https://patchwork.freedesktop.org/api/1.0/series/20334/rev

[Intel-gfx] [PATCH 2/2] gpu: drm: Convert printk(KERN_ to pr_

2017-02-27 Thread Joe Perches
Use a more common logging style. Miscellanea: o Coalesce formats and realign arguments o Neaten a few macros now using pr_ Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c | 4 +- drivers/gpu/drm/amd/

[Intel-gfx] [PATCH 0/2] gpu: drm: Use pr_cont and neaten logging

2017-02-27 Thread Joe Perches
Joe Perches (2): drm: Use pr_cont where appropriate gpu: drm: Convert printk(KERN_ to pr_ drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 +- drivers/gpu/drm/amd/amd

Re: [Intel-gfx] [PATCH] drm/i915: Force uncached PPAT for debugging purposes.

2017-02-27 Thread Ben Widawsky
On 17-02-27 17:12:07, Rodrigo Vivi wrote: Many screen corruptions and hangs in the past were somehow related to the caches. In many situations forcing the uncached was useful at least to narrow down the issue by confirming it was cache related. Instead of having to hardcode it everytime that we

[Intel-gfx] [PATCH] drm/i915: Force uncached PPAT for debugging purposes.

2017-02-27 Thread Rodrigo Vivi
Many screen corruptions and hangs in the past were somehow related to the caches. In many situations forcing the uncached was useful at least to narrow down the issue by confirming it was cache related. Instead of having to hardcode it everytime that we suspect on this table let's provide a mechan

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Consolidate reporting of "missed breadcrumbs"

2017-02-27 Thread Patchwork
== Series Details == Series: drm/i915: Consolidate reporting of "missed breadcrumbs" URL : https://patchwork.freedesktop.org/series/20330/ State : failure == Summary == Series 20330v1 drm/i915: Consolidate reporting of "missed breadcrumbs" https://patchwork.freedesktop.org/api/1.0/series/20330

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Suppress context restore w/a when using MI_RESTORE_INHIBIT

2017-02-27 Thread Chris Wilson
On Fri, Feb 24, 2017 at 12:45:54PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > If we are setting the context and do inhibit the restoration from the > > context image, also forgo applying the set-context w/a. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/i915

[Intel-gfx] [PATCH] drm/i915: Consolidate reporting of "missed breadcrumbs"

2017-02-27 Thread Chris Wilson
Move the setting of gpu_error->missed_irq_ring bit to a common function so that we can get the debug logging for either path. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoiding recursing on ww_mutex inside shrinker

2017-02-27 Thread Patchwork
== Series Details == Series: drm/i915: Avoiding recursing on ww_mutex inside shrinker URL : https://patchwork.freedesktop.org/series/20328/ State : failure == Summary == Series 20328v1 drm/i915: Avoiding recursing on ww_mutex inside shrinker https://patchwork.freedesktop.org/api/1.0/series/203

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Takashi Iwai
On Mon, 27 Feb 2017 22:27:58 +0100, Rafael J. Wysocki wrote: > > On Mon, Feb 27, 2017 at 3:40 PM, Takashi Iwai wrote: > > On Mon, 27 Feb 2017 15:25:32 +0100, > > Hans de Goede wrote: > >> > >> Hi, > >> > >> On 27-02-17 14:30, Rafael J. Wysocki wrote: > >> > +Mika & Andy > >> > > >> > On Saturday,

[Intel-gfx] [PATCH] drm/i915: Avoiding recursing on ww_mutex inside shrinker

2017-02-27 Thread Chris Wilson
We have to avoid taking ww_mutex inside the shrinker as we use it as a plain mutex type and so need to avoid recursive deadlocks: [ 602.771969] = [ 602.771970] [ INFO: inconsistent lock state ] [ 602.771973] 4.10.0gpudebug+ #122 Not tainted [ 602.771974] ---

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: Report both waiters and success from intel_engine_wakeup()

2017-02-27 Thread Chris Wilson
On Mon, Feb 27, 2017 at 09:22:31PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/4] drm/i915: Report both waiters and > success from intel_engine_wakeup() > URL : https://patchwork.freedesktop.org/series/20325/ > State : success > > == Summary == > > Se

Re: [Intel-gfx] [PATCH resend 11/15] drm/i915/dsi: Group MIPI_SEQ_BACKLIGHT_ON/OFF with panel_[en|dis]able_backlight

2017-02-27 Thread Hans de Goede
Hi, On 27-02-17 18:06, Bob Paauwe wrote: On Sat, 25 Feb 2017 11:37:50 +0100 Hans de Goede wrote: Hi, On 24-02-17 18:00, Bob Paauwe wrote: On Mon, 20 Feb 2017 15:08:41 +0100 Hans de Goede wrote: Execute the MIPI_SEQ_BACKLIGHT_ON/OFF VBT sequences at the same time as we call intel_panel_en

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Rafael J. Wysocki
On Mon, Feb 27, 2017 at 10:58 PM, Hans de Goede wrote: > Hi, > > > On 27-02-17 22:49, Rafael J. Wysocki wrote: >> >> On Mon, Feb 27, 2017 at 10:29 PM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> >>> On 27-02-17 22:25, Rafael J. Wysocki wrote: On Mon, Feb 27, 2017 at 3:25 PM, Hans d

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Hans de Goede
Hi, On 27-02-17 22:49, Rafael J. Wysocki wrote: On Mon, Feb 27, 2017 at 10:29 PM, Hans de Goede wrote: Hi, On 27-02-17 22:25, Rafael J. Wysocki wrote: On Mon, Feb 27, 2017 at 3:25 PM, Hans de Goede wrote: Hi, On 27-02-17 14:30, Rafael J. Wysocki wrote: +Mika & Andy On Saturday, Fe

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Rafael J. Wysocki
On Mon, Feb 27, 2017 at 10:29 PM, Hans de Goede wrote: > Hi, > > > On 27-02-17 22:25, Rafael J. Wysocki wrote: >> >> On Mon, Feb 27, 2017 at 3:25 PM, Hans de Goede >> wrote: >>> >>> Hi, >>> >>> >>> On 27-02-17 14:30, Rafael J. Wysocki wrote: +Mika & Andy On Saturday, Febr

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Hans de Goede
Hi, On 27-02-17 22:25, Rafael J. Wysocki wrote: On Mon, Feb 27, 2017 at 3:25 PM, Hans de Goede wrote: Hi, On 27-02-17 14:30, Rafael J. Wysocki wrote: +Mika & Andy On Saturday, February 25, 2017 07:23:28 PM Hans de Goede wrote: Several cherrytrail devices (all of which ship with windows

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Rafael J. Wysocki
On Mon, Feb 27, 2017 at 3:40 PM, Takashi Iwai wrote: > On Mon, 27 Feb 2017 15:25:32 +0100, > Hans de Goede wrote: >> >> Hi, >> >> On 27-02-17 14:30, Rafael J. Wysocki wrote: >> > +Mika & Andy >> > >> > On Saturday, February 25, 2017 07:23:28 PM Hans de Goede wrote: >> >> Several cherrytrail device

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Rafael J. Wysocki
On Mon, Feb 27, 2017 at 3:25 PM, Hans de Goede wrote: > Hi, > > > On 27-02-17 14:30, Rafael J. Wysocki wrote: >> >> +Mika & Andy >> >> On Saturday, February 25, 2017 07:23:28 PM Hans de Goede wrote: >>> >>> Several cherrytrail devices (all of which ship with windows 10) hide the >>> lpss pwm contr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: Report both waiters and success from intel_engine_wakeup()

2017-02-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Report both waiters and success from intel_engine_wakeup() URL : https://patchwork.freedesktop.org/series/20325/ State : success == Summary == Series 20325v1 Series without cover letter https://patchwork.freedesktop.org/api/

[Intel-gfx] [CI 2/4] drm/i915: Signal first fence from irq handler if complete

2017-02-27 Thread Chris Wilson
As execlists and other non-semaphore multi-engine devices coordinate between engines using interrupts, we can shave off a few 10s of microsecond of scheduling latency by doing the fence signaling from the interrupt as opposed to a RT kthread. (Realistically the delay adds about 1% to an individual

[Intel-gfx] [CI 4/4] drm/i915: Delay disabling the user interrupt for breadcrumbs

2017-02-27 Thread Chris Wilson
A significant cost in setting up a wait is the overhead of enabling the interrupt. As we disable the interrupt whenever the queue of waiters is empty, if we are frequently waiting on alternating batches, we end up re-enabling the interrupt on a frequent basis. We do want to disable the interrupt du

[Intel-gfx] [CI 1/4] drm/i915: Report both waiters and success from intel_engine_wakeup()

2017-02-27 Thread Chris Wilson
The two users of the return value from intel_engine_wakeup() are expecting different results. In the breadcrumbs hangcheck, we are using it to determine whether wake_up_process() detected the waiter was currently running (and if so we presume that it hasn't yet missed the interrupt). However, in th

[Intel-gfx] [CI 3/4] drm/i915: Defer enabling hangcheck to the first fake breadcrumb interrupt

2017-02-27 Thread Chris Wilson
By deferring hangcheck to the fake breadcrumb interrupt, we can simply the enabling procedure slightly - as by enabling the fake, we then enable the hangcheck. By always enabling the hangcheck from each fake interrupt (it will be a no-op for an already queued hangcheck), it will make restoring the

Re: [Intel-gfx] [PATCH] drm/i915: Only enable DDI IO power domains after enabling DPLL

2017-02-27 Thread Ville Syrjälä
On Fri, Feb 24, 2017 at 04:19:59PM +0200, Ander Conselvan de Oliveira wrote: > According to bspec, the DDI IO power domains should be enabled after > enabling the DPLL and mapping it to the DDI. The current order doesn't > seem to create problems with Skylake and Kabylake, but causes enable > timeo

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: Delay disabling the user interrupt for breadcrumbs

2017-02-27 Thread Tvrtko Ursulin
On 27/02/2017 14:13, Chris Wilson wrote: On Mon, Feb 27, 2017 at 02:06:58PM +, Chris Wilson wrote: On Mon, Feb 27, 2017 at 01:57:35PM +, Tvrtko Ursulin wrote: On 27/02/2017 13:24, Chris Wilson wrote: if (b->hangcheck_interrupts != atomic_read(&engine->irq_count)) { @@ -67,7 +

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-27 Thread Pandiyan, Dhinakaran
On Sun, 2017-02-26 at 20:57 +0100, Daniel Vetter wrote: > On Wed, Feb 22, 2017 at 12:01:12AM +, Pandiyan, Dhinakaran wrote: > > On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: > > > > > > On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: > > > > On Wed, 2017-02-15 at 16:53 +0530, Arc

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

2017-02-27 Thread Patchwork
== Series Details == Series: drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058 URL : https://patchwork.freedesktop.org/series/19959/ State : success == Summary == Series 19959v1 drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058 https://patchwork.freedesktop.org/api/1.0/se

Re: [Intel-gfx] [PATCH] drm/i915/dsi: VLV/CHT Only wait for LP00 on MIPI PORT A

2017-02-27 Thread Bob Paauwe
On Mon, 27 Feb 2017 11:22:32 +0100 Hans de Goede wrote: > On some devices only MIPI PORT C is used, in this case checking the > MIPI PORT A CTRL AFE_LATCHOUT bit (there is no such bit for PORT C > on VLV/CHT) will result in false positive "DSI LP not going Low" errors > as this checks the PORT A

Re: [Intel-gfx] [PATCH resend 13/15] drm/i915/dsi: Execute MIPI_SEQ_TEAR_OFF from intel_dsi_post_disable

2017-02-27 Thread Jani Nikula
On Sat, 25 Feb 2017, Hans de Goede wrote: > Hi, > > On 24-02-17 18:02, Bob Paauwe wrote: >> On Mon, 20 Feb 2017 15:08:43 +0100 >> Hans de Goede wrote: >> >>> For v3 VBTs we should call MIPI_SEQ_TEAR_OFF before >>> MIPI_SEQ_DISPLAY_OFF, for non v3 VBTs this is a nop. >> >> Isn't this only for comm

Re: [Intel-gfx] [PATCH resend 12/15] drm/i915/dsi: Document always using v3 SHUTDOWN / MIPI_SEQ_DISPLAY_OFF order

2017-02-27 Thread Jani Nikula
On Mon, 27 Feb 2017, Bob Paauwe wrote: > On Sat, 25 Feb 2017 11:42:09 +0100 > Hans de Goede wrote: > >> Hi, >> >> On 24-02-17 18:02, Bob Paauwe wrote: >> > On Mon, 20 Feb 2017 15:08:42 +0100 >> > Hans de Goede wrote: >> > >> >> According to the spec for v2 VBTs we should call MIPI_SEQ_DISPLAY

Re: [Intel-gfx] [PATCH resend 11/15] drm/i915/dsi: Group MIPI_SEQ_BACKLIGHT_ON/OFF with panel_[en|dis]able_backlight

2017-02-27 Thread Jani Nikula
On Mon, 27 Feb 2017, Bob Paauwe wrote: > On Sat, 25 Feb 2017 11:37:50 +0100 > Hans de Goede wrote: > >> Hi, >> >> On 24-02-17 18:00, Bob Paauwe wrote: >> > On Mon, 20 Feb 2017 15:08:41 +0100 >> > Hans de Goede wrote: >> > >> >> Execute the MIPI_SEQ_BACKLIGHT_ON/OFF VBT sequences at the same t

Re: [Intel-gfx] [PATCH resend 14/15] drm/i915/dsi: Call MIPI_SEQ_TEAR_ON and DISPLAY_ON for cmd-mode (untested)

2017-02-27 Thread Bob Paauwe
On Sat, 25 Feb 2017 11:47:32 +0100 Hans de Goede wrote: > Hi, > > On 24-02-17 18:02, Bob Paauwe wrote: > > On Mon, 20 Feb 2017 15:08:44 +0100 > > Hans de Goede wrote: > > > >> According to the spec we should call MIPI_SEQ_TEAR_ON and DISPLAY_ON > >> on enable for cmd-mode, just like we alread

Re: [Intel-gfx] [PATCH] drm/i915: Distinguish between timeout and error in sideband transactions

2017-02-27 Thread Chris Wilson
On Mon, Feb 27, 2017 at 06:34:26PM +0200, Jani Nikula wrote: > On Thu, 23 Feb 2017, Chris Wilson wrote: > > After initiating a sideband transaction, we only want to wait for the > > transaction to become idle. If, as we are, we wait for both the busy > > and error flag to clear, if an error is rai

Re: [Intel-gfx] [PATCH resend 15/15] drm/i915/dsi: Skip delays for v3 VBTs in vid-mode

2017-02-27 Thread Bob Paauwe
On Sat, 25 Feb 2017 11:49:09 +0100 Hans de Goede wrote: > HI, > > On 24-02-17 18:02, Bob Paauwe wrote: > > On Mon, 20 Feb 2017 15:08:45 +0100 > > Hans de Goede wrote: > > > >> For v3 VBTs in vid-mode the delays are part of the VBT sequences, so > >> we should not also delay ourselves otherwis

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Stop using RP_DOWN_EI on Baytrail

2017-02-27 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Stop using RP_DOWN_EI on Baytrail URL : https://patchwork.freedesktop.org/series/20314/ State : success == Summary == Series 20314v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/20314/revisions/1/

Re: [Intel-gfx] [PATCH resend 12/15] drm/i915/dsi: Document always using v3 SHUTDOWN / MIPI_SEQ_DISPLAY_OFF order

2017-02-27 Thread Bob Paauwe
On Sat, 25 Feb 2017 11:42:09 +0100 Hans de Goede wrote: > Hi, > > On 24-02-17 18:02, Bob Paauwe wrote: > > On Mon, 20 Feb 2017 15:08:42 +0100 > > Hans de Goede wrote: > > > >> According to the spec for v2 VBTs we should call MIPI_SEQ_DISPLAY_OFF > >> before sending SHUTDOWN, where as for v3 V

Re: [Intel-gfx] [PATCH resend 11/15] drm/i915/dsi: Group MIPI_SEQ_BACKLIGHT_ON/OFF with panel_[en|dis]able_backlight

2017-02-27 Thread Bob Paauwe
On Sat, 25 Feb 2017 11:37:50 +0100 Hans de Goede wrote: > Hi, > > On 24-02-17 18:00, Bob Paauwe wrote: > > On Mon, 20 Feb 2017 15:08:41 +0100 > > Hans de Goede wrote: > > > >> Execute the MIPI_SEQ_BACKLIGHT_ON/OFF VBT sequences at the same time as > >> we call intel_panel_enable_backlight() /

Re: [Intel-gfx] [PATCH resend 07/15] drm/i915/dsi: Drop bogus MIPI_SEQ_ASSERT_RESET before POWER_ON

2017-02-27 Thread Bob Paauwe
On Sat, 25 Feb 2017 11:35:03 +0100 Hans de Goede wrote: > Hi, > > On 24-02-17 18:00, Bob Paauwe wrote: > > On Mon, 20 Feb 2017 15:08:37 +0100 > > Hans de Goede wrote: > > > >> MIPI_SEQ_ASSERT_RESET before POWER_ON is not necessary for 2 reasons: > >> 1) The reset should already be asserted be

Re: [Intel-gfx] [PATCH v2 4/4] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-27 Thread Ville Syrjälä
On Mon, Feb 27, 2017 at 05:19:21PM +0100, Daniel Vetter wrote: > On Mon, Feb 27, 2017 at 05:09:44PM +0200, Ville Syrjälä wrote: > > On Sun, Feb 26, 2017 at 10:22:42PM +0100, Daniel Vetter wrote: > > > On Fri, Feb 17, 2017 at 05:20:54PM +0200, Jani Nikula wrote: > > > > Handle debugfs override edid

Re: [Intel-gfx] [PATCH] drm/i915: Distinguish between timeout and error in sideband transactions

2017-02-27 Thread Jani Nikula
On Thu, 23 Feb 2017, Chris Wilson wrote: > After initiating a sideband transaction, we only want to wait for the > transaction to become idle. If, as we are, we wait for both the busy > and error flag to clear, if an error is raised we just spin until the > timeout. Once the hw is idle, we can the

Re: [Intel-gfx] [PATCH v2 4/4] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-27 Thread Daniel Vetter
On Mon, Feb 27, 2017 at 05:09:44PM +0200, Ville Syrjälä wrote: > On Sun, Feb 26, 2017 at 10:22:42PM +0100, Daniel Vetter wrote: > > On Fri, Feb 17, 2017 at 05:20:54PM +0200, Jani Nikula wrote: > > > Handle debugfs override edid and firmware edid at the low level to > > > transparently and completel

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915: Remove redundant TLB invalidate on switching contexts

2017-02-27 Thread Chris Wilson
On Mon, Feb 27, 2017 at 03:52:12PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/3] drm/i915: Remove redundant TLB > invalidate on switching contexts > URL : https://patchwork.freedesktop.org/series/20313/ > State : success > > == Summary == > > Series

[Intel-gfx] [PULL] drm-misc-next-fixes

2017-02-27 Thread Daniel Vetter
Hi Dave, drm-misc-next-fixes-2017-02-27: Misc fixes for the 4.11 merge window. - vmwgfx drm_control node compat patch - rockchip&zte fixes - compat32 support for dma-buf ioctl (cc: stable ofc, since this is a massive fumble. oops) Nothing major outstanding afaik. Cheers, Daniel The followin

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915: Remove redundant TLB invalidate on switching contexts

2017-02-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Remove redundant TLB invalidate on switching contexts URL : https://patchwork.freedesktop.org/series/20313/ State : success == Summary == Series 20313v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/s

Re: [Intel-gfx] [PATCH 07/10] drm/i915/guc: Simplify intel_guc_init_hw()

2017-02-27 Thread Arkadiusz Hiler
On Fri, Feb 24, 2017 at 06:26:10PM +0100, Michal Wajdeczko wrote: > On Fri, Feb 24, 2017 at 04:40:01PM +0100, Arkadiusz Hiler wrote: > > Current version of intel_guc_init_hw() does a lot: > > - cares about submission > > - loads huc > > - implement WA > > > > This change offloads some of the lo

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/3] drm/i915: Start splitting out i915_gem_object routines

2017-02-27 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Start splitting out i915_gem_object routines URL : https://patchwork.freedesktop.org/series/20312/ State : warning == Summary == Series 20312v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/20312/

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Implement .get_format_info() hook for CCS

2017-02-27 Thread Ville Syrjälä
On Sun, Feb 26, 2017 at 02:41:50PM -0800, Chad Versace wrote: > On Wed 04 Jan 2017, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > SKL+ display engine can scan out certain kinds of compressed surfaces > > produced by the render engine. This involved telling the display engin

Re: [Intel-gfx] [PATCH v2 4/4] drm: handle override edid and firmware EDID at drm_do_get_edid() level

2017-02-27 Thread Ville Syrjälä
On Sun, Feb 26, 2017 at 10:22:42PM +0100, Daniel Vetter wrote: > On Fri, Feb 17, 2017 at 05:20:54PM +0200, Jani Nikula wrote: > > Handle debugfs override edid and firmware edid at the low level to > > transparently and completely replace the real edid. Previously, we > > practically only used the m

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v5,1/4] drm/i915: Report both waiters and success from intel_engine_wakeup()

2017-02-27 Thread Chris Wilson
On Mon, Feb 27, 2017 at 02:52:27PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [v5,1/4] drm/i915: Report both waiters and > success from intel_engine_wakeup() > URL : https://patchwork.freedesktop.org/series/20310/ > State : failure > > == Summary == > > Se

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v5,1/4] drm/i915: Report both waiters and success from intel_engine_wakeup()

2017-02-27 Thread Patchwork
== Series Details == Series: series starting with [v5,1/4] drm/i915: Report both waiters and success from intel_engine_wakeup() URL : https://patchwork.freedesktop.org/series/20310/ State : failure == Summary == Series 20310v1 Series without cover letter https://patchwork.freedesktop.org/api/

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Takashi Iwai
On Mon, 27 Feb 2017 15:25:32 +0100, Hans de Goede wrote: > > Hi, > > On 27-02-17 14:30, Rafael J. Wysocki wrote: > > +Mika & Andy > > > > On Saturday, February 25, 2017 07:23:28 PM Hans de Goede wrote: > >> Several cherrytrail devices (all of which ship with windows 10) hide the > >> lpss pwm con

Re: [Intel-gfx] [PATCH] drm/i915: Remove temporary allocation of dma addresses when rotating

2017-02-27 Thread Tvrtko Ursulin
On 27/02/2017 10:21, Chris Wilson wrote: On Mon, Feb 27, 2017 at 10:14:12AM +, Tvrtko Ursulin wrote: On 27/02/2017 10:06, Chris Wilson wrote: On Mon, Feb 27, 2017 at 09:55:10AM +, Tvrtko Ursulin wrote: On 22/02/2017 08:44, Chris Wilson wrote: I also think that's an argument for imp

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Hans de Goede
Hi, On 27-02-17 14:30, Rafael J. Wysocki wrote: +Mika & Andy On Saturday, February 25, 2017 07:23:28 PM Hans de Goede wrote: Several cherrytrail devices (all of which ship with windows 10) hide the lpss pwm controller in ACPI, typically the _STA method looks like this: Method (_STA, 0, No

[Intel-gfx] [PATCH 1/2] drm/i915: Stop using RP_DOWN_EI on Baytrail

2017-02-27 Thread Chris Wilson
On Baytrail, we manually calculate busyness over the evaluation interval to avoid issues with miscaluations with RC6 enabled. However, it turns out that the DOWN_EI interrupt generator is completely bust - it operates in two modes, continuous or never. Neither of which are conducive to good behavio

[Intel-gfx] [PATCH 2/2] drm/i915: Defer unmasking RPS interrupts until after making adjustments

2017-02-27 Thread Chris Wilson
To make our adjustments to RPS requires taking a mutex and potentially sleeping for an unknown duration - until we have completed our adjustments further RPS interrupts are immaterial (they are based on stale thresholds) and we can safely ignore them. Signed-off-by: Chris Wilson Cc: Mika Kuoppala

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: Delay disabling the user interrupt for breadcrumbs

2017-02-27 Thread Chris Wilson
On Mon, Feb 27, 2017 at 02:06:58PM +, Chris Wilson wrote: > On Mon, Feb 27, 2017 at 01:57:35PM +, Tvrtko Ursulin wrote: > > > > On 27/02/2017 13:24, Chris Wilson wrote: > > > if (b->hangcheck_interrupts != atomic_read(&engine->irq_count)) { > > >@@ -67,7 +76,7 @@ static void intel_breadc

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: Delay disabling the user interrupt for breadcrumbs

2017-02-27 Thread Chris Wilson
On Mon, Feb 27, 2017 at 01:57:35PM +, Tvrtko Ursulin wrote: > > On 27/02/2017 13:24, Chris Wilson wrote: > > if (b->hangcheck_interrupts != atomic_read(&engine->irq_count)) { > >@@ -67,7 +76,7 @@ static void intel_breadcrumbs_hangcheck(unsigned long data) > > * to process the pending

[Intel-gfx] ✗ Fi.CI.BAT: failure for GuC Scrub vol. 1 (rev7)

2017-02-27 Thread Patchwork
== Series Details == Series: GuC Scrub vol. 1 (rev7) URL : https://patchwork.freedesktop.org/series/16856/ State : failure == Summary == In file included from drivers/gpu/drm/i915/i915_drv.h:60:0, from drivers/gpu/drm/i915/i915_gem_execbuffer.c:37: drivers/gpu/drm/i915/intel_u

[Intel-gfx] [CI 3/3] drm/i915: Reduce context alignment

2017-02-27 Thread Chris Wilson
No hardware was ever shipped that needed more than 4096 byte alignment and future hardware will not use this legacy path. So reduce the alignment to make it easier and quicker to launch workloads. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_context.c

[Intel-gfx] [CI 2/3] drm/i915: Remove redundant TLB invalidate on switching ppgtt

2017-02-27 Thread Chris Wilson
We are required to reload the TLBs around ppgtt switches. However, we already do an unconditional TLB invalidate before every batch and a flush afterwards, so this condition is already satisfied without extra flushes around the LRI instructions. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuopp

[Intel-gfx] [CI 1/3] drm/i915: Remove redundant TLB invalidate on switching contexts

2017-02-27 Thread Chris Wilson
We are required to reload the TLBs around context switches (MI_SET_CONTEXT specifically) and the recommendation is do that before the MI_SET_CONTEXT so that it is serialised with the switch and not forgotten: [DevSNB] If Flush TLB invalidation Mode is enabled it’s the driver’s responsibility to in

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: Delay disabling the user interrupt for breadcrumbs

2017-02-27 Thread Tvrtko Ursulin
On 27/02/2017 13:24, Chris Wilson wrote: A significant cost in setting up a wait is the overhead of enabling the interrupt. As we disable the interrupt whenever the queue of waiters is empty, if we are frequently waiting on alternating batches, we end up re-enabling the interrupt on a frequent b

Re: [Intel-gfx] [PATCH v2] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-02-27 Thread Petri Latvala
On 02/27/2017 10:13 AM, Xu, Terrence wrote: [Xu, Terrence] Yes the root is needed for all our "echo" related commands, can I suppose the case is running under root privilege? Or need to return "skip" when it is not under root privilege? Right, seems I was a bit confused there and there are

Re: [Intel-gfx] [PATCH] ACPI / bus: Introduce a list of ids for "always present" devices

2017-02-27 Thread Rafael J. Wysocki
+Mika & Andy On Saturday, February 25, 2017 07:23:28 PM Hans de Goede wrote: > Several cherrytrail devices (all of which ship with windows 10) hide the > lpss pwm controller in ACPI, typically the _STA method looks like this: > > Method (_STA, 0, NotSerialized) // _STA: Status > { >

[Intel-gfx] [PATCH 1/3] drm/i915: Start splitting out i915_gem_object routines

2017-02-27 Thread Chris Wilson
To begin with move obj->mm related operations to i915_gem_object.c, in preparation for future tweaks. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.h| 107 -- drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [PATCH 2/3] drm/i915: Exercise backing storage of mock gem objects

2017-02-27 Thread Chris Wilson
Check that we can retrieve the right page for a random index, and that we can map the whole object. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_object.c | 1 + drivers/gpu/drm/i915/selftests/i915_gem_object.c | 405 + .../gpu/drm/i915/selftes

[Intel-gfx] [PATCH 3/3] drm/i915: Prepare for async get_pages

2017-02-27 Thread Chris Wilson
In the next patch, we will allow for obj->mm.__pages to be populated asynchronously. This means that simply acquiring a pages_pin_count is no longer sufficient to be sure the pages are there, we need to acquire the pin (to prevent the pages from disappearing again) and then wait for the completion.

[Intel-gfx] Start planning for handling async pages, binding, everything

2017-02-27 Thread Chris Wilson
Currently we have a heavyweight EAGAIN loop round tripping to userspace to handle asynchronous loading. However, we now have fences to handle asynchronous execution. Fun times ahead. For starters, let's move the current asynchronous get_pages onto a more secure footing. -Chris

Re: [Intel-gfx] [PATCH 10/10] drm/i915/uc: Add params for specifying firmware

2017-02-27 Thread Jani Nikula
On Mon, 27 Feb 2017, Joonas Lahtinen wrote: > On pe, 2017-02-24 at 16:40 +0100, Arkadiusz Hiler wrote: >> `guc_firmware_path` and `huc_firmware_path` module parameters are added. >> >> Using the parameter disabled version checks and loads desired firmware >> instead of the default one. >> >> Cc:

Re: [Intel-gfx] I915 dmesg warnings on Mac Mini, solo core edition

2017-02-27 Thread Jani Nikula
On Sun, 26 Feb 2017, Enrico Mioso wrote: > Hello. I am not using this computer actively and can't report easily > on the state of the screen. Still, I observed the following situation > in the system's dmesg: running the stock Archlinux Kernel. This is an > Apple MacMini system, booted via an EF

[Intel-gfx] [PATCH v5 2/4] drm/i915: Signal first fence from irq handler if complete

2017-02-27 Thread Chris Wilson
As execlists and other non-semaphore multi-engine devices coordinate between engines using interrupts, we can shave off a few 10s of microsecond of scheduling latency by doing the fence signaling from the interrupt as opposed to a RT kthread. (Realistically the delay adds about 1% to an individual

[Intel-gfx] [PATCH v5 1/4] drm/i915: Report both waiters and success from intel_engine_wakeup()

2017-02-27 Thread Chris Wilson
The two users of the return value from intel_engine_wakeup() are expecting different results. In the breadcrumbs hangcheck, we are using it to determine whether wake_up_process() detected the waiter was currently running (and if so we presume that it hasn't yet missed the interrupt). However, in th

[Intel-gfx] [PATCH v5 3/4] drm/i915: Defer enabling hangcheck to the first fake breadcrumb interrupt

2017-02-27 Thread Chris Wilson
By deferring hangcheck to the fake breadcrumb interrupt, we can simply the enabling procedure slightly - as by enabling the fake, we then enable the hangcheck. By always enabling the hangcheck from each fake interrupt (it will be a no-op for an already queued hangcheck), it will make restoring the

[Intel-gfx] [PATCH v5 4/4] drm/i915: Delay disabling the user interrupt for breadcrumbs

2017-02-27 Thread Chris Wilson
A significant cost in setting up a wait is the overhead of enabling the interrupt. As we disable the interrupt whenever the queue of waiters is empty, if we are frequently waiting on alternating batches, we end up re-enabling the interrupt on a frequent basis. We do want to disable the interrupt du

Re: [Intel-gfx] [PATCH] drm/i915: Avoid tweaking evaluation thresholds on Baytrail v3

2017-02-27 Thread Mika Kuoppala
Chris Wilson writes: > On Wed, Feb 15, 2017 at 03:52:59PM +0200, Mika Kuoppala wrote: >> Certain Baytrails, namely the 4 cpu core variants, have been >> plaqued by spurious system hangs, mostly occurring with light loads. >> >> Multiple bisects by various people point to a commit which changes t

Re: [Intel-gfx] [PATCH] drm/i915/skl: Add missing SKL ID

2017-02-27 Thread Mika Kuoppala
Michał Winiarski writes: > Used by production device: > Intel(R) Iris(TM) Graphics P555 > > Cc: > Cc: Mika Kuoppala > Cc: Rodrigo Vivi > Signed-off-by: Michał Winiarski > Reviewed-by: Rodrigo Vivi > Reviewed-by: Mika Kuoppala Pushed to dinq, thanks for patch and review. -Mika > --- >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915: Only unwind the local pgtable layer if empty

2017-02-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Only unwind the local pgtable layer if empty URL : https://patchwork.freedesktop.org/series/20303/ State : success == Summary == Series 20303v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/203

Re: [Intel-gfx] [PATCH] drm/i915: Remove temporary allocation of dma addresses when rotating

2017-02-27 Thread Joonas Lahtinen
On ma, 2017-02-27 at 10:21 +, Chris Wilson wrote: > On Mon, Feb 27, 2017 at 10:14:12AM +, Tvrtko Ursulin wrote: > > Perhaps you could say what kind of optimisation you have in mind to > > save me guessing? :) > > I was thinking you would like an inactivity timer. Or we could have a > separ

[Intel-gfx] [PATCH v5] drm/i915/guc: Extract param logic form guc_init_fw()

2017-02-27 Thread Arkadiusz Hiler
Let intel_guc_init_fw() focus on determining and fetching the correct firmware. This patch introduces intel_uc_sanitize_options() that is called from intel_sanitize_options(). Then, if we have GuC, we can call intel_guc_init_fw() conditionally and we do not have to do the internal checks. v2: fi

Re: [Intel-gfx] [PATCH 10/10] drm/i915/uc: Add params for specifying firmware

2017-02-27 Thread Joonas Lahtinen
On pe, 2017-02-24 at 16:40 +0100, Arkadiusz Hiler wrote: > `guc_firmware_path` and `huc_firmware_path` module parameters are added. > > Using the parameter disabled version checks and loads desired firmware > instead of the default one. > > Cc: Chris Wilson > Cc: Joonas Lahtinen > Cc: Michal Wi

[Intel-gfx] [PATCH v2] drm/i915/uc: Move intel_uc_fw_fetch() to intel_uc.c

2017-02-27 Thread Arkadiusz Hiler
The file fits better. Additionally rename it to intel_uc_prepare_fw(), as the function does more than simple fetch. v2: remove second declaration, reorder (M. Wajdeczko) Cc: Michal Wajdeczko Signed-off-by: Arkadiusz Hiler --- drivers/gpu/drm/i915/intel_guc_loader.c | 137 +

[Intel-gfx] [CI 3/3] drm/i915: Remove the vma from the drm_mm if binding fails

2017-02-27 Thread Chris Wilson
As we track whether a vma has been inserted into the drm_mm using the vma->flags, if we fail to bind the vma into the GTT we do not update those bits and will attempt to reinsert the vma into the drm_mm on future passes. To prevent that, we want to unwind i915_vma_insert() if we fail in our attempt

[Intel-gfx] [CI 2/3] drm/i915: Unwind vma->pages allocation upon failure

2017-02-27 Thread Chris Wilson
If we fail to allocate the ppgtt range after allocating the pages for the vma, we should unwind the local allocation before reporting back the failure. Fixes: ff685975d97f ("drm/i915: Move allocate_va_range to GTT") Signed-off-by: Chris Wilson Cc: Matthew Auld Reviewed-by: Matthew Auld --- dri

[Intel-gfx] [CI 1/3] drm/i915: Only unwind the local pgtable layer if empty

2017-02-27 Thread Chris Wilson
Only if we allocated the layer and the lower level failed should we remove this layer when unwinding. Otherwise we ignore the overlapping entries by overwriting the old layer with scratch. Fixes: c5d092a4293f ("drm/i915: Remove bitmap tracking for used-pml4") Fixes: e2b763caa6eb ("drm/i915: Remove

Re: [Intel-gfx] [PATCH 09/10] drm/i915/uc: Separate firmware selection and preparation

2017-02-27 Thread Joonas Lahtinen
On pe, 2017-02-24 at 16:40 +0100, Arkadiusz Hiler wrote: > intel_{h,g}uc_init_fw selects correct firmware and then triggers it's > preparation (fetch + initial parsing). > > This change separates out select steps, so those can be called by > the sanitize_options(). > > Then, during the init_fw()

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/skl: Add missing SKL ID (rev3)

2017-02-27 Thread Patchwork
== Series Details == Series: drm/i915/skl: Add missing SKL ID (rev3) URL : https://patchwork.freedesktop.org/series/3537/ State : success == Summary == Series 3537v3 drm/i915/skl: Add missing SKL ID https://patchwork.freedesktop.org/api/1.0/series/3537/revisions/3/mbox/ fi-bdw-5557u total

Re: [Intel-gfx] [PATCH 1/3] drm/i915/perf: improve invalid OA format debug message

2017-02-27 Thread Matthew Auld
On 22 February 2017 at 15:25, Robert Bragg wrote: > A minor improvement to debugging output > > Signed-off-by: Robert Bragg Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listi

Re: [Intel-gfx] [PATCH 05/10] drm/i915/uc: Introduce intel_uc_init_fw()

2017-02-27 Thread Joonas Lahtinen
On pe, 2017-02-24 at 16:39 +0100, Arkadiusz Hiler wrote: > Instead of calling intel_guc_init() and intel_huc_init() one by one this > patch introduces intel_uc_init_fw() function that calls them both. > > Called functions are renamed accordingly. > > Trying to have subject_verb_object ordering an

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Unwind vma->pages allocation upon failure

2017-02-27 Thread Matthew Auld
On 25 February 2017 at 23:25, Chris Wilson wrote: > If we fail to allocate the ppgtt range after allocating the pages for > the vma, we should unwind the local allocation before reporting back the > failure. > > Fixes: ff685975d97f ("drm/i915: Move allocate_va_range to GTT") > Signed-off-by: Chris

  1   2   >