[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Convert connector properties to atomic. (rev6)

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Convert connector properties to atomic. (rev6) URL : https://patchwork.freedesktop.org/series/22634/ State : warning == Summary == Series 22634v6 drm/i915: Convert connector properties to atomic. https://patchwork.freedesktop.org/api/1.0/series/22634/revi

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Stop pretending to mask/unmask LPE audio interrupts

2017-04-25 Thread Pierre-Louis Bossart
On 4/25/17 3:27 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä vlv_display_irq_postinstall() enables the LPE audio interrupts regardless of whether the LPE audio irq chip has masked/unmasked them. Also the irqchip masking/unmasking doesn't consider the state of the display power w

Re: [Intel-gfx] [alsa-devel] [PATCH 05/11] drm/i915: Replace tmds_clock_speed and link_rate with just ls_clock

2017-04-25 Thread Pierre-Louis Bossart
On 4/25/17 3:27 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä There's no need to distinguish between the DP link rate and HDMI TMDS clock for the purposes of the LPE audio. Both are actually the same thing more or less, which is the link symbol clock. So let's just call the thing

Re: [Intel-gfx] [alsa-devel] [PATCH 11/11] ALSA: x86: Register multiple PCM devices for the LPE audio card

2017-04-25 Thread Pierre-Louis Bossart
On 04/25/2017 03:27 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Now that everything is in place let's register a PCM device for each pipe of the display engine. This will make it possible to actually output audio to multiple displays at the same time. And it avoids modesets o

[Intel-gfx] [PATCH i-g-t 29/29] igt/perf: remove unused frequency functions

2017-04-25 Thread Lionel Landwerlin
Now that we've found that frequency changes happen mostly outside of our control and don't seem to be following our requests through sysfs, let's drop a bunch code/variables. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 83 +++- 1 fi

[Intel-gfx] [PATCH i-g-t 24/29] igt/perf: fix rc6 test

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg When measuring that rc6 doesn't happen, we need to do so after opening the OA stream. Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index

[Intel-gfx] [PATCH i-g-t 10/29] igt/perf: wrap emission of MI_REPORT_PERF_COUNT

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 44 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 600fa7d9..864c465c 100644 --- a/tests/perf.c +++ b

[Intel-gfx] [PATCH i-g-t 27/29] igt/perf: make buffer-fill more reliable

2017-04-25 Thread Lionel Landwerlin
Filling rate of the buffer must discard context switch reports as they do not depend upon the periodicity, instead they're a factor on the amount of different applications concurrently running on the system. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 113

[Intel-gfx] [PATCH i-g-t 19/29] igt/perf: update print_reports to print context ID

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index ab8db296..d057d943 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1215,6 +1215,9 @@ print_reports(uint32_t *

[Intel-gfx] [PATCH i-g-t 13/29] igt/perf: allow 10% margin matching oa/sysfs freq in test_oa_exponents

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index d47e45c8..c8092eaa 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -,6 +

[Intel-gfx] [PATCH i-g-t 26/29] igt/perf: make enable-disable more reliable

2017-04-25 Thread Lionel Landwerlin
Estimation of the amount of reports can only refer to periodic ones, as context switch reports completely depend on what happens on the system. Also generate some load to prevent clock frequency changes to impact our measurement. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 88 +++

[Intel-gfx] [PATCH i-g-t 06/29] igt/perf: fix a counter indexing

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 3eef82d2..5a6bd05a 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -863,17

[Intel-gfx] [PATCH i-g-t 21/29] igt/perf: make stream_fd a global variable

2017-04-25 Thread Lionel Landwerlin
When debugging unstable tests on new platforms we currently we don't cleanup everything well in between different tests. Since only a single OA stream fd can be opened at a time, having the stream_fd as a global variable helps us cleanup the state between tests. Signed-off-by: Lionel Landwerlin -

[Intel-gfx] [PATCH i-g-t 20/29] igt/perf: add utility function for checking periodic reports

2017-04-25 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 55 +-- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index d057d943..f8ac06c3 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -450,6 +450,29 @@ ge

[Intel-gfx] [PATCH i-g-t 23/29] igt/perf: update max buffer size for reading reports

2017-04-25 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 98f80bfd..887836e2 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1245,9 +1245,7 @@ read_2_oa_reports(int format_id, /* Note: w

[Intel-gfx] [PATCH i-g-t 22/29] igt/perf: add per context filtering test for gen8+

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 813 --- 1 file changed, 775 insertions(+), 38 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index b7af1c3b..98f80bfd 100644 --- a

[Intel-gfx] [PATCH i-g-t 05/29] igt/perf: add gen8 formats

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 78 +--- 1 file changed, 64 insertions(+), 14 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 29487cdf..3eef82d2 100644 --- a/te

[Intel-gfx] [PATCH i-g-t 16/29] igt/perf: consider ctx-switch reports while polling/blocking

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 92 1 file changed, 86 insertions(+), 6 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 9a8c54fc..fe5ff0fc 100644 --- a/tes

[Intel-gfx] [PATCH i-g-t 15/29] igt/perf: don't assume constant of 40 EUs

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 62bfd80f..9a8c54fc 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -239,6

[Intel-gfx] [PATCH i-g-t 25/29] igt/perf: rework oa-exponent test

2017-04-25 Thread Lionel Landwerlin
New issues that were discovered while making the tests work on Gen8+ : - we need to measure timings between periodic reports and discard all other kind of reports - it seems periodicity of the reports can be affected outside of RC6 (frequency change), we can detect this by looking at the

[Intel-gfx] [PATCH i-g-t 28/29] igt/perf: load gt_boost_freq_mhz as max gt frequency

2017-04-25 Thread Lionel Landwerlin
We want the absolute max the hardware can do, not the max value set by a previous application/user. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index 6026811b..3d033b3a 100644 --- a/tests/perf.c

[Intel-gfx] [PATCH i-g-t 08/29] igt/perf: generalize reading gpu ticks from reports

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 67 +--- 1 file changed, 42 insertions(+), 25 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index fe39f4dd..48e8750f 100644 --- a/te

[Intel-gfx] [PATCH i-g-t 12/29] igt/perf: avoid assumptions about oa exponent <-> freq mappings

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 135 +-- 1 file changed, 84 insertions(+), 51 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 15f41246..d47e45c8 100644 --- a/te

[Intel-gfx] [PATCH i-g-t 00/29] Update i915 perf tests for Gen8+

2017-04-25 Thread Lionel Landwerlin
Hi, Apologies for this unfriendly series, in the end squashing everything into a single commit didn't look too good. We went through quite a few iterations to figure all the instability issues on Gen8+. This has finally reached a state where you can run the tests on a machine with other applicati

[Intel-gfx] [PATCH i-g-t 14/29] igt/perf: s/test_perf_ctx_mi_rpc/hsw_test_single_ctx_counters/

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index c8092eaa..62bfd80f 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -2177,9

[Intel-gfx] [PATCH i-g-t 04/29] igt/perf: update init_sys_info for skl with per-gt configs

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index f518bcc1..29487cdf 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -381,7 +381,20

[Intel-gfx] [PATCH i-g-t 17/29] igt/perf: factor out oa report sanity checking

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 274 +++ 1 file changed, 202 insertions(+), 72 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index fe5ff0fc..08ee8665 100644 --- a/t

[Intel-gfx] [PATCH i-g-t 18/29] igt/perf: print [un]slice freq and report reasons in debug

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 58 +- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index 08ee8665..ab8db296 100644 --- a/tests/

[Intel-gfx] [PATCH i-g-t 03/29] igt/perf: init timestamp freq and oa format per devid

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 120 +-- 1 file changed, 67 insertions(+), 53 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index df0120b2..f518bcc1 100644 --- a/

[Intel-gfx] [PATCH i-g-t 01/29] igt/perf: generalize lookup for test metric set

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 85 1 file changed, 57 insertions(+), 28 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 2a66bb63..0422e517 100644 --- a/te

[Intel-gfx] [PATCH i-g-t 11/29] igt/perf: handling printing gen8 formats

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 73 +--- 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 864c465c..15f41246 100644 --- a/te

[Intel-gfx] [PATCH i-g-t 07/29] igt/perf: generalize checks for undefined A counters

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 5a6bd05a..fe39f4dd 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -232,6 +232,9 @@ st

[Intel-gfx] [PATCH i-g-t 02/29] igt/perf: improve robustness of polling/blocking tests

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg There were a couple of problems with both of these tests that could lead to false negatives addressed by this patch. 1) The upper limit for the number of iterations missed a +1 to consider that there might be a sample immediately available at the start of the loop. 2) T

[Intel-gfx] [PATCH i-g-t 09/29] igt/perf: move timebase + oa exponent utilities up

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Reviewed-by: Lionel Landwerlin --- tests/perf.c | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 48e8750f..600fa7d9 100644 --- a/tests/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: LPE audio runtime PM and multipipe

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915: LPE audio runtime PM and multipipe URL : https://patchwork.freedesktop.org/series/23526/ State : success == Summary == Series 23526v1 drm/i915: LPE audio runtime PM and multipipe https://patchwork.freedesktop.org/api/1.0/series/23526/revisions/1/mbox/ Te

[Intel-gfx] [PATCH 07/11] drm/i915: Reorganize intel_lpe_audio_notify() arguments

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä Shuffle the arguments to intel_lpe_audio_notify() around a bit. Pipe and port being the most important things, so let's put the first, and thre rest can come in as is. Also constify the eld argument. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --

[Intel-gfx] [PATCH 05/11] drm/i915: Replace tmds_clock_speed and link_rate with just ls_clock

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä There's no need to distinguish between the DP link rate and HDMI TMDS clock for the purposes of the LPE audio. Both are actually the same thing more or less, which is the link symbol clock. So let's just call the thing ls_clock and simplify the code. Cc: Takashi Iwai Cc: Pie

[Intel-gfx] [PATCH 10/11] ALSA: x86: Split snd_intelhad into card and PCM specific structures

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä To allow multiple PCM devices to be registered for the LPE audio card, split the private data into card and PCM specific chunks. For now we'll stick to just one PCM device as before. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --- sound/x86/inte

[Intel-gfx] [PATCH 11/11] ALSA: x86: Register multiple PCM devices for the LPE audio card

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä Now that everything is in place let's register a PCM device for each pipe of the display engine. This will make it possible to actually output audio to multiple displays at the same time. And it avoids modesets on unrelated displays from clobbering up the ELD and whatnot for t

[Intel-gfx] [PATCH 09/11] ALSA: x86: Prepare LPE audio ctls for multiple PCMs

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä In preparation for register a PCM device for each pipe adjust link up the ctl elements with the corresponding PCM device. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --- sound/x86/intel_hdmi_audio.c | 23 +++ 1 file changed,

[Intel-gfx] [PATCH 08/11] drm/i915: Clean up the LPE audio platform data

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä Split the LPE audio platform data into a pipe specific chunk and device specific chunk. Eventually we'll have a pipe specific chunk for each pipe, but for now we'll stick to just one. We'll also get rid of the intel_hdmi_lpe_audio_eld structure which doesn't seem to have any

[Intel-gfx] [PATCH 06/11] drm/i915: Remove hdmi_connected from LPE audio pdata

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä We can determine that the pipe was shut down from port<0, so there's no point in duplicating that information as 'hdmi_connected'. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_lpe_audio.c | 5 ++--- include/drm/inte

[Intel-gfx] [PATCH 03/11] drm/i915: Stop pretending to mask/unmask LPE audio interrupts

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä vlv_display_irq_postinstall() enables the LPE audio interrupts regardless of whether the LPE audio irq chip has masked/unmasked them. Also the irqchip masking/unmasking doesn't consider the state of the display power well or the device, and hence just leads to dmesg spew when

[Intel-gfx] [PATCH 04/11] drm/i915: Remove the unsued pending_notify from LPE platform data

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä The pending_notify flag in the LPE audio platform data is pointless, actually unused. So let's kill it off. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_lpe_audio.c | 2 -- include/drm/intel_lpe_audio.h | 1

[Intel-gfx] [PATCH 02/11] ALSA: x86: Clear the pdata.notify_lpe_audio pointer before teardown

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä Clear the notify function pointer in the platform data before we tear down the driver. Otherwise i915 would end up calling a stale function pointer and possibly explode. Cc: Takashi Iwai Cc: Pierre-Louis Bossart Signed-off-by: Ville Syrjälä --- sound/x86/intel_hdmi_audio.

[Intel-gfx] [PATCH 00/11] drm/i915: LPE audio runtime PM and multipipe

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä I was wondering why my VLV no longer runtime suspended, and after some thinking I decided it had to be the LPE audio preventing it. Turns out I was right, so here's my attempt at fixing it. And while looking at the code I couldn't help but notice that it couldn't actually han

[Intel-gfx] [PATCH 01/11] drm/i915: Fix runtime PM for LPE audio

2017-04-25 Thread ville . syrjala
From: Ville Syrjälä Not calling pm_runtime_enable() means that runtime PM can't be enabled at all via sysfs. So we definitely need to call it from somewhere. Calling it from the driver seems like a bad idea because it would have to be paired with a pm_runtime_disable() at driver unload time, oth

Re: [Intel-gfx] GPU hangs and X shot down with 4.11-rc6

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 06:41:20PM +0200, Michal Hocko wrote: > Hi, > I have just experienced X being shut down once with 4.11-rc2 and 2 times > with 4.11-rc6 kernel. I do not remember seeing something like this > before but it is quite possible I was just lucky to not trigger this > issue before.

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

2017-04-25 Thread Brian Starkey
On Tue, Apr 25, 2017 at 02:43:13PM -0300, Gabriel Krisman Bertazi wrote: Brian Starkey writes: igt_get_all_cairo_formats() allocates the format list on the heap, but returns it in a const pointer. Change this so that callers can free the array without a warning, and free the array in all calle

[Intel-gfx] ✓ Fi.CI.BAT: success for Introduce common scatterlist map function (rev2)

2017-04-25 Thread Patchwork
== Series Details == Series: Introduce common scatterlist map function (rev2) URL : https://patchwork.freedesktop.org/series/23149/ State : success == Summary == Series 23149v2 Introduce common scatterlist map function https://patchwork.freedesktop.org/api/1.0/series/23149/revisions/2/mbox/ T

[Intel-gfx] [PATCH v2 16/21] mmc: sdhci: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion, except due to the lack of an error path we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Adrian Hunter Cc: Ulf Hansson --- drivers/mmc/host/sdhci.c | 14 +- 1 file changed, 9 insertio

[Intel-gfx] [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

2017-04-25 Thread Logan Gunthorpe
This patch introduces functions which kmap the pages inside an sgl. These functions replace a common pattern of kmap(sg_page(sg)) that is used in more than 50 places within the kernel. The motivation for this work is to eventually safely support sgls that contain io memory. In order for that to wo

[Intel-gfx] [PATCH v2 10/21] RDS: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion except there's no error path, so we make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Santosh Shilimkar Cc: "David S. Miller" --- net/rds/ib_recv.c | 8 1 file changed, 4 insertions(+), 4 del

[Intel-gfx] [PATCH v2 19/21] mmc: sdricoh_cs: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This is a straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Cc: Sascha Sommer Cc: Ulf Hansson --- drivers/mmc/host/sdricoh_cs.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdricoh_cs.c b/drivers/mmc/host/sdric

[Intel-gfx] [PATCH v2 13/21] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers Signed-off-by: Logan Gunthorpe Cc: Adaptec OEM Raid Solutions Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S --- drivers/scsi/arcmsr/arcmsr_hba.c | 16 drivers/scsi/ips.c | 8 drivers/scsi/me

[Intel-gfx] [PATCH v2 17/21] mmc: spi: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
We use the sg_map helper but it's slightly more complicated as we only check for the error when the mapping actually gets used. Such that if the mapping failed but wasn't needed then no error occurs. Signed-off-by: Logan Gunthorpe Cc: Ulf Hansson --- drivers/mmc/host/mmc_spi.c | 26

[Intel-gfx] [PATCH v2 21/21] memstick: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion, but we have to make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Alex Dubov --- drivers/memstick/host/jmb38x_ms.c | 11 ++- drivers/memstick/host/tifm_ms.c | 11 ++- 2 files changed,

[Intel-gfx] [PATCH v2 11/21] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Brian King Cc: Artur Paszkiewicz --- drivers/scsi/ipr.c | 27 ++- drivers/scsi/isci/request.c | 42 +- drivers/scsi/pmcraid.c

[Intel-gfx] [PATCH v2 20/21] mmc: tifm_sd: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This conversion is a bit complicated. We modiy the read_fifo, write_fifo and copy_page functions to take a scatterlist instead of a page. Thus we can use sg_map instead of kmap_atomic. There's a bit of accounting that needed to be done for the offset for this to work. (Seeing sg_map takes care of t

[Intel-gfx] [PATCH v2 06/21] crypto: hifn_795x: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Conversion of a couple kmap_atomic instances to the sg_map helper function. However, it looks like there was a bug in the original code: the source scatter lists offset (t->offset) was passed to ablkcipher_get which added it to the destination address. This doesn't make a lot of sense, but t->offs

[Intel-gfx] [PATCH v2 12/21] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Achim Leubner Cc: John Garry --- drivers/scsi/gdth.c| 9 +++-- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 14 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 13 +---

[Intel-gfx] [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to the new helper, except due to the lack of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" --- dr

[Intel-gfx] [PATCH v2 09/21] staging: unisys: visorbus: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Acked-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers

[Intel-gfx] [PATCH v2 05/21] drm/i915: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
This is a single straightforward conversion from kmap to sg_map. We also create the i915_gem_object_unmap function to common up the unmap code. Signed-off-by: Logan Gunthorpe Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 27 --- 1 file changed, 16 insert

[Intel-gfx] [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion to the new function in the caam driver and shash library. Signed-off-by: Logan Gunthorpe Cc: Herbert Xu Cc: "David S. Miller" --- crypto/shash.c| 9 ++--- drivers/crypto/caam/caamalg.c | 8 +++- 2 files changed, 9 insertions(+), 8 deletio

[Intel-gfx] [PATCH v2 02/21] libiscsi: Add an internal error code

2017-04-25 Thread Logan Gunthorpe
This is a prep patch to add a new error code to libiscsi. We want to rework some kmap calls to be able to fail. When we do, we'd like to use this error code. This patch simply introduces ISCSI_TCP_INTERNAL_ERR and prints "Internal Error." when it gets hit. Signed-off-by: Logan Gunthorpe --- dri

[Intel-gfx] [PATCH v2 00/21] Introduce common scatterlist map function

2017-04-25 Thread Logan Gunthorpe
Changes since v1: * Rebased onto next-20170424 * Removed the _offset version of these functions per Christoph's suggestion * Added an SG_MAP_MUST_NOT_FAIL flag which will BUG_ON in future cases that can't gracefully fail. This removes a bunch of the noise added in v1 to a couple of the drive

[Intel-gfx] [PATCH v2 04/21] target: Make use of the new sg_map function at 16 call sites

2017-04-25 Thread Logan Gunthorpe
Fairly straightforward conversions in all spots. In a couple of cases any error gets propogated up should sg_map fail. In other cases a warning is issued if the kmap fails seeing there's no clear error path. This should not be an issue until someone tries to use unmappable memory in the sgl with th

[Intel-gfx] [PATCH v2 08/21] dm-crypt: Make use of the new sg_map helper in 4 call sites

2017-04-25 Thread Logan Gunthorpe
Very straightforward conversion to the new function in all four spots. Signed-off-by: Logan Gunthorpe Cc: Alasdair Kergon Cc: Mike Snitzer --- drivers/md/dm-crypt.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/md/dm-crypt

[Intel-gfx] [PATCH v2 18/21] mmc: tmio: Make use of the new sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Straightforward conversion to sg_map helper. Seeing there is no cleare error path, SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Wolfram Sang Cc: Ulf Hansson --- drivers/mmc/host/tmio_mmc.h | 7 +-- drivers/mmc/host/tmio_mmc_p

[Intel-gfx] [PATCH v2 03/21] libiscsi: Make use of new the sg_map helper function

2017-04-25 Thread Logan Gunthorpe
Convert the kmap and kmap_atomic uses to the sg_map function. We now store the flags for the kmap instead of a boolean to indicate atomicitiy. We use ISCSI_TCP_INTERNAL_ERR error type that was prepared earlier for this. Signed-off-by: Logan Gunthorpe Cc: Lee Duncan Cc: Chris Leech --- drivers/

[Intel-gfx] [PATCH v2 14/21] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers

2017-04-25 Thread Logan Gunthorpe
These two drivers appear to duplicate the functionality of sg_copy_buffer. So we clean them up to use the common code. This helps us remove a couple of instances that would otherwise be slightly tricky sg_map usages. Signed-off-by: Logan Gunthorpe Cc: Johannes Thumshirn --- drivers/scsi/csiost

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Matthew Auld
On 25 April 2017 at 18:10, Lionel Landwerlin wrote: > On 25/04/17 09:42, Matthew Auld wrote: >> >> On 24 April 2017 at 19:49, Lionel Landwerlin >> wrote: >>> >>> From: Robert Bragg >>> >>> Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all >>> share (more-or-less) the same OA

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

2017-04-25 Thread Gabriel Krisman Bertazi
Brian Starkey writes: > igt_get_all_cairo_formats() allocates the format list on the heap, but > returns it in a const pointer. Change this so that callers can free the > array without a warning, and free the array in all callers. > > Signed-off-by: Brian Starkey > --- > lib/igt_fb.c |

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable OA unit for Gen 8 and 9 in i915 perf (rev8)

2017-04-25 Thread Patchwork
== Series Details == Series: Enable OA unit for Gen 8 and 9 in i915 perf (rev8) URL : https://patchwork.freedesktop.org/series/20084/ State : failure == Summary == cc1: all warnings being treated as errors cc1: all warnings being treated as errors scripts/Makefile.build:294: recipe for target

[Intel-gfx] [PATCH v7 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular note in comparison to Haswell: some OA unit HW config state has become per-context state and as a consequence it is somewhat more complicated to ma

Re: [Intel-gfx] [PATCH] drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Michel Thierry
On 25/04/17 05:30, Chris Wilson wrote: On Tue, Apr 25, 2017 at 01:21:47PM +0100, Tvrtko Ursulin wrote: On 25/04/2017 11:38, Chris Wilson wrote: As we now share the execlist_port[] tracking for both execlists/guc, we can reset the inflight count on both and report which requests are being resta

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
On 25/04/17 09:42, Matthew Auld wrote: On 24 April 2017 at 19:49, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular note in comparison to Haswell: some OA unit HW confi

Re: [Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

2017-04-25 Thread Brian Starkey
On Tue, Apr 25, 2017 at 07:58:18PM +0300, Ville Syrjälä wrote: On Tue, Apr 25, 2017 at 05:45:13PM +0100, Brian Starkey wrote: If "video=" is specified on the kernel command-line, use it to override the default mode in kmstest_get_connector_default_mode. If a mode override was provided on the co

Re: [Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

2017-04-25 Thread Ville Syrjälä
On Tue, Apr 25, 2017 at 05:45:13PM +0100, Brian Starkey wrote: > If "video=" is specified on the kernel command-line, use it to override > the default mode in kmstest_get_connector_default_mode. > > If a mode override was provided on the command-line, it was probably for > good reason so we should

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid the branch in computing intel_ring_space()

2017-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Avoid the branch in computing intel_ring_space() URL : https://patchwork.freedesktop.org/series/23515/ State : success == Summary == Series 23515v1 drm/i915: Avoid the branch in computing intel_ring_space() https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] [PATCH i-g-t 4/7] lib/igt_debugfs: Remove igt_debugfs_t

2017-04-25 Thread Brian Starkey
It's not used anymore, so remove it. Signed-off-by: Brian Starkey --- lib/igt_debugfs.c |5 - 1 file changed, 5 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index 7584be5f9cc1..f5ed3dafee8a 100644 --- a/lib/igt_debugfs.c +++ b/lib/igt_debugfs.c @@ -84,11 +84,6 @@ *

[Intel-gfx] [PATCH i-g-t RESEND 1/7] lib/igt_kms: Fix erroneous assert

2017-04-25 Thread Brian Starkey
In trying to fix igt_display_init() for devices without cursors, I actually made matters worse. Fix the assert. Fixes: 545aa3398223 lib/igt_kms: Remove redundant cursor code Signed-off-by: Brian Starkey --- lib/igt_kms.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --

[Intel-gfx] [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak

2017-04-25 Thread Brian Starkey
igt_get_all_cairo_formats() allocates the format list on the heap, but returns it in a const pointer. Change this so that callers can free the array without a warning, and free the array in all callers. Signed-off-by: Brian Starkey --- lib/igt_fb.c |4 +++- lib/igt_fb.h |2 +-

[Intel-gfx] [PATCH i-g-t 6/7] igt: lib/igt_crc: Split out CRC functionality

2017-04-25 Thread Brian Starkey
Separate out the CRC code for better compartmentalisation. Should ease the addition of more/different CRC sources in the future. Signed-off-by: Brian Starkey --- lib/Makefile.sources |2 + lib/igt_chamelium.h |1 + lib/igt_crc.c | 563 +

[Intel-gfx] [PATCH i-g-t 5/7] lib/igt_debugfs: Only use valid values in igt_crc_to_str()

2017-04-25 Thread Brian Starkey
Not all elements in the crc array may be valid, so only use the valid ones to generate the string. Signed-off-by: Brian Starkey --- lib/igt_debugfs.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index f5ed3dafee8a..80f25c6159

[Intel-gfx] [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified

2017-04-25 Thread Brian Starkey
If "video=" is specified on the kernel command-line, use it to override the default mode in kmstest_get_connector_default_mode. If a mode override was provided on the command-line, it was probably for good reason so we should honor it. Signed-off-by: Brian Starkey --- lib/igt_kms.c | 135 +

[Intel-gfx] [PATCH i-g-t 2/7] lib/igt_kms: Fix override_mode handling

2017-04-25 Thread Brian Starkey
igt_display_commit isn't refreshing all outputs anymore, which means that an override mode may never get picked up. Instead of forcing a reprobe to handle copying the override_mode into default_mode, just change igt_output_get_mode() to return the override_mode if it's been set, and remove the old

[Intel-gfx] [PATCH i-g-t 0/7] Misc fixes and cleanup

2017-04-25 Thread Brian Starkey
Hi, This is not really a series but a set of miscellaneous fixes and cleanup. It should be mostly noncontroversial, with the exception of perhaps the last two patches. Patch 6 splits all of the igt_crc code out of igt_debugfs into a separate file. The goal here was to make it easier to add new C

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Matthew Auld
On 24 April 2017 at 19:49, Lionel Landwerlin wrote: > From: Robert Bragg > > Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all > share (more-or-less) the same OA unit design. > > Of particular note in comparison to Haswell: some OA unit HW config > state has become per-context

[Intel-gfx] GPU hangs and X shot down with 4.11-rc6

2017-04-25 Thread Michal Hocko
Hi, I have just experienced X being shut down once with 4.11-rc2 and 2 times with 4.11-rc6 kernel. I do not remember seeing something like this before but it is quite possible I was just lucky to not trigger this issue before. It always happened while I was working on a presentation in LibreOffice

Re: [Intel-gfx] [PATCH v6 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-04-25 Thread Lionel Landwerlin
Hey Matt, This commit had your reviewed-by on v4, are you still okay with it? Thanks! - Lionel On 24/04/17 11:49, Lionel Landwerlin wrote: From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular no

[Intel-gfx] [PATCH] drm/i915: Avoid the branch in computing intel_ring_space()

2017-04-25 Thread Chris Wilson
Exploit the power-of-two ring size to compute the space across the wraparound using a mask rather than a if. Convert to unsigned integers so the operation is well defined. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/intel_ringbuffer.c | 20 ++-- driver

Re: [Intel-gfx] [PATCH v5 02/11] drm/core: Allow attaching custom scaling mode properties

2017-04-25 Thread Ville Syrjälä
On Tue, Apr 25, 2017 at 01:55:26PM +0200, Maarten Lankhorst wrote: > Some connectors may not allow all scaling mode properties, this function will > allow > creating the scaling mode property with only the supported subset. > > This will make it possible to convert i915 connectors to atomic. > >

Re: [Intel-gfx] [PATCH v5 02/11] drm/core: Allow attaching custom scaling mode properties

2017-04-25 Thread Sean Paul
On Tue, Apr 25, 2017 at 01:55:26PM +0200, Maarten Lankhorst wrote: > Some connectors may not allow all scaling mode properties, this function will > allow > creating the scaling mode property with only the supported subset. > > This will make it possible to convert i915 connectors to atomic. > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Differentiate between sw write location into ring and last hw read

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 04:50:15PM +0300, Mika Kuoppala wrote: > Chris Wilson writes: > > > We need to keep track of the last location we ask the hw to read up to > > (RING_TAIL) separately from our last write location into the ring, so > > that in the event of a GPU reset we do not tell the HW t

Re: [Intel-gfx] [PATCH v2] drm/i915: Differentiate between sw write location into ring and last hw read

2017-04-25 Thread Mika Kuoppala
Chris Wilson writes: > We need to keep track of the last location we ask the hw to read up to > (RING_TAIL) separately from our last write location into the ring, so > that in the event of a GPU reset we do not tell the HW to proceed into > a partially written request (which can happen if that re

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Differentiate between sw write location into ring and last hw read (rev2)

2017-04-25 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Differentiate between sw write location into ring and last hw read (rev2) URL : https://patchwork.freedesktop.org/series/23411/ State : success == Summary == Series 23411v2 Series without cover letter https://patchwork.freedeskt

[Intel-gfx] [PATCH i-g-t] igt/meta_test: Fix dmesg-warn test

2017-04-25 Thread Marta Lofstedt
Add bracket to match with piglit dmesg filter. Signed-off-by: Marta Lofstedt --- tests/meta_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/meta_test.c b/tests/meta_test.c index e09efba0..c02cf8bc 100644 --- a/tests/meta_test.c +++ b/tests/meta_test.c @@ -97,

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Report request restarts for both execlists/guc

2017-04-25 Thread Chris Wilson
On Tue, Apr 25, 2017 at 11:58:46AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Report request restarts for both execlists/guc > URL : https://patchwork.freedesktop.org/series/23502/ > State : success > > == Summary == > > Series 23502v1 drm/i915: Report request restart

  1   2   >