Re: [Intel-gfx] [alsa-devel] [PATCH v2 00/11] drm/i915: LPE audio runtime PM and multipipe (v2)

2017-05-01 Thread Pierre-Louis Bossart
On 04/28/2017 02:37 PM, Ville Syrjälä wrote: On Fri, Apr 28, 2017 at 12:10:31PM -0500, Pierre-Louis Bossart wrote: On 04/28/2017 03:41 AM, Takashi Iwai wrote: On Thu, 27 Apr 2017 18:02:19 +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Okay,

[Intel-gfx] [PATCH v9 12/15] drm/i915/perf: Add OA unit support for Gen 8+

2017-05-01 Thread Lionel Landwerlin
From: Robert Bragg Enables access to OA unit metrics for BDW, CHV, SKL and BXT which all share (more-or-less) the same OA unit design. Of particular note in comparison to Haswell: some OA unit HW config state has become per-context state and as a consequence it is somewhat

Re: [Intel-gfx] [PATCH v7 04/20] drm/i915: Skip reset request if there is one already

2017-05-01 Thread Michel Thierry
On 29/04/17 07:21, Chris Wilson wrote: On Thu, Apr 27, 2017 at 04:12:44PM -0700, Michel Thierry wrote: From: Mika Kuoppala To perform engine reset we first disable engine to capture its state. This is done by issuing a reset request. Because we are reusing

Re: [Intel-gfx] [PATCH v3 1/2] PCI / PM: Add needs_resume flag to avoid suspend complete optimization

2017-05-01 Thread Rafael J. Wysocki
On Sunday, April 30, 2017 03:57:13 PM Imre Deak wrote: > On Sat, Apr 29, 2017 at 12:21:57PM +0200, Rafael J. Wysocki wrote: > > On Friday, April 28, 2017 11:33:02 PM Rafael J. Wysocki wrote: > > > On Friday, April 28, 2017 05:16:02 PM Imre Deak wrote: > > > > Some drivers - like i915 - may not

Re: [Intel-gfx] [PATCH v7 13/20] drm/i915/guc: Rename the function that resets the GuC

2017-05-01 Thread Michel Thierry
On 28/04/17 00:40, Tvrtko Ursulin wrote: --- a/drivers/gpu/drm/i915/intel_uc.c +++ b/drivers/gpu/drm/i915/intel_uc.c @@ -46,9 +46,9 @@ static int __intel_uc_reset_hw(struct drm_i915_private *dev_priv) int ret; u32 guc_status; -ret = intel_guc_reset(dev_priv); +ret =

[Intel-gfx] ✓ Fi.CI.BAT: success for Adding driver-private objects to atomic state

2017-05-01 Thread Patchwork
== Series Details == Series: Adding driver-private objects to atomic state URL : https://patchwork.freedesktop.org/series/23775/ State : success == Summary == Series 23775v1 Adding driver-private objects to atomic state https://patchwork.freedesktop.org/api/1.0/series/23775/revisions/1/mbox/

[Intel-gfx] [RESEND FOR CI PATCH v8 2/4] drm/dp: Introduce MST topology state to track available link bandwidth

2017-05-01 Thread Dhinakaran Pandiyan
From: "Pandiyan, Dhinakaran" Link bandwidth is shared between multiple display streams in DP MST configurations. The DP MST topology manager structure maintains the shared link bandwidth for a primary link directly connected to the GPU. For atomic modesetting

[Intel-gfx] [RESEND FOR CI PATCH v8 3/4] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

2017-05-01 Thread Dhinakaran Pandiyan
From: "Pandiyan, Dhinakaran" drm_dp_atomic_find_vcpi_slots() should be called from ->atomic_check() to check there are sufficient vcpi slots for a mode and to add that to the state. This should be followed by a call to drm_dp_mst_allocate_vcpi() in

[Intel-gfx] [RESEND FOR CI PATCH v8 1/4] drm: Add driver-private objects to atomic state

2017-05-01 Thread Dhinakaran Pandiyan
From: "Pandiyan, Dhinakaran" It is necessary to track states for objects other than connector, crtc and plane for atomic modesets. But adding objects like DP MST link bandwidth to drm_atomic_state would mean that a non-core object will be modified by the core

[Intel-gfx] [RESEND FOR CI PATCH v8 4/4] drm/dp: Track MST link bandwidth

2017-05-01 Thread Dhinakaran Pandiyan
From: "Pandiyan, Dhinakaran" Use the added helpers to track MST link bandwidth for atomic modesets. Link bw is acquired in the ->atomic_check() phase when CRTCs are being enabled with drm_atomic_find_vcpi_slots(). Similarly, link bw is released during

[Intel-gfx] [RESEND FOR CI PATCH v8 0/4] Adding driver-private objects to atomic state

2017-05-01 Thread Dhinakaran Pandiyan
Resending for CI. Pandiyan, Dhinakaran (4): drm: Add driver-private objects to atomic state drm/dp: Introduce MST topology state to track available link bandwidth drm/dp: Add DP MST helpers to atomically find and release vcpi slots drm/dp: Track MST link bandwidth

Re: [Intel-gfx] [PATCH v6 01/12] drm/atomic: Handle picture_aspect_ratio in atomic core

2017-05-01 Thread Manasi Navare
On Mon, May 01, 2017 at 03:37:53PM +0200, Maarten Lankhorst wrote: > This is only used in i915, which had used its own non-taomic way to > deal with the picture aspect ratio. Move selected aspect_ratio to > atomic state and use the atomic state in the affected i915 connectors. > Please correct

Re: [Intel-gfx] [PATCH v8 4/4] drm/dp: Track MST link bandwidth

2017-05-01 Thread Pandiyan, Dhinakaran
On Mon, 2017-05-01 at 10:24 +0200, Maarten Lankhorst wrote: > Op 29-04-17 om 01:14 schreef Dhinakaran Pandiyan: > > From: "Pandiyan, Dhinakaran" > > > > Use the added helpers to track MST link bandwidth for atomic modesets. > > Link bw is acquired in the

Re: [Intel-gfx] [PATCH] drm/i915: New vfunc prepare_request

2017-05-01 Thread Oscar Mateo
On 04/29/2017 08:31 AM, Chris Wilson wrote: On Fri, Apr 28, 2017 at 05:26:09PM +, Oscar Mateo wrote: This will be more useful later to support platforms that need to emit HW commands at the beginning of every request (more general than emitting things at the beginning of every

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Convert connector properties to atomic. (rev7)

2017-05-01 Thread Patchwork
== Series Details == Series: drm/i915: Convert connector properties to atomic. (rev7) URL : https://patchwork.freedesktop.org/series/22634/ State : failure == Summary == Series 22634v7 drm/i915: Convert connector properties to atomic.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Calculate intermediate watermarks correctly.

2017-05-01 Thread Patchwork
== Series Details == Series: drm/i915: Calculate intermediate watermarks correctly. URL : https://patchwork.freedesktop.org/series/23769/ State : success == Summary == Series 23769v1 drm/i915: Calculate intermediate watermarks correctly.

[Intel-gfx] [PATCH v6 10/12] drm/i915: Convert intel_hdmi connector properties to atomic

2017-05-01 Thread Maarten Lankhorst
intel_hdmi supports 3 properties, force_audio, broadcast rgb and scaling mode. The last one is only created for eDP, so the is_eDP in set_property is not required. panel fitting and broadcast rgb are straightforward and only requires changing compute_config. force_audio is also used to force DVI

[Intel-gfx] [PATCH v6 12/12] drm/i915: Convert intel_sdvo connector properties to atomic.

2017-05-01 Thread Maarten Lankhorst
SDVO was the last connector that's still using the legacy paths for properties, and this is with a reason! This connector implements a lot of properties dynamically, and some of them shared with the digital connector state, so sdvo_connector_state subclasses intel_digital_connector_state.

[Intel-gfx] [PATCH v6 04/12] drm/i915: Use per-connector scaling mode property

2017-05-01 Thread Maarten Lankhorst
None of the intel connectors can use all types of scaling modes, so only try the ones that are possible. This is another preparation for connectors towards conversion to atomic. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_dp.c | 29

[Intel-gfx] [PATCH v6 11/12] drm/i915: Handle force_audio correctly in intel_sdvo

2017-05-01 Thread Maarten Lankhorst
Do the same as other connectors, attempt to detect hdmi audio in the detect() callback, and only use the force_audio property as override. Compute has_audio in pipe_config, and use that value instead of the probed value directly. Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH v6 07/12] drm/i915: Convert LVDS connector properties to atomic.

2017-05-01 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_lvds.c | 35 +-- 1 file changed, 5 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lvds.c

[Intel-gfx] [PATCH v6 09/12] drm/i915: Convert intel_dp properties to atomic, v2.

2017-05-01 Thread Maarten Lankhorst
intel_dp supports 3 properties, scaling mode, broadcast rgb and force_audio. intel_digital_connector handles the plumbing, so we only have to hook this up in compute_config and init. Changes since v1: - Remove limited_color_range too, unused. (danvet) Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH v6 06/12] drm/i915: Convert DSI connector properties to atomic.

2017-05-01 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_dsi.c | 38 +- 1 file changed, 5 insertions(+), 33 deletions(-) diff --git

[Intel-gfx] [PATCH v6 03/12] drm/i915: Use atomic scaling_mode instead of panel.fitting_mode

2017-05-01 Thread Maarten Lankhorst
The first step in converting connector properties to atomic is wiring up the atomic state. We're still not completely supoprting the scaling mode in the atomic case, but this is the first step towards it. Signed-off-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH v6 01/12] drm/atomic: Handle picture_aspect_ratio in atomic core

2017-05-01 Thread Maarten Lankhorst
This is only used in i915, which had used its own non-taomic way to deal with the picture aspect ratio. Move selected aspect_ratio to atomic state and use the atomic state in the affected i915 connectors. Signed-off-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH v6 08/12] drm/i915: Make intel_dp->has_audio reflect hw state only

2017-05-01 Thread Maarten Lankhorst
Always detect if audio is available during edid detection. With less magic switching it's easier to convert the dp connector properties to atomic. Signed-off-by: Maarten Lankhorst Reviewed-by: Daniel Vetter ---

[Intel-gfx] [PATCH v6 05/12] drm/i915: Add plumbing for digital connector state, v3.

2017-05-01 Thread Maarten Lankhorst
Some atomic properties are common between the various kinds of connectors, for example a lot of them use panel fitting mode. It makes sense to put a lot of it in a common place, so each connector can use it while they're being converted. Implement the properties required for the connectors: -

[Intel-gfx] [PATCH v6 00/12] drm/i915: Convert connector properties to atomic.

2017-05-01 Thread Maarten Lankhorst
This is required to allow setting i915 connector properties using the atomic ioctl. This version shouldn't cause unbisectable changes in between. CHanges since last version: - Split out picture_aspect_ratio and atomic scaling mode property to separate commits. - Make sure it bisects correctly,

[Intel-gfx] [PATCH v6 02/12] drm/atomic: Add support for custom scaling mode properties, v2

2017-05-01 Thread Maarten Lankhorst
Some connectors may not allow all scaling mode properties, this function will allow creating the scaling mode property with only the supported subset. It also wires up this state for atomic. This will make it possible to convert i915 connectors to atomic. Changes since v1: - Add

[Intel-gfx] [PATCH v2 0/4] drm/i915: Calculate intermediate watermarks correctly.

2017-05-01 Thread Maarten Lankhorst
Calculate intermediate watermarks with the correct previous optimal watermark values. This is the same as v1, but with helper macro to get the old state. Maarten Lankhorst (4): drm/i915: Change use get_new_plane_state instead of existing plane state drm/i915: Change

[Intel-gfx] [PATCH v2 1/4] drm/i915: Change use get_new_plane_state instead of existing plane state

2017-05-01 Thread Maarten Lankhorst
The get_existing macros are deprecated and should be replaced by get_old/new_state for clarity. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 4 ++-- drivers/gpu/drm/i915/intel_drv.h| 4 ++-- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v2 3/4] drm/i915: Calculate ironlake intermediate watermarks correctly, v2.

2017-05-01 Thread Maarten Lankhorst
The watermarks it should calculate against are the old optimal watermarks. The currently active crtc watermarks are pure fiction, and are invalid in case of a nonblocking modeset, page flip enabling/disabling planes or any other reason. When the crtc is disabled or during a modeset the

[Intel-gfx] [PATCH v2 4/4] drm/i915: Calculate vlv/chv intermediate watermarks correctly, v2.

2017-05-01 Thread Maarten Lankhorst
The watermarks it should calculate against are the old optimal watermarks. The currently active crtc watermarks are pure fiction, and are invalid in case of a nonblocking modeset, page flip enabling/disabling planes or any other reason. When the crtc is disabled or during a modeset the

[Intel-gfx] [PATCH v2 2/4] drm/i915: Change get_existing_crtc_state to old state

2017-05-01 Thread Maarten Lankhorst
get_existing_crtc_state is currently unused, but the next commit needs to access the old intel state. Rename this and use this as convenience wrapper. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_drv.h | 6 +++--- 1 file changed, 3

Re: [Intel-gfx] [PATCH v8 4/4] drm/dp: Track MST link bandwidth

2017-05-01 Thread Maarten Lankhorst
Op 29-04-17 om 01:14 schreef Dhinakaran Pandiyan: > From: "Pandiyan, Dhinakaran" > > Use the added helpers to track MST link bandwidth for atomic modesets. > Link bw is acquired in the ->atomic_check() phase when CRTCs are being > enabled with