Re: [Intel-gfx] [PATCH v4 0/5] HPD support during suspend for BXT/APL.

2017-06-28 Thread Animesh Manna
Hi, On 6/27/2017 5:31 PM, David Weinehall wrote: On Mon, Jun 12, 2017 at 08:54:02PM +0530, Animesh Manna wrote: Along with below patches sharing some background details/design. - On BXT, Display cannot generate an interrupt when in D3. - Without display in D3, S0ix can be achieved, Power impac

Re: [Intel-gfx] [PATCH i-g-t v2 7/7] Make igtrc configuration common, with configurable suspend/resume delay

2017-06-28 Thread Paul Kocialkowski
On Tue, 2017-06-27 at 17:11 -0400, Lyude Paul wrote: > > > On Tue, 2017-06-27 at 13:53 +0300, Paul Kocialkowski wrote: > > This adds support for configurable suspend/resume delay and takes the > > occasion to move igtrc configuation from igt_chamelium to igt_core. > > This way, suspend/resume del

Re: [Intel-gfx] [PATCH 00/13] fbdev locking rework and deferred setup, take 2

2017-06-28 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 04:02:02PM -0700, John Stultz wrote: > On Tue, Jun 27, 2017 at 7:59 AM, Daniel Vetter wrote: > > > > Thanks to Liviu's help I realized that I fumbled the locking rework > > completely. > > This one here should be better, but somehow I'm having a real bad day today > > and

Re: [Intel-gfx] [PATCH i-g-t v2 5/7] tests/chamelium: Update connector state without reprobe when possible

2017-06-28 Thread Paul Kocialkowski
On Tue, 2017-06-27 at 17:26 -0400, Lyude Paul wrote: > I -think- this one might be okay but I just got reminded of a rather > not-obvious part of the DRM spec for hotplugging, and I need to check > that this doesn't actually break that. will get back to you in a bit > with an actual review :) Mart

Re: [Intel-gfx] [PATCH i-g-t v2 6/7] tests/chamelium: Disconnect connectors without extra reset

2017-06-28 Thread Paul Kocialkowski
On Tue, 2017-06-27 at 17:21 -0400, Lyude Paul wrote: > NAK, I'd rather just go with the idea you had with removing the > connector reset in chamelium_init() Okay then, I'll craft v3 in that directon. This is not a big overhead anyways, and it does not change anything when running subtests separate

Re: [Intel-gfx] [PATCH v12 3/3] drm/i915: Add option to support dynamic backlight via DPCD

2017-06-28 Thread David Weinehall
On Tue, Jun 27, 2017 at 10:29:33PM +, Pandiyan, Dhinakaran wrote: > > > > On Tue, 2017-06-27 at 16:23 +0300, David Weinehall wrote: > > On Mon, Jun 26, 2017 at 05:18:19PM +0300, David Weinehall wrote: > > > On Thu, Jun 22, 2017 at 12:03:39PM -0700, Puthikorn Voravootivat wrote: > > > > This

Re: [Intel-gfx] [igt PATCH] igt/pm_rps: Remove remaining assert on CUR <= MAX

2017-06-28 Thread Arkadiusz Hiler
On Wed, Jun 21, 2017 at 08:57:21AM -0700, Jeff McGee wrote: > On Wed, Jun 21, 2017 at 12:55:42PM +0300, Arkadiusz Hiler wrote: > > On Tue, Jun 20, 2017 at 06:15:52PM +0300, Arkadiusz Hiler wrote: > > > On Tue, Jun 20, 2017 at 01:54:54PM +, Szwichtenberg, Radoslaw wrote: > > > > On Wed, 2017-06-

Re: [Intel-gfx] [PATCH] drm/i915: select CRC32

2017-06-28 Thread Jani Nikula
On Wed, 21 Jun 2017, Nicholas Piggin wrote: > On Wed, 21 Jun 2017 10:15:56 +0100 > Chris Wilson wrote: > >> Quoting Daniel Vetter (2017-06-21 10:13:41) >> > On Wed, Jun 21, 2017 at 04:34:20PM +1000, Nicholas Piggin wrote: >> > > kbuild test robot found a build failure when building with thin >>

Re: [Intel-gfx] [RFC] drm/i915: Add GuC timeout config options to Kconfig.debug

2017-06-28 Thread Tvrtko Ursulin
On 14/06/2017 00:19, Kelvin Gardiner wrote: It is sometimes useful for debug purposes to be able to set GuC timeout lengths. This patch adds GuC load and request timeouts values to Kconfig.debug, which can then be optionally set as required for debug cases. A default value equal to the current

Re: [Intel-gfx] [PATCH] drm/i915: Cancel pending execlists irq handler upon idling

2017-06-28 Thread Tvrtko Ursulin
On 27/06/2017 16:25, Chris Wilson wrote: Due to the slight asynchronicity in handling the execlists interrupts (i.e. we defer the work to a handler that may consume more than one interrupt event), when the engine is idle we may still have an irq tasklet queued (especially when it has been deferr

[Intel-gfx] [PATCH] drm/hisilicon: Remove custom FB helper deferred setup

2017-06-28 Thread Daniel Vetter
From: Thierry Reding The FB helper core now supports deferred setup, so the driver's custom implementation can be removed. v2: Dont' resurrect drm_vblank_cleanup. Cc: Xinliang Liu Cc: Rongrong Zou Cc: Xinwei Kong Cc: Chen Feng Reviewed-by: Daniel Vetter Signed-off-by: Thierry Reding (v1)

[Intel-gfx] [PATCH] dim: Fixes/polish for cherry-pick

2017-06-28 Thread Daniel Vetter
- Subcommands without subshell is nice, except it can break worktree setups: Branch specific commands want to run in the worktree, general commands like dim_cite switch back to the main directory. Tears ensue (or well, some cryptic complaint from git that cherry-pick --abort failed because

[Intel-gfx] ✓ Fi.CI.BAT: success for fbdev locking rework and deferred setup, take 2 (rev2)

2017-06-28 Thread Patchwork
== Series Details == Series: fbdev locking rework and deferred setup, take 2 (rev2) URL : https://patchwork.freedesktop.org/series/26437/ State : success == Summary == Series 26437v2 fbdev locking rework and deferred setup, take 2 https://patchwork.freedesktop.org/api/1.0/series/26437/revision

Re: [Intel-gfx] [PATCH] drm/i915: Cancel pending execlists irq handler upon idling

2017-06-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-06-28 09:59:04) > > On 27/06/2017 16:25, Chris Wilson wrote: > > Due to the slight asynchronicity in handling the execlists interrupts > > (i.e. we defer the work to a handler that may consume more than one > > interrupt event), when the engine is idle we may still hav

Re: [Intel-gfx] [PATCH] drm/i915: Cancel pending execlists irq handler upon idling

2017-06-28 Thread Tvrtko Ursulin
On 28/06/2017 11:01, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-06-28 09:59:04) On 27/06/2017 16:25, Chris Wilson wrote: Due to the slight asynchronicity in handling the execlists interrupts (i.e. we defer the work to a handler that may consume more than one interrupt event), when the e

Re: [Intel-gfx] [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

2017-06-28 Thread Takashi Iwai
On Mon, 26 Jun 2017 19:54:49 +0200, Daniel Vetter wrote: > > On Mon, Jun 26, 2017 at 7:47 PM, Takashi Iwai wrote: > > On Mon, 26 Jun 2017 18:16:30 +0200, > > Daniel Vetter wrote: > >> > >> On Wed, Jun 21, 2017 at 05:30:10PM +0200, Takashi Iwai wrote: > >> > On Wed, 21 Jun 2017 17:23:57 +0200, > >

Re: [Intel-gfx] [PATCH] drm/i915: Set all undefined MOCS entries to follow PTE

2017-06-28 Thread Chris Wilson
Quoting Francisco Jerez (2017-05-04 21:59:44) > Chris Wilson writes: > > > On Thu, May 04, 2017 at 10:56:54AM -0700, Francisco Jerez wrote: > >> David Weinehall writes: > >> > >> > On Thu, May 04, 2017 at 10:51:29AM +0100, Chris Wilson wrote: > >> >> A good default for garbage entries from the

Re: [Intel-gfx] [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

2017-06-28 Thread Maarten Lankhorst
Op 27-06-17 om 17:01 schreef Daniel Vetter: > On Tue, Jun 27, 2017 at 04:29:44PM +0200, Maarten Lankhorst wrote: >> Op 27-06-17 om 09:37 schreef Daniel Vetter: >>> On Mon, Jun 26, 2017 at 03:44:07PM -0400, Harry Wentland wrote: On 2017-06-20 01:57 PM, Andrey Grodzovsky wrote: > Problem : W

Re: [Intel-gfx] [PATCH] drm/i915: Cancel pending execlists irq handler upon idling

2017-06-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-06-28 11:15:36) > > On 28/06/2017 11:01, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-06-28 09:59:04) > >> > >> On 27/06/2017 16:25, Chris Wilson wrote: > >>> Due to the slight asynchronicity in handling the execlists interrupts > >>> (i.e. we defer the work to

[Intel-gfx] [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data

2017-06-28 Thread Abdiel Janulgue
Doing this tends to takes forever. Signed-off-by: Abdiel Janulgue --- tests/debugfs_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c index 3f0eaae..3d973d9 100644 --- a/tests/debugfs_test.c +++ b/tests/debugfs_test.c @@ -40,

[Intel-gfx] [PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Daniel Vetter
There's a bunch of folks who're trying to make printk less contended and faster, but there's a problem: printk uses the console_lock, and the console lock has become the BKL for all things fbdev/fbcon, which in turn pulled in half the drm subsystem under that lock. That's awkward. There reasons fo

[Intel-gfx] [PATCH i-g-t] lib/ioctl_wrappers: Fix some comments

2017-06-28 Thread Arkadiusz Hiler
"This is a wraps" -> "This wraps" "hw/hardware context" -> "context" gem_context_create does not use igt_require() but igt_skip_on() so make the similarity note more vague and in result true. Cc: Daniel Vetter Cc: Radoslaw Szwichtenberg Signed-off-by: Arkadiusz Hiler --- lib/ioctl_wrappers.c

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Hold RPM wakelock while initializing OA buffer

2017-06-28 Thread Lionel Landwerlin
Hi Sagar, Thanks for this patch, it all looks good to me : Reviewed-by: Lionel Landwerlin On 27/06/17 20:39, Sagar Arun Kamble wrote: OA buffer initialization involves access to HW registers to set the OA base, head and tail. Ensure device is awake while setting these. With this, all oa.ops a

Re: [Intel-gfx] [PATCH i-g-t v2] lib/ioctl_wrappers: Fix function descriptions

2017-06-28 Thread Arkadiusz Hiler
On Fri, Jun 23, 2017 at 04:01:05PM +0200, Radoslaw Szwichtenberg wrote: > Function description incorrectly stated that gem_context_get_param > and gem_context_set_param were freeing hw context. > > v2: removed additional incorrect information > > Signed-off-by: Radoslaw Szwichtenberg Reviewed-by

Re: [Intel-gfx] [PATCH i-g-t] igt/debugfs_test: Skip dummy reads for sysfs pipe crc data

2017-06-28 Thread Arkadiusz Hiler
On Wed, Jun 28, 2017 at 01:33:16PM +0300, Abdiel Janulgue wrote: > Doing this tends to takes forever. > > Signed-off-by: Abdiel Janulgue > --- > tests/debugfs_test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c > index 3f

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s

2017-06-28 Thread Marta Lofstedt
The subtests: igt@kms_frontbuffer_tracking@fbc-*draw* has non-consistent results, pending between fail and pass. The fails are always due to "FBC disabled". With this increase in timeout the flip-flop behavior is no longer reproducible. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101623

Re: [Intel-gfx] [PATCH] drm/i915: Drop flushing of the object free list/worker from i915_gem_suspend

2017-06-28 Thread Chris Wilson
Quoting David Weinehall (2017-06-27 18:57:34) > On Tue, Jun 27, 2017 at 06:37:31PM +0100, Chris Wilson wrote: > > i915_gem_suspend() is called from all of our finalization paths > > (suspend, hibernate, unload). i915_gem_drain_freed_objects() adds an > > arbitrary delay as it uses an rcu_barrier()

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Check for existence of ifbdev->vma before operations

2017-06-28 Thread Chris Wilson
Quoting Chris Wilson (2017-06-22 17:02:11) > Commit fabef825626d ("drm/i915: Drop struct_mutex around frontbuffer > flushes") adds a dependency to ifbdev->vma when flushing the framebufer, > but the checks are only against the existence of the ifbdev->fb and not > against ifbdev->vma. This leaves a

[Intel-gfx] ✓ Fi.CI.BAT: success for fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Patchwork
== Series Details == Series: fbcon: Make fbcon a built-time depency for fbdev URL : https://patchwork.freedesktop.org/series/26477/ State : success == Summary == Series 26477v1 fbcon: Make fbcon a built-time depency for fbdev https://patchwork.freedesktop.org/api/1.0/series/26477/revisions/1/m

Re: [Intel-gfx] [PATCH i-g-t] lib/ioctl_wrappers: Fix some comments

2017-06-28 Thread Szwichtenberg, Radoslaw
On Wed, 2017-06-28 at 13:40 +0300, Arkadiusz Hiler wrote: > "This is a wraps" -> "This wraps" > "hw/hardware context" -> "context" > > gem_context_create does not use igt_require() but igt_skip_on() so make > the similarity note more vague and in result true. > > Cc: Daniel Vetter > Cc: Radoslaw

Re: [Intel-gfx] [RFC v4 1/2] drm/i915: Engine discovery uAPI

2017-06-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-06-26 16:47:41) > From: Tvrtko Ursulin > > Engine discovery uAPI allows userspace to probe for engine > configuration and features without needing to maintain the > internal PCI id based database. > > This enables removal of code duplications across userspace > compo

[Intel-gfx] [PATCH] drm/fb-helper: Support deferred setup

2017-06-28 Thread Daniel Vetter
FB helper code falls back to a 1024x768 mode if no outputs are connected or don't report back any modes upon initialization. This can be annoying because outputs that are added to FB helper later on can't be used with FB helper if they don't support a matching mode. The fallback is in place becaus

Re: [Intel-gfx] [RFC v4 1/2] drm/i915: Engine discovery uAPI

2017-06-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-06-26 16:47:41) > From: Tvrtko Ursulin > > Engine discovery uAPI allows userspace to probe for engine > configuration and features without needing to maintain the > internal PCI id based database. > > This enables removal of code duplications across userspace > compo

Re: [Intel-gfx] [PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 1:00 PM, Alan Cox wrote: > On Wed, 28 Jun 2017 12:36:35 +0200 > Daniel Vetter wrote: > >> There's a bunch of folks who're trying to make printk less >> contended and faster, but there's a problem: printk uses the >> console_lock, and the console lock has become the BKL for

Re: [Intel-gfx] [PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Alan Cox
On Wed, 28 Jun 2017 12:36:35 +0200 Daniel Vetter wrote: > There's a bunch of folks who're trying to make printk less > contended and faster, but there's a problem: printk uses the > console_lock, and the console lock has become the BKL for all things > fbdev/fbcon, which in turn pulled in half th

Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

2017-06-28 Thread Arkadiusz Hiler
On Thu, Jun 22, 2017 at 09:28:35AM -0700, Anusha Srivatsa wrote: > From: anushasr > > Just following the spec and adding these extra IDs. > > v2: update IDs following the kernel commit: > b056f8f3d6b900e8afd19f312719160346d263b4 (Chris) > > Cc: Rodrigo Vivi > Signed-off-by: Anusha Srivatsa >

Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

2017-06-28 Thread Arkadiusz Hiler
On Wed, Jun 28, 2017 at 03:17:00PM +0300, Arkadiusz Hiler wrote: > On Thu, Jun 22, 2017 at 09:28:35AM -0700, Anusha Srivatsa wrote: > > From: anushasr > > > > Just following the spec and adding these extra IDs. > > > > v2: update IDs following the kernel commit: > > b056f8f3d6b900e8afd19f3127191

[Intel-gfx] ✓ Fi.CI.BAT: success for fbdev locking rework and deferred setup, take 2 (rev3)

2017-06-28 Thread Patchwork
== Series Details == Series: fbdev locking rework and deferred setup, take 2 (rev3) URL : https://patchwork.freedesktop.org/series/26437/ State : success == Summary == Series 26437v3 fbdev locking rework and deferred setup, take 2 https://patchwork.freedesktop.org/api/1.0/series/26437/revision

[Intel-gfx] [PATCH v2] drm/i915: Avoid keeping waitboost active for signaling threads

2017-06-28 Thread Chris Wilson
Once a client has requested a waitboost, we keep that waitboost active until all clients are no longer waiting. This is because we don't distinguish which waiter deserves the boost. However, with the advent of fence signaling, the signaler threads appear as waiters to the RPS interrupt handler. So

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-28 Thread Zhang, Tina
> -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Gerd Hoffmann > Sent: Tuesday, June 27, 2017 2:13 PM > To: Alex Williamson > Cc: Wang, Zhenyu Z ; intel- > g...@lists.freedesktop.org; linux-ker...@vger.kernel.org; Chen, Xiaogu

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Avoid keeping waitboost active for signaling threads (rev2)

2017-06-28 Thread Patchwork
== Series Details == Series: drm/i915: Avoid keeping waitboost active for signaling threads (rev2) URL : https://patchwork.freedesktop.org/series/26211/ State : failure == Summary == Series 26211v2 drm/i915: Avoid keeping waitboost active for signaling threads https://patchwork.freedesktop.org

Re: [Intel-gfx] External display pixelated after upgrade to kernel >= 4.11.0-rc1

2017-06-28 Thread Jani Nikula
On Wed, 21 Jun 2017, neil k wrote: > Hey everyone, > > I have a new Thinkpad with a Kaby Lake CPU and Intel HD Graphics 620. I > had been using a 26" Vizio TV (1360x768) over HDMI as an external monitor > with no issues. I upgraded to a 4.11 series kernel and now the TV is very > pixelated (see

Re: [Intel-gfx] [RFC v4 1/2] drm/i915: Engine discovery uAPI

2017-06-28 Thread Tvrtko Ursulin
On 28/06/2017 12:27, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-06-26 16:47:41) From: Tvrtko Ursulin Engine discovery uAPI allows userspace to probe for engine configuration and features without needing to maintain the internal PCI id based database. This enables removal of code duplic

Re: [Intel-gfx] [RFC v4 1/2] drm/i915: Engine discovery uAPI

2017-06-28 Thread Tvrtko Ursulin
On 28/06/2017 14:15, Tvrtko Ursulin wrote: On 28/06/2017 12:27, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-06-26 16:47:41) From: Tvrtko Ursulin Engine discovery uAPI allows userspace to probe for engine configuration and features without needing to maintain the internal PCI id based da

Re: [Intel-gfx] [RFC v4 1/2] drm/i915: Engine discovery uAPI

2017-06-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-06-28 14:15:05) > > On 28/06/2017 12:27, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-06-26 16:47:41) > >> From: Tvrtko Ursulin > >> > >> Engine discovery uAPI allows userspace to probe for engine > >> configuration and features without needing to maintain the

[Intel-gfx] [PATCH 2/2] drm/atomic: Wait indefinitely and interruptibly for hw_done.

2017-06-28 Thread Maarten Lankhorst
Without waiting for hw_done, previous atomic updates may dereference the wrong state and cause a lot of confusion. The real fix is fixing all obj->state to use the accessor macros, but for now wait indefinitely and interruptibly. Cc: Boris Brezillon Cc: David Airlie Cc: Daniel Vetter Cc: Jani N

[Intel-gfx] [PATCH 1/2] drm/atomic: Change drm_atomic_helper_swap_state to return an error.

2017-06-28 Thread Maarten Lankhorst
We want to change swap_state to wait indefinitely, but to do this swap_state should wait interruptibly. This requires propagating the error to each driver. All drivers have changes to deal with the clean up. In order to allow easy reverting, the commit that changes behavior is separate so someone o

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/atomic: Change drm_atomic_helper_swap_state to return an error.

2017-06-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/atomic: Change drm_atomic_helper_swap_state to return an error. URL : https://patchwork.freedesktop.org/series/26488/ State : failure == Summary == Series 26488v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/

Re: [Intel-gfx] [PATCH i-g-t] vc4: Test setting labels of BOs.

2017-06-28 Thread Arkadiusz Hiler
On Thu, Jun 22, 2017 at 01:51:29PM -0700, Eric Anholt wrote: > So far this test is basically making sure that we throw appropriate > errors, and don't oops the kernel with silly inputs. > > Signed-off-by: Eric Anholt Acked-by: Arkadiusz Hiler ___ Intel

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib: Add reset-type helper in ioctl_wrappers

2017-06-28 Thread Arkadiusz Hiler
On Tue, Jun 20, 2017 at 11:25:01AM -0700, Michel Thierry wrote: > Soon we will have tests that are only for platforms with reset-engine > (GEN8+), so add a helper to query the has_gpu_reset via the getparam ioctl. > > Signed-off-by: Michel Thierry > --- > lib/ioctl_wrappers.c | 22 ++

Re: [Intel-gfx] [PATCH] i915/gvt: Add MIPI DSI support

2017-06-28 Thread Jani Nikula
On Wed, 21 Jun 2017, Alan Tan wrote: > From: Vivek Kasireddy > > In addition to adding the registers asscociated with MIPI DSI > encoder/connector, we also ensure intel_bios_init() function > gets called before intel_gvt_init() so that we can detect the presence > of MIPI DSI from the VBT and dec

[Intel-gfx] [RFC v5 1/2] drm/i915: Engine discovery uAPI

2017-06-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Engine discovery uAPI allows userspace to probe for engine configuration and features without needing to maintain the internal PCI id based database. This enables removal of code duplications across userspace components. Probing is done via the new DRM_IOCTL_I915_GEM_ENGINE

[Intel-gfx] [PATCH] drm/i915: Drain the device workqueue on unload

2017-06-28 Thread Chris Wilson
Workers on the i915->wq may rearm themselves so for completeness we need to replace our flush_workqueue() with a call to drain_workqueue() before unloading the device. References: https://bugs.freedesktop.org/show_bug.cgi?id=101627 Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/dr

[Intel-gfx] [PATCH i-g-t] tests/gem_mocs_settings: Fix LNCFCMOCS testing and extract the subtests

2017-06-28 Thread Michał Winiarski
Testing LNCFCMOCS values on non-render engines is tricky. The values in those registers are lost on RC6, which means that if users of non-render engines want to see the proper values, they need to obtain a forcewake and execute something on render (relying on it to restore the values) before using

[Intel-gfx] ✗ Fi.CI.BAT: failure for New engine discovery and execbuffer2 engine selection uAPI (rev9)

2017-06-28 Thread Patchwork
== Series Details == Series: New engine discovery and execbuffer2 engine selection uAPI (rev9) URL : https://patchwork.freedesktop.org/series/23189/ State : failure == Summary == Series 23189v9 New engine discovery and execbuffer2 engine selection uAPI https://patchwork.freedesktop.org/api/1.0

Re: [Intel-gfx] [PATCH] fbcon: Make fbcon a built-time depency for fbdev

2017-06-28 Thread Daniel Vetter
On Wed, Jun 28, 2017 at 5:08 PM, Steven Rostedt wrote: > On Wed, 28 Jun 2017 12:36:35 +0200 > Daniel Vetter wrote: > >> There's a bunch of folks who're trying to make printk less >> contended and faster, but there's a problem: printk uses the >> console_lock, and the console lock has become the B

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drain the device workqueue on unload

2017-06-28 Thread Patchwork
== Series Details == Series: drm/i915: Drain the device workqueue on unload URL : https://patchwork.freedesktop.org/series/26494/ State : success == Summary == Series 26494v1 drm/i915: Drain the device workqueue on unload https://patchwork.freedesktop.org/api/1.0/series/26494/revisions/1/mbox/

Re: [Intel-gfx] [PATCH] drm/fb-helper: Support deferred setup

2017-06-28 Thread Liviu Dudau
On Wed, Jun 28, 2017 at 01:32:01PM +0200, Daniel Vetter wrote: > FB helper code falls back to a 1024x768 mode if no outputs are connected > or don't report back any modes upon initialization. This can be annoying > because outputs that are added to FB helper later on can't be used with > FB helper

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib: Add reset-type helper in ioctl_wrappers

2017-06-28 Thread Michel Thierry
On 6/28/2017 7:10 AM, Arkadiusz Hiler wrote: On Tue, Jun 20, 2017 at 11:25:01AM -0700, Michel Thierry wrote: Soon we will have tests that are only for platforms with reset-engine (GEN8+), so add a helper to query the has_gpu_reset via the getparam ioctl. Signed-off-by: Michel Thierry --- lib

Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

2017-06-28 Thread Srivatsa, Anusha
>-Original Message- >From: Hiler, Arkadiusz >Sent: Wednesday, June 28, 2017 5:20 AM >To: Srivatsa, Anusha >Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo >Subject: Re: [Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs >for S >SKU. > >On Wed, Jun 28, 2017 at 03:17:00PM

[Intel-gfx] [PATCH i-g-t v2 1/2] lib: Add reset-type helper in ioctl_wrappers

2017-06-28 Thread Michel Thierry
Soon we will have tests that are only for platforms with reset-engine (GEN8+), so add a helper to query the has_gpu_reset via the getparam ioctl. v2: Add more helper functions to avoid using magic numbers in tests (Arek). Cc: Arkadiusz Hiler Signed-off-by: Michel Thierry --- lib/ioctl_wrappers

[Intel-gfx] [PATCH i-g-t v2 2/2] tests/gem_reset_stats: Enforce full chip reset mode before run

2017-06-28 Thread Michel Thierry
Platforms with per-engine reset enabled (i915.reset=2) are unlikely to perform a full chip reset, keeping the reset_count unmodified. In order to keep the expectations of this test, enforce that full GPU reset is enabled (i915.reset=1). Later on, we can expand the reset_stats ioctl to also return

[Intel-gfx] [PATCH v3 0/6] drm: add asynchrounous plane update

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Hi, This is just a rebase on top of latest drm-misc-next. Last iteration can be found here: https://www.spinics.net/lists/intel-gfx/msg130582.html Please review! Thanks, Gustavo --- Gustavo Padovan (6): drm/atomic: initial support for asynchronous plane update

[Intel-gfx] [PATCH v3 1/6] drm/atomic: initial support for asynchronous plane update

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan In some cases, like cursor updates, it is interesting to update the plane in an asynchronous fashion to avoid big delays. The current queued update could be still waiting for a fence to signal and thus block any subsequent update until its scan out. In cases like this if we

[Intel-gfx] [PATCH v3 3/6] drm/i915: remove intel_cursor_plane_funcs

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits intel_cursor_plane_funcs just duplicates intel_plane_funcs now. Cc: Daniel Vetter Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/i915/intel_display.c | 13 + 1 file changed, 1 insertion(+), 12

[Intel-gfx] [PATCH v3 2/6] drm/i915: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what intel_legacy_cursor_update() did but through atomic. v3: - set correct vma to new state for cleanup - move size checks back to driv

[Intel-gfx] [PATCH v3 4/6] drm/msm: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what mdp5_update_cursor_plane_legacy() did but through atomic. v4: add missing atomic async commit call to msm_atomic_commit(Archit Taneja) v3: move si

[Intel-gfx] [PATCH v3 5/6] drm/msm: remove mdp5_cursor_plane_funcs

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan After converting legacy cursor updates to atomic async commits mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now. Cc: Rob Clark Cc: Archit Taneja Signed-off-by: Gustavo Padovan Tested-by: Archit Taneja --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 26 +++--

[Intel-gfx] [PATCH v3 6/6] drm/vc4: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan Add support for async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what vc4_update_plane() did but through atomic. v5: add missing call to vc4_plane_atomic_check() (Eric Anholt) v4: add drm_atomic_helper_async() commi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: add asynchrounous plane update (rev4)

2017-06-28 Thread Patchwork
== Series Details == Series: drm: add asynchrounous plane update (rev4) URL : https://patchwork.freedesktop.org/series/25814/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHK

Re: [Intel-gfx] [RESEND i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl

2017-06-28 Thread Clint Taylor
On 06/22/2017 09:28 AM, Anusha Srivatsa wrote: From: anushasr Follow the spec and add ID for U SKU v2: Update IDs in accordance to the kernel commit: d29fe702c9cb682df99146d24d06e5455f043101 (Chris) Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- lib/i915_pciids.h | 9 - 1

[Intel-gfx] [PATCH] drm/i915: reintroduce VLV/CHV PFI programming power domain workaround

2017-06-28 Thread Gabriel Krisman Bertazi
There are still cases on these platforms where an attempt is made to configure the CDCLK while the power domain is off, like when coming back from a suspend. So the workaround below is still needed. This effectively reverts commit 63ff30442519 ("drm/i915: Nuke the VLV/CHV PFI programming power do

Re: [Intel-gfx] [PATCH libdrm 1/3] intel: PCI Ids for S SKU in CFL

2017-06-28 Thread Clint Taylor
On 06/21/2017 09:39 AM, Anusha Srivatsa wrote: Add the PCI IDs for S SKU IN CFL by following the spec. v2: Update IDs. Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- intel/intel_chipset.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/intel/int

Re: [Intel-gfx] [PATCH libdrm 2/3] intel: PCI Ids for H SKU in CFL

2017-06-28 Thread Clint Taylor
On 06/21/2017 09:39 AM, Anusha Srivatsa wrote: Add the PCI IDs for H SKU IN CFL by following the spec. v2: Update IDs Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- intel/intel_chipset.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/intel/intel_chipset.h

Re: [Intel-gfx] [PATCH libdrm 3/3] intel: PCI Ids for U SKU in CFL

2017-06-28 Thread Clint Taylor
On 06/21/2017 09:39 AM, Anusha Srivatsa wrote: Add the PCI IDs for U SKU IN CFL by following the spec. v2: Update IDs Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- intel/intel_chipset.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/intel/intel_chi

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm: add asynchrounous plane update (rev4)

2017-06-28 Thread Gustavo Padovan
This patch is meant for drm-misc, where the changes to intel_plane->update_plane() and intel_plane->disable_plane() are not present, so this patchset just builds fine there. 2017-06-28 Patchwork : > == Series Details == > > Series: drm: add asynchrounous plane update (rev4) > URL : https://pat

Re: [Intel-gfx] [PATCH] drm/i915: Set all undefined MOCS entries to follow PTE

2017-06-28 Thread Francisco Jerez
Chris Wilson writes: > Quoting Francisco Jerez (2017-05-04 21:59:44) >> Chris Wilson writes: >> >> > On Thu, May 04, 2017 at 10:56:54AM -0700, Francisco Jerez wrote: >> >> David Weinehall writes: >> >> >> >> > On Thu, May 04, 2017 at 10:51:29AM +0100, Chris Wilson wrote: >> >> >> A good defau

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: reintroduce VLV/CHV PFI programming power domain workaround

2017-06-28 Thread Patchwork
== Series Details == Series: drm/i915: reintroduce VLV/CHV PFI programming power domain workaround URL : https://patchwork.freedesktop.org/series/26509/ State : success == Summary == Series 26509v1 drm/i915: reintroduce VLV/CHV PFI programming power domain workaround https://patchwork.freedes

[Intel-gfx] [PATCH] drm/i915: Skip i915_swizzle_info in platforms without GPU side swizzle

2017-06-28 Thread Michel Thierry
There's no need to keep reading random registers in i915_swizzle_info if the platform is not doing GPU side swizzling. After HSW, swizzling is not used, and the CPU's memory controller performs all the address swizzling modifications, commit be292e1563ac5b ("drm/i915/bdw: Let the memory controller

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Skip i915_swizzle_info in platforms without GPU side swizzle

2017-06-28 Thread Patchwork
== Series Details == Series: drm/i915: Skip i915_swizzle_info in platforms without GPU side swizzle URL : https://patchwork.freedesktop.org/series/26517/ State : success == Summary == Series 26517v1 drm/i915: Skip i915_swizzle_info in platforms without GPU side swizzle https://patchwork.freed

[Intel-gfx] [PATCH v2] drm/i915/edp: Add a T12 panel delay quirk to fix DP AUX CH timeouts

2017-06-28 Thread Manasi Navare
This patch fixes the DP AUX CH timeouts observed during CI IGT tests thus fixing the CI failures. This is done by adding a quirk for a particular PCI device that requires the panel power cycle delay (T12) to be 300msecs more than the minimum value specified in the eDP spec. So a quirk is implemente

Re: [Intel-gfx] [PATCH v2] drm/i915/edp: Add a T12 panel delay quirk to fix DP AUX CH timeouts

2017-06-28 Thread Clint Taylor
Looks Good. Reviewed-by: Clinton Taylor -Clint On 06/28/2017 05:14 PM, Manasi Navare wrote: This patch fixes the DP AUX CH timeouts observed during CI IGT tests thus fixing the CI failures. This is done by adding a quirk for a particular PCI device that requires the panel power cycle delay (

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Add a T12 panel delay quirk to fix DP AUX CH timeouts

2017-06-28 Thread Patchwork
== Series Details == Series: drm/i915/edp: Add a T12 panel delay quirk to fix DP AUX CH timeouts URL : https://patchwork.freedesktop.org/series/26518/ State : success == Summary == Series 26518v1 drm/i915/edp: Add a T12 panel delay quirk to fix DP AUX CH timeouts https://patchwork.freedesktop

[Intel-gfx] [RESEND i-g-t 1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

2017-06-28 Thread Anusha Srivatsa
Just following the spec and adding these extra IDs. v2: update IDs following the kernel commit: b056f8f3d6b900e8afd19f312719160346d263b4 (Chris) Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Clint Taylor --- lib/i915_pciids.h | 10 ++ lib/intel_device_info.c | 2

[Intel-gfx] [RESEND i-g-t 2/3] lib/cfl: Add PCI IDs to H SKU in CFl

2017-06-28 Thread Anusha Srivatsa
Follow the spec and add the ID for H SKU in CFL. v2: Update IDs following kernel commit: ccfd13215fd25a0e8c28221f3acc0dcaec11cd15 (Chris) Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Clint Taylor --- lib/i915_pciids.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-

[Intel-gfx] [RESEND i-g-t 3/3] lib/cfl: Add PCI Ids for U SKU in CFl

2017-06-28 Thread Anusha Srivatsa
Follow the spec and add ID for U SKU v2: Update IDs in accordance to the kernel commit: d29fe702c9cb682df99146d24d06e5455f043101 (Chris) Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa Reviewed-by: Clint Taylor --- lib/i915_pciids.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-

Re: [Intel-gfx] [PATCH 05/20] drm/i915: introduce page_size members

2017-06-28 Thread Zhenyu Wang
On 2017.06.27 15:54:29 +0100, Matthew Auld wrote: > In preparation for supporting huge gtt pages for the ppgtt, we introduce > page size members for gem objects. We fill in the page sizes by > scanning the sg table. > > v2: pass the sg_mask to set_pages > > v3: calculate the sg_mask inline with

Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-06-28 Thread Gerd Hoffmann
Hi, > > Does gvt track the live cycle of all dma-bufs it has handed out? > > The V9 implementation does track the dma-bufs' live cycle. The > original idea was that leaving the dma-bufs' live cycle management to > user mode. That is still the case, user space decides which dma-bufs it'll go ke

[Intel-gfx] [GIT PULL] GVT-g fixes for drm-intel-next-fixes

2017-06-28 Thread Zhenyu Wang
Hi, this is current gvt fixes after 4.13 stuff got pulled in drm-intel-next. Mostly two race fixes and several virtual display fixes on BDW. Thanks. -- The following changes since commit e274086e473c0cbea18051ae0a78a05f8d658f47: drm/i915/gvt: clean up unsubmited workloads before destroying kme