[Intel-gfx] [PATCH v7 1/2] drm/i915: Enable guest i915 48bit full ppgtt functionality

2017-07-07 Thread Zhenyu Wang
From: Tina Zhang Enable the guest i915 48bit full ppgtt functionality when host can provide the capability. vgt_caps is introduced to guest i915 driver to get the vgpu capabilities from the device model. VGT_CAPS_FULL_PPGTT_48BIT is one of the capabilities type which let guest i915 dirver know th

[Intel-gfx] [PATCH v7 2/2] drm/i915/gvt: Fix guest i915 48bit full ppgtt blocking issue

2017-07-07 Thread Zhenyu Wang
From: Tina Zhang Guest i915 48bit full ppgtt functionality was blocking by an issue, which would lead to gpu hardware hang. Guest i915 driver may update the ppgtt table just before this workload is going to be submitted to the hardware by device model. This case wasn't handled well by device mode

Re: [Intel-gfx] [PATCH v7 1/2] drm/i915: Enable guest i915 48bit full ppgtt functionality

2017-07-07 Thread Zhenyu Wang
On 2017.07.07 15:29:38 +0800, Zhenyu Wang wrote: > From: Tina Zhang > > Enable the guest i915 48bit full ppgtt functionality when host can provide > the capability. vgt_caps is introduced to guest i915 driver to get the vgpu > capabilities from the device model. VGT_CAPS_FULL_PPGTT_48BIT is one o

[Intel-gfx] ✓ Fi.CI.BAT: success for YCBCR 4:2:0 handling in DRM layer

2017-07-07 Thread Patchwork
== Series Details == Series: YCBCR 4:2:0 handling in DRM layer URL : https://patchwork.freedesktop.org/series/26972/ State : success == Summary == Series 26972v1 YCBCR 4:2:0 handling in DRM layer https://patchwork.freedesktop.org/api/1.0/series/26972/revisions/1/mbox/ Test gem_exec_flush:

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Fix the kernel panic when using aliasing ppgtt

2017-07-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix the kernel panic when using aliasing ppgtt URL : https://patchwork.freedesktop.org/series/26977/ State : warning == Summary == Series 26977v1 drm/i915: Fix the kernel panic when using aliasing ppgtt https://patchwork.freedesktop.org/api/1.0/series/269

Re: [Intel-gfx] [PATCH] drm/i915: Fix the kernel panic when using aliasing ppgtt

2017-07-07 Thread Matthew Auld
On 7 July 2017 at 07:00, Chuanxiao Dong wrote: > The ppgtt should be get directly from i915_address_space *vm instead of > vma->vm as in alias ppgtt case the vma->vm is not same with vm. > > Fixes: 4a234c5fae16 ("drm/i915: pass the vma to insert_entries") > Bugzilla:https://bugs.freedesktop.org/sh

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v7,1/2] drm/i915: Enable guest i915 48bit full ppgtt functionality

2017-07-07 Thread Patchwork
== Series Details == Series: series starting with [v7,1/2] drm/i915: Enable guest i915 48bit full ppgtt functionality URL : https://patchwork.freedesktop.org/series/26980/ State : success == Summary == Series 26980v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

2017-07-07 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Don't trust VBT's alternate pin for port D for now. URL : https://patchwork.freedesktop.org/series/26956/ State : success == Summary == Series 26956v1 drm/i915/cnl: Don't trust VBT's alternate pin for port D for now. https://patchwork.freedesktop.org/

Re: [Intel-gfx] [PATCH] drm/i915: Fix the kernel panic when using aliasing ppgtt

2017-07-07 Thread Chris Wilson
Quoting Chuanxiao Dong (2017-07-07 07:00:09) > The ppgtt should be get directly from i915_address_space *vm instead of > vma->vm as in alias ppgtt case the vma->vm is not same with vm. And for consistency, also @@ -2242,7 +2242,7 @@ static void bxt_vtd_ggtt_insert_entries__BKL(struct i915_addres

Re: [Intel-gfx] [PATCH] drm/i915: Fix the kernel panic when using aliasing ppgtt

2017-07-07 Thread Dong, Chuanxiao
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Friday, July 7, 2017 5:38 PM > To: Dong, Chuanxiao ; intel- > g...@lists.freedesktop.org > Cc: intel-gvt-...@lists.freedesktop.org; Dong, Chuanxiao > ; Auld, Matthew ; > Zhenyu Wang > Subject: Re: [PATCH] d

[Intel-gfx] [PATCH v2] drm/i915: Fix the kernel panic when using aliasing ppgtt

2017-07-07 Thread Chuanxiao Dong
The ppgtt should be get directly from i915_address_space *vm instead of vma->vm. v2: - add one more fix for bxt. (Chris) Fixes: 4a234c5fae16 ("drm/i915: pass the vma to insert_entries") Bugzilla:https://bugs.freedesktop.org/show_bug.cgi?id=101713 Signed-off-by: Chuanxiao Dong Reviewed-by: Matthe

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix the kernel panic when using aliasing ppgtt

2017-07-07 Thread Chris Wilson
Quoting Chuanxiao Dong (2017-07-07 10:50:59) > The ppgtt should be get directly from i915_address_space *vm instead of > vma->vm. > > v2: > - add one more fix for bxt. (Chris) > > Fixes: 4a234c5fae16 ("drm/i915: pass the vma to insert_entries") > Bugzilla:https://bugs.freedesktop.org/show_bug.cgi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix the kernel panic when using aliasing ppgtt (rev2)

2017-07-07 Thread Patchwork
== Series Details == Series: drm/i915: Fix the kernel panic when using aliasing ppgtt (rev2) URL : https://patchwork.freedesktop.org/series/26977/ State : success == Summary == Series 26977v2 drm/i915: Fix the kernel panic when using aliasing ppgtt https://patchwork.freedesktop.org/api/1.0/ser

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Allow execbuffer to use the first object as the batch

2017-07-07 Thread Daniel Vetter
On Fri, Mar 17, 2017 at 12:15 PM, Joonas Lahtinen wrote: > On to, 2017-03-16 at 13:20 +, Chris Wilson wrote: >> Currently, the last object in the execlist is the always the batch. >> However, when building the batch buffer we often know the batch object >> first and if we can use the first slo

[Intel-gfx] [PATCH 3/3] drm/i915: Consolidate max_cdclk_freq check in intel_crtc_compute_min_cdclk()

2017-07-07 Thread ville . syrjala
From: Ville Syrjälä Currently the .modeset_calc_cdclk() hooks check the final cdclk value against the max allowed. That's not really sufficient since the low level calc_cdclk() functions effectively clamp the minimum required cdclk to the max supported by the platform. Hence if the minimum requir

[Intel-gfx] [PATCH 2/3] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock"

2017-07-07 Thread ville . syrjala
From: Ville Syrjälä Make the min_pixclk thing less confusing by changing it to track the minimum acceptable cdclk frequency instead. This means moving the application of the guardbands to a slightly higher level from the low level platform specific calc_cdclk() functions. The immediate benefit i

[Intel-gfx] [PATCH 1/3] drm/i915: Fix up CNL cdclk related limits

2017-07-07 Thread ville . syrjala
From: Ville Syrjälä Follow the GLK path when computing cdclk and related limits. CNL pipes also produce two pixels per clock, so that's what we should use. For the HBR2 vs. audio issue the limit should more correctly be 336 MHz, but the GLK limit of 316.8 MHz works just as well and results in pi

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Version the MOCS settings

2017-07-07 Thread Chris Wilson
Quoting Ben Widawsky (2017-07-07 00:27:01) > drivers/gpu/drm/i915/i915_drv.c | 3 +++ > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/i915_pci.c | 13 + > include/uapi/drm/i915_drm.h | 8 > 4 files changed, 22 insertions(+), 4 deletions(-) > > diff --g

Re: [Intel-gfx] Skylake / (EE) modeset(0): present flip failed loop

2017-07-07 Thread Chris Wilson
Quoting Marc MERLIN (2017-07-07 06:40:51) > Is this the right place to send this? > Can anyone help? > > On Wed, Jul 05, 2017 at 11:33:01PM -0700, Marc MERLIN wrote: > > Howdy, > > > > I have a thinkpad P70 with debian testing and 4.11.6 kernel. > > A recent-ish upgrade broke something and now I'

Re: [Intel-gfx] [PATCH] drm/crc: Only open CRC on atomic drivers when the CRTC is active.

2017-07-07 Thread Daniel Vetter
On Thu, Jul 06, 2017 at 03:03:15PM +0200, Maarten Lankhorst wrote: > Op 06-07-17 om 13:09 schreef Tomeu Vizoso: > > Looks good to me: > > > > Reviewed-by: Tomeu Vizoso > > > > I guess you have tested this with IGT? In any case, I think it would > > be good to mention how a patch has been tested in

Re: [Intel-gfx] [Mesa-dev] [PATCH 1/1] drm/i915: Version the MOCS settings

2017-07-07 Thread Emil Velikov
On 7 July 2017 at 11:34, Chris Wilson wrote: > Quoting Ben Widawsky (2017-07-07 00:27:01) >> drivers/gpu/drm/i915/i915_drv.c | 3 +++ >> drivers/gpu/drm/i915/i915_drv.h | 2 ++ >> drivers/gpu/drm/i915/i915_pci.c | 13 + >> include/uapi/drm/i915_drm.h | 8 >> 4 files ch

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Fix up CNL cdclk related limits

2017-07-07 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Fix up CNL cdclk related limits URL : https://patchwork.freedesktop.org/series/26988/ State : success == Summary == Series 26988v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/26988/revisions/1/mb

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Allow execbuffer to use the first object as the batch

2017-07-07 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-07 11:17:22) > On Fri, Mar 17, 2017 at 12:15 PM, Joonas Lahtinen > wrote: > > On to, 2017-03-16 at 13:20 +, Chris Wilson wrote: > >> Currently, the last object in the execlist is the always the batch. > >> However, when building the batch buffer we often know the

Re: [Intel-gfx] [PATCH v3 21/22] drm/atomic: Introduce drm_atomic_helper_duplicate_commited_state()

2017-07-07 Thread Daniel Vetter
On Thu, Jul 06, 2017 at 11:24:41PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > For i915 GPU reset handling we'll want to be able to duplicate the state > that was last commited to the hardware. For that purpose let's start to > track the commited state for each object an

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Inherit RPS stuff from previous platforms.

2017-07-07 Thread David Weinehall
On Thu, Jul 06, 2017 at 01:41:13PM -0700, Rodrigo Vivi wrote: > Apparently no change on RPS stuff from previous platforms. > > v2: Merging to rps related patches in one and also adding > missed cases. > > Cc: David Weinehall > Signed-off-by: Rodrigo Vivi Double-checking BSpec didn't yield

Re: [Intel-gfx] [PATCH v3 21/22] drm/atomic: Introduce drm_atomic_helper_duplicate_commited_state()

2017-07-07 Thread Ville Syrjälä
On Fri, Jul 07, 2017 at 02:03:38PM +0200, Daniel Vetter wrote: > On Thu, Jul 06, 2017 at 11:24:41PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > For i915 GPU reset handling we'll want to be able to duplicate the state > > that was last commited to the hardware. For

Re: [Intel-gfx] [PATCH 5/5] drm/hisilicon: Remove custom FB helper deferred setup

2017-07-07 Thread Sean Paul
On Thu, Jul 6, 2017 at 9:00 AM, Daniel Vetter wrote: > From: Thierry Reding > > The FB helper core now supports deferred setup, so the driver's custom > implementation can be removed. > > v2: Dont' resurrect drm_vblank_cleanup. > > Cc: Xinliang Liu > Cc: Rongrong Zou > Cc: Xinwei Kong > Cc: Ch

Re: [Intel-gfx] [PATCH IGT v2 2/6] lib: Add PSR utility functions to igt library.

2017-07-07 Thread Jim Bride
On Fri, Jun 30, 2017 at 01:11:52PM -0700, Rodrigo Vivi wrote: > On Fri, Jun 30, 2017 at 12:12 PM, Jim Bride wrote: > > Factor out some code that was replicated in three test utilities into > > some new IGT library functions so that we are checking PSR status in > > a consistent fashion across all

Re: [Intel-gfx] [PATCH IGT v2 2/6] lib: Add PSR utility functions to igt library.

2017-07-07 Thread Jim Bride
On Fri, Jun 30, 2017 at 05:54:32PM -0300, Paulo Zanoni wrote: > Em Sex, 2017-06-30 às 12:12 -0700, Jim Bride escreveu: > > Factor out some code that was replicated in three test utilities into > > some new IGT library functions so that we are checking PSR status in > > a consistent fashion across a

Re: [Intel-gfx] [PATCH v3 21/22] drm/atomic: Introduce drm_atomic_helper_duplicate_commited_state()

2017-07-07 Thread Daniel Vetter
On Fri, Jul 7, 2017 at 3:21 PM, Ville Syrjälä wrote: > On Fri, Jul 07, 2017 at 02:03:38PM +0200, Daniel Vetter wrote: >> On Thu, Jul 06, 2017 at 11:24:41PM +0300, ville.syrj...@linux.intel.com >> wrote: >> > From: Ville Syrjälä >> > >> > For i915 GPU reset handling we'll want to be able to dupli

[Intel-gfx] [PATCH v2 06/18] drm/i915: Check for duplicated power well IDs

2017-07-07 Thread Imre Deak
Check that all the power well IDs are unique on the given platform. v2: - Fix using BIT_ULL() instead of BIT() for 64 bit mask. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_runtime_pm.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_runtim

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Unify the HSW/BDW and GEN9+ power well code (rev2)

2017-07-07 Thread Patchwork
== Series Details == Series: drm/i915: Unify the HSW/BDW and GEN9+ power well code (rev2) URL : https://patchwork.freedesktop.org/series/26922/ State : success == Summary == Series 26922v2 drm/i915: Unify the HSW/BDW and GEN9+ power well code https://patchwork.freedesktop.org/api/1.0/series/26

Re: [Intel-gfx] [PATCH v3 21/22] drm/atomic: Introduce drm_atomic_helper_duplicate_commited_state()

2017-07-07 Thread Ville Syrjälä
On Fri, Jul 07, 2017 at 04:05:28PM +0200, Daniel Vetter wrote: > On Fri, Jul 7, 2017 at 3:21 PM, Ville Syrjälä > wrote: > > On Fri, Jul 07, 2017 at 02:03:38PM +0200, Daniel Vetter wrote: > >> On Thu, Jul 06, 2017 at 11:24:41PM +0300, ville.syrj...@linux.intel.com > >> wrote: > >> > From: Ville Sy

Re: [Intel-gfx] [Mesa-dev] [PATCH 1/1] drm/i915: Version the MOCS settings

2017-07-07 Thread Jason Ekstrand
On Fri, Jul 7, 2017 at 3:34 AM, Chris Wilson wrote: > Quoting Ben Widawsky (2017-07-07 00:27:01) > > drivers/gpu/drm/i915/i915_drv.c | 3 +++ > > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/i915_pci.c | 13 + > > include/uapi/drm/i915_drm.h | 8 > >

Re: [Intel-gfx] [PATCH 3/3] intel: Make driver aware of MOCS table version

2017-07-07 Thread Jason Ekstrand
On Thu, Jul 6, 2017 at 4:27 PM, Ben Widawsky wrote: > We don't yet have optimal MOCS settings, but we have enough to know how > to at least determine when we might have non-optimal settings within our > driver. > > Signed-off-by: Ben Widawsky > --- > src/intel/vulkan/anv_device.c |

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

2017-07-07 Thread Rodrigo Vivi
patch merged to dinq. thanks for reviewing. On Thu, Jul 6, 2017 at 2:52 PM, Clint Taylor wrote: > > > On 07/06/2017 02:08 PM, Rodrigo Vivi wrote: >> >> Cannon Lake's VBT that is currently available for B0 stepping >> states that port D uses alternate pin 3 messing up with the >> default pin-port

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Inherit RPS stuff from previous platforms.

2017-07-07 Thread Rodrigo Vivi
patch merged to dinq. thanks for reviewing. On Fri, Jul 7, 2017 at 5:03 AM, David Weinehall wrote: > On Thu, Jul 06, 2017 at 01:41:13PM -0700, Rodrigo Vivi wrote: >> Apparently no change on RPS stuff from previous platforms. >> >> v2: Merging to rps related patches in one and also adding >> m

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Gen10 render context size.

2017-07-07 Thread Rodrigo Vivi
patch merged to dinq. thanks for reviewing. On Thu, Jul 6, 2017 at 7:51 PM, Ben Widawsky wrote: > On 17-07-06 14:06:24, Vivi, Rodrigo wrote: >> >> No change on render context size is required for Gen10. >> >> So this patch doesn't change the default behaviour, >> but only avoid the missing_case m

[Intel-gfx] [PATCH i-g-t] igt/perf: add tests to verify create/destroy userspace configs

2017-07-07 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 135 +++ 1 file changed, 135 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index db28ba1f..14bbb361 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -146,6 +146,33 @@ enum drm_i915

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Get DDI clock based on PLLs.

2017-07-07 Thread Rodrigo Vivi
patch merged to dinq. On Thu, Jul 6, 2017 at 1:52 PM, Rodrigo Vivi wrote: > PLLs are the source clocks for the DDIs so in order > to determine the ddi clock we need to check the PLL > configuration. > > v2: Mika pointed out that 24 was hardcoded while it > should consider ref clock that can b

[Intel-gfx] [PATCH 1/2] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-07 Thread Lionel Landwerlin
From: Matthew Auld The motivation behind this new interface is expose at runtime the creation of new OA configs which can be used as part of the i915 perf open interface. This will enable the kernel to learn new configs which may be experimental, or otherwise not part of the core set currently av

[Intel-gfx] [PATCH 0/2] drm/i915/perf: Add support for loadable OA configs

2017-07-07 Thread Lionel Landwerlin
Hi, This series adds support for loadable OA configurations. It is based off Matthew's initial work. This idea is to let userspace mostly hold these configurations, so they can be tweaked from userspace without patching the kernel, which is quite useful for debug purposes. I've made sent IGT test

[Intel-gfx] [PATCH] drm/i915: Force CPU synchronisation even if userspace requests ASYNC

2017-07-07 Thread Chris Wilson
The goal here was to minimise doing any thing or any check inside the kernel that was not strictly required. For a userspace that assumes complete control over the cache domains, the kernel is usually using outdated information and may trigger clflushes where none were required. However, swapping

Re: [Intel-gfx] Skylake / (EE) modeset(0): present flip failed loop

2017-07-07 Thread Marc MERLIN
On Fri, Jul 07, 2017 at 11:47:25AM +0100, Chris Wilson wrote: > Quoting Marc MERLIN (2017-07-07 06:40:51) > > Is this the right place to send this? > > Can anyone help? > > > > On Wed, Jul 05, 2017 at 11:33:01PM -0700, Marc MERLIN wrote: > > > Howdy, > > > > > > I have a thinkpad P70 with debian

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-07 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-07-07 18:08:37) > +static bool gen8_is_valid_flex_addr(struct drm_i915_private *dev_priv, u32 > addr) > +{ > + static const i915_reg_t flex_eu_regs[] = { > + EU_PERF_CNTL0, > + EU_PERF_CNTL1, > + EU_PERF_CNTL2, > +

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix up CNL cdclk related limits

2017-07-07 Thread Rodrigo Vivi
I will review the series more carefully later, but my concern is that with this series applied I got a blank screen on eDP... On Fri, Jul 7, 2017 at 3:24 AM, wrote: > From: Ville Syrjälä > > Follow the GLK path when computing cdclk and related limits. CNL > pipes also produce two pixels per cl

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Add max allowed Cannonlake DC.

2017-07-07 Thread Imre Deak
On Thu, Jul 06, 2017 at 01:45:08PM -0700, Rodrigo Vivi wrote: > This is a follow-up after enabling DC states with > commit: "drm/i915/DMC/CNL: Load DMC on CNL". > > Cc: Anusha Srivatsa > Cc: Imre Deak > Signed-off-by: Rodrigo Vivi Reviewed-by: Imre Deak We could add max_dc_state to intel_dev

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Add support for loadable OA configs

2017-07-07 Thread Patchwork
== Series Details == Series: drm/i915/perf: Add support for loadable OA configs URL : https://patchwork.freedesktop.org/series/27011/ State : success == Summary == Series 27011v1 drm/i915/perf: Add support for loadable OA configs https://patchwork.freedesktop.org/api/1.0/series/27011/revisions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Force CPU synchronisation even if userspace requests ASYNC

2017-07-07 Thread Patchwork
== Series Details == Series: drm/i915: Force CPU synchronisation even if userspace requests ASYNC URL : https://patchwork.freedesktop.org/series/27012/ State : success == Summary == Series 27012v1 drm/i915: Force CPU synchronisation even if userspace requests ASYNC https://patchwork.freedeskt

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix up CNL cdclk related limits

2017-07-07 Thread Ville Syrjälä
On Fri, Jul 07, 2017 at 10:54:47AM -0700, Rodrigo Vivi wrote: > I will review the series more carefully later, > but my concern is that with this series applied I got a blank screen on eDP... Hmm. Oh, I guess we could now be going for a lower cdclk that before since we now account for 2 pixels per

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Track minimum acceptable cdclk instead of "minimum dotclock"

2017-07-07 Thread Ville Syrjälä
On Fri, Jul 07, 2017 at 01:24:49PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make the min_pixclk thing less confusing by changing it to track > the minimum acceptable cdclk frequency instead. This means moving > the application of the guardbands to a slightly higher le

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix up CNL cdclk related limits

2017-07-07 Thread Pandiyan, Dhinakaran
iirc I assumed 1 pixel per clk for CNL when I originally submitted the workaround patch because cnl_xxx_calc_cdclk() functions assume that. Are we missing something in the cdclk setup code to enable 2 pixels per clk? -DK From: Ville Syrjälä [ville.syrj...

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Version the MOCS settings

2017-07-07 Thread Ben Widawsky
On 17-07-07 11:34:48, Chris Wilson wrote: Quoting Ben Widawsky (2017-07-07 00:27:01) drivers/gpu/drm/i915/i915_drv.c | 3 +++ drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 13 + include/uapi/drm/i915_drm.h | 8 4 files changed, 22 insertio

Re: [Intel-gfx] [Mesa-dev] [PATCH 1/1] drm/i915: Version the MOCS settings

2017-07-07 Thread Ben Widawsky
On 17-07-07 09:23:26, Jason Ekstrand wrote: On Fri, Jul 7, 2017 at 3:34 AM, Chris Wilson wrote: Quoting Ben Widawsky (2017-07-07 00:27:01) > drivers/gpu/drm/i915/i915_drv.c | 3 +++ > drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 13 + > include/uapi

Re: [Intel-gfx] [PATCH IGT v2 5/6] tests/kms_frontbuffer_tracking: Fix multidraw subtest

2017-07-07 Thread Paulo Zanoni
Em Sex, 2017-06-30 às 12:12 -0700, Jim Bride escreveu: > The multidraw subtest was not taking whether or not the GEM buffer > had > ever been in write-combining mode when checking for PSR state, so fix > that. Reviewed-by: Paulo Zanoni > > Signed-off-by: Jim Bride > --- >  tests/kms_frontbuffe

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Version the MOCS settings

2017-07-07 Thread Chris Wilson
Quoting Ben Widawsky (2017-07-07 19:42:25) > On 17-07-07 11:34:48, Chris Wilson wrote: > >Quoting Ben Widawsky (2017-07-07 00:27:01) > >> drivers/gpu/drm/i915/i915_drv.c | 3 +++ > >> drivers/gpu/drm/i915/i915_drv.h | 2 ++ > >> drivers/gpu/drm/i915/i915_pci.c | 13 + > >> include/ua

Re: [Intel-gfx] [RFC] drm/i915/lrc: allocate separate page for HWSP

2017-07-07 Thread Daniele Ceraolo Spurio
On 06/07/17 11:51, Michel Thierry wrote: On 7/6/2017 10:59 AM, Chris Wilson wrote: > If there are no conflicts, then just skip the patch, and really there > shouldn't be since the writes we care about are ordered and the writes > we don't, we don't. We will need to move to per-context hwsp i

Re: [Intel-gfx] [PATCH IGT v2 4/6] tests/kms_frontbuffer_tracking: Refactor to use IGT PSR library functions

2017-07-07 Thread Jim Bride
On Fri, Jun 30, 2017 at 01:19:57PM -0700, Rodrigo Vivi wrote: > I believe it would be better to create the psr lib with only one > function at time and on every patch that adds the new function already > removes that from here and from frontbuffer tracking test as well... > > easier to review and

[Intel-gfx] [RESEND v2 1/2] drm/i915/dp: Generalize intel_dp_link_params function to accept arguments to be validated

2017-07-07 Thread Manasi Navare
This function now takes the link rate and lane ocunt to be validated as an argument so that this can be used for validating even the compliance test link parameters. Signed-off-by: Manasi Navare Cc: Ville Syrjala Cc: Jani Nikula Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 1

[Intel-gfx] [RESEND v2 2/2] drm/i915/dp: Validate the compliance test link parameters

2017-07-07 Thread Manasi Navare
Validate the compliance test link parameters when the compliance test dpcd registers are read. Also validate them in compute_config before using them since the max values might have been reduced due to link training fallback. If either the link rate or lane count is invalid, we still bail from usi

Re: [Intel-gfx] [PATCH 2/4] fbdev: Nuke FBINFO_MODULE

2017-07-07 Thread kbuild test robot
Hi Daniel, [auto build test ERROR on linus/master] [also build test ERROR on v4.12 next-20170707] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/fbcon-Make-fbcon-a-built-time

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RESEND,v2,1/2] drm/i915/dp: Generalize intel_dp_link_params function to accept arguments to be validated

2017-07-07 Thread Patchwork
== Series Details == Series: series starting with [RESEND,v2,1/2] drm/i915/dp: Generalize intel_dp_link_params function to accept arguments to be validated URL : https://patchwork.freedesktop.org/series/27028/ State : success == Summary == Series 27028v1 Series without cover letter https://pa

Re: [Intel-gfx] [RFC] drm/i915/lrc: allocate separate page for HWSP

2017-07-07 Thread Michel Thierry
On 07/07/17 14:15, Daniele Ceraolo Spurio wrote: After a bit of investigation I've found that the issue is not actually with the positioning of the HWSP but with the fact that we use status_page.ggtt_offset to point to the lrca offset of the default context in guc_ads_create instead of using k

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-07-07 Thread Matthew Auld
On 7 July 2017 at 18:08, Lionel Landwerlin wrote: > From: Matthew Auld > > The motivation behind this new interface is expose at runtime the > creation of new OA configs which can be used as part of the i915 perf > open interface. This will enable the kernel to learn new configs which > may be ex

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Allow execbuffer to use the first object as the batch

2017-07-07 Thread Kenneth Graunke
On Friday, July 7, 2017 3:17:22 AM PDT Daniel Vetter wrote: > On Fri, Mar 17, 2017 at 12:15 PM, Joonas Lahtinen > wrote: > > On to, 2017-03-16 at 13:20 +, Chris Wilson wrote: > >> Currently, the last object in the execlist is the always the batch. > >> However, when building the batch buffer w