Hi,
As per my understanding "get_existing_*_state == get_new_*_state"
It looks like you are trying to use currently available unused wrapper
for completely different purpose. But IMHO you should create a new
wrapper for get_old_state
& this should be renamed to get_new_state. :)
-Mahesh
O
Hi,
On Thursday 20 July 2017 06:45 PM, Maarten Lankhorst wrote:
The get_existing macros are deprecated and should be replaced by
get_old/new_state for clarity.
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/i915/intel_atomic.c | 4 ++--
drivers/gpu/drm/i915/intel_drv.h| 4 ++--
> But now you're suggesting another arbitrary narrow selection of panels
> based on limited evidence.
I understand your point that the panel I observe is not the
representative of the real world.
My point is that we don't know that the panel will work or not unless
we test all panel in the world.
== Series Details ==
Series: series starting with [1/5] lib/scatterlist: Fix offset type in
sg_alloc_table_from_pages
URL : https://patchwork.freedesktop.org/series/28151/
State : success
== Summary ==
Series 28151v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series
Hi Sourab,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20170731]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sagar-Arun
On Mon, 2017-07-31 at 16:05 -0300, Paulo Zanoni wrote:
> Em Seg, 2017-07-31 às 11:52 -0700, Rodrigo Vivi escreveu:
> > No functional change.
> >
> > KBP was based on SPT and spec wasn't clear about the full name.
> > There was the initial point of the "Point" confusion.
> >
> > Later the split wi
== Series Details ==
Series: drm/i915: Fix PCH names for KBP and CNP.
URL : https://patchwork.freedesktop.org/series/28150/
State : success
== Summary ==
Series 28150v1 drm/i915: Fix PCH names for KBP and CNP.
https://patchwork.freedesktop.org/api/1.0/series/28150/revisions/1/mbox/
Test kms_p
Em Seg, 2017-07-31 às 11:52 -0700, Rodrigo Vivi escreveu:
> No functional change.
>
> KBP was based on SPT and spec wasn't clear about the full name.
> There was the initial point of the "Point" confusion.
>
> Later the split with Coffee Lake and Cannon Lake both using CNP
> and also some uncerta
From: Tvrtko Ursulin
Drivers like i915 benefit from being able to control the maxium
size of the sg coallesced segment while building the scatter-
gather list.
Introduce and export the __sg_alloc_table_from_pages function
which will allow it that control.
v2: Reorder parameters. (Chris Wilson)
From: Tvrtko Ursulin
With the addition of __sg_alloc_table_from_pages we can control
the maximum coallescing size and eliminate a separate path for
allocating backing store here.
Similar to 871dfbd67d4e ("drm/i915: Allow compaction upto
SWIOTLB max segment size") this enables more compact sg lis
From: Tvrtko Ursulin
Exercise the new __sg_alloc_table_from_pages API (and through
it also the old sg_alloc_table_from_pages), checking that the
created table has the expected number of segments depending on
the sequence of input pages and other conditions.
Signed-off-by: Tvrtko Ursulin
Cc: Chr
From: Tvrtko Ursulin
Since the scatterlist length field is an unsigned int, make
sure that sg_alloc_table_from_pages does not overflow it while
coallescing pages to a single entry.
v2: Drop reference to future use. Use UINT_MAX.
v3: max_segment must be page aligned.
v4: Do not rely on compiler t
From: Tvrtko Ursulin
Scatterlist entries have an unsigned int for the offset so
correct the sg_alloc_table_from_pages function accordingly.
Since these are offsets withing a page, unsigned int is
wide enough.
Also converts callers which were using unsigned long locally
with the lower_32_bits an
No functional change.
KBP was based on SPT and spec wasn't clear about the full name.
There was the initial point of the "Point" confusion.
Later the split with Coffee Lake and Cannon Lake both using CNP
and also some uncertainty from the specs we had at that time
made us to propagated the mistak
New getfb2 functionality uses drm_mode_fb_cmd2 struct to be symmetric
with addfb2. Also modifies *_fb_create_handle() calls to accept a
format_plane_index so that handles for each plane can be generated.
Previously, many *_fb_create_handle() calls simply defaulted to plane 0 only.
Signed-off-by:
Hi Sourab,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20170731]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sagar-Arun
On 28 July 2017 at 18:10, Lionel Landwerlin
wrote:
> There will be a need for userspaces configurations to set this
> register. We can apply the same model inside the kernel for test
> configs.
>
> Signed-off-by: Lionel Landwerlin
Assuming the A0 magic is correct:
Reviewed-by: Matthew Auld
On 07/28, Lionel Landwerlin wrote:
> In the following commit we'll introduce loadable userspace
> configs. This change reworks how configurations are handled in the
> perf driver and retains only the test configurations in kernel space.
>
> We now store the test config in dev_priv and resolve the
On 28 July 2017 at 18:10, Lionel Landwerlin
wrote:
> The motivation behind this new interface is expose at runtime the
> creation of new OA configs which can be used as part of the i915 perf
> open interface. This will enable the kernel to learn new configs which
> may be experimental, or otherwis
From: Thierry Reding
Instead of listing branches and grepping for the current branch, simply
read the name of the current branch and compare.
Suggested-by: Daniel Vetter
Signed-off-by: Thierry Reding
---
dim | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dim b/dim
index 1
From: Thierry Reding
The new apply and push commands are shorthands for applying patches to
and pushing the current branch, respectively.
v2: use git symbolic-ref to find current branch (Daniel Vetter)
Signed-off-by: Thierry Reding
---
dim | 18 ++
dim.rst | 8
2
Hi Sourab,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20170731]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sagar-Arun
On 31/07/17 17:39, Matthew Auld wrote:
On 28 July 2017 at 18:10, Lionel Landwerlin
wrote:
It makes things easier to read to implement whitelisting in the
"easier to read and to" ?
I guess :
"to read when implementing"
following patches.
Signed-off-by: Lionel Landwerlin
Reviewed-by: M
On 28 July 2017 at 18:10, Lionel Landwerlin
wrote:
> It makes things easier to read to implement whitelisting in the
"easier to read and to" ?
> following patches.
>
> Signed-off-by: Lionel Landwerlin
Reviewed-by: Matthew Auld
___
Intel-gfx mailing li
On 28 July 2017 at 18:10, Lionel Landwerlin
wrote:
> We already do it on Haswell and the documentation says it saves power.
>
> Signed-off-by: Lionel Landwerlin
Reviewed-by: Matthew Auld
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https:
Hi,
On 26 July 2017 at 19:07, Ben Widawsky wrote:
> Due to hardware limitations we require that the main surface and
> the AUX surface (CCS) be part of the same bo. The hardware also
> makes life hard by not allowing you to provide separate x/y offsets
> for the main and AUX surfaces (excpet with
Hi Ben,
On 26 July 2017 at 19:07, Ben Widawsky wrote:
> v2: Drop the 'dev' argument from the hook
> v3: Include the description of the CCS surface layout
This went missing. Vidya's patch has it though.
> +static const struct drm_format_info ccs_formats[] = {
> + { .format = DRM_FO
Hi Ben,
On 26 July 2017 at 19:08, Ben Widawsky wrote:
> +static bool intel_primary_plane_format_mod_supported(struct drm_plane *plane,
> +uint32_t format,
> +uint64_t modifier)
> +{
> + s
On Mon, Jul 31, 2017 at 04:17:56PM +0200, Thierry Reding wrote:
> From: Thierry Reding
>
> The new apply and push commands are shorthands for applying patches to
> and pushing the current branch, respectively.
>
> Signed-off-by: Thierry Reding
> ---
> dim | 27 +++
>
On 31/07/17 08:59, Sagar Arun Kamble wrote:
From: Sourab Gupta
This patch introduces a framework to capture OA counter reports associated
with Render command stream. We can then associate the reports captured
through this mechanism with their corresponding context id's. This can be
further exte
Hi Sourab,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20170731]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sagar-Arun
2017-07-31 Daniel Vetter :
> On Sat, Jul 29, 2017 at 12:18:32PM -0300, Gustavo Padovan wrote:
> > Hi Chris,
> >
> > 2017-07-28 Chris Wilson :
> >
> > > Up until recently sync_file were create to export a single dma-fence to
> > > userspace, and so we could canabalise a bit insie dma-fence to mar
On Fri, Jul 28, 2017 at 01:08:02PM +0100, Chris Wilson wrote:
> Apply a little more stress to the scheduler.
Missing sign-off.
> ---
> lib/igt_rand.h| 6 +++
> tests/gem_exec_schedule.c | 108
> +-
> 2 files changed, 113 insertions(+), 1
Quoting Tvrtko Ursulin (2017-07-31 15:35:45)
>
> On 28/07/2017 13:08, Chris Wilson wrote:
> > +static void reorder_wide(int fd, unsigned ring)
> > +{
> > + const int gen = intel_gen(intel_get_drm_devid(fd));
> > + struct drm_i915_gem_relocation_entry reloc;
> > + struct drm_i915_gem_ex
On 28/07/2017 13:08, Chris Wilson wrote:
Apply a little more stress to the scheduler.
---
lib/igt_rand.h| 6 +++
tests/gem_exec_schedule.c | 108 +-
2 files changed, 113 insertions(+), 1 deletion(-)
diff --git a/lib/igt_rand.h b/lib/
Thanks for the details!
On 31/07/17 12:38, sourab gupta wrote:
On Mon, Jul 31, 2017 at 3:13 PM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
On 31/07/17 08:59, Sagar Arun Kamble wrote:
From: Sourab Gupta mailto:sourab.gu...@intel.com>>
___
From: Thierry Reding
The new apply and push commands are shorthands for applying patches to
and pushing the current branch, respectively.
Signed-off-by: Thierry Reding
---
dim | 27 +++
dim.rst | 8
2 files changed, 35 insertions(+)
diff --git a/dim b/dim
Hi Sourab,
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20170731]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sagar-Arun
On 31/07/17 14:48, Laurent Pinchart wrote:
>>> The comment about read lock is only valid when the plane is bound to the
>>> crtc. In general this is not always the case. You can only peak at
>>> plane->state when crtc->state->plane_mask & BIT(drm_plane_index(plane))
>>> is true.
>>>
>>> I think we
Hi Sourab,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20170731]
[cannot apply to v4.13-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Sagar-Arun
Hi Daniel,
On Tuesday 25 Jul 2017 11:24:28 Daniel Vetter wrote:
> On Tue, Jul 25, 2017 at 10:47 AM, Maarten Lankhorst wrote:
> > Op 25-07-17 om 10:01 schreef Daniel Vetter:
> >> I want/need to rework the core property handling, and this hack is
> >> getting in the way. But since it's a non-standar
On Wed, 26 Jul 2017, Daniel Vetter wrote:
> On Wed, Jul 26, 2017 at 03:53:09PM +0200, Arnd Bergmann wrote:
>> Hi everyone,
>>
>> It took me a while to figure this out properly, as I kept getting
>> circular or missing dependencies with video drivers.
>>
>> This set of three patches should simpli
On Mon, 24 Jul 2017, Puthikorn Voravootivat wrote:
> I saw a DP 1.3 panel that advertise AUX backlight brightness control
> but not working properly. So it should work but not in real world.
> I think that is good reason enough to add this as a heuristic.
Are you suggesting the one panel you ment
Ctx_id for first submission will be its corresponding context as CS sample for
that is allocated during submission with ctx_id taken from ctx->hw_id.
For periodic reports, cs sample after those reports will have the ctx_id info
as the timestamp of that CS sample's report is greater than periodic
On 31/07/2017 11:17, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2017-07-31 10:41:06)
On 28/07/2017 13:08, Chris Wilson wrote:
gdb uses ptrace() to peek and poke bytes of the target's address space.
The kernel must implement an vm_ops->access() handler or else gdb will
be unable to inspect th
Quoting Tvrtko Ursulin (2017-07-31 10:41:06)
>
> On 28/07/2017 13:08, Chris Wilson wrote:
> > gdb uses ptrace() to peek and poke bytes of the target's address space.
> > The kernel must implement an vm_ops->access() handler or else gdb will
> > be unable to inspect the pointer and report it as out
Quoting Chris Wilson (2017-07-31 09:34:30)
> Quoting Sagar Arun Kamble (2017-07-31 08:59:36)
> > +/**
> > + * i915_perf_stream_emit_sample_capture - Insert the commands to capture
> > perf
> > + * metrics into the GPU command stream
> > + * @stream: An i915-perf stream opened for GPU metrics
> > +
On 28/07/2017 13:08, Chris Wilson wrote:
Just a small variant to apply a continuous context-switch load to all
engines.
---
tests/gem_ctx_switch.c | 80 ++
1 file changed, 80 insertions(+)
diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_swi
On 31/07/17 08:59, Sagar Arun Kamble wrote:
From: Sourab Gupta
This patch introduces a framework to capture OA counter reports associated
with Render command stream. We can then associate the reports captured
through this mechanism with their corresponding context id's. This can be
further exte
On 28/07/2017 13:08, Chris Wilson wrote:
gdb uses ptrace() to peek and poke bytes of the target's address space.
The kernel must implement an vm_ops->access() handler or else gdb will
be unable to inspect the pointer and report it as out-of-bounds. Worse
than useless as it causes immediate suspi
Hi Sagar,
I'm curious to what happens if 2 contexts submit requests which a time
period smaller than the sampling OA period on Gen7.5.
My understanding is that with this change you'll only retain the last
submission and then the ctx_id reported in the SAMPLE_CTX_ID field will
be incorrect for
On 28/07/2017 13:07, Chris Wilson wrote:
The idea is to implement read(dmabuf) and write(dambuf) so provide some
tests.
Signed-off-by: Chris Wilson
---
tests/Makefile.sources | 1 +
tests/prime_rw.c | 179 +
2 files changed, 180 inser
Quoting Michał Winiarski (2017-07-31 09:26:44)
> On Fri, Jul 28, 2017 at 01:08:06PM +0100, Chris Wilson wrote:
> > + for_each_engine(fd, engine) {
> > + int fence, new;
> > +
> > + execbuf.flags = engine | LOCAL_EXEC_FENCE_OUT;
> > + execbuf.rsvd2 = -1;
> > +
On Fri, Jul 28, 2017 at 01:08:04PM +0100, Chris Wilson wrote:
> Make sure that our buffers are ready and loaded to reduce the initial
> stall.
Missing sign-off.
Reviewed-by: Michał Winiarski
-Michał
> ---
> tests/gem_ringfill.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-
> -Original Message-
> From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of
> Daniel Vetter
> Sent: Monday, July 31, 2017 11:13 AM
> To: Kahola, Mika
> Cc: intel-gfx
> Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference
> CRC
>
> On Fri, Ju
Quoting Michał Winiarski (2017-07-31 09:58:43)
> > @@ -197,6 +200,9 @@ static void run_test(int fd, unsigned engine, unsigned
> > flags)
> > gem_close(fd, obj[1].handle);
> > }
> >
> > + if (flags & HANG)
> > + spin = igt_spin_batch_new(fd, 0, engine, 0);
>
>
== Series Details ==
Series: i915 perf support for command stream based OA, GPU and workload metrics
capture
URL : https://patchwork.freedesktop.org/series/28104/
State : success
== Summary ==
Series 28104v1 i915 perf support for command stream based OA, GPU and workload
metrics capture
http
On Fri, Jul 28, 2017 at 01:08:05PM +0100, Chris Wilson wrote:
> Ensure that we can suspend the GPU even if it is currently busy in an
> indefinite loop, requiring us to declare the task hung.
Missing sign-off.
> ---
> tests/gem_exec_suspend.c | 19 +++
> 1 file changed, 19 insert
On Mon, Jul 31, 2017 at 12:34:45PM +0530, Vidya Srinivas wrote:
> This patch series is adding NV12 support for Broxton display after
> rebasing on latest drm-intel-nightly. Initial series of the patches
> can be found here:
> https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html
>
Hi Matt, Mauro,
On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote:
> On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote:
> > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for
> > decoding DMI memory device entries. Move the structure definition to
> > dmi.h so that it
Quoting Sagar Arun Kamble (2017-07-31 08:59:36)
> +/**
> + * i915_perf_stream_emit_sample_capture - Insert the commands to capture perf
> + * metrics into the GPU command stream
> + * @stream: An i915-perf stream opened for GPU metrics
> + * @request: request in whose context the metrics are being
On Sat, Jul 29, 2017 at 12:18:32PM -0300, Gustavo Padovan wrote:
> Hi Chris,
>
> 2017-07-28 Chris Wilson :
>
> > Up until recently sync_file were create to export a single dma-fence to
> > userspace, and so we could canabalise a bit insie dma-fence to mark
> > whether or not we had enable polling
On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote:
> On 17-07-29 13:53:10, Daniel Stone wrote:
> > Hi Ben,
> >
> > On 26 July 2017 at 19:08, Ben Widawsky wrote:
> > > + } else if (INTEL_GEN(dev_priv) >= 9) {
> > > intel_primary_formats = skl_primary_formats;
> > >
On Fri, Jul 28, 2017 at 01:08:06PM +0100, Chris Wilson wrote:
> Execute the same batch on each engine and check that the composite fence
> across all engines completes only after the batch is completed on every
> engine.
>
> Signed-off-by: Chris Wilson
> ---
> tests/gem_exec_fence.c | 120
> +++
Hi all,
More 4.14 work:
- tons of corner-case fixes for gpu reset/recovery (Chris Wilson)
- refactor power-well code for future platforms (Imre)
- Ycbcr420 support for hdmi 2.0 displays (Shashank Sharma)
- document FBC structs (Paulo Zanoni)
- reduce struct_mutex usage in pinning (Chris Wilson)
-
On Fri, Jul 28, 2017 at 2:45 PM, Mika Kahola wrote:
> When grabbing reference CRC with igt_pipe_crc_get_crcs() the number of
> words in igt_crc_t structure was incorrectly collected. The fix here is
> to switch to igt_pipe_crc_collect_crc() function when collecting CRC for
> reference frame.
So t
From: Sourab Gupta
This patch ensures hrtimer is rescheduled immediately during cb by
doing async call to check for streams data availability.
Signed-off-by: Sourab Gupta
Signed-off-by: Sagar Arun Kamble
---
drivers/gpu/drm/i915/i915_perf.c | 15 +++
1 file changed, 11 insertions(
From: Sourab Gupta
This patch enables userspace to specify tags (per workload), provided via
execbuffer ioctl, which could be added to OA reports, to help associate
reports with the corresponding workloads.
There may be multiple stages within a single context, from a userspace
perspective. An ab
From: Sourab Gupta
This patch adds support for capturing MMIO register values through
i915 perf interface.
The userspace can request upto 8 MMIO register values to be dumped.
The addresses of these registers can be passed through the corresponding
property 'value' field while opening the stream.
From: Sourab Gupta
Considering how we don't currently give userspace control over the
OA buffer size and always configure a large 16MB buffer,
then a buffer overflow does anyway likely indicate that something
has gone quite badly wrong.
Here we set a status flag to detect overflow and inform use
From: Sourab Gupta
This adds support for populating the ctx id for the periodic OA reports
when requested through the corresponding property.
For Gen8, the OA reports itself have the ctx ID and it is the one
programmed into HW while submitting workloads. Thus it's retrieved from
reports itself.
From: Sourab Gupta
This patch adds a new ctx getparam ioctl parameter, which can be used to
retrieve ctx unique id by userspace.
This can be used by userspace to map the OA reports received in the
i915 perf samples with their associated ctx's (The OA reports have the
hw ctx ID information embedd
From: Sourab Gupta
With this patch, for RCS, timestamps and OA reports can be collected
together, and provided to userspace in separate sample fields. For other
engines, the capabilility to collect timestamps is added.
The thing to note is that, still only a single stream instance can be
opened
This series is prepared from below two series posted by Sourab in March.
1. https://patchwork.freedesktop.org/series/21351/ - Collect command stream
based OA reports using i915 perf
2. https://patchwork.freedesktop.org/series/21352/ - Collect command stream
based GPU metrics for all engines u
From: Sourab Gupta
This patch introduces a framework to capture OA counter reports associated
with Render command stream. We can then associate the reports captured
through this mechanism with their corresponding context id's. This can be
further extended to associate any other metadata informati
From: Sourab Gupta
This patch introduces flags and adds support for having pid output with
the OA reports generated through the RCS commands.
When the stream is opened with pid sample type, the pid information is also
captured through the command stream samples and forwarded along with the
OA re
From: Sourab Gupta
This patch exposes a new sample source field to userspace. This field can
be populated to specify the origin of the OA report.
Currently, the OA samples are being generated only periodically, and hence
there's only source flag enum definition right now, but there are other
mean
From: Sourab Gupta
When there are no pending CS OA samples, flush the periodic OA samples
collected so far.
We can safely forward the periodic OA samples in the case we
have no pending CS samples, but we can't do so in the case we have
pending CS samples, since we don't know what the ordering be
From: Sourab Gupta
The OA reports contain the least significant 32 bits of the gpu timestamp.
This patch enables retrieval of the timestamp field from OA reports, to
forward as 64 bit raw gpu timestamps in the perf samples.
Signed-off-by: Sourab Gupta
Signed-off-by: Sagar Arun Kamble
---
driv
Dear Linux folks,
Just a small note, that Intel pushed patches for the Chromium browser
for review [1] to use VAAPI [2] along with vaapi-driver to run all
supported media use cases with hardware acceleration.
This will hopefully let GNU/Linux systems desktop to catch up further
to Microsoft Wind
80 matches
Mail list logo
