From: Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
Cc: Chris Wilson
Cc: Joonas Lahtine
Thanks!
-Original Message-
From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On
Behalf Of Rodrigo Vivi
Sent: Tuesday, October 17, 2017 3:29 AM
To: Wang, Zhi A
Cc: Nikula, Jani ; intel-gfx@lists.freedesktop.org;
joonas.lahti...@linux.intel.com; zhen...@linux.intel.
== Series Details ==
Series: series starting with drm/atomic: Make atomic helper track newly
assigned planes correctly, v2. (rev2)
URL : https://patchwork.freedesktop.org/series/32044/
State : success
== Summary ==
Series 32044v2 series starting with drm/atomic: Make atomic helper track newly
Commit 669c9215afea ("drm/atomic: Make async plane update checks work as
intended, v2.") forced planes to always be tracked, but forgot to
explicitly get the crtc commit from the new crtc when available.
This broke plane commit tracking, and caused kms_atomic_transitions
to randomly fail with -EBU
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON
URL : https://patchwork.freedesktop.org/series/32050/
State : success
== Summary ==
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test kms_flip:
Subg
> -Original Message-
> From: Kristian Kristensen [mailto:hoegsb...@gmail.com]
> Sent: Tuesday, October 17, 2017 4:05 AM
> To: Srinivas, Vidya ; intel-
> g...@lists.freedesktop.org
> Cc: Srinivas, Vidya
> Subject: Re: [Intel-gfx] [PATCH 13/14] drm/i915: Add NV12 as supported
> format for
== Series Details ==
Series: DDI buf trans cleanup
URL : https://patchwork.freedesktop.org/series/32049/
State : warning
== Summary ==
Test kms_flip:
Subgroup dpms-vs-vblank-race-interruptible:
fail -> PASS (shard-hsw) fdo#103060
Test kms_plane:
Subg
== Series Details ==
Series: series starting with [v2,1/4] lib: Extract helpers for determining
submission method
URL : https://patchwork.freedesktop.org/series/32020/
State : failure
== Summary ==
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-C-frame-sequence:
pass
== Series Details ==
Series: series starting with drm/i915/cnl: Add Cannonlake PCI IDs for another
SKU. (rev2)
URL : https://patchwork.freedesktop.org/series/32069/
State : success
== Summary ==
Series 32069v2 series starting with drm/i915/cnl: Add Cannonlake PCI IDs for
another SKU.
https:/
== Series Details ==
Series: series starting with [1/2] drm/atomic: Make atomic helper track newly
assigned planes correctly.
URL : https://patchwork.freedesktop.org/series/32044/
State : warning
== Summary ==
Test kms_universal_plane:
Subgroup universal-plane-pipe-B-functional:
On Mon, Oct 16, 2017 at 05:12:42PM +, Zhi Wang wrote:
> Hi:
>
> Here is a fix of one bug for 4.14-rc5 which fixes a GPU hang after resuing
> one vGPU across different guest OSes.
Applied to drm-intel-fixes.
Thanks,
Rodrigo.
>
> Thanks.
>
> ---
>
> The following changes since commit ea850
By the Spec all CNL skus are GT2.
v2: Really include the PCI IDs to the picidlist[];
v3: Add the PCI Id for another SKU (Anusha).
v4: Update IDs, really include to pciidlists again.
v5: Unify all GT2 IDs.
v6: Prefer INTEL_CNL_IDS for the union since it is already
in use at arch/x86/kernel/earl
== Series Details ==
Series: drm/i915: Add -Wall -Wextra to our build, set warnings to full (rev2)
URL : https://patchwork.freedesktop.org/series/32033/
State : success
== Summary ==
Test prime_self_import:
Subgroup export-vs-gem_close-race:
pass -> FAIL (sh
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> The caller of intel_prepare_hdmi_ddi_buffers() alreday figured out the
> level, so let's just pass it in instead if figuring it out again.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: James Ausmus
> ---
> driver
== Series Details ==
Series: drm/i915/cnl: DDIA Lane capability bit not set in clone mode (rev2)
URL : https://patchwork.freedesktop.org/series/28204/
State : success
== Summary ==
Series 28204v2 drm/i915/cnl: DDIA Lane capability bit not set in clone mode
https://patchwork.freedesktop.org/api
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> encoder->type isn't reliable for DP/HDMI encoders, so pass the type
> explicity to skl_set_iboost(). Also take the opportunity to streamline
> the code.
>
> v2: Clean up the argument types to skl_ddi_set_iboost() whil
On Wed, Oct 04, 2017 at 07:34:27PM +, Ausmus, James wrote:
> On Tue, Oct 3, 2017 at 3:08 PM, Rodrigo Vivi wrote:
> > HDMI Mode selection on CNL is on CFGCR0 for that PLL, not
> > on in a global CTRL1 as it was on SKL.
> >
> > The original patch addressed this difference, but leaving behind
> >
From: Clint Taylor
DDIA Lane capability control 4 lane bit is not being set by firmware during
clone mode boot. This occurs when multiple monitors are connected during
boot. The driver will configure the port for 2 lane maximum width if this
bit is not set.
Cc: Mika Kahola
Signed-off-by: Clint
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> Introduce intel_ddi_get_buf_trans_hdmi() and start using it where we
> can.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 50
> ++--
> 1 file change
On Mon, Oct 16, 2017 at 07:58:25PM +, Chris Wilson wrote:
> Quoting Chris Wilson (2017-10-16 20:54:59)
> > Quoting Rodrigo Vivi (2017-10-16 19:16:58)
> > > On Mon, Oct 16, 2017 at 12:07:23PM +, David Weinehall wrote:
> > > > On Tue, Aug 22, 2017 at 04:58:28PM -0700, Rodrigo Vivi wrote:
> >
On Mon, Oct 16, 2017 at 7:56 AM, Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> We'll want to use the intel_ddi_get_buf_trans_*() functions a bit
> earlier in the file, so move them up. While at it start using them
> in the iboost setup to get rid of the platform checks there.
>
> v2: Rebase due
On Fri, Oct 13, 2017 at 8:35 PM, Patchwork
wrote:
> == Series Details ==
>
> Series: drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector (rev6)
> URL : https://patchwork.freedesktop.org/series/30384/
> State : failure
>
> == Summary ==
>
> Test kms_flip:
> Subgroup basic-flip
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Tvrtko Ursu
Vidya Srinivas writes:
> From: Chandra Konduru
>
> This patch adds NV12 to list of supported formats for sprite plane.
>
> v2: Rebased (me)
>
> v3: Review comments by Ville addressed
> - Removed skl_plane_formats_with_nv12 and added
> NV12 case in existing skl_plane_formats
> -
Vidya Srinivas writes:
> From: Chandra Konduru
>
> This patch adds NV12 to list of supported formats for
> primary plane
>
> v2: Rebased (Chandra Konduru)
>
> v3: Rebased (me)
>
> v4: Review comments by Ville addressed
> Removed the skl_primary_formats_with_nv12 and
> added NV12 case
On Fri, Sep 1, 2017 at 6:46 AM, Ville Syrjälä
wrote:
> On Thu, Aug 31, 2017 at 05:05:01PM -0700, Rodrigo Vivi wrote:
>> Hi Ville,
>>
>> On Wed, Aug 30, 2017 at 10:09 AM, Ville Syrjälä
>> wrote:
>> > On Wed, Aug 30, 2017 at 11:31:16AM +0300, Jani Nikula wrote:
>> >> On Mon, 28 Aug 2017, Ville Syrj
== Series Details ==
Series: drm/i915: Remove mostly duplicated video DIP handling from PSR code
URL : https://patchwork.freedesktop.org/series/31954/
State : success
== Summary ==
Test kms_atomic_transition:
Subgroup plane-all-transition-nonblocking:
pass -> FAIL
== Series Details ==
Series: series starting with [1/9] drm/i915/cnl: Add Cannonlake PCI IDs for
another SKU.
URL : https://patchwork.freedesktop.org/series/32069/
State : failure
== Summary ==
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK
Now let's finish the Port-F support by adding the
proper port F detection, irq and power well support.
v2: Rebase
v3: Use BIT_ULL
v4: Cover missed case on ddi init.
v5: Update commit message.
Cc: Manasi Navare
Cc: Ville Syrjälä
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_drv.h
This was wrong since its introduction on commit '04416108ccea
("drm/i915/cnl: Add registers related to voltage swing sequences.")'
But since no Port F was needed so far we don't need to
propagate fixes back there.
Cc: Manasi Navare
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_reg.
On CNP Pin 3 is for misc of Port F usage depending on the
configuration. For CNL that uses Port F, pin 3 is the one.
v2: Make it more generic and update commit message.
Cc: Manasi Navare
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_hdmi.c | 3 +++
1 file changed, 3 insertions(+)
On CNL SKUs that uses port F, max DP rate is 8.1G for all
ports when we have the elevated voltage.
v2: Make commit message more generic.
Cc: Manasi Navare
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/intel_dp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/d
Since when it got introduced with commit '555e38d27317
("drm/i915/cnl: DDI - PLL mapping")' the support for Port F
was wrong, because Port F bits are far from bits used
for A to E.
Since Port F is not used so far we don't need to propagate
Fixes back there.
Cc: Manasi Navare
Signed-off-by: Rodri
On CNP boards that are using DDI F,
bit 25 (SDE_PORTE_HOTPLUG_SPT) is representing
the Digital Port F hotplug line when the Digital
Port F hotplug detect input is enabled.
v2: Reuse all existent structure instead of adding a
new HPD_PORT_F pointing to pin of port E.
v3: Use IS_CNL_WITH_PORT_F so w
By the Spec all CNL skus are GT2.
v2: Really include the PCI IDs to the picidlist[];
v3: Add the PCI Id for another SKU (Anusha).
v4: Update IDs, really include to pciidlists again.
v5: Unify all GT2 IDs.
Signed-off-by: Anusha Srivatsa
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_
On some Cannonlake SKUs we have a dedicated Aux for port F,
that is only the full split between port A and port E.
There is still no Aux E for Port E, as in previous platforms,
because port_E still means shared lanes with port A.
v2: Rebase.
v3: Add couple missed PORT_F cases on intel_dp.
v4: Reb
Some Cannonlake SKUs will come with a full split between
port A and port E. This will be called port F although it
is not a 6th port, but only a split.
v2: Fix size of dvo_ports found by Ander.
v3: Adding missing cases from intel_bios.c for Port_F
v4: Adding other missing cases and fix the commit
== Series Details ==
Series: drm/i915: Add -Wall -Wextra to our build, set warnings to full
URL : https://patchwork.freedesktop.org/series/32033/
State : success
== Summary ==
Test kms_flip:
Subgroup modeset-vs-vblank-race:
fail -> PASS (shard-hsw) fdo#10291
== Series Details ==
Series: drm/i915: Report -EFAULT before pwrite fast path into shmemfs
URL : https://patchwork.freedesktop.org/series/32066/
State : success
== Summary ==
Series 32066v1 drm/i915: Report -EFAULT before pwrite fast path into shmemfs
https://patchwork.freedesktop.org/api/1.0/
When pwriting into shmemfs, the fast path pagecache_write does not
notice when it is writing to beyond the end of the truncated shmemfs
inode. Report -EFAULT directly when we try to use pwrite into the
!I915_MADV_WILLNEED object.
Fixes: 7c55e2c5772d ("drm/i915: Use pagecache write to prepopulate s
Quoting Mika Kuoppala (2017-10-16 16:30:33)
> Chris Wilson writes:
>
> > If we fail to recover the HW state upon resume (i.e. our attempt to
> > clear the wedged bit and reset during i915_gem_sanitize() fails), then
> > skip the HW restart inside i915_gem_init_hw(). We will ultimately do the
> >
Quoting Jeff McGee (2017-10-16 17:10:20)
> On Sun, Oct 15, 2017 at 09:43:10PM +0100, Chris Wilson wrote:
> > In the intel_engine_cs dumper, we were showing the request details for
> > the request queue but not of those requests already passed to the hw
> > (just a summary of the seqno). If we show
== Series Details ==
Series: series starting with [1/9] drm/i915: Refactor testing obj->mm.pages
(rev4)
URL : https://patchwork.freedesktop.org/series/31959/
State : failure
== Summary ==
Test kms_flip:
Subgroup modeset-vs-vblank-race:
fail -> PASS (shard-h
Quoting Chris Wilson (2017-10-16 20:54:59)
> Quoting Rodrigo Vivi (2017-10-16 19:16:58)
> > On Mon, Oct 16, 2017 at 12:07:23PM +, David Weinehall wrote:
> > > On Tue, Aug 22, 2017 at 04:58:28PM -0700, Rodrigo Vivi wrote:
> > > > Apparently RC6 residency is lower than expected
> > > > with EI mo
Quoting Rodrigo Vivi (2017-10-16 19:16:58)
> On Mon, Oct 16, 2017 at 12:07:23PM +, David Weinehall wrote:
> > On Tue, Aug 22, 2017 at 04:58:28PM -0700, Rodrigo Vivi wrote:
> > > Apparently RC6 residency is lower than expected
> > > with EI mode for most of the cases on CNL A0, B0 and C0.
> > >
== Series Details ==
Series: Documentation/i915: Add "User command execution" to doc-tree
URL : https://patchwork.freedesktop.org/series/32025/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-spr-indfb-move:
skip -> PASS
On Mon, Oct 16, 2017 at 2:53 PM, Harsha Sharma
wrote:
> On Tue, Oct 17, 2017 at 12:15 AM, Sean Paul wrote:
>> On Sat, Oct 14, 2017 at 2:36 PM, Harsha Sharma
>> wrote:
>>> Replace instances of drm_framebuffer_reference/unreference() with
>>> *_get/put() suffixes and drm_dev_unref with *_put() suf
On 16/10/17 12:08:19 +0300, Jani Nikula wrote:
> On Sun, 15 Oct 2017, Christos Gkekas wrote:
> > Delete variables 'gma_bottom' that are set but never used.
>
> Please use common sense in choosing the mailing lists and maintainers
> you send patches to. In this case, intel-gvt-dev would have been
On Tue, Oct 17, 2017 at 12:15 AM, Sean Paul wrote:
> On Sat, Oct 14, 2017 at 2:36 PM, Harsha Sharma
> wrote:
>> Replace instances of drm_framebuffer_reference/unreference() with
>> *_get/put() suffixes and drm_dev_unref with *_put() suffix
>> because get/put is shorter and consistent with the
>>
On Sat, Oct 14, 2017 at 2:36 PM, Harsha Sharma
wrote:
> Replace instances of drm_framebuffer_reference/unreference() with
> *_get/put() suffixes and drm_dev_unref with *_put() suffix
> because get/put is shorter and consistent with the
> kernel use of *_get/put suffixes.
> Done with following cocc
Hi:
Here is a fix of one bug for 4.14-rc5 which fixes a GPU hang after resuing one
vGPU across different guest OSes.
Thanks.
---
The following changes since commit ea850f64c2722278f150dc11de2141baeb24211c:
drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP AUX
channel (201
On Mon, Oct 16, 2017 at 12:07:23PM +, David Weinehall wrote:
> On Tue, Aug 22, 2017 at 04:58:28PM -0700, Rodrigo Vivi wrote:
> > Apparently RC6 residency is lower than expected
> > with EI mode for most of the cases on CNL A0, B0 and C0.
> >
> > This Wa doesn't solve our lower residency, but I
On 10/13/2017 02:05 AM, Sagar Arun Kamble wrote:
Keep subject as "drm/i915" as this is generic change. Also I saw
i915_runtime_pm_status debugfs output not updated.
Could you please check.
I did not change the seq_puts message of i915_runtime_pm_status debugfs
since it doesn't fit into the
Hi:
Here is a fix of one bug for 4.14-rc5 which fixes a GPU hang after
resuing one vGPU across different guest OSes.
Thanks.
---
The following changes since commit ea850f64c2722278f150dc11de2141baeb24211c:
drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP
AUX channel (2
== Series Details ==
Series: drm/i915/gvt: Fix error handling bug in perform_bb_shadow
URL : https://patchwork.freedesktop.org/series/32006/
State : success
== Summary ==
shard-hswtotal:2553 pass:1441 dwarn:0 dfail:0 fail:9 skip:1103
time:9666s
== Logs ==
For more details see:
On 10/13/2017 02:42 AM, Sagar Arun Kamble wrote:
On 10/11/2017 12:02 AM, Sujaritha Sundaresan wrote:
We currently have two module parameters that control GuC:
"enable_guc_loading" and "enable_guc_submission".
Whenever we need i915_modparams.enable_guc_submission=1, we also need
enable_guc_l
On 10/13/2017 02:05 AM, Sagar Arun Kamble wrote:
Keep subject as "drm/i915" as this is generic change. Also I saw
i915_runtime_pm_status debugfs output not updated.
Could you please check.
I will change the subject and check the if the output is being updated.
On 10/11/2017 12:02 AM, Su
== Series Details ==
Series: series starting with [1/2] lib: Skip unsupported suspend-test modes
URL : https://patchwork.freedesktop.org/series/32028/
State : warning
== Summary ==
IGT patchset tested on top of latest successful build
d4d976de7e022cb56a2dbfe96c4ab10549e24acc igt/gem_mocs_setti
On Sun, Oct 15, 2017 at 09:43:10PM +0100, Chris Wilson wrote:
> In the intel_engine_cs dumper, we were showing the request details for
> the request queue but not of those requests already passed to the hw
> (just a summary of the seqno). If we show those details, we can then
> eliminate the entire
== Series Details ==
Series: drm/i915/gvt: Clean up dead code in cmd_parser
URL : https://patchwork.freedesktop.org/series/32023/
State : failure
== Summary ==
Test kms_color:
Subgroup ctm-0-5-pipe3:
skip -> INCOMPLETE (shard-hsw)
Test kms_cursor_legacy:
S
On Mon, 2017-10-16 at 15:23 +, Patchwork wrote:
> == Series Details ==
>
> Series: Firmware code reorg (rev5)
> URL : https://patchwork.freedesktop.org/series/31846/
> State : failure
GLK is broken as a baseline, not having GuC firmware.
This is now merged, thanks for the patches and revie
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON
URL : https://patchwork.freedesktop.org/series/32050/
State : success
== Summary ==
Series 32050v1 drm/i915: Print the condition causing GEM_BUG_ON
https://patchwork.freedesktop.org/api/1.0/series/32050/revisions/1/m
On Fri, Oct 13, 2017 at 01:35:05PM +0300, Ville Syrjälä wrote:
> On Thu, Oct 12, 2017 at 09:06:24PM +0200, Daniel Vetter wrote:
> > On Wed, Oct 11, 2017 at 07:04:49PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > Rename enum plane to enum old_plane_id to make it clear that it
== Series Details ==
Series: DDI buf trans cleanup
URL : https://patchwork.freedesktop.org/series/32049/
State : success
== Summary ==
Series 32049v1 DDI buf trans cleanup
https://patchwork.freedesktop.org/api/1.0/series/32049/revisions/1/mbox/
Test kms_cursor_legacy:
Subgroup basic-b
On Mon, 2017-10-16 at 18:26 +0300, Mika Kuoppala wrote:
> It is easier to categorize and debug bugs if the failed condition
> is in plain sight in the actual dmesg output. Make it so.
>
> Cc: Chris Wilson
> Cc: Joonas Lahtinen
> Signed-off-by: Mika Kuoppala
That's one off my TODO list. This
On Mon, Oct 16, 2017 at 05:28:27PM +0200, Maarten Lankhorst wrote:
> Op 16-10-17 om 16:48 schreef Ville Syrjälä:
> > On Mon, Oct 16, 2017 at 03:59:38PM +0200, Maarten Lankhorst wrote:
> >> Op 16-10-17 om 15:42 schreef Ville Syrjälä:
> >>> On Mon, Oct 16, 2017 at 03:29:27PM +0200, Maarten Lankhorst
El 14/10/17 a las 01:45, Alex Villacis Lasso escribió:
El 13/10/17 a las 11:28, Alex Villacís Lasso escribió:
El 11/10/17 a las 11:38, Ville Syrjälä escribió:
On Wed, Oct 11, 2017 at 04:21:58PM +, Alex Villacis Lasso wrote:
El 11/10/17 a las 11:04, Ville Syrjala escribió:
From: Ville Syrj
Chris Wilson writes:
> If we fail to recover the HW state upon resume (i.e. our attempt to
> clear the wedged bit and reset during i915_gem_sanitize() fails), then
> skip the HW restart inside i915_gem_init_hw(). We will ultimately do the
> HW restart when successfully unwedging and resetting the
Chris Wilson writes:
> If we fail to recover the HW state upon resume (i.e. our attempt to
> clear the wedged bit and reset during i915_gem_sanitize() fails), then
> skip the HW restart inside i915_gem_init_hw(). We will ultimate do the
> the HW restart when sucessfully unwedgeding and reseting t
Op 16-10-17 om 16:48 schreef Ville Syrjälä:
> On Mon, Oct 16, 2017 at 03:59:38PM +0200, Maarten Lankhorst wrote:
>> Op 16-10-17 om 15:42 schreef Ville Syrjälä:
>>> On Mon, Oct 16, 2017 at 03:29:27PM +0200, Maarten Lankhorst wrote:
Commit 669c9215afea ("drm/atomic: Make async plane update check
It is easier to categorize and debug bugs if the failed condition
is in plain sight in the actual dmesg output. Make it so.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Signed-off-by: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_gem.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --gi
== Series Details ==
Series: Firmware code reorg (rev5)
URL : https://patchwork.freedesktop.org/series/31846/
State : failure
== Summary ==
Series 31846v5 Firmware code reorg
https://patchwork.freedesktop.org/api/1.0/series/31846/revisions/5/mbox/
Test debugfs_test:
Subgroup read_all_
== Series Details ==
Series: series starting with [v2,1/4] lib: Extract helpers for determining
submission method
URL : https://patchwork.freedesktop.org/series/32020/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
d4d976de7e022cb56a2dbfe96c4ab10549e24acc
From: Ville Syrjälä
default_index contained in the BXT buf_trans tables is actually useless.
For DP we should always have a valid level selected (otherwise the link
training logic would be buggy), and for HDMI we can just do what the
other platforms do and pick the correct entry in intel_ddi_hdmi
From: Ville Syrjälä
Handle missing buf trans tables, or out of bounds buf trans levels
the same way everywhere. These should never be hit under normal
conditions, but let's play it safe for now.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 25 -
1
From: Ville Syrjälä
A bunch of functions are now exclusively used for HDMI, so naming the
variables with hdmi prefix/suffix is redundant. Also use int rather
than u32 for the translation level consistently.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 61
From: Ville Syrjälä
Make BXT less special by following the CNL approach and handling
it in intel_ddi_dp_voltage_max() alognside every other DDI platform.
v2: Clean up the argument types to bxt_ddi_vswing_sequence() while at it
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c
From: Ville Syrjälä
SKL DDI B/C/D only have 9 usable buf trans registers for DP/eDP. That
matches the normal DP buf trans tables, but the low vswing eDP tables
have 10 entries. Thus the eDP tables can only be used safely with DDI A
and E.
We try to catch cases where DDI B/C/D gets used with the
From: Ville Syrjälä
encoder->type is unreliable for DP/HDMI, so pass it in explicity into
cnl_ddi_vswing_sequence(). This matches what we do for BXT.
v2: Pass intel_encoder down to cnl_ddi_vswing_program(), and
clean up the argument types while at it
Signed-off-by: Ville Syrjälä
---
drive
From: Ville Syrjälä
The caller of intel_prepare_hdmi_ddi_buffers() alreday figured out the
level, so let's just pass it in instead if figuring it out again.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --
From: Ville Syrjälä
Introduce intel_ddi_get_buf_trans_hdmi() and start using it where we
can.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 50 ++--
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/in
From: Ville Syrjälä
encoder->type isn't reliable for DP/HDMI encoders, so pass the type
explicity to skl_set_iboost(). Also take the opportunity to streamline
the code.
v2: Clean up the argument types to skl_ddi_set_iboost() while at it
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/in
From: Ville Syrjälä
Second batch of goodies extracted from the big DDI encoder->type series.
This one tries to clean up a lot of the mess in DDI buf trans handling.
The end result is DDI buf trans code that isn't reliant on
encoder->type to tell DP vs. HDMI apart, and as a nice bonus we also
brin
From: Ville Syrjälä
We'll want to use the intel_ddi_get_buf_trans_*() functions a bit
earlier in the file, so move them up. While at it start using them
in the iboost setup to get rid of the platform checks there.
v2: Rebase due to BDW FDI buf trans fix
Signed-off-by: Ville Syrjälä
---
driver
On Sat, 14 Oct 2017, Alex Villacis Lasso wrote:
> El 13/10/17 a las 11:28, Alex Villacís Lasso escribió:
>> El 11/10/17 a las 11:38, Ville Syrjälä escribió:
>>> On Wed, Oct 11, 2017 at 04:21:58PM +, Alex Villacis Lasso wrote:
El 11/10/17 a las 11:04, Ville Syrjala escribió:
> From: Vi
On Mon, Oct 16, 2017 at 03:59:38PM +0200, Maarten Lankhorst wrote:
> Op 16-10-17 om 15:42 schreef Ville Syrjälä:
> > On Mon, Oct 16, 2017 at 03:29:27PM +0200, Maarten Lankhorst wrote:
> >> Commit 669c9215afea ("drm/atomic: Make async plane update checks work as
> >> intended, v2.") forced planes to
Remaining functions in intel_guc_loader.c were focused around
GuC firmware. Rename them to match object-verb pattern and
rename file itself.
Suggested-by: Joonas Lahtinen
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Sagar Arun Kamble
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i
In case of GuC firmware loading failure we were reporting
DRM_ERROR also for case when GuC loading was not strictly
required.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Sagar Arun Kamble
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_uc.c | 9 +
Function intel_guc_wopcm_size didn't fit well in the old place.
With this move upcoming cleanup will be simpler.
Suggested-by: Joonas Lahtinen
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Sagar Arun Kamble
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_guc.c| 11
In case of firmware fetch failure we should help user
find latest firmware. URL macro duplication from csr.c
will be fixed in upcoming patch.
Suggested-by: Chris Wilson
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_uc_fw.c | 2 ++
dr
Firmware loading for GuC and HuC are similar. Move common code
into generic function for maximum reuse.
v2: change message levels (Chris)
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Sagar Arun Kamble
Cc: Anusha Srivatsa
Cc: Sujaritha Sundaresan
Cc: Chris Wilson
Reviewed-by: Chri
Some of the error messages from DMC load were too generic and
may be confusing for the user. Lets explicitly add DMC words there.
Also as homepage of DMC firmware is same as for the GuC and Huc,
lets reuse URL definition.
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
Cc: Imre Deak
Cc: Mika K
Time to remove less important info and make messages clear
and consistent.
v2: change some message levels (Chris)
v3: restore DRM_WARN (Chris)
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Joonas Lahtinen
Cc: Chris Wilson
Reviewed-by: Chris Wilson #2
---
drivers/gpu/drm/i915/int
After GuC code reorg some documentation was left in wrong
place. Move it closer to corresponding definitions.
v2: use consistent name for the GuC (Sagar)
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Sagar Arun Kamble
Reviewed-by: Sagar Arun Kamble
---
drivers/gpu/drm/i915/intel_gu
Also revert ("drm/i915/guc: Assert that we switch between
known ggtt->invalidate functions")
Signed-off-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++--
drivers/gpu/drm/i915/i915_params.h | 4 ++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/
Functions should be defined in their use order.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_guc_fw.c | 81 +++--
1 file changed, 41 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/i915
No functional change. Just place the function closer to related
definitions.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Sagar Arun Kamble
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_huc.c | 72
1 file changed, 36 insertions(+)
CC: Joonas Lahtinen
Cc: Chris Wilson
v1: was sent with wrong prefix "P v4"
v2: apply review comments from Chris/Daniele
v3: restore DRM_WARN, add firmware url
v4: update DMC messages, drop CI HAX
v5: common fw size check against WOPCM (Joonas)
v6: GuC HAX for CI
Michal Wajdeczko (15):
drm/i91
We want to keep ucode xfer functions separate from other
initialization. Once separated, add explicit forcewake.
v2: use BLITTER domain only and add comment (Daniele)
Suggested-by: Joonas Lahtinen
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Sagar Arun Kamble
Cc: Daniele Ceraolo Sp
Both GuC and HuC firmwares will be moved into WOPCM so
we can check ucode size early for both cases.
Suggested-by: Joonas Lahtinen
Signed-off-by: Michal Wajdeczko
Cc: Sagar Arun Kamble
Cc: Joonas Lahtinen
Cc: Chris Wilson
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/intel_uc_fw.c |
1 - 100 of 206 matches
Mail list logo
