Re: [Intel-gfx] [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-05 Thread Zhang, Tina
> -Original Message- > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > Behalf Of Alex Williamson > Sent: Monday, November 6, 2017 10:39 AM > To: Zhang, Tina > Cc: Tian, Kevin ; Daniel Vetter > ; > intel-gfx@lists.freedesktop.org; joonas.lahti...@linux.intel

Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: Increase wait timeout for doorbell release status update

2017-11-05 Thread Sagar Arun Kamble
On 11/5/2017 9:25 PM, Michal Wajdeczko wrote: On Sun, 05 Nov 2017 14:39:42 +0100, Sagar Arun Kamble wrote: Current wait timeout of 10us is very tight as seen on SKL/KBL randomly for pm_rpm@basic-pci-d3-state. Increase it to 50us. Signed-off-by: Sagar Arun Kamble Cc: Chris Wilson Cc: Mich

Re: [Intel-gfx] [PATCH 6/7] drm/drivers: drop redundant drm_edid_to_eld() calls

2017-11-05 Thread Archit Taneja
On 11/01/2017 07:51 PM, Jani Nikula wrote: drm_add_edid_modes() now fills in the ELD automatically, so the calls to drm_edid_to_eld() are redundant. Remove them. All the other places are obvious, but nv50 has detached drm_edid_to_eld() from the drm_add_edid_modes() call. For the bridge drive

Re: [Intel-gfx] [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-05 Thread Alex Williamson
On Mon, 6 Nov 2017 10:19:17 +0800 Tina Zhang wrote: > Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get > a plane and its related information. So far, two types of buffers are > supported: buffers based on dma-buf and buffers based on region. > > This ioctl can be invoked

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Dma-buf support for GVT-g

2017-11-05 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Dma-buf support for GVT-g URL : https://patchwork.freedesktop.org/series/33222/ State : failure == Summary == Series 33222 revision 1 was fully merged or fully failed: no git log ___ Intel-gfx mailing list

[Intel-gfx] [PATCH v16 2/6] drm: Introduce RGB 64-bit 16:16:16:16 float format

2017-11-05 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by some Apps in windows. The float format in each component is 1:5:10 MSb-sign:exponent: fraction. This patch is to introduce the format to drm, so that the windows guest's framebuffer in this kind of format can be recognized and used by linu

[Intel-gfx] [PATCH v16 6/6] drm/i915/gvt: Dmabuf support for GVT-g

2017-11-05 Thread Tina Zhang
This patch introduces a guest's framebuffer sharing mechanism based on dma-buf subsystem. With this sharing mechanism, guest's framebuffer can be shared between guest VM and host. v16: - add x_hot and y_hot. (Gerd) - add flag validation for VFIO_DEVICE_GET_GFX_DMABUF. (Alex) - rebase 4.14.0-rc6.

[Intel-gfx] [PATCH v16 4/6] drm/i915/gvt: Add opregion support

2017-11-05 Thread Tina Zhang
Windows guest driver needs vbt in opregion, to configure the setting for display. Without opregion support, the display registers won't be set and this blocks display model to get the correct information of the guest display plane. This patch is to provide a virtual opregion for guest. Current imp

[Intel-gfx] [PATCH v16 5/6] vfio: ABI for mdev display dma-buf operation

2017-11-05 Thread Tina Zhang
Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user query and get a plane and its related information. So far, two types of buffers are supported: buffers based on dma-buf and buffers based on region. This ioctl can be invoked with: 1) either DMABUF or REGION flag. Vendor driver returns a pl

[Intel-gfx] [PATCH v16 3/6] drm/i915/gvt: Add RGB 64-bit 16:16:16:16 float format

2017-11-05 Thread Tina Zhang
The RGB 64-bit 16:16:16:16 float pixel format is needed by windows 10 guest VM. This patch is to add this pixel format support to gvt device model. Without this patch, some Apps, e.g. "DXGIGammaVM.exe", will crash and make guest screen black. Signed-off-by: Tina Zhang --- drivers/gpu/drm/i915/gv

[Intel-gfx] [PATCH v16 0/6] drm/i915/gvt: Dma-buf support for GVT-g

2017-11-05 Thread Tina Zhang
v15->v16: 1) add cursor hotspot fields in struct vfio_device_gfx_plane_info. (Gerd) 2) clean up some typos and add comments for VFIO_DEVICE_QUERY_GFX_PLANE. (Alex) 3) seperate the GEM Proxy part to another patch-set. (Joonas and Chris) https://lists.freedesktop.org/archives/intel-gvt-dev/2017-N

[Intel-gfx] [PATCH v16 1/6] drm/i915/gvt: Add framebuffer decoder support

2017-11-05 Thread Tina Zhang
This patch is to introduce the framebuffer decoder which can decode guest OS's framebuffer information, including primary, cursor and sprite plane. v16: rebase to 4.14.0-rc6. v14: - refine pixel format table. (Zhenyu) v9: - move drm format change to a separate patch. (Xiaoguang) v8: - fix a bu

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [CI,1/8] drm/i915: Define an engine class enum for the uABI

2017-11-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/8] drm/i915: Define an engine class enum for the uABI URL : https://patchwork.freedesktop.org/series/33211/ State : warning == Summary == Test kms_chv_cursor_fail: Subgroup pipe-B-128x128-bottom-edge: pass -

Re: [Intel-gfx] [PATCH 4/5] drm/i915/guc: Increase wait timeout for doorbell release status update

2017-11-05 Thread Michal Wajdeczko
On Sun, 05 Nov 2017 14:39:42 +0100, Sagar Arun Kamble wrote: Current wait timeout of 10us is very tight as seen on SKL/KBL randomly for pm_rpm@basic-pci-d3-state. Increase it to 50us. Signed-off-by: Sagar Arun Kamble Cc: Chris Wilson Cc: Michał Winiarski Cc: Michel Thierry Cc: Michal Waj

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Read ilk FDI PLL frequency once during initialisation

2017-11-05 Thread Patchwork
== Series Details == Series: drm/i915: Read ilk FDI PLL frequency once during initialisation URL : https://patchwork.freedesktop.org/series/33210/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 fdo#99912 h

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/8] drm/i915: Define an engine class enum for the uABI

2017-11-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/8] drm/i915: Define an engine class enum for the uABI URL : https://patchwork.freedesktop.org/series/33211/ State : success == Summary == Series 33211v1 series starting with [CI,1/8] drm/i915: Define an engine class enum for the uABI ht

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Read ilk FDI PLL frequency once during initialisation

2017-11-05 Thread Patchwork
== Series Details == Series: drm/i915: Read ilk FDI PLL frequency once during initialisation URL : https://patchwork.freedesktop.org/series/33210/ State : success == Summary == Series 33210v1 drm/i915: Read ilk FDI PLL frequency once during initialisation https://patchwork.freedesktop.org/api/

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/5] drm/i915/guc: Separate GuC doorbell destroy function into doorbell unit and GuC task

2017-11-05 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/guc: Separate GuC doorbell destroy function into doorbell unit and GuC task URL : https://patchwork.freedesktop.org/series/33209/ State : warning == Summary == Series 33209v1 series starting with [1/5] drm/i915/guc: Separate GuC

[Intel-gfx] [CI 5/8] drm/i915: Mark the context state as dirty/written

2017-11-05 Thread Chris Wilson
In the next few patches, we will want to both copy out of the context image and write a valid image into a new context. To be completely safe, we should then couple in our domain tracking to ensure that we don't have any issues with stale data remaining in unwanted cachelines. Historically, we omi

[Intel-gfx] [CI 4/8] drm/i915: Inline intel_modeset_gem_init()

2017-11-05 Thread Chris Wilson
intel_modeset_gem_init() now only sets up the legacy overlay, so let's remove the function and call the setup directly during driver load. This should help us find a better point in the initialisation sequence for it later. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Reviewed-by: Mi

[Intel-gfx] [CI 3/8] drm/i915: Move GT powersaving init to i915_gem_init()

2017-11-05 Thread Chris Wilson
GT powersaving is tightly coupled to the request infrastructure. To avoid complications with the order of initialisation in the next patch (where we want to send requests to hw during GEM init) move the powersaving initialisation into the purview of i915_gem_init(). Signed-off-by: Chris Wilson Cc

[Intel-gfx] [CI 2/8] drm/i915: Force the switch to the i915->kernel_context

2017-11-05 Thread Chris Wilson
In the next few patches, we will have a hard requirement that we emit a context-switch to the perma-pinned i915->kernel_context (so that we can save the HW state using that context-switch). As the first context itself may be classed as a kernel context, we want to be explicit in our comparison. For

[Intel-gfx] [CI 7/8] drm/i915: Report whether we have true context isolation

2017-11-05 Thread Chris Wilson
Let userspace know if they can trust that new contexts are created using HW default values; and avoid inheriting state from existing contexts. Note: I intend to squash this into the bugfix once we agree on the uabi. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Joonas Lahtinen Cc: Tvrtko U

[Intel-gfx] [CI 8/8] drm/i915: Stop caching the "golden" renderstate

2017-11-05 Thread Chris Wilson
As we now record the default HW state and so only emit the "golden" renderstate once to prepare the HW, there is no advantage in keeping the renderstate batch around as it will never be used again. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [CI 6/8] drm/i915: Record the default hw state after reset upon load

2017-11-05 Thread Chris Wilson
Take a copy of the HW state after a reset upon module loading by executing a context switch from a blank context to the kernel context, thus saving the default hw state over the blank context image. We can then use the default hw state to initialise any future context, ensuring that each starts wit

[Intel-gfx] [CI 1/8] drm/i915: Define an engine class enum for the uABI

2017-11-05 Thread Chris Wilson
From: Tvrtko Ursulin We want to be able to report back to userspace details about an engine's class, and in return for userspace to be able to request actions regarding certain classes of engines. To isolate the uABI from any variations between hw generations, we define an abstract class for the

[Intel-gfx] [PATCH] drm/i915: Read ilk FDI PLL frequency once during initialisation

2017-11-05 Thread Chris Wilson
During intel_atomic_check(), we do not take the intel_runtime_pm_get() wakeref and so should do the atomic modeset precalculations without referring to the HW. However, on Ironlake we see <7>[ 23.487557] [drm:intel_atomic_check [i915]] [CONNECTOR:47:VGA-1] checking for sink bpp constrains <7>[

[Intel-gfx] [PATCH 4/5] drm/i915/guc: Increase wait timeout for doorbell release status update

2017-11-05 Thread Sagar Arun Kamble
Current wait timeout of 10us is very tight as seen on SKL/KBL randomly for pm_rpm@basic-pci-d3-state. Increase it to 50us. Signed-off-by: Sagar Arun Kamble Cc: Chris Wilson Cc: Michał Winiarski Cc: Michel Thierry Cc: Michal Wajdeczko Cc: Arkadiusz Hiler Cc: Joonas Lahtinen --- drivers/gpu/

[Intel-gfx] [PATCH 2/5] drm/i915/guc: Release all client doorbells on suspend and acquire on resume

2017-11-05 Thread Sagar Arun Kamble
Before GT device suspend, i915 should release GuC client doorbells by stopping doorbell controller snooping and doorbell deallocation through GuC. They need to be acquired again on resume. This will also resolve the driver unload issue with GuC, where doorbell deallocation was being done post GEM s

[Intel-gfx] [PATCH 1/5] drm/i915/guc: Separate GuC doorbell destroy function into doorbell unit and GuC task

2017-11-05 Thread Sagar Arun Kamble
Releasing GuC doorbell involves stopping the doorbell unit snooping and executing doorbell deallocation flow in GuC firmware. When GuC is in sane state, both steps will be necessary to release doorbell. If GuC is hung (possibly leading to i915 reset), only doorbell unit snooping is to be stopped. d

[Intel-gfx] [PATCH 5/5] HAX enable GuC submission for CI

2017-11-05 Thread Sagar Arun Kamble
Also revert ("drm/i915/guc: Assert that we switch between known ggtt->invalidate functions") --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++-- drivers/gpu/drm/i915/i915_params.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/dri

[Intel-gfx] [PATCH 3/5] drm/i915/guc: Deactivate all client doorbells before reset

2017-11-05 Thread Sagar Arun Kamble
Prior to i915 reset, we need to deactivate all client doorbells as they will need to be reacquired again post reset. We should not execute GuC doorbell deallocation flow as GuC might be in bad state (possibly reason for i915 reset). Signed-off-by: Sagar Arun Kamble Cc: Chris Wilson Cc: Michał Wi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Assert vma->flags are updated correctly during binding (rev3)

2017-11-05 Thread Patchwork
== Series Details == Series: drm/i915: Assert vma->flags are updated correctly during binding (rev3) URL : https://patchwork.freedesktop.org/series/33199/ State : failure == Summary == Series 33199v3 drm/i915: Assert vma->flags are updated correctly during binding https://patchwork.freedesktop

Re: [Intel-gfx] [PATCH v3] drm/i915: Assert vma->flags are updated correctly during binding

2017-11-05 Thread Matthew Auld
On 5 November 2017 at 12:45, Chris Wilson wrote: > As we bind, and unbind on error, we want to be sure that the vma->flags > are updated to reflect the binding state so that on the next invocation > all is well. > > v2: Take two. > v3: Take three; vma-misplaced is checking map-and-fenceable so kee

[Intel-gfx] [PATCH v3] drm/i915: Assert vma->flags are updated correctly during binding

2017-11-05 Thread Chris Wilson
As we bind, and unbind on error, we want to be sure that the vma->flags are updated to reflect the binding state so that on the next invocation all is well. v2: Take two. v3: Take three; vma-misplaced is checking map-and-fenceable so keep it last! Signed-off-by: Chris Wilson Cc: Joonas Lahtinen

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Assert vma->flags are updated correctly during binding (rev2)

2017-11-05 Thread Patchwork
== Series Details == Series: drm/i915: Assert vma->flags are updated correctly during binding (rev2) URL : https://patchwork.freedesktop.org/series/33199/ State : failure == Summary == Series 33199v2 drm/i915: Assert vma->flags are updated correctly during binding https://patchwork.freedesktop

[Intel-gfx] [PATCH v2] drm/i915: Assert vma->flags are updated correctly during binding

2017-11-05 Thread Chris Wilson
As we bind, and unbind on error, we want to be sure that the vma->flags are updated to reflect the binding state so that on the next invocation all is well. v2: Take two. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Matthew Auld --- drivers/gpu/drm/i915/i915_vma.c | 8 ++-- 1 file

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Assert vma->flags are updated correctly during binding

2017-11-05 Thread Patchwork
== Series Details == Series: drm/i915: Assert vma->flags are updated correctly during binding URL : https://patchwork.freedesktop.org/series/33199/ State : failure == Summary == Series 33199v1 drm/i915: Assert vma->flags are updated correctly during binding https://patchwork.freedesktop.org/ap

[Intel-gfx] [PATCH] drm/i915: Assert vma->flags are updated correctly during binding

2017-11-05 Thread Chris Wilson
As we bind, and unbind on error, we want to be sure that the vma->flags are updated to reflect the binding state so that on the next invocation all is well. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Matthew Auld --- drivers/gpu/drm/i915/i915_vma.c | 2 ++ 1 file changed, 2 insertions