Re: [Intel-gfx] [PATCH 4/7] drm/i915: fix register naming

2017-11-12 Thread Ewelina Musial
On Fri, Nov 10, 2017 at 07:08:42PM +, Lionel Landwerlin wrote: > This name was added with the whitelisting of registers for building up OA > configs. It is contained in a range gen8 whitelist : > >addr >= RPM_CONFIG0.reg && addr <= NOA_CONFIG(8).reg > > Hence why the name isn't used anywh

Re: [Intel-gfx] [PATCH 2/7] drm/i915/perf: add support for Coffeelake GT3

2017-11-12 Thread Ewelina Musial
On Fri, Nov 10, 2017 at 07:08:40PM +, Lionel Landwerlin wrote: > We can enable GT3 as well as GT2. > > Signed-off-by: Lionel Landwerlin > Reviewed-by: Matthew Auld Reviewed-by: Ewelina Musial > --- > drivers/gpu/drm/i915/Makefile | 3 +- > drivers/gpu/drm/i915/i915_drv.h |

Re: [Intel-gfx] [PATCH 1/7] drm/i915/perf: complete whitelisting for OA programming on HSW

2017-11-12 Thread Ewelina Musial
On Fri, Nov 10, 2017 at 07:08:39PM +, Lionel Landwerlin wrote: > We were missing some registers and also can name one for which we only had > the offset. > > Signed-off-by: Lionel Landwerlin > Reviewed-by: Matthew Auld > --- > drivers/gpu/drm/i915/i915_perf.c | 3 ++- > drivers/gpu/drm/i91

[Intel-gfx] [PATCH v4] drm/i915: Object w/o backing stroage is banned by -ENXIO

2017-11-12 Thread Tina Zhang
-ENXIO should be returned when operations are banned from changing backing storage of objects without backing storage. v4: - update "Reviewed-by". (Joonas) v3: - separate this patch from "Introduce GEM proxy" patch-set. (Joonas) v2: - update the patch description and subject to just mention obje

[Intel-gfx] [PATCH v3] drm/i915: Introduce GEM proxy

2017-11-12 Thread Tina Zhang
GEM proxy is a kind of GEM, whose backing physical memory is pinned and produced by guest VM and is used by host as read only. With GEM proxy, host is able to access guest physical memory through GEM object interface. As GEM proxy is such a special kind of GEM, a new flag I915_GEM_OBJECT_IS_PROXY i

Re: [Intel-gfx] [PATCH 0/1] HDMI 2.0 on CNL... not working...

2017-11-12 Thread Mike Lothian
Hi You will need a HDMI 2 cable Regards Mike On Fri, 10 Nov 2017, 10:27 pm Rodrigo Vivi, wrote: > I'm just sending this patch for reference here since > this is the patch that I believe it is the correct one > to get HDMI 2.0 working on CNL. > > However I'm just getting a blank screen when tr

Re: [Intel-gfx] [PATCH v9 8/8] drm/i915/guc : Calling intel_guc_init in i915_gem_init

2017-11-12 Thread Michal Wajdeczko
On Sat, 11 Nov 2017 01:06:38 +0100, Sujaritha Sundaresan wrote: Placing the call to intel_guc_init after i915_gem_contexts_init, based on the dependency within i915_gem_init. Will move the function if required, depending on the review comments. Suggested by: Sagar Arun Kamble Signed-off-by

Re: [Intel-gfx] [PATCH v9 7/8] drm/i915/guc : Decouple logs and ADS from submission

2017-11-12 Thread Michal Wajdeczko
On Sat, 11 Nov 2017 01:06:37 +0100, Sujaritha Sundaresan wrote: The Additional Data Struct (ADS) contains objects that are required by guc post FW load and are not necessarily submission-only (although that's our current only use-case). If in the future we load GuC with submission disabled to

Re: [Intel-gfx] [PATCH v9 6/8] drm/i915/guc : Introducing enable_guc module parameter

2017-11-12 Thread Michal Wajdeczko
On Sat, 11 Nov 2017 01:06:36 +0100, Sujaritha Sundaresan wrote: Replacing enable_guc_submission with enable_guc modparam. In effect enable_guc is replacing enable_guc_loading and enable_guc_submission. Maybe it will be better if we replace guc_loading and guc_submission modparams with singl

Re: [Intel-gfx] [PATCH v9 4/8] drm/i915/guc : Updating GuC logs to remove enable_guc_submission parameter

2017-11-12 Thread Michal Wajdeczko
On Sat, 11 Nov 2017 01:06:34 +0100, Sujaritha Sundaresan wrote: Replacing conditions to remove dependance on enable_guc_submission typo ;) v9: Including guc_log_level in the condition (Sagar) Signed-off-by: Sujaritha Sundaresan Cc: Michal Wajdeczko Cc: Oscar Mateo Cc: Sagar Arun Kamb

Re: [Intel-gfx] [PATCH v9 3/8] drm/i915/guc : Updating GuC and HuC firmware select function

2017-11-12 Thread Michal Wajdeczko
On Sat, 11 Nov 2017 01:06:33 +0100, Sujaritha Sundaresan wrote: Updating GuC and HuC firmware select function to support removing i915_modparams.enable_guc_loading module parameter. v2: Clarifying the commit message (Anusha) v3: Unify seq_puts messages, Re-factoring code as per review (Mich

Re: [Intel-gfx] [PATCH v9 2/8] drm/i915/guc : Removing i915_modparams.enable_guc_loading module parameter

2017-11-12 Thread Michal Wajdeczko
On Sat, 11 Nov 2017 01:06:32 +0100, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need submission=1, we also need loading=1.We also need loading=1 when we want to want to verify the HuC, whic

Re: [Intel-gfx] [PATCH v9 1/8] drm/i915 : Unifying seq_puts messages for feature support

2017-11-12 Thread Michal Wajdeczko
On Sat, 11 Nov 2017 01:06:31 +0100, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages in debugfs to the simplest one for feature support. v2: Clarifying the commit message (Anusha) v3: Re-factoring code as per review (Michal) v4: Rebase v5: Split from following patch v6:

Re: [Intel-gfx] [RFC PATCH 1/6] drm/i915: Remove Gen9 WAs with no effect

2017-11-12 Thread Chris Wilson
Quoting Mika Kuoppala (2017-11-09 11:42:45) > Oscar Mateo writes: > > > GEN8_CONFIG0 (0xD00) is a protected by a lock (bit 31) which is set by > > the BIOS, so there is no way we can enable the three chicken bits > > mandated by the WA (the BIOS should be doing it instead). > > > > v2: Rebased >

[Intel-gfx] ✗ Fi.CI.BAT: failure for lib/i915: Prepare for the loss of i915.enable_execlists parameter

2017-11-12 Thread Patchwork
== Series Details == Series: lib/i915: Prepare for the loss of i915.enable_execlists parameter URL : https://patchwork.freedesktop.org/series/33676/ State : failure == Summary == IGT patchset tested on top of latest successful build f370d5903689f37620e006f004a91d6bdeac7c16 lib/i915: Query sema

[Intel-gfx] [PATCH igt] lib/i915: Prepare for the loss of i915.enable_execlists parameter

2017-11-12 Thread Chris Wilson
If we can't find the enable_execlists parameter, presume that the switch is forced by the kernel and enabled for all hw supporting execlists. We don't have a GETPARAM or ENGINE_INFO to query the internal details. Signed-off-by: Chris Wilson --- lib/i915/gem_submission.c | 17 + 1

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs file"

2017-11-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs file" URL : https://patchwork.freedesktop.org/series/33672/ State : success == Summary == Test drv_module_reload: Subgroup basic-reload: pass -> DMESG-WARN

[Intel-gfx] ✗ Fi.CI.BAT: failure for tools/error_decode: Print ASCII user buffers

2017-11-12 Thread Patchwork
== Series Details == Series: tools/error_decode: Print ASCII user buffers URL : https://patchwork.freedesktop.org/series/33673/ State : failure == Summary == IGT patchset tested on top of latest successful build 7d75119b7f23fb49af52463da9bcd62e64fe6a6f lib: Always enable ftrace-dump-on-oops w

[Intel-gfx] [PATCH igt] tools/error_decode: Print ASCII user buffers

2017-11-12 Thread Chris Wilson
Look at the first 16 characters of the user buffer and if they are all printable, assume that user buffer contains ASCII data (e.g. a debug log) that we want to simply print out. Otherwise, we treat it as a binary data and hexdump as before. Signed-off-by: Chris Wilson --- tools/intel_error_deco

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs file"

2017-11-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs file" URL : https://patchwork.freedesktop.org/series/33672/ State : success == Summary == Series 33672v1 series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs

[Intel-gfx] [CI 2/3] Revert "drm/atomic: Use drm_framebuffer_print_info()"

2017-11-12 Thread Chris Wilson
This reverts commit f02b604b07d5314d01968eda4e199e6c46352a6d. --- drivers/gpu/drm/drm_atomic.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 37445d50816a..7e0e7bec2526 100644 --- a/drivers/g

[Intel-gfx] [CI 1/3] Revert "drm/framebuffer: Add framebuffer debugfs file"

2017-11-12 Thread Chris Wilson
This reverts commit 45d58b40292b16ab847497dcd299e315a2ad7956. --- drivers/gpu/drm/drm_debugfs.c | 6 drivers/gpu/drm/drm_framebuffer.c | 59 --- drivers/gpu/drm/drm_gem.c | 17 --- drivers/gpu/drm/drm_internal.h| 7 - include/d

[Intel-gfx] [CI 3/3] drm/i915: Remove redundant intel_autoenable_gt_powersave()

2017-11-12 Thread Chris Wilson
Now that we always execute a context switch upon module load, there is no need to queue a delayed task for doing so. The purpose of the delayed task is to enable GT powersaving, for which we need the HW state to be valid (i.e. having loaded a context and initialised basic state). We used to defer t

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs file"

2017-11-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs file" URL : https://patchwork.freedesktop.org/series/33671/ State : failure == Summary == Series 33671v1 series starting with [CI,1/3] Revert "drm/framebuffer: Add framebuffer debugfs

[Intel-gfx] [CI 3/3] drm/i915: Remove redundant intel_autoenable_gt_powersave()

2017-11-12 Thread Chris Wilson
Now that we always execute a context switch upon module load, there is no need to queue a delayed task for doing so. The purpose of the delayed task is to enable GT powersaving, for which we need the HW state to be valid (i.e. having loaded a context and initialised basic state). We used to defer t

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/2] Revert "drm/framebuffer: Add framebuffer debugfs file"

2017-11-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] Revert "drm/framebuffer: Add framebuffer debugfs file" URL : https://patchwork.freedesktop.org/series/33670/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK

[Intel-gfx] [CI 2/3] Revert "drm/atomic: Use drm_framebuffer_print_info()"

2017-11-12 Thread Chris Wilson
This reverts commit f02b604b07d5314d01968eda4e199e6c46352a6d. --- drivers/gpu/drm/drm_atomic.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 37445d50816a..7e0e7bec2526 100644 --- a/drivers/g

[Intel-gfx] [CI 1/3] Revert "drm/framebuffer: Add framebuffer debugfs file"

2017-11-12 Thread Chris Wilson
This reverts commit 45d58b40292b16ab847497dcd299e315a2ad7956. --- drivers/gpu/drm/drm_debugfs.c | 6 drivers/gpu/drm/drm_framebuffer.c | 59 --- drivers/gpu/drm/drm_gem.c | 17 --- drivers/gpu/drm/drm_internal.h| 7 - include/d

[Intel-gfx] [CI 1/2] Revert "drm/framebuffer: Add framebuffer debugfs file"

2017-11-12 Thread Chris Wilson
This reverts commit 45d58b40292b16ab847497dcd299e315a2ad7956. --- drivers/gpu/drm/drm_debugfs.c | 6 drivers/gpu/drm/drm_framebuffer.c | 59 --- drivers/gpu/drm/drm_gem.c | 17 --- drivers/gpu/drm/drm_internal.h| 7 - include/d

[Intel-gfx] [CI 2/2] drm/i915: Remove redundant intel_autoenable_gt_powersave()

2017-11-12 Thread Chris Wilson
Now that we always execute a context switch upon module load, there is no need to queue a delayed task for doing so. The purpose of the delayed task is to enable GT powersaving, for which we need the HW state to be valid (i.e. having loaded a context and initialised basic state). We used to defer t