Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-20 Thread Chris Wilson
Quoting Dave Airlie (2017-12-21 02:42:56) > > @@ -494,12 +473,11 @@ static int drm_syncobj_fd_to_handle(struct drm_file > > *file_private, > > spin_unlock(&file_private->syncobj_table_lock); > > idr_preload_end(); > > > > - if (ret < 0) { > > - fput(syncobj->fil

[Intel-gfx] ✗ Fi.CI.IGT: failure for tests: Add tests for new sequence API and leases

2017-12-20 Thread Patchwork
== Series Details == Series: tests: Add tests for new sequence API and leases URL : https://patchwork.freedesktop.org/series/35657/ State : failure == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-blt: pass -> FAIL (shard-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dp: Power cycle display if LINK_ADDRESS fails.

2017-12-20 Thread Patchwork
== Series Details == Series: drm/dp: Power cycle display if LINK_ADDRESS fails. URL : https://patchwork.freedesktop.org/series/35659/ State : success == Summary == Series 35659v1 drm/dp: Power cycle display if LINK_ADDRESS fails. https://patchwork.freedesktop.org/api/1.0/series/35659/revisions

[Intel-gfx] ✓ Fi.CI.BAT: success for tests: Add tests for new sequence API and leases

2017-12-20 Thread Patchwork
== Series Details == Series: tests: Add tests for new sequence API and leases URL : https://patchwork.freedesktop.org/series/35657/ State : success == Summary == IGT patchset tested on top of latest successful build 382865bf1204241cdb609fbf8953a1de781368f7 lib/i915_pciids.h: synchronize with

Re: [Intel-gfx] [PATCH] drm/dp: Power cycle display if LINK_ADDRESS fails.

2017-12-20 Thread Jani Nikula
On Wed, 20 Dec 2017, Dhinakaran Pandiyan wrote: > Occasionally there are LINK_ADDRESS sideband messages timing out with the > Lenovo MST dock + Dell MST monitor(w/ in-built branch) setup I have. These > failures lead to the display not coming up on boot. Power cycling the port > corresponding to t

[Intel-gfx] [PATCH] drm/dp: Power cycle display if LINK_ADDRESS fails.

2017-12-20 Thread Dhinakaran Pandiyan
Occasionally there are LINK_ADDRESS sideband messages timing out with the Lenovo MST dock + Dell MST monitor(w/ in-built branch) setup I have. These failures lead to the display not coming up on boot. Power cycling the port corresponding to the MST monitor's branch device and resending the message

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_sequence: Add tests for new CRTC get/queue sequence ioctls [v2]

2017-12-20 Thread Keith Packard
These ioctls replace drmWaitVBlank and add ns time resolution and 64-bit sequence numbers to comply with the Vulkan API specifications. The tests were derived from the existing kms_vblank tests with the 'wait' variant elided as the new API doesn't provide a mechanism for blocking in the kernel. v

[Intel-gfx] [PATCH i-g-t 0/2] tests: Add tests for new sequence API and leases

2017-12-20 Thread Keith Packard
Both of these APIs are now in the kernel; it would be nice to have the tests integrated into the test suite. This includes an updated version of the kms_lease patch (v3) which adapts to the final kernel API changes. ___ Intel-gfx mailing list Intel-gfx@

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_lease: add tests for lease ioctls [v3]

2017-12-20 Thread Keith Packard
Validate that the leasing API creates leases that allow access to a subset of the available resources and that lease revocation works. v2: from Dave Airlie * Update ioctl numbers to latest proposed values. * Fix commit message * Add tests for get_lease and list_lessees v3: adapt to final ker

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: DMC 1.07 for Cannonlake

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.07 for Cannonlake URL : https://patchwork.freedesktop.org/series/35651/ State : success == Summary == Test kms_cursor_crc: Subgroup cursor-64x64-suspend: skip -> PASS (shard-snb) fdo#102365 Test gem_tiled_swap

[Intel-gfx] [PULL] gvt-fixes for 4.15

2017-12-20 Thread Zhenyu Wang
Hi, Please pull one fix for 4.15 that correct default pipe enable for virtual display in a previous commit from Xiaolin. thanks -- The following changes since commit 11474e9091cf2002e948647fd9f63a7f027e488a: drm/i915/gvt: set max priority for gvt context (2017-12-06 11:38:21 +0800) are avail

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc : Decoupling ADS and logs from submission

2017-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc : Decoupling ADS and logs from submission URL : https://patchwork.freedesktop.org/series/35650/ State : success == Summary == Test kms_cursor_crc: Subgroup cursor-64x64-suspend: skip -> PASS

[Intel-gfx] [PATCH i-g-t] syncobj: add test for handle->fd + close twice.

2017-12-20 Thread Dave Airlie
From: Dave Airlie This demos a bug found in the vulkan CTS that causes VFS: Close: file count is 0 in dmesg, and ls /proc/self/fd to oops. Signed-off-by: Dave Airlie --- tests/syncobj_basic.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/syncobj_basic.c b/tests

Re: [Intel-gfx] [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd

2017-12-20 Thread Dave Airlie
> @@ -494,12 +473,11 @@ static int drm_syncobj_fd_to_handle(struct drm_file > *file_private, > spin_unlock(&file_private->syncobj_table_lock); > idr_preload_end(); > > - if (ret < 0) { > - fput(syncobj->file); > - return ret; > - } > -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: DMC 1.07 for Cannonlake

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.07 for Cannonlake URL : https://patchwork.freedesktop.org/series/35651/ State : success == Summary == Series 35651v1 drm/i915/dmc: DMC 1.07 for Cannonlake https://patchwork.freedesktop.org/api/1.0/series/35651/revisions/1/mbox/ Test debugfs_tes

[Intel-gfx] [PATCH] CNL DMC v1.07

2017-12-20 Thread Anusha Srivatsa
Adding Pull Request to the cover letter. This is to trigger the CI systems and not the official Pull Request(which will be sent after ack from CI). The following changes since commit 2451bb228f6401ca3f2ecd498bf3bab613c532a7: linux-firmware: liquidio: add v1.7.0 vswitch firmware (2017-12-06 22:0

[Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake

2017-12-20 Thread Anusha Srivatsa
There is a new version of DMC available for KBL. The release notes mentions: 1. Fix for the issue where DC_STATE was getting enabled even when disabled by driver causing data corruption Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/i915/intel_csr.c | 4 ++-- 1 file change

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc : Decoupling ADS and logs from submission

2017-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc : Decoupling ADS and logs from submission URL : https://patchwork.freedesktop.org/series/35650/ State : success == Summary == Series 35650v1 series starting with [1/2] drm/i915/guc : Decoupling ADS and logs from submission

[Intel-gfx] [PATCH 1/2] drm/i915/guc : Decoupling ADS and logs from submission

2017-12-20 Thread Sujaritha Sundaresan
The Additional Data Struct (ADS) contains objects that are required by GuC post FW load and are not necessarily submission-only. Even with submission disabled we may require something inside the ADS, so it makes more sense for them to be always created. Similarly, we still want to access GuC logs

[Intel-gfx] [PATCH 2/2] drm/i915/guc : GEM_BUG_ON for GuC reset

2017-12-20 Thread Sujaritha Sundaresan
Including GEM_BUG_ON for GuC reset function in intel_uncore. Signed-off-by: Sujaritha Sundaresan Cc: Chris Wilson Cc: Michal Wajdeczko Cc: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_uncore.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Zhang Rui
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ >   xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Zhang Rui
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ >   xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWU

Re: [Intel-gfx] [PATCH] i915: Reject CCS modifiers for pipe C on Geminilake

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 03:43:14PM +, Ben Widawsky wrote: > On 17-12-19 22:24:10, Gabriel Krisman Bertazi wrote: > > Current code advertises (on the modifiers blob property) support for CCS > > modifier for pipe C on GLK, only to reject it later when validating the > > request before the atomic

Re: [Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Optimize event parsing and processing

2017-12-20 Thread John Harrison
On 12/20/2017 1:54 AM, Tvrtko Ursulin wrote: What was the effect of all this on your big traces? I am only testing with a smaller one which goes from ~3.3s to ~2.2s. On a larger trace it might be non-linear gains due to double sort avoidance, unless there will be some other effects to cancel th

Re: [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 11:21:28PM +, Rodrigo Vivi wrote: > On Wed, Dec 20, 2017 at 08:55:24PM +, Lucas De Marchi wrote: > > Synchronize with kernel header as of > > c99d7832dcd7 ("drm/i915/cfl: Adding more Coffee Lake PCI IDs.") > > > > Signed-off-by: Lucas De Marchi > > Reviewed-by: Ro

Re: [Intel-gfx] [PATCH i-g-t] scripts/trace.pl: Fix context id recycling

2017-12-20 Thread John Harrison
Looks good. Or at least, it looks to be the same as it was originally. Reviewed-by:  John Harrison On 12/20/2017 1:38 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Last refactoring introduced a copy and paste error, fix it. Signed-off-by: Tvrtko Ursulin Reported-by: John Harrison Cc: Jo

Re: [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 08:55:24PM +, Lucas De Marchi wrote: > Synchronize with kernel header as of > c99d7832dcd7 ("drm/i915/cfl: Adding more Coffee Lake PCI IDs.") > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > lib/i915_pciids.h | 28 ++-- >

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Show FBC worker status in debugfs

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Show FBC worker status in debugfs URL : https://patchwork.freedesktop.org/series/35646/ State : warning == Summary == Test gem_softpin: Subgroup noreloc-s4: fail -> SKIP (shard-snb) fdo#103375 Subgroup noreloc-s

[Intel-gfx] ✗ Fi.CI.IGT: warning for lib/i915_pciids.h: synchronize with kernel header (rev3)

2017-12-20 Thread Patchwork
== Series Details == Series: lib/i915_pciids.h: synchronize with kernel header (rev3) URL : https://patchwork.freedesktop.org/series/35121/ State : warning == Summary == Test kms_flip: Subgroup vblank-vs-suspend-interruptible: pass -> DMESG-WARN (shard-snb) fdo#10

Re: [Intel-gfx] [PATCH] drm/i915/psr: Don't name status or debug registers like control registers.

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 08:10:21PM +, Dhinakaran Pandiyan wrote: > Avoids some typo pitfalls. > > Cc: Chris Wilson > Cc: Rodrigo Vivi > Signed-off-by: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Don't name status or debug registers like control registers.

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/psr: Don't name status or debug registers like control registers. URL : https://patchwork.freedesktop.org/series/35644/ State : success == Summary == Test kms_flip: Subgroup plain-flip-ts-check: pass -> FAIL (shard-hsw)

Re: [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 08:06:24PM +, De Marchi, Lucas wrote: > On Tue, 2017-12-19 at 15:28 -0800, Rodrigo Vivi wrote: > > On Tue, Dec 19, 2017 at 10:07:30PM +, Chris Wilson wrote: > > > Quoting Rodrigo Vivi (2017-12-19 21:59:43) > > > > On Fri, Dec 08, 2017 at 10:06:46PM +, Lucas De Ma

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Show FBC worker status in debugfs

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Show FBC worker status in debugfs URL : https://patchwork.freedesktop.org/series/35646/ State : success == Summary == Series 35646v1 drm/i915: Show FBC worker status in debugfs https://patchwork.freedesktop.org/api/1.0/series/35646/revisions/1/mbox/ Test

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/i915_pciids.h: synchronize with kernel header (rev3)

2017-12-20 Thread Patchwork
== Series Details == Series: lib/i915_pciids.h: synchronize with kernel header (rev3) URL : https://patchwork.freedesktop.org/series/35121/ State : success == Summary == IGT patchset tested on top of latest successful build 851c417b6b7a4ea28af67cfad116c8b7dc1d263e igt/kms_frontbuffer_tracking:

[Intel-gfx] [PATCH] drm/i915: Show FBC worker status in debugfs

2017-12-20 Thread Chris Wilson
Include the pending update from the FBC worker in i915_fbc_status. Signed-off-by: Chris Wilson Cc: Paulo Zanoni --- drivers/gpu/drm/i915/i915_debugfs.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread Lucas De Marchi
Synchronize with kernel header as of c99d7832dcd7 ("drm/i915/cfl: Adding more Coffee Lake PCI IDs.") Signed-off-by: Lucas De Marchi --- lib/i915_pciids.h | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h index

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/gem_spin_batch: Skip overloading aliased BSD engines

2017-12-20 Thread Patchwork
== Series Details == Series: igt/gem_spin_batch: Skip overloading aliased BSD engines URL : https://patchwork.freedesktop.org/series/35634/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render: fail -> PASS

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Don't name status or debug registers like control registers.

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/psr: Don't name status or debug registers like control registers. URL : https://patchwork.freedesktop.org/series/35644/ State : success == Summary == Series 35644v1 drm/i915/psr: Don't name status or debug registers like control registers. https://patchw

Re: [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread De Marchi, Lucas
On Tue, 2017-12-19 at 13:59 -0800, Rodrigo Vivi wrote: > On Fri, Dec 08, 2017 at 10:06:46PM +, Lucas De Marchi wrote: > > This copies include/drm/i915_pciids.h from kernel as of drm-tip: > > drm-tip: 2017y-12m-08d-21h-06m-35s UTC + patch adding INTEL_CFL_IDS that > > was missing there[1]. > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cfl: Adding more Coffee Lake PCI IDs.

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/cfl: Adding more Coffee Lake PCI IDs. URL : https://patchwork.freedesktop.org/series/35636/ State : success == Summary == Test gem_eio: Subgroup in-flight-contexts: pass -> DMESG-WARN (shard-snb) fdo#104058 Test kms_frontbuffe

Re: [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread Chris Wilson
Quoting De Marchi, Lucas (2017-12-20 20:06:24) > On Tue, 2017-12-19 at 15:28 -0800, Rodrigo Vivi wrote: > > On Tue, Dec 19, 2017 at 10:07:30PM +, Chris Wilson wrote: > > > Quoting Rodrigo Vivi (2017-12-19 21:59:43) > > > > On Fri, Dec 08, 2017 at 10:06:46PM +, Lucas De Marchi wrote: > > > >

[Intel-gfx] [PATCH] drm/i915/psr: Don't name status or debug registers like control registers.

2017-12-20 Thread Dhinakaran Pandiyan
Avoids some typo pitfalls. Cc: Chris Wilson Cc: Rodrigo Vivi Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- drivers/gpu/drm/i915/i915_reg.h | 6 +++--- drivers/gpu/drm/i915/intel_psr.c| 24 3 files changed, 17 insertions(

Re: [Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread De Marchi, Lucas
On Tue, 2017-12-19 at 15:28 -0800, Rodrigo Vivi wrote: > On Tue, Dec 19, 2017 at 10:07:30PM +, Chris Wilson wrote: > > Quoting Rodrigo Vivi (2017-12-19 21:59:43) > > > On Fri, Dec 08, 2017 at 10:06:46PM +, Lucas De Marchi wrote: > > > > This copies include/drm/i915_pciids.h from kernel as o

Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix register name mess up.

2017-12-20 Thread Pandiyan, Dhinakaran
On Wed, 2017-12-20 at 09:24 +, Chris Wilson wrote: > Quoting Dhinakaran Pandiyan (2017-12-20 04:35:20) > > Commit 77affa31722b ("drm/i915/psr: Fix compiler warnings for > > hsw_psr_disable()") swapped status and control registers while fixing > > indentation. The _ctl at the end of the statu

Re: [Intel-gfx] [PATCH 0/8] Misc i915_drv.h cleanups

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 07:24:52PM +, Jani Nikula wrote: > On Wed, 20 Dec 2017, Michal Wajdeczko wrote: > > Our main header is huge. Lets try to make some cleanup. > > Overall seems fine, I think I agree with Chris' review. I do want > Rodrigo's ack wrt upcoming stuff that's bound to conflict

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_spin_batch: Skip overloading aliased BSD engines

2017-12-20 Thread Patchwork
== Series Details == Series: igt/gem_spin_batch: Skip overloading aliased BSD engines URL : https://patchwork.freedesktop.org/series/35634/ State : success == Summary == IGT patchset tested on top of latest successful build 851c417b6b7a4ea28af67cfad116c8b7dc1d263e igt/kms_frontbuffer_tracking:

Re: [Intel-gfx] [PATCH 0/8] Misc i915_drv.h cleanups

2017-12-20 Thread Jani Nikula
On Wed, 20 Dec 2017, Michal Wajdeczko wrote: > Our main header is huge. Lets try to make some cleanup. Overall seems fine, I think I agree with Chris' review. I do want Rodrigo's ack wrt upcoming stuff that's bound to conflict with many of the patches here. I don't want to cause unnecessary burde

Re: [Intel-gfx] [PATCH] drm/i915/cfl: Adding more Coffee Lake PCI IDs.

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 07:15:47PM +, Anusha Srivatsa wrote: > On Wed, Dec 20, 2017 at 10:29:19AM -0800, Rodrigo Vivi wrote: > > Spec has been updated with more reserved IDs for existent SKUs. > > > > Cc: Lucas De Marchi > > Cc: Anusha Srivatsa > > Cc: Dhinakaran Pandiyan > > Cc: Anuj Phoga

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Dump device info at once

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:10) > We are dumping device info separately for sw_only and runtime part > but to simplify the code we can also do it from one place once > we complete driver load. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joonas

Re: [Intel-gfx] [PATCH] drm/i915/cfl: Adding more Coffee Lake PCI IDs.

2017-12-20 Thread Anusha Srivatsa
On Wed, Dec 20, 2017 at 10:29:19AM -0800, Rodrigo Vivi wrote: > Spec has been updated with more reserved IDs for existent SKUs. > > Cc: Lucas De Marchi > Cc: Anusha Srivatsa > Cc: Dhinakaran Pandiyan > Cc: Anuj Phogat > Signed-off-by: Rodrigo Vivi The IDs match with Spec. Reviewed-by: Anusha

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Update intel_device_info_runtime_init() parameter

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:08) > As we try to follow object-verb pattern in our functions, update > intel_device_info_runtime_init() parameter from dev_priv to info. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen The patch looks

[Intel-gfx] ✗ Fi.CI.BAT: failure for Misc i915_drv.h cleanups

2017-12-20 Thread Patchwork
== Series Details == Series: Misc i915_drv.h cleanups URL : https://patchwork.freedesktop.org/series/35637/ State : failure == Summary == Series 35637v1 Misc i915_drv.h cleanups https://patchwork.freedesktop.org/api/1.0/series/35637/revisions/1/mbox/ Test debugfs_test: Subgroup read_a

Re: [Intel-gfx] [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Rafael J. Wysocki
On Tuesday, December 19, 2017 7:15:08 PM CET Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Move intel_device_info definitions to its own header

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:07) > We already keep intel_device_info functions in dedicated file. > Add matching header file and move related definitions there. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen > --- > drivers/gpu/dr

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: copy intel_aub.h from libdrm

2017-12-20 Thread Jordan Justen
Series: Tested-by: Jordan Justen Reviewed-by: Jordan Justen On 2017-12-06 15:11:20, Scott D Phillips wrote: > No functionality related to aub is provided by libdrm aside from > intel_aub.h which somewhat defines the file format. Move the > header into this project to ease aub-related developmen

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Move opregion definitions to dedicated intel_opregion.h

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:06) > We already have dedicated file for opregion related code, dedicated > header will make our life easier. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen > Cc: Ville Syrjälä > --- > drivers/gpu/d

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Move display related definitions to dedicated header

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:05) > We already have separate files for display related code, there > is no reason to keep all display definitions in master header. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen Looks a straight cop

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Move some utility functions to i915_util.h

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:04) > We have dedicated header file for utility functions and macros. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen Reviewed-by: Chris Wilson -Chris ___ Int

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Move uint_fixed_16_16_t to i915_types.h

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:03) > Our uint_fixed_16_16_t definition and related helper functions > deserve dedicated header. While here cleanup types and indent. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen > --- > drivers/gpu/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cfl: Adding more Coffee Lake PCI IDs.

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/cfl: Adding more Coffee Lake PCI IDs. URL : https://patchwork.freedesktop.org/series/35636/ State : success == Summary == Series 35636v1 drm/i915/cfl: Adding more Coffee Lake PCI IDs. https://patchwork.freedesktop.org/api/1.0/series/35636/revisions/1/mbox/

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Add pretty printer for runtime part of intel_device_info

2017-12-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-12-20 18:36:09) > During initialization of the runtime part of the intel_device_info > we are dumping that part using DRM_DEBUG_DRIVERE mechanism. > As we already have pretty printer for const part of the info, > make similar function for the runtime part and use it s

[Intel-gfx] [PATCH 2/8] drm/i915: Move some utility functions to i915_util.h

2017-12-20 Thread Michal Wajdeczko
We have dedicated header file for utility functions and macros. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 15 --- drivers/gpu/drm/i915/i915_utils.h | 15 +++ 2 files changed, 15 inserti

[Intel-gfx] [PATCH 8/8] drm/i915: Dump device info at once

2017-12-20 Thread Michal Wajdeczko
We are dumping device info separately for sw_only and runtime part but to simplify the code we can also do it from one place once we complete driver load. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 18 +++

[Intel-gfx] [PATCH 1/8] drm/i915: Move uint_fixed_16_16_t to i915_types.h

2017-12-20 Thread Michal Wajdeczko
Our uint_fixed_16_16_t definition and related helper functions deserve dedicated header. While here cleanup types and indent. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 139 +-- driv

[Intel-gfx] [PATCH 7/8] drm/i915: Add pretty printer for runtime part of intel_device_info

2017-12-20 Thread Michal Wajdeczko
During initialization of the runtime part of the intel_device_info we are dumping that part using DRM_DEBUG_DRIVERE mechanism. As we already have pretty printer for const part of the info, make similar function for the runtime part and use it separately. Signed-off-by: Michal Wajdeczko Cc: Chris

[Intel-gfx] [PATCH 6/8] drm/i915: Update intel_device_info_runtime_init() parameter

2017-12-20 Thread Michal Wajdeczko
As we try to follow object-verb pattern in our functions, update intel_device_info_runtime_init() parameter from dev_priv to info. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 5/8] drm/i915: Move intel_device_info definitions to its own header

2017-12-20 Thread Michal Wajdeczko
We already keep intel_device_info functions in dedicated file. Add matching header file and move related definitions there. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 139 + drive

[Intel-gfx] [PATCH 4/8] drm/i915: Move opregion definitions to dedicated intel_opregion.h

2017-12-20 Thread Michal Wajdeczko
We already have dedicated file for opregion related code, dedicated header will make our life easier. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 57 +--- drivers/gpu/drm

[Intel-gfx] [PATCH 3/8] drm/i915: Move display related definitions to dedicated header

2017-12-20 Thread Michal Wajdeczko
We already have separate files for display related code, there is no reason to keep all display definitions in master header. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_drv.h | 283 +-- d

[Intel-gfx] [PATCH 0/8] Misc i915_drv.h cleanups

2017-12-20 Thread Michal Wajdeczko
Our main header is huge. Lets try to make some cleanup. Cc: Chris Wilson Cc: Rodrigo Vivi Cc: Joonas Lahtinen Michal Wajdeczko (8): drm/i915: Move uint_fixed_16_16_t to i915_types.h drm/i915: Move some utility functions to i915_util.h drm/i915: Move display related definitions to dedicat

[Intel-gfx] [PATCH] drm/i915/cfl: Adding more Coffee Lake PCI IDs.

2017-12-20 Thread Rodrigo Vivi
Spec has been updated with more reserved IDs for existent SKUs. Cc: Lucas De Marchi Cc: Anusha Srivatsa Cc: Dhinakaran Pandiyan Cc: Anuj Phogat Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_pci.c | 2 ++ include/drm/i915_pciids.h | 28 ++-- 2 files

[Intel-gfx] [PATCH igt] igt/gem_spin_batch: Skip overloading aliased BSD engines

2017-12-20 Thread Chris Wilson
BSD == BSD1 or BSD2. Since we already emit spinners to the explicit BSD rins, skip the aliased ring. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104352 Signed-off-by: Chris Wilson --- tests/gem_spin_batch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gem_

Re: [Intel-gfx] [PATCH igt] igt/kms_frontbuffer_tracking: Make assert(false) more informative

2017-12-20 Thread Rodrigo Vivi
On Wed, Dec 20, 2017 at 09:42:57AM +, Chris Wilson wrote: > When reading CI failure reports seeing an "assertion false failed" is > confusing as you then have to look for the preceding explanation. Show > the actual condition that fails in the assert report. Note that this > give the system a c

Re: [Intel-gfx] [PATCH] drm/i915: Protect DDI port to DPLL map from theoretical race.

2017-12-20 Thread Ausmus, James
On Fri, Dec 15, 2017 at 2:35 PM, Rodrigo Vivi wrote: > In case we have multiple modesets for different connectors > happening in parallel we could have a race on the RMW on these > shared registers. > > This possibility was initially raised by Paulo when reviewing > commit '555e38d27317 ("drm/i915

Re: [Intel-gfx] [PATCH i-g-t] tools: Cannonlake port clock programming

2017-12-20 Thread Rodrigo Vivi
On Thu, Dec 07, 2017 at 12:36:34PM +, Mika Kahola wrote: > Cannonlake port clock programming tests and verifies DPLL legal dividers > P, Q, and K. This tests adds two reference clocks 19.2MHz and 24MHz to > test algorithm's capability to find P, Q, and K dividers as well as DCO > frequency for

Re: [Intel-gfx] [-next PATCH 0/4] sysfs and DEVICE_ATTR_

2017-12-20 Thread Corey Minyard
On 12/19/2017 12:15 PM, Joe Perches wrote: drivers/char/ipmi/ipmi_msghandler.c| 17 +++--- For ipmi: Acked-by: Corey Minyard ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/

Re: [Intel-gfx] [alsa-devel] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Jidong Zhang
Does anyone know how to use Conexant CX20921 to develop our own application. I cannot find anywhere to download the software and manuals. Thanks to all J.D -Original Message- From: alsa-devel-boun...@alsa-project.org [mailto:alsa-devel-boun...@alsa-project.org] On Behalf Of Andy Shevch

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Jarkko Nikula
On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > > > Convert DEVICE_ATTR uses to DEVIC

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Jarkko Nikula
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > ... > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c > index 7a54e3083203..79d4dc785e5c 100644 > --- a/sound/soc/omap/mcbsp.c > +++ b/sound/soc/omap/mcbsp.c

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2017-12-20 Thread Byungchul Park
On 12/19/2017 6:59 PM, Daniel Vetter wrote: On Mon, Dec 18, 2017 at 09:42:13AM -0800, Linus Torvalds wrote: On Sun, Dec 17, 2017 at 11:11 PM, Daniel Vetter wrote: This didn't seem to have made it into -rc4. Anything needed to get it going? Do you actually see the problem in -rc4? Because w

Re: [Intel-gfx] Question about CCS modifier on GLK

2017-12-20 Thread Ben Widawsky
On 17-12-17 22:45:13, Gabriel Krisman Bertazi wrote: Hi Ben and list folks, I've been investigating some CI failures with the kms_ccs testcase in the GLK hardware. The original bug is linked below, but there are other more basic tests failing when trying CCS on pipe C. https://bugs.freedeskto

Re: [Intel-gfx] [PATCH] i915: Reject CCS modifiers for pipe C on Geminilake

2017-12-20 Thread Ben Widawsky
On 17-12-19 22:24:10, Gabriel Krisman Bertazi wrote: Current code advertises (on the modifiers blob property) support for CCS modifier for pipe C on GLK, only to reject it later when validating the request before the atomic commit. This fixes the tests igt@kms_ccs@pipe-c-*, which should skip on

Re: [Intel-gfx] [PATCH v2] drm/i915/vlv: Add cdclk workaround for DSI

2017-12-20 Thread Ville Syrjälä
On Wed, Dec 20, 2017 at 11:50:17AM +0100, Hans de Goede wrote: > At least on the Chuwi Vi8 (non pro/plus) the LCD panel will show an image > shifted aprox. 20% to the left (with wraparound) and sometimes also wrong > colors, showing that the panel controller is starting with sampling the > datastre

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Julia Lawall
On Wed, 20 Dec 2017, Joe Perches wrote: > On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote: > > > > Why you didn't send that patch to the sysfs maintainer is a bit odd... > > > > :) > > > > > > So here's an opportunity for you: > > > > > > The sysfs maintainer hasn't added include/l

Re: [Intel-gfx] [PATCH] drm/i915: Tidy up GEM_TRACE around execlists

2017-12-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-20 13:21:45) > > On 20/12/2017 12:43, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-12-20 12:39:42) > >> > >> On 20/12/2017 09:06, Chris Wilson wrote: > >>> Looking at the coordination of resets with the submission of execlists, > >>> it will be useful to hav

Re: [Intel-gfx] [PATCH] drm/i915: Tidy up GEM_TRACE around execlists

2017-12-20 Thread Tvrtko Ursulin
On 20/12/2017 12:43, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-12-20 12:39:42) On 20/12/2017 09:06, Chris Wilson wrote: Looking at the coordination of resets with the submission of execlists, it will be useful to have a GEM_TRACE for when we issue the reset. Whilst there tidy up the ot

Re: [Intel-gfx] [PATCH] drm/i915: Tidy up GEM_TRACE around execlists

2017-12-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-20 12:39:42) > > On 20/12/2017 09:06, Chris Wilson wrote: > > Looking at the coordination of resets with the submission of execlists, > > it will be useful to have a GEM_TRACE for when we issue the reset. > > Whilst there tidy up the other GEM_TRACE to always includ

Re: [Intel-gfx] [PATCH] drm/i915: Tidy up GEM_TRACE around execlists

2017-12-20 Thread Tvrtko Ursulin
On 20/12/2017 09:06, Chris Wilson wrote: Looking at the coordination of resets with the submission of execlists, it will be useful to have a GEM_TRACE for when we issue the reset. Whilst there tidy up the other GEM_TRACE to always include the engine name, and be careful not to trust any pointers

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/perf_pmu: Simplify interrupt testing

2017-12-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-12-20 12:35:31) > > On 20/12/2017 10:49, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-12-20 09:45:41) > >> > >> On 19/12/2017 21:45, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2017-12-19 15:45:42) > From: Tvrtko Ursulin > > Rather than ca

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/perf_pmu: Simplify interrupt testing

2017-12-20 Thread Tvrtko Ursulin
On 20/12/2017 10:49, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-12-20 09:45:41) On 19/12/2017 21:45, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-12-19 15:45:42) From: Tvrtko Ursulin Rather than calibrate and emit nop batches, use a manually signalled chain of spinners to generat

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/vlv: Add cdclk workaround for DSI (rev2)

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/vlv: Add cdclk workaround for DSI (rev2) URL : https://patchwork.freedesktop.org/series/35598/ State : warning == Summary == Test kms_flip: Subgroup plain-flip-ts-check-interruptible: pass -> FAIL (shard-hsw) fdo#100368

[Intel-gfx] [PULL] drm-intel-fixes

2017-12-20 Thread Jani Nikula
Hi Dave, seasons greetings, just a few small fixes. BR, Jani. The following changes since commit 2cf654db8d7eafb973d28eb3cddf043d353e1345: drm/i915/fence: Use rcu to defer freeing of irq_work (2017-12-14 10:58:59 +0200) are available in the git repository at: git://anongit.freedesktop.or

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/kms_frontbuffer_tracking: Make assert(false) more informative

2017-12-20 Thread Patchwork
== Series Details == Series: igt/kms_frontbuffer_tracking: Make assert(false) more informative URL : https://patchwork.freedesktop.org/series/35617/ State : success == Summary == Warning: bzip IGTPW_712/shard-hsw4/results34.json.bz2 wasn't in correct JSON format Test kms_frontbuffer_tracking:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Plug framebuffer leaks.

2017-12-20 Thread Patchwork
== Series Details == Series: drm: Plug framebuffer leaks. URL : https://patchwork.freedesktop.org/series/35615/ State : success == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-pri-indfb-multidraw: fail -> PASS (shard-snb) fdo#103167 Subg

[Intel-gfx] ✗ Fi.CI.BAT: failure for scripts/trace.pl: Rudimentary preemption support

2017-12-20 Thread Patchwork
== Series Details == Series: scripts/trace.pl: Rudimentary preemption support URL : https://patchwork.freedesktop.org/series/35618/ State : failure == Summary == Applying: scripts/trace.pl: Rudimentary preemption support Using index info to reconstruct a base tree... M scripts/trace.pl F

Re: [Intel-gfx] [PATCH i-g-t v9] tests/kms_frontbuffer_tracking: Including DRRS test coverage

2017-12-20 Thread Tahvanainen, Jari
-Original Message- > From: Lohith BS [mailto:lohith...@intel.com] > Sent: Monday, December 11, 2017 3:13 PM > To: intel-gfx@lists.freedesktop.org; rodrigo.v...@intel.com; > jani.saari...@intel.com; daniel.vet...@ffwll.ch; ch...@chris-wilson.co.uk > Cc: ankit.k.nauti...@intel.com; paulo.r.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vlv: Add cdclk workaround for DSI (rev2)

2017-12-20 Thread Patchwork
== Series Details == Series: drm/i915/vlv: Add cdclk workaround for DSI (rev2) URL : https://patchwork.freedesktop.org/series/35598/ State : success == Summary == Series 35598v2 drm/i915/vlv: Add cdclk workaround for DSI https://patchwork.freedesktop.org/api/1.0/series/35598/revisions/2/mbox/

Re: [Intel-gfx] [PATCH 4/4] drm/i915: push shared dpll enable to encoders on DDI platforms

2017-12-20 Thread Chauhan, Madhav
> -Original Message- > From: Chauhan, Madhav > Sent: Monday, December 18, 2017 6:35 PM > To: Nikula, Jani ; intel-gfx@lists.freedesktop.org > Cc: Daniel Vetter > Subject: RE: [Intel-gfx] [PATCH 4/4] drm/i915: push shared dpll enable to > encoders on DDI platforms > > > -Original Messa

Re: [Intel-gfx] [PATCH igt v2] igt/pm_rps: Always allocate spin[0]

2017-12-20 Thread Chris Wilson
Quoting Szwichtenberg, Radoslaw (2017-12-20 10:12:23) > On Tue, 2017-12-19 at 12:34 +, Chris Wilson wrote: > > Avoid having to test for spin[0] existing by starting the load-loop with > > it allocated. > > > > v2: Preallocate the spin[1] as well for high load. > > > > References: https://bugs

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Joe Perches
On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote: > > > Why you didn't send that patch to the sysfs maintainer is a bit odd... :) > > > > So here's an opportunity for you: > > > > The sysfs maintainer hasn't added include/linux/sysfs.h to > > the list of maintained files... > > > > D

  1   2   >