[Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset.

2018-01-03 Thread Maarten Lankhorst
This weas a workaround to gracefully skip on i915 before nonblocking modeset support was added, but this is no longer needed. Remove the code, since it's safe to always assume such support is enabled. Signed-off-by: Maarten Lankhorst Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104471 -

Re: [Intel-gfx] [PATCH v2] drm/i915: Try EDID bitbanging on HDMI after failed read

2018-01-03 Thread Stefan Brüns
On Wednesday, January 3, 2018 8:14:47 AM CET Jani Nikula wrote: > On Tue, 02 Jan 2018, Chris Wilson wrote: > > Quoting Rodrigo Vivi (2018-01-02 19:12:18) > > > >> On Sun, Dec 31, 2017 at 10:34:54PM +, Stefan Brüns wrote: > >> > + edid = drm_get_edid(connector, i2c); > >> > + > >> > +

[Intel-gfx] ✓ Fi.CI.BAT: success for kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset.

2018-01-03 Thread Patchwork
== Series Details == Series: kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset. URL : https://patchwork.freedesktop.org/series/35934/ State : success == Summary == IGT patchset tested on top of latest successful build d86d53b072b50172309abf21ecb521bd70c5fc73 tests/kms_curso

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset.

2018-01-03 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Maarten Lankhorst > Sent: Wednesday, January 3, 2018 11:19 AM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition

Re: [Intel-gfx] [PATCH 18/19] drm/i915/execlists: Tidy enabling execlists

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 03:12:34PM +, Chris Wilson wrote: > Move the register settings for enabling execlists into its own function > for clarity. > > Signed-off-by: Chris Wilson Reviewed-by: Michał Winiarski -Michał > --- > drivers/gpu/drm/i915/intel_lrc.c | 22 ++ >

Re: [Intel-gfx] [PATCH 17/19] drm/i915/execlists: Record elsp offset during engine setup

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 03:12:33PM +, Chris Wilson wrote: > Currently, we record the elsp register offset inside init-hw but we only > need to do it once during engine setup (after we know the mmio > iomapping). > > Signed-off-by: Chris Wilson Reviewed-by: Michał Winiarski -Michał > --- >

Re: [Intel-gfx] [PATCH 16/19] drm/i915/execlists: Clear context-switch interrupt earlier in the reset

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 03:12:32PM +, Chris Wilson wrote: > Move the clearing of the CS-interrupt into the engine reset phase, > before the current init-hw phase. This helps clarify that we clear the > pending interrupts prior to any restarting of the execlists. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 15/19] drm/i915: Hold rpm wakeref for modifying the global seqno

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 03:12:31PM +, Chris Wilson wrote: > To modify the global seqno may require rewriting a few registers, which > requires us to hold the rpm wakeref. We must therefore take it around > the call to i915_gem_set_global_seqno() in debugfs, on behalf of the > user. > > Signed-

[Intel-gfx] ✓ Fi.CI.IGT: success for kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset.

2018-01-03 Thread Patchwork
== Series Details == Series: kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset. URL : https://patchwork.freedesktop.org/series/35934/ State : success == Summary == Test kms_flip: Subgroup blt-wf_vblank-vs-modeset: skip -> PASS (shard-hsw)

Re: [Intel-gfx] [PATCH 11/19] drm/i915/execlists: Reduce list_for_each_safe+list_safe_reset_next

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 03:12:27PM +, Chris Wilson wrote: > After staring at the list_for_each_safe macros for a bit, our current > invocation of list_safe_reset_next in execlists_schedule() simply > reduces to list_for_each. > > Signed-off-by: Chris Wilson Reviewed-by: Michał Winiarski -M

Re: [Intel-gfx] [PATCH 18/19] drm/i915/execlists: Tidy enabling execlists

2018-01-03 Thread Chris Wilson
Quoting Michał Winiarski (2018-01-03 09:55:39) > On Tue, Jan 02, 2018 at 03:12:34PM +, Chris Wilson wrote: > > Move the register settings for enabling execlists into its own function > > for clarity. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Michał Winiarski Pushed the 3 code mo

Re: [Intel-gfx] [PATCH 10/19] drm/i915/execlists: Assert there are no simple cycles in the dependencies

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 03:12:26PM +, Chris Wilson wrote: > The dependency chain must be an acyclic graph. This is checked by the > swfence, but for sanity, also do a simple check that we do not corrupt > our list iteration in execlists_schedule() by a shallow dependency > cycle. > > Signed-of

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset.

2018-01-03 Thread Maarten Lankhorst
Op 03-01-18 om 10:50 schreef Lofstedt, Marta: > Reviewed-by: Marta Lofstedt Thanks, pushed. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 09/19] drm/i915: Assert all signalers we depended on did indeed signal

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 03:12:25PM +, Chris Wilson wrote: > Back up our comment that all signalers should have been signaled before > we ourselves were retired with an assert to that effect. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Michał Winiarski -Michał > ---

Re: [Intel-gfx] [PATCH 09/19] drm/i915: Assert all signalers we depended on did indeed signal

2018-01-03 Thread Chris Wilson
Quoting Michał Winiarski (2018-01-03 11:40:19) > On Tue, Jan 02, 2018 at 03:12:25PM +, Chris Wilson wrote: > > Back up our comment that all signalers should have been signaled before > > we ourselves were retired with an assert to that effect. > > > > Signed-off-by: Chris Wilson > > Cc: Joona

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Chris Wilson
Quoting Alexandru Chirvasitu (2018-01-03 00:14:38) > For comparison, here's another one produced by the same kernel, on the > same laptop, but a different hard drive. > > The OS was installed on a USB stick that I'd boot the laptop off > of. Recently I started getting lags when copying to / from t

[Intel-gfx] [PATCH igt 2/2] lib/gem: Reset the global seqno at the start of each test

2018-01-03 Thread Chris Wilson
When we require GEM, reset the global seqno. This gives each test a clean slate to work with, and avoids left-over state from previous tests impacting on the next. In particular, somes tests may be setting up long sequence of stalling batches not expecting to hit a seqno wraparound (leftover from,

[Intel-gfx] [PATCH igt 1/2] igt/gem_busy: Remove repeated use of igt_spin_batch_new

2018-01-03 Thread Chris Wilson
igt_spin_batch_new() includes a throttling check that GEM works, which breaks trying to create multiple spin batches, use __igt_spin_batch_new() instead, after verifying GEM works. Signed-off-by: Chris Wilson --- tests/gem_busy.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Alexandru Chirvasitu
I've cloned your https://anongit.freedesktop.org/git/drm-tip.git and am now trying to build it (just the master; I haven't tried previous commits). The build fails at the modules stage with Makefile:1015: recipe for target 'drivers' failed make: *** [drivers] Error 2 What is the earliest commit

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] igt/gem_busy: Remove repeated use of igt_spin_batch_new

2018-01-03 Thread Patchwork
== Series Details == Series: series starting with [1/2] igt/gem_busy: Remove repeated use of igt_spin_batch_new URL : https://patchwork.freedesktop.org/series/35942/ State : success == Summary == IGT patchset tested on top of latest successful build 58bd37d347d1369ecd272ff778057ee8004d6b15 km

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Chris Wilson
Quoting Alexandru Chirvasitu (2018-01-03 13:46:42) > I've cloned your > > https://anongit.freedesktop.org/git/drm-tip.git > > and am now trying to build it (just the master; I haven't tried > previous commits). The build fails at the modules stage with > > Makefile:1015: recipe for target 'drive

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Alexandru Chirvasitu
On Wed, Jan 03, 2018 at 01:47:56PM +, Chris Wilson wrote: > Quoting Alexandru Chirvasitu (2018-01-03 13:46:42) > > I've cloned your > > > > https://anongit.freedesktop.org/git/drm-tip.git > > > > and am now trying to build it (just the master; I haven't tried > > previous commits). The build

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [v2,1/2] drm/i915/guc : Decoupling ADS and logs from submission

2018-01-03 Thread Chris Wilson
Quoting Patchwork (2018-01-02 22:40:48) > == Series Details == > > Series: series starting with [v2,1/2] drm/i915/guc : Decoupling ADS and logs > from submission > URL : https://patchwork.freedesktop.org/series/35913/ > State : warning > > == Summary == > > Test kms_frontbuffer_tracking: >

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Chris Wilson
Quoting Alexandru Chirvasitu (2018-01-03 14:03:40) > > On Wed, Jan 03, 2018 at 01:47:56PM +, Chris Wilson wrote: > > Quoting Alexandru Chirvasitu (2018-01-03 13:46:42) > > > I've cloned your > > > > > > https://anongit.freedesktop.org/git/drm-tip.git > > > > > > and am now trying to build it

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Chris Wilson
Quoting Alexandru Chirvasitu (2018-01-03 14:48:26) > Here's the log for the make bzImage and modules without ccache. > > I ran it with j8 still because otherwise it would take very long, but > if I run out of options I'll try plain too.. > > In the meantime I'd like to try some other configs; may

[Intel-gfx] [PATCH i-g-t v11] tests/kms_frontbuffer_tracking: Including DRRS test coverage

2018-01-03 Thread Lohith BS
Dynamic Refresh Rate Switch(DRRS) is used to switch the panel's refresh rate to the lowest vrefresh supported by panel, when frame is not flipped for more than a Sec. In kernel, DRRS uses the front buffer tracking infrastructure. Hence DRRS test coverage is added along with other frontbuffer track

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2018-01-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday, December 19, 2017 10:15:07 AM Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev6)

2018-01-03 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev6) URL : https://patchwork.freedesktop.org/series/32888/ State : success == Summary == IGT patchset tested on top of latest successful build 58bd37d347d1369ecd272ff778057ee8004d6b15 kms_atomic_transition: R

Re: [Intel-gfx] [PATCH i-g-t v10] tests/kms_frontbuffer_tracking: Including DRRS test coverage

2018-01-03 Thread Bs, Lohith
Hi Rodrigo, Thank you for your valuable comments, the same has been addressed and a new patch had been pushed with the changes. Request you to have a look at the new patch-set[v11] and provide your comments if any. On 1/3/2018 2:04 AM, Rodrigo Vivi wrote: On Mon, Jan 01, 2018 at 01:45:32P

Re: [Intel-gfx] [PATCH] drm/i915: Assert we do not try to wait on an invalid seqno

2018-01-03 Thread Michał Winiarski
On Tue, Jan 02, 2018 at 07:25:00PM +, Chris Wilson wrote: > We should never insert the invalid seqno into the wait tree, so assert > we do not. > > Signed-off-by: Chris Wilson Reviewed-by: Michał Winiarski -Michał > --- > drivers/gpu/drm/i915/intel_breadcrumbs.c | 2 ++ > 1 file changed,

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Alexandru Chirvasitu
Thank you for that! I'd been getting used to seeing warnings to that effect, so got complacent and stopped checking for errors.. In any case, it's now compiled and installed, and I will report back with any new logs if / when another hang occurs. On Wed, Jan 03, 2018 at 02:53:45PM +, Chris W

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] igt/gem_busy: Remove repeated use of igt_spin_batch_new

2018-01-03 Thread Patchwork
== Series Details == Series: series starting with [1/2] igt/gem_busy: Remove repeated use of igt_spin_batch_new URL : https://patchwork.freedesktop.org/series/35942/ State : warning == Summary == Test kms_flip: Subgroup blt-wf_vblank-vs-modeset-interruptible: pass

[Intel-gfx] [PATCH igt] igt/perf_pmu: Skip GEM checks for repeated spin_batch allocations

2018-01-03 Thread Chris Wilson
Each call to igt_spin_batch_new_fence will do a stalling check to verify that GEM is functional before submitting the spinning batch. In a loop, this means that we may end up waiting for our earlier spinning batches... Signed-off-by: Chris Wilson --- tests/perf_pmu.c | 3 ++- 1 file changed, 2 i

Re: [Intel-gfx] [PATCH] drm/i915: Assert we do not try to wait on an invalid seqno

2018-01-03 Thread Chris Wilson
Quoting Michał Winiarski (2018-01-03 16:29:18) > On Tue, Jan 02, 2018 at 07:25:00PM +, Chris Wilson wrote: > > We should never insert the invalid seqno into the wait tree, so assert > > we do not. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Michał Winiarski Ta, and pushed. -Chris

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/perf_pmu: Skip GEM checks for repeated spin_batch allocations

2018-01-03 Thread Patchwork
== Series Details == Series: igt/perf_pmu: Skip GEM checks for repeated spin_batch allocations URL : https://patchwork.freedesktop.org/series/35949/ State : success == Summary == IGT patchset tested on top of latest successful build 58bd37d347d1369ecd272ff778057ee8004d6b15 kms_atomic_transitio

[Intel-gfx] [PATCH igt] igt/kms_flip: Do igt_require_gem() just once

2018-01-03 Thread Chris Wilson
Since igt_spin_batch_new() will do a stalling GEM check, it is not advisable to use it within loops. Perform the igt_require_gem() upfront and then use __igt_spin_batch_new() inside the test loop. Signed-off-by: Chris Wilson --- tests/kms_flip.c | 11 +++ 1 file changed, 7 insertions(+),

Re: [Intel-gfx] [PATCH] drm/i915: Grab power domain in skl_pipe_wm_get_hw_state()

2018-01-03 Thread Pandiyan, Dhinakaran
On Tue, 2018-01-02 at 18:33 +, Pandiyan, Dhinakaran wrote: > On Tue, 2017-12-19 at 13:16 +0100, Maarten Lankhorst wrote: > > This should get rid of unclaimed register debug warnings, if > > it still happens we should put this in a intel_crtc->active check.. > > > > Bugzilla: https://bugs.freed

[Intel-gfx] [PATCH igt 4/4] lib/gem: Reset the global seqno at the start of each test

2018-01-03 Thread Chris Wilson
When we require GEM, reset the global seqno. This gives each test a clean slate to work with, and avoids left-over state from previous tests impacting on the next. In particular, somes tests may be setting up long sequence of stalling batches not expecting to hit a seqno wraparound (leftover from,

[Intel-gfx] [PATCH igt 1/4] igt/gem_busy: Remove repeated use of igt_spin_batch_new

2018-01-03 Thread Chris Wilson
igt_spin_batch_new() includes a throttling check that GEM works, which breaks trying to create multiple spin batches, use __igt_spin_batch_new() instead, after verifying GEM works. Signed-off-by: Chris Wilson --- tests/gem_busy.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Intel-gfx] [PATCH igt 2/4] igt/perf_pmu: Skip GEM checks for repeated spin_batch allocations

2018-01-03 Thread Chris Wilson
Each call to igt_spin_batch_new_fence will do a stalling check to verify that GEM is functional before submitting the spinning batch. In a loop, this means that we may end up waiting for our earlier spinning batches... Signed-off-by: Chris Wilson --- tests/perf_pmu.c | 3 ++- 1 file changed, 2 i

[Intel-gfx] [PATCH igt 3/4] igt/kms_flip: Do igt_require_gem() just once

2018-01-03 Thread Chris Wilson
Since igt_spin_batch_new() will do a stalling GEM check, it is not advisable to use it within loops. Perform the igt_require_gem() upfront and then use __igt_spin_batch_new() inside the test loop. Signed-off-by: Chris Wilson --- tests/kms_flip.c | 11 +++ 1 file changed, 7 insertions(+),

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-03 Thread Yaodong Li
You are thinking of plugging into intel_pstate to make it smarter for ia freq transitions? Yep. This seems a correct step to give some automatic support instead of parameter/hardcoded multiplier. Does this mean we should use cpufreq/intel_pstate based approach instead of the current modpara

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_flip: Do igt_require_gem() just once

2018-01-03 Thread Patchwork
== Series Details == Series: igt/kms_flip: Do igt_require_gem() just once URL : https://patchwork.freedesktop.org/series/35950/ State : success == Summary == IGT patchset tested on top of latest successful build 58bd37d347d1369ecd272ff778057ee8004d6b15 kms_atomic_transition: Remove skip_on_un

[Intel-gfx] ✗ Fi.CI.IGT: failure for tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev6)

2018-01-03 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev6) URL : https://patchwork.freedesktop.org/series/32888/ State : failure == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-rgb101010-draw-mmap-gtt: pass -> FAIL (

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] igt/gem_busy: Remove repeated use of igt_spin_batch_new

2018-01-03 Thread Patchwork
== Series Details == Series: series starting with [1/4] igt/gem_busy: Remove repeated use of igt_spin_batch_new URL : https://patchwork.freedesktop.org/series/35951/ State : success == Summary == IGT patchset tested on top of latest successful build 58bd37d347d1369ecd272ff778057ee8004d6b15 km

[Intel-gfx] ✗ Fi.CI.IGT: warning for igt/perf_pmu: Skip GEM checks for repeated spin_batch allocations

2018-01-03 Thread Patchwork
== Series Details == Series: igt/perf_pmu: Skip GEM checks for repeated spin_batch allocations URL : https://patchwork.freedesktop.org/series/35949/ State : warning == Summary == Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-blt: fail -> P

[Intel-gfx] [PATCH] drm/i915/glk: Disable Guc and HuC on GLK

2018-01-03 Thread Anusha Srivatsa
Since the firmwares are not yet released to public repo, disable them on Geminilake. v2: Remove the firmware versions (Michal) v3: Remove unwanted defines (Rodrigo) Correct commit message (Michal) Cc: Michal Wajdeczko Cc: Rodrigo Vivi Cc: Signed-off-by: Anusha Srivatsa Fixes: 90f192c8241e ("

[Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-01-03 Thread Gaurav K Singh
From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD audio controller link was going out of sync for which there was a fix in i915 driver but was not getting invoked f

Re: [Intel-gfx] [PATCH i-g-t v11] tests/kms_frontbuffer_tracking: Including DRRS test coverage

2018-01-03 Thread Rodrigo Vivi
On Wed, Jan 03, 2018 at 03:02:07PM +, Lohith BS wrote: > Dynamic Refresh Rate Switch(DRRS) is used to switch the panel's > refresh rate to the lowest vrefresh supported by panel, when frame is > not flipped for more than a Sec. > > In kernel, DRRS uses the front buffer tracking infrastructure.

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/glk: Disable Guc and HuC on GLK (rev4)

2018-01-03 Thread Patchwork
== Series Details == Series: drm/i915/glk: Disable Guc and HuC on GLK (rev4) URL : https://patchwork.freedesktop.org/series/35381/ State : warning == Summary == Series 35381v4 drm/i915/glk: Disable Guc and HuC on GLK https://patchwork.freedesktop.org/api/1.0/series/35381/revisions/4/mbox/ Tes

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: i915: Fix audio issue on BXT

2018-01-03 Thread Patchwork
== Series Details == Series: drm: i915: Fix audio issue on BXT URL : https://patchwork.freedesktop.org/series/35955/ State : success == Summary == Series 35955v1 drm: i915: Fix audio issue on BXT https://patchwork.freedesktop.org/api/1.0/series/35955/revisions/1/mbox/ Test debugfs_test:

[Intel-gfx] ✗ Fi.CI.IGT: warning for igt/kms_flip: Do igt_require_gem() just once

2018-01-03 Thread Patchwork
== Series Details == Series: igt/kms_flip: Do igt_require_gem() just once URL : https://patchwork.freedesktop.org/series/35950/ State : warning == Summary == Warning: bzip CI_DRM_3595/shard-glkb2/results3.json.bz2 wasn't in correct JSON format Test kms_frontbuffer_tracking: Subgroup f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Disable Guc and HuC on GLK (rev4)

2018-01-03 Thread Patchwork
== Series Details == Series: drm/i915/glk: Disable Guc and HuC on GLK (rev4) URL : https://patchwork.freedesktop.org/series/35381/ State : success == Summary == Series 35381v4 drm/i915/glk: Disable Guc and HuC on GLK https://patchwork.freedesktop.org/api/1.0/series/35381/revisions/4/mbox/ Tes

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-01-03 Thread Pandiyan, Dhinakaran
On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > From: Gaurav Singh > > On Apollolake, with stress test warm reboot, audio card > was not getting enumerated after reboot. This was a The problem looks similar to https://lists.freedesktop.org/archives/intel-gfx/2017-October/144495.html

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] igt/gem_busy: Remove repeated use of igt_spin_batch_new

2018-01-03 Thread Patchwork
== Series Details == Series: series starting with [1/4] igt/gem_busy: Remove repeated use of igt_spin_batch_new URL : https://patchwork.freedesktop.org/series/35951/ State : success == Summary == Warning: bzip CI_DRM_3595/shard-glkb2/results3.json.bz2 wasn't in correct JSON format Test gem_t

[Intel-gfx] [PATCH 1/5] drm/vblank: Do not update vblank counts if vblanks are already disabled.

2018-01-03 Thread Dhinakaran Pandiyan
Updating the vblank counts requires register reads and these reads may not return meaningful values after the vblank interrupts are disabled as the device may go to low power state. An additional change would be to allow the driver to save the vblank counts before entering a low power state, but th

[Intel-gfx] [PATCH 4/5] drm/i915: Introduce a non-blocking power domain for vblank interrupts

2018-01-03 Thread Dhinakaran Pandiyan
When DC states are enabled and PSR is active, the hardware enters DC5/DC6 states resulting in the frame counter resetting. The frame counter reset mess up the vblank counting logic as the diff between the new frame counter value and the previous is negative, and this negative diff gets applied as a

[Intel-gfx] [PATCH 5/5] drm/i915: Use the vblank power domain disallow or disable DC states.

2018-01-03 Thread Dhinakaran Pandiyan
Disable DC states before enabling vblank interrupts and conversely enable DC states after disabling. Since the frame counter may have got reset between disabling and enabling, use drm_crtc_vblank_restore() to compute the missed vblanks. Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Rodrigo Vivi Signe

[Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-03 Thread Dhinakaran Pandiyan
Since we want to allow for a non-blocking power domain for vblanks, the power domain use count and power well use count will not be updated atomically inside the power domain mutex (see next patch). This affects verifying if sum(power_domain_use_count) == power_well_use_count at init time. So do no

[Intel-gfx] [PATCH 2/5] drm/vblank: Restoring vblank counts after device runtime PM events.

2018-01-03 Thread Dhinakaran Pandiyan
The HW frame counter can get reset when devices enters low power states and this messes up any following vblank count updates. So, compute the missed vblank interrupts for that low power state duration using time stamps. This is similar to _crtc_vblank_on() except that it doesn't enable vblank inte

Re: [Intel-gfx] [PATCH 1/5] drm/vblank: Do not update vblank counts if vblanks are already disabled.

2018-01-03 Thread Chris Wilson
Quoting Dhinakaran Pandiyan (2018-01-03 20:39:57) > Updating the vblank counts requires register reads and these reads may not > return meaningful values after the vblank interrupts are disabled as the > device may go to low power state. An additional change would be to allow > the driver to save t

Re: [Intel-gfx] [PATCH 2/5] drm/vblank: Restoring vblank counts after device runtime PM events.

2018-01-03 Thread Chris Wilson
Quoting Dhinakaran Pandiyan (2018-01-03 20:39:58) > The HW frame counter can get reset when devices enters low power > states and this messes up any following vblank count updates. So, compute > the missed vblank interrupts for that low power state duration using time > stamps. This is similar to _

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-03 Thread Chris Wilson
Quoting Dhinakaran Pandiyan (2018-01-03 20:39:59) > Since we want to allow for a non-blocking power domain for vblanks, > the power domain use count and power well use count will not be updated > atomically inside the power domain mutex (see next patch). This affects > verifying if sum(power_domain

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/vblank: Do not update vblank counts if vblanks are already disabled.

2018-01-03 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/vblank: Do not update vblank counts if vblanks are already disabled. URL : https://patchwork.freedesktop.org/series/35959/ State : success == Summary == Series 35959v1 series starting with [1/5] drm/vblank: Do not update vblank coun

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-01-03 Thread Rodrigo Vivi
On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: > > On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: > > From: Gaurav Singh > > > > On Apollolake, with stress test warm reboot, audio card > > was not getting enumerated after reboot. This was a > > The problem looks

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: i915: Fix audio issue on BXT

2018-01-03 Thread Patchwork
== Series Details == Series: drm: i915: Fix audio issue on BXT URL : https://patchwork.freedesktop.org/series/35955/ State : success == Summary == Warning: bzip CI_DRM_3595/shard-glkb2/results3.json.bz2 wasn't in correct JSON format Test kms_frontbuffer_tracking: Subgroup fbc-1p-offsc

[Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake

2018-01-03 Thread Anusha Srivatsa
There is a new version of DMC available for CNL. The release notes mentions: 1. Fix for the issue where DC_STATE was getting enabled even when disabled by driver causing data corruption v2: Since the firmware is merged to linux-firmware.git, add MODUE_FIRMWARE. Cc: Rodrigo Vivi Signed-off-by:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: DMC 1.07 for Cannonlake (rev3)

2018-01-03 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.07 for Cannonlake (rev3) URL : https://patchwork.freedesktop.org/series/35651/ State : failure == Summary == Applying: drm/i915/dmc: DMC 1.07 for Cannonlake error: sha1 information is lacking or useless (drivers/gpu/drm/i915/intel_csr.c). error

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/glk: Disable Guc and HuC on GLK (rev4)

2018-01-03 Thread Patchwork
== Series Details == Series: drm/i915/glk: Disable Guc and HuC on GLK (rev4) URL : https://patchwork.freedesktop.org/series/35381/ State : failure == Summary == Warning: bzip CI_DRM_3595/shard-glkb2/results3.json.bz2 wasn't in correct JSON format Test gem_tiled_swapping: Subgroup non-

[Intel-gfx] [PATCH 1/3] drm/i915/psr: Kill psr.source_ok flag.

2018-01-03 Thread Dhinakaran Pandiyan
This flag has become redundant since commit 4d90f2d507ab ("drm/i915: Start tracking PSR state in crtc state") It is set at the same place as psr.enabled, which is also exposed via debugfs. Cc: Rodrigo Vivi Cc: Ville Syrjälä Signed-off-by: Dhinakaran Pandiyan Acked-by: Rodrigo Vivi --- drivers

[Intel-gfx] [PATCH 2/3] drm/i915/psr: CAN_PSR() macro to check for PSR source and sink support.

2018-01-03 Thread Dhinakaran Pandiyan
The global variable dev_priv->psr.sink_support is set if an eDP sink supports PSR. Use this instead of redoing the check with is_edp_psr(). Combine source and sink support checks into a macro that can be used to return early from psr_{invalidate, single_frame_update, flush}. Cc: Rodrigo Vivi Sign

[Intel-gfx] [PATCH 3/3] drm/i915/psr: Avoid initializing PSR if there is no sink support.

2018-01-03 Thread Dhinakaran Pandiyan
DPCD read for the eDP is complete by the time intel_psr_init() is called, which means we can avoid initializing PSR structures and state if there is no sink support. Cc: Rodrigo Vivi Cc: Ville Syrjälä Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_debugfs.c | 7 ++- drive

Re: [Intel-gfx] PROBLEM: i915 causes complete desktop freezes in 4.15-rc5

2018-01-03 Thread Alexandru Chirvasitu
All right, here's the dmesg from the kernel compiled from drm-tip (in sync with upstream at the time of the compilation earlier today), with CONFIG_DRM_I915_DEBUG_GEM=y I crashed it by opening 20+ xterm windows. Doesn't always do it though (tried this before). On Wed, Jan 03, 2018 at 11:31:31AM

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/psr: Kill psr.source_ok flag.

2018-01-03 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/psr: Kill psr.source_ok flag. URL : https://patchwork.freedesktop.org/series/35965/ State : success == Summary == Series 35965v1 series starting with [1/3] drm/i915/psr: Kill psr.source_ok flag. https://patchwork.freedesktop.org/

Re: [Intel-gfx] [PATCH v2 3/8] drm/i915/psr: Avoid initializing PSR if there is no sink support.

2018-01-03 Thread Rodrigo Vivi
first of all sorry for not getting back sooner on this... On Tue, Dec 19, 2017 at 09:40:01PM +, Pandiyan, Dhinakaran wrote: > > > > On Tue, 2017-12-19 at 13:29 -0800, Rodrigo Vivi wrote: > > On Tue, Dec 19, 2017 at 05:26:54AM +, Dhinakaran Pandiyan wrote: > > > DPCD read for the eDP is

Re: [Intel-gfx] [PATCH i-g-t v11] tests/kms_frontbuffer_tracking: Including DRRS test coverage

2018-01-03 Thread Ramalingam C
On Thursday 04 January 2018 12:51 AM, Rodrigo Vivi wrote: On Wed, Jan 03, 2018 at 03:02:07PM +, Lohith BS wrote: Dynamic Refresh Rate Switch(DRRS) is used to switch the panel's refresh rate to the lowest vrefresh supported by panel, when frame is not flipped for more than a Sec. In kernel

Re: [Intel-gfx] [PATCH v2 3/8] drm/i915/psr: Avoid initializing PSR if there is no sink support.

2018-01-03 Thread Pandiyan, Dhinakaran
On Wed, 2018-01-03 at 13:59 -0800, Rodrigo Vivi wrote: > first of all sorry for not getting back sooner on this... > > On Tue, Dec 19, 2017 at 09:40:01PM +, Pandiyan, Dhinakaran wrote: > > > > > > > > On Tue, 2017-12-19 at 13:29 -0800, Rodrigo Vivi wrote: > > > On Tue, Dec 19, 2017 at 05

[Intel-gfx] [RFC v2 4/8] drm/fb-helper: Ensure driver module is pinned in fb_open()

2018-01-03 Thread Noralf Trønnes
If struct fb_ops is defined in a library like cma, fb_open() and fbcon takes a ref on the library instead of the driver module. Use fb_ops.fb_open/fb_release to ensure that the driver module is pinned. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 40 +++

[Intel-gfx] [RFC v2 3/8] drm: Export some ioctl functions

2018-01-03 Thread Noralf Trønnes
Export the following functions so in-kernel users can allocate dumb buffers: - drm_file_alloc - drm_file_free - drm_prime_handle_to_fd_ioctl - drm_mode_addfb2 - drm_mode_create_dumb_ioctl - drm_dropmaster_ioctl Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_auth.c | 1 + drivers

[Intel-gfx] [RFC v2 7/8] drm/fb-helper: Add generic fbdev emulation

2018-01-03 Thread Noralf Trønnes
Add generic fbdev emulation which uses a drm_file to get a dumb_buffer and drm_framebuffer. The buffer is exported and vmap/mmap called on the dma-buf. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 301 +++- include/drm/drm_fb_helper.h

[Intel-gfx] [RFC v2 8/8] drm/vc4: Test generic fbdev emulation

2018-01-03 Thread Noralf Trønnes
Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/vc4/vc4_drv.c | 3 --- drivers/gpu/drm/vc4/vc4_kms.c | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index ceb385fd69c5..ef8a2d3a6d1f 100644 --- a/drivers/gpu/drm

[Intel-gfx] [RFC v2 1/8] drm: provide management functions for drm_file

2018-01-03 Thread Noralf Trønnes
From: David Herrmann Rather than doing drm_file allocation/destruction right in the fops, lets provide separate helpers. This decouples drm_file management from the still-mandatory drm-fops. It prepares for use of drm_file without the fops, both by possible separate fops implementations and APIs

[Intel-gfx] [RFC v2 5/8] drm/fb-helper: Don't restore if fbdev is not in use

2018-01-03 Thread Noralf Trønnes
Keep track of fbdev users and only restore fbdev in drm_fb_helper_restore_fbdev_mode_unlocked() when in use. This avoids fbdev being restored in drm_driver.last_close when nothing uses it. Additionally fbdev is turned off when the last user is closing. fbcon is a user in this context. Signed-off-b

[Intel-gfx] [RFC v2 2/8] drm/ioctl: Remove trailing whitespace

2018-01-03 Thread Noralf Trønnes
Remove a couple of trailing spaces. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 4aafe4802099..b1e96fb68ea8 100644 --- a/drivers/gpu/drm/drm_io

[Intel-gfx] [RFC v2 0/8] drm: Add generic fbdev emulation

2018-01-03 Thread Noralf Trønnes
This patchset explores the possibility of having generic fbdev emulation in DRM for drivers that supports dumb buffers which they can export. Chris pointed out a bug in the previous version. I've solved this by deferring buffer creation until fb_ops->fb_open. This works fine for fbcon as well, sin

[Intel-gfx] [RFC v2 6/8] drm: Handle fbdev emulation in core

2018-01-03 Thread Noralf Trønnes
Prepare for generic fbdev emulation by letting DRM core work directly with the fbdev compatibility layer. This is done by adding new fbdev helper vtable callbacks for restore, hotplug_event, unregister and release. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_file.c | 12 +++

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add generic fbdev emulation (rev2)

2018-01-03 Thread Patchwork
== Series Details == Series: drm: Add generic fbdev emulation (rev2) URL : https://patchwork.freedesktop.org/series/35873/ State : success == Summary == Series 35873v2 drm: Add generic fbdev emulation https://patchwork.freedesktop.org/api/1.0/series/35873/revisions/2/mbox/ Test debugfs_test:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/psr: Kill psr.source_ok flag.

2018-01-03 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/psr: Kill psr.source_ok flag. URL : https://patchwork.freedesktop.org/series/35965/ State : success == Summary == Warning: bzip CI_DRM_3595/shard-glkb2/results3.json.bz2 wasn't in correct JSON format Test gem_eio: Subgro

[Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake

2018-01-03 Thread Anusha Srivatsa
There is a new version of DMC available for CNL. The release notes mentions: 1. Fix for the issue where DC_STATE was getting enabled even when disabled by driver causing data corruption v2: Since the firmware is merged to linux-firmware.git, add MODUE_FIRMWARE. Cc: Rodrigo Vivi Signed-off-by:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: DMC 1.07 for Cannonlake (rev4)

2018-01-03 Thread Patchwork
== Series Details == Series: drm/i915/dmc: DMC 1.07 for Cannonlake (rev4) URL : https://patchwork.freedesktop.org/series/35651/ State : failure == Summary == Applying: drm/i915/dmc: DMC 1.07 for Cannonlake error: sha1 information is lacking or useless (drivers/gpu/drm/i915/intel_csr.c). error

Re: [Intel-gfx] [RFC] drm/i915: Add a new modparam for customized ring multiplier

2018-01-03 Thread Sagar Arun Kamble
Since ring frequency programming needs consideration of both IA and GT frequency requests I think keeping the logic to program the ring frequency table in driver that monitors both IA/GT busyness and power budgets like intel_ips will be more appropriate. intel_ips is relying on global load derive

Re: [Intel-gfx] FW: [PATCH] drm: i915: Fix audio issue on BXT

2018-01-03 Thread Sharma, Shashank
Regards Shashank On 1/4/2018 11:40 AM, Sharma, Shashank wrote: On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerate

[Intel-gfx] Review https://patchwork.freedesktop.org/patch/160274/

2018-01-03 Thread Mustaffa, Mustamin B
Hi all, Please help to review a patch https://patchwork.freedesktop.org/patch/160274/ Best regard Mustamin ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannonlake

2018-01-03 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Anusha Srivatsa > Sent: keskiviikko 3. tammikuuta 2018 23.22 > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo > Subject: [Intel-gfx] [PATCH] drm/i915/dmc: DMC 1.07 for Cannon