[Intel-gfx] ✓ Fi.CI.BAT: success for CNL port refactoring

2018-02-15 Thread Patchwork
== Series Details == Series: CNL port refactoring URL : https://patchwork.freedesktop.org/series/38334/ State : success == Summary == Series 38334v1 CNL port refactoring https://patchwork.freedesktop.org/api/1.0/series/38334/revisions/1/mbox/ Test debugfs_test: Subgroup read_all_entri

Re: [Intel-gfx] [RFC i-g-t 1/3] intel-gpu-top: Rename to intel-legacy-top

2018-02-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-02-15 09:57:45) > > On 15/02/2018 09:10, Petri Latvala wrote: > > On Wed, Feb 14, 2018 at 06:52:05PM +, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> Signed-off-by: Tvrtko Ursulin > >> --- > >> tools/.gitignore | 2 +- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for CNL port refactoring

2018-02-15 Thread Patchwork
== Series Details == Series: CNL port refactoring URL : https://patchwork.freedesktop.org/series/38334/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7464b147c8e2 drm/i915/cnl: Fix PORT_TX_DW5/7 register address 55e9964aae48 drm/i915/cnl; Add macro to get PORT_TX register -:37:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Avoid escaping check_digital_port_conflicts() with locks held

2018-02-15 Thread Patchwork
== Series Details == Series: drm/i915: Avoid escaping check_digital_port_conflicts() with locks held URL : https://patchwork.freedesktop.org/series/38331/ State : success == Summary == Series 38331v1 drm/i915: Avoid escaping check_digital_port_conflicts() with locks held https://patchwork.fre

Re: [Intel-gfx] [RFC i-g-t 1/3] intel-gpu-top: Rename to intel-legacy-top

2018-02-15 Thread Tvrtko Ursulin
On 15/02/2018 09:10, Petri Latvala wrote: On Wed, Feb 14, 2018 at 06:52:05PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- tools/.gitignore | 2 +- tools/Makefile.sources| 2 +- tools/{intel_gpu_to

[Intel-gfx] [PATCH 0/3] CNL port refactoring

2018-02-15 Thread Mahesh Kumar
This series fixes CNL PORT_TX_DW5/7_LNO_D register address. This series also introduces macros to get register address of CNL_PORT_TX registers instead of defining for each DW instance. Mahesh Kumar (3): drm/i915/cnl: Fix PORT_TX_DW5/7 register address drm/i915/cnl; Add macro to get PORT_TX re

[Intel-gfx] [PATCH 2/3] drm/i915/cnl; Add macro to get PORT_TX register

2018-02-15 Thread Mahesh Kumar
This patch creates a new macro to get PORT_TX register for any given DW. This will remove the need of defining register address for each port & DW. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h | 28 1 file changed, 28 insertions(+) diff --git a/dr

[Intel-gfx] [PATCH 1/3] drm/i915/cnl: Fix PORT_TX_DW5/7 register address

2018-02-15 Thread Mahesh Kumar
Register Address for CNL_PORT_DW5_LN0_D is 0x162E54, but current code is defining it as 0x162ED4. Similarly for CNL_PORT_DW7_LN0_D register address is defined 0x162EDC instead of 0x162E5C, fix it. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2 inserti

[Intel-gfx] [PATCH 3/3] drm/i915/cnl: Replace PORT_TX register macros with new ones

2018-02-15 Thread Mahesh Kumar
This patch replaces CNL_PORT_TX register macros with new macros defined in previous patch. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h | 107 +--- 1 file changed, 11 insertions(+), 96 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg

Re: [Intel-gfx] [RFC 0/5] Per-client engine stats

2018-02-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-02-15 09:44:58) > > On 14/02/2018 19:20, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-02-14 18:50:30) > >> From: Tvrtko Ursulin > >> > >> Another re-post of my earlier, now slightly updated work, to expose a DRM > >> client > >> hierarchy in sysfs in order to

Re: [Intel-gfx] [RFC 0/5] Per-client engine stats

2018-02-15 Thread Tvrtko Ursulin
On 14/02/2018 19:20, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-02-14 18:50:30) From: Tvrtko Ursulin Another re-post of my earlier, now slightly updated work, to expose a DRM client hierarchy in sysfs in order to enable a top like tool: So what I don't like about it is that it is a ne

Re: [Intel-gfx] [RFC 4/5] drm/i915: Expose per-engine client busyness

2018-02-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-02-15 09:41:53) > > On 14/02/2018 19:17, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-02-14 18:50:34) > >> From: Tvrtko Ursulin > >> > >> Expose per-client and per-engine busyness under the previously added sysfs > >> client root. > >> > >> The new files are o

Re: [Intel-gfx] [RFC 4/5] drm/i915: Expose per-engine client busyness

2018-02-15 Thread Tvrtko Ursulin
On 14/02/2018 19:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-02-14 18:50:34) From: Tvrtko Ursulin Expose per-client and per-engine busyness under the previously added sysfs client root. The new files are one per-engine instance and located under the 'busy' directory. Each contains

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Release connector iterator on a digital port conflict.

2018-02-15 Thread Patchwork
== Series Details == Series: drm/i915: Release connector iterator on a digital port conflict. URL : https://patchwork.freedesktop.org/series/38330/ State : failure == Summary == Series 38330v1 drm/i915: Release connector iterator on a digital port conflict. https://patchwork.freedesktop.org/ap

Re: [Intel-gfx] [RFC 2/5] drm/i915: Expose list of clients in sysfs

2018-02-15 Thread Tvrtko Ursulin
On 14/02/2018 19:13, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-02-14 18:50:32) From: Tvrtko Ursulin Expose a list of clients with open file handles in sysfs. This will be a basis for a top-like utility showing per-client and per- engine GPU load. Currently we only expose each client'

Re: [Intel-gfx] [RFC 1/5] drm/i915: Track per-context engine busyness

2018-02-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-02-15 09:29:57) > > On 14/02/2018 19:07, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-02-14 18:50:31) > >> +ktime_t intel_context_engine_get_busy_time(struct i915_gem_context *ctx, > >> + struct intel_engine_cs *engine)

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/cnl: Remove alpha_support protection (rev2)

2018-02-15 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Remove alpha_support protection (rev2) URL : https://patchwork.freedesktop.org/series/38264/ State : failure == Summary == Test perf: Subgroup buffer-fill: fail -> PASS (shard-apl) fdo#103755 Test kms_rotation_crc:

Re: [Intel-gfx] [RFC 1/5] drm/i915: Track per-context engine busyness

2018-02-15 Thread Tvrtko Ursulin
On 14/02/2018 19:07, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-02-14 18:50:31) +ktime_t intel_context_engine_get_busy_time(struct i915_gem_context *ctx, + struct intel_engine_cs *engine) +{ + struct intel_context *ce = &ctx->engine[engine->i

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Set scaler mode for NV12

2018-02-15 Thread Srinivas, Vidya
I addressed it with PS_SCALER_MODE_PLANAR (1 << 29) to keep it generic. But as you mentioned that wouldn't be the right way. I need to keep GEN9 and GEN10+ separate. Will fix it in the next push. Thank you. Vidya From: Sharma, Shashank Sent: Thursday, February 15, 2018 12:03 PM To: Srinivas

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Update format_is_yuv() to include NV12

2018-02-15 Thread Srinivas, Vidya
Sorry about this. Will fix it in the next push. Thanks. Vidya > -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 15, 2018 12:05 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com; Kamath, Sunil > ; Shankar, Uma ; >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Release connector iterator on a digital port conflict.

2018-02-15 Thread Patchwork
== Series Details == Series: drm/i915: Release connector iterator on a digital port conflict. URL : https://patchwork.freedesktop.org/series/38330/ State : warning == Summary == $ dim checkpatch origin/drm-tip fc1e8ae4c756 drm/i915: Release connector iterator on a digital port conflict. -:13:

Re: [Intel-gfx] [PATCH] drm/i915: Release connector iterator on a digital port conflict.

2018-02-15 Thread Chris Wilson
Quoting Maarten Lankhorst (2018-02-15 09:14:25) > <4>[ 30.702366] > <4>[ 30.702383] WARNING: lock held when returning to user space! > <4>[ 30.702404] 4.16.0-rc1-CI-kasan_1+ #1 Tainted: GW > <4>[ 30.702422] ---

Re: [Intel-gfx] [PATCH 15/16] drm/i915: Add NV12 support to intel_framebuffer_init

2018-02-15 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 2/14/2018 10:27 AM, Vidya Srinivas wrote: From: Chandra Konduru This patch adds NV12 as supported format to intel_framebuffer_init and performs various checks. v2: -Fix an issue in checks added (Chandra Konduru) v3: rebased (me) v4: Review c

Re: [Intel-gfx] [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

2018-02-15 Thread Chris Wilson
Quoting Chris Wilson (2018-02-11 18:54:33) > Signed-off-by: Chris Wilson Poke, CI is still tripping over this... > --- > tests/kms_frontbuffer_tracking.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/kms_frontbuffer_tracking.c > b/tests/kms_frontbuffer_tracking.c > index 6

Re: [Intel-gfx] [PATCH 14/16] drm/i915: Add NV12 as supported format for sprite plane

2018-02-15 Thread Srinivas, Vidya
> -Original Message- > From: Sharma, Shashank > Sent: Thursday, February 15, 2018 2:24 PM > To: Srinivas, Vidya ; intel- > g...@lists.freedesktop.org > Cc: maarten.lankho...@linux.intel.com; Kamath, Sunil > ; Shankar, Uma ; > Konduru, Chandra ; Maiti, Nabendu Bikash > > Subject: Re: [PAT

[Intel-gfx] [PATCH] drm/i915: Avoid escaping check_digital_port_conflicts() with locks held

2018-02-15 Thread Chris Wilson
Hitting the failure path through check_digital_port_conflicts triggers: WARNING: lock held when returning to user space! 4.16.0-rc1-CI-kasan_1+ #1 Tainted: GW kms_3d/1439 i

Re: [Intel-gfx] [RFC i-g-t 1/3] intel-gpu-top: Rename to intel-legacy-top

2018-02-15 Thread Chris Wilson
Quoting Petri Latvala (2018-02-15 09:10:45) > On Wed, Feb 14, 2018 at 06:52:05PM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Signed-off-by: Tvrtko Ursulin > > --- > > tools/.gitignore | 2 +- > > tools/Makefile.sources| 2 +-

[Intel-gfx] [PATCH] drm/i915: Release connector iterator on a digital port conflict.

2018-02-15 Thread Maarten Lankhorst
<4>[ 30.702366] <4>[ 30.702383] WARNING: lock held when returning to user space! <4>[ 30.702404] 4.16.0-rc1-CI-kasan_1+ #1 Tainted: GW <4>[ 30.702422] <4>[ 30.702440] kms_3d/1439 is l

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix inconsistent IS_ERR and PTR_ERR

2018-02-15 Thread Jani Nikula
On Wed, 14 Feb 2018, "Gustavo A. R. Silva" wrote: > Fix inconsistent IS_ERR and PTR_ERR in shrink_boom. > The proper pointer to use is _explode_ instead of _purge_. > > This issue was detected with the help of Coccinelle. > > Fixes: fe215c8bc426 ("drm/i915/selftests: add missing gtt shrinker test"

Re: [Intel-gfx] [RFC i-g-t 1/3] intel-gpu-top: Rename to intel-legacy-top

2018-02-15 Thread Petri Latvala
On Wed, Feb 14, 2018 at 06:52:05PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Signed-off-by: Tvrtko Ursulin > --- > tools/.gitignore | 2 +- > tools/Makefile.sources| 2 +- > tools/{intel_gpu_top.c => intel_legacy_top.c} | 0 > t

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Store gen_mask inside the static device info

2018-02-15 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Store gen_mask inside the static device info URL : https://patchwork.freedesktop.org/series/38317/ State : success == Summary == Series 38317v1 series starting with [v2,1/3] drm/i915: Store gen_mask inside the static device

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Track GT interrupt handling using the master iir

2018-02-15 Thread Patchwork
== Series Details == Series: drm/i915: Track GT interrupt handling using the master iir URL : https://patchwork.freedesktop.org/series/38297/ State : failure == Summary == Test kms_flip: Subgroup flip-vs-expired-vblank-interruptible: pass -> FAIL (shard-hsw)

Re: [Intel-gfx] [PATCH 14/16] drm/i915: Add NV12 as supported format for sprite plane

2018-02-15 Thread Sharma, Shashank
Regards Shashank On 2/14/2018 10:27 AM, Vidya Srinivas wrote: + if ((INTEL_GEN(dev_priv) == 9 && !IS_GEMINILAKE(dev_priv) && + (plane != 0 || pipe == PIPE_C)) || + ((INTEL_GEN(dev_priv) == 10 || + IS_GEMINILAKE(dev_priv)) && p

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Store gen_mask inside the static device info

2018-02-15 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Store gen_mask inside the static device info URL : https://patchwork.freedesktop.org/series/38317/ State : warning == Summary == $ dim checkpatch origin/drm-tip 85fcbfb0bee2 drm/i915: Store gen_mask inside the static device

[Intel-gfx] [PATCH v2 3/3] drm/i915: Store platform_mask inside the static device info

2018-02-15 Thread Chris Wilson
Rather than deriving the platform_mask from the intel_device_static_info->platform at runtime, pre-fill it in the static data. v2: Undefine macros at end of their scope Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH v2 1/3] drm/i915: Store gen_mask inside the static device info

2018-02-15 Thread Chris Wilson
Rather than deriving the gen_mask from the static intel_device_info->gen at runtime, pre-fill it in the static data. v2: Undefine local macros at end of their scope. Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm/i915/i915_pci

[Intel-gfx] [PATCH v2 2/3] drm/i915: Always define GEN as part of GENx_FEATURES

2018-02-15 Thread Chris Wilson
Be consistent and define the device's GEN as part of the GENx_FEATURE. It will be overridden by the next gen upon inheriting, as per usual. Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_pci.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) di

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Store gen_mask inside the static device info

2018-02-15 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Store gen_mask inside the static device info URL : https://patchwork.freedesktop.org/series/38315/ State : failure == Summary == Applying: drm/i915: Store gen_mask inside the static device info Applying: drm/i915: Always define

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Track GT interrupt handling using the master iir

2018-02-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Track GT interrupt handling using the master iir URL : https://patchwork.freedesktop.org/series/38314/ State : success == Summary == Series 38314v1 series starting with [1/2] drm/i915: Track GT interrupt handling using the mas

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: Remove alpha_support protection (rev2)

2018-02-15 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Remove alpha_support protection (rev2) URL : https://patchwork.freedesktop.org/series/38264/ State : success == Summary == Test kms_flip: Subgroup flip-vs-expired-vblank-interruptible: pass -> FAIL (shard-hsw) fdo#1

[Intel-gfx] [PATCH 1/3] drm/i915: Store gen_mask inside the static device info

2018-02-15 Thread Chris Wilson
Rather than deriving the gen_mask from the static intel_device_info->gen at runtime, pre-fill it in the static data. v2: Undefine local macros at end of their scope. Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm/i915/i915_pci

[Intel-gfx] [PATCH 3/3] drm/i915: Store platform_mask inside the static device info

2018-02-15 Thread Chris Wilson
Rather than deriving the platform_mask from the intel_device_static_info->platform at runtime, pre-fill it in the static data. v2: Undefine macros at end of their scope Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 2 -- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH 2/3] drm/i915: Always define GEN as part of GENx_FEATURES

2018-02-15 Thread Chris Wilson
Be consistent and define the device's GEN as part of the GENx_FEATURE. It will be overridden by the next gen upon inheriting, as per usual. Signed-off-by: Chris Wilson Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_pci.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) di

<    1   2