[Intel-gfx] ✓ Fi.CI.IGT: success for cgroup private data and DRM/i915 integration (rev3)

2018-03-22 Thread Patchwork
== Series Details == Series: cgroup private data and DRM/i915 integration (rev3) URL : https://patchwork.freedesktop.org/series/40142/ State : success == Summary == Known issues: Test kms_flip: Subgroup 2x-flip-vs-expired-vblank: pass -> FAIL (shard-hs

[Intel-gfx] [PATCH 1/4] drm/i915/selftests: Include the trace as a debug aide

2018-03-22 Thread Chris Wilson
If we fail to reset the GPU in a timely fashion, dump the GEM trace so that we can see what operations were in flight when the GPU got stuck. v2: There's more than one timeout that deserves tracing! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 23 ++

[Intel-gfx] [PATCH 4/4] drm/i915: Flush pending interrupt following a GPU reset

2018-03-22 Thread Chris Wilson
After resetting the GPU (or subset of engines), call synchronize_irq() to flush any pending irq before proceeding with the cleanup. For a device level reset, we disable the interupts around the reset, but when resetting just one engine, we have to avoid such global disabling. This leaves us open to

[Intel-gfx] [PATCH 2/4] drm/i915/selftests: Stress resets-vs-request-priority

2018-03-22 Thread Chris Wilson
Watch what happens if we try to reset with a queue of requests with varying priorities -- that may need reordering or preemption across the reset. v2: Tweak priorities to avoid starving the hanging thread. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_hangcheck.c | 189 ++

[Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-22 Thread Chris Wilson
Using engine->irq_posted for execlists, we are not always serialised by the tasklet as we supposed. On the reset paths, the tasklet is disabled and ignored. Instead, we manipulate the engine->irq_posted directly to account for the reset, but if an interrupt fired before the reset and so wrote to en

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/selftests: Include the trace as a debug aide

2018-03-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/selftests: Include the trace as a debug aide URL : https://patchwork.freedesktop.org/series/40439/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6adaf914c971 drm/i915/selftests: Include the trace as a debug aide

[Intel-gfx] [PATCH v2] drm/i915/selftests: Include the trace as a debug aide

2018-03-22 Thread Chris Wilson
If we fail to reset the GPU in a timely fashion, dump the GEM trace so that we can see what operations were in flight when the GPU got stuck. v2: There's more than one timeout that deserves tracing! v3: Silence checkpatch by not even using a product at all! Signed-off-by: Chris Wilson --- drive

Re: [Intel-gfx] [PATCH] drm: Fix uabi regression by allowing garbage mode->type from userspace

2018-03-22 Thread Thomas Hellstrom
On 03/21/2018 10:12 PM, Ville Syrjala wrote: From: Ville Syrjälä Apparently xf86-video-vmware leaves the mode->type uninitialized when feeding the mode to the kernel. Thus we have no choice but to accept the garbage in. We'll just ignore any of the bits we don't want. The mode type is just a hi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/selftests: Include the trace as a debug aide

2018-03-22 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/selftests: Include the trace as a debug aide URL : https://patchwork.freedesktop.org/series/40439/ State : success == Summary == Series 40439v1 series starting with [1/4] drm/i915/selftests: Include the trace as a debug aide ht

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2] drm/i915/selftests: Include the trace as a debug aide (rev2)

2018-03-22 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915/selftests: Include the trace as a debug aide (rev2) URL : https://patchwork.freedesktop.org/series/40439/ State : warning == Summary == $ dim checkpatch origin/drm-tip d4b28d06e3b8 drm/i915/selftests: Include the trace as a debug

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915/selftests: Include the trace as a debug aide (rev2)

2018-03-22 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915/selftests: Include the trace as a debug aide (rev2) URL : https://patchwork.freedesktop.org/series/40439/ State : success == Summary == Series 40439v2 series starting with [v2] drm/i915/selftests: Include the trace as a debug ai

Re: [Intel-gfx] [PATCH 5/5] drm/i915/psr: Timestamps for PSR entry and exit interrupts.

2018-03-22 Thread Ville Syrjälä
On Thu, Mar 22, 2018 at 01:05:24AM +, Pandiyan, Dhinakaran wrote: > On Wed, 2018-03-21 at 21:48 +0200, Ville Syrjälä wrote: > > On Tue, Mar 20, 2018 at 03:41:51PM -0700, Dhinakaran Pandiyan wrote: > > > Timestamps are useful for IGT tests that trigger PSR exit and/or wait for > > > PSR entry. >

Re: [Intel-gfx] [RFC 0/8] Force preemption

2018-03-22 Thread Tvrtko Ursulin
On 21/03/2018 17:26, jeff.mc...@intel.com wrote: From: Jeff McGee Force preemption uses engine reset to enforce a limit on the time that a request targeted for preemption can block. This feature is a requirement in automotive systems where the GPU may be shared by clients of critically high pr

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: prefer INTEL_GEN() over INTEL_INFO()->gen

2018-03-22 Thread Tvrtko Ursulin
On 21/03/2018 14:29, Jani Nikula wrote: Prefer INTEL_GEN() over INTEL_INFO()->gen except in special circumstances. v2: don't change device info dump (Chris) Cc: Tvrtko Ursulin Cc: Mika Kuoppala Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_device_info.c | 2 +- 1 file changed

Re: [Intel-gfx] [RFC 0/8] Force preemption

2018-03-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-22 09:22:55) > > On 21/03/2018 17:26, jeff.mc...@intel.com wrote: > > From: Jeff McGee > > > > Force preemption uses engine reset to enforce a limit on the time > > that a request targeted for preemption can block. This feature is > > a requirement in automotive s

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a locked clear_bit() for synchronisation with interrupt

2018-03-22 Thread Jani Nikula
On Wed, 21 Mar 2018, Chris Wilson wrote: > Quoting Michel Thierry (2018-03-21 17:01:12) >> On 3/21/2018 3:46 AM, Mika Kuoppala wrote: >> > Chris Wilson writes: >> >> -/* The write will be ordered by the uncached read (itself >> >> - * a memory barrier), so we do not need a

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: hint gen and gen_mask shouldn't be used directly

2018-03-22 Thread Tvrtko Ursulin
On 21/03/2018 14:29, Jani Nikula wrote: Prefix gen and gen_mask in struct intel_device_info with underscores to hint that they should not be used directly, except in special circumstances. I started writing the same patch yesterday and then gave up, being unsure if underscore would prevent so

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a locked clear_bit() for synchronisation with interrupt

2018-03-22 Thread Chris Wilson
Quoting Jani Nikula (2018-03-22 09:34:18) > On Wed, 21 Mar 2018, Chris Wilson wrote: > > Quoting Michel Thierry (2018-03-21 17:01:12) > >> On 3/21/2018 3:46 AM, Mika Kuoppala wrote: > >> > Chris Wilson writes: > >> >> -/* The write will be ordered by the uncached read (itself > >> >>

Re: [Intel-gfx] [PATCH] drm/i915: Allow control of PSR at runtime through debugfs.

2018-03-22 Thread Maarten Lankhorst
Op 22-03-18 om 02:45 schreef Pandiyan, Dhinakaran: > On Thu, 2018-03-15 at 11:28 +0100, Maarten Lankhorst wrote: >> Currently tests modify i915.enable_psr and then do a modeset cycle >> to change PSR. We can write a value to i915_edp_psr_status to force >> a certain value without a modeset. >> >> T

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a locked clear_bit() for synchronisation with interrupt

2018-03-22 Thread Jani Nikula
On Thu, 22 Mar 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-03-22 09:34:18) >> On Wed, 21 Mar 2018, Chris Wilson wrote: >> > Quoting Michel Thierry (2018-03-21 17:01:12) >> >> On 3/21/2018 3:46 AM, Mika Kuoppala wrote: >> >> > Chris Wilson writes: >> >> >> -/* The write will

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for cgroup private data and DRM/i915 integration (rev3)

2018-03-22 Thread Jani Nikula
On Wed, 21 Mar 2018, Patchwork wrote: > == Series Details == > > Series: cgroup private data and DRM/i915 integration (rev3) > URL : https://patchwork.freedesktop.org/series/40142/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 8c23fa59eef7 cgroup: Allow registration a

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2] drm/i915/selftests: Include the trace as a debug aide (rev2)

2018-03-22 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915/selftests: Include the trace as a debug aide (rev2) URL : https://patchwork.freedesktop.org/series/40439/ State : success == Summary == Known issues: Test kms_cursor_legacy: Subgroup flip-vs-cursor-atomic:

[Intel-gfx] [PATCH] drm/i915: Fix tracing of submit seqno

2018-03-22 Thread Chris Wilson
We pre-increment the timeline->seqno when handing it to the request, make sure the GEM_TRACE takes this into account. Otherwise, it appears that we go backwards over a preemption point: 1d..1 157681077us : __i915_request_unsubmit: vcs0 fence 75e:3 <- global_seqno 17 0d.s1 157681113us : __i915_requ

[Intel-gfx] [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution

2018-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we stop relying on regular GPU hangs to be detected, but trigger them manually as soon as we know our batch of interest is actually executing on the GPU, we can dramatically speed up various subtests. This is enabled by the pollable spin batch added in the previous patch.

[Intel-gfx] [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch

2018-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Pollable spin batch exports a spin->running pointer which can be checked by dereferencing it to see if the spinner is actually executing on the GPU. This is useful for tests which want to make sure they do not proceed with their next step whilst the spinner is potentially on

[Intel-gfx] [PATCH i-g-t 3/3] tests/perf_pmu: Improve accuracy by waiting on spinner to start

2018-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More than one test assumes that the spinner is running pretty much immediately after we have create or submitted it. In actuality there is a variable delay, especially on execlists platforms, between submission and spin batch starting to run on the hardware. To enable tests

[Intel-gfx] [PATCH i-g-t v2 2/3] tests/gem_eio: Speed up test execution

2018-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we stop relying on regular GPU hangs to be detected, but trigger them manually as soon as we know our batch of interest is actually executing on the GPU, we can dramatically speed up various subtests. This is enabled by the pollable spin batch added in the previous patch.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix tracing of submit seqno

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix tracing of submit seqno URL : https://patchwork.freedesktop.org/series/40450/ State : warning == Summary == $ dim checkpatch origin/drm-tip 227134823400 drm/i915: Fix tracing of submit seqno -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commi

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/3] lib/dummyload: Add pollable spin batch

2018-03-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-22 11:17:10) > From: Tvrtko Ursulin > > Pollable spin batch exports a spin->running pointer which can be checked > by dereferencing it to see if the spinner is actually executing on the > GPU. > > This is useful for tests which want to make sure they do not procee

[Intel-gfx] [PATCH i-g-t v2 2/3] tests/gem_eio: Speed up test execution

2018-03-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If we stop relying on regular GPU hangs to be detected, but trigger them manually as soon as we know our batch of interest is actually executing on the GPU, we can dramatically speed up various subtests. This is enabled by the pollable spin batch added in the previous patch.

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Enable edp psr error interrupts on hsw

2018-03-22 Thread Ville Syrjälä
On Thu, Mar 22, 2018 at 01:19:19AM +, Pandiyan, Dhinakaran wrote: > > > > On Wed, 2018-03-21 at 21:29 +0200, Ville Syrjälä wrote: > > On Wed, Mar 21, 2018 at 07:19:53PM +, Pandiyan, Dhinakaran wrote: > > > > > > > > > > > > On Wed, 2018-03-21 at 20:59 +0200, Ville Syrjälä wrote: > > >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution

2018-03-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-22 11:17:11) > From: Tvrtko Ursulin > > If we stop relying on regular GPU hangs to be detected, but trigger them > manually as soon as we know our batch of interest is actually executing > on the GPU, we can dramatically speed up various subtests. > > This is enab

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix tracing of submit seqno

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix tracing of submit seqno URL : https://patchwork.freedesktop.org/series/40450/ State : success == Summary == Series 40450v1 drm/i915: Fix tracing of submit seqno https://patchwork.freedesktop.org/api/1.0/series/40450/revisions/1/mbox/ Known issue

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix tracing of submit seqno

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix tracing of submit seqno URL : https://patchwork.freedesktop.org/series/40450/ State : failure == Summary == Possible new issues: Test kms_frontbuffer_tracking: Subgroup fbc-2p-scndscrn-indfb-plflip-blt: pass -> DMES

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution

2018-03-22 Thread Tvrtko Ursulin
On 22/03/2018 11:39, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-03-22 11:17:11) From: Tvrtko Ursulin If we stop relying on regular GPU hangs to be detected, but trigger them manually as soon as we know our batch of interest is actually executing on the GPU, we can dramatically speed up

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/3] tests/gem_eio: Speed up test execution

2018-03-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-03-22 12:36:58) > > On 22/03/2018 11:39, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-03-22 11:17:11) > > > >> trigger_reset(fd); > >> + > >> + /* HACK for CI */ > >> + igt_assert(igt_nsec_elapsed(&ts) < 5e9); > > > > igt_seconds_elapsed(

[Intel-gfx] [PATCH] drm/i915: Remove local timeline var from submit/unsubmit

2018-03-22 Thread Chris Wilson
Both request_submit and request_unsubmit deal with transferring the request from the client's timeline onto the execution timeline and back again. As both functions deal with a pair of timeline's, using a shorthand for just one of them is slightly confusing, especially as the different functions us

[Intel-gfx] [PATCH v2] drm/i915: Remove local timeline var from submit/unsubmit

2018-03-22 Thread Chris Wilson
Both request_submit and request_unsubmit deal with transferring the request from the client's timeline onto the execution timeline and back again. As both functions deal with a pair of timeline's, using a shorthand for just one of them is slightly confusing, especially as the different functions us

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove local timeline var from submit/unsubmit

2018-03-22 Thread Chris Wilson
Quoting Chris Wilson (2018-03-22 12:55:52) > Both request_submit and request_unsubmit deal with transferring the > request from the client's timeline onto the execution timeline and back > again. As both functions deal with a pair of timeline's, using a > shorthand for just one of them is slightly

[Intel-gfx] [PATCH v3] drm/i915: Remove local timeline var from submit/unsubmit

2018-03-22 Thread Chris Wilson
Both request_submit and request_unsubmit deal with transferring the request from the client's timeline onto the execution timeline and back again. As both functions deal with a pair of timeline's, using a shorthand for just one of them is slightly confusing, especially as the different functions us

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove local timeline var from submit/unsubmit (rev2)

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Remove local timeline var from submit/unsubmit (rev2) URL : https://patchwork.freedesktop.org/series/40458/ State : success == Summary == Series 40458v2 drm/i915: Remove local timeline var from submit/unsubmit https://patchwork.freedesktop.org/api/1.0/ser

[Intel-gfx] [PATCH] drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä When we're disabling the HDMI link we try to reset the scrambling and TMDS bit clock ratio back to the default values. This will fail if the sink has already been disconnected. Thus we should not print an error message when resetting the scrambling/TMDS bit clock ratio fail du

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove local timeline var from submit/unsubmit

2018-03-22 Thread Mika Kuoppala
Chris Wilson writes: > Both request_submit and request_unsubmit deal with transferring the > request from the client's timeline onto the execution timeline and back > again. As both functions deal with a pair of timeline's, using a > shorthand for just one of them is slightly confusing, especiall

Re: [Intel-gfx] [PATCH] drm/i915: Fix tracing of submit seqno

2018-03-22 Thread Mika Kuoppala
Chris Wilson writes: > We pre-increment the timeline->seqno when handing it to the request, > make sure the GEM_TRACE takes this into account. Otherwise, it appears > that we go backwards over a preemption point: > > 1d..1 157681077us : __i915_request_unsubmit: vcs0 fence 75e:3 <- global_seqno >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove local timeline var from submit/unsubmit (rev3)

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Remove local timeline var from submit/unsubmit (rev3) URL : https://patchwork.freedesktop.org/series/40458/ State : success == Summary == Series 40458v3 drm/i915: Remove local timeline var from submit/unsubmit https://patchwork.freedesktop.org/api/1.0/ser

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails URL : https://patchwork.freedesktop.org/series/40461/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK in

[Intel-gfx] [RFC 0/5] drm/i915: Interface to get GFX shmem usage stats per process

2018-03-22 Thread Praveen Paneri
This series introduces a new gfx driver interface for tracking graphics memory usage at per process level. This interface is currently needed by android memtracker HAL and it can also be used with driver's shrinker interface (see patch 5). This feature was last floated to ML by Sourab and the disc

[Intel-gfx] [RFC 5/5] drm/i915: Update process mm stats for Gen GFX memory

2018-03-22 Thread Praveen Paneri
From: Sourab Gupta The GFX memory consumed by a process is not accounted by kernel. This leads to a scenario wherein the low memory killer is not able to correctly identify the best process to be killed during OOM scenarios. This case particularly manifests when an application has a large GFX mem

[Intel-gfx] [RFC 3/5] drm/i915: Sysfs interface to get detailed GFX buffer info per process

2018-03-22 Thread Praveen Paneri
From: Sourab Gupta Sometimes, in order to debug the mem usage scenarios, the summarized view of GFX memory consumption per process is not sufficient, as it doesn't provide buffer level details. Therefore, there's a need for an interface, which can provide such detailed information. This patch pr

[Intel-gfx] [RFC 2/5] drm/i915: Calculate total shmem GFX memory consumed

2018-03-22 Thread Praveen Paneri
From: Sourab Gupta There are some GFX buffers e.g. ringbuffers, ctx buffers, etc. which are not associated with any drm fd. Thus, the sum of the shmem memory consumed by processes would be less than the total memory actually consumed in the system. This patch keeps track of all shmem memory cons

[Intel-gfx] [RFC 1/5] drm/i915: Sysfs interface to get GFX shmem usage stats per process

2018-03-22 Thread Praveen Paneri
From: Sourab Gupta There's a need for an interface which provide information about GFX memory usage per process, at any instantaneous point of time. Such information is useful to analyze GFX memory usage of the processes, on the lines of other system memory usage tools (e.g. procrank). This is es

[Intel-gfx] [RFC 4/5] drm/i915: Output the user virtual addresses for GFX buffers

2018-03-22 Thread Praveen Paneri
From: Sourab Gupta This patch adds the functionality to output the virtual addresses of each GFX buffer, mapped into process address space (via interfaces such as mmap and mmap_gtt). Signed-off-by: Sourab Gupta Signed-off-by: Akash Goel Signed-off-by: Nidhi Gupta Signed-off-by: Praveen Paneri

[Intel-gfx] [PATCH v2] drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä When we're disabling the HDMI link we try to reset the scrambling and TMDS bit clock ratio back to the default values. This will fail if the sink has already been disconnected. Thus we should not print an error message when resetting the scrambling/TMDS bit clock ratio fail du

[Intel-gfx] [PATCH v2] drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä When we're disabling the HDMI link we try to reset the scrambling and TMDS bit clock ratio back to the default values. This will fail if the sink has already been disconnected. Thus we should not print an error message when resetting the scrambling/TMDS bit clock ratio fail du

[Intel-gfx] [PATCH igt] lib: Run gem_test_engine() in an isolated context

2018-03-22 Thread Chris Wilson
Ignore the shennigans of the test surrounding the library call to gem_test_engine() and focus on answering the query of whether the engine exists and is operational. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- lib/i915/gem_submission.c | 23 +++ 1 file changed, 19 ins

Re: [Intel-gfx] [RFC 1/5] drm/i915: Sysfs interface to get GFX shmem usage stats per process

2018-03-22 Thread Chris Wilson
Quoting Praveen Paneri (2018-03-22 14:14:54) > From: Sourab Gupta > > There's a need for an interface which provide information about GFX > memory usage per process, at any instantaneous point of time. You meant per context surely. So why not solve userspace's problem in userspace, you are missi

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Include the trace as a debug aide

2018-03-22 Thread Mika Kuoppala
Chris Wilson writes: > If we fail to reset the GPU in a timely fashion, dump the GEM trace so > that we can see what operations were in flight when the GPU got stuck. > > v2: There's more than one timeout that deserves tracing! > v3: Silence checkpatch by not even using a product at all! > > Sign

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Include the trace as a debug aide

2018-03-22 Thread Chris Wilson
Quoting Mika Kuoppala (2018-03-22 14:26:41) > Chris Wilson writes: > > > If we fail to reset the GPU in a timely fashion, dump the GEM trace so > > that we can see what operations were in flight when the GPU got stuck. > > > > v2: There's more than one timeout that deserves tracing! > > v3: Silen

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use full serialisation around engine->irq_posted

2018-03-22 Thread Mika Kuoppala
Chris Wilson writes: > Using engine->irq_posted for execlists, we are not always serialised by > the tasklet as we supposed. On the reset paths, the tasklet is disabled > and ignored. Instead, we manipulate the engine->irq_posted directly to > account for the reset, but if an interrupt fired befo

[Intel-gfx] [PULL] drm-intel-next-fixes

2018-03-22 Thread Joonas Lahtinen
Hi Dave, One GVT regression fix and a fix for race condition declaring GPU wedged, found in CI. The rest are smaller fixes. Expect next week's pull bit earlier in prep for Easter holidays. Regards, Joonas The following changes since commit 963976cfe9c54d4d9e725e61c90c47a4af6b5ea2: Merge tag

[Intel-gfx] [PATCH] drm/i915: Fix hibernation with ACPI S0 target state

2018-03-22 Thread Imre Deak
After commit dd9f31c7a3887950cbd0d49eb9d43f7a1518a356 Author: Imre Deak Date: Wed Aug 16 17:46:07 2017 +0300 drm/i915/gen9+: Set same power state before hibernation image save/restore during hibernation/suspend the power domain functionality got disabled, after which resume could leav

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove local timeline var from submit/unsubmit (rev3)

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Remove local timeline var from submit/unsubmit (rev3) URL : https://patchwork.freedesktop.org/series/40458/ State : failure == Summary == Possible new issues: Test gem_exec_suspend: Subgroup basic-s4-devices: pass -> IN

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Interface to get GFX shmem usage stats per process

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Interface to get GFX shmem usage stats per process URL : https://patchwork.freedesktop.org/series/40464/ State : warning == Summary == $ dim checkpatch origin/drm-tip a2507d62bb4c drm/i915: Sysfs interface to get GFX shmem usage stats per process -:228: C

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Interface to get GFX shmem usage stats per process

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Interface to get GFX shmem usage stats per process URL : https://patchwork.freedesktop.org/series/40464/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Sysfs interface to get GFX shmem usage stats per process Okay! Commit: dr

Re: [Intel-gfx] [RFC 0/8] Force preemption

2018-03-22 Thread Jeff McGee
On Thu, Mar 22, 2018 at 09:28:00AM +, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2018-03-22 09:22:55) > > > > On 21/03/2018 17:26, jeff.mc...@intel.com wrote: > > > From: Jeff McGee > > > > > > Force preemption uses engine reset to enforce a limit on the time > > > that a request targeted

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Interface to get GFX shmem usage stats per process

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Interface to get GFX shmem usage stats per process URL : https://patchwork.freedesktop.org/series/40464/ State : failure == Summary == Series 40464v1 drm/i915: Interface to get GFX shmem usage stats per process https://patchwork.freedesktop.org/api/1.0/se

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails

2018-03-22 Thread Sharma, Shashank
Regards Shashank On 3/22/2018 7:35 PM, Ville Syrjala wrote: From: Ville Syrjälä When we're disabling the HDMI link we try to reset the scrambling and TMDS bit clock ratio back to the default values. This will fail if the sink has already been disconnected. Thus we should not print an error m

[Intel-gfx] [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä I really just wanted to fix i915 to re-enable its planes afer load detection (a two line patch). This is what I actually ended up with after I ran into a framebuffer refcount leak with said two line patch. I've tested this on a few i915 boxes and so far it's looking good. Eve

[Intel-gfx] [PATCH 02/23] drm/atomic-helper: Make drm_atomic_helper_disable_all() update the plane->fb pointers

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä drm_atomic_helper_shutdown() needs to release the reference held by plane->fb, so we want to use drm_atomic_clean_old_fb() in drm_atomic_helper_disable_all(). However during suspend/resume, gpu reset and load detection we should probably leave that stuff alone, as otherwise we

[Intel-gfx] [PATCH 03/23] drm: Clear crtc->primary->crtc when disabling the crtc via setcrtc()

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Keep the primary->crtc in sync with the state->crtc (also with primary->fb and state->fb) when disabling the crtc (and thus also the primary) via setcrtc(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Intel-gfx] [PATCH 04/23] drm/atomic-helper: WARN if legacy plane fb pointers are bogus when committing duplicated state

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä drm_atomic_helper_commit_duplicated_state() should only be called resume/reset/load_detect paths where plane->old_fb should always be NULL and plane->fb should be equal to the new_plane_state->fb. Assert that is indeed the case. Cc: martin.pe...@free.fr Cc: ch...@chris-wilson

[Intel-gfx] [PATCH 06/23] drm: Adjust whitespace for legibility

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Add a bit of whitespace here and there to make the code look a bit more structured. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc.c | 4 +++- drivers/gpu/drm/drm_plane.c | 6 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] [PATCH 05/23] drm: Add local 'plane' variable for primary/cursor planes

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Make the code a bit more readable by storing the plane pointer in a local variable rather than having to do crtc->{primary,cursor} all the time. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_crtc.c | 32 +++- drivers/gpu/drm/drm_plane.c |

[Intel-gfx] [PATCH 08/23] drm: Use plane->state->fb over plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Stop looking at plane->fb on atomic drivers. Use plane->state->fb instead. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- drivers/gpu/drm/drm_crtc.c | 11 +-- drivers/gpu/drm/drm_plane.c | 19 ++- 3 fil

[Intel-gfx] [PATCH 07/23] drm: Make the fb refcount handover less magic

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Instead of assigning the plane->fb pointer and clearing the fb pointer to hand over the reference, let's just do it by grabbing another referece for plane->fb and let fb keep its original one. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_plane.c | 3 +-- 1 file chan

[Intel-gfx] [PATCH 09/23] drm/i915: Stop consulting plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop looking at it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_fbdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH 10/23] drm/msm: Stop consulting plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop looking at it. Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[Intel-gfx] [PATCH 11/23] drm/sti: Stop consulting plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop looking at it. Cc: Benjamin Gaignard Cc: Vincent Abriou Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/sti/sti_plane.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/st

[Intel-gfx] [PATCH 13/23] drm/zte: Stop consulting plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop looking at it. Cc: Shawn Guo Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/zte/zx_vou.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.

[Intel-gfx] [PATCH 15/23] drm: Stop updating plane->crtc/fb/old_fb on atomic drivers

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Stop playing around with plane->crtc/fb/old_fb with atomic drivers. Make life a lot simpler when we don't have to do the magic old_fb vs. fb dance around plane updates. That way we can't risk plane->fb getting out of sync with plane->state->fb and we're less likely to leak any

[Intel-gfx] [PATCH 14/23] drm/atmel-hlcdc: Stop using plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop looking at it. Cc: Boris Brezillon Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/gpu/drm/atme

[Intel-gfx] [PATCH 16/23] drm/amdgpu/dc: Stop updating plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop setting it. Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: Harry Wentland Cc: amd-...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[Intel-gfx] [PATCH 17/23] drm/i915: Stop updating plane->fb/crtc

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb/crtc on atomic drivers. Stop setting them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/

[Intel-gfx] [PATCH 18/23] drm/exynos: Stop updating plane->crtc

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->crtc on atomic drivers. Stop setting it. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH 19/23] drm/msm: Stop updating plane->fb/crtc

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb/crtc on atomic drivers. Stop setting them. Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 - drivers/gpu/drm/msm/disp/mdp4/m

[Intel-gfx] [PATCH 20/23] drm/virtio: Stop updating plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop setting it. Cc: David Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 -- 1 file changed, 2 deletions(-) diff --gi

[Intel-gfx] [PATCH 01/23] Revert "drm/atomic-helper: Fix leak in disable_all"

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Currently we're leaking fbs on load detect on account of nothing setting up plane->old_fb for the drm_atomic_clean_old_fb() call in drm_atomic_helper_commit_duplicated_state(). Removing the drm_atomic_clean_old_fb() call seems like the right call to me here. This does mean we

[Intel-gfx] [PATCH 22/23] drm/i915: Restore planes after load detection

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä Actually turn the planes back on after were done with the load detection. Fixes: 20bdc112bbe4 ("drm/i915: Disable all planes for load detection, v2.") Cc: Maarten Lankhorst Cc: Daniel Vetter Reviewed-by: Maarten Lankhorst Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/

[Intel-gfx] [PATCH 21/23] drm/vc4: Stop updating plane->fb/crtc

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb/crtc on atomic drivers. Stop setting them. Cc: Eric Anholt Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vc4/vc4_crtc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c

[Intel-gfx] [PATCH 12/23] drm/vmwgfx: Stop consulting plane->fb

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä We want to get rid of plane->fb on atomic drivers. Stop looking at it. Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[Intel-gfx] [PATCH 23/23] drm/i915: Make force_load_detect effective even w/ DMI quirks/hotplug

2018-03-22 Thread Ville Syrjala
From: Ville Syrjälä When doing forced load detection testing we should totally ignore any hotplug status for the connector. This is mostly relevant for machines where we already ignore the hotplug status based on the DMI quirks. On other machines we would currently skip the force load detection t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails (rev3)

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails (rev3) URL : https://patchwork.freedesktop.org/series/40461/ State : success == Summary == Series 40461v3 drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio f

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't spew errors when resetting HDMI scrambling/bit clock ratio fails

2018-03-22 Thread Ville Syrjälä
On Thu, Mar 22, 2018 at 08:42:26PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 3/22/2018 7:35 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > When we're disabling the HDMI link we try to reset the scrambling and > > TMDS bit clock ratio back to the default values. Th

Re: [Intel-gfx] [PATCH 5/5] drm/i915/execlists: Flush pending preemption events during reset

2018-03-22 Thread Jeff McGee
On Tue, Mar 20, 2018 at 05:17:34PM -0700, Jeff McGee wrote: > On Tue, Mar 20, 2018 at 12:18:48AM +, Chris Wilson wrote: > > Catch up with the inflight CSB events, after disabling the tasklet > > before deciding which request was truly guilty of hanging the GPU. > > > > Signed-off-by: Chris Wil

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix hibernation with ACPI S0 target state

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix hibernation with ACPI S0 target state URL : https://patchwork.freedesktop.org/series/40466/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3f4a1545711f drm/i915: Fix hibernation with ACPI S0 target state -:11: ERROR:GIT_COMMIT_ID: Pleas

Re: [Intel-gfx] [RFC 0/8] Force preemption

2018-03-22 Thread Chris Wilson
Quoting Jeff McGee (2018-03-22 14:34:58) > On Thu, Mar 22, 2018 at 09:28:00AM +, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-03-22 09:22:55) > > > > > > On 21/03/2018 17:26, jeff.mc...@intel.com wrote: > > > > From: Jeff McGee > > > > > > > > Force preemption uses engine reset to en

Re: [Intel-gfx] [PATCH 2/5] drm/i915/execlists: Refactor out complete_preempt_context()

2018-03-22 Thread Jeff McGee
On Tue, Mar 20, 2018 at 12:18:45AM +, Chris Wilson wrote: > As a complement to inject_preempt_context(), follow up with the function > to handle its completion. This will be useful should we wish to extend > the duties of the preempt-context for execlists. > > Signed-off-by: Chris Wilson > Cc

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Move engine reset prepare/finish to backends

2018-03-22 Thread Jeff McGee
On Tue, Mar 20, 2018 at 12:18:46AM +, Chris Wilson wrote: > In preparation to more carefully handling incomplete preemption during > reset by execlists, we move the existing code wholesale to the backends > under a couple of new reset vfuncs. > > Signed-off-by: Chris Wilson > Cc: Michał Winia

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Split execlists/guc reset prepartions

2018-03-22 Thread Jeff McGee
On Tue, Mar 20, 2018 at 12:18:47AM +, Chris Wilson wrote: > In the next patch, we will make the execlists reset prepare callback > take into account preemption by flushing the context-switch handler. > This is not applicable to the GuC submission backend, so split the two > into their own backe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix hibernation with ACPI S0 target state

2018-03-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix hibernation with ACPI S0 target state URL : https://patchwork.freedesktop.org/series/40466/ State : success == Summary == Series 40466v1 drm/i915: Fix hibernation with ACPI S0 target state https://patchwork.freedesktop.org/api/1.0/series/40466/revisio

  1   2   3   >