Re: [Intel-gfx] [PATCH] drm/i915/psr: Remove few mod parameters option.

2018-07-11 Thread Dhinakaran Pandiyan
On Wed, 2018-07-11 at 22:27 -0700, Rodrigo Vivi wrote: > Reduce the module parameter to enable or disable. > > The link stand by vs full link off was used only once. > > And it was actually masking another bug fixed by commit > '84bb2916a683 ("drm/i915/psr: Check for SET_POWER_CAPABLE > bit at

[Intel-gfx] [PATCH v5] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-11 Thread Tarun Vyas
In commit "drm/i915: Wait for PSR exit before checking for vblank evasion", the idea was to limit the PSR IDLE checks when PSR is actually supported. While CAN_PSR does do that check, it doesn't applies on a per-crtc basis. crtc_state->has_psr is a more granular check that only applies to pipe(s)

[Intel-gfx] [PATCH] drm/i915/psr: Remove few mod parameters option.

2018-07-11 Thread Rodrigo Vivi
Reduce the module parameter to enable or disable. The link stand by vs full link off was used only once. And it was actually masking another bug fixed by commit '84bb2916a683 ("drm/i915/psr: Check for SET_POWER_CAPABLE bit at PSR init time.")' So, let's remove these options for now. End goal is

Re: [Intel-gfx] [PATCH v4] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-11 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 17:39 -0700, Tarun Vyas wrote: > In commit "drm/i915: Wait for PSR exit before checking for vblank > evasion", the idea was to limit the PSR IDLE checks when PSR is > actually supported. While CAN_PSR does do that check, it doesn't > applies on a per-crtc basis.

Re: [Intel-gfx] [PATCH v5 20/40] drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 2:21 AM > To: C, Ramalingam > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > ;

Re: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Thursday, July 12, 2018 12:38 AM > To: C, Ramalingam > Cc: Sean Paul ; intel-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; dan...@ffwll.ch; Winkler, Tomas > ; Usyskin, Alexander > ; Shankar, Uma

Re: [Intel-gfx] [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Thursday, July 12, 2018 2:36 AM > To: C, Ramalingam > Cc: Sean Paul ; intel-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; dan...@ffwll.ch; Winkler, Tomas > ; Usyskin, Alexander > ; Shankar, Uma

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2018-07-11 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/gpu/drm/sun4i/sun8i_tcon_top.c: In function 'sun8i_tcon_top_register_gate': drivers/gpu/drm/sun4i/sun8i_tcon_top.c:102:10: warning: return makes pointer from integer

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-11 Thread Feng Tang
On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > Hi Daneil/Jani/Takashi, > > When I was testing this patch from Takashi, I further checked the kernel > module code, and found that: we may need NOT to add any new codes

[Intel-gfx] [PULL] drm-misc-next

2018-07-11 Thread Gustavo Padovan
Hi Dave, Big update this week for 4.19. One can never have enough panels, many added. We also have the initial support for vkms from our GSoC and Outreachy students \o/ plus a bunch of improvements and fixes all over core and drivers. An API for in-kernel clients is also in the works. Please

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Remove useless function calls.

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915/psr: Remove useless function calls. URL : https://patchwork.freedesktop.org/series/46339/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4473 -> Patchwork_9619 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-11 Thread Andrew Morton
On Wed, 11 Jul 2018 13:51:08 +0200 Daniel Vetter wrote: > But I still have the situation that a bunch of maintainers acked this > and Andrew Morton defacto nacked it, which I guess means I'll keep the > macro in drm? The common way to go about this seems to be to just push > the patch series

[Intel-gfx] ✓ Fi.CI.BAT: success for Remaining ICL display patches

2018-07-11 Thread Patchwork
== Series Details == Series: Remaining ICL display patches URL : https://patchwork.freedesktop.org/series/46338/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4473 -> Patchwork_9618 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Remaining ICL display patches

2018-07-11 Thread Patchwork
== Series Details == Series: Remaining ICL display patches URL : https://patchwork.freedesktop.org/series/46338/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/icl: compute the TBT PLL registers Okay! Commit: drm/i915/icl: implement icl_digital_port_connected()

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Remaining ICL display patches

2018-07-11 Thread Patchwork
== Series Details == Series: Remaining ICL display patches URL : https://patchwork.freedesktop.org/series/46338/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0b47f5ccf84a drm/i915/icl: compute the TBT PLL registers -:23: CHECK:CAMELCASE: Avoid CamelCase: #23: FILE:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Interactive RPS mode

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: Interactive RPS mode URL : https://patchwork.freedesktop.org/series/46334/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4473 -> Patchwork_9617 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9617 absolutely

Re: [Intel-gfx] [PATCH i-g-t 06/11] trace.pl: Improve context colouring for large context id's

2018-07-11 Thread John Harrison
On 7/9/2018 6:19 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin John reports that on a long runnning systems the huge disparity between kernel context and user context id's causes all interesting colours to be clustered too close together. Fix this by assigning colours to seen contexts

Re: [Intel-gfx] [PATCH i-g-t 02/11] trace.pl: Improve readability of graphical timeline representation

2018-07-11 Thread John Harrison
On 7/9/2018 6:19 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We add stripes for different stages of request execution so it is easier to follow one context in the multi-colour mode. Vertical stripe pattern indicates pipeline "blockages" - requests waiting for dependencies before they are

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Interactive RPS mode

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: Interactive RPS mode URL : https://patchwork.freedesktop.org/series/46334/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Interactive RPS mode -drivers/gpu/drm/i915/selftests/../i915_drv.h:3652:16: warning: expression using

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Interactive RPS mode

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: Interactive RPS mode URL : https://patchwork.freedesktop.org/series/46334/ State : warning == Summary == $ dim checkpatch origin/drm-tip f46e1cca8c23 drm/i915: Interactive RPS mode -:24: ERROR:GIT_COMMIT_ID: Please use git commit description style

Re: [Intel-gfx] [PATCH] drm/i915/psr: Remove useless function calls.

2018-07-11 Thread Souza, Jose
On Wed, 2018-07-11 at 15:00 -0700, Rodrigo Vivi wrote: > PSR is no longer supported on VLV/CHV so this is just dead code. > Reviewed-by: José Roberto de Souza > Cc: Dhinakaran Pandiyan > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_dp.c | 7 --- > 1 file changed, 7

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "ALSA: pcm: Fix snd_interval_refine first/last with open min/max"

2018-07-11 Thread Patchwork
== Series Details == Series: Revert "ALSA: pcm: Fix snd_interval_refine first/last with open min/max" URL : https://patchwork.freedesktop.org/series/46332/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4473 -> Patchwork_9616 = == Summary - SUCCESS == No regressions

[Intel-gfx] [PATCH] drm/i915/psr: Remove useless function calls.

2018-07-11 Thread Rodrigo Vivi
PSR is no longer supported on VLV/CHV so this is just dead code. Cc: Dhinakaran Pandiyan Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index

[Intel-gfx] [PATCH 0/8] Remaining ICL display patches

2018-07-11 Thread Paulo Zanoni
These are the remaining patches from the series called "[PATCH 00/24] More ICL display patches". Patches 1, 3 and 4 still need reviews. Animesh Manna (1): drm/i915/icl: Update FIA supported lane count for hpd. Paulo Zanoni (7): drm/i915/icl: compute the TBT PLL registers drm/i915/icl:

[Intel-gfx] [PATCH 6/8] drm/i915/icl: Update FIA supported lane count for hpd.

2018-07-11 Thread Paulo Zanoni
From: Animesh Manna In ICL, Flexible IO Adapter (FIA) muxes data and clocks of USB 3.1, tbt and display controller. In DP alt mode FIA configure the number of lanes and will be used apart from DPCD read to calculate max available lanes for DP enablement. Reviewed-by: Anusha Srivatsa

[Intel-gfx] [PATCH 3/8] drm/i915/icl: store the port type for TC ports

2018-07-11 Thread Paulo Zanoni
The type is detected based on the interrupt ISR bit. Once detected, it's not supposed to be changed, so we have some sanity checks for that. Cc: Animesh Manna Signed-off-by: Paulo Zanoni Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.h | 7 +++

[Intel-gfx] [PATCH 5/8] drm/i915/icl: implement the legacy HPD {dis, }connect flow for HDMI

2018-07-11 Thread Paulo Zanoni
Just like DP, HDMI needs to implement these flows. The side effect is that HDMI is now going to rely on the ISR bits, just like DP. Reviewed-by: Mika Kahola Signed-off-by: Paulo Zanoni [Rodrigo: non-trivial rebase.] Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_hdmi.c | 11

[Intel-gfx] [PATCH 8/8] drm/i915/icl: toggle PHY clock gating around link training

2018-07-11 Thread Paulo Zanoni
The Gen11 TypeC PHY DDI Buffer chapter, PHY Clock Gating Programming section says that PHY clock gating should be disabled before starting voltage swing programming, then enabled after any link training is complete. Cc: Animesh Manna Cc: Manasi Navare Reviewed-by: Maarten Lankhorst

[Intel-gfx] [PATCH 4/8] drm/i915/icl: implement the tc/legacy HPD {dis, }connect flow for DP

2018-07-11 Thread Paulo Zanoni
Implement the DFLEXDPPMS/DFLEXDPCSSS dance for DisplayPort. These functions need to be called during HPD assert/deassert, but due to how our driver works it's much simpler if we always call them when icl_digital_port_connected() is called, which means we won't call them exactly once per HPD event.

[Intel-gfx] [PATCH 7/8] drm/i915/icl: program MG_DP_MODE

2018-07-11 Thread Paulo Zanoni
Programming this register is part of the Enable Sequence for DisplayPort on ICL. Do as the spec says. Cc: Animesh Manna Reviewed-by: Maarten Lankhorst Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_reg.h | 15 + drivers/gpu/drm/i915/intel_ddi.c | 2 ++

[Intel-gfx] [PATCH 2/8] drm/i915/icl: implement icl_digital_port_connected()

2018-07-11 Thread Paulo Zanoni
Do like the other functions and check for the ISR bits. We have plans to add a few more checks in this code in the next patches, that's why it's a little more verbose than it could be. v2: Rebase. Cc: Animesh Manna Reviewed-by: Lucas De Marchi (v1) Signed-off-by: Paulo Zanoni Signed-off-by:

[Intel-gfx] [PATCH 1/8] drm/i915/icl: compute the TBT PLL registers

2018-07-11 Thread Paulo Zanoni
Use the hardcoded tables provided by our spec. v2: - SSC stays disabled. - Use intel_port_is_tc(). Cc: Anusha Srivatsa Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "ALSA: pcm: Fix snd_interval_refine first/last with open min/max"

2018-07-11 Thread Patchwork
== Series Details == Series: Revert "ALSA: pcm: Fix snd_interval_refine first/last with open min/max" URL : https://patchwork.freedesktop.org/series/46332/ State : warning == Summary == $ dim checkpatch origin/drm-tip d89275af2b4f Revert "ALSA: pcm: Fix snd_interval_refine first/last with

Re: [Intel-gfx] [PATCH 20/24] drm/i915/icl: implement the tc/legacy HPD {dis, }connect flow for DP

2018-07-11 Thread Paulo Zanoni
Em Qui, 2018-06-21 às 15:04 -0700, Srivatsa, Anusha escreveu: > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On > > Behalf Of > > Paulo Zanoni > > Sent: Monday, May 21, 2018 5:26 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Zanoni, Paulo R

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Jens Axboe
On 7/11/18 3:08 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: >> On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: >>> I don't think there's a git easy way of sending it out outside of >>> just ensuring that everybody is CC'ed on everything. I don't mind

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 10:06 PM, Tejun Heo wrote: > On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: >> I don't think there's a git easy way of sending it out outside of >> just ensuring that everybody is CC'ed on everything. I don't mind >> that at all. I don't subscribe to lkml, and

Re: [Intel-gfx] [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-11 Thread Sean Paul
On Wed, Jul 11, 2018 at 07:07:10PM +, C, Ramalingam wrote: > > > -Original Message- > > From: Sean Paul [mailto:seanp...@chromium.org] > > Sent: Tuesday, July 10, 2018 2:04 AM > > To: C, Ramalingam > > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > >

[Intel-gfx] [PATCH] drm/i915: Interactive RPS mode

2018-07-11 Thread Chris Wilson
RPS provides a feedback loop where we use the load during the previous evaluation interval to decide whether to up or down clock the GPU frequency. Our responsiveness is split into 3 regimes, a high and low plateau with the intent to keep the gpu clocked high to cover occasional stalls under high

[Intel-gfx] [PATCH] Revert "ALSA: pcm: Fix snd_interval_refine first/last with open min/max"

2018-07-11 Thread Chris Wilson
This reverts commit ff2d6acdf6f13d9f8fdcd890844c6d7535ac1f10. --- sound/core/pcm_lib.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 4e6110d778bd..5736860f325b 100644 --- a/sound/core/pcm_lib.c +++

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Wed, Jul 11, 2018 at 01:31:51PM -0600, Jens Axboe wrote: > I don't think there's a git easy way of sending it out outside of > just ensuring that everybody is CC'ed on everything. I don't mind > that at all. I don't subscribe to lkml, and the patches weren't > sent to linux-block. Hence all I

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Jens Axboe
On 7/11/18 12:50 PM, Daniel Vetter wrote: > On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >> On 7/11/18 10:45 AM, Tejun Heo wrote: >>> On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > Makes the macros

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-11 Thread Mark Rutland
On Mon, Jul 09, 2018 at 07:55:20PM +0200, Daniel Vetter wrote: > On Mon, Jul 9, 2018 at 6:12 PM, Mark Rutland wrote: > > On Mon, Jul 09, 2018 at 06:03:42PM +0200, Peter Zijlstra wrote: > >> On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: > >> > for_each_something(foo) > >> > if

Re: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-11 Thread Sean Paul
On Wed, Jul 11, 2018 at 05:57:08PM +, C, Ramalingam wrote: > Thanks seanpaul for the reviews. > > > -Original Message- > > From: Sean Paul [mailto:seanp...@chromium.org] > > Sent: Tuesday, July 10, 2018 1:51 AM > > To: C, Ramalingam > > Cc: intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 2:04 AM > To: C, Ramalingam > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > > Subject:

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: > On 7/11/18 10:45 AM, Tejun Heo wrote: >> On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: >>> On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: Makes the macros resilient against if {} else {} blocks right

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Jens Axboe
On 7/11/18 10:45 AM, Tejun Heo wrote: > On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: >> On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: >>> Makes the macros resilient against if {} else {} blocks right >>> afterwards. >>> >>> Signed-off-by: Daniel Vetter >>> Cc: Tejun

[Intel-gfx] [drm-tip:drm-tip 8/9] debug.c:undefined reference to `save_stack_trace'

2018-07-11 Thread kbuild test robot
Hi Rodrigo, It's probably a bug fix that unveils the link errors. tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 02e578b7aace48d33fa617dddb40621bd664c92c commit: dde6f6606700e68d82f0452d9a9a3b78dff1068f [8/9] Merge remote-tracking branch 'drm-intel/topic/core-for-CI' into

Re: [Intel-gfx] [PATCH v5 05/40] drm/i915: wrapping all hdcp var into intel_hdcp

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 2:00 AM > To: C, Ramalingam > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > > Subject:

Re: [Intel-gfx] [PATCH i-g-t 05/11] trace.pl: Fix HTML timestamp generation

2018-07-11 Thread John Harrison
On 7/9/2018 6:19 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Now that we scale timestamps to get better timeline granularity, the hacky hand rolled micro-second time to HTML date conversion does no longer cut it. Use perl built-in gmtime to handle things properly. Signed-off-by: Tvrtko

Re: [Intel-gfx] [PATCH v5 02/40] drm: HDMI and DP specific HDCP2.2 defines

2018-07-11 Thread C, Ramalingam
> -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 1:53 AM > To: C, Ramalingam > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, > Alexander ; Shankar, Uma > > Subject:

Re: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-11 Thread C, Ramalingam
Thanks seanpaul for the reviews. > -Original Message- > From: Sean Paul [mailto:seanp...@chromium.org] > Sent: Tuesday, July 10, 2018 1:51 AM > To: C, Ramalingam > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > dan...@ffwll.ch; Winkler, Tomas ; Usyskin, >

Re: [Intel-gfx] [PATCH i-g-t 04/11] trace.pl: Put single context at single vertical slot

2018-07-11 Thread John Harrison
On 7/9/2018 6:19 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Turn off timeline stacking in favour of putting all the boxes belonging to a single context at the same vertical slot. Also remove the custom sorting function in favour of correctly assigning the subgroup id's and order which

Re: [Intel-gfx] [PATCH i-g-t 03/11] trace.pl: Scale timeline for better precision

2018-07-11 Thread John Harrison
On 7/9/2018 6:19 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin vis library has a limited precision compared to our trace data which prevents zooming into the timeline and seeing the fine detail. Scale the HTML view by a thousand to work around it. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH i-g-t 01/11] trace.pl: Fix no context colouring mode

2018-07-11 Thread John Harrison
On 7/9/2018 6:19 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 87d2affc380da96ba66c258c5337c363fe8651ef ("trace.pl: Add support for colouring context execution"), due some dodgy attempts at patch splitting broke the legacy colouring mode. Fix it by passing in the request stage into

Re: [Intel-gfx] [PATCH 2/2] drm/i915: kill resource streamer

2018-07-11 Thread Lucas De Marchi
On Tue, Jul 10, 2018 at 2:51 AM Chris Wilson wrote: > > Quoting Lucas De Marchi (2018-07-10 01:06:58) > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > > b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > > index 1932bc227942..a5eec97a40fe 100644 > > ---

Re: [Intel-gfx] [PATCH 03/12] cgroup: use for_each_if

2018-07-11 Thread Tejun Heo
On Mon, Jul 09, 2018 at 10:36:41AM +0200, Daniel Vetter wrote: > Avoids the need to invert the condition instead of the open-coded > version. > > Signed-off-by: Daniel Vetter > Cc: Tejun Heo > Cc: Li Zefan > Cc: Johannes Weiner > Cc: cgro...@vger.kernel.org Acked-by: Tejun Heo Please feel

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > > Makes the macros resilient against if {} else {} blocks right > > afterwards. > > > > Signed-off-by: Daniel Vetter > > Cc: Tejun Heo > > Cc: Jens Axboe > > Cc:

Re: [Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-11 Thread Tejun Heo
On Mon, Jul 09, 2018 at 10:36:40AM +0200, Daniel Vetter wrote: > Makes the macros resilient against if {} else {} blocks right > afterwards. > > Signed-off-by: Daniel Vetter > Cc: Tejun Heo > Cc: Jens Axboe > Cc: Shaohua Li > Cc: Kate Stewart > Cc: Greg Kroah-Hartman > Cc: Joseph Qi > Cc:

[Intel-gfx] ✗ Fi.CI.BAT: failure for Improve crc-core driver interface (rev5)

2018-07-11 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev5) URL : https://patchwork.freedesktop.org/series/45246/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4470 -> Patchwork_9615 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9615

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Improve crc-core driver interface (rev5)

2018-07-11 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev5) URL : https://patchwork.freedesktop.org/series/45246/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm: crc: Introduce verify_crc_source callback Okay! Commit: drm: crc: Introduce get_crc_sources

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2)

2018-07-11 Thread Ville Syrjälä
On Wed, Jul 11, 2018 at 04:09:03PM +0200, Hans Verkuil wrote: > Hi Ville, > > On 11/07/18 15:41, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2) > > URL : https://patchwork.freedesktop.org/series/46306/ > > State :

[Intel-gfx] [PATCH 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the crc sources supported by driver in current platform. Signed-off-by: Mahesh Kumar Cc: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 11 ++ drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +

[Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-11 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source.

[Intel-gfx] [PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 +

[Intel-gfx] [PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-11 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

[Intel-gfx] [PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should return a constant pointer to an array of crc sources list and update count according to the number

[Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 66

[Intel-gfx] [PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +

[Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Signed-off-by: Mahesh Kumar Cc:

[Intel-gfx] [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner ---

[Intel-gfx] [PATCH 00/10] Improve crc-core driver interface

2018-07-11 Thread Mahesh Kumar
This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup

[Intel-gfx] ✓ Fi.CI.BAT: success for i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-11 Thread Patchwork
== Series Details == Series: i915/intel_tv_get_modes: fix strncpy truncation warning URL : https://patchwork.freedesktop.org/series/46314/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4470 -> Patchwork_9614 = == Summary - SUCCESS == No regressions found. External

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-11 Thread Chris Wilson
Quoting Dominique Martinet (2018-07-11 08:46:15) > This is effectively no-op as the next line writes a nul at the final > byte of the buffer, so copying one letter less does not change the > behaviour. > > Signed-off-by: Dominique Martinet > --- > > gcc 8 gives the following warning, which I am

[Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-11 Thread Dominique Martinet
This is effectively no-op as the next line writes a nul at the final byte of the buffer, so copying one letter less does not change the behaviour. Signed-off-by: Dominique Martinet --- gcc 8 gives the following warning, which I am not sure why is treated as error for this file, thus making me

[Intel-gfx] ✗ Fi.CI.BAT: failure for I915 component master

2018-07-11 Thread Patchwork
== Series Details == Series: I915 component master URL : https://patchwork.freedesktop.org/series/46312/ State : failure == Summary == Applying: component: alloc component_match without any comp to match Applying: drm/i915: component master at i915 driver load Applying: drm/i915: Initialize

[Intel-gfx] [RFC 3/3] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-11 Thread Ramalingam C
Initialize HDCP2.2 support. This includes the mei interface initialization along with required component registration. v2: mei interface handle is protected with mutex. [Chris Wilson] v3: Notifiers are used for the mei interface state. v4: Poll for mei client device state Error msg for

[Intel-gfx] [RFC 0/3] I915 component master

2018-07-11 Thread Ramalingam C
i915_driver_load registers a component master and i915 driver registration is moved into the bind call of that component master. If any component of the particular features are registered with this I915 component master's match, then I915 registration will wait until all registered components are

[Intel-gfx] [RFC 1/3] component: alloc component_match without any comp to match

2018-07-11 Thread Ramalingam C
If all the components associated to a component master is not added to the component framework due to the HW capability or Kconfig selection, component_match will be NULL at component_master_add_with_match(). To avoid this, component_match_alloc() is added to the framework, to allcoate the struct

[Intel-gfx] [RFC 2/3] drm/i915: component master at i915 driver load

2018-07-11 Thread Ramalingam C
A generic component master is added to hold the i915 registration untill all required kernel modules are up and active. This is achieved through following steps: - moving the i915 driver registration to the component master's bind call - all required kernel modules

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2)

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2) URL : https://patchwork.freedesktop.org/series/46306/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4469 -> Patchwork_9612 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2)

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2) URL : https://patchwork.freedesktop.org/series/46306/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm: add support for DisplayPort CEC-Tunneling-over-AUX + +Error in reading or

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2)

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: add DisplayPort CEC-Tunneling-over-AUX support (rev2) URL : https://patchwork.freedesktop.org/series/46306/ State : warning == Summary == $ dim checkpatch origin/drm-tip 79b707b649f8 drm: add support for DisplayPort CEC-Tunneling-over-AUX -:53:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Add a safety net to live_workarounds (rev3)

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add a safety net to live_workarounds (rev3) URL : https://patchwork.freedesktop.org/series/46301/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4469 -> Patchwork_9611 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCHv10 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard. Unfortunately, not all DisplayPort/USB-C to HDMI adapters with a chip that has this capability actually hook up the CEC pin, so even though a CEC device is

[Intel-gfx] [PATCHv10 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Implement support for this DisplayPort feature. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCHv10 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX feature. This patch series is based on top of drm-intel-next. The v10 is identical to v9, except it is rebased to drm-intel-next (v9 didn't apply cleanly) and two alignment warnings have been fixed.

[Intel-gfx] [PATCHv10 2/3] drm-kms-helpers.rst: document the DP CEC helpers

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Document the Display Port CEC helper functions. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- Documentation/gpu/drm-kms-helpers.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst

Re: [Intel-gfx] [PATCH 09/37] drm/i915/execlists: Switch to rb_root_cached

2018-07-11 Thread Tvrtko Ursulin
On 29/06/2018 08:53, Chris Wilson wrote: The kernel recently gained an augmented rbtree with the purpose of cacheing the leftmost element of the rbtree, a frequent optimisation to avoid calls to rb_first() which is also employed by the execlists->queue. Switch from our open-coded cache to the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Add a safety net to live_workarounds (rev3)

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add a safety net to live_workarounds (rev3) URL : https://patchwork.freedesktop.org/series/46301/ State : warning == Summary == $ dim checkpatch origin/drm-tip a79baf771e2d drm/i915/selftests: Add a safety net to live_workarounds -:20:

Re: [Intel-gfx] [PATCH v3] drm/i915/selftests: Add a safety net to live_workarounds

2018-07-11 Thread Mika Kuoppala
Chris Wilson writes: > Since live_workarounds poke around the w/a registers and checks to see > if they survive across a reset, we are prone to fouling the machine and > leaving it in a non-recoverable state. Wrap the probe inside a timeout > to abort the test if the reset fails. > > v2: Include

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: add DisplayPort CEC-Tunneling-over-AUX support URL : https://patchwork.freedesktop.org/series/46306/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4469 -> Patchwork_9610 = == Summary - SUCCESS == No regressions found. External

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: add DisplayPort CEC-Tunneling-over-AUX support URL : https://patchwork.freedesktop.org/series/46306/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm: add support for DisplayPort CEC-Tunneling-over-AUX + +Error in reading or end of

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Patchwork
== Series Details == Series: drm/i915: add DisplayPort CEC-Tunneling-over-AUX support URL : https://patchwork.freedesktop.org/series/46306/ State : warning == Summary == $ dim checkpatch origin/drm-tip a9b15a0bc541 drm: add support for DisplayPort CEC-Tunneling-over-AUX -:53:

[Intel-gfx] [PATCH v3] drm/i915/selftests: Add a safety net to live_workarounds

2018-07-11 Thread Chris Wilson
Since live_workarounds poke around the w/a registers and checks to see if they survive across a reset, we are prone to fouling the machine and leaving it in a non-recoverable state. Wrap the probe inside a timeout to abort the test if the reset fails. v2: Include GEM_TRACE on declaring wedged.

[Intel-gfx] [PATCHv9 2/3] drm-kms-helpers.rst: document the DP CEC helpers

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Document the Display Port CEC helper functions. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- Documentation/gpu/drm-kms-helpers.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst

[Intel-gfx] [PATCHv9 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX feature. This patch series is based on the current media master branch (https://git.linuxtv.org/media_tree.git/log/) but it applies fine on top of the current mainline tree. The v9 is identical to v8,

[Intel-gfx] [PATCH v2] drm/i915/selftests: Add a safety net to live_workarounds

2018-07-11 Thread Chris Wilson
Since live_workarounds poke around the w/a registers and checks to see if they survive across a reset, we are prone to fouling the machine and leaving it in a non-recoverable state. Wrap the probe inside a timeout to abort the test if the reset fails. v2: Include GEM_TRACE on declaring wedged.

[Intel-gfx] [PATCHv9 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Implement support for this DisplayPort feature. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCHv9 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard. Unfortunately, not all DisplayPort/USB-C to HDMI adapters with a chip that has this capability actually hook up the CEC pin, so even though a CEC device is

  1   2   >