[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: avoid unclaimed PLANE_NV12_BUF_CFG register

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915/icl: avoid unclaimed PLANE_NV12_BUF_CFG register URL : https://patchwork.freedesktop.org/series/47520/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4600_full -> Patchwork_9828_full = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: avoid unclaimed PLANE_NV12_BUF_CFG register

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915/icl: avoid unclaimed PLANE_NV12_BUF_CFG register URL : https://patchwork.freedesktop.org/series/47520/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4600 -> Patchwork_9828 = == Summary - SUCCESS == No regressions found. External

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows URL : https://patchwork.freedesktop.org/series/47518/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4600_full -> Patchwork_9826_full = == Summary - WARNING == Minor unknown

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/icl: Add pre_pll_enable hook for ICL and set DFLEXDPMLE in this hook

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add pre_pll_enable hook for ICL and set DFLEXDPMLE in this hook URL : https://patchwork.freedesktop.org/series/47519/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4600 -> Patchwork_9827 = == Summary - FAILURE == Serious

[Intel-gfx] [PATCH] drm/i915/icl: avoid unclaimed PLANE_NV12_BUF_CFG register

2018-07-31 Thread Paulo Zanoni
We don't have proper watermark NV12 support on ICL due to differences in how it should be implemented. In commit 234059da0f33 ("drm/i915/icl: NV12 y-plane ddb is not in same plane") we avoided writing the non-existent PLANE_NV12_BUF_CFG registers but we forgot to also avoid them on the hardware

[Intel-gfx] [PATCH] drm/i915/icl: Add pre_pll_enable hook for ICL and set DFLEXDPMLE in this hook

2018-07-31 Thread Manasi Navare
In case of Legacy DP connector on TypeC port (C, D, E or F), the flex IO DPMLE register is set to maximum number of lanes since there is no muxing with other controllers in this case. While in case of the TypeC connector, it is set to the lane count obained from DFLEXDPSP register. This needs to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows URL : https://patchwork.freedesktop.org/series/47518/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4600 -> Patchwork_9826 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH] drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows

2018-07-31 Thread Paulo Zanoni
Unlike the other ports, TC ports are not available to use as soon as we get a hotplug. The TC PHYs can be shared between multiple controllers: display, USB, etc. As a result, handshaking through FIA is required around connect and disconnect to cleanly transfer ownership with the controller and set

Re: [Intel-gfx] [PATCH v2 03/23] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-07-31 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Tuesday, July 31, 2018 2:07 PM >To: intel-gfx@lists.freedesktop.org >Cc: Navare, Manasi D ; Singh, Gaurav K >; dri-de...@lists.freedesktop.org; Jani Nikula >; Ville Syrjala ; >Srivatsa, Anusha >Subject: [PATCH v2 03/23] drm/dp: DRM DP

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Drop stray clearing of rps->last_adj

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915: Drop stray clearing of rps->last_adj URL : https://patchwork.freedesktop.org/series/47513/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4599_full -> Patchwork_9822_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] ✗ Fi.CI.BAT: failure for Display Stream Compression enabling on eDP/DP

2018-07-31 Thread Patchwork
== Series Details == Series: Display Stream Compression enabling on eDP/DP URL : https://patchwork.freedesktop.org/series/47514/ State : failure == Summary == Applying: drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Applying: drm/i915/dp: Cache the DP/eDP DSC DPCD

Re: [Intel-gfx] [PATCH v2 02/23] drm/i915/dp: Cache the DP/eDP DSC DPCD register set on Hotplug/eDP Init

2018-07-31 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Tuesday, July 31, 2018 2:07 PM >To: intel-gfx@lists.freedesktop.org >Cc: Navare, Manasi D ; Jani Nikula >; Ville Syrjala ; >Daniel >Vetter ; Srivatsa, Anusha ; >Singh, Gaurav K >Subject: [PATCH v2 02/23] drm/i915/dp: Cache the DP/eDP

Re: [Intel-gfx] [PATCH v2 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-07-31 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Tuesday, July 31, 2018 2:07 PM >To: intel-gfx@lists.freedesktop.org >Cc: Navare, Manasi D ; dri- >de...@lists.freedesktop.org; Jani Nikula ; Ville >Syrjala ; Srivatsa, Anusha >; Singh, Gaurav K >Subject: [PATCH v2 01/23] drm/dp: Add DP

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v4,1/3] drm/i915: make PCH_GMBUS* definitions private to gvt

2018-07-31 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915: make PCH_GMBUS* definitions private to gvt URL : https://patchwork.freedesktop.org/series/47367/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4599_full -> Patchwork_9821_full = == Summary - WARNING ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for Display Stream Compression enabling on eDP/DP

2018-07-31 Thread Patchwork
== Series Details == Series: Display Stream Compression enabling on eDP/DP URL : https://patchwork.freedesktop.org/series/47514/ State : failure == Summary == Applying: drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Applying: drm/i915/dp: Cache the DP/eDP DSC DPCD

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drop stray clearing of rps->last_adj

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915: Drop stray clearing of rps->last_adj URL : https://patchwork.freedesktop.org/series/47513/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4599 -> Patchwork_9822 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✗ Fi.CI.BAT: failure for Display Stream Compression enabling on eDP/DP

2018-07-31 Thread Patchwork
== Series Details == Series: Display Stream Compression enabling on eDP/DP URL : https://patchwork.freedesktop.org/series/47514/ State : failure == Summary == Applying: drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Applying: drm/i915/dp: Cache the DP/eDP DSC DPCD

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Terminate the context image with BB_END

2018-07-31 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-07-31 13:47:32) > On 30/07/18 17:43, Chris Wilson wrote: > > In the aub trace utility, the context images are terminated with a > > MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise. > > Do the same for our protocontext image for completeness,

Re: [Intel-gfx] [PATCH v1 1/2] drm/i915: ddb_size is of u16 type

2018-07-31 Thread Chris Wilson
Quoting Mahesh Kumar (2018-07-31 15:24:44) > ddb_size is u16 so use same return type for intel_get_ddb_size > wrapper. > > Signed-off-by: Mahesh Kumar Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/skl: distribute DDB based on panel resolution

2018-07-31 Thread Chris Wilson
Quoting Mahesh Kumar (2018-07-31 15:24:45) > + for_each_new_crtc_in_state(state, crtc, crtc_state, i) { > + const struct drm_display_mode *adjusted_mode; > + int hdisplay, vdisplay; > + enum pipe pipe; > + > + if (!crtc_state->enable) >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915: make PCH_GMBUS* definitions private to gvt

2018-07-31 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] drm/i915: make PCH_GMBUS* definitions private to gvt URL : https://patchwork.freedesktop.org/series/47367/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4599 -> Patchwork_9821 = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-07-31 Thread Chris Wilson
Quoting Manasi Navare (2018-07-31 22:07:06) > + /* PPS 4 */ > + pps_sdp->pps_payload.pps_4 = (u8)((dsc_cfg->bits_per_pixel & > + DSC_PPS_BPP_HIGH_MASK) >> > + DSC_PPS_MSB_SHIFT) | To avoid overhanging

[Intel-gfx] [PATCH v2 23/23] drm/i915/dp: Disable DSC in source by disabling DSS CTL bits

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh 1. Disable Left/right VDSC branch in DSS Ctrl reg depending on the number of VDSC engines being used 2. Disable joiner in DSS Ctrl reg v5 (From Manasi): * Add Disable PG2 for VDSC on eDP v4: (From Manasi) * Rebase on top of revised patches v3 (From Manasi): * Use

[Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-07-31 Thread Manasi Navare
If a eDP panel supports both PSR2 and VDSC, our HW cannot support both at a time. Give priority to PSR2 if a requested resolution can be supported without compression else enable VDSC and keep PSR2 disabled. Cc: Rodrigo Vivi Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: Manasi Navare ---

[Intel-gfx] [PATCH v2 14/23] drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh DSC specification defines linebuf_depth which contains the line buffer bit depth used to generate the bitstream. These values are defined as per Table 4.1 in DSC 1.2 spec v2 (From Manasi): * Rename as MAX_LINEBUF_DEPTH for DSC 1.1 and DSC 1.2 Cc:

[Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh This patches does the following: 1. This patch defines all the DSC parameters as per the VESA DSC specification. These are stored in the encoder and used to compute the PPS parameters to be sent to the Sink. 2. Compute all the DSC parameters which are derived from DSC state

[Intel-gfx] [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-07-31 Thread Manasi Navare
According to Display Stream compression spec 1.2, the picture parameter set metadata is sent from source to sink device using the DP Secondary data packet. An infoframe is formed for the PPS SDP header and PPS SDP payload bytes. This patch adds helpers to fill the PPS SDP header and PPS SDP

[Intel-gfx] [PATCH v2 09/23] drm/dsc: Define Rate Control values that do not change over configurations

2018-07-31 Thread Manasi Navare
From: "Srivatsa, Anusha" DSC has some Rate Control values that remain constant across all configurations. These are as per the DSC standard. v3: * Define them in drm_dsc.h as they are DSC constants (Manasi) v2: * Add DP_DSC_ prefix (Jani Nikula) Cc: dri-de...@lists.freedesktop.org Cc: Manasi

[Intel-gfx] [PATCH v2 19/23] drm/i915/dp: Use the existing write_infoframe() for DSC PPS SDPs

2018-07-31 Thread Manasi Navare
Infoframes are used to send secondary data packets. This patch adds support for DSC Picture parameter set secondary data packets in the existing write_infoframe helpers. Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/i915_reg.h |

[Intel-gfx] [PATCH v2 04/23] drm/i915/dp: Add helpers for Compressed BPP and Slice Count for DSC

2018-07-31 Thread Manasi Navare
This patch adds helpers for calculating the maximum compressed BPP supported with small joiner. This also adds a helper for calculating the slice count in case of small joiner. These are inside intel_dp since they take into account hardware limitations. v5: * Get the max slice width from DPCD *

[Intel-gfx] [PATCH v2 21/23] drm/i915/icl: Add Display Stream Splitter control registers

2018-07-31 Thread Manasi Navare
From: "Srivatsa, Anusha" Add defines for DSS_CTL registers. These registers specify the big joiner, splitter, overlap pixels and info regarding display stream compression enabled on left or right branch. v2: - Add define to conditionally check the buffer target depth (James Ausmus)

[Intel-gfx] [PATCH v2 22/23] drm/i915/dp: Configure Display stream splitter registers during DSC enable

2018-07-31 Thread Manasi Navare
Display Stream Splitter registers need to be programmed to enable the joiner if two DSC engines are used and also to enable the left and the right DSC engines. This happens as part of the DSC enabling routine in the source in atomic commit. Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa

[Intel-gfx] [PATCH v2 11/23] drm/i915/dp: Add DSC params and DSC config to intel_crtc_state

2018-07-31 Thread Manasi Navare
Basic DSC parameters and DSC configuration data needs to be computed for each of the requested mode during atomic check. This is required since for certain modes, valid DSC parameters and config data might not be computed in which case compression cannot be enabled for that mode. For that reason

[Intel-gfx] [PATCH v2 16/23] drm/i915/dsc: Compute Rate Control parameters for DSC

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh This computation of RC params happens in the atomic commit phase during compute_config() to validate if display stream compression can be enabled for the requested mode. v5 (From Manasi): * Fix dim checkpatch warnings/checks v4(From Gaurav): * No change.Rebase on drm-tip

[Intel-gfx] [PATCH v2 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

2018-07-31 Thread Manasi Navare
This patch defines a new header file for all the DSC 1.2 structures and creates a structure for PPS infoframe which will be used to send picture parameter set secondary data packet for display stream compression. All the PPS infoframe syntax elements are taken from DSC 1.2 specification from VESA.

[Intel-gfx] [PATCH v2 20/23] drm/i915/dp: Populate DSC PPS SDP and send PPS infoframes

2018-07-31 Thread Manasi Navare
DSC PPS secondary data packet infoframes are filled with DSC picure parameter set metadata according to the DSC standard. These infoframes are sent to the sink device and used during DSC decoding. Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa Signed-off-by: Manasi Navare ---

[Intel-gfx] [PATCH v2 12/23] drm/i915/dp: Compute DSC pipe config in atomic check

2018-07-31 Thread Manasi Navare
DSC params like the enable, compressed bpp, slice ocunt and dsc_split are added to the intel_crtc_state. These parameters are set based on the requested mode and available link parameters during the pipe configuration in atomic check phase. These values are then later used to populate the

[Intel-gfx] [PATCH v2 03/23] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-07-31 Thread Manasi Navare
This patch adds inline functions and helpers for obtaining DP sink's supported DSC parameters like DSC sink support, eDP compressed BPP supported, maximum slice count supported by the sink devices, DSC line buffer bit depth supported on DP sink, DSC sink maximum color depth by parsing

[Intel-gfx] [PATCH v2 17/23] drm/i915/dp: Enable/Disable DSC in DP Sink

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh This patch enables decompression support in sink device before link training and disables the same during the DDI disabling. v2:(From Manasi) * Change the enable/disable function to take crtc_state instead of intel_dp as an argument (Manasi) * Use the compression_enable

[Intel-gfx] [PATCH v2 02/23] drm/i915/dp: Cache the DP/eDP DSC DPCD register set on Hotplug/eDP Init

2018-07-31 Thread Manasi Navare
DSC is supported on eDP starting GEN 10 display and on DP starting GEN 11. This patch implements the discovery phase of DSC. On hotplug, source reads the DSC DPCD register set (0x00060 - 0x006F) to read the decompression capabilities of the sink device. This entire block of registers is cached in

[Intel-gfx] [PATCH v2 08/23] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh This defines all the DSC parameters as per the VESA DSC spec that will be required for DSC encoder/decoder v4 (From Manasi) * Add the DSC_MUX_WORD_SIZE constants (Manasi) v3 (From Manasi) * Remove the duplicate define (Suggested By:Harry Wentland) v2: Define this struct

[Intel-gfx] [PATCH v2 05/23] drm/i915/dp: Validate modes using max Output BPP and slice count when DSC supported

2018-07-31 Thread Manasi Navare
When DSC is supported we need to validate the modes based on the maximum supported compressed BPP and maximum supported slice count. This allows us to allow the modes with pixel clock greater than the available link BW as long as it meets the compressed BPP and slice count requirements. v3: * Use

[Intel-gfx] [PATCH v2 18/23] drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling

2018-07-31 Thread Manasi Navare
After encoder->pre_enable() hook, after link training sequence is completed, PPS registers for DSC encoder are configured using the DSC state parameters in intel_crtc_state as part of DSC enabling routine in the source. DSC enabling routine is called after encoder->pre_enable() before enbaling the

[Intel-gfx] [PATCH v2 06/23] drm/dp: Define payload size for DP SDP PPS packet

2018-07-31 Thread Manasi Navare
DP 1.4 spec defines DP secondary data packet for DSC picture parameter set. This patch defines its payload size according to the DP 1.4 specification. Signed-off-by: Manasi Navare Cc: dri-de...@lists.freedesktop.org Cc: Gaurav K Singh Cc: Jani Nikula Cc: Ville Syrjala Cc: Anusha Srivatsa

[Intel-gfx] [PATCH v2 00/23] Display Stream Compression enabling on eDP/DP

2018-07-31 Thread Manasi Navare
Cc: dri-de...@lists.freedesktop.org VESA has developed an industry standard Display Stream Compression(DSC) for interoperable, visually lossless compression over display links to address the needs for higher resolution displays. This patch series enables DSC on Gen 10 eDP and Gen 11 eDP/DP

[Intel-gfx] [PATCH v2 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-07-31 Thread Manasi Navare
This patch defines the DP DSC receiver capability size that gives total number of DP DSC DPCD registers. This also adds a missing #defines for DP DSC support missed in the commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature") v3: * MIN_SLICE_WIDTH = 2560 (Anusha) * Define

[Intel-gfx] [PATCH] drm/i915: Drop stray clearing of rps->last_adj

2018-07-31 Thread Chris Wilson
We used to reset last_adj to 0 on crossing a power domain boundary, to slow down our rate of change. However, commit 60548c554be2 ("drm/i915: Interactive RPS mode") accidentally caused it to be reset on every frequency update, nerfing the fast response granted by the slow start algorithm. Fixes:

Re: [Intel-gfx] [PATCH 01/23] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-07-31 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Monday, July 30, 2018 7:13 PM >To: intel-gfx@lists.freedesktop.org >Cc: ville.syrj...@linux.intel.com; jani.nik...@linux.intel.com; Srivatsa, >Anusha >; Singh, Gaurav K ; >Navare, Manasi D ; dri- >de...@lists.freedesktop.org >Subject:

Re: [Intel-gfx] [PATCH v6 11/35] drm/i915: Enable and Disable of HDCP2.2

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

Re: [Intel-gfx] [RFC 1/3] drm: Add colorspace property

2018-07-31 Thread Adam Jackson
On Tue, 2018-07-24 at 21:15 +0530, Uma Shankar wrote: > --- a/include/uapi/drm/drm_mode.h > +++ b/include/uapi/drm/drm_mode.h > @@ -209,6 +209,17 @@ > #define DRM_MODE_CONTENT_PROTECTION_DESIRED 1 > #define DRM_MODE_CONTENT_PROTECTION_ENABLED 2 > > +enum extended_colorimetry { > +

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Dmitry Vyukov
On Tue, Jul 31, 2018 at 7:41 PM, Eric Dumazet wrote: > On Tue, Jul 31, 2018 at 10:36 AM Christopher Lameter wrote: > >> >> If there is refcounting going on then why use SLAB_TYPESAFE_BY_RCU? > > To allow fast reuse of objects, without going through call_rcu() and > reducing cache efficiency. > >

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Eric Dumazet
On Tue, Jul 31, 2018 at 10:10 AM Florian Westphal wrote: > > Andrey Ryabinin wrote: > > Guys, it seems that we have a lot of code using SLAB_TYPESAFE_BY_RCU cache > > without constructor. > > I think it's nearly impossible to use that combination without having bugs. > > It's either you don't

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Eric Dumazet
On Tue, Jul 31, 2018 at 10:51 AM Dmitry Vyukov wrote: > > > Is it OK to overwrite ct->status? It seems that are some read and > writes to it right after atomic_inc_not_zero. If it is after a (successful) atomic_inc_not_zero(), the object is guaranteed to be alive (not freed or about to be

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Florian Westphal
Andrey Ryabinin wrote: > Guys, it seems that we have a lot of code using SLAB_TYPESAFE_BY_RCU cache > without constructor. > I think it's nearly impossible to use that combination without having bugs. > It's either you don't really need the SLAB_TYPESAFE_BY_RCU, or you need to > have a

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Eric Dumazet
On Tue, Jul 31, 2018 at 10:36 AM Christopher Lameter wrote: > > If there is refcounting going on then why use SLAB_TYPESAFE_BY_RCU? To allow fast reuse of objects, without going through call_rcu() and reducing cache efficiency. I believe this is mentioned in Documentation/RCU/rculist_nulls.txt

Re: [Intel-gfx] Something is breaking the driver for me

2018-07-31 Thread Jamesie Pic
Hi all, It turned out my cable was defectuous. Keep up the great work and support, sorry for the noise on the list ! Cheers ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do not use iowait while waiting for the GPU

2018-07-31 Thread Francisco Jerez
Mika Kuoppala writes: > Chris Wilson writes: > >> A recent trend for cpufreq is to boost the CPU frequencies for >> iowaiters, in particularly to benefit high frequency I/O. We do the same >> and boost the GPU clocks to try and minimise time spent waiting for the >> GPU. However, as the igfx

Re: [Intel-gfx] [PATCH v6 09/35] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable Display Stream Compression on eDP/DP (rev2)

2018-07-31 Thread Patchwork
== Series Details == Series: Enable Display Stream Compression on eDP/DP (rev2) URL : https://patchwork.freedesktop.org/series/47461/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4599_full -> Patchwork_9820_full = == Summary - WARNING == Minor unknown changes coming

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Linus Torvalds
On Tue, Jul 31, 2018 at 10:49 AM Linus Torvalds wrote: > > So the re-use might initialize the fields lazily, not necessarily using a > ctor. In particular, the pattern that nf_conntrack uses looks like it is safe. If you have a well-defined refcount, and use "atomic_inc_not_zero()" to guard

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Display Stream Compression on eDP/DP (rev2)

2018-07-31 Thread Patchwork
== Series Details == Series: Enable Display Stream Compression on eDP/DP (rev2) URL : https://patchwork.freedesktop.org/series/47461/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4599 -> Patchwork_9820 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Display Stream Compression on eDP/DP (rev2)

2018-07-31 Thread Patchwork
== Series Details == Series: Enable Display Stream Compression on eDP/DP (rev2) URL : https://patchwork.freedesktop.org/series/47461/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Okay! Commit:

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Christopher Lameter
On Tue, 31 Jul 2018, Andrey Ryabinin wrote: > Guys, it seems that we have a lot of code using SLAB_TYPESAFE_BY_RCU cache > without constructor. > I think it's nearly impossible to use that combination without having bugs. > It's either you don't really need the SLAB_TYPESAFE_BY_RCU, or you need

Re: [Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Linus Torvalds
On Tue, Jul 31, 2018 at 10:36 AM Christopher Lameter wrote: > > If there is refcounting going on then why use SLAB_TYPESAFE_BY_RCU? .. because the object can be accessed (by RCU) after the refcount has gone down to zero, and the thing has been released. That's the whole and only point of

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Display Stream Compression on eDP/DP (rev2)

2018-07-31 Thread Patchwork
== Series Details == Series: Enable Display Stream Compression on eDP/DP (rev2) URL : https://patchwork.freedesktop.org/series/47461/ State : warning == Summary == $ dim checkpatch origin/drm-tip 27c39427ec85 drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

[Intel-gfx] [PATCH v2] drm/i915/dp: Compute DSC pipe config in atomic check

2018-07-31 Thread Manasi Navare
DSC params like the enable, compressed bpp, slice ocunt and dsc_split are added to the intel_crtc_state. These parameters are set based on the requested mode and available link parameters during the pipe configuration in atomic check phase. These values are then later used to populate the

[Intel-gfx] SLAB_TYPESAFE_BY_RCU without constructors (was Re: [PATCH v4 13/17] khwasan: add hooks implementation)

2018-07-31 Thread Andrey Ryabinin
On 07/31/2018 07:04 PM, Andrey Ryabinin wrote: >> Somewhat offtopic, but I can't understand how SLAB_TYPESAFE_BY_RCU >> slabs can be useful without ctors or at least memset(0). Objects in >> such slabs need to be type-stable, but I can't understand how it's >> possible to establish type stability

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/skl: distribute DDB based on panel resolution (rev2)

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915/skl: distribute DDB based on panel resolution (rev2) URL : https://patchwork.freedesktop.org/series/47428/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4598_full -> Patchwork_9819_full = == Summary - SUCCESS == No regressions

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/skl: distribute DDB based on panel resolution (rev2)

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915/skl: distribute DDB based on panel resolution (rev2) URL : https://patchwork.freedesktop.org/series/47428/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4598 -> Patchwork_9819 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Interactive RPS mode (rev5)

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915: Interactive RPS mode (rev5) URL : https://patchwork.freedesktop.org/series/46334/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4597_full -> Patchwork_9818_full = == Summary - SUCCESS == No regressions found. == Known issues

[Intel-gfx] [PATCH v2 2/2] drm/i915/skl: distribute DDB based on panel resolution

2018-07-31 Thread Mahesh Kumar
We distribute DDB equally among all pipes irrespective of display buffer requirement of each pipe. This leads to a situation where high resolution y-tiled display can not be enabled with 2 low resolution displays. Main contributing factor for DDB requirement is width of the display. This patch

[Intel-gfx] [PATCH v1 1/2] drm/i915: ddb_size is of u16 type

2018-07-31 Thread Mahesh Kumar
ddb_size is u16 so use same return type for intel_get_ddb_size wrapper. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_pm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

[Intel-gfx] [PATCH v2 0/2] distribute DDB based on panel resolution

2018-07-31 Thread Mahesh Kumar
This series make changes to distribute DDB based on resolution of panel instead of dividing equally among pipes. Mahesh Kumar (2): drm/i915: ddb_size is of u16 type drm/i915/skl: distribute DDB based on panel resolution drivers/gpu/drm/i915/intel_pm.c | 66

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Implement 16GB dimm wa for latency level-0

2018-07-31 Thread Kumar, Mahesh
Hi, On 7/28/2018 11:18 AM, Rodrigo Vivi wrote: On Fri, Jul 27, 2018 at 11:40:14AM +0530, Kumar, Mahesh wrote: Hi Matt, On 7/27/2018 9:21 AM, Matt Turner wrote: On Thu, Jul 26, 2018 at 7:14 AM, Mahesh Kumar wrote: Bspec: 4381 Do we know that these numbers are stable? yes these numbers

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Interactive RPS mode (rev5)

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915: Interactive RPS mode (rev5) URL : https://patchwork.freedesktop.org/series/46334/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4597 -> Patchwork_9818 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] [PATCH 2/2] drm/i915/psr: Add debugfs support to force toggling PSR1/2 mode.

2018-07-31 Thread Maarten Lankhorst
This will make it easier to test PSR1 on PSR2 capable eDP machines. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_psr.c | 27 --- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 1/2] drm/i915: Allow control of PSR at runtime through debugfs, v4.

2018-07-31 Thread Maarten Lankhorst
Currently tests modify i915.enable_psr and then do a modeset cycle to change PSR. We can write a value to i915_edp_psr_debug to force a certain PSR mode without a modeset. To retain compatibility with older userspace, we also still allow the override through the module parameter, and add some

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Interactive RPS mode (rev5)

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915: Interactive RPS mode (rev5) URL : https://patchwork.freedesktop.org/series/46334/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Interactive RPS mode -O:drivers/gpu/drm/i915/i915_irq.c:1265:22: warning: expression using

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Interactive RPS mode (rev5)

2018-07-31 Thread Patchwork
== Series Details == Series: drm/i915: Interactive RPS mode (rev5) URL : https://patchwork.freedesktop.org/series/46334/ State : warning == Summary == $ dim checkpatch origin/drm-tip 93827b4e697a drm/i915: Interactive RPS mode -:27: ERROR:GIT_COMMIT_ID: Please use git commit description style

[Intel-gfx] [PATCH] drm/i915: Interactive RPS mode

2018-07-31 Thread Chris Wilson
RPS provides a feedback loop where we use the load during the previous evaluation interval to decide whether to up or down clock the GPU frequency. Our responsiveness is split into 3 regimes, a high and low plateau with the intent to keep the gpu clocked high to cover occasional stalls under high

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do not use iowait while waiting for the GPU

2018-07-31 Thread Mika Kuoppala
Chris Wilson writes: > A recent trend for cpufreq is to boost the CPU frequencies for > iowaiters, in particularly to benefit high frequency I/O. We do the same > and boost the GPU clocks to try and minimise time spent waiting for the > GPU. However, as the igfx and CPU share the same TDP,

Re: [Intel-gfx] [PATCH] drm/i915: Interactive RPS mode

2018-07-31 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-07-23 13:01:00) > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -784,6 +784,8 @@ struct intel_rps { > > int last_adj; > enum { LOW_POWER, BETWEEN, HIGH_POWER } power; > + unsigned int interactive; > + struct mutex power_lock; Please describe

Re: [Intel-gfx] [PATCH] firmware/dmc/icl: load v1.07 on icelake.

2018-07-31 Thread Imre Deak
On Mon, Jul 30, 2018 at 04:57:11PM -0700, Anusha Srivatsa wrote: > Add Support to load DMC on Icelake. > > Cc: Rodrigo Vivi > Cc: Paulo Zanoni > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/i915/intel_csr.c | 7 +++ > 1 file changed, 7 insertions(+) the firmware also needs to

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Terminate the context image with BB_END

2018-07-31 Thread Lionel Landwerlin
On 30/07/18 17:43, Chris Wilson wrote: In the aub trace utility, the context images are terminated with a MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise. Do the same for our protocontext image for completeness, and in passing apply the magic bit for gen10 to mark the end

Re: [Intel-gfx] [PATCH v6 06/35] drm/i915: Define Intel HDCP2.2 registers

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

Re: [Intel-gfx] [PATCH v6 05/35] drm/i915: wrapping all hdcp var into intel_hdcp

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

Re: [Intel-gfx] [PATCH v6 04/35] linux/mei: Header for mei_hdcp driver interface

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

Re: [Intel-gfx] [PATCH v6 02/35] drm: HDMI and DP specific HDCP2.2 defines

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: C, Ramalingam >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >; Usyskin, Alexander ; >Shankar, Uma >Cc: Sharma, Shashank ; C, Ramalingam >

Re: [Intel-gfx] [PATCH v6 01/35] drm: hdcp2.2 authentication msg definitions

2018-07-31 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ramalingam C >Sent: Saturday, July 14, 2018 8:45 AM >To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dan...@ffwll.ch; seanp...@chromium.org; Winkler, Tomas >;

Re: [Intel-gfx] [PATCH] drm/i915/skl: distribute DDB based on panel resolution

2018-07-31 Thread Kumar, Mahesh
Hi Chris, Thanks for review. On 7/30/2018 9:08 PM, Chris Wilson wrote: Quoting Mahesh Kumar (2018-07-30 15:12:02) We distribute DDB equally among all pipes irrespective of display buffer requirement of each pipe. This leads to a situation where high resolution y-tiled display can not be