[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Add a small wrapper to check for CCS modifiers.

2018-08-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add a small wrapper to check for CCS modifiers. URL : https://patchwork.freedesktop.org/series/48524/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4695_full -> Patchwork_9986_full = == Summary - SUCCESS ==

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Add a small wrapper to check for CCS modifiers.

2018-08-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Add a small wrapper to check for CCS modifiers. URL : https://patchwork.freedesktop.org/series/48524/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4695 -> Patchwork_9986 = == Summary - SUCCESS == No

Re: [Intel-gfx] [CI 1/3] drm/i915/psr: Print PSR_STATUS when PSR idle wait times out.

2018-08-21 Thread Dhinakaran Pandiyan
On Tue, 2018-08-21 at 15:11 -0700, Dhinakaran Pandiyan wrote: > Knowing the status of the PSR HW state machine is useful for debug, > especially since we are seeing errors with PSR2 in CI. > > Cc: José Roberto de Souza > Cc: Rodrigo Vivi > Signed-off-by: Dhinakaran Pandiyan > Reviewed-by:

[Intel-gfx] [PATCH 2/2] drm/i915: Rename PLANE_CTL_DECOMPRESSION_ENABLE

2018-08-21 Thread Dhinakaran Pandiyan
Rename PLANE_CTL_DECOMPRESSION_ENABLE to resemble the bpsec name - PLANE_CTL_RENDER_DECOMPRESSION_ENABLE Suggested-by: Rodrigo Vivi Cc: Daniel Vetter Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_display.c | 8 2 files

[Intel-gfx] [PATCH 1/2] drm/i915: Add a small wrapper to check for CCS modifiers.

2018-08-21 Thread Dhinakaran Pandiyan
Code looks cleaner with modifiers hidden inside this wrapper. Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/intel_display.c | 21 +++-- drivers/gpu/drm/i915/intel_display.h | 1 + drivers/gpu/drm/i915/intel_sprite.c | 3 +-- 3 files changed, 13 insertions(+), 12

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/psr: Print PSR_STATUS when PSR idle wait times out.

2018-08-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/psr: Print PSR_STATUS when PSR idle wait times out. URL : https://patchwork.freedesktop.org/series/48520/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4694_full -> Patchwork_9985_full = == Summary -

Re: [Intel-gfx] [PATCH 1/5] drm/dp/fec: DRM helper for Forward Error Correction

2018-08-21 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Monday, August 20, 2018 12:32 PM >To: Jani Nikula >Cc: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org; Ville Syrjala >Subject: Re: [PATCH 1/5] drm/dp/fec: DRM helper for Forward Error Correction > >Hi Jani, > >Thanks for your

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/psr: Print PSR_STATUS when PSR idle wait times out.

2018-08-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/psr: Print PSR_STATUS when PSR idle wait times out. URL : https://patchwork.freedesktop.org/series/48520/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4694 -> Patchwork_9985 = == Summary - SUCCESS ==

[Intel-gfx] [CI 3/3] drm/i915/psr: Mask PSR irq bits when re-enabling interrupts.

2018-08-21 Thread Dhinakaran Pandiyan
gen8_de_irq_postinstall() wasn't masking the IRQ bit before passing the debug flag to psr_irq_control(). This check was missed when new debug bits were defined in 'commit c44301fce614 ("drm/i915: Allow control of PSR at runtime through debugfs, v6")'. Instead of ANDing the irq bit in all the

[Intel-gfx] [CI 2/3] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-21 Thread Dhinakaran Pandiyan
We print the last attempted entry and last exit timestamps only when IRQ debug is requested. This check was missed when new debug flags were added in 'commit c44301fce614 ("drm/i915: Allow control of PSR at runtime through debugfs, v6") Fixes: c44301fce614 ("drm/i915: Allow control of PSR at

[Intel-gfx] [CI 1/3] drm/i915/psr: Print PSR_STATUS when PSR idle wait times out.

2018-08-21 Thread Dhinakaran Pandiyan
Knowing the status of the PSR HW state machine is useful for debug, especially since we are seeing errors with PSR2 in CI. Cc: José Roberto de Souza Cc: Rodrigo Vivi Signed-off-by: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_drv.h| 3 ++-

Re: [Intel-gfx] [PATCH 1/4] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-21 Thread Paulo Zanoni
Em Ter, 2018-08-21 às 14:12 +0300, Imre Deak escreveu: > On Mon, Aug 20, 2018 at 04:11:27PM -0700, Paulo Zanoni wrote: > > Em Sex, 2018-08-17 às 16:41 -0700, Paulo Zanoni escreveu: > > > Em Qua, 2018-08-15 às 23:27 +0300, Imre Deak escreveu: > > > > On Wed, Aug 08, 2018 at 03:16:11PM -0700, Paulo

Re: [Intel-gfx] [PATCH 4/5] drm/i915/kbl+: Enable IPC only for symmetric memory configurations

2018-08-21 Thread Rodrigo Vivi
On Tue, Aug 21, 2018 at 09:30:21PM +0530, Kumar, Mahesh wrote: > Hi, > > > On 8/21/2018 8:27 PM, Kumar, Mahesh wrote: > > Hi, > > > > > > On 8/17/2018 11:50 PM, Rodrigo Vivi wrote: > > > On Thu, Jul 26, 2018 at 07:44:09PM +0530, Mahesh Kumar wrote: > > > > IPC may cause underflows if not used

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread John Stultz
On Tue, Aug 21, 2018 at 7:59 AM, Noralf Trønnes wrote: > Den 21.08.2018 10.44, skrev Daniel Vetter: >> On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: >>> >>> Since we don't have a drm_gem_cma_object reference in >>> drm_fb_helper_generic_probe(), I instead added: >>>

Re: [Intel-gfx] [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs

2018-08-21 Thread Dhinakaran Pandiyan
On Mon, 2018-08-20 at 16:42 -0700, Azhar Shaikh wrote: > Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file > i915_edp_psr_status. > > Signed-off-by: Azhar Shaikh > --- > Changes in v3: > - rebased > > Changes in v2: > - Fix checkpatch warning. > - Add Reviewed-by: from v1 > >

Re: [Intel-gfx] [PATCH i-g-t] Skip VBlank tests in modules without VBlank

2018-08-21 Thread Rodrigo Siqueira
On 08/21, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2018-08-21 15:29:03) > > On 08/21, Chris Wilson wrote: > > > Quoting Rodrigo Siqueira (2018-08-21 00:54:45) > > > > The kms_flip test does not support drivers without VBlank which exclude > > > > some virtual drivers. This patch adds a

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 6:03 PM, Noralf Trønnes wrote: > > Den 21.08.2018 17.41, skrev Daniel Vetter: >> >> On Tue, Aug 21, 2018 at 04:59:46PM +0200, Noralf Trønnes wrote: >>> >>> Den 21.08.2018 10.44, skrev Daniel Vetter: On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote:

Re: [Intel-gfx] [PATCH 1/5] drm/dp/fec: DRM helper for Forward Error Correction

2018-08-21 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Monday, August 20, 2018 12:32 PM >To: Jani Nikula >Cc: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org; Ville Syrjala >Subject: Re: [PATCH 1/5] drm/dp/fec: DRM helper for Forward Error Correction > >Hi Jani, > >Thanks for your

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Noralf Trønnes
Den 21.08.2018 17.41, skrev Daniel Vetter: On Tue, Aug 21, 2018 at 04:59:46PM +0200, Noralf Trønnes wrote: Den 21.08.2018 10.44, skrev Daniel Vetter: On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: This switches the CMA

Re: [Intel-gfx] [PATCH 4/5] drm/i915/kbl+: Enable IPC only for symmetric memory configurations

2018-08-21 Thread Kumar, Mahesh
Hi, On 8/21/2018 8:27 PM, Kumar, Mahesh wrote: Hi, On 8/17/2018 11:50 PM, Rodrigo Vivi wrote: On Thu, Jul 26, 2018 at 07:44:09PM +0530, Mahesh Kumar wrote: IPC may cause underflows if not used with dual channel symmetric memory configuration. Disable IPC for non symmetric configurations in

Re: [Intel-gfx] [PATCH V2 4/4] drm/crc: add pre_crc_read function

2018-08-21 Thread Rodrigo Vivi
On Tue, Aug 21, 2018 at 02:08:58PM +0530, Mahesh Kumar wrote: > This patch implements a callback function which will be called before > crc read. In this function driver can implement any preparation work > required for successfully reading CRC data. > > Changes Since V1: > - rebase > > Cc:

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 04:59:46PM +0200, Noralf Trønnes wrote: > > Den 21.08.2018 10.44, skrev Daniel Vetter: > > On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: > > > On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > > > > This switches the CMA helper drivers that use its

Re: [Intel-gfx] [PATCH i-g-t] Skip VBlank tests in modules without VBlank

2018-08-21 Thread Chris Wilson
Quoting Rodrigo Siqueira (2018-08-21 15:29:03) > On 08/21, Chris Wilson wrote: > > Quoting Rodrigo Siqueira (2018-08-21 00:54:45) > > > The kms_flip test does not support drivers without VBlank which exclude > > > some virtual drivers. This patch adds a function that checks if a module > > > has a

Re: [Intel-gfx] [PATCH 1/5] drm/i915/bxt: Decode memory bandwidth and parameters

2018-08-21 Thread Rodrigo Vivi
On Tue, Aug 21, 2018 at 03:23:06PM +0530, Kumar, Mahesh wrote: > Hi, > > > On 8/17/2018 11:13 PM, Rodrigo Vivi wrote: > > On Thu, Jul 26, 2018 at 07:44:06PM +0530, Mahesh Kumar wrote: > > > This patch adds support to decode system memory bandwidth and other > > > parameters for broxton platform,

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Noralf Trønnes
Den 21.08.2018 10.44, skrev Daniel Vetter: On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: This switches the CMA helper drivers that use its fbdev emulation over to the generic fbdev emulation. It's the first phase of using

Re: [Intel-gfx] [PATCH 4/5] drm/i915/kbl+: Enable IPC only for symmetric memory configurations

2018-08-21 Thread Kumar, Mahesh
Hi, On 8/17/2018 11:50 PM, Rodrigo Vivi wrote: On Thu, Jul 26, 2018 at 07:44:09PM +0530, Mahesh Kumar wrote: IPC may cause underflows if not used with dual channel symmetric memory configuration. Disable IPC for non symmetric configurations in affected platforms. Display WA #1141

Re: [Intel-gfx] [PATCH V3 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-21 Thread Haneen Mohammed
On Tue, Aug 21, 2018 at 10:04:01AM +0530, Mahesh Kumar wrote: > This patch implements "verify_crc_source" callback function for > Virtual KMS drm driver. > > Changes Since V1: > - update values_cnt in verify_crc_source > Changes Since V2: > - don't return early from set_crc_source to keep

Re: [Intel-gfx] [PATCH V2 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-21 Thread Haneen Mohammed
On Tue, Aug 21, 2018 at 09:53:11AM +0530, Kumar, Mahesh wrote: > Hi Haneen, > > > On 8/21/2018 4:09 AM, Haneen Mohammed wrote: > > On Tue, Aug 14, 2018 at 08:31:03AM +0530, Mahesh Kumar wrote: > > > This patch implements "verify_crc_source" callback function for > > > Virtual KMS drm driver. > >

Re: [Intel-gfx] [PATCH V2 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-21 Thread Haneen Mohammed
On Tue, Aug 14, 2018 at 08:31:03AM +0530, Mahesh Kumar wrote: > This patch implements "verify_crc_source" callback function for > Virtual KMS drm driver. > > Changes Since V1: > - update values_cnt in verify_crc_source > > Cc: Haneen Mohammed > Signed-off-by: Mahesh Kumar > --- >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: preparations for enabling P010, P012, P016 formats

2018-08-21 Thread Sharma, Swati2
On 16-Aug-18 6:25 PM, Juha-Pekka Heikkila wrote: Preparations for enabling P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 3 +-

Re: [Intel-gfx] [PATCH i-g-t] Skip VBlank tests in modules without VBlank

2018-08-21 Thread Rodrigo Siqueira
On 08/21, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2018-08-21 00:54:45) > > The kms_flip test does not support drivers without VBlank which exclude > > some virtual drivers. This patch adds a function that checks if a module > > has a VBlank or not; if a module has VBlank than kms_flip will

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Noralf Trønnes
Den 21.08.2018 08.44, skrev John Stultz: On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: This switches the CMA helper drivers that use its fbdev emulation over to the generic fbdev emulation. It's the first phase of using generic fbdev. A later phase will use DRM client callbacks for

Re: [Intel-gfx] [PATCH i-g-t 2/2] Add support for forcing specific module

2018-08-21 Thread Rodrigo Siqueira
On 08/21, Petri Latvala wrote: > On Sat, Jul 07, 2018 at 08:25:07PM -0300, Rodrigo Siqueira wrote: > > This commit adds a new option for forcing the use of a specific module > > indicated via command line. The force command expects a module name > > which will be used on the target test (changing

Re: [Intel-gfx] [PATCH i-g-t 1/2] Increase the string size for a module name

2018-08-21 Thread Rodrigo Siqueira
On 08/21, Petri Latvala wrote: > On Sat, Jul 07, 2018 at 08:24:39PM -0300, Rodrigo Siqueira wrote: > > Some modules name are larger than 5 characters, this can be a problem to > > add support for other modules. This patch, increase the maximum size in > > order to enable other modules to use IGT.

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: preparations for enabling P010, P012, P016 formats

2018-08-21 Thread Sharma, Swati2
Hi Juha, Shouldn't the following DRM_DEBUG_KMS DRM_DEBUG_KMS("NV12: src dimensions not met\n"); be made generalized and not specific to NV12? On 12-Jun-18 4:46 PM, Juha-Pekka Heikkila wrote: Preparations for enabling P010, P012 and P016 formats. These formats will extend NV12 for larger bit

Re: [Intel-gfx] [PATCH i-g-t V2] tests/kms_cursor_crc: Open DRM device with DRIVER_ANY

2018-08-21 Thread Daniel Vetter
On Thu, Aug 16, 2018 at 11:56:55PM +0300, Haneen Mohammed wrote: > So that this test can be run in drivers other than i915. > Remove devid and only check it if the driver is i915. > > Signed-off-by: Haneen Mohammed > --- > changes in v2: > - return false for has_nonsquare_cursors() when driver

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tracepoints: Remove DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig option

2018-08-21 Thread Joonas Lahtinen
Quoting Kukanova, Svetlana (2018-08-13 16:44:49) > Joonas, sorry for interfering; could you please explain more regarding the > options for tracing scheduling events better than tracepoints? > After scheduling moves to GuC tools will have to switch to something like > GuC-logging; but while kmd

[Intel-gfx] [PATCH] [intel-gfx][igt-dev] tests/pm_backlight.c : Brightness test with DPMS and System suspend.

2018-08-21 Thread Yadav Jyoti
From: Jyoti Yadav BIOS programs few of PWM related registers during initial boot. But during System suspend those registers are cleared. This test aims to check whether display programs those registers properly after system resume. Also checks brightness programming during

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Correct CSB probing for engine state dumper (rev2)

2018-08-21 Thread Patchwork
== Series Details == Series: drm/i915: Correct CSB probing for engine state dumper (rev2) URL : https://patchwork.freedesktop.org/series/48381/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692_full -> Patchwork_9984_full = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-21 Thread Imre Deak
On Mon, Aug 20, 2018 at 04:11:27PM -0700, Paulo Zanoni wrote: > Em Sex, 2018-08-17 às 16:41 -0700, Paulo Zanoni escreveu: > > Em Qua, 2018-08-15 às 23:27 +0300, Imre Deak escreveu: > > > On Wed, Aug 08, 2018 at 03:16:11PM -0700, Paulo Zanoni wrote: > > > > Use the same coding pattern as we use in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Correct CSB probing for engine state dumper (rev2)

2018-08-21 Thread Patchwork
== Series Details == Series: drm/i915: Correct CSB probing for engine state dumper (rev2) URL : https://patchwork.freedesktop.org/series/48381/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692 -> Patchwork_9984 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH 2/5] drm/i915/skl+: Decode memory bandwidth and parameters

2018-08-21 Thread Kumar, Mahesh
Hi, On 8/17/2018 4:05 AM, Rodrigo Vivi wrote: On Thu, Jul 26, 2018 at 07:44:07PM +0530, Mahesh Kumar wrote: This patch adds support to decode system memory bandwidth and other parameters for skylake and Gen9+ platforms, which will be used for arbitrated display memory bandwidth calculation in

Re: [Intel-gfx] [PATCH i-g-t] Skip VBlank tests in modules without VBlank

2018-08-21 Thread Chris Wilson
Quoting Rodrigo Siqueira (2018-08-21 00:54:45) > The kms_flip test does not support drivers without VBlank which exclude > some virtual drivers. This patch adds a function that checks if a module > has a VBlank or not; if a module has VBlank than kms_flip will execute > all the VBlank tests,

[Intel-gfx] [CI] drm/i915: Correct CSB probing for engine state dumper

2018-08-21 Thread Chris Wilson
Since we no longer maintain our read position in the CSB pointers register, it always returns 0 and not where we last read up to. As a result the CSB probing in the state dumper starts from 0, either missing entries or showing stale one. Signed-off-by: Chris Wilson Cc: Mika Kuoppala

Re: [Intel-gfx] [RFC v4 7/8] drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:50PM +0530, Uma Shankar wrote: > Implement Plane Gamma feature for BDW and Gen9 platforms. > > v2: Used newly added drm_color_lut_ext structure for enhanced > precision for Gamma LUT entries. > > v3: Rebase > > Signed-off-by: Uma Shankar > --- >

Re: [Intel-gfx] [PATCH 1/5] drm/i915/bxt: Decode memory bandwidth and parameters

2018-08-21 Thread Kumar, Mahesh
Hi, On 8/17/2018 11:13 PM, Rodrigo Vivi wrote: On Thu, Jul 26, 2018 at 07:44:06PM +0530, Mahesh Kumar wrote: This patch adds support to decode system memory bandwidth and other parameters for broxton platform, which will be used for arbitrated display memory bandwidth calculation in GEN9

[Intel-gfx] ✓ Fi.CI.IGT: success for Improve crc-core driver interface (rev14)

2018-08-21 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev14) URL : https://patchwork.freedesktop.org/series/45246/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692_full -> Patchwork_9983_full = == Summary - SUCCESS == No regressions found. == Known

Re: [Intel-gfx] [RFC v4 5/8] drm: Define helper function for plane color enabling

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:48PM +0530, Uma Shankar wrote: > Define helper function to enable Plane color features > to attach plane color properties to plane structure. > > v2: Rebase > > v3: Modiefied the function to use updated property names. > > v4: Rebase > > Signed-off-by:

Re: [Intel-gfx] [PATCH i-g-t 2/2] Add support for forcing specific module

2018-08-21 Thread Petri Latvala
On Sat, Jul 07, 2018 at 08:25:07PM -0300, Rodrigo Siqueira wrote: > This commit adds a new option for forcing the use of a specific module > indicated via command line. The force command expects a module name > which will be used on the target test (changing the standard behavior). > >

Re: [Intel-gfx] [RFC v4 4/8] drm: Add Plane Gamma properties

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:47PM +0530, Uma Shankar wrote: > Add plane gamma as blob property and size as a > range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to instantiate > these

Re: [Intel-gfx] [RFC v4 3/8] drm: Add Plane CTM property

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:46PM +0530, Uma Shankar wrote: > Add a blob property for plane CSC usage. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to instantiate > these properties and removed

Re: [Intel-gfx] [RFC v4 2/8] drm: Add Plane Degamma properties

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:45PM +0530, Uma Shankar wrote: > Add Plane Degamma as a blob property and plane degamma size as > a range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to

Re: [Intel-gfx] [RFC v4 1/8] drm: Add Enhanced Gamma LUT precision structure

2018-08-21 Thread Alexandru-Cosmin Gheorghe
Hi Uma, On Fri, Aug 17, 2018 at 07:48:44PM +0530, Uma Shankar wrote: > Existing LUT precision structure is having only 16 bit > precision. This is not enough for upcoming enhanced hardwares > and advance usecases like HDR processing. Hence added a new > structure with 32 bit precision values.

Re: [Intel-gfx] [PATCH i-g-t 1/2] Increase the string size for a module name

2018-08-21 Thread Petri Latvala
On Sat, Jul 07, 2018 at 08:24:39PM -0300, Rodrigo Siqueira wrote: > Some modules name are larger than 5 characters, this can be a problem to > add support for other modules. This patch, increase the maximum size in > order to enable other modules to use IGT. > > Signed-off-by: Rodrigo Siqueira >

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve crc-core driver interface (rev14)

2018-08-21 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev14) URL : https://patchwork.freedesktop.org/series/45246/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692 -> Patchwork_9983 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Daniel Vetter
On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: > On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > > This switches the CMA helper drivers that use its fbdev emulation over > > to the generic fbdev emulation. It's the first phase of using generic > > fbdev. A later phase will

[Intel-gfx] [PATCH V5 2/4] drm/crc: Cleanup crtc_crc_open function

2018-08-21 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source.

[Intel-gfx] [PATCH V2 4/4] drm/crc: add pre_crc_read function

2018-08-21 Thread Mahesh Kumar
This patch implements a callback function which will be called before crc read. In this function driver can implement any preparation work required for successfully reading CRC data. Changes Since V1: - rebase Cc: dri-de...@lists.freedesktop.org Signed-off-by: Mahesh Kumar ---

[Intel-gfx] [PATCH V3 1/4] drm/vkms/crc: Implement verify_crc_source callback

2018-08-21 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Changes Since V2: - don't return early from set_crc_source to keep behavior same (Haneen) Cc: Haneen Mohammed Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 0/4] Improve crc-core driver interface

2018-08-21 Thread Mahesh Kumar
This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup

[Intel-gfx] [PATCH V4 3/4] Revert "drm: crc: Wait for a frame before returning from open()"

2018-08-21 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

Re: [Intel-gfx] linux-next: manual merge of the mfd tree with the drm-intel tree

2018-08-21 Thread Stephen Rothwell
Hi Geert, On Tue, 21 Aug 2018 10:27:48 +0200 Geert Uytterhoeven wrote: > > FTR, it's not this one, but the similar one reported on Jul 19, which does not > add the tc_port_type enum. Right, sorry about that. Linus has now merged the mfd tree so things are probably done now. -- Cheers,

Re: [Intel-gfx] linux-next: manual merge of the mfd tree with the drm-intel tree

2018-08-21 Thread Geert Uytterhoeven
On Thu, Aug 16, 2018 at 8:05 PM Stephen Rothwell wrote: > On Thu, 26 Jul 2018 15:10:06 +1000 Stephen Rothwell > wrote: > > Today's linux-next merge of the mfd tree got a conflict in: > > > > drivers/gpu/drm/i915/intel_display.h > > > > between commit: > > > > 6075546f57f8 ("drm/i915/icl:

Re: [Intel-gfx] [PATCH] drm/i915: Correct CSB probing for engine state dumper

2018-08-21 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-21 08:58:26) > Chris Wilson writes: > > > Since we no longer maintain our read position in the CSB pointers > > register, it always returns 0 and not where we last read up to. As a > > result the CSB probing in the state dumper starts from 0, either missing > >

Re: [Intel-gfx] [PATCH] drm/i915: Correct CSB probing for engine state dumper

2018-08-21 Thread Mika Kuoppala
Chris Wilson writes: > Since we no longer maintain our read position in the CSB pointers > register, it always returns 0 and not where we last read up to. As a > result the CSB probing in the state dumper starts from 0, either missing > entries or showing stale one. > > Signed-off-by: Chris

[Intel-gfx] [PATCH i-g-t] [intel-gfx] [igt-dev] tests/pm_backlight.c : Brightness test with DPMS and System suspend.

2018-08-21 Thread Yadav Jyoti
From: Jyoti Yadav BIOS programs few of PWM related registers during initial boot. But during System suspend those registers are cleared. This test aims to check whether display programs those registers properly after system resume. Also checks brightness programming during

[Intel-gfx] ✓ Fi.CI.IGT: success for Improve crc-core driver interface (rev13)

2018-08-21 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev13) URL : https://patchwork.freedesktop.org/series/45246/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692_full -> Patchwork_9982_full = == Summary - SUCCESS == No regressions found. == Known

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread John Stultz
On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > This switches the CMA helper drivers that use its fbdev emulation over > to the generic fbdev emulation. It's the first phase of using generic > fbdev. A later phase will use DRM client callbacks for the > lastclose/hotplug/remove callbacks.

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve crc-core driver interface (rev13)

2018-08-21 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev13) URL : https://patchwork.freedesktop.org/series/45246/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692 -> Patchwork_9982 = == Summary - SUCCESS == No regressions found. External URL: