== Series Details ==
Series: series starting with [01/23] drm/i915: Reduce context HW ID lifetime
URL : https://patchwork.freedesktop.org/series/49157/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4769_full -> Patchwork_10086_full =
== Summary - SUCCESS ==
No
== Series Details ==
Series: drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl
URL : https://patchwork.freedesktop.org/series/49150/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4769_full -> Patchwork_10085_full =
== Summary - SUCCESS ==
No regressions
On Tue, 2018-09-04 at 16:19 -0700, Rodrigo Vivi wrote:
> On Tue, Sep 04, 2018 at 03:53:51PM -0700, Dhinakaran Pandiyan wrote:
> > On Tuesday, September 4, 2018 5:54:16 AM PDT Imre Deak wrote:
> > > On Tue, Sep 04, 2018 at 03:08:16PM +0300, Jani Nikula wrote:
> > > > On Fri, 31 Aug 2018, Imre Deak
On SKL+ the linear source buffer has to start from cache line boundary
to meet the 2d engine source copy requirements. Apply this cache line
alignment policy for SKL+ only.
v2: Apply these changes only to SKL+ for not breaking old platforms
based on Chris Wilson's reviews.
Cc: Chris Wilson
== Series Details ==
Series: drm/i915: Be defensive and don't assume PSR has any commit to sync
against
URL : https://patchwork.freedesktop.org/series/49141/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4767_full -> Patchwork_10084_full =
== Summary - SUCCESS ==
No
On Tue, Sep 04, 2018 at 03:53:51PM -0700, Dhinakaran Pandiyan wrote:
> On Tuesday, September 4, 2018 5:54:16 AM PDT Imre Deak wrote:
> > On Tue, Sep 04, 2018 at 03:08:16PM +0300, Jani Nikula wrote:
> > > On Fri, 31 Aug 2018, Imre Deak wrote:
> > > > commit afb2c4437dae ("drm/i915/ddi: Push pipe
== Series Details ==
Series: igt/pm_rpm: Reload the module with full mmio debugging
URL : https://patchwork.freedesktop.org/series/49138/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4625_full -> IGTPW_1785_full =
== Summary - SUCCESS ==
No regressions found.
External
On Tuesday, September 4, 2018 5:54:16 AM PDT Imre Deak wrote:
> On Tue, Sep 04, 2018 at 03:08:16PM +0300, Jani Nikula wrote:
> > On Fri, 31 Aug 2018, Imre Deak wrote:
> > > commit afb2c4437dae ("drm/i915/ddi: Push pipe clock enabling to
> > > encoders")
> > > inadvertently stopped enabling the
== Series Details ==
Series: series starting with [01/23] drm/i915: Reduce context HW ID lifetime
URL : https://patchwork.freedesktop.org/series/49157/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4769 -> Patchwork_10086 =
== Summary - SUCCESS ==
No regressions found.
== Series Details ==
Series: drm/i915: Reduce context HW ID lifetime (rev3)
URL : https://patchwork.freedesktop.org/series/44134/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4767_full -> Patchwork_10083_full =
== Summary - WARNING ==
Minor unknown changes coming with
== Series Details ==
Series: series starting with [01/23] drm/i915: Reduce context HW ID lifetime
URL : https://patchwork.freedesktop.org/series/49157/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915: Reduce context HW ID lifetime
== Series Details ==
Series: series starting with [01/23] drm/i915: Reduce context HW ID lifetime
URL : https://patchwork.freedesktop.org/series/49157/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d7ddd5a81ce5 drm/i915: Reduce context HW ID lifetime
-:61:
The final call to zlib_deflate(Z_FINISH) may require more output
space to be allocated and so needs to re-invoked. Failure to do so in
the current code leads to incomplete zlib streams (albeit intact due to
the use of Z_SYNC_FLUSH) resulting in the occasional short object
capture.
Testcase:
If the request is currently on the HW (in port 0), then we do not need
to kick the submission tasklet to evaluate whether we should be
preempting itself in order to execute it again.
In the case that was annoying me:
execlists_schedule: rq(18:211173).prio=0 -> 2
need_preempt:
Include the total size of closed vma when reporting the per_ctx_stats of
debugfs/i915_gem_objects.
Whilst adjusting the context tracking, note that we can simply use our
list of contexts in i915->contexts rather than circumlocute via
dev->filelist and the per-file context idr.
Signed-off-by:
Fix up the error unwind for logical_ring_init() failing by moving the
cleanup into the callers who own the various bits of state during
initialisation.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lrc.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
We need to exercise the HW and submission paths for switching contexts
rapidly to check that features such as execlists' wa_tail are adequate.
Plus it's an interesting baseline latency metric.
Signed-off-by: Chris Wilson
---
.../gpu/drm/i915/selftests/i915_gem_context.c | 185 ++
The majority of runtime-pm operations are bounded and scoped within a
function; these are easy to verify that the wakeref are handled
correctly. We can employ the compiler to help us, and reduce the number
of wakerefs tracked when debugging, by passing around cookies provided
by the various
We do not need to continually clear our dedicated PTE for error capture
as it will be updated and invalidated to the next object. Only at the
end do we wish to be sure that the PTE doesn't point back to any buffer.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gpu_error.c | 10
As we only release each power well once, we assume that each transcoder
maps to a different domain. Complain if this is not so.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
Using the guc, we cannot disable the user interrupt generation as we use
it for driving submission. And from Icelake, we no longer have the
ability to individually mask interrupt generation from each engine,
disabling our ability to fake missed interrupts.
In both cases, report back to userspace
Frequently, we use intel_runtime_pm_get/_put around a small block.
Formalise that usage by providing a macro to define such a block with an
automatic closure to scope the intel_runtime_pm wakeref to that block,
i.e. macro abuse smelling of python.
Signed-off-by: Chris Wilson
---
Attach our device_info to the our i915 private on creation so that it is
always available for inspection.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 66 +++--
1 file changed, 38 insertions(+), 28 deletions(-)
diff --git
That we use a WB mapping for updating the RING_TAIL register inside the
context image even on !llc machines has been a source of consternation
for every reader. It appears to work on bsw+, but it may just have been
that we have been incredibly bad at detecting the errors.
v2: With extra
The majority of runtime-pm operations are bounded and scoped within a
function; these are easy to verify that the wakeref are handled
correctly. We can employ the compiler to help us, and reduce the number
of wakerefs tracked when debugging, by passing around cookies provided
by the various
Track where and when we acquire and release the power well for pps
access along the dp aux link, with a view to detecting if we leak any
wakerefs.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_dp.c | 223 +---
1 file changed, 116 insertions(+), 107
Everytime we take a wakeref, record the stack trace of where it was
taken; clearing the set if we ever drop back to no owners. For debugging
a rpm leak, we can look at all the current wakerefs and check if they
have a matching rpm_put.
Signed-off-by: Chris Wilson
---
In the sequence
<0>[ 531.960431] drv_self-48067 527402570us : intel_gpu_reset:
engine_mask=1, ret=0, retry=0
<0>[ 531.960431] drv_self-48067 527402571us : execlists_reset: rcs0
request global=115de, current=71133
<0>[ 531.960431] drv_self-48067d..1 527402571us :
On module load and unload, we grab the POWER_DOMAIN_INIT powerwells and
transfer them to the runtime-pm code. We can use our wakeref tracking to
verify that the wakeref is indeed passed from init to enable, and
disable to fini; and across suspend.
Signed-off-by: Chris Wilson
---
The information presented here is not relevant to current development.
We can either use the context information, but more often we want to
inspect the active gpu state.
The ulterior motive is to eradicate dev->filelist.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c | 119
Make i915_gem_set_wedged() and i915_gem_unset_wedged() behaviour more
consistently if called concurrently.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_gem.c | 32 ++-
drivers/gpu/drm/i915/i915_gpu_error.h | 4 ++-
Now that we reload both RING_HEAD and RING_TAIL when rebinding the
context, we do not need to scrub those registers immediately on resume.
v2: Handle the perma-pinned contexts.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
Cc: Mika Kuoppala
---
drivers/gpu/drm/i915/intel_lrc.c | 29
Future gen reduce the number of bits we will have available to
differentiate between contexts, so reduce the lifetime of the ID
assignment from that of the context to its current active cycle (i.e.
only while it is pinned for use by the HW, will it have a constant ID).
This means that instead of a
Currently, we convert the error state into a string every time we read
from sysfs (and sysfs reads in page size (4KiB) chunks). We do try to
window the string and only capture the portion that is being read, but
that means that we must always convert up to the window to find the
start. For a very
Currently Ironlake operates under the assumption that rpm awake (and its
error checking is disabled). As such, we have missed a few places where we
access registers without taking the rpm wakeref and thus trigger
warnings. intel_ips being one culprit.
As this involved adding a potentially
On Tue, Sep 04, 2018 at 09:53:19PM +0100, Chris Wilson wrote:
> Since this is handling user provided bpp and depth, we need to sanity
> check and propagate the EINVAL back rather than assume what the insane
> client intended and fill the logs with DRM_ERROR.
>
> Signed-off-by: Chris Wilson
> Cc:
== Series Details ==
Series: drm: Reject unknown legacy bpp and dpeth for drm_mode_addfb ioctl
URL : https://patchwork.freedesktop.org/series/49150/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4769 -> Patchwork_10085 =
== Summary - SUCCESS ==
No regressions found.
== Series Details ==
Series: drm/i915: optimzie eDP 1.4 config
URL : https://patchwork.freedesktop.org/series/49131/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4766_full -> Patchwork_10082_full =
== Summary - WARNING ==
Minor unknown changes coming with
On Tue, 2018-09-04 at 19:12 +0100, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-09-04 19:06:29)
> > On Tue, Sep 04, 2018 at 08:59:32PM +0300, Ville Syrjälä wrote:
> > > On Tue, Sep 04, 2018 at 06:44:14PM +0100, Chris Wilson wrote:
> > > > Quoting Ville Syrjälä (2018-09-04 18:39:53)
> > > > >
Since this is handling user provided bpp and depth, we need to sanity
check and propagate the EINVAL back rather than assume what the insane
client intended and fill the logs with DRM_ERROR.
Signed-off-by: Chris Wilson
Cc: Daniel Vetter
Cc: Ville Syrjälä
---
So I am presuming that
On 4 September 2018 at 13:19, Daniel Vetter wrote:
> On Mon, Sep 03, 2018 at 06:38:44PM +0100, Emil Velikov wrote:
>> On 3 September 2018 at 17:54, Daniel Vetter wrote:
>>
>> > -Hide legacy cruft better
>> > -
>> > -
>> > -Way back DRM supported only drivers which
On Mon, Sep 03, 2018 at 06:54:31PM +0200, Daniel Vetter wrote:
> This leaves all the commit/check and state handling in drm_atomic.c,
> while pulling all the uapi glue and the huge ioctl itself into a
> seprate file.
>
> This seems to almost perfectly split the rather big drm_atomic.c file
> into
== Series Details ==
Series: drm/i915: Pull intel_uncore_arm_unclaimed_mmio_detection() under the
spinlock
URL : https://patchwork.freedesktop.org/series/49128/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4766_full -> Patchwork_10081_full =
== Summary - SUCCESS ==
No
On SKL+ the linear source buffer has to start from cache line boundary
to meet the 2d engine source copy requirements. Apply this cache line
alignment policy for SKL+ only.
Signed-off-by: Guang Bai
---
src/sna/sna_io.c | 47 +++
1 file changed, 35
Quoting Ville Syrjälä (2018-09-04 19:06:29)
> On Tue, Sep 04, 2018 at 08:59:32PM +0300, Ville Syrjälä wrote:
> > On Tue, Sep 04, 2018 at 06:44:14PM +0100, Chris Wilson wrote:
> > > Quoting Ville Syrjälä (2018-09-04 18:39:53)
> > > > On Tue, Sep 04, 2018 at 05:29:02PM +0100, Chris Wilson wrote:
> >
On Tue, Sep 04, 2018 at 08:59:32PM +0300, Ville Syrjälä wrote:
> On Tue, Sep 04, 2018 at 06:44:14PM +0100, Chris Wilson wrote:
> > Quoting Ville Syrjälä (2018-09-04 18:39:53)
> > > On Tue, Sep 04, 2018 at 05:29:02PM +0100, Chris Wilson wrote:
> > > > If the previous modeset commit has completed
On Tue, Sep 04, 2018 at 06:44:14PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-09-04 18:39:53)
> > On Tue, Sep 04, 2018 at 05:29:02PM +0100, Chris Wilson wrote:
> > > If the previous modeset commit has completed and is no longer part of
> > > the crtc state, skip waiting for it.
> > >
Quoting Ville Syrjälä (2018-09-04 18:39:53)
> On Tue, Sep 04, 2018 at 05:29:02PM +0100, Chris Wilson wrote:
> > If the previous modeset commit has completed and is no longer part of
> > the crtc state, skip waiting for it.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107792
> >
On Fri, 31 Aug 2018 13:21:40 -0700
Rodrigo Vivi wrote:
> On Fri, Aug 31, 2018 at 04:51:29PM +0100, Chris Wilson wrote:
> > Quoting Bob Paauwe (2018-08-31 16:47:04)
> > > For ppgtt, what we're really interested in is the number of page
> > > walk levels for each platform. Rename the device info
On Tue, Sep 04, 2018 at 05:29:02PM +0100, Chris Wilson wrote:
> If the previous modeset commit has completed and is no longer part of
> the crtc state, skip waiting for it.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107792
> Fixes: c44301fce614 ("drm/i915: Allow control of PSR at
+Susanta
From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of
Kumar, Abhay
Sent: Tuesday, August 28, 2018 5:55 PM
To: Ville Syrjälä
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v1] drm/i915: Skip modeset for cdclk changes if
possible
On
== Series Details ==
Series: drm/i915: Be defensive and don't assume PSR has any commit to sync
against
URL : https://patchwork.freedesktop.org/series/49141/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4767 -> Patchwork_10084 =
== Summary - SUCCESS ==
No regressions
== Series Details ==
Series: igt/pm_rpm: Reload the module with full mmio debugging
URL : https://patchwork.freedesktop.org/series/49138/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4766 -> IGTPW_1785 =
== Summary - SUCCESS ==
No regressions found.
External URL:
If the previous modeset commit has completed and is no longer part of
the crtc state, skip waiting for it.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107792
Fixes: c44301fce614 ("drm/i915: Allow control of PSR at runtime through
debugfs, v6")
Signed-off-by: Chris Wilson
Cc: Maarten
== Series Details ==
Series: drm/i915: Reduce context HW ID lifetime (rev3)
URL : https://patchwork.freedesktop.org/series/44134/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4767 -> Patchwork_10083 =
== Summary - SUCCESS ==
No regressions found.
External URL:
Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.
Signed-off-by: Chris Wilson
Cc: Imre Deak
Reviewed-by: Imre Deak
---
== Series Details ==
Series: drm/i915: Reduce context HW ID lifetime (rev3)
URL : https://patchwork.freedesktop.org/series/44134/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Commit: drm/i915: Reduce context HW ID lifetime
-drivers/gpu/drm/i915/selftests/../i915_drv.h:3686:16:
== Series Details ==
Series: drm/i915: Reduce context HW ID lifetime (rev3)
URL : https://patchwork.freedesktop.org/series/44134/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9a6f6d0994b2 drm/i915: Reduce context HW ID lifetime
-:61: CHECK:UNCOMMENTED_DEFINITION: struct mutex
Future gen reduce the number of bits we will have available to
differentiate between contexts, so reduce the lifetime of the ID
assignment from that of the context to its current active cycle (i.e.
only while it is pinned for use by the HW, will it have a constant ID).
This means that instead of a
== Series Details ==
Series: drm/i915: optimzie eDP 1.4 config
URL : https://patchwork.freedesktop.org/series/49131/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4766 -> Patchwork_10082 =
== Summary - SUCCESS ==
No regressions found.
External URL:
Hi Daniel,
FYI, the error/warning still remains.
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip
head: 1b18cb66428cffa748719cf900b2decac3690029
commit: 7928ca5cc786fdc0269342f1b9e22c2af939b989 [144/320] RFC: debugobjects:
capture stack traces at _init() time
config:
== Series Details ==
Series: drm/i915: Pull intel_uncore_arm_unclaimed_mmio_detection() under the
spinlock
URL : https://patchwork.freedesktop.org/series/49128/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4766 -> Patchwork_10081 =
== Summary - SUCCESS ==
No
On Tue, Sep 04, 2018 at 03:21:09PM +0100, Chris Wilson wrote:
> Quoting Imre Deak (2018-09-04 15:14:06)
> > On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > > periodically and only if they fail do a full check
== Series Details ==
Series: drm/i915: Double check we didn't miss an unclaimed register access
URL : https://patchwork.freedesktop.org/series/49121/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4763_full -> Patchwork_10079_full =
== Summary - WARNING ==
Minor unknown
Quoting Lee, Shawn C (2018-09-04 15:55:41)
> eDP 1.4 introduce a new link rates flexibility and selection.
> It provided system specific link rate optimization and power
> efficiency. We should keep eDP 1.3 and older version to use
> max link rate approach to avoid any side effect. And eDP 1.4
>
eDP 1.4 introduce a new link rates flexibility and selection.
It provided system specific link rate optimization and power
efficiency. We should keep eDP 1.3 and older version to use
max link rate approach to avoid any side effect. And eDP 1.4
used the optimization link rate and lane count
Quoting Imre Deak (2018-09-04 15:14:06)
> On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > periodically and only if they fail do a full check around every mmio
> > access. When testing for runtime pm, enable the
On Tue, Sep 4, 2018 at 3:45 PM, Thomas Hellstrom wrote:
> On 09/03/2018 06:54 PM, Daniel Vetter wrote:
>>
>> The idea behind allowing drivers to override legacy ioctls (instead of
>> using the generic implementations unconditionally) is to handle bugs
>> in old driver-specific userspace. Like
On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> Our unclaimed mmio access debugging is lazy, doing cheap checks
> periodically and only if they fail do a full check around every mmio
> access. When testing for runtime pm, enable the full mmio debugging from
> the initial load.
>
>
On Tue, Sep 04, 2018 at 03:52:51PM +0200, Maarten Lankhorst wrote:
> Op 04-09-18 om 15:50 schreef Ville Syrjälä:
> > On Tue, Sep 04, 2018 at 02:47:51PM +0200, Maarten Lankhorst wrote:
> >> Op 30-08-18 om 16:24 schreef Stanislav Lisovskiy:
> >>> PLANE_CTL_FORMAT_AYUV is already supported, according
== Series Details ==
Series: Add XYUV format support (rev5)
URL : https://patchwork.freedesktop.org/series/48007/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4763_full -> Patchwork_10078_full =
== Summary - FAILURE ==
Serious unknown changes coming with
On Tue, Sep 04, 2018 at 11:19:38AM +0100, Chris Wilson wrote:
> 5s is often not enough for the sound module to finish loading, so bump
> the timeout to 10s. For fun, poll quicker over the 1s!
>
> Signed-off-by: Chris Wilson
> Cc: Imre Deak
Reviewed-by: Imre Deak
> ---
> lib/igt_pm.c | 7
Op 04-09-18 om 15:50 schreef Ville Syrjälä:
> On Tue, Sep 04, 2018 at 02:47:51PM +0200, Maarten Lankhorst wrote:
>> Op 30-08-18 om 16:24 schreef Stanislav Lisovskiy:
>>> PLANE_CTL_FORMAT_AYUV is already supported, according to hardware
>>> specification.
>>>
>>> v2: Edited commit message, removed
On Tue, Sep 04, 2018 at 02:47:51PM +0200, Maarten Lankhorst wrote:
> Op 30-08-18 om 16:24 schreef Stanislav Lisovskiy:
> > PLANE_CTL_FORMAT_AYUV is already supported, according to hardware
> > specification.
> >
> > v2: Edited commit message, removed redundant whitespaces.
> >
> > v3: Fixed
On 03/09/2018 13:53, Patchwork wrote:
== Series Details ==
Series: drm/i915/icl: Fix context RPCS programming (rev2)
URL : https://patchwork.freedesktop.org/series/49005/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4757 -> Patchwork_10070 =
== Summary - SUCCESS ==
On Tue, Sep 04, 2018 at 01:49:56PM +0100, Chris Wilson wrote:
> Make sure we do flush out the previous spinner and delay signaling
> transition completion until we do.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102250
> Signed-off-by: Chris Wilson
> Cc: Katarzyna Dec
> ---
>
Quoting Tvrtko Ursulin (2018-09-03 10:59:01)
>
> On 31/08/2018 13:36, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2018-08-30 17:23:43)
> >>
> >> On 30/08/2018 11:24, Chris Wilson wrote:
> >>> +static int assign_hw_id(struct drm_i915_private *i915, unsigned int *out)
> >>> +{
> >>> + int
On 09/03/2018 06:54 PM, Daniel Vetter wrote:
The idea behind allowing drivers to override legacy ioctls (instead of
using the generic implementations unconditionally) is to handle bugs
in old driver-specific userspace. Like e.g. vmw_kms_set_config does,
to work around some vmwgfx userspace not
Quoting Mika Kuoppala (2018-09-04 13:56:07)
> Chris Wilson writes:
>
> > Quoting Chris Wilson (2018-09-04 13:38:27)
> >> Quoting Mika Kuoppala (2018-09-04 13:34:12)
> >> > Chris Wilson writes:
> >> >
> >> > > Currently, if the user has enabled mmio-debug around each register
> >> > > access,
Chris Wilson writes:
> Elsewhere we manipulate uncore.unclaimed_mmio_check and
> i915_param.mmio_debug under the irq lock (e.g. preserving the current
> value across a user forcewake grab), but do not protect the manipulation
> inside intel_uncore_arm_unclaimed_mmio_detection() from concurrent
>
Quoting Mika Kuoppala (2018-09-04 14:22:17)
> Chris Wilson writes:
>
> > Continuing the fun of trying to find exactly the delay that is
> > sufficient to ensure that the page directory is fully loaded between
> > context switches, move the extra flush added in commit 70b73f9ac113
> >
On Mon, Sep 03, 2018 at 10:21:30PM -0700, Rodrigo Vivi wrote:
> On Mon, Sep 03, 2018 at 05:28:41PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Copy the 38.4 vs. 19.2 MHz ref clock exception from the dpll
> > mgr into the clock readout function as well.
> >
> > v2: Refactor the
On Tue, 28 Aug 2018, Lucas De Marchi wrote:
> On Tue, Aug 28, 2018 at 07:05:46PM +0100, Chris Wilson wrote:
>> Quoting Lucas De Marchi (2018-08-28 18:41:46)
>> > Document it like a real struct for ease of copy and paste, remove
>> > comment of C99 compatibility and document that in some cases the
Chris Wilson writes:
> Continuing the fun of trying to find exactly the delay that is
> sufficient to ensure that the page directory is fully loaded between
> context switches, move the extra flush added in commit 70b73f9ac113
> ("drm/i915/ringbuffer: Delay after invalidating gen6+ xcs") to just
== Series Details ==
Series: drm/i915: Pull intel_uncore_arm_unclaimed_mmio_detection() under the
spinlock
URL : https://patchwork.freedesktop.org/series/49128/
State : failure
== Summary ==
Applying: drm/i915: Pull intel_uncore_arm_unclaimed_mmio_detection() under the
spinlock
Using index
Elsewhere we manipulate uncore.unclaimed_mmio_check and
i915_param.mmio_debug under the irq lock (e.g. preserving the current
value across a user forcewake grab), but do not protect the manipulation
inside intel_uncore_arm_unclaimed_mmio_detection() from concurrent
access, even from itself. This
Chris Wilson writes:
> Quoting Chris Wilson (2018-09-04 13:38:27)
>> Quoting Mika Kuoppala (2018-09-04 13:34:12)
>> > Chris Wilson writes:
>> >
>> > > Currently, if the user has enabled mmio-debug around each register
>> > > access, we presume that we have then checked them all. However, it is
On Tue, Sep 04, 2018 at 03:08:16PM +0300, Jani Nikula wrote:
> On Fri, 31 Aug 2018, Imre Deak wrote:
> > commit afb2c4437dae ("drm/i915/ddi: Push pipe clock enabling to encoders")
> > inadvertently stopped enabling the pipe clock for any DP-MST stream
> > after the first one. It also rearranged
Make sure we do flush out the previous spinner and delay signaling
transition completion until we do.
References: https://bugs.freedesktop.org/show_bug.cgi?id=102250
Signed-off-by: Chris Wilson
Cc: Katarzyna Dec
---
tests/pm_rps.c | 26 +-
1 file changed, 21
Op 30-08-18 om 16:24 schreef Stanislav Lisovskiy:
> PLANE_CTL_FORMAT_AYUV is already supported, according to hardware
> specification.
>
> v2: Edited commit message, removed redundant whitespaces.
>
> v3: Fixed fallthrough logic for the format switch cases.
>
> v4: Yet again fixed fallthrough
On Tue, Sep 04, 2018 at 10:02:40AM +0100, Eric Engestrom wrote:
> On Tuesday, 2018-09-04 16:24:44 +1000, Dave Airlie wrote:
> > On Mon, 3 Sep 2018 at 18:47, Daniel Vetter wrote:
> > >
> > > I picked up a bunch of the pieces from wayland's version:
> > >
> > >
Quoting Chris Wilson (2018-09-04 13:38:27)
> Quoting Mika Kuoppala (2018-09-04 13:34:12)
> > Chris Wilson writes:
> >
> > > Currently, if the user has enabled mmio-debug around each register
> > > access, we presume that we have then checked them all. However, it is
> > > still possible through
Quoting Mika Kuoppala (2018-09-04 13:34:12)
> Chris Wilson writes:
>
> > Currently, if the user has enabled mmio-debug around each register
> > access, we presume that we have then checked them all. However, it is
> > still possible through omission (raw register access) or external
> >
Chris Wilson writes:
> Currently, if the user has enabled mmio-debug around each register
> access, we presume that we have then checked them all. However, it is
> still possible through omission (raw register access) or external
> interaction that the unclaimed access was not highlighted.
>
>
Hey,
I like the new series. Looks good to me.
Reviewed-by: Maarten Lankhorst
Unfortunately, we probably shouldn't merge this until we've fixed IGT to
support the new floating point formats. :(
This requires a new pixman release and a new cairo release, but without
it we can't actually test.
On Mon, Sep 03, 2018 at 06:38:44PM +0100, Emil Velikov wrote:
> On 3 September 2018 at 17:54, Daniel Vetter wrote:
>
> > -Hide legacy cruft better
> > -
> > -
> > -Way back DRM supported only drivers which shadow-attached to PCI devices
> > with
> > -userspace or fbdev
On Fri, 31 Aug 2018, Imre Deak wrote:
> commit afb2c4437dae ("drm/i915/ddi: Push pipe clock enabling to encoders")
> inadvertently stopped enabling the pipe clock for any DP-MST stream
> after the first one. It also rearranged the pipe clock enabling wrt.
> initial MST payload allocation step
== Series Details ==
Series: drm/i915: Double check we didn't miss an unclaimed register access
URL : https://patchwork.freedesktop.org/series/49121/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4763 -> Patchwork_10079 =
== Summary - WARNING ==
Minor unknown changes
== Series Details ==
Series: Add XYUV format support (rev5)
URL : https://patchwork.freedesktop.org/series/48007/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4763 -> Patchwork_10078 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10078 need to be
Currently, if the user has enabled mmio-debug around each register
access, we presume that we have then checked them all. However, it is
still possible through omission (raw register access) or external
interaction that the unclaimed access was not highlighted.
Signed-off-by: Chris Wilson
Cc:
1 - 100 of 120 matches
Mail list logo
