Re: [Intel-gfx] [PATCH] drm/i915/dsc: Fix the deadlock in dsc debugfs node

2018-12-20 Thread Chris Wilson
Quoting Lyude Paul (2018-12-19 23:50:58) > Reviewed-by: Lyude Paul > > On Wed, 2018-12-19 at 15:51 -0800, Manasi Navare wrote: > > The DSC debugfs node causes a possible deadlock situation. This patch > > resets the try_again at the beginning of loop to fix this. > > > > Fixes: e845f099f1c6 ('dr

[Intel-gfx] [PATCH] drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

2018-12-20 Thread Bin Yang
i915_gem_wait_for_idle() waits for all requests being completed and calls i915_retire_requests() to retire them. It assumes the active_requests should be zero finally. In i915_retire_requests(), it will retire all requests on the active rings. Unfortunately, active_requests is increased in i915_re

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
On Wed, 19 Dec 2018 at 17:52, Vincent Guittot wrote: > > On Wed, 19 Dec 2018 at 17:36, Ulf Hansson wrote: > > > > On Wed, 19 Dec 2018 at 14:26, Vincent Guittot > > wrote: > > > > > > On Wed, 19 Dec 2018 at 11:43, Ulf Hansson wrote: > > > > > > > > On Wed, 19 Dec 2018 at 11:34, Vincent Guittot >

Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

2018-12-20 Thread Chris Wilson
Quoting Bin Yang (2018-12-20 08:01:35) > Normally, i915_request_alloc() and i915_request_add() will be called > in sequence with drm.struct_mutex locked. But in > intel_vgpu_create_workload(), it will pre-allocate the request and > call i915_request_add() in the workload thread for performance > op

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Vincent Guittot
On Thu, 20 Dec 2018 at 09:16, Ulf Hansson wrote: > > On Wed, 19 Dec 2018 at 17:52, Vincent Guittot > wrote: > > > > On Wed, 19 Dec 2018 at 17:36, Ulf Hansson wrote: > > > > > > On Wed, 19 Dec 2018 at 14:26, Vincent Guittot > > > wrote: > > > > > > > > On Wed, 19 Dec 2018 at 11:43, Ulf Hansson

Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

2018-12-20 Thread Yang, Bin
On Thu, 2018-12-20 at 08:35 +, Chris Wilson wrote: > Quoting Bin Yang (2018-12-20 08:01:35) > > Normally, i915_request_alloc() and i915_request_add() will be called > > in sequence with drm.struct_mutex locked. But in > > intel_vgpu_create_workload(), it will pre-allocate the request and > > ca

Re: [Intel-gfx] [PATCH v2 01/16] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends

2018-12-20 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:19:45PM -0500, Lyude Paul wrote: > s/drm_dp_get_validated_port_ref/drm_dp_mst_topology_get_port_validated/ > s/drm_dp_put_port/drm_dp_mst_topology_put_port/ > s/drm_dp_get_validated_mstb_ref/drm_dp_mst_topology_get_mstb_validated/ > s/drm_dp_put_mst_branch_device/drm_dp_m

Re: [Intel-gfx] [PATCH v2 06/16] drm/i915: Keep malloc references to MST ports

2018-12-20 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:19:50PM -0500, Lyude Paul wrote: > So that the ports stay around until we've destroyed the connectors, in > order to ensure that we don't pass an invalid pointer to any MST helpers > once we introduce the new MST VCPI helpers. > > Changes since v1: > * Move drm_dp_mst_ge

Re: [Intel-gfx] [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
[...] > > > > Re-thinking this a bit from my earlier comments - and by following the > > > > above reasoning, it sounds like this better belongs in the > > > > driver/subsystem, without requiring any data from the core. > > > > > > > > The driver/subsystem could just store a timestamp in it's > >

Re: [Intel-gfx] [RFC PATCH v2 1/2] drm/i915: Export current required functions for GVT

2018-12-20 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2018-11-26 08:05:53) > This trys to export all required i915 functions for GVT. We have couple of __ prefixed functions proposed here. That'd mostly mean whoever wrote the function intended it to be used only at file scope for its nature (or with special caution outside of fil

Re: [Intel-gfx] [RFC PATCH v2 2/2] drm/i915: Move GVT device model into separate module

2018-12-20 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2018-11-26 08:05:54) > This makes GVT device model into a stand alone module named as > "i915_gvt", which depends on i915 but load after i915 that do > all left GVT host initialization setup. > > Currently i915_gvt module would still load "kvmgt" module to > initialize for VFI

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915/gvt: Change KVMGT as self load module

2018-12-20 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2018-12-07 10:16:53) > This trys to make 'kvmgt' module as self loadable instead of loading > by i915/gvt device model. So hypervisor specific module could be > stand-alone, e.g only after loading hypervisor specific module, GVT > feature could be enabled via specific hyperviso

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check URL : https://patchwork.freedesktop.org/series/54330/ State : warning == Summary == $ dim checkpatch origin/drm-tip bba6cf804980 drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check URL : https://patchwork.freedesktop.org/series/54330/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Fix i915_gem_wait_for_idle oops due to ac

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix i915_gem_wait_for_idle oops due to active_requests check URL : https://patchwork.freedesktop.org/series/54330/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5335 -> Patchwork_11133

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list

2018-12-20 Thread Mika Kuoppala
Talha Nassar writes: > From: talha nassar > > HW team confirmed that this register is write-only. It could be that it is that bit only. We don't need to care about that now, Reviewed-by: Mika Kuoppala > > References: https://bugs.freedesktop.org/show_bug.cgi?id=107338 > Cc: Chris Wilson > C

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list

2018-12-20 Thread Chris Wilson
Quoting Mika Kuoppala (2018-12-20 10:54:33) > Talha Nassar writes: > > > From: talha nassar > > > > HW team confirmed that this register is write-only. > > It could be that it is that bit only. We don't need > to care about that now, > > Reviewed-by: Mika Kuoppala Please follow my suggestion

[Intel-gfx] [PATCH] drm/i915: Fix ILK-IVB primary plane enable delays

2018-12-20 Thread Juha-Pekka Heikkila
Primary and sprite plane enable on ILK-IVB may take two frames to complete Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103925 Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [v4,1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements URL : https://patchwork.freedesktop.org/series/54003/ State : success == Summary == CI Bug Log - changes from CI_DRM_5311 -> Patchwork_11089 ==

Re: [Intel-gfx] [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 9/21/2018 12:21 AM, Ville Syrjala wrote: From: Ville Syrjälä We'll be wanting to send more than just infoframes over HDMI. So add an enum for other packet types. TODO: Maybe just include the infoframe types in the packet type enum and get rid of the infoframe type

Re: [Intel-gfx] [PATCH v9 08/39] drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking

2018-12-20 Thread C, Ramalingam
On 12/19/2018 9:18 PM, Daniel Vetter wrote: On Thu, Dec 13, 2018 at 09:31:10AM +0530, Ramalingam C wrote: "hdcp_encrypted" flag is defined to denote the HDCP1.4 encryption status. This SW tracking is used to determine the need for real hdcp1.4 disable and hdcp_check_link upon CP_IRQ. On CP_IRQ

Re: [Intel-gfx] [v5 1/2] drm: Add colorspace connector property

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/11/2018 11:44 PM, Uma Shankar wrote: This patch adds a colorspace connector property, enabling userspace to switch to various supported colorspaces. This will help enable BT2020 along with other colorspaces. v2: Addressed Maarten and Ville's review comments. Enhanced th

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix ILK-IVB primary plane enable delays

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix ILK-IVB primary plane enable delays URL : https://patchwork.freedesktop.org/series/54336/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5335 -> Patchwork_11134 Summary --- *

Re: [Intel-gfx] uABI / Removing DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig

2018-12-20 Thread Joonas Lahtinen
Quoting Steven Rostedt (2018-12-19 21:22:57) > On Wed, 19 Dec 2018 12:08:18 +0200 > Joonas Lahtinen wrote: > > > To me, it seems almost as if folks are too preoccupied with thinking if > > we somehow can do this through tracepoints, to stop and actually think > > if we should. > > Regardless of

Re: [Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-20 Thread C, Ramalingam
On 12/19/2018 8:51 PM, Daniel Vetter wrote: Indeed, I overlooked that. Maybe highlight it a bit more with a separate if (!CONFIG_ENABLED(MEI_HDCP)) return false; so it stick out more in the previous patch. Currently it's a bit burried. With that + the init ordering fix

[Intel-gfx] [PATCH v2 1/3] drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2)

2018-12-20 Thread Hans de Goede
When we are doing a fastset (needs_modeset=false, update_pipe=true) we may need to update some encoder-level things such as checking that PSR is enabled. This commit adds an update_pipe callback to intel_encoder and a new intel_encoders_update_pipe helper which calls this for all encoders connecte

[Intel-gfx] [PATCH v2 3/3] drm/i915: DDI: call intel_psr_ and _edp_drrs_enable() on pipe updates (v2)

2018-12-20 Thread Hans de Goede
Call intel_psr_enable() and intel_edp_drrs_enable() on pipe updates to make sure that we enable PSR / DRRS (when applicable) on fastsets. Note calling these functions when PSR / DRRS has already been enabled is a no-op, so it is safe to do this on every encoder->update_pipe callback. Changes in v

[Intel-gfx] [PATCH v2 2/3] drm/i915: Allow calling intel_edp_drrs_enable twice

2018-12-20 Thread Hans de Goede
Do not make it an error to call intel_edp_drrs_enable while drrs has already been enabled, instead exit silently in this case. This is a preparation patch for ensuring that DRRS is enabled on fastsets. Note that the removed WARN_ON could also be triggered from userspace through the i915_drrs_ctl

[Intel-gfx] [PATCH 3/3] drm/i915/icl: Work around broken VBTs for port F detection

2018-12-20 Thread Imre Deak
VBT may include incorrect information about the presence of port F. Work around this on SKUs where we know the port is not present. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915 Cc: Mika Kahola Cc: Jani Nikula Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_drv.h |

[Intel-gfx] [PATCH 1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper

2018-12-20 Thread Imre Deak
We have already a function to detect DDI ports using VBT, so instead of opencoding the DDI specific version of this, move the opencoded part to the existing helper. Cc: Jani Nikula Cc: Mika Kahola Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_bios.c| 9 + drivers/gpu/drm/

[Intel-gfx] [PATCH 2/3] drm/i915/icl: Detect port F presence via VBT

2018-12-20 Thread Imre Deak
Registering an output for a non-existent port (on a given SKU) can lead to problems when trying to use the port, for instance timeouts during power well enabling. Since there are no strap bits for port detection we have to rely on VBT for this, so do that here. There are no known SKUs where any of

Re: [Intel-gfx] drm/i915: Disable FBC on fastset if necessary

2018-12-20 Thread Hans de Goede
Hi, On 18-12-18 16:27, Maarten Lankhorst wrote: Without this, we will get a dmesg-warn when enable_fbc is cleared on a fastset: WARN_ON(!crtc_state->enable_fbc) WARNING: CPU: 0 PID: 1090 at drivers/gpu/drm/i915/intel_fbc.c:1091 intel_fbc_enable+0x2ce/0x580 [i915] RIP: 0010:intel_fbc_enable+0x2c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix ILK-IVB primary plane enable delays (rev2)

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix ILK-IVB primary plane enable delays (rev2) URL : https://patchwork.freedesktop.org/series/54336/ State : success == Summary == CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11135 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/3] drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2)

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2) URL : https://patchwork.freedesktop.org/series/54339/ State : warning == Summary == $ dim checkpatch origin/drm-tip 79612d0a1354 drm/i915: Add an up

Re: [Intel-gfx] drm/i915: Disable FBC on fastset if necessary

2018-12-20 Thread Hans de Goede
Hi, On 20-12-18 14:43, Hans de Goede wrote: Hi, On 18-12-18 16:27, Maarten Lankhorst wrote: Without this, we will get a dmesg-warn when enable_fbc is cleared on a fastset: WARN_ON(!crtc_state->enable_fbc) WARNING: CPU: 0 PID: 1090 at drivers/gpu/drm/i915/intel_fbc.c:1091 intel_fbc_enable+0x2c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2)

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Add an update_pipe callback to intel_encoder and call this on fastsets (v2) URL : https://patchwork.freedesktop.org/series/54339/ State : success == Summary == CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11136 ===

[Intel-gfx] [PATCH v4 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Vincent Guittot
Some drivers (like i915/drm) needs to get the accounted suspended time. pm_runtime_suspended_time() will return the suspended accounted time in ns unit. Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 16 include/linux/pm_runtime.h | 2 ++ 2 files changed, 1

[Intel-gfx] [PATCH v4 0/3] Move pm_runtime accounted time to raw nsec

2018-12-20 Thread Vincent Guittot
Move pm_runtime accounted time to raw nsec. The subject of the patchset has changed as the 1st patch of the previous version has been queued by Rafael. Patch 1 adds a new pm_runtime interface to get accounted suspended time Patch 2 moves drm/i915 driver on the new interface and removes access to

[Intel-gfx] [PATCH v4 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2018-12-20 Thread Vincent Guittot
From: Thara Gopinath This patch replaces jiffies based accounting for runtime_active_time and runtime_suspended_time with ktime base accounting. This makes the runtime debug counters inline with genpd and other pm subsytems which uses ktime based accounting. Signed-off-by: Thara Gopinath [move

[Intel-gfx] [PATCH v4 2/3] drm/i915: Move on the new pm runtime interface

2018-12-20 Thread Vincent Guittot
Use the new pm runtime interface to get the accounted suspended time: pm_runtime_accounted_time_get() Signed-off-by: Vincent Guittot --- drivers/gpu/drm/i915/i915_pmu.c | 16 ++-- drivers/gpu/drm/i915/i915_pmu.h | 4 ++-- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915: add a helper to make a copy of i915_params

2018-12-20 Thread Jani Nikula
Abstract the one user in anticipation of more. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gpu_error.c | 11 +-- drivers/gpu/drm/i915/i915_params.c| 14 ++ drivers/gpu/drm/i915/i915_params.h| 1 + 3 files changed, 16 insertions(+), 10 deletions(-) diff

Re: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-20 Thread Winkler, Tomas
> On Wed, 19 Dec 2018, "Winkler, Tomas" wrote: > >> > >> On Wed, 19 Dec 2018, "C, Ramalingam" wrote: > >> > On 12/19/2018 8:05 PM, Daniel Vetter wrote: > >> >> On Thu, Dec 13, 2018 at 09:31:12AM +0530, Ramalingam C wrote: > >> >>> struct intel_hdcp { > >> >>> @@ -414,6 +430,24 @@ struct intel

Re: [Intel-gfx] [PATCH] drm/i915: add a helper to make a copy of i915_params

2018-12-20 Thread Chris Wilson
Quoting Jani Nikula (2018-12-20 14:27:50) > Abstract the one user in anticipation of more. > > Signed-off-by: Jani Nikula No harm done, Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedeskt

Re: [Intel-gfx] [PATCH v9 07/39] drm/i915: MEI interface definition

2018-12-20 Thread Daniel Vetter
On Thu, Dec 20, 2018 at 06:48:08PM +0530, C, Ramalingam wrote: > > On 12/19/2018 8:51 PM, Daniel Vetter wrote: > > Indeed, I overlooked that. Maybe highlight it a bit more with a separate > > > > if (!CONFIG_ENABLED(MEI_HDCP)) > > return false; > > > > so it stick out more in the

Re: [Intel-gfx] [v5 1/2] drm: Add colorspace connector property

2018-12-20 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Thursday, December 20, 2018 5:28 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: hansv...@cisco.com; Syrjala, Ville ; L

Re: [Intel-gfx] [PATCH v9 08/39] drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking

2018-12-20 Thread Daniel Vetter
On Thu, Dec 20, 2018 at 04:59:13PM +0530, C, Ramalingam wrote: > > On 12/19/2018 9:18 PM, Daniel Vetter wrote: > > On Thu, Dec 13, 2018 at 09:31:10AM +0530, Ramalingam C wrote: > > > "hdcp_encrypted" flag is defined to denote the HDCP1.4 encryption status. > > > This SW tracking is used to determi

Re: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-20 Thread Daniel Vetter
On Thu, Dec 20, 2018 at 02:28:55PM +, Winkler, Tomas wrote: > > > > On Wed, 19 Dec 2018, "Winkler, Tomas" wrote: > > >> > > >> On Wed, 19 Dec 2018, "C, Ramalingam" wrote: > > >> > On 12/19/2018 8:05 PM, Daniel Vetter wrote: > > >> >> On Thu, Dec 13, 2018 at 09:31:12AM +0530, Ramalingam C wr

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper URL : https://patchwork.freedesktop.org/series/54341/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/ddi: Move DDI port

[Intel-gfx] [PATCH] drm/i915: Disable FBC on fastset if necessary, v2.

2018-12-20 Thread Maarten Lankhorst
Without this, we will get a dmesg-warn when enable_fbc is cleared on a fastset: WARN_ON(!crtc_state->enable_fbc) WARNING: CPU: 0 PID: 1090 at drivers/gpu/drm/i915/intel_fbc.c:1091 intel_fbc_enable+0x2ce/0x580 [i915] RIP: 0010:intel_fbc_enable+0x2ce/0x580 [i915] Call Trace: ? __mutex_unlock_slowpa

[Intel-gfx] [PATCH] drm/debugfs_crc: Degrade ERROR when overflowing to INFO

2018-12-20 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_debugfs_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index 00e743153e94..80f473ce5c67 100644 --- a/drivers/gpu/drm/drm_debugfs_crc.c +++ b/d

Re: [Intel-gfx] drm/i915: Disable FBC on fastset if necessary

2018-12-20 Thread Maarten Lankhorst
Op 20-12-2018 om 14:56 schreef Hans de Goede: > Hi, > > On 20-12-18 14:43, Hans de Goede wrote: >> Hi, >> >> On 18-12-18 16:27, Maarten Lankhorst wrote: >>> Without this, we will get a dmesg-warn when enable_fbc is cleared on a >>> fastset: >>> WARN_ON(!crtc_state->enable_fbc) >>> WARNING: CPU: 0

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper URL : https://patchwork.freedesktop.org/series/54341/ State : success == Summary == CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11137 ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: add a helper to make a copy of i915_params

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: add a helper to make a copy of i915_params URL : https://patchwork.freedesktop.org/series/54353/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6179c542522e drm/i915: add a helper to make a copy of i915_params -:53: CHECK:MACRO_ARG_PRECEDEN

[Intel-gfx] [PATCH v2 3/3] drm/i915/icl: Work around broken VBTs for port F detection

2018-12-20 Thread Imre Deak
VBT may include incorrect information about the presence of port F. Work around this on SKUs where we know the port is not present. v2: - Fix IS_ICL_WITH_PORT_F, so it's useable from any context. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108915 Cc: Mika Kahola Cc: Jani Nikula Signe

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add a helper to make a copy of i915_params

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: add a helper to make a copy of i915_params URL : https://patchwork.freedesktop.org/series/54353/ State : success == Summary == CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11138 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Disable FBC on fastset if necessary, v2.

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Disable FBC on fastset if necessary, v2. URL : https://patchwork.freedesktop.org/series/54363/ State : warning == Summary == $ dim checkpatch origin/drm-tip 59cca50e5e76 drm/i915: Disable FBC on fastset if necessary, v2. -:6: WARNING:COMMIT_LOG_LONG_LINE:

Re: [Intel-gfx] [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-20 Thread C, Ramalingam
On 12/19/2018 12:15 PM, C, Ramalingam wrote: Tomas and Daniel, From the discussion on this thread, I infer following understanding: * At present(v9) I915 wants to be hard binded to mei_hdcp device-driver binding status through components o This means I915 driver load will get comp

Re: [Intel-gfx] [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-20 Thread Winkler, Tomas
From: C, Ramalingam Sent: Thursday, December 20, 2018 18:00 To: Daniel Vetter ; Winkler, Tomas Cc: Greg KH ; Rafael J. Wysocki ; intel-gfx ; dri-devel ; Sean Paul ; Shankar, Uma ; Syrjala, Ville ; Chris Wilson Subject: Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interf

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable FBC on fastset if necessary, v2.

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Disable FBC on fastset if necessary, v2. URL : https://patchwork.freedesktop.org/series/54363/ State : success == Summary == CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11139 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/debugfs_crc: Degrade ERROR when overflowing to INFO

2018-12-20 Thread Patchwork
== Series Details == Series: drm/debugfs_crc: Degrade ERROR when overflowing to INFO URL : https://patchwork.freedesktop.org/series/54364/ State : warning == Summary == $ dim checkpatch origin/drm-tip ae751d55dd4f drm/debugfs_crc: Degrade ERROR when overflowing to INFO -:7: WARNING:COMMIT_MESS

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/debugfs_crc: Degrade ERROR when overflowing to INFO

2018-12-20 Thread Patchwork
== Series Details == Series: drm/debugfs_crc: Degrade ERROR when overflowing to INFO URL : https://patchwork.freedesktop.org/series/54364/ State : success == Summary == CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11140 Summary --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) URL : https://patchwork.freedesktop.org/series/54341/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0f71660394ec drm/i915/ddi: Move DDI port detecti

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) URL : https://patchwork.freedesktop.org/series/54341/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/ddi: Move DD

Re: [Intel-gfx] [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-20 Thread C, Ramalingam
On 12/20/2018 9:36 PM, Winkler, Tomas wrote: +static void __exit mei_hdcp_exit(void) +{ +   mei_hdcp_component_cleanup(&cldev->dev); Don’t think you can do that,  no guarantees this will be valid pointer As we discussed offline, we have the below line at cleanup. So valid pointer is made s

[Intel-gfx] [PULL] drm-misc-fixes

2018-12-20 Thread Sean Paul
Hi Dave and Daniel, A late spectre fix for you to pull for 4.20 final. drm-misc-fixes-2018-12-20: Fix spectre v1 vuln in drm_ioctl Cheers, Sean The following changes since commit 7566ec393f4161572ba6f11ad5171fd5d59b0fbd: Linux 4.20-rc7 (2018-12-16 15:46:55 -0800) are available in the Git r

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Implement HDCP2.2 (rev12)

2018-12-20 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev12) URL : https://patchwork.freedesktop.org/series/38254/ State : failure == Summary == Applying: drm/i915: Gathering the HDCP1.4 routines together Applying: drm: header for i915 - MEI_HDCP interface Applying: drivers/base: use a wor

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2)

2018-12-20 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/ddi: Move DDI port detection to the corresponding helper (rev2) URL : https://patchwork.freedesktop.org/series/54341/ State : success == Summary == CI Bug Log - changes from CI_DRM_5336 -> Patchwork_11141 ===

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: DDI: call intel_psr_ and _edp_drrs_enable() on pipe updates (v2)

2018-12-20 Thread Rodrigo Vivi
On Thu, Dec 20, 2018 at 02:21:20PM +0100, Hans de Goede wrote: > Call intel_psr_enable() and intel_edp_drrs_enable() on pipe updates to make > sure that we enable PSR / DRRS (when applicable) on fastsets. > > Note calling these functions when PSR / DRRS has already been enabled is a > no-op, so it

Re: [Intel-gfx] [PULL] drm-misc-fixes

2018-12-20 Thread Daniel Vetter
On Thu, Dec 20, 2018 at 11:57:40AM -0500, Sean Paul wrote: > > Hi Dave and Daniel, > A late spectre fix for you to pull for 4.20 final. > > drm-misc-fixes-2018-12-20: > Fix spectre v1 vuln in drm_ioctl > > Cheers, Sean Thanks, applied. -Daniel > > > The following changes since commit 7566ec3

Re: [Intel-gfx] [v5 2/2] drm/i915: Attach colorspace property and enable modeset

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/11/2018 11:44 PM, Uma Shankar wrote: This patch attaches the colorspace connector property to the hdmi connector. Based on colorspace change, modeset will be triggered to switch to new colorspace. Based on colorspace property value create an infoframe with appropriate c

Re: [Intel-gfx] [v2 01/14] drm: Add HDR source metadata property

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/12/2018 2:08 AM, Uma Shankar wrote: This patch adds a blob property to get HDR metadata information from userspace. This will be send as part of AVI Infoframe to panel. v2: Rebase and modified the metadata structure elements as per Ville's POC changes. Signed-off-by: U

Re: [Intel-gfx] [v2 02/14] drm: Add CEA extended tag blocks and HDR bitfield macros

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/12/2018 2:08 AM, Uma Shankar wrote: Add bit field and macro for extended tag in CEA block. Also, declare macros for HDR metadata block. This should have been a part of patch, where these macros are being used, so that we can see it being used properly. While re-basing c

Re: [Intel-gfx] [v2 03/14] drm: Parse HDR metadata info from EDID

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/12/2018 2:08 AM, Uma Shankar wrote: HDR metadata block is introduced in CEA-861.3 spec. Parsing the same to get the panel's HDR metadata. v2: Rebase and added Ville's POC changes to the patch. Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_edid.c | 45 ++

Re: [Intel-gfx] [v2 04/14] drm: Parse Colorimetry data block from EDID

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/12/2018 2:08 AM, Uma Shankar wrote: CEA 861.3 spec adds colorimetry data block for HDMI. Parsing the block to get the colorimetry data from panel. v2: Rebase Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_edid.c | 24 include/drm/drm_c

Re: [Intel-gfx] [v2 05/14] drm/i915: Attach HDR metadata property to connector

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/12/2018 2:08 AM, Uma Shankar wrote: Attach HDR metadata property to connector object. v2: Rebase Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/

Re: [Intel-gfx] uABI / Removing DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig

2018-12-20 Thread Michael Sartain
On Wed, Dec 19, 2018, at 12:22 PM, Steven Rostedt wrote: > On Wed, 19 Dec 2018 12:08:18 +0200 > Joonas Lahtinen wrote: >· > > To me, it seems almost as if folks are too preoccupied with thinking if > > we somehow can do this through tracepoints, to stop and actually think > > if we should. >· > Re

Re: [Intel-gfx] [v2 07/14] drm: Implement HDR source metadata set and get property handling

2018-12-20 Thread Sharma, Shashank
Regards Shashank On 12/12/2018 2:08 AM, Uma Shankar wrote: HDR source metadata set and get property implemented in this patch. Again, HDR output metadata ? How about re-arranging the line like "This patch implements get() and set() functions for HDR output metadata property" just to make it

Re: [Intel-gfx] [PATCH] drm/i915: Disable FBC on fastset if necessary, v2.

2018-12-20 Thread Hans de Goede
Hi, On 20-12-18 16:17, Maarten Lankhorst wrote: Without this, we will get a dmesg-warn when enable_fbc is cleared on a fastset: WARN_ON(!crtc_state->enable_fbc) WARNING: CPU: 0 PID: 1090 at drivers/gpu/drm/i915/intel_fbc.c:1091 intel_fbc_enable+0x2ce/0x580 [i915] RIP: 0010:intel_fbc_enable+0x2c

[Intel-gfx] [v4 4/4] drm/i915/icl: Add degamma and gamma lut size to gen11 caps

2018-12-20 Thread Uma Shankar
Add the degamma and gamma lut sizes to gen11 capability structure. Note: Currently this doesn't account for the extended range gamma entries and this will be addressed with new segmented gamma ABI in a future patch. v2: Reorder the patch as per Maarten's suggestion. v3: Rebase v4: Updated commi

[Intel-gfx] [v4 0/4] Add support for Gen 11 pipe color features

2018-12-20 Thread Uma Shankar
This patch series adds support for Gen11 pipe degamma, CSC and gamma hardware blocks. CRC checks are not working for 10bit gamma but works for 8bit pallete modes which seems to be due to some rounding errors in pipe. ToDo: Support for Multi Segmented Gamma will be added later. v2: Addressed Maar

[Intel-gfx] [v4 1/4] drm/i915: Remove gamma_mode state variable

2018-12-20 Thread Uma Shankar
Removed crtc state variable for gamma mode as it's redundant since currently we have fixed modes on respective hardware platforms. This was making this state variable irrelevant. Credits-to: Matt Roper Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_color.c | 5 + drivers/gpu/d

[Intel-gfx] [v4 2/4] drm/i915/icl: Add icl pipe degamma and gamma support

2018-12-20 Thread Uma Shankar
Add support for icl pipe degamma and gamma. v2: Removed a POSTING_READ and corrected the Bit Definition as per Maarten's comments. v3: Addressed Matt's review comments. Removed rmw patterns as suggested by Matt. v4: Fixed Matt's review comments. Signed-off-by: Uma Shankar --- drivers/gpu/drm/

[Intel-gfx] [v4 3/4] drm/i915/icl: Enable ICL Pipe CSC block

2018-12-20 Thread Uma Shankar
Enable ICL pipe csc hardware. CSC block is enabled in CSC_MODE register instead of PLANE_COLOR_CTL. ToDO: Extend the ABI to accept 32 bit coefficient values instead of 16bit for future platforms. v2: Addressed Maarten's review comments. v3: Addressed Matt's review comments. Removed rmw patterns

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for Gen 11 pipe color features (rev4)

2018-12-20 Thread Patchwork
== Series Details == Series: Add support for Gen 11 pipe color features (rev4) URL : https://patchwork.freedesktop.org/series/51408/ State : success == Summary == CI Bug Log - changes from CI_DRM_5337 -> Patchwork_11143 Summary --- *

Re: [Intel-gfx] [PATCH v4 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2018-12-20 Thread Ulf Hansson
On Thu, 20 Dec 2018 at 15:17, Vincent Guittot wrote: > > From: Thara Gopinath > > This patch replaces jiffies based accounting for runtime_active_time > and runtime_suspended_time with ktime base accounting. This makes the > runtime debug counters inline with genpd and other pm subsytems which >

Re: [Intel-gfx] [PATCH v4 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-20 Thread Ulf Hansson
On Thu, 20 Dec 2018 at 15:16, Vincent Guittot wrote: > > Some drivers (like i915/drm) needs to get the accounted suspended time. > pm_runtime_suspended_time() will return the suspended accounted time > in ns unit. > > Signed-off-by: Vincent Guittot Reviewed-by: Ulf Hansson Kind regards Uffe >

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: Move on the new pm runtime interface

2018-12-20 Thread Ulf Hansson
On Thu, 20 Dec 2018 at 15:17, Vincent Guittot wrote: > > Use the new pm runtime interface to get the accounted suspended time: > pm_runtime_accounted_time_get() pm_runtime_suspended_time() This change also makes quite some nice cleanups to the code, which is mostly because of converting to the n

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: DDI: call intel_psr_ and _edp_drrs_enable() on pipe updates (v2)

2018-12-20 Thread Dhinakaran Pandiyan
On Thu, 2018-12-20 at 09:10 -0800, Rodrigo Vivi wrote: > On Thu, Dec 20, 2018 at 02:21:20PM +0100, Hans de Goede wrote: > > Call intel_psr_enable() and intel_edp_drrs_enable() on pipe updates > > to make > > sure that we enable PSR / DRRS (when applicable) on fastsets. I am probably missing someth

Re: [Intel-gfx] [v4 1/4] drm/i915: Remove gamma_mode state variable

2018-12-20 Thread Matt Roper
On Fri, Dec 21, 2018 at 01:29:38AM +0530, Uma Shankar wrote: > Removed crtc state variable for gamma mode as it's redundant > since currently we have fixed modes on respective hardware > platforms. This was making this state variable irrelevant. > > Credits-to: Matt Roper > > Signed-off-by: Uma

Re: [Intel-gfx] [v4 2/4] drm/i915/icl: Add icl pipe degamma and gamma support

2018-12-20 Thread Matt Roper
On Fri, Dec 21, 2018 at 01:29:39AM +0530, Uma Shankar wrote: > Add support for icl pipe degamma and gamma. > > v2: Removed a POSTING_READ and corrected the Bit > Definition as per Maarten's comments. > > v3: Addressed Matt's review comments. Removed rmw patterns > as suggested by Matt. > > v4: F

Re: [Intel-gfx] Local Display Direct Flip Feature Discussion

2018-12-20 Thread Zhang, Tina
+ intel-gfx and dri-devel Hi, This is the Gvt-g local display direct flip discussion. And please reference here (https://lists.freedesktop.org/archives/intel-gvt-dev/2018-December/004594.html) to see what the feature is. Mostly, with Gvt-g local display direct flip feature, vGPU can directly

Re: [Intel-gfx] Local Display Direct Flip Feature Discussion

2018-12-20 Thread Zhenyu Wang
On 2018.12.20 12:33:35 +0100, Gerd Hoffmann wrote: > On Thu, Dec 20, 2018 at 08:45:09AM +, Zhang, Tina wrote: > > > > > > > -Original Message- > > > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] > > > On > > > Behalf Of Gerd Hoffmann > > > Sent: Wednesday,

Re: [Intel-gfx] uABI / Removing DRM_I915_LOW_LEVEL_TRACEPOINTS Kconfig

2018-12-20 Thread Joonas Lahtinen
Quoting Michael Sartain (2018-12-20 20:27:19) > On Wed, Dec 19, 2018, at 12:22 PM, Steven Rostedt wrote: > > On Wed, 19 Dec 2018 12:08:18 +0200 > > Joonas Lahtinen wrote: > >· > > > To me, it seems almost as if folks are too preoccupied with thinking if > > > we somehow can do this through tracepo