Re: [Intel-gfx] [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nathan Chancellor
On Fri, Jan 25, 2019 at 11:34:19PM -0800, Nick Desaulniers wrote: > On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor > wrote: > > > > This warning is disabled by default in scripts/Makefile.extrawarn when > > W= is not provided but this Makefile adds -Wall after this warning is > > disabled so i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable -Wuninitialized

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Disable -Wuninitialized URL : https://patchwork.freedesktop.org/series/55769/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488 -> Patchwork_12051 Summary --- **SUCCESS** No

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nick Desaulniers
On Fri, Jan 25, 2019 at 11:34 PM Nick Desaulniers wrote: > > On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor > wrote: > > > > This warning is disabled by default in scripts/Makefile.extrawarn when > > W= is not provided but this Makefile adds -Wall after this warning is > > disabled so it show

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nick Desaulniers
On Fri, Jan 25, 2019 at 11:13 PM Nathan Chancellor wrote: > > This warning is disabled by default in scripts/Makefile.extrawarn when > W= is not provided but this Makefile adds -Wall after this warning is > disabled so it shows up in the build when it shouldn't: > > In file included from drivers/g

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Disable -Wuninitialized

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Disable -Wuninitialized URL : https://patchwork.freedesktop.org/series/55769/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Disable -Wuninitialized - +./arch/x86/include/asm/pgtable_64.h:61:9: warning:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Don't send MST hotplugs until after resume

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Don't send MST hotplugs until after resume URL : https://patchwork.freedesktop.org/series/55763/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5488_full -> Patchwork_12049_full Summary

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nathan Chancellor
On Sat, Jan 26, 2019 at 12:11:23AM -0700, Nathan Chancellor wrote: > This warning is disabled by default in scripts/Makefile.extrawarn when > W= is not provided but this Makefile adds -Wall after this warning is > disabled so it shows up in the build when it shouldn't: > > In file included from dr

[Intel-gfx] [PATCH v2] drm/i915: Disable -Wuninitialized

2019-01-25 Thread Nathan Chancellor
This warning is disabled by default in scripts/Makefile.extrawarn when W= is not provided but this Makefile adds -Wall after this warning is disabled so it shows up in the build when it shouldn't: In file included from drivers/gpu/drm/i915/intel_breadcrumbs.c:895: drivers/gpu/drm/i915/selftests/in

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME URL : https://patchwork.freedesktop.org/series/55762/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488_full -> Patchwork_12048_full S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Apply LUT validation checks to platforms more accurately

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Apply LUT validation checks to platforms more accurately URL : https://patchwork.freedesktop.org/series/55765/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488 -> Patchwork_12050 Sum

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Apply LUT validation checks to platforms more accurately

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Apply LUT validation checks to platforms more accurately URL : https://patchwork.freedesktop.org/series/55765/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0088726a8c5a drm/i915: Apply LUT validation checks to platforms more accurately -:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't send MST hotplugs until after resume

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Don't send MST hotplugs until after resume URL : https://patchwork.freedesktop.org/series/55763/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488 -> Patchwork_12049 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for icl: Misc PLL patches (rev2)

2019-01-25 Thread Patchwork
== Series Details == Series: icl: Misc PLL patches (rev2) URL : https://patchwork.freedesktop.org/series/55378/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5488_full -> Patchwork_12047_full Summary --- **FAILURE**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME URL : https://patchwork.freedesktop.org/series/55762/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488 -> Patchwork_12048 Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint URL : https://patchwork.freedesktop.org/series/55750/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488_full -> Patchwork_12046_full ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME URL : https://patchwork.freedesktop.org/series/55762/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/psr: Remove PSR2 FIXME Okay! Commit: drm/i915/psr: In

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/psr: Remove PSR2 FIXME URL : https://patchwork.freedesktop.org/series/55762/ State : warning == Summary == $ dim checkpatch origin/drm-tip c3c5516bfe56 drm/i915/psr: Remove PSR2 FIXME 134873148487 drm/i915/psr: Initialize PSR mut

[Intel-gfx] [PATCH] drm/i915: Apply LUT validation checks to platforms more accurately

2019-01-25 Thread Matt Roper
Use of the new DRM_COLOR_LUT_NON_DECREASING test was a bit over-zealous; it doesn't actually need to be applied to the degamma on "bdw-style" platforms. Likewise, we overlooked the fact that CHV should have that test applied to the gamma LUT as well as the degamma LUT. Rather than adding more com

[Intel-gfx] [PATCH] drm/i915: Don't send MST hotplugs until after resume

2019-01-25 Thread Lyude Paul
Turns out we are sending a lot more hotplug events then we need, and this is causing some pretty serious issues. Currently, we call intel_dp_mst_resume() in i915_drm_resume() well before we have any sort of hotplugging setup. This is a pretty big problem, because in practice it will generally resul

[Intel-gfx] [PATCH 4/4] drm/i915/psr: Print why PSR or PSR2 was not enabled in debugfs

2019-01-25 Thread José Roberto de Souza
PSR needs to do some checks against the current/future CRTC state to confirm if PSR hardware can support PSR in given configuration. So lets add this information to debugfs this way we can make IGT test smarter and skip tests when a valid a know reason caused PSR to not be enabled. It will print P

[Intel-gfx] [PATCH 1/4] drm/i915/psr: Remove PSR2 FIXME

2019-01-25 Thread José Roberto de Souza
Now we are only checking sink capabilities when probing PSR DPCD register and then dynamically checking in intel_psr2_config_valid() to make sure the current modeset and features enables are compatible with PSR2. So this FIXME can be dropped. Cc: Dhinakaran Pandiyan Signed-off-by: José Roberto de

[Intel-gfx] [PATCH 2/4] drm/i915/psr: Initialize PSR mutex even when sink is not reliable

2019-01-25 Thread José Roberto de Souza
Even when driver is reload and hits this scenario the PSR mutex should be initialized, otherwise reading PSR debugfs status will execute mutex_lock() over a mutex that was not initialized. Cc: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_psr.c | 1 - 1

[Intel-gfx] [PATCH 3/4] drm/psr: Do not enable PSR when a interlaced mode set for all gens

2019-01-25 Thread José Roberto de Souza
This interlaced restriction applies to all gens, not only to Haswell. Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_psr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_psr.c b/driv

[Intel-gfx] ✓ Fi.CI.BAT: success for icl: Misc PLL patches (rev2)

2019-01-25 Thread Patchwork
== Series Details == Series: icl: Misc PLL patches (rev2) URL : https://patchwork.freedesktop.org/series/55378/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488 -> Patchwork_12047 Summary --- **SUCCESS** No regr

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix skl srckey mask bits

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Fix skl srckey mask bits URL : https://patchwork.freedesktop.org/series/55744/ State : success == Summary == CI Bug Log - changes from CI_DRM_5486_full -> Patchwork_12045_full Summary --- **SUCC

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint URL : https://patchwork.freedesktop.org/series/55750/ State : success == Summary == CI Bug Log - changes from CI_DRM_5488 -> Patchwork_12046

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/tv: Fix return value for intel_tv_compute_config()

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tv: Fix return value for intel_tv_compute_config() URL : https://patchwork.freedesktop.org/series/55743/ State : success == Summary == CI Bug Log - changes from CI_DRM_5486_full -> Patchwork_12044_full ==

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/dp/mst: Provide defines for ACK vs. NAK reply type (rev2)

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp/mst: Provide defines for ACK vs. NAK reply type (rev2) URL : https://patchwork.freedesktop.org/series/55581/ State : success == Summary == CI Bug Log - changes from CI_DRM_5486_full -> Patchwork_12043_full =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint URL : https://patchwork.freedesktop.org/series/55750/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0cf0a44086c4 drm/i915: Rename execlists->queue_priori

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint URL : https://patchwork.freedesktop.org/series/55750/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Rename execlists

[Intel-gfx] [PATCH v2 0/4] icl: Misc PLL patches

2019-01-25 Thread Lucas De Marchi
Some PLL reworks on ICL. Patches are more or less independent of each other, but touch the same part of the code. v2 of https://patchwork.freedesktop.org/series/55378/ Changes: typos, commit messages and checkpatch fix. I'm dropping the last commit as we don't really need it right now and when/if

[Intel-gfx] [PATCH v2 1/4] drm/i915/icl: use tc_port in MG_PLL macros

2019-01-25 Thread Lucas De Marchi
Fix the TODO leftover in the code by changing the argument in MG_PLL macros. The MG_PLL ids used to access the register values can be converted from tc_port rather than port. All these registers can use the TC port to calculate the right offsets because they are only available for TC ports. The ra

[Intel-gfx] [PATCH v2 4/4] drm/i915/icl: keep track of unused pll while looping

2019-01-25 Thread Lucas De Marchi
Instead of looping again on the range of plls, just keep track of one unused one and use it later. Signed-off-by: Lucas De Marchi Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/

[Intel-gfx] [PATCH v2 2/4] drm/i915: always return something on DDI clock selection

2019-01-25 Thread Lucas De Marchi
Even if we don't have the correct clock and get a warning, we should not skip the return. v2: improve commit message (from Joonas) Fixes: 1fa11ee2d9d0 ("drm/i915/icl: start adding the TBT pll") Cc: Paulo Zanoni Cc: # v4.19+ Signed-off-by: Lucas De Marchi Reviewed-by: Mika Kahola --- drivers/

[Intel-gfx] [PATCH v2 3/4] drm/i915/icl: remove dpll from clk_sel

2019-01-25 Thread Lucas De Marchi
We should not pass DPLL_ID_ICL_DPLL0 or DPLL_ID_ICL_DPLL1 to this function because the path is only taken for non-combophy ports. Let the warning trigger if improper value is given. While at it, rename the function to match the register name we are trying to program. v2: fix typo in comment Sign

[Intel-gfx] [PATCH 3/3] drm/i915/execlists: Suppress redundant preemption

2019-01-25 Thread Chris Wilson
On unwinding the active request we give it a small (limited to internal priority levels) boost to prevent it from being gazumped a second time. However, this means that it can be promoted to above the request that triggered the preemption request, causing a preempt-to-idle cycle for no change. We c

[Intel-gfx] [PATCH 2/3] drm/i915/execlists: Suppress preempting self

2019-01-25 Thread Chris Wilson
In order to avoid preempting ourselves, we currently refuse to schedule the tasklet if we reschedule an inflight context. However, this glosses over a few issues such as what happens after a CS completion event and we then preempt the newly executing context with itself, or if something else causes

[Intel-gfx] [PATCH 1/3] drm/i915: Rename execlists->queue_priority to preempt_priority_hint

2019-01-25 Thread Chris Wilson
After noticing that we trigger preemption events for currently executing requests, as well as requests that complete before the preemption and attempting to suppress those preemption events, it is wise to not consider the queue_priority to be authoritative. As only track the maximum priority see be

Re: [Intel-gfx] [PATCH] drm/i915: Fix skl srckey mask bits

2019-01-25 Thread Matt Roper
On Fri, Jan 25, 2019 at 08:38:46PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > We're incorrectly masking off the R/V channel enable bit from > KEYMSK. Fix it up. > > Cc: Maarten Lankhorst > Cc: Matt Roper > Fixes: b20815255693 ("drm/i915: Add plane alpha blending support, v2.") > Sig

Re: [Intel-gfx] [PATCH v3] drm/i915: correct the pitch check for NV12 framebuffer

2019-01-25 Thread Ville Syrjälä
On Wed, Dec 19, 2018 at 01:59:12PM +0530, raviraj.p.sita...@intel.com wrote: > From: P Raviraj Sitaram > > framebuffer for NV12 requires the pitch to the multiplier of 4, instead > of the width. This patch corrects it. > > For instance, a 480p video, whose width and pitch are 854 and 896 > respe

Re: [Intel-gfx] [PATCH] drm/i915/icl: Add TypeC ports only if VBT is present

2019-01-25 Thread Souza, Jose
On Fri, 2019-01-25 at 16:34 +0200, Imre Deak wrote: > We can't safely probe Type C ports, whether they are a legacy or a > USB/Thunderbolt DP Alternate Type C port. This would require > performing > the TypeC connect sequence - as described by the specification - but > that may have unwanted side-e

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dsi: Call drm_connector_cleanup on vlv_dsi_init error exit path

2019-01-25 Thread Ville Syrjälä
On Sat, Dec 01, 2018 at 12:31:48PM +0100, Hans de Goede wrote: > If we exit vlv_dsi_init() because we failed to find a fixed_mode, then > we've already called drm_connector_init() and we should call > drm_connector_cleanup() to unregister the connector object. > > Signed-off-by: Hans de Goede Re

Re: [Intel-gfx] [PATCH 2/3] drm: Sync errno values for property lookup errors

2019-01-25 Thread Ville Syrjälä
On Tue, Jan 22, 2019 at 10:39:38AM +0100, Daniel Vetter wrote: > On Mon, Jan 21, 2019 at 10:24:29PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Use ENOENT consistently for the case where the requested property > > isn't found, and EINVAL for the case where the object has no > > pr

Re: [Intel-gfx] [PATCH 1/3] drm: Add debug prints for the various object lookup errors

2019-01-25 Thread Ville Syrjälä
On Tue, Jan 22, 2019 at 10:38:30AM +0100, Daniel Vetter wrote: > On Mon, Jan 21, 2019 at 10:24:28PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Only some of the drm mode object lookups have a corresponding debug > > print for the lookup failure. That makes logs a bit hard to parse

[Intel-gfx] ✗ Fi.CI.IGT: failure for Per context dynamic (sub)slice power-gating (rev20)

2019-01-25 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev20) URL : https://patchwork.freedesktop.org/series/48194/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5484_full -> Patchwork_12042_full Summary

Re: [Intel-gfx] [PATCH 2/2] drm/i915/tv: Use the scanline counter for timestamps on i965gm TV output

2019-01-25 Thread Imre Deak
On Fri, Jan 25, 2019 at 08:19:31PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Just like the frame counter, the pixel counter also reads zero > all the time when the TV encoder is used. Fortunately the > scanline counter still works sufficiently well so let's use that > to correct the v

Re: [Intel-gfx] [PATCH 1/2] drm/i915/tv: Fix return value for intel_tv_compute_config()

2019-01-25 Thread Imre Deak
On Fri, Jan 25, 2019 at 08:19:30PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Ever since commit 204474a6b859 ("drm/i915: Pass down rc in > intel_encoder->compute_config()") we're supposed to return an > errno from .compute_config(). I failed to notice that when > pushing the TV encoder

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Validate userspace-provided color management LUT's (v4)

2019-01-25 Thread Ville Syrjälä
On Tue, Dec 18, 2018 at 09:51:58AM -0800, Matt Roper wrote: > We currently program userspace-provided gamma and degamma LUT's into our > hardware without really checking to see whether they satisfy our > hardware's rules. We should try to catch tables that are invalid for > our hardware early and

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/icl: Add TypeC ports only if VBT is present

2019-01-25 Thread Imre Deak
On Fri, Jan 25, 2019 at 03:49:07PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/icl: Add TypeC ports only if VBT is present > URL : https://patchwork.freedesktop.org/series/55733/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5484 -> Patchwork_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix skl srckey mask bits

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Fix skl srckey mask bits URL : https://patchwork.freedesktop.org/series/55744/ State : success == Summary == CI Bug Log - changes from CI_DRM_5486 -> Patchwork_12045 Summary --- **SUCCESS** N

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/tv: Fix return value for intel_tv_compute_config()

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tv: Fix return value for intel_tv_compute_config() URL : https://patchwork.freedesktop.org/series/55743/ State : success == Summary == CI Bug Log - changes from CI_DRM_5486 -> Patchwork_12044

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/dp/mst: Provide defines for ACK vs. NAK reply type (rev2)

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp/mst: Provide defines for ACK vs. NAK reply type (rev2) URL : https://patchwork.freedesktop.org/series/55581/ State : success == Summary == CI Bug Log - changes from CI_DRM_5486 -> Patchwork_12043 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/tv: Fix return value for intel_tv_compute_config()

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/tv: Fix return value for intel_tv_compute_config() URL : https://patchwork.freedesktop.org/series/55743/ State : warning == Summary == $ dim checkpatch origin/drm-tip 03b411930b07 drm/i915/tv: Fix return value for intel_tv_compu

[Intel-gfx] [PATCH] drm/i915: Fix skl srckey mask bits

2019-01-25 Thread Ville Syrjala
From: Ville Syrjälä We're incorrectly masking off the R/V channel enable bit from KEYMSK. Fix it up. Cc: Maarten Lankhorst Cc: Matt Roper Fixes: b20815255693 ("drm/i915: Add plane alpha blending support, v2.") Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 1 fil

Re: [Intel-gfx] [PATCH 06/26] drm/fb_helper: set info->par in fill_info()

2019-01-25 Thread Sam Ravnborg
On Fri, Jan 25, 2019 at 09:44:06AM +0100, Daniel Vetter wrote: > On Thu, Jan 24, 2019 at 06:45:52PM +0100, Sam Ravnborg wrote: > > Hi Daniel. > > > > On Thu, Jan 24, 2019 at 05:58:11PM +0100, Daniel Vetter wrote: > > > The fbdev emulation helpers pretty much assume that this is set. > > > Let's do

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/dp/mst: Provide defines for ACK vs. NAK reply type (rev2)

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/dp/mst: Provide defines for ACK vs. NAK reply type (rev2) URL : https://patchwork.freedesktop.org/series/55581/ State : warning == Summary == $ dim checkpatch origin/drm-tip b8534842e422 drm/dp/mst: Provide defines for ACK vs. NAK

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Stop tracking MRU activity on VMA

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Stop tracking MRU activity on VMA URL : https://patchwork.freedesktop.org/series/55731/ State : success == Summary == CI Bug Log - changes from CI_DRM_5483_full -> Patchwork_12039_full Summary ---

[Intel-gfx] [PATCH 1/2] drm/i915/tv: Fix return value for intel_tv_compute_config()

2019-01-25 Thread Ville Syrjala
From: Ville Syrjälä Ever since commit 204474a6b859 ("drm/i915: Pass down rc in intel_encoder->compute_config()") we're supposed to return an errno from .compute_config(). I failed to notice that when pushing the TV encoder fixes which were written before said commmit. Fix up the return value for

[Intel-gfx] [PATCH 2/2] drm/i915/tv: Use the scanline counter for timestamps on i965gm TV output

2019-01-25 Thread Ville Syrjala
From: Ville Syrjälä Just like the frame counter, the pixel counter also reads zero all the time when the TV encoder is used. Fortunately the scanline counter still works sufficiently well so let's use that to correct the vblank timestamps. Otherwise the timestamps may en up out of whack, and sinc

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/5] drm/i915: Make all GPU resets atomic

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: Make all GPU resets atomic URL : https://patchwork.freedesktop.org/series/55730/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5483_full -> Patchwork_12038_full ===

Re: [Intel-gfx] [PATCH 14/15] drm/i915/tv: Fix >1024 modes on gen3

2019-01-25 Thread Ville Syrjälä
On Wed, Jan 23, 2019 at 03:49:02PM +0200, Imre Deak wrote: > On Mon, Nov 12, 2018 at 06:59:59PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > On gen3 we must disable the TV encoder vertical filter for >1024 > > pixel wide sources. Once that's done all we can is try to center > > the

[Intel-gfx] ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev20)

2019-01-25 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev20) URL : https://patchwork.freedesktop.org/series/48194/ State : success == Summary == CI Bug Log - changes from CI_DRM_5484 -> Patchwork_12042 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per context dynamic (sub)slice power-gating (rev20)

2019-01-25 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev20) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Record the sseu configuration per-context & engine -drivers/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev20)

2019-01-25 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev20) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim checkpatch origin/drm-tip e1d7e70fd818 drm/i915: Record the sseu configuration per-context & engine f8dd0fb8513e drm/i915/p

[Intel-gfx] [PATCH v4 3/5] drm/i915: Add timeline barrier support

2019-01-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Timeline barrier allows serialization between different timelines. After calling i915_timeline_set_barrier with a request, all following submissions on this timeline will be set up as depending on this request, or barrier. Once the barrier has been completed it automatically

Re: [Intel-gfx] [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-25 Thread Daniel Vetter
On Fri, Jan 25, 2019 at 02:46:55PM +, Emil Velikov wrote: > On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > > > This is only used by drm_irq_install(), which is an optional helper. > > And the right choice is to set it for all pci devices, and not for > > everything else. > > > Can you

[Intel-gfx] ✗ Fi.CI.BAT: failure for Per context dynamic (sub)slice power-gating (rev19)

2019-01-25 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev19) URL : https://patchwork.freedesktop.org/series/48194/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5484 -> Patchwork_12041 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/icl: Add TypeC ports only if VBT is present

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915/icl: Add TypeC ports only if VBT is present URL : https://patchwork.freedesktop.org/series/55733/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5484 -> Patchwork_12040 Summary ---

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add timeline barrier support

2019-01-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-25 15:24:39) > From: Tvrtko Ursulin > > Timeline barrier allows serialization between different timelines. > > After calling i915_timeline_set_barrier with a request, all following > submissions on this timeline will be set up as depending on this request, > or ba

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Per context dynamic (sub)slice power-gating (rev19)

2019-01-25 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev19) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Record the sseu configuration per-context & engine -drivers/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev19)

2019-01-25 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev19) URL : https://patchwork.freedesktop.org/series/48194/ State : warning == Summary == $ dim checkpatch origin/drm-tip b46b66196670 drm/i915: Record the sseu configuration per-context & engine 56a1aaefc8e7 drm/i915/p

Re: [Intel-gfx] [PATCH] drm/i915: Don't use the second dbuf slice on icl

2019-01-25 Thread Ville Syrjälä
On Tue, Jan 22, 2019 at 02:58:46PM +0530, Mahesh Kumar wrote: > Hi, > > On Mon, Jan 21, 2019 at 9:01 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > The code managing the dbuf slices is borked and needs some > > real work to fix. In the meantime let's just stop using the > > second

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915: Remove manual breadcumb counting

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Remove manual breadcumb counting URL : https://patchwork.freedesktop.org/series/55726/ State : success == Summary == CI Bug Log - changes from CI_DRM_5481_full -> Patchwork_12037_full =

[Intel-gfx] [PATCH 1/5] drm/i915: Record the sseu configuration per-context & engine

2019-01-25 Thread Tvrtko Ursulin
From: Lionel Landwerlin We want to expose the ability to reconfigure the slices, subslice and eu per context and per engine. To facilitate that, store the current configuration on the context for each engine, which is initially set to the device default upon creation. v2: record sseu configurati

[Intel-gfx] [PATCH 4/5] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)

2019-01-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to allow userspace to reconfigure the subslice configuration on a per context basis. This is required for the functional requirement of shutting down non-VME enabled sub-slices on Gen11 parts. To do so, we expose a context parameter to allow adjustment of the RPCS r

[Intel-gfx] [PATCH 2/5] drm/i915/perf: lock powergating configuration to default when active

2019-01-25 Thread Tvrtko Ursulin
From: Lionel Landwerlin If some of the contexts submitting workloads to the GPU have been configured to shutdown slices/subslices, we might loose the NOA configurations written in the NOA muxes. One possible solution to this problem is to reprogram the NOA muxes when we switch to a new context.

[Intel-gfx] [PATCH 5/5] drm/i915/selftests: Context SSEU reconfiguration tests

2019-01-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Exercise the context image reconfiguration logic for idle and busy contexts, with the resets thrown into the mix as well. Free from the uAPI restrictions this test runs on all Gen9+ platforms with slice power gating. v2: * Rename some helpers for clarity. * Include subtes

[Intel-gfx] [PATCH 3/5] drm/i915: Add timeline barrier support

2019-01-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Timeline barrier allows serialization between different timelines. After calling i915_timeline_set_barrier with a request, all following submissions on this timeline will be set up as depending on this request, or barrier. Once the barrier has been completed it automatically

[Intel-gfx] [PATCH 0/5] Per context dynamic (sub)slice power-gating

2019-01-25 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Changes since last version: * One patch got to drm-tip early so removed from this series. * Two small cleanups in the area of request emission. Lionel Landwerlin (2): drm/i915: Record the sseu configuration per-context & engine drm/i915/perf: lock powergating configura

Re: [Intel-gfx] [PATCH 26/26] drm/: Don't set FBINFO_(FLAG_)DEFAULT

2019-01-25 Thread Thierry Reding
On Thu, Jan 24, 2019 at 05:58:31PM +0100, Daniel Vetter wrote: > It's 0. > > Signed-off-by: Daniel Vetter > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Patrik Jakobsson > Cc: Ben Skeggs > Cc: Sandy Huang > Cc:

Re: [Intel-gfx] [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info

2019-01-25 Thread Thierry Reding
On Thu, Jan 24, 2019 at 05:58:27PM +0100, Daniel Vetter wrote: > Another driver that didn't set fbinfo->fix.id before. > > Signed-off-by: Daniel Vetter > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-te...@vger.kernel.org > --- > drivers/gpu/drm/tegra/fb.c | 4 +--- > 1 file changed, 1

Re: [Intel-gfx] [PATCH 01/26] drm/irq: Don't check for DRIVER_HAVE_IRQ in drm_irq_(un)install

2019-01-25 Thread Emil Velikov
On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > If a non-legacy driver calls these it's valid to assume there is > interrupt support. The flag is really only needed for legacy drivers. ... legacy drivers which issue the IRQ via the DRM_IOCTL_CONTROL legacy IOCTL. At a later stage, we migh

Re: [Intel-gfx] [PATCH] drm/i915: Don't use the second dbuf slice on icl

2019-01-25 Thread Imre Deak
On Mon, Jan 21, 2019 at 05:31:43PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > The code managing the dbuf slices is borked and needs some > real work to fix. In the meantime let's just stop using the > second slice. > > Signed-off-by: Ville Syrjälä Reviewed-by: Imre Deak > --- > d

Re: [Intel-gfx] [PATCH] drm/i915: Don't use the second dbuf slice on icl

2019-01-25 Thread Imre Deak
On Tue, Jan 22, 2019 at 02:49:13PM +0530, Mahesh Kumar wrote: > Hi, > > > On Mon, Jan 21, 2019 at 9:01 PM Ville Syrjala > wrote: > > > > From: Ville Syrjälä > > > > The code managing the dbuf slices is borked and needs some > > real work to fix. In the meantime let's just stop using the > > sec

Re: [Intel-gfx] [PATCH 26/26] drm/: Don't set FBINFO_(FLAG_)DEFAULT

2019-01-25 Thread Emil Velikov
On Thu, 24 Jan 2019 at 17:00, Daniel Vetter wrote: > > It's 0. > I'd add a bit more information here. Feel free to reuse as much/little of the following: Both macros evaluate to 0. At the same time flag is already set to zero since the struct is kzalloc'd in framebuffer_alloc(). As called by drm_

Re: [Intel-gfx] [PATCH 03/26] drm/irq: Ditch DRIVER_IRQ_SHARED

2019-01-25 Thread Emil Velikov
On Thu, 24 Jan 2019 at 16:58, Daniel Vetter wrote: > > This is only used by drm_irq_install(), which is an optional helper. > And the right choice is to set it for all pci devices, and not for > everything else. > Can you please add some information (or reference) why it's the right choice? Thank

Re: [Intel-gfx] [PATCH 27/33] drm/i915: Replace global breadcrumbs with per-context interrupt tracking

2019-01-25 Thread Chris Wilson
Quoting Chris Wilson (2019-01-25 14:26:49) > Quoting Tvrtko Ursulin (2019-01-25 13:54:05) > > > > On 25/01/2019 02:29, Chris Wilson wrote: > > > + > > > + requests[n] = i915_request_get(rq); > > > + i915_request_add(rq); > > > + > > > + m

[Intel-gfx] [PATCH] drm/i915/icl: Add TypeC ports only if VBT is present

2019-01-25 Thread Imre Deak
We can't safely probe Type C ports, whether they are a legacy or a USB/Thunderbolt DP Alternate Type C port. This would require performing the TypeC connect sequence - as described by the specification - but that may have unwanted side-effects. These side-effects include at least - without complete

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop tracking MRU activity on VMA

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Stop tracking MRU activity on VMA URL : https://patchwork.freedesktop.org/series/55731/ State : success == Summary == CI Bug Log - changes from CI_DRM_5483 -> Patchwork_12039 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH 27/33] drm/i915: Replace global breadcrumbs with per-context interrupt tracking

2019-01-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-25 13:54:05) > > On 25/01/2019 02:29, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/i915_request.c > > b/drivers/gpu/drm/i915/i915_request.c > > index 2171df2d3019..c09a6644a2ab 100644 > > --- a/drivers/gpu/drm/i915/i915_request.c > > +++ b/drivers/gpu/

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/5] drm/i915: Make all GPU resets atomic

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: Make all GPU resets atomic URL : https://patchwork.freedesktop.org/series/55730/ State : success == Summary == CI Bug Log - changes from CI_DRM_5483 -> Patchwork_12038 Sum

Re: [Intel-gfx] [PATCH 26/33] drm/i915: Remove the intel_engine_notify tracepoint

2019-01-25 Thread Tvrtko Ursulin
On 25/01/2019 02:29, Chris Wilson wrote: The global seqno is defunct and so we have no meaningful indicator of forward progress for an engine. You need to listen to the request signaling tracepoints instead. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 2 -- drivers/

Re: [Intel-gfx] [PATCH 07/38] drm/i915: Stop tracking MRU activity on VMA

2019-01-25 Thread Tvrtko Ursulin
On 25/01/2019 13:46, Chris Wilson wrote: Quoting Chris Wilson (2019-01-25 13:38:09) Quoting Tvrtko Ursulin (2019-01-25 10:46:19) On 22/01/2019 14:19, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-18 16:03:27) On 18/01/2019 14:00, Chris Wilson wrote: Our goal is to remove struct_mute

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Measure the required reserved size for request emission (rev2)

2019-01-25 Thread Patchwork
== Series Details == Series: drm/i915: Measure the required reserved size for request emission (rev2) URL : https://patchwork.freedesktop.org/series/55683/ State : success == Summary == CI Bug Log - changes from CI_DRM_5480_full -> Patchwork_12036_full =

[Intel-gfx] [PATCH] drm/i915: Stop tracking MRU activity on VMA

2019-01-25 Thread Chris Wilson
Our goal is to remove struct_mutex and replace it with fine grained locking. One of the thorny issues is our eviction logic for reclaiming space for an execbuffer (or GTT mmaping, among a few other examples). While eviction itself is easy to move under a per-VM mutex, performing the activity tracki

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/5] drm/i915: Make all GPU resets atomic

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: Make all GPU resets atomic URL : https://patchwork.freedesktop.org/series/55730/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Make all GPU resets atomic Okay! Commit: drm

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/5] drm/i915: Make all GPU resets atomic

2019-01-25 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: Make all GPU resets atomic URL : https://patchwork.freedesktop.org/series/55730/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4273a708fc23 drm/i915: Make all GPU resets atomic -:33: CHECK:USLEEP_RANGE: usleep

Re: [Intel-gfx] [PATCH 07/38] drm/i915: Stop tracking MRU activity on VMA

2019-01-25 Thread Chris Wilson
Quoting Chris Wilson (2019-01-25 13:38:09) > Quoting Tvrtko Ursulin (2019-01-25 10:46:19) > > > > On 22/01/2019 14:19, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2019-01-18 16:03:27) > > >> > > >> On 18/01/2019 14:00, Chris Wilson wrote: > > >>> Our goal is to remove struct_mutex and replac

Re: [Intel-gfx] [PATCH 07/38] drm/i915: Stop tracking MRU activity on VMA

2019-01-25 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-25 10:46:19) > > On 22/01/2019 14:19, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-01-18 16:03:27) > >> > >> On 18/01/2019 14:00, Chris Wilson wrote: > >>> Our goal is to remove struct_mutex and replace it with fine grained > >>> locking. One of the thorny i

[Intel-gfx] [CI 5/5] drm/i915: Issue engine resets onto idle engines

2019-01-25 Thread Chris Wilson
Always perform the requested reset, even if we believe the engine is idle. Presumably there was a reason the caller wanted the reset, and in the near future we lose the easy tracking for whether the engine is idle. Signed-off-by: Chris Wilson Reviewed-by: John Harrison --- drivers/gpu/drm/i915/

  1   2   >