Re: [Intel-gfx] [PULL] drm-intel-next

2019-02-03 Thread Dave Airlie
On Sat, 2 Feb 2019 at 18:29, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > Here goes another pull request for 5.1. dim complained: Chris committed this without an S-O-B, now because it's all Intel this probably doesn't matter, so I'll pull it, put please try and let it not happen again.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/drv: Remove drm_dev_unplug()

2019-02-03 Thread Patchwork
== Series Details == Series: drm/drv: Remove drm_dev_unplug() URL : https://patchwork.freedesktop.org/series/56153/ State : success == Summary == CI Bug Log - changes from CI_DRM_5530_full -> Patchwork_12122_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/drv: Remove drm_dev_unplug()

2019-02-03 Thread Patchwork
== Series Details == Series: drm/drv: Remove drm_dev_unplug() URL : https://patchwork.freedesktop.org/series/56153/ State : success == Summary == CI Bug Log - changes from CI_DRM_5530 -> Patchwork_12122 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH 4/6] drm/udl: Use drm_dev_unregister()

2019-02-03 Thread Noralf Trønnes
drm_dev_unplug() has been stripped down and is going away. Open code its 2 remaining function calls. Cc: Dave Airlie Cc: Sean Paul Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/udl/udl_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 1/6] drm: Fix drm_release() and device unplug

2019-02-03 Thread Noralf Trønnes
If userspace has open fd(s) when drm_dev_unplug() is run, it will result in drm_dev_unregister() being called twice. First in drm_dev_unplug() and then later in drm_release() through the call to drm_put_dev(). Since userspace already holds a ref on drm_device through the drm_minor, it's not

[Intel-gfx] [PATCH 5/6] drm/xen: Use drm_dev_unregister()

2019-02-03 Thread Noralf Trønnes
drm_dev_unplug() has been stripped down and is going away. Open code its 2 remaining function calls. Also remove the drm_dev_is_unplugged() check since this can't be true before drm_dev_unregister() is called which happens after the check. Cc: Oleksandr Andrushchenko Signed-off-by: Noralf

[Intel-gfx] [PATCH 6/6] drm/drv: Remove drm_dev_unplug()

2019-02-03 Thread Noralf Trønnes
There are no users left. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_drv.c | 17 - include/drm/drm_drv.h | 1 - 2 files changed, 18 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index e0941200edc6..87210d4a9e53 100644 ---

[Intel-gfx] [PATCH 0/6] drm/drv: Remove drm_dev_unplug()

2019-02-03 Thread Noralf Trønnes
This series removes drm_dev_unplug() and moves the unplugged state setting to drm_dev_unregister(). All drivers will now have access to the unplugged state if they so desire. The drm_device ref handling wrt to the last fd closed after unregister have been simplified, which also fixed a double

[Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-03 Thread Noralf Trønnes
The only thing now that makes drm_dev_unplug() special is that it sets drm_device->unplugged. Move this code to drm_dev_unregister() so that we can remove drm_dev_unplug(). Signed-off-by: Noralf Trønnes --- Maybe s/unplugged/unregistered/ ? I looked at drm_device->registered, but using that

[Intel-gfx] [PATCH 3/6] drm/amd: Use drm_dev_unregister()

2019-02-03 Thread Noralf Trønnes
drm_dev_unplug() has been stripped down and is going away. Open code its 2 remaining function calls. Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1