Re: [Intel-gfx] [PATCH v11 24/42] mei: me: add ice lake point device ids

2019-02-06 Thread Daniel Vetter
On Thu, Feb 07, 2019 at 07:22:37AM +, C, Ramalingam wrote: > Sure. Intention was enabling the HDCP2.2 testing on CI for ICL. I will > drop this patch, instead I will cherry-pick the one you have published > for other branch. We still need this for merging in some form, otherwise CI on our end

[Intel-gfx] [PULL] drm-intel-fixes

2019-02-06 Thread Jani Nikula
Hi Dave and Daniel, i915 display fixes for v5.0-rc6. BR, Jani. The following changes since commit 8834f5600cf3c8db365e18a3d5cac2c2780c81e5: Linux 5.0-rc5 (2019-02-03 13:48:04 -0800) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-20

[Intel-gfx] [PATCH] drm/i915: Don't claim an unstarted request was guilty

2019-02-06 Thread Chris Wilson
If we haven't even begun executing the payload of the stalled request, then we should not claim that its userspace context was guilty of submitting a hanging batch. v2: Check for context corruption before trying to restart. v3: Preserve semaphores on skipping requests (need to keep the timelines i

Re: [Intel-gfx] [PATCH v11 24/42] mei: me: add ice lake point device ids

2019-02-06 Thread C, Ramalingam
Sure. Intention was enabling the HDCP2.2 testing on CI for ICL. I will drop this patch, instead I will cherry-pick the one you have published for other branch. Best Regards, Ramalingam C > -Original Message- > From: Winkler, Tomas > Sent: Thursday, February 7, 2019 12:47 PM > To: C, R

[Intel-gfx] [PATCH 3/8] drm/i915: Revoke mmaps and prevent access to fence registers across reset

2019-02-06 Thread Chris Wilson
Previously, we were able to rely on the recursive properties of struct_mutex to allow us to serialise revoking mmaps and reacquiring the FENCE registers with them being clobbered over a global device reset. I then proceeded to throw out the baby with the bath water in order to pursue a struct_mutex

[Intel-gfx] [PATCH 5/8] drm/i915: Uninterruptibly drain the timelines on unwedging

2019-02-06 Thread Chris Wilson
On wedging, we mark all executing requests as complete and all pending requests completed as soon as they are ready. Before unwedging though we wish to flush those pending requests prior to restoring default execution, and so we must wait. Do so interruptibly as we do not provide the EINTR graceful

[Intel-gfx] [PATCH 4/8] drm/i915: Force the GPU reset upon wedging

2019-02-06 Thread Chris Wilson
When declaring the GPU wedged, we do need to hit the GPU with the reset hammer so that its state matches our presumed state during cleanup. If the reset fails, it fails, and we may be unhappy but wedged. However, if we are testing our wedge/unwedged handling, the desync carries over into the next t

[Intel-gfx] [PATCH 2/8] drm/i915: Defer removing fence register tracking to rpm wakeup

2019-02-06 Thread Chris Wilson
Currently, we may simultaneously release the fence register from both fence_update() and i915_gem_restore_fences(). This is dangerous, so defer the bookkeeping entirely to i915_gem_restore_fences() when the device is asleep. Reported-by: Mika Kuoppala Signed-off-by: Chris Wilson Cc: Mika Kuoppal

[Intel-gfx] [PATCH 8/8] drm/i915: Don't claim an unstarted request was guilty

2019-02-06 Thread Chris Wilson
If we haven't even begun executing the payload of the stalled request, then we should not claim that its userspace context was guilty of submitting a hanging batch. v2: Check for context corruption before trying to restart. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_lrc.c

[Intel-gfx] [PATCH 7/8] drm/i915: Serialise resets with wedging

2019-02-06 Thread Chris Wilson
Prevent concurrent set-wedge with ongoing resets (and vice versa) by taking the same wedge_mutex around both operations. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_reset.c | 68 ++- 1 file changed, 40 insertions(+), 28 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 6/8] drm/i915: Wait for old resets before applying debugfs/i915_wedged

2019-02-06 Thread Chris Wilson
Since we use the debugfs to recover the device after modifying the i915.reset parameter, we need to be sure that we apply the reset and not piggy-back onto a concurrent one in order for the parameter to take effect. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 10 +++

[Intel-gfx] [PATCH 1/8] drm/i915: Hack and slash, throttle execbuffer hogs

2019-02-06 Thread Chris Wilson
Apply backpressure to hogs that emit requests faster than the GPU can process them by waiting for their ring to be less than half-full before proceeding with taking the struct_mutex. This is a gross hack to apply throttling backpressure, the long term goal is to remove the struct_mutex contention

Re: [Intel-gfx] [PATCH v11 24/42] mei: me: add ice lake point device ids

2019-02-06 Thread Winkler, Tomas
> > From: Tomas Winkler > > Add icelake device ids: ICP LP, N and H > > Signed-off-by: Tomas Winkler NACK, this goes via mei driver submission process. Please drop it from the series. > --- > drivers/misc/mei/hw-me-regs.h | 4 > drivers/misc/mei/pci-me.c | 4 > 2 files change

Re: [Intel-gfx] [PATCH] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-06 Thread Daniel Vetter
On Mon, Feb 04, 2019 at 09:14:40PM +0530, Ramalingam C wrote: > The downgrade of the fullmodeset into fastset > intel_encoder->update_pipe, in possible scenario, skips the En/Dis-able > DDI. Hence breaks the HDCP state change handling. > > We also don't have any hdcp tests in CI, because the shard

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add pipe crc tracepoint

2019-02-06 Thread kbuild test robot
Hi Ville, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on next-20190206] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add pipe crc tracepoint

2019-02-06 Thread kbuild test robot
Hi Ville, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190206] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Implement HDCP2.2 (rev17)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev17) URL : https://patchwork.freedesktop.org/series/38254/ State : success == Summary == CI Bug Log - changes from CI_DRM__full -> Patchwork_12164_full Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/dsc: Add kernel documentation for DRM DP DSC helpers (rev3)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/dsc: Add kernel documentation for DRM DP DSC helpers (rev3) URL : https://patchwork.freedesktop.org/series/56206/ State : success == Summary == CI Bug Log - changes from CI_DRM__full -> Patchwork_12163_full ==

Re: [Intel-gfx] [PATCH v4] drm/i915/psr: Execute the default PSR code path when setting i915_edp_psr_debug

2019-02-06 Thread Dhinakaran Pandiyan
On Wed, 2019-02-06 at 13:18 -0800, José Roberto de Souza wrote: > Changing the i915_edp_psr_debug was enabling, disabling or switching > PSR version by directly calling intel_psr_disable_locked() and > intel_psr_enable_locked(), what is not the default PSR path that will > be executed by real users

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Execute the default PSR code path when setting i915_edp_psr_debug (rev4)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915/psr: Execute the default PSR code path when setting i915_edp_psr_debug (rev4) URL : https://patchwork.freedesktop.org/series/56013/ State : success == Summary == CI Bug Log - changes from CI_DRM__full -> Patchwork_12162_full ==

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Add pipe crc tracepoint

2019-02-06 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Add pipe crc tracepoint URL : https://patchwork.freedesktop.org/series/56309/ State : success == Summary == CI Bug Log - changes from CI_DRM__full -> Patchwork_12161_full

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Just use icl+ definition for PLANE_WM blocks field

2019-02-06 Thread Souza, Jose
On Wed, 2019-02-06 at 15:18 +0200, Ville Syrjälä wrote: > On Wed, Feb 06, 2019 at 01:04:19AM +, Souza, Jose wrote: > > On Tue, 2019-02-05 at 22:50 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The unused bits on PLANE_WM & co. are hardwired to zero. So no > > > need to wor

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Implement HDCP2.2 (rev17)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev17) URL : https://patchwork.freedesktop.org/series/38254/ State : success == Summary == CI Bug Log - changes from CI_DRM_ -> Patchwork_12164 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Implement HDCP2.2 (rev17)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev17) URL : https://patchwork.freedesktop.org/series/38254/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: component: Add documentation Okay! Commit: components: multiple components for a devi

Re: [Intel-gfx] [PATCH 2/3] components: multiple components for a device

2019-02-06 Thread Rafael J. Wysocki
) On Wed, Feb 6, 2019 at 5:46 PM Daniel Vetter wrote: > > Component framework is extended to support multiple components for > a struct device. These will be matched with different masters based on > its sub component value. > > We are introducing this, as I915 needs two different components > wit

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 (rev17)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915: Implement HDCP2.2 (rev17) URL : https://patchwork.freedesktop.org/series/38254/ State : warning == Summary == $ dim checkpatch origin/drm-tip 516981139a84 component: Add documentation -:38: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/dsc: Add kernel documentation for DRM DP DSC helpers (rev3)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/dsc: Add kernel documentation for DRM DP DSC helpers (rev3) URL : https://patchwork.freedesktop.org/series/56206/ State : success == Summary == CI Bug Log - changes from CI_DRM_ -> Patchwork_12163 Summar

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't set update_wm_post on g4x+

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915: Don't set update_wm_post on g4x+ URL : https://patchwork.freedesktop.org/series/56303/ State : success == Summary == CI Bug Log - changes from CI_DRM_5553_full -> Patchwork_12160_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Execute the default PSR code path when setting i915_edp_psr_debug (rev4)

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915/psr: Execute the default PSR code path when setting i915_edp_psr_debug (rev4) URL : https://patchwork.freedesktop.org/series/56013/ State : success == Summary == CI Bug Log - changes from CI_DRM_ -> Patchwork_12162

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Add pipe crc tracepoint

2019-02-06 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Add pipe crc tracepoint URL : https://patchwork.freedesktop.org/series/56309/ State : success == Summary == CI Bug Log - changes from CI_DRM_ -> Patchwork_12161 Summary -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Nuke drm_calc_{h,v}scale_relaxed()

2019-02-06 Thread Patchwork
== Series Details == Series: drm: Nuke drm_calc_{h,v}scale_relaxed() URL : https://patchwork.freedesktop.org/series/56300/ State : success == Summary == CI Bug Log - changes from CI_DRM_5553_full -> Patchwork_12159_full Summary --- *

[Intel-gfx] [PATCH v11 42/42] FOR_TESTING_ONLY: ICL: Limit clk to <= 340MHz

2019-02-06 Thread Ramalingam C
Pruning 4k60 modes. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index c2c91e6645a5..d60713cd658c 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++

Re: [Intel-gfx] [PATCH v11 08/42] drm/i915: MEI interface definition

2019-02-06 Thread C, Ramalingam
Daniel, Due to significant changes @unbind and cleanup, i have dropped your r-b. Please review it again. --Ram On 2/7/2019 2:33 AM, Ramalingam C wrote: Defining the mei-i915 interface functions and initialization of the interface. v2: Adjust to the new interface changes. [Tomas] Added

[Intel-gfx] [PATCH v3] drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-06 Thread Manasi Navare
This patch adds appropriate kernel documentation for DRM DP helpers used for enabling Display Stream compression functionality in drm_dp_helper.h and drm_dp_helper.c as well as for the DSC spec related structure definitions and helpers in drm_dsc.c and drm_dsc.h Also add links between the functions

Re: [Intel-gfx] [PATCH] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-06 Thread C, Ramalingam
Daniel, Could we process this for merger? Or anything is pending from myside? --Ram On 2/4/2019 9:14 PM, Ramalingam C wrote: The downgrade of the fullmodeset into fastset intel_encoder->update_pipe, in possible scenario, skips the En/Dis-able DDI. Hence breaks the HDCP state change handling.

Re: [Intel-gfx] [PATCH v10 25/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-06 Thread C, Ramalingam
On 2/6/2019 3:57 PM, Winkler, Tomas wrote: Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init m

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Add pipe crc tracepoint

2019-02-06 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Add pipe crc tracepoint URL : https://patchwork.freedesktop.org/series/56309/ State : warning == Summary == $ dim checkpatch origin/drm-tip f8b2e309e24f drm/i915: Add pipe crc tracepoint -:56: CHECK:OPEN_ENDED_LINE: Lines should

[Intel-gfx] [PATCH v4] drm/i915/psr: Execute the default PSR code path when setting i915_edp_psr_debug

2019-02-06 Thread José Roberto de Souza
Changing the i915_edp_psr_debug was enabling, disabling or switching PSR version by directly calling intel_psr_disable_locked() and intel_psr_enable_locked(), what is not the default PSR path that will be executed by real users. So lets force a fastset in the PSR CRTC to trigger a pipe update and

[Intel-gfx] [PATCH v11 40/42] FOR_TEST_ONLY: i915/Kconfig: Select mei_hdcp by I915

2019-02-06 Thread Ramalingam C
FOR TESTING PURPOSE ONLY. By default INTEL_MEI_HDCP is set to y. This patch is created to test the interface between I915 and MEI_HDCP. Signed-off-by: Ramalingam C --- drivers/misc/mei/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfi

[Intel-gfx] [PATCH v11 38/42] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2019-02-06 Thread Ramalingam C
Request the ME to terminate the HDCP2.2 session for a port. On Success, ME FW will mark the intel port as Deauthenticated and terminate the wired HDCP2.2 Tx session started due to the cmd WIRED_INITIATE_HDCP2_SESSION. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comme

[Intel-gfx] [PATCH v11 37/42] misc/mei/hdcp: Enabling the HDCP authentication

2019-02-06 Thread Ramalingam C
Request to ME to configure a port as authenticated. On Success, ME FW will mark the port as authenticated and provides HDCP cipher with the encryption keys. Enabling the Authentication can be requested once all stages of HDCP2.2 authentication is completed by interacting with ME FW. Only after t

[Intel-gfx] [PATCH v11 41/42] FOR_TESTING_ONLY: debugfs: Excluding the LSPCon for HDCP1.4

2019-02-06 Thread Ramalingam C
Just excluding the LSPCon HDMI ports from the HDCP1.4 testing. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/i915_debugfs.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 0bd89

[Intel-gfx] [PATCH v11 39/42] misc/mei/hdcp: Component framework for I915 Interface

2019-02-06 Thread Ramalingam C
Mei hdcp driver is designed as component slave for the I915 component master. v2: Rebased. v3: Notifier chain is adopted for cldev state update [Tomas] v4: Made static dummy functions as inline in mei_hdcp.h API for polling client device status IS_ENABLED used in header, for config status

[Intel-gfx] [PATCH v11 33/42] misc/mei/hdcp: Verify L_prime

2019-02-06 Thread Ramalingam C
Request to ME to verify the LPrime received from HDCP sink. On Success, ME FW will verify the received Lprime by calculating and comparing with L. This represents the completion of Locality Check. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are rem

[Intel-gfx] [PATCH v11 36/42] misc/mei/hdcp: Verify M_prime

2019-02-06 Thread Ramalingam C
Request to ME to verify the M_Prime received from the HDCP sink. ME FW will calculate the M and compare with M_prime received as part of RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. On successful completion of this stage, downstream propagation of the stream management info is comple

[Intel-gfx] [PATCH v11 34/42] misc/mei/hdcp: Prepare Session Key

2019-02-06 Thread Ramalingam C
Request to ME to prepare the encrypted session key. On Success, ME provides Encrypted session key. Function populates the HDCP2.2 authentication msg SKE_Send_Eks. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas] v4: %zd for ssize_t

[Intel-gfx] [PATCH v11 30/42] misc/mei/hdcp: Verify H_prime

2019-02-06 Thread Ramalingam C
Requests for the verification of AKE_Send_H_prime. ME will calculate the H and comparing it with received H_Prime. The result will be returned as status. Here AKE_Send_H_prime is a HDCP2.2 Authentication msg. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and

[Intel-gfx] [PATCH v11 21/42] drm/i915: HDCP state handling in ddi_update_pipe

2019-02-06 Thread Ramalingam C
The downgrade of the fullmodeset into fastset intel_encoder->update_pipe, in possible scenario, skips the En/Dis-able DDI. Hence breaks the HDCP state change handling. We also don't have any hdcp tests in CI, because the shard runs don't have hdcp capable outputs :-/ So this change fixs it by han

[Intel-gfx] [PATCH v11 22/42] drm/i915: Fix KBL HDCP2.2 encrypt status signalling

2019-02-06 Thread Ramalingam C
HDCP transmitter is supposed to indicate the HDCP encryption status of the link through enc_en signals in a window of time called "window of opportunity" defined by HDCP HDMI spec. But on KBL this timing of signalling has an issue. To fix the issue this WA of resetting the signalling is required.

[Intel-gfx] [PATCH v11 29/42] misc/mei/hdcp: Verify Receiver Cert and prepare km

2019-02-06 Thread Ramalingam C
Requests for verification for receiver certification and also the preparation for next AKE auth message with km. On Success ME FW validate the HDCP2.2 receivers certificate and do the revocation check on the receiver ID. AKE_Stored_Km will be prepared if the receiver is already paired, else AKE_No

[Intel-gfx] [PATCH v11 27/42] misc/mei/hdcp: Define ME FW interface for HDCP2.2

2019-02-06 Thread Ramalingam C
Defines the HDCP specific ME FW interfaces such as Request CMDs, payload structure for CMDs and their response status codes. This patch defines payload size(Excluding the Header)for each WIRED HDCP2.2 CMDs. v2: Rebased. v3: Extra comments are removed. v4: %s/\/\*\*/\/\* v5: Extra lines are

[Intel-gfx] [PATCH v11 10/42] drm/i915: Enable and Disable of HDCP2.2

2019-02-06 Thread Ramalingam C
Considering that HDCP2.2 is more secure than HDCP1.4, When a setup supports HDCP2.2 and HDCP1.4, HDCP2.2 will be enabled. When HDCP2.2 enabling fails and HDCP1.4 is supported, HDCP1.4 is enabled. This change implements a sequence of enabling and disabling of HDCP2.2 authentication and HDCP2.2 por

[Intel-gfx] [PATCH v11 12/42] drm: helper functions for hdcp2 seq_num to from u32

2019-02-06 Thread Ramalingam C
Library functions for endianness are aligned for 16/32/64 bits. But hdcp sequence numbers are 24bits(big endian). So for their conversion to and from u32 helper functions are developed. v2: Comment is updated. [Daniel] Reviewed-by Uma. Signed-off-by: Ramalingam C Reviewed-by: Daniel Vetter

[Intel-gfx] [PATCH v11 13/42] drm/i915: Implement HDCP2.2 repeater authentication

2019-02-06 Thread Ramalingam C
Implements the HDCP2.2 repeaters authentication steps such as verifying the downstream topology and sending stream management information. v2: Rebased. v3: -EINVAL is returned for topology error and rollover scenario. Endianness conversion func from drm_hdcp.h is used [Uma] v4: Rebased as pa

[Intel-gfx] [PATCH v11 32/42] misc/mei/hdcp: Initiate Locality check

2019-02-06 Thread Ramalingam C
Requests ME to start the second stage of HDCP2.2 authentication, called Locality Check. On Success, ME FW will provide LC_Init message to send to hdcp sink. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas] v4: %zd used for ssize_t [

[Intel-gfx] [PATCH v11 31/42] misc/mei/hdcp: Store the HDCP Pairing info

2019-02-06 Thread Ramalingam C
Provides Pairing info to ME to store. Pairing is a process to fast track the subsequent authentication with the same HDCP sink. On Success, received HDCP pairing info is stored in non-volatile memory of ME. v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and ca

[Intel-gfx] [PATCH v11 35/42] misc/mei/hdcp: Repeater topology verification and ack

2019-02-06 Thread Ramalingam C
Request ME to verify the downstream topology information received. ME FW will validate the Repeaters receiver id list and downstream topology. On Success ME FW will provide the Least Significant 128bits of VPrime, which forms the repeater ack. v2: Rebased. v3: cldev is passed as first paramete

[Intel-gfx] [PATCH v11 28/42] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-06 Thread Ramalingam C
Request ME FW to start the HDCP2.2 session for an intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init message. v2: Rebased. v3: cldev is add as a sepa

[Intel-gfx] [PATCH v11 23/42] mei: bus: whitelist hdcp client

2019-02-06 Thread Ramalingam C
From: Tomas Winkler Whitelist HDCP client for in kernel drm use v2: Rebased. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index 80215c312f0e..5f

[Intel-gfx] [PATCH v11 25/42] mei: bus: export to_mei_cl_device for mei client device drivers

2019-02-06 Thread Ramalingam C
From: Tomas Winkler Export to_mei_cl_device macro, it is needed also in mei client drivers. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 1 - include/linux/mei_cl_bus.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/

[Intel-gfx] [PATCH v11 24/42] mei: me: add ice lake point device ids

2019-02-06 Thread Ramalingam C
From: Tomas Winkler Add icelake device ids: ICP LP, N and H Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 4 drivers/misc/mei/pci-me.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h index 23739a

[Intel-gfx] [PATCH v11 26/42] misc/mei/hdcp: Client driver for HDCP application

2019-02-06 Thread Ramalingam C
ME FW contributes a vital role in HDCP2.2 authentication. HDCP2.2 driver needs to communicate to ME FW for each step of the HDCP2.2 authentication. ME FW prepare and HDCP2.2 authentication parameters and encrypt them as per spec. With such parameter Driver prepares HDCP2.2 auth messages and commu

[Intel-gfx] [PATCH v11 14/42] drm: HDCP2.2 link check period

2019-02-06 Thread Ramalingam C
Time period for HDCP2.2 link check. Signed-off-by: Ramalingam C Reviewed-by: Daniel Vetter Reviewed-by: Uma Shankar --- include/drm/drm_hdcp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index 7260b31af276..d4e98b11b4aa 100644 --- a/inclu

[Intel-gfx] [PATCH v11 15/42] drm/i915: Implement HDCP2.2 link integrity check

2019-02-06 Thread Ramalingam C
Implements the link integrity check once in 500mSec. Once encryption is enabled, an ongoing Link Integrity Check is performed by the HDCP Receiver to check that cipher synchronization is maintained between the HDCP Transmitter and the HDCP Receiver. On the detection of synchronization lost, the H

[Intel-gfx] [PATCH v11 05/42] drm/i915: Gathering the HDCP1.4 routines together

2019-02-06 Thread Ramalingam C
All HDCP1.4 routines are gathered together, followed by the generic functions those can be extended for HDCP2.2 too. Signed-off-by: Ramalingam C Acked-by: Daniel Vetter Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/intel_hdcp.c | 118 +++--- 1 file changed,

[Intel-gfx] [PATCH v11 17/42] drm: removing the DP Errata msg and its msg id

2019-02-06 Thread Ramalingam C
Since DP ERRATA message is not defined at spec, those structure definition is removed from drm_hdcp.h Signed-off-by: Ramalingam C Suggested-by: Daniel Vetter Reviewed-by: Daniel Vetter Reviewed-by: Uma Shankar --- include/drm/drm_hdcp.h | 6 -- 1 file changed, 6 deletions(-) diff --git a

[Intel-gfx] [PATCH v11 18/42] drm/i915: Implement the HDCP2.2 support for DP

2019-02-06 Thread Ramalingam C
Implements the DP adaptation specific HDCP2.2 functions. These functions perform the DPCD read and write for communicating the HDCP2.2 auth message back and forth. v2: wait for cp_irq is merged with this patch. Rebased. v3: wait_queue is used for wait for cp_irq [Chris Wilson] v4: Style fix

[Intel-gfx] [PATCH v11 20/42] drm/i915: CP_IRQ handling for DP HDCP2.2 msgs

2019-02-06 Thread Ramalingam C
Implements the Waitqueue is created to wait for CP_IRQ Signaling the CP_IRQ arrival through atomic variable. For applicable DP HDCP2.2 msgs read wait for CP_IRQ. As per HDCP2.2 spec "HDCP Transmitters must process CP_IRQ interrupts when they are received from HDCP Receivers

[Intel-gfx] [PATCH v11 19/42] drm/i915: Implement the HDCP2.2 support for HDMI

2019-02-06 Thread Ramalingam C
Implements the HDMI adaptation specific HDCP2.2 operations. Basically these are DDC read and write for authenticating through HDCP2.2 messages. v2: Rebased. v3: No more special handling of Gmbus burst read for AKE_SEND_CERT. Style fixed with few naming. [Uma] %s/PARING/PAIRING v4: msg_sz

[Intel-gfx] [PATCH v11 16/42] drm/i915: Handle HDCP2.2 downstream topology change

2019-02-06 Thread Ramalingam C
When repeater notifies a downstream topology change, this patch reauthenticate the repeater alone without disabling the hdcp encryption. If that fails then complete reauthentication is executed. v2: Rebased. v3: Typo in commit msg is fixed [Uma] v4: Rebased as part of patch reordering. Min

[Intel-gfx] [PATCH v11 07/42] drm/i915: Initialize HDCP2.2

2019-02-06 Thread Ramalingam C
Add the HDCP2.2 initialization to the existing HDCP1.4 stack. v2: mei interface handle is protected with mutex. [Chris Wilson] v3: Notifiers are used for the mei interface state. v4: Poll for mei client device state Error msg for out of mem [Uma] Inline req for init function removed [Uma

[Intel-gfx] [PATCH v11 09/42] drm/i915: hdcp1.4 CP_IRQ handling and SW encryption tracking

2019-02-06 Thread Ramalingam C
"hdcp_encrypted" flag is defined to denote the HDCP1.4 encryption status. This SW tracking is used to determine the need for real hdcp1.4 disable and hdcp_check_link upon CP_IRQ. On CP_IRQ we filter the CP_IRQ related to the states like Link failure and reauthentication req etc and handle them in

[Intel-gfx] [PATCH v11 11/42] drm/i915: Implement HDCP2.2 receiver authentication

2019-02-06 Thread Ramalingam C
Implements HDCP2.2 authentication for hdcp2.2 receivers, with following steps: Authentication and Key exchange (AKE). Locality Check (LC). Session Key Exchange(SKE). DP Errata for stream type configuration for receivers. At AKE, the HDCP Receiver’s public key certif

[Intel-gfx] [PATCH v11 06/42] drm: header for i915 - MEI_HDCP interface

2019-02-06 Thread Ramalingam C
Header defines the interface for the I915 and MEI_HDCP drivers. This interface is specific to the usage of mei_hdcp from gen9+ platforms for ME FW based HDCP2.2 services. And Generic HDCP2.2 protocol specific definitions are added at drm/drm_hdcp.h. v2: Commit msg is enhanced [Daniel] v3: i91

[Intel-gfx] [PATCH v11 00/42] drm/i915: Implement HDCP2.2

2019-02-06 Thread Ramalingam C
This series enables the HDCP2.2 Type 0 for I915. The sequence for HDCP2.2 authentication and encryption is implemented as a generic flow between HDMI and DP. Encoder specific implementations are moved into hdcp_shim. Intel HWs supports HDCP2.2 through ME FW. Hence this series introduces a client d

[Intel-gfx] [PATCH v11 01/42] component: Add documentation

2019-02-06 Thread Ramalingam C
From: Daniel Vetter While typing these I think doing an s/component_master/aggregate/ would be useful: - it's shorter :-) - I think component/aggregate is much more meaningful naming than component/puppetmaster or something like that. At least to my English ear "aggregate" emphasizes much mor

[Intel-gfx] [PATCH v11 08/42] drm/i915: MEI interface definition

2019-02-06 Thread Ramalingam C
Defining the mei-i915 interface functions and initialization of the interface. v2: Adjust to the new interface changes. [Tomas] Added further debug logs for the failures at MEI i/f. port in hdcp_port data is equipped to handle -ve values. v3: mei comp is matched for global i915 comp master

[Intel-gfx] [PATCH v11 04/42] i915/snd_hdac: I915 subcomponent for the snd_hdac

2019-02-06 Thread Ramalingam C
From: Daniel Vetter Since we need multiple components for I915 for different purposes (Audio & Mei_hdcp), we adopt the subcomponents methodology introduced by the previous patch (mentioned below). Author: Daniel Vetter Date: Mon Jan 28 17:08:20 2019 +0530 componen

[Intel-gfx] [PATCH v11 03/42] drm/doc: document recommended component helper usage

2019-02-06 Thread Ramalingam C
From: Daniel Vetter Now that component has docs it's worth spending a few words and hyperlinks on recommended best practices in drm. Cc: Russell King - ARM Linux admin Signed-off-by: Daniel Vetter --- Documentation/driver-api/component.rst | 2 ++ Documentation/gpu/drm-internals.rst| 5

[Intel-gfx] [PATCH v11 02/42] components: multiple components for a device

2019-02-06 Thread Ramalingam C
From: Daniel Vetter Component framework is extended to support multiple components for a struct device. These will be matched with different masters based on its sub component value. We are introducing this, as I915 needs two different components with different subcomponent value, which will be

[Intel-gfx] [PATCH 2/4] drm/i915: Add pipe enable/disable tracepoints

2019-02-06 Thread Ville Syrjala
From: Ville Syrjälä Add tracepoints for pipe enable/disable. We'll include the frame/scanline counters for all pipes in these tracepoints to help in diagnosing underruns and whatnot when enabling/disabling pipes in parallel with plane updates/flips on another pipe. Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH 1/4] drm/i915: Add pipe crc tracepoint

2019-02-06 Thread Ville Syrjala
From: Ville Syrjälä Add a tracepoint for pipe crc. Makes life much simpler when staring at traces when hunting for fifo underruns and other issues which cause corrupted frames. We'll add the tracepoint before filtering out any potentially bogus crcs during modeset (should actually verify if that

[Intel-gfx] [PATCH 3/4] drm/i915: Add overlooked plane disable tracepoint into intel_crtc_disable_planes()

2019-02-06 Thread Ville Syrjala
From: Ville Syrjälä intel_crtc_disable_planes() disables the planes so it should trigger the appropriate tracepoint. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 4/4] drm/i915: Wrap plane update/disable hook calls

2019-02-06 Thread Ville Syrjala
From: Ville Syrjälä Wrap the .update_plane()/.update_slave()/.disable_plane() vfunc calls into helpers which also take care to emit the appropriate tracepoint. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_atomic_plane.c | 49 +-- drivers/gpu/drm/i915/intel_di

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-06 Thread Daniel Vetter
On Wed, Feb 06, 2019 at 05:46:51PM +0100, Noralf Trønnes wrote: > > > Den 06.02.2019 16.26, skrev Daniel Vetter: > > On Tue, Feb 05, 2019 at 06:57:50PM +0100, Noralf Trønnes wrote: > >> > >> > >> Den 05.02.2019 17.31, skrev Daniel Vetter: > >>> On Tue, Feb 05, 2019 at 11:20:55AM +0100, Noralf Trø

[Intel-gfx] ✓ Fi.CI.IGT: success for Support 64 bpp half float formats (rev5)

2019-02-06 Thread Patchwork
== Series Details == Series: Support 64 bpp half float formats (rev5) URL : https://patchwork.freedesktop.org/series/53212/ State : success == Summary == CI Bug Log - changes from CI_DRM_5552_full -> Patchwork_12158_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't set update_wm_post on g4x+

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915: Don't set update_wm_post on g4x+ URL : https://patchwork.freedesktop.org/series/56303/ State : success == Summary == CI Bug Log - changes from CI_DRM_5553 -> Patchwork_12160 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH v3 1/3] drm/i915: Block fbdev HPD processing during suspend

2019-02-06 Thread Lyude Paul
On Wed, 2019-01-30 at 14:46 +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 0e32b39ceed6 drm/i915: add DP 1.2 MST support (v0.7). > > The bot has tested the following trees: v4.20.5, v4.19.18

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: Don't send hotplug in intel_dp_check_mst_status()

2019-02-06 Thread Ville Syrjälä
On Tue, Jan 29, 2019 at 02:10:01PM -0500, Lyude Paul wrote: > This hotplug also isn't needed: drm_dp_mst_topology_mgr_set_mst() > already sends a hotplug on its own from drm_dp_destroy_connector_work() > after destroying connectors in the MST topology. > > Signed-off-by: Lyude Paul > Cc: Imre Dea

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915: Don't send MST hotplugs during resume

2019-02-06 Thread Ville Syrjälä
On Tue, Jan 29, 2019 at 02:10:00PM -0500, Lyude Paul wrote: > We have a bad habit of calling drm_fb_helper_hotplug_event() far more > then we actually need to. MST appears to be one of these cases, where we > call drm_fb_helper_hotplug_event() if we fail to resume a connected MST > topology in inte

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Nuke drm_calc_{h,v}scale_relaxed()

2019-02-06 Thread Patchwork
== Series Details == Series: drm: Nuke drm_calc_{h,v}scale_relaxed() URL : https://patchwork.freedesktop.org/series/56300/ State : success == Summary == CI Bug Log - changes from CI_DRM_5553 -> Patchwork_12159 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH] drm/i915: Don't set update_wm_post on g4x+

2019-02-06 Thread Rodrigo Vivi
On Wed, Feb 06, 2019 at 08:54:33PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > update_wm_post is meant for pre-g4x only. Don't ever set > it on g4x+. > > The only effect of a bogus update_wm_post on g4x+ could > be that we clear the legacy_cursor_update flag in > intel_atomic_commit().

[Intel-gfx] [PATCH] drm/i915: Don't set update_wm_post on g4x+

2019-02-06 Thread Ville Syrjala
From: Ville Syrjälä update_wm_post is meant for pre-g4x only. Don't ever set it on g4x+. The only effect of a bogus update_wm_post on g4x+ could be that we clear the legacy_cursor_update flag in intel_atomic_commit(). Since legacy_cursor_update is only set for legacy cursor updates (as the name

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Defer removing fence register tracking to rpm wakeup

2019-02-06 Thread Patchwork
== Series Details == Series: drm/i915: Defer removing fence register tracking to rpm wakeup URL : https://patchwork.freedesktop.org/series/56291/ State : success == Summary == CI Bug Log - changes from CI_DRM_5552_full -> Patchwork_12156_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for Support 64 bpp half float formats (rev5)

2019-02-06 Thread Patchwork
== Series Details == Series: Support 64 bpp half float formats (rev5) URL : https://patchwork.freedesktop.org/series/53212/ State : success == Summary == CI Bug Log - changes from CI_DRM_5552 -> Patchwork_12158 Summary --- **SUCCESS*

Re: [Intel-gfx] [PATCH] drm: Nuke drm_calc_{h,v}scale_relaxed()

2019-02-06 Thread Alex Deucher
On Wed, Feb 6, 2019 at 1:32 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > The fuzzy drm_calc_{h,v}scale_relaxed() helpers are no longer used. > Throw them in the bin. > > Signed-off-by: Ville Syrjälä Acked-by: Alex Deucher > --- > drivers/gpu/drm/drm_rect.c | 108 --

[Intel-gfx] [PATCH] drm: Nuke drm_calc_{h,v}scale_relaxed()

2019-02-06 Thread Ville Syrjala
From: Ville Syrjälä The fuzzy drm_calc_{h,v}scale_relaxed() helpers are no longer used. Throw them in the bin. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_rect.c | 108 - include/drm/drm_rect.h | 6 --- 2 files changed, 114 deletions(-) diff

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Support 64 bpp half float formats (rev5)

2019-02-06 Thread Patchwork
== Series Details == Series: Support 64 bpp half float formats (rev5) URL : https://patchwork.freedesktop.org/series/53212/ State : warning == Summary == $ dim checkpatch origin/drm-tip e6ee4ac0d854 drm/fourcc: Add 64 bpp half float formats -:40: WARNING:LONG_LINE: line over 100 characters #40

Re: [Intel-gfx] [PATCH 2/6] drm/drv: Prepare to remove drm_dev_unplug()

2019-02-06 Thread Eric Anholt
Daniel Vetter writes: > > Zooming out more looking at the big picture I'd say all your work in the > past few years has enormously simplified drm for simple drivers already. > If we can't resolve this one here right now that just means you "only" > made drm 98% simpler instead of maybe 99%. It's s

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/i915: Hack and slash, throttle execbuffer hogs

2019-02-06 Thread Chris Wilson
Quoting Patchwork (2019-02-06 18:01:31) > == Series Details == > > Series: series starting with [1/8] drm/i915: Hack and slash, throttle > execbuffer hogs > URL : https://patchwork.freedesktop.org/series/56294/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5552 -> P

  1   2   3   >