Re: [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_isolation: Sanitycheck nonpriv access

2019-03-01 Thread Chris Wilson
Quoting Dale B Stimson (2019-03-01 00:36:10) > On Sat, Feb 23, 2019 at 09:45:10AM +, Chris Wilson wrote: > > Verify that our list of nonpriv registers exist and are writable. > > > > Signed-off-by: Chris Wilson > > Cc: Dale B Stimson > > Cc: Tvrtko Ursulin > > Cc: Joonas Lahtinen > > --- >

[Intel-gfx] [PATCH i-g-t] i915/gem_ctx_isolation: Sanitycheck nonpriv access

2019-03-01 Thread Chris Wilson
Verify that our list of nonpriv registers exist and are writable. v2: TD_CTL has a write_mask of 0x instead of being a masked register. Signed-off-by: Chris Wilson Cc: Dale B Stimson Cc: Tvrtko Ursulin Cc: Joonas Lahtinen --- tests/i915/gem_ctx_isolation.c | 167 +

[Intel-gfx] [PATCH 2/6] drm/i915: Preparations for enabling P010, P012, P016 formats

2019-03-01 Thread swati2 . sharma
From: Juha-Pekka Heikkila Preparations for enabling P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +- drivers/

[Intel-gfx] [PATCH 1/6] drm/i915: Add P010, P012, P016 plane control definitions

2019-03-01 Thread swati2 . sharma
From: Juha-Pekka Heikkila Add needed plane control flag definitions for P010, P012 and P016 formats. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driver

[Intel-gfx] [PATCH 4/6] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-03-01 Thread swati2 . sharma
From: Swati Sharma The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies 32bit. Y210: For each component, valid data occupies MSB 10 bits. LSB 6 bits are filled with

[Intel-gfx] [PATCH 0/6] Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats

2019-03-01 Thread swati2 . sharma
From: Swati Sharma This patch series is for enabling P0xx, Y2xx and Y4xx pixel formats for intel's i915 driver. In this patch series, Juha Pekka's patch series Gen10+ P0xx formats https://patchwork.freedesktop.org/series/56053/ is combined with Swati's https://patchwork.freedesktop.org/series/55

[Intel-gfx] [PATCH 3/6] drm/i915: Enable P010, P012, P016 formats for primary and sprite planes

2019-03-01 Thread swati2 . sharma
From: Juha-Pekka Heikkila Enabling of P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_sprite.c | 28 ++-- 1

[Intel-gfx] [PATCH 6/6] drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes

2019-03-01 Thread swati2 . sharma
From: Swati Sharma Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 30 ++ drivers/gpu/drm/i915/intel_sprite.c | 60 +++- 2 fil

[Intel-gfx] [PATCH 5/6] drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions

2019-03-01 Thread swati2 . sharma
From: Swati Sharma Added needed plane control flag definitions for Y2xx and Y4xx (10, 12 and 16 bits) Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ 1 file changed, 6 i

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3)

2019-03-01 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3) URL : https://patchwork.freedesktop.org/series/56606/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5ce21c7dd534 drm/i915: Add P010, P012, P016 plane control definitions 9096b3421086 drm/

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3)

2019-03-01 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3) URL : https://patchwork.freedesktop.org/series/56606/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add P010, P012, P016 plane control definitions Oka

Re: [Intel-gfx] [PATCH 4/6] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-03-01 Thread Sharma, Swati2
On 15-Feb-19 2:12 AM, Juha-Pekka Heikkilä wrote: Swati Sharma kirjoitti 13.2.2019 klo 15.25: The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies 32bit. Y210:    For each

[Intel-gfx] [PATCH v2] drm/i915/selftests: Check that whitelisted registers are accessible

2019-03-01 Thread Chris Wilson
There is no point in whitelisting a register that the user then cannot write to, so check the register exists before merging such patches. v2: Mark SLICE_COMMON_ECO_CHICKEN1 [731c] as write-only Signed-off-by: Chris Wilson Cc: Dale B Stimson Cc: Michał Winiarski --- .../drm/i915/selftests/int

[Intel-gfx] [PATCH v3] drm/i915/selftests: Check that whitelisted registers are accessible

2019-03-01 Thread Chris Wilson
There is no point in whitelisting a register that the user then cannot write to, so check the register exists before merging such patches. v2: Mark SLICE_COMMON_ECO_CHICKEN1 [731c] as write-only Signed-off-by: Chris Wilson Cc: Dale B Stimson Cc: Michał Winiarski --- .../drm/i915/selftests/int

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3)

2019-03-01 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3) URL : https://patchwork.freedesktop.org/series/56606/ State : success == Summary == CI Bug Log - changes from CI_DRM_5675 -> Patchwork_12336 Summary

[Intel-gfx] [PATCH v7 0/4] drm & vgaarb: handle vgacon removal in vgaarb.

2019-03-01 Thread Gerd Hoffmann
v7: - codestype fixes. - new patch, switching i915 to use drm_fb_helper_remove_conflicting_pci_framebuffers v6: buildfix. Gerd Hoffmann (4): drm: move i915_kick_out_vgacon to vgaarb drm/fb-helper: call vga_remove_vgacon automatically. drm/qxl: remove conflicting framebuffers earlier d

[Intel-gfx] [PATCH v7 1/4] drm: move i915_kick_out_vgacon to vgaarb

2019-03-01 Thread Gerd Hoffmann
Also rename it to vga_remove_vgacon and add kerneldoc text. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- include/linux/vgaarb.h | 2 ++ drivers/gpu/drm/i915/i915_drv.c | 35 + drivers/gpu/vga/vgaarb.c| 49 +

[Intel-gfx] [PATCH v7 2/4] drm/fb-helper: call vga_remove_vgacon automatically.

2019-03-01 Thread Gerd Hoffmann
Add vga_remove_vgacon() call to drm_fb_helper_remove_conflicting_pci_framebuffers(). Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- include/drm/drm_fb_helper.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/

[Intel-gfx] [PATCH v7 4/4] drm/i915: switch to drm_fb_helper_remove_conflicting_pci_framebuffers

2019-03-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/i915/i915_drv.c | 38 ++ 1 file changed, 2 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 9df65d386d11..c6f1e0dbdd58 100644 --- a/drivers/gpu/

[Intel-gfx] [PATCH v7 3/4] drm/qxl: remove conflicting framebuffers earlier

2019-03-01 Thread Gerd Hoffmann
Add error checking while being at it. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index bb81e310eb6d..578d867a81d5

Re: [Intel-gfx] [PATCH v4 2/5] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-03-01 Thread Chris Wilson
Quoting Carlos Santa (2019-02-21 02:58:16) > +#define GEN8_WATCHDOG_1000US(dev_priv) watchdog_to_clock_counts(dev_priv, > 1000) > +static void gen8_watchdog_irq_handler(unsigned long data) > +{ > + struct intel_engine_cs *engine = (struct intel_engine_cs *)data; > + struct drm_i915_pri

[Intel-gfx] [RFT i-g-t] lib/i915: Assert mmap size alignment

2019-03-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Fishing for fails... /* mmap(2) mandates size is page aligned so check this in our wrappers. */ Signed-off-by: Tvrtko Ursulin --- lib/i915/gem_mman.c | 4 tests/kms_psr.c | 8 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/i915/gem_mm

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Check that whitelisted registers are accessible (rev4)

2019-03-01 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check that whitelisted registers are accessible (rev4) URL : https://patchwork.freedesktop.org/series/57342/ State : success == Summary == CI Bug Log - changes from CI_DRM_5675 -> Patchwork_12337

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm & vgaarb: handle vgacon removal in vgaarb. (rev3)

2019-03-01 Thread Patchwork
== Series Details == Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev3) URL : https://patchwork.freedesktop.org/series/57086/ State : warning == Summary == $ dim checkpatch origin/drm-tip e56773c102aa drm: move i915_kick_out_vgacon to vgaarb -:139: CHECK:AVOID_EXTERNS: extern protot

[Intel-gfx] [PATCH 1/2] drm: move a detected edid member to drm_connector from intel_connector

2019-03-01 Thread Gwan-gyeong Mun
In order to use a detected edid on drm helper functions, it moves a detected edid member to drm_connector structure from intel_connector structure. v2: Rebased. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/intel_connector.c | 2 +- drivers/gpu/drm/i915/intel_dp.c| 17 +++

[Intel-gfx] [PATCH 2/2] drm: Add detection of changing of edid on between suspend and resume

2019-03-01 Thread Gwan-gyeong Mun
The hotplug detection routine of drm_helper_hpd_irq_event() can detect changing of status of connector, but it can not detect changing of edid. Following scenario requires detection of changing of edid. 1) plug display device to a connector 2) system suspend 3) unplug 1)'s display device and p

[Intel-gfx] ✓ Fi.CI.BAT: success for drm & vgaarb: handle vgacon removal in vgaarb. (rev3)

2019-03-01 Thread Patchwork
== Series Details == Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev3) URL : https://patchwork.freedesktop.org/series/57086/ State : success == Summary == CI Bug Log - changes from CI_DRM_5675 -> Patchwork_12338 Summary ---

Re: [Intel-gfx] [PATCH 10/11] drm/i915/execlists: Skip direct submission if only lite-restore

2019-03-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-02-28 13:20:50) > > On 26/02/2019 10:24, Chris Wilson wrote: > > If we resubmitting the active context, simply skip the submission as > > we are It took multiple reads to even notice that the third word was missing, mainly because I kept skipping the "we". > > perfo

Re: [Intel-gfx] [PATCH 10/11] drm/i915/execlists: Skip direct submission if only lite-restore

2019-03-01 Thread Chris Wilson
Quoting Chris Wilson (2019-03-01 10:22:30) > Quoting Tvrtko Ursulin (2019-02-28 13:20:50) > > > > On 26/02/2019 10:24, Chris Wilson wrote: > > > If we resubmitting the active context, simply skip the submission as > > > > we are > > It took multiple reads to even notice that the third word was m

[Intel-gfx] [PATCH i-g-t 2/2] automake: Make librt mandatory

2019-03-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin librt is required by libintel_tools so express it as mandatory in autoconf and also drop explicit mentions from Makefile.am. This also fixes a build warning of: tests/Makefile.am:134: warning: variable 'pm_rc6_residency_LDADD' is defined but no program or tests/Makefil

[Intel-gfx] [PATCH i-g-t 1/2] autoconf: Silence void pointer arithmetic warnings

2019-03-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Meson build does it so make the two symmetrical in this respect. v2: * Do it properly. (Chris Wilson) Signed-off-by: Tvrtko Ursulin --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 4f55ea5d0f89..e22703d03198 100644

Re: [Intel-gfx] [PATCH v6 0/3] drm & vgaarb: handle vgacon removal in vgaarb.

2019-03-01 Thread Arkadiusz Hiler
On Fri, Mar 01, 2019 at 07:12:04AM +0100, Gerd Hoffmann wrote: > Hi, > > > > Hmm, I see the test results in patchwork, but I can't remember having > > > seen a mail. > > > So the next question: where the results are sent to? > > From page above sent by Arek: > > " Since we accept patches throug

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/2] autoconf: Silence void pointer arithmetic warnings

2019-03-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-01 10:32:01) > From: Tvrtko Ursulin > > Meson build does it so make the two symmetrical in this respect. > > v2: > * Do it properly. (Chris Wilson) > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson -Chris _

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] automake: Make librt mandatory

2019-03-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-01 10:32:02) > From: Tvrtko Ursulin > > librt is required by libintel_tools so express it as mandatory in autoconf > and also drop explicit mentions from Makefile.am. > > This also fixes a build warning of: > > tests/Makefile.am:134: warning: variable 'pm_rc6_r

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3)

2019-03-01 Thread Patchwork
== Series Details == Series: Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats (rev3) URL : https://patchwork.freedesktop.org/series/56606/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5675_full -> Patchwork_12336_full

[Intel-gfx] [PATCH 1/5] drm/i915/execlists: Suppress redundant preemption

2019-03-01 Thread Chris Wilson
On unwinding the active request we give it a small (limited to internal priority levels) boost to prevent it from being gazumped a second time. However, this means that it can be promoted to above the request that triggered the preemption request, causing a preempt-to-idle cycle for no change. We c

[Intel-gfx] [PATCH 3/5] drm/i915: Keep timeline HWSP allocated until idle across the system

2019-03-01 Thread Chris Wilson
In preparation for enabling HW semaphores, we need to keep in flight timeline HWSP alive until its use across entire system has completed, as any other timeline active on the GPU may still refer back to the already retired timeline. We both have to delay recycling available cachelines and unpinning

[Intel-gfx] [PATCH 2/5] drm/i915: Introduce i915_timeline.mutex

2019-03-01 Thread Chris Wilson
A simple mutex used for guarding the flow of requests in and out of the timeline. In the short-term, it will be used only to guard the addition of requests into the timeline, taken on alloc and released on commit so that only one caller can construct a request into the timeline (important as the se

[Intel-gfx] [PATCH 5/5] drm/i915: Prioritise non-busywait semaphore workloads

2019-03-01 Thread Chris Wilson
We don't want to busywait on the GPU if we have other work to do. If we give non-busywaiting workloads higher (initial) priority than workloads that require a busywait, we will prioritise work that is ready to run immediately. We then also have to be careful that we don't give earlier semaphores an

[Intel-gfx] [PATCH 4/5] drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+

2019-03-01 Thread Chris Wilson
Having introduced per-context seqno, we now have a means to identity progress across the system without feel of rollback as befell the global_seqno. That is we can program a MI_SEMAPHORE_WAIT operation in advance of submission safe in the knowledge that our target seqno and address is stable. Howe

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm: move a detected edid member to drm_connector from intel_connector

2019-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: move a detected edid member to drm_connector from intel_connector URL : https://patchwork.freedesktop.org/series/57397/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6c66b5f875a6 drm: move a detected edid member to d

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: move a detected edid member to drm_connector from intel_connector

2019-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: move a detected edid member to drm_connector from intel_connector URL : https://patchwork.freedesktop.org/series/57397/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5676 -> Patchwork_12339 =

[Intel-gfx] [PATCH xf86-video-intel v2] sna: Switch back to hwcursor on the next cursor update

2019-03-01 Thread Chris Wilson
From: Ville Syrjälä Once we've switched to using the swcursor (possibly due to the cursor ioctl failing) we currently keep using the swcursor until the modeset. That's not particularly great as the swcursor has several issues. Apart from the (presumably expected) flicker, the cursor also tends t

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Keep timeline HWSP allocated until idle across the system

2019-03-01 Thread Tvrtko Ursulin
On 01/03/2019 11:05, Chris Wilson wrote: In preparation for enabling HW semaphores, we need to keep in flight timeline HWSP alive until its use across entire system has completed, as any other timeline active on the GPU may still refer back to the already retired timeline. We both have to delay

Re: [Intel-gfx] [PATCH 3/7] drm/leases: Don't init to 0 in drm_master_create

2019-03-01 Thread Mika Kuoppala
Daniel Vetter writes: > We kzalloc. > > Cc: Keith Packard > Signed-off-by: Daniel Vetter Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/drm_auth.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_auth.c > index 1669c42c40ed..bcf0

Re: [Intel-gfx] [PATCH 03/11] drm/i915/execlists: Suppress redundant preemption

2019-03-01 Thread Tvrtko Ursulin
ping on below On 28/02/2019 13:11, Tvrtko Ursulin wrote: On 26/02/2019 10:23, Chris Wilson wrote: On unwinding the active request we give it a small (limited to internal priority levels) boost to prevent it from being gazumped a second time. However, this means that it can be promoted to abov

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/execlists: Suppress redundant preemption

2019-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/execlists: Suppress redundant preemption URL : https://patchwork.freedesktop.org/series/57400/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/execlists: Suppress redundant preem

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Keep timeline HWSP allocated until idle across the system

2019-03-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-01 11:29:06) > > On 01/03/2019 11:05, Chris Wilson wrote: > > +int i915_timeline_read_hwsp(struct i915_request *from, > > + struct i915_request *to, > > + u32 *hwsp) > > +{ > > + struct i915_timeline_cacheline *cl

Re: [Intel-gfx] [PATCH 03/11] drm/i915/execlists: Suppress redundant preemption

2019-03-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-01 11:31:26) > > ping on below > > On 28/02/2019 13:11, Tvrtko Ursulin wrote: > > > > On 26/02/2019 10:23, Chris Wilson wrote: > >> On unwinding the active request we give it a small (limited to internal > >> priority levels) boost to prevent it from being gazumpe

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+

2019-03-01 Thread Tvrtko Ursulin
On 01/03/2019 11:05, Chris Wilson wrote: Having introduced per-context seqno, we now have a means to identity progress across the system without feel of rollback as befell the global_seqno. That is we can program a MI_SEMAPHORE_WAIT operation in advance of submission safe in the knowledge that o

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Introduce i915_timeline.mutex

2019-03-01 Thread Tvrtko Ursulin
On 01/03/2019 11:05, Chris Wilson wrote: A simple mutex used for guarding the flow of requests in and out of the timeline. In the short-term, it will be used only to guard the addition of requests into the timeline, taken on alloc and released on commit so that only one caller can construct a re

Re: [Intel-gfx] [RFC v4 12/25] drm/i915: Add drm_driver->initial_client_display callback

2019-03-01 Thread Noralf Trønnes
Den 16.04.2018 10.38, skrev Daniel Vetter: > On Sat, Apr 14, 2018 at 01:53:05PM +0200, Noralf Trønnes wrote: >> As part of moving the modesetting code out of drm_fb_helper and into >> drm_client, the drm_fb_helper_funcs->initial_config callback needs to go. >> Replace it with a drm_driver->initia

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Introduce i915_timeline.mutex

2019-03-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-01 11:38:11) > > On 01/03/2019 11:05, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/selftests/mock_timeline.c > > b/drivers/gpu/drm/i915/selftests/mock_timeline.c > > index d2de9ece2118..416d85233263 100644 > > --- a/drivers/gpu/drm/i915/selftests/mock_

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Prioritise non-busywait semaphore workloads

2019-03-01 Thread Tvrtko Ursulin
On 01/03/2019 11:05, Chris Wilson wrote: We don't want to busywait on the GPU if we have other work to do. If we give non-busywaiting workloads higher (initial) priority than workloads that require a busywait, we will prioritise work that is ready to run immediately. We then also have to be care

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/execlists: Suppress redundant preemption

2019-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/execlists: Suppress redundant preemption URL : https://patchwork.freedesktop.org/series/57400/ State : success == Summary == CI Bug Log - changes from CI_DRM_5676 -> Patchwork_12340 ==

Re: [Intel-gfx] [RFC v4 12/25] drm/i915: Add drm_driver->initial_client_display callback

2019-03-01 Thread Daniel Vetter
On Fri, Mar 1, 2019 at 12:46 PM Noralf Trønnes wrote: > > > > Den 16.04.2018 10.38, skrev Daniel Vetter: > > On Sat, Apr 14, 2018 at 01:53:05PM +0200, Noralf Trønnes wrote: > >> As part of moving the modesetting code out of drm_fb_helper and into > >> drm_client, the drm_fb_helper_funcs->initial_c

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Prioritise non-busywait semaphore workloads

2019-03-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-01 11:48:25) > > On 01/03/2019 11:05, Chris Wilson wrote: > > @@ -69,6 +70,10 @@ bool __i915_sched_node_add_dependency(struct > > i915_sched_node *node, > > dep->signaler = signal; > > dep->flags = flags; > > > > + /* Keep

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Check that whitelisted registers are accessible (rev4)

2019-03-01 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check that whitelisted registers are accessible (rev4) URL : https://patchwork.freedesktop.org/series/57342/ State : success == Summary == CI Bug Log - changes from CI_DRM_5675_full -> Patchwork_12337_full ==

[Intel-gfx] [PATCH v2] drm/i915: Prioritise non-busywait semaphore workloads

2019-03-01 Thread Chris Wilson
We don't want to busywait on the GPU if we have other work to do. If we give non-busywaiting workloads higher (initial) priority than workloads that require a busywait, we will prioritise work that is ready to run immediately. We then also have to be careful that we don't give earlier semaphores an

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/execlists: Suppress redundant preemption (rev2)

2019-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/execlists: Suppress redundant preemption (rev2) URL : https://patchwork.freedesktop.org/series/57400/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/execlists: Suppress redundan

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/execlists: Suppress redundant preemption (rev2)

2019-03-01 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/execlists: Suppress redundant preemption (rev2) URL : https://patchwork.freedesktop.org/series/57400/ State : success == Summary == CI Bug Log - changes from CI_DRM_5676 -> Patchwork_12341 ===

[Intel-gfx] [PATCH 08/17] drm/imx: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert imx to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-crtc.c | 30 ++-

[Intel-gfx] [PATCH 11/17] drm/omap: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert omap to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_crtc.c | 11 +-- 1 file ch

[Intel-gfx] [PATCH 04/17] drm/amd: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert amd to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Signed-off-by: Maarten Lankhorst Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++

[Intel-gfx] [PATCH 07/17] drm/i915: Use the new __drm_atomic_helper_crtc_reset() helper.

2019-03-01 Thread Maarten Lankhorst
i915 has its own hw readout and doesn't use the reset helpers directly. Still it has 2 places where it initialises the crtc_state. Fix those by calling __drm_atomic_helper_crtc_reset(). Signed-off-by: Maarten Lankhorst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i

[Intel-gfx] [PATCH 02/17] drm/atomic: Create __drm_atomic_helper_crtc_reset() for subclassing crtc_state.

2019-03-01 Thread Maarten Lankhorst
We already have __drm_atomic_helper_connector_reset() and __drm_atomic_helper_plane_reset(), extend this to crtc as well. This will allow us to set default values in the crtc_state, without having to do it in each driver separately. Of all drivers that need conversion, only nouveau is done in thi

[Intel-gfx] [PATCH 03/17] drm/docs: Fix typo in __drm_atomic_helper_connector_reset

2019-03-01 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_state_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c index bc5ee66f75b3..172c8c698a46 100644 --- a/drivers/gpu/drm/d

[Intel-gfx] [PATCH 10/17] drm/msm: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert msm to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Rob Clark Cc: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++---

[Intel-gfx] [PATCH 15/17] drm/vc4: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert vc4 to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 9 + 1 file changed, 5 ins

[Intel-gfx] [PATCH 06/17] drm/atmel-hlcdc: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert atmel-hlcdc to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Boris Brezillon --- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c| 29

[Intel-gfx] [PATCH 12/17] drm/rcar-du: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert rcar-du to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Laurent Pinchart Cc: Kieran Bingham Cc: linux-renesas-...@vger.kernel.org ---

[Intel-gfx] [PATCH 09/17] drm/mediatek: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert mediatek to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: CK Hu Cc: Philipp Zabel Cc: Matthias Brugger --- drivers/gpu/drm/mediatek/mt

[Intel-gfx] [PATCH 01/17] drm/vc4: Fix memory leak during gpu reset.

2019-03-01 Thread Maarten Lankhorst
__drm_atomic_helper_crtc_destroy_state does not free memory, it only cleans it up. Fix this by calling the functions own destroy function. Fixes: 6d6e50039187 ("drm/vc4: Allocate the right amount of space for boot-time CRTC state.") Cc: Eric Anholt Cc: # v4.6+ Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH 14/17] drm/tegra: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert tegra to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Thierry Reding Cc: Jonathan Hunter Cc: linux-te...@vger.kernel.org --- drivers/g

[Intel-gfx] [PATCH 16/17] drm/vkms: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert vkms to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Rodrigo Siqueira Cc: Haneen Mohammed Cc: Daniel Vetter --- drivers/gpu/drm/vkms/

[Intel-gfx] [PATCH 00/17] drm: Start subclassing crtc_state.

2019-03-01 Thread Maarten Lankhorst
When we want to start adding default values to crtc_state, it makes sense fix all drivers to call __drm_atomic_helper_crtc_reset, like we do for connectors and planes. Maarten Lankhorst (17): drm/vc4: Fix memory leak during gpu reset. drm/atomic: Create __drm_atomic_helper_crtc_reset() for sub

[Intel-gfx] [PATCH 05/17] drm/mali: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert mali to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding malidp_crtc_destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Liviu Dudau Cc: Brian Starkey --- drivers/gpu/drm/arm/malidp_crtc.c |

[Intel-gfx] [PATCH 13/17] drm/rockchip: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert rockchip to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Sandy Huang Cc: "Heiko Stübner" Cc: linux-rockc...@lists.infradead.org --- dr

[Intel-gfx] [PATCH 17/17] drm/vmwgfx: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Maarten Lankhorst
Convert vmwgfx to using __drm_atomic_helper_crtc_reset(), instead of writing its own version. Instead of open coding destroy_state(), call it directly for freeing the old state. Signed-off-by: Maarten Lankhorst Cc: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 20 --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm & vgaarb: handle vgacon removal in vgaarb. (rev3)

2019-03-01 Thread Patchwork
== Series Details == Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev3) URL : https://patchwork.freedesktop.org/series/57086/ State : success == Summary == CI Bug Log - changes from CI_DRM_5675_full -> Patchwork_12338_full Summar

Re: [Intel-gfx] [PATCH xf86-video-intel 2/2] sna: Support 10bpc gamma via the GAMMA_LUT crtc property

2019-03-01 Thread Chris Wilson
Quoting Ville Syrjala (2019-02-18 19:50:52) > From: Ville Syrjälä > > Probe the GAMMA_LUT/GAMMA_LUT_SIZE props and utilize them when > the running with > 8bpc. > > Cc: Mario Kleiner > Signed-off-by: Ville Syrjälä Looks fine to me, so I'll push unless any one objects. -Chris __

Re: [Intel-gfx] [PATCH 12/17] drm/rcar-du: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Laurent Pinchart
Hi Maarten, Thank you for the patch. On Fri, Mar 01, 2019 at 01:56:22PM +0100, Maarten Lankhorst wrote: > Convert rcar-du to using __drm_atomic_helper_crtc_reset(), instead of > writing its own version. Instead of open coding destroy_state(), call > it directly for freeing the old state. I don't

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Start subclassing crtc_state.

2019-03-01 Thread Patchwork
== Series Details == Series: drm: Start subclassing crtc_state. URL : https://patchwork.freedesktop.org/series/57425/ State : warning == Summary == $ dim checkpatch origin/drm-tip 51d3cd4204fb drm/vc4: Fix memory leak during gpu reset. fdfc56a108d3 drm/atomic: Create __drm_atomic_helper_crtc_r

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Start subclassing crtc_state.

2019-03-01 Thread Patchwork
== Series Details == Series: drm: Start subclassing crtc_state. URL : https://patchwork.freedesktop.org/series/57425/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/vc4: Fix memory leak during gpu reset. Okay! Commit: drm/atomic: Create __drm_atom

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915/crc: Make IPS workaround generic

2019-03-01 Thread Ville Syrjälä
On Thu, Feb 28, 2019 at 11:26:57PM +, Souza, Jose wrote: > On Thu, 2019-02-28 at 18:56 +0200, Ville Syrjälä wrote: > > On Wed, Feb 27, 2019 at 05:32:57PM -0800, José Roberto de Souza > > wrote: > > > Other features like PSR2 also needs to be disabled while getting > > > CRC > > > so lets rename

Re: [Intel-gfx] [PATCH 05/17] drm/mali: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-03-01 Thread Liviu Dudau
Hi Maarten, On Fri, Mar 01, 2019 at 01:56:15PM +0100, Maarten Lankhorst wrote: > Convert mali to using __drm_atomic_helper_crtc_reset(), instead of > writing its own version. Instead of open coding > malidp_crtc_destroy_state(), call it directly for freeing the old state. > > Signed-off-by: Maart

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Don't manually add connectors and planes state

2019-03-01 Thread Ville Syrjälä
On Thu, Feb 28, 2019 at 09:27:48PM +, Souza, Jose wrote: > On Thu, 2019-02-28 at 13:37 +0200, Ville Syrjälä wrote: > > On Wed, Feb 27, 2019 at 03:04:08PM -0800, José Roberto de Souza > > wrote: > > > drm_atomic_commit() call chain already takes care of adding > > > connectors and planes, so let

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Start subclassing crtc_state.

2019-03-01 Thread Patchwork
== Series Details == Series: drm: Start subclassing crtc_state. URL : https://patchwork.freedesktop.org/series/57425/ State : success == Summary == CI Bug Log - changes from CI_DRM_5676 -> Patchwork_12342 Summary --- **SUCCESS** N

[Intel-gfx] [PATCH 36/38] drm/i915: Allow specification of parallel execbuf

2019-03-01 Thread Chris Wilson
There is a desire to split a task onto two engines and have them run at the same time, e.g. scanline interleaving to spread the workload evenly. Through the use of the out-fence from the first execbuf, we can coordinate secondary execbuf to only become ready simultaneously with the first, so that w

[Intel-gfx] [PATCH 34/38] drm/i915: Extend execution fence to support a callback

2019-03-01 Thread Chris Wilson
In the next patch, we will want to configure the slave request depending on which physical engine the master request is executed on. For this, we introduce a callback from the execute fence to convey this information. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_request.c | 84 +

[Intel-gfx] [PATCH 35/38] drm/i915/execlists: Virtual engine bonding

2019-03-01 Thread Chris Wilson
Some users require that when a master batch is executed on one particular engine, a companion batch is run simultaneously on a specific slave engine. For this purpose, we introduce virtual engine bonding, allowing maps of master:slaves to be constructed to constrain which physical engines a virtual

[Intel-gfx] [PATCH 32/38] drm/i915: Introduce intel_context.pin_mutex for pin management

2019-03-01 Thread Chris Wilson
Introduce a mutex to start locking the HW contexts independently of struct_mutex, with a view to reducing the coarse struct_mutex. The intel_context.pin_mutex is used to guard the transition to and from being pinned on the gpu, and so is required before starting to build any request, and released w

[Intel-gfx] [PATCH 23/38] drm/i915: Re-arrange execbuf so context is known before engine

2019-03-01 Thread Chris Wilson
From: Tvrtko Ursulin Needed for a following patch. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer

[Intel-gfx] [PATCH 16/38] drm/i915: Introduce a context barrier callback

2019-03-01 Thread Chris Wilson
In the next patch, we will want to update live state within a context. As this state may be in use by the GPU and we haven't been explicitly tracking its activity, we instead attach it to a request we send down the context setup with its new state and on retiring that request cleanup the old state

[Intel-gfx] [PATCH 25/38] drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[]

2019-03-01 Thread Chris Wilson
Allow the user to specify a local engine index (as opposed to class:index) that they can use to refer to a preset engine inside the ctx->engine[] array defined by an earlier I915_CONTEXT_PARAM_ENGINES. This will be useful for setting SSEU parameters on virtual engines that are local to the context

[Intel-gfx] [PATCH 20/38] drm/i915: Allow userspace to clone contexts on creation

2019-03-01 Thread Chris Wilson
A usecase arose out of handling context recovery in mesa, whereby they wish to recreate a context with fresh logical state but preserving all other details of the original. Currently, they create a new context and iterate over which bits they want to copy across, but it would much more convenient i

[Intel-gfx] [PATCH 03/38] drm/i915: Keep timeline HWSP allocated until idle across the system

2019-03-01 Thread Chris Wilson
In preparation for enabling HW semaphores, we need to keep in flight timeline HWSP alive until its use across entire system has completed, as any other timeline active on the GPU may still refer back to the already retired timeline. We both have to delay recycling available cachelines and unpinning

[Intel-gfx] [PATCH 14/38] drm/i915: Introduce the i915_user_extension_method

2019-03-01 Thread Chris Wilson
An idea for extending uABI inspired by Vulkan's extension chains. Instead of expanding the data struct for each ioctl every time we need to add a new feature, define an extension chain instead. As we add optional interfaces to control the ioctl, we define a new extension struct that can be linked i

[Intel-gfx] [PATCH 30/38] drm/i915: Make context pinning part of intel_context_ops

2019-03-01 Thread Chris Wilson
Push the intel_context pin callback down from intel_engine_cs onto the context itself by virtue of having a central caller for intel_context_pin() being able to lookup the intel_context itself. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_context.c | 34 ++ drivers/gpu

[Intel-gfx] [PATCH 02/38] drm/i915: Introduce i915_timeline.mutex

2019-03-01 Thread Chris Wilson
A simple mutex used for guarding the flow of requests in and out of the timeline. In the short-term, it will be used only to guard the addition of requests into the timeline, taken on alloc and released on commit so that only one caller can construct a request into the timeline (important as the se

  1   2   3   >