[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Fix legacy gamma mode for ICL

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix legacy gamma mode for ICL URL : https://patchwork.freedesktop.org/series/58079/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5754_full -> Patchwork_12487_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: pass cfgcr* register around instead of pll_id

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915/icl: pass cfgcr* register around instead of pll_id URL : https://patchwork.freedesktop.org/series/58084/ State : success == Summary == CI Bug Log - changes from CI_DRM_5756 -> Patchwork_12490 Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/ehl: Add EHL platform info and PCI IDs

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/ehl: Add EHL platform info and PCI IDs URL : https://patchwork.freedesktop.org/series/58078/ State : success == Summary == CI Bug Log - changes from CI_DRM_5754_full -> Patchwork_12486_full ==

[Intel-gfx] [PATCH] drm/i915/icl: pass cfgcr* register around instead of pll_id

2019-03-15 Thread Lucas De Marchi
The caller already knows what platform that is and what register should be used. Instead of keep adding if/else chains on a leaf functions, let the caller pass the register. We read cfgcr0 twice for CNL, but we were already doing that anyway. icl_calc_dp_combo_pll_link() is only used for ICL, but

Re: [Intel-gfx] [CI 3/6] drm/i915/ehl: Add dpll mgr

2019-03-15 Thread Lucas De Marchi
On Fri, Mar 15, 2019 at 10:57 AM Rodrigo Vivi wrote: > > From: Lucas De Marchi > > Elkhart Lake has a different set of PLLs as compared to Ice Lake, > although programming them is very similar. > > Signed-off-by: Lucas De Marchi > Signed-off-by: Rodrigo Vivi > Reviewed-by: José Roberto de Souza

Re: [Intel-gfx] [RFC 01/10] drm/i915: do not pass dev_priv to low-level forcewake functions

2019-03-15 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-03-13 23:13:10) > The only usage we have for it is for the regs pointer. Save a pointer to > the set and ack registers instead of the register offsets to remove this > requirement > > Cc: Paulo Zanoni > Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Chris

Re: [Intel-gfx] [RFC 08/10] drm/i915: make raw access function work on uncore

2019-03-15 Thread Paulo Zanoni
Em qua, 2019-03-13 às 16:13 -0700, Daniele Ceraolo Spurio escreveu: > This allows us to ditch i915 in some more places. > > RFC: should we just make them work directly on the regs pointer instead? Both options look better than passing God Object dev_priv, so I'm fine with either. To give a paral

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix clockgating issue when using scalars

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix clockgating issue when using scalars URL : https://patchwork.freedesktop.org/series/58081/ State : success == Summary == CI Bug Log - changes from CI_DRM_5756 -> Patchwork_12489 Summary ---

Re: [Intel-gfx] [RFC 06/10] drm/i915: reduce the dev_priv->uncore dance in uncore.c

2019-03-15 Thread Paulo Zanoni
Em qua, 2019-03-13 às 16:13 -0700, Daniele Ceraolo Spurio escreveu: > Use a local variable where it makes sense. Also worth it on its own IMHO. Reviewed-by: Paulo Zanoni > > Cc: Paulo Zanoni > Signed-off-by: Daniele Ceraolo Spurio > --- > drivers/gpu/drm/i915/intel_uncore.c | 79 +++

[Intel-gfx] [PATCH i-g-t] sw_sync: Wait until the end

2019-03-15 Thread Chris Wilson
If we allow a fork-helper to exit normally before the parent tries to reap the helper (fork-helpers are intended to be only used for persistent background loads), then the helper unhelpful aborts because the child exited cleanly. Simplify by not using the so called helpers at all. Bugzilla: https

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase timeout for DP Aux channel ctl signal URL : https://patchwork.freedesktop.org/series/58077/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12485_full =

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Vanshidhar Konda
On Fri, Mar 15, 2019 at 02:43:46PM -0700, Rodrigo Vivi wrote: On Fri, Mar 15, 2019 at 02:39:25PM -0700, Rodrigo Vivi wrote: On Fri, Mar 15, 2019 at 02:31:40PM -0700, Rodrigo Vivi wrote: > On Fri, Mar 15, 2019 at 01:27:22PM -0700, Vanshidhar Konda wrote: > > On Fri, Mar 15, 2019 at 12:38:41PM -07

Re: [Intel-gfx] [PATCH v4 0/3] drm/i915: introduce macros to define register contents

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 03:56:17PM +0200, Jani Nikula wrote: > v4 of [1], rebased and very mildly tweaked, with the intention to merge. before it starts conflicting again :) > I added > Chris' Reviewed-bys despite the rebase. Acked-by: Rodrigo Vivi Do you intend to follow-up with a big sed or

Re: [Intel-gfx] [RFC 05/10] drm/i915: make find_fw_domain work on intel_uncore

2019-03-15 Thread Paulo Zanoni
Em qua, 2019-03-13 às 16:13 -0700, Daniele Ceraolo Spurio escreveu: > Remove unneeded usage of dev_priv from 1 extra function. > Reviewed-by: Paulo Zanoni > Cc: Paulo Zanoni > Signed-off-by: Daniele Ceraolo Spurio > --- > drivers/gpu/drm/i915/intel_uncore.c | 20 ++-- > 1 fil

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev4)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev4) URL : https://patchwork.freedesktop.org/series/57900/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5756 -> Patchwork_12488

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix clockgating issue when using scalars

2019-03-15 Thread Chris Wilson
Scalars as opposed to vector instructions? EU clock gating issues with certain shaders? Itym scalers. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add support for retrying hotplug

2019-03-15 Thread Souza, Jose
On Fri, 2019-03-15 at 03:39 +0200, Imre Deak wrote: > On Fri, Mar 15, 2019 at 02:25:36AM +0200, Souza, Jose wrote: > > On Thu, 2019-03-14 at 18:09 +0200, Imre Deak wrote: > > > On Tue, Mar 12, 2019 at 05:58:51PM -0700, José Roberto de Souza > > > wrote: > > > > From: Imre Deak > > > > > > > > The

Re: [Intel-gfx] [RFC 04/10] drm/i915: make more uncore function work on intel_uncore

2019-03-15 Thread Paulo Zanoni
Em qua, 2019-03-13 às 16:13 -0700, Daniele Ceraolo Spurio escreveu: > Move the init, fini, prune, suspend, resume function to work on > intel_uncore instead of dev_priv > A common theme in this series is the last sentence of a commit message missing the final period ("."). Please fix all of them

[Intel-gfx] [PATCH] drm/i915/icl: Fix clockgating issue when using scalars

2019-03-15 Thread Radhakrishna Sripada
Fixes the clock-gating issue when pipe scaling is enabled. (Lineage #2006604312) Cc: Rodrigo Vivi Cc: Anusha Srivatsa Cc: Aditya Swarup Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_display.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/6] drm/i915/ehl: Add EHL platform info and PCI IDs

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/ehl: Add EHL platform info and PCI IDs URL : https://patchwork.freedesktop.org/series/58076/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12484_full ===

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix PSR2 selective update corruption after PSR1 setup

2019-03-15 Thread Dhinakaran Pandiyan
On Thu, 2019-03-14 at 16:01 -0700, José Roberto de Souza wrote: > There is probably a issue in DMC firmwares(icl_dmc_ver1_07.bin and > kbl_dmc_ver1_04.bin at least) that causes PSR2 SU to fail nit: instead of "fail", it is better to document what you see visually - freeze, flicker, corruption etc.

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 02:39:25PM -0700, Rodrigo Vivi wrote: > On Fri, Mar 15, 2019 at 02:31:40PM -0700, Rodrigo Vivi wrote: > > On Fri, Mar 15, 2019 at 01:27:22PM -0700, Vanshidhar Konda wrote: > > > On Fri, Mar 15, 2019 at 12:38:41PM -0700, Rodrigo Vivi wrote: > > > > On Fri, Mar 15, 2019 at 11:

Re: [Intel-gfx] [RFC 03/10] drm/i915: use intel_uncore for all forcewake get/put

2019-03-15 Thread Paulo Zanoni
Em qua, 2019-03-13 às 16:13 -0700, Daniele Ceraolo Spurio escreveu: > Now that the internal code all works on intel_uncore, flip the > external-facing interface. Long but trivial patch. It breaks compilation of gvt but that's also trivial to fix. Unlike patches 1 and 2, this one doesn't add much

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 02:31:40PM -0700, Rodrigo Vivi wrote: > On Fri, Mar 15, 2019 at 01:27:22PM -0700, Vanshidhar Konda wrote: > > On Fri, Mar 15, 2019 at 12:38:41PM -0700, Rodrigo Vivi wrote: > > > On Fri, Mar 15, 2019 at 11:39:54AM -0700, Vanshidhar Konda wrote: > > > > Extend the timeout for

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 01:27:22PM -0700, Vanshidhar Konda wrote: > On Fri, Mar 15, 2019 at 12:38:41PM -0700, Rodrigo Vivi wrote: > > On Fri, Mar 15, 2019 at 11:39:54AM -0700, Vanshidhar Konda wrote: > > > Extend the timeout for the hardware to signal SEND_BUSY on the DP > > > Aux Channel Controlle

Re: [Intel-gfx] [RFC 02/10] drm/i915: use intel_uncore in fw get/put internal paths

2019-03-15 Thread Paulo Zanoni
Em qua, 2019-03-13 às 16:13 -0700, Daniele Ceraolo Spurio escreveu: > Get/put functions used outside of uncore.c are updated in the next > patch for a nicer split > > Cc: Paulo Zanoni > Signed-off-by: Daniele Ceraolo Spurio I really like this one, replacing a gazillion i915->uncore.x with only

Re: [Intel-gfx] [RFC 07/10] drm/i915: move regs pointer inside the uncore structure

2019-03-15 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-03-13 23:13:16) > This will allow futher simplifications in the uncore handling. > > RFC: if we want to keep the pointer logically separate from the uncore, > we could also move both the regs pointer and the uncore struct > inside a new structure (intel_mmio?)

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Sanity check mmap length against object size (rev2)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Sanity check mmap length against object size (rev2) URL : https://patchwork.freedesktop.org/series/57977/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12482_full

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Preocmpute/readout/check CHV CGM mode

2019-03-15 Thread Ville Syrjälä
On Wed, Mar 13, 2019 at 03:11:55PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjala [mailto:ville.syrj...@linux.intel.com] > >Sent: Tuesday, February 19, 2019 1:02 AM > >To: intel-gfx@lists.freedesktop.org > >Cc: Shankar, Uma ; Roper, Matthew D > > > >Subject: [

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix legacy gamma mode for ICL

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix legacy gamma mode for ICL URL : https://patchwork.freedesktop.org/series/58079/ State : success == Summary == CI Bug Log - changes from CI_DRM_5754 -> Patchwork_12487 Sum

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Vanshidhar Konda
On Fri, Mar 15, 2019 at 12:38:41PM -0700, Rodrigo Vivi wrote: On Fri, Mar 15, 2019 at 11:39:54AM -0700, Vanshidhar Konda wrote: Extend the timeout for the hardware to signal SEND_BUSY on the DP Aux Channel Controller register. This is needed to address FDO #109982 https://bugzilla.freedesktop.o

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/ehl: Add EHL platform info and PCI IDs

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/ehl: Add EHL platform info and PCI IDs URL : https://patchwork.freedesktop.org/series/58078/ State : success == Summary == CI Bug Log - changes from CI_DRM_5754 -> Patchwork_12486

Re: [Intel-gfx] [RFC 01/10] drm/i915: do not pass dev_priv to low-level forcewake functions

2019-03-15 Thread Paulo Zanoni
Em qua, 2019-03-13 às 16:13 -0700, Daniele Ceraolo Spurio escreveu: > The only usage we have for it is for the regs pointer. Save a pointer to > the set and ack registers instead of the register offsets to remove this > requirement Reviewed-by: Paulo Zanoni > > Cc: Paulo Zanoni > Signed-off-by

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Clean up ilk+ csc stuff (rev2)

2019-03-15 Thread Ville Syrjälä
On Fri, Mar 15, 2019 at 06:19:08PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Clean up ilk+ csc stuff (rev2) > URL : https://patchwork.freedesktop.org/series/56857/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12478_f

[Intel-gfx] [PATCH 2/2] drm/i915: Turn off the CUS when turning off a HDR plane

2019-03-15 Thread Ville Syrjala
From: Ville Syrjälä We're currently leaving the CUS enabled if we disable the master plane directly after scanning out NV12. Could perhaps cause the selected slave plane to misbehave if we try to use it for scanning out something non-NV12? Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/2] drm/i915: Fix legacy gamma mode for ICL

2019-03-15 Thread Ville Syrjala
From: Ville Syrjälä We must remember to actually enable the post CSC gamma if we expect the legacy LUT to work. Seems to fix NV12 crc tests on the SDR planes. Curiously we apparently managed to get 100% match for the HDR planes even without chopping off the low bits. Cc: Uma Shankar Signed-off-

Re: [Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 11:39:54AM -0700, Vanshidhar Konda wrote: > Extend the timeout for the hardware to signal SEND_BUSY on the DP > Aux Channel Controller register. > > This is needed to address FDO #109982 > https://bugzilla.freedesktop.org/show_bug.cgi?id=109982 instead of mentioning like t

Re: [Intel-gfx] [PATCH 2/2] x86/gpu: add ElkhartLake to gen11 early quirks

2019-03-15 Thread Souza, Jose
On Fri, 2019-03-15 at 12:19 -0700, Rodrigo Vivi wrote: > Let's reserve EHL stolen memory for graphics. > > ElkhartLake is a gen11 platform which is compatible with > ICL changes. Reviewed-by: José Roberto de Souza > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Pet

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ehl: Add EHL platform info and PCI IDs

2019-03-15 Thread Souza, Jose
On Fri, 2019-03-15 at 12:19 -0700, Rodrigo Vivi wrote: > From: James Ausmus > > Add known EHL PCI IDs. > > v2 (Rodrigo): Removed x86 early quirk. To be sent in a separated > patch cc'ing the appropriated list and maintainers for > proper ack. > v3: (Rodrigo): - Removed .n

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix off-by-one in reporting hanging process

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix off-by-one in reporting hanging process URL : https://patchwork.freedesktop.org/series/58073/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12481_full Summar

[Intel-gfx] [PATCH 2/2] x86/gpu: add ElkhartLake to gen11 early quirks

2019-03-15 Thread Rodrigo Vivi
Let's reserve EHL stolen memory for graphics. ElkhartLake is a gen11 platform which is compatible with ICL changes. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: José Roberto de Souza Signed-off-by: Rodrigo Vivi --- arch/x86/kernel/ear

[Intel-gfx] [PATCH 1/2] drm/i915/ehl: Add EHL platform info and PCI IDs

2019-03-15 Thread Rodrigo Vivi
From: James Ausmus Add known EHL PCI IDs. v2 (Rodrigo): Removed x86 early quirk. To be sent in a separated patch cc'ing the appropriated list and maintainers for proper ack. v3: (Rodrigo): - Removed .num_pipes = 3 that is coming since GEN&_FEATURES. - A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915/display: Increase timeout for DP Aux channel ctl signal URL : https://patchwork.freedesktop.org/series/58077/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12485 Summa

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915/ehl: Add EHL platform info and PCI IDs

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915/ehl: Add EHL platform info and PCI IDs URL : https://patchwork.freedesktop.org/series/58076/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12484 =

Re: [Intel-gfx] [PATCH] drm/i915: Drop platform_mask

2019-03-15 Thread Lucas De Marchi
On Fri, Mar 15, 2019 at 08:19:58PM +0200, Ville Syrjälä wrote: On Fri, Mar 15, 2019 at 07:13:49AM +, Tvrtko Ursulin wrote: On 15/03/2019 06:56, Tvrtko Ursulin wrote: > > On 15/03/2019 00:52, Chris Wilson wrote: >> Quoting José Roberto de Souza (2019-03-15 00:42:35) >>> We don't have any pla

Re: [Intel-gfx] [PATCH] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Lucas De Marchi
On Fri, Mar 15, 2019 at 05:31:05PM +, Tvrtko Ursulin wrote: On 15/03/2019 17:12, Lucas De Marchi wrote: On Fri, Mar 15, 2019 at 12:26:33PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar

[Intel-gfx] [PATCH] drm/i915/display: Increase timeout for DP Aux channel ctl signal

2019-03-15 Thread Vanshidhar Konda
Extend the timeout for the hardware to signal SEND_BUSY on the DP Aux Channel Controller register. This is needed to address FDO #109982 https://bugzilla.freedesktop.org/show_bug.cgi?id=109982 Cc: Ville Syrjälä Cc: Imre Deak Signed-off-by: Vanshidhar Konda --- drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Sanity check mmap length against object size (rev2)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Sanity check mmap length against object size (rev2) URL : https://patchwork.freedesktop.org/series/57977/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12482 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Introduce concept of a sub-platform (rev3)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Introduce concept of a sub-platform (rev3) URL : https://patchwork.freedesktop.org/series/58056/ State : failure == Summary == Applying: drm/i915: Introduce concept of a sub-platform error: corrupt patch at line 199 error: could not build fake ancestor hi

Re: [Intel-gfx] [PATCH] drm/i915: Drop platform_mask

2019-03-15 Thread Ville Syrjälä
On Fri, Mar 15, 2019 at 07:13:49AM +, Tvrtko Ursulin wrote: > > On 15/03/2019 06:56, Tvrtko Ursulin wrote: > > > > On 15/03/2019 00:52, Chris Wilson wrote: > >> Quoting José Roberto de Souza (2019-03-15 00:42:35) > >>> We don't have any platform that is composed by 2 or more platforms so > >>

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Clean up ilk+ csc stuff (rev2)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Clean up ilk+ csc stuff (rev2) URL : https://patchwork.freedesktop.org/series/56857/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12478_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix off-by-one in reporting hanging process

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix off-by-one in reporting hanging process URL : https://patchwork.freedesktop.org/series/58073/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12481 Summary ---

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gtt: Refactor common ppgtt initialisation

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 10:26:04AM -0700, Bob Paauwe wrote: > On Fri, 15 Mar 2019 10:01:51 -0700 > Rodrigo Vivi wrote: > > > On Fri, Mar 15, 2019 at 09:55:47AM -0700, Bob Paauwe wrote: > > > On Fri, 15 Mar 2019 09:09:11 + > > > Chris Wilson wrote: > > > > > > > Quoting Rodrigo Vivi (2019-

[Intel-gfx] [CI 6/6] drm/i915/ehl: Add Support for DMC on EHL

2019-03-15 Thread Rodrigo Vivi
From: Anusha Srivatsa EHL uses the same firmware as ICL. Cc: Bob Paauwe Signed-off-by: Anusha Srivatsa Signed-off-by: Rodrigo Vivi Reviewed-by: Lucas De Marchi Link: https://patchwork.freedesktop.org/patch/msgid/20190313211144.4842-9-rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_cs

[Intel-gfx] [CI 2/6] drm/i915/ehl: Add ElkhartLake platform

2019-03-15 Thread Rodrigo Vivi
From: Bob Paauwe Add ElkhartLake as a unique platform as there are some differences between it and Icelake. Signed-off-by: Bob Paauwe Signed-off-by: Rodrigo Vivi Reviewed-by: Lucas De Marchi Link: https://patchwork.freedesktop.org/patch/msgid/20190313211144.4842-2-rodrigo.v...@intel.com ---

[Intel-gfx] [CI 3/6] drm/i915/ehl: Add dpll mgr

2019-03-15 Thread Rodrigo Vivi
From: Lucas De Marchi Elkhart Lake has a different set of PLLs as compared to Ice Lake, although programming them is very similar. Signed-off-by: Lucas De Marchi Signed-off-by: Rodrigo Vivi Reviewed-by: José Roberto de Souza Link: https://patchwork.freedesktop.org/patch/msgid/20190313211144.

[Intel-gfx] [CI 4/6] drm/i915/ehl: EHL outputs are different from ICL

2019-03-15 Thread Rodrigo Vivi
From: Bob Paauwe Configure the correct set of outputs for EHL. EHL has three DDI's plus MIPI. Cc: Lucas De Marchi Signed-off-by: Bob Paauwe Signed-off-by: Rodrigo Vivi Reviewed-by: Lucas De Marchi Link: https://patchwork.freedesktop.org/patch/msgid/20190313211144.4842-6-rodrigo.v...@intel.c

[Intel-gfx] [CI 1/6] drm/i915/ehl: Add EHL platform info and PCI IDs

2019-03-15 Thread Rodrigo Vivi
From: James Ausmus Add known EHL PCI IDs. v2 (Rodrigo): Removed x86 early quirk. To be sent in a separated patch cc'ing the appropriated list and maintainers for proper ack. Cc: Bob Paauwe Signed-off-by: James Ausmus Signed-off-by: Rodrigo Vivi Reviewed-by: José Roberto de Souza Link: h

[Intel-gfx] [CI 5/6] drm/i915/ehl: Set proper eu slice/subslice parameters for EHL

2019-03-15 Thread Rodrigo Vivi
From: Bob Paauwe EHL has a different number of subslices. Cc: Lucas De Marchi Signed-off-by: Bob Paauwe Signed-off-by: Rodrigo Vivi Reviewed-by: Lucas De Marchi Link: https://patchwork.freedesktop.org/patch/msgid/20190313211144.4842-7-rodrigo.v...@intel.com --- drivers/gpu/drm/i915/intel_d

Re: [Intel-gfx] [PATCH] drm/i915: Drop platform_mask

2019-03-15 Thread Paulo Zanoni
Em sex, 2019-03-15 às 06:56 +, Tvrtko Ursulin escreveu: > On 15/03/2019 00:52, Chris Wilson wrote: > > Quoting José Roberto de Souza (2019-03-15 00:42:35) > > > We don't have any platform that is composed by 2 or more platforms so > > > we don't need a mask, lets drop it and remove the actual l

[Intel-gfx] ✗ Fi.CI.BAT: failure for no-primary

2019-03-15 Thread Patchwork
== Series Details == Series: no-primary URL : https://patchwork.freedesktop.org/series/58072/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12480 Summary --- **FAILURE** Serious unknown changes c

Re: [Intel-gfx] [PATCH v5] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Tvrtko Ursulin
On 15/03/2019 17:28, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-03-15 17:09:28) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 3d8020888604..e3360a31f8d3 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_g

Re: [Intel-gfx] [PATCH] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Tvrtko Ursulin
On 15/03/2019 17:12, Lucas De Marchi wrote: On Fri, Mar 15, 2019 at 12:26:33PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar),implemented via the macros which check a list of device ids to

Re: [Intel-gfx] [PATCH v5] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-15 17:09:28) > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c > b/drivers/gpu/drm/i915/i915_gpu_error.c > index 3d8020888604..e3360a31f8d3 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -677,6 +677,7 @@ st

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gtt: Refactor common ppgtt initialisation

2019-03-15 Thread Bob Paauwe
On Fri, 15 Mar 2019 10:01:51 -0700 Rodrigo Vivi wrote: > On Fri, Mar 15, 2019 at 09:55:47AM -0700, Bob Paauwe wrote: > > On Fri, 15 Mar 2019 09:09:11 + > > Chris Wilson wrote: > > > > > Quoting Rodrigo Vivi (2019-03-14 22:53:44) > > > > On Thu, Mar 14, 2019 at 10:38:39PM +, Chris Wi

Re: [Intel-gfx] [PATCH] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Lucas De Marchi
On Fri, Mar 15, 2019 at 12:26:33PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar),implemented via the macros which check a list of device ids to determine a match. With this patch we consoli

[Intel-gfx] [PATCH v5] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar),implemented via the macros which check a list of device ids to determine a match. With this patch we consolidate device ids checking into a single function called during earl

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gtt: Refactor common ppgtt initialisation

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 09:55:47AM -0700, Bob Paauwe wrote: > On Fri, 15 Mar 2019 09:09:11 + > Chris Wilson wrote: > > > Quoting Rodrigo Vivi (2019-03-14 22:53:44) > > > On Thu, Mar 14, 2019 at 10:38:39PM +, Chris Wilson wrote: > > > > The basic setup of the i915_hw_ppgtt is the same be

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: introduce macros to define register contents (rev4)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: introduce macros to define register contents (rev4) URL : https://patchwork.freedesktop.org/series/50513/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12476_full

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gtt: Refactor common ppgtt initialisation

2019-03-15 Thread Bob Paauwe
On Fri, 15 Mar 2019 09:09:11 + Chris Wilson wrote: > Quoting Rodrigo Vivi (2019-03-14 22:53:44) > > On Thu, Mar 14, 2019 at 10:38:39PM +, Chris Wilson wrote: > > > The basic setup of the i915_hw_ppgtt is the same between gen6 and gen8, > > > so refactor that into a common routine. > > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in reporting hanging process

2019-03-15 Thread Rodrigo Vivi
On Fri, Mar 15, 2019 at 04:39:33PM +, Chris Wilson wrote: > ffs() is 1-indexed, but we want to use it as an index into an array, so > use __ffs() instead. > > Fixes: eb8d0f5af4ec ("drm/i915: Remove GPU reset dependence on struct_mutex") > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala Rev

[Intel-gfx] [PATCH] drm/i915: Fix off-by-one in reporting hanging process

2019-03-15 Thread Chris Wilson
ffs() is 1-indexed, but we want to use it as an index into an array, so use __ffs() instead. Fixes: eb8d0f5af4ec ("drm/i915: Remove GPU reset dependence on struct_mutex") Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- 1 file changed, 1 insertion(

Re: [Intel-gfx] [PATCH] no-primary

2019-03-15 Thread Chris Wilson
Wrong branch... -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] no-primary

2019-03-15 Thread Chris Wilson
--- drivers/gpu/drm/drm_debugfs.c | 2 +- drivers/gpu/drm/drm_drv.c | 12 drivers/gpu/drm/drm_prime.c | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index f8468eae0503..f7044ff82f9c 100644 -

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix PSR2 selective update corruption after PSR1 setup

2019-03-15 Thread Rodrigo Vivi
On Thu, Mar 14, 2019 at 04:01:13PM -0700, José Roberto de Souza wrote: > There is probably a issue in DMC firmwares(icl_dmc_ver1_07.bin and > kbl_dmc_ver1_04.bin at least) that causes PSR2 SU to fail after > exiting DC6 if EDP_PSR_TP1_TP3_SEL is kept in PSR_CTL, so for now > lets workaround the iss

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clean up ilk+ csc stuff (rev2)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Clean up ilk+ csc stuff (rev2) URL : https://patchwork.freedesktop.org/series/56857/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12478 Summary --- **SUCCESS*

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/21] drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3)

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [01/21] drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev3) URL : https://patchwork.freedesktop.org/series/58065/ State : failure == Summary == Applying: drm/i915: Move intel_engine_mask_t around for use by i915_r

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread John Ogness
On 2019-03-14, John Ogness wrote: > On 2019-03-14, Daniel Vetter wrote: >> That's why we came up with the trylock + immediate bail out design if >> that fails. Plus really only render the oops int whatever is the >> current display buffer, so that we don't have to do any hw >> programming at all.

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Get active pending request for given context

2019-03-15 Thread Ankit Navik
Hi Tvrtko, On Tue, Nov 6, 2018 at 3:14 PM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > On 06/11/2018 04:13, Ankit Navik wrote: > > From: Praveen Diwakar > > > > This patch gives us the active pending request count which is yet > > to be submitted to the GPU > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Update render power clock state configuration for given context

2019-03-15 Thread Ankit Navik
Hi Tvrtko, On Tue, Dec 11, 2018 at 6:06 PM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > On 11/12/2018 10:14, Ankit Navik wrote: > > From: Praveen Diwakar > > > > This patch will update power clock state register at runtime base on the > > flag which can set by any governor which c

Re: [Intel-gfx] [PATCH v2 1/3] drm: Add support for panic message output

2019-03-15 Thread John Ogness
On 2019-03-14, Daniel Vetter wrote: > That's why we came up with the trylock + immediate bail out design if > that fails. Plus really only render the oops int whatever is the > current display buffer, so that we don't have to do any hw programming > at all. I think this is your best option. The r

Re: [Intel-gfx] [PATCH] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Tvrtko Ursulin
On 15/03/2019 15:55, Ville Syrjälä wrote: On Fri, Mar 15, 2019 at 02:21:57PM +, Tvrtko Ursulin wrote: [snip] diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h index 047d10bdd455..b03fbd2e451a 100644 --- a/drivers/gpu/drm/i915/intel_device_i

Re: [Intel-gfx] [PATCH] drm/i915/display: Reduce log level for DP command signal timeout

2019-03-15 Thread Vanshidhar Konda
On Fri, Mar 15, 2019 at 03:35:04PM +0200, Ville Syrjälä wrote: On Thu, Mar 14, 2019 at 06:37:22PM -0700, Vanshidhar Konda wrote: On Thu, Mar 14, 2019 at 11:09:38PM +0200, Ville Syrjälä wrote: >On Thu, Mar 14, 2019 at 02:00:29PM -0700, Vanshidhar Konda wrote: >> On Thu, Mar 14, 2019 at 10:47:56PM

Re: [Intel-gfx] [PATCH] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Ville Syrjälä
On Fri, Mar 15, 2019 at 05:55:19PM +0200, Ville Syrjälä wrote: > On Fri, Mar 15, 2019 at 02:21:57PM +, Tvrtko Ursulin wrote: > > > > On 15/03/2019 14:09, Ville Syrjälä wrote: > > > On Fri, Mar 15, 2019 at 12:26:33PM +, Tvrtko Ursulin wrote: > > >> -#define IS_KBL_ULX(dev_priv)(INTEL_DE

Re: [Intel-gfx] [PATCH] drm/i915: Introduce concept of a sub-platform

2019-03-15 Thread Ville Syrjälä
On Fri, Mar 15, 2019 at 02:21:57PM +, Tvrtko Ursulin wrote: > > On 15/03/2019 14:09, Ville Syrjälä wrote: > > On Fri, Mar 15, 2019 at 12:26:33PM +, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> Concept of a sub-platform already exist in our code (like ULX and ULT > >> platform

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev2)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h (rev2) URL : https://patchwork.freedesktop.org/series/58052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5753_full -> Patchwork_12474_full

[Intel-gfx] [PATCH] drm/i915: Allow userspace to clone contexts on creation

2019-03-15 Thread Chris Wilson
A usecase arose out of handling context recovery in mesa, whereby they wish to recreate a context with fresh logical state but preserving all other details of the original. Currently, they create a new context and iterate over which bits they want to copy across, but it would much more convenient i

[Intel-gfx] [PATCH] drm/i915/execlists: Virtual engine bonding

2019-03-15 Thread Chris Wilson
Some users require that when a master batch is executed on one particular engine, a companion batch is run simultaneously on a specific slave engine. For this purpose, we introduce virtual engine bonding, allowing maps of master:slaves to be constructed to constrain which physical engines a virtual

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/21] drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h

2019-03-15 Thread Chris Wilson
Quoting Patchwork (2019-03-15 15:44:37) > == Series Details == > > Series: series starting with [01/21] drm/i915: Move intel_engine_mask_t > around for use by i915_request_types.h > URL : https://patchwork.freedesktop.org/series/58065/ > State : failure > > == Summary == > > CI Bug Log - chan

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/21] drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h

2019-03-15 Thread Patchwork
== Series Details == Series: series starting with [01/21] drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h URL : https://patchwork.freedesktop.org/series/58065/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12477

Re: [Intel-gfx] [PATCH 15/21] drm/i915: Allow userspace to clone contexts on creation

2019-03-15 Thread Chris Wilson
Quoting Chris Wilson (2019-03-15 15:03:27) > +static int create_clone(struct i915_user_extension __user *ext, void *data) > +{ > + static int (* const fn[])(struct i915_gem_context *dst, > + struct i915_gem_context *src) = { > + [ilog2(I915_CONTEX

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: introduce macros to define register contents (rev4)

2019-03-15 Thread Patchwork
== Series Details == Series: drm/i915: introduce macros to define register contents (rev4) URL : https://patchwork.freedesktop.org/series/50513/ State : success == Summary == CI Bug Log - changes from CI_DRM_5753 -> Patchwork_12476 Summary

[Intel-gfx] [PATCH 12/21] drm/i915: Create/destroy VM (ppGTT) for use with contexts

2019-03-15 Thread Chris Wilson
In preparation to making the ppGTT binding for a context explicit (to facilitate reusing the same ppGTT between different contexts), allow the user to create and destroy named ppGTT. v2: Replace global barrier for swapping over the ppgtt and tlbs with a local context barrier (Tvrtko) v3: serialise

[Intel-gfx] [PATCH 02/21] drm/i915: Sanity check mmap length against object size

2019-03-15 Thread Chris Wilson
We assumed that vm_mmap() would reject an attempt to mmap past the end of the filp (our object), but we were wrong. Reported-by: Antonio Argenziano Testcase: igt/gem_mmap/bad-size Signed-off-by: Chris Wilson Cc: Antonio Argenziano Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: sta...@vger.kernel.

[Intel-gfx] [PATCH 10/21] drm/i915: Introduce a mutex for file_priv->context_idr

2019-03-15 Thread Chris Wilson
Define a mutex for the exclusive use of interacting with the per-file context-idr, that was previously guarded by struct_mutex. This allows us to reduce the coverage of struct_mutex, with a view to removing the last bits coordinating GEM context later. (In the short term, we avoid taking struct_mut

[Intel-gfx] [PATCH 03/21] drm/i915: Hold a ref to the ring while retiring

2019-03-15 Thread Chris Wilson
As the final request on a ring may hold the reference to this ring (via retiring the last pinned context), we may find ourselves chasing a dangling pointer on completion of the list. A quick solution is to hold a reference to the ring itself as we retire along it so that we only free it after we s

[Intel-gfx] [PATCH 01/21] drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h

2019-03-15 Thread Chris Wilson
We want to use intel_engine_mask_t inside i915_request.h, which means extracting it from the general header file mess and placing it inside a types.h. A knock on effect is that the compiler wants to warn about type-contraction of ALL_ENGINES into intel_engine_maskt_t, so prepare for the worst. Sig

[Intel-gfx] [PATCH 07/21] drm/i915/selftests: Provide stub reset functions

2019-03-15 Thread Chris Wilson
If a test fails, we quite often mark the device as wedged. Provide the stub functions so that we can wedge the mock device, and avoid exploding on test failures. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109981 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/mock_engi

[Intel-gfx] [PATCH 08/21] drm/i915: Switch to use HWS indices rather than addresses

2019-03-15 Thread Chris Wilson
If we use the STORE_DATA_INDEX function we can use a fixed offset and avoid having to lookup up the engine HWS address. A step closer to being able to emit the final breadcrumb during request_add rather than later in the submission interrupt handler. Signed-off-by: Chris Wilson --- drivers/gpu/d

[Intel-gfx] [PATCH 21/21] drm/i915: Allow specification of parallel execbuf

2019-03-15 Thread Chris Wilson
There is a desire to split a task onto two engines and have them run at the same time, e.g. scanline interleaving to spread the workload evenly. Through the use of the out-fence from the first execbuf, we can coordinate secondary execbuf to only become ready simultaneously with the first, so that w

  1   2   >