== Series Details ==
Series: drm/i915: stick to kernel fixed size types
URL : https://patchwork.freedesktop.org/series/58135/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5768_full -> Patchwork_12500_full
Summary
---
== Series Details ==
Series: drm/i915: Move intel_engine_mask_t around for use by
i915_request_types.h (rev3)
URL : https://patchwork.freedesktop.org/series/58052/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5768_full -> Patchwork_12499_full
== Series Details ==
Series: drm/i915: Ensure minimum CDCLK requirement for audio
URL : https://patchwork.freedesktop.org/series/58132/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5767_full -> Patchwork_12498_full
Summary
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: Add support for retrying hotplug
URL : https://patchwork.freedesktop.org/series/58156/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12508
===
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: Add support for retrying hotplug
URL : https://patchwork.freedesktop.org/series/58156/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Add support for retrying hotplug
-drive
== Series Details ==
Series: series starting with [CI,1/2] drm/i915: Lock the
gem_context->active_list while dropping the link
URL : https://patchwork.freedesktop.org/series/58151/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12507
=
== Series Details ==
Series: drm/i915: Handle YUV subpixel support better
URL : https://patchwork.freedesktop.org/series/58130/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5767_full -> Patchwork_12497_full
Summary
---
== Series Details ==
Series: series starting with [1/3] drm/i915: Add some missing curly braces
URL : https://patchwork.freedesktop.org/series/58148/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12506
Sum
== Series Details ==
Series: series starting with [1/2] drm/i915/cml: Add CML PCI IDS
URL : https://patchwork.freedesktop.org/series/58147/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12505
Summary
-
Hi all,
Today's linux-next merge of the drm-misc tree got a conflict in:
drivers/gpu/drm/i915/intel_hdmi.c
between commit:
fbf08556ed43 ("drm/i915: Precompute HDMI infoframes")
from the drm-intel tree and commit:
2f146b78d5a9 ("drm/i915: Attach colorspace property and enable modeset")
== Series Details ==
Series: series starting with [1/2] drm/i915/cml: Add CML PCI IDS
URL : https://patchwork.freedesktop.org/series/58147/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/cml: Add CML PCI IDS
Okay!
Commit: drm/i915/cml: Introd
== Series Details ==
Series: series starting with [1/2] drm/i915/cml: Add CML PCI IDS
URL : https://patchwork.freedesktop.org/series/58147/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2e242bf601c6 drm/i915/cml: Add CML PCI IDS
-:44: ERROR:COMPLEX_MACRO: Macros with complex va
On Tue, Mar 12, 2019 at 10:58:44PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> skl_build_pipe_wm() is quite pointless now. Just inline it into
I think you actually mean skl_update_pipe_wm(), right?
The code change looks good, so with an updated commit message,
Reviewed-by: Matt Roper
On Tue, Mar 12, 2019 at 10:58:43PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> {skl,icl}_build_plane_wm() don't need to be passed the pipe_wm, so
> don't. And skl_build_pipe_wm() can easily dig it out itself.
>
> Cc: Neel Desai
> Signed-off-by: Ville Syrjälä
Reviewed-by: Matt Roper
On Tue, Mar 12, 2019 at 10:58:42PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Clean up skl_allocate_pipe_ddb() a bit by moving the 'wm' variable
> to tighter scope. We'll also consitify it where appropriate.
>
> Cc: Neel Desai
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/
On Tue, Mar 12, 2019 at 10:58:41PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Currently we disable all the watermarks above the selected max
> level for every plane. That would mean that the cursor's watermarks
> may also get modified when another plane causes the selected
> max waterm
== Series Details ==
Series: drm/i915: Fix PSR2 selective update corruption after PSR1 setup (rev5)
URL : https://patchwork.freedesktop.org/series/57900/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12504
On Mon, Mar 18, 2019 at 05:39:48PM -0600, Shaobo He wrote:
> Hi Rodrigo,
>
> Sorry I'm a bit lost here. May I ask where the `WARN` is?
along with the return NULL
struct i2c_adapter *intel_gmbus_get_adapte()
if (WARN_ON(!intel_gmbus_is_valid_pin(dev_priv, pin)))
return NULL;
>
>
Right now we are aware of two cases that needs another hotplug retry:
- Unpowered type-c dongles
- HDMI slow unplug
Both have a complete explanation in the code to schedule another run
of the hotplug handler.
It could have more checks to just trigger the retry in those two
specific cases but why
From: Imre Deak
There is some scenarios that we are aware that sink probe can fail,
so lets add the infrastructure to let hotplug() hook to request
another probe after some time.
v2: Handle shared HPD pins (Imre)
Cc: Ville Syrjälä
Signed-off-by: José Roberto de Souza
Signed-off-by: Jani Nikul
== Series Details ==
Series: series starting with [1/6] drm/i915: Reorder gen3/4 swizzle detection
logic
URL : https://patchwork.freedesktop.org/series/58139/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5770 -> Patchwork_12503
===
On Mon, Mar 18, 2019 at 08:53:23PM +0200, Ville Syrjälä wrote:
On Mon, Mar 18, 2019 at 11:40:34AM -0700, Lucas De Marchi wrote:
On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote:
>On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote:
>> The caller already knows what platfo
Hi Shaobo,
n Mon, Mar 18, 2019 at 05:01:10PM -0600, Shaobo He wrote:
> Hello everyone,
>
> My name is Shaobo He and I am a graduate student at University of Utah. I am
> using a static analysis tool to search for null pointer dereferences and
> came across a potentially invalid memory access in t
On Mon, 2019-03-18 at 21:22 +, Chris Wilson wrote:
> Quoting Sripada, Radhakrishna (2019-03-18 21:19:29)
> > On Fri, 2019-03-15 at 22:23 +, Chris Wilson wrote:
> > > Scalars as opposed to vector instructions? EU clock gating issues
> > > with
> > > certain shaders?
> > >
> >
> > Hi Chris,
On Mon, 2019-03-18 at 15:30 +0200, Ville Syrjälä wrote:
> On Fri, Mar 15, 2019 at 03:18:38PM -0700, Radhakrishna Sripada wrote:
> > Fixes the clock-gating issue when pipe scaling is enabled.
> > (Lineage #2006604312)
> >
> > Cc: Rodrigo Vivi
> > Cc: Anusha Srivatsa
> > Cc: Aditya Swarup
> > Sig
On 03/18, Chris Wilson wrote:
> Quoting Rodrigo Siqueira (2019-03-18 21:53:42)
> > On 03/18, Chris Wilson wrote:
> > > Quoting Rodrigo Siqueira (2019-03-18 21:35:44)
> > > > On 03/18, Ville Syrjälä wrote:
> > > > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote:
> > > > > > The km
On 03/18, Liviu Dudau wrote:
> On Wed, Mar 06, 2019 at 06:30:05PM -0300, Rodrigo Siqueira wrote:
> > Hi Liviu,
> >
> > I’m using your patchset to guide my implementation of writeback in the
> > VKMS, so, first of all, thanks :)
> >
> > During my work, I noticed that you’re setting the drmSetClien
On Mon, Mar 18, 2019 at 08:53:23PM +0200, Ville Syrjälä wrote:
On Mon, Mar 18, 2019 at 11:40:34AM -0700, Lucas De Marchi wrote:
On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote:
>On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote:
>> The caller already knows what platfo
Quoting Rodrigo Siqueira (2019-03-18 21:53:42)
> On 03/18, Chris Wilson wrote:
> > Quoting Rodrigo Siqueira (2019-03-18 21:35:44)
> > > On 03/18, Ville Syrjälä wrote:
> > > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote:
> > > > > The kms_flip test relies on VBlank support, and
On 03/18, Chris Wilson wrote:
> Quoting Rodrigo Siqueira (2019-03-18 21:35:44)
> > On 03/18, Ville Syrjälä wrote:
> > > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote:
> > > > The kms_flip test relies on VBlank support, and this situation may
> > > > exclude some virtual drivers t
Quoting Rodrigo Siqueira (2019-03-18 21:35:44)
> On 03/18, Ville Syrjälä wrote:
> > On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote:
> > > The kms_flip test relies on VBlank support, and this situation may
> > > exclude some virtual drivers to take advantage of this set of tests.
>
On 03/18, Ville Syrjälä wrote:
> On Sat, Mar 16, 2019 at 11:00:23AM -0300, Rodrigo Siqueira wrote:
> > The kms_flip test relies on VBlank support, and this situation may
> > exclude some virtual drivers to take advantage of this set of tests.
> > This commit adds a mechanism that checks if a module
On unpinning the intel_context, we remove it from the active list
inside the GEM context. This list is supposed to be guarded by the GEM
context mutex, so remember to take it!
Fixes: 7e3d9a59410d ("drm/i915: Track active engines within a context")
Signed-off-by: Chris Wilson
Reviewed-by: Tvrtko U
For virtual engines, we need to keep the HW context alive while it
remains in use. For regular HW contexts, they are created and kept alive
until the end of the GEM context. For simplicity, generalise the
requirements and keep an active reference to each HW context.
Signed-off-by: Chris Wilson
Re
Quoting Sripada, Radhakrishna (2019-03-18 21:19:29)
> On Fri, 2019-03-15 at 22:23 +, Chris Wilson wrote:
> > Scalars as opposed to vector instructions? EU clock gating issues
> > with
> > certain shaders?
> >
> Hi Chris,
>
> The scalers mentioned for this WA around are specific to display
> s
On Fri, 2019-03-15 at 22:23 +, Chris Wilson wrote:
> Scalars as opposed to vector instructions? EU clock gating issues
> with
> certain shaders?
>
Hi Chris,
The scalers mentioned for this WA around are specific to display
scaling. They are not related to EU clock gating.
-Radhakrishna(RK) Sr
Quoting Tvrtko Ursulin (2019-03-18 16:45:41)
>
> On 18/03/2019 16:35, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2019-03-18 16:28:35)
> >>
> >> On 18/03/2019 09:51, Chris Wilson wrote:
> >>> Define a mutex for the exclusive use of interacting with the per-file
> >>> context-idr, that was prev
On Mon, Mar 18, 2019 at 09:45:16PM +0100, Michal Wajdeczko wrote:
> > Make things look a bit nicer by passing dev_priv to
>
> In other places we are changing naming from dev_priv to i915.
> Can we do the same here ?
The display code uses dev_priv quite consistently,. We could
go for i915 I suppos
== Series Details ==
Series: series starting with [1/3] drm/i915: Split Pineview device info into
desktop and mobile
URL : https://patchwork.freedesktop.org/series/58123/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5765_full -> Patchwork_12495_full
=
Make things look a bit nicer by passing dev_priv to
In other places we are changing naming from dev_priv to i915.
Can we do the same here ?
~Michal
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listin
== Series Details ==
Series: drm/i915: Clean up intel_color_check()
URL : https://patchwork.freedesktop.org/series/58137/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12502
Summary
---
**SUCCESS**
On Mon, Mar 18, 2019 at 10:26:53PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Make things look a bit nicer by passing dev_priv to
> intel_is_dual_link_lvds().
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/intel_display.c | 28 ++
On Mon, Mar 18, 2019 at 10:26:51PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Sprinkle some curly braces in accordance with the coding style.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 +++
> 1 file changed
On Mon, Mar 18, 2019 at 10:26:52PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pass dev_priv to intel_get_lvds_encoder() and polish the
> implementation a bit.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> drivers/g
From: Ville Syrjälä
Sprinkle some curly braces in accordance with the coding style.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915
== Series Details ==
Series: drm/i915/psr: remove drmP.h include that crept in
URL : https://patchwork.freedesktop.org/series/58136/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12501
Summary
---
*
From: Ville Syrjälä
Pass dev_priv to intel_get_lvds_encoder() and polish the
implementation a bit.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
drivers/gpu/drm/i915/intel_drv.h | 2 +-
drivers/gpu/drm/i915/intel_lvds.c | 13 +++--
3 files changed, 9 ins
From: Ville Syrjälä
Make things look a bit nicer by passing dev_priv to
intel_is_dual_link_lvds().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 28
drivers/gpu/drm/i915/intel_drv.h | 2 +-
drivers/gpu/drm/i915/intel_lvds.c| 4 ++
== Series Details ==
Series: drm/i915: Clean up intel_color_check()
URL : https://patchwork.freedesktop.org/series/58137/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Extract check_luts()
Okay!
Commit: drm/i915: Turn intel_color_check() in
From: Anusha Srivatsa
Comet Lake is a Intel Processor containing Gen9
Intel HD Graphics. This patch adds the initial set of
PCI IDs. Comet Lake comes off of Coffee Lake - adding
the IDs to Coffee Lake ID list.
More support and features will be in the patches that follow.
v2: Split IDs according
From: Anusha Srivatsa
Comet Lake PCH is based off of Cannon Point(CNP).
Add PCI ID for Comet Lake PCH.
v2: Code cleanup (DK)
v3: Comment cleanup (Jani)
Cc: Jani Nikula
Cc: Dhinakaran Pandiyan
Cc: Rodrigo Vivi
Signed-off-by: Anusha Srivatsa
Reviewed-by: Rodrigo Vivi
---
drivers/gpu/drm/i9
On Mon, 2019-03-18 at 18:04 +0200, Jani Nikula wrote:
> We've been free of deprecated drmP.h includes for a while, but one
> crept
> in. Fend it off.
Reviewed-by: José Roberto de Souza
>
> Cc: José Roberto de Souza
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_psr.c | 1 -
>
== Series Details ==
Series: drm/i915: stick to kernel fixed size types
URL : https://patchwork.freedesktop.org/series/58135/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12500
Summary
---
**SUCCES
On Mon, Mar 18, 2019 at 08:37:33PM +0200, Ville Syrjälä wrote:
> On Mon, Mar 18, 2019 at 04:34:35PM +0200, Imre Deak wrote:
> > @@ -2137,6 +2194,44 @@ void intel_set_cdclk(struct drm_i915_private
> > *dev_priv,
> > }
> > }
> >
> > +/**
> > + * intel_set_cdclk_pre_plane_update - Push the CDC
== Series Details ==
Series: drm/i915: Move intel_engine_mask_t around for use by
i915_request_types.h (rev3)
URL : https://patchwork.freedesktop.org/series/58052/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5768 -> Patchwork_12499
==
On Mon, Mar 18, 2019 at 07:09:59AM +, Tvrtko Ursulin wrote:
On 15/03/2019 18:40, Lucas De Marchi wrote:
On Fri, Mar 15, 2019 at 05:31:05PM +, Tvrtko Ursulin wrote:
On 15/03/2019 17:12, Lucas De Marchi wrote:
On Fri, Mar 15, 2019 at 12:26:33PM +, Tvrtko Ursulin wrote:
From: Tvrtk
On Mon, Mar 18, 2019 at 11:40:34AM -0700, Lucas De Marchi wrote:
> On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote:
> >On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote:
> >> The caller already knows what platform that is and what register should
> >> be used. Instead of
== Series Details ==
Series: drm/i915: Move intel_engine_mask_t around for use by
i915_request_types.h (rev3)
URL : https://patchwork.freedesktop.org/series/58052/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Move intel_engine_mask_t aroun
== Series Details ==
Series: drm/i915: Move intel_engine_mask_t around for use by
i915_request_types.h (rev3)
URL : https://patchwork.freedesktop.org/series/58052/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
443b208a11ff drm/i915: Move intel_engine_mask_t around for use by
On Mon, Mar 18, 2019 at 03:31:52PM +0200, Ville Syrjälä wrote:
On Fri, Mar 15, 2019 at 05:45:26PM -0700, Lucas De Marchi wrote:
The caller already knows what platform that is and what register should
be used. Instead of keep adding if/else chains on a leaf functions,
let the caller pass the regi
On Mon, Mar 18, 2019 at 04:34:35PM +0200, Imre Deak wrote:
> @@ -2137,6 +2194,44 @@ void intel_set_cdclk(struct drm_i915_private *dev_priv,
> }
> }
>
> +/**
> + * intel_set_cdclk_pre_plane_update - Push the CDCLK state to the hardware
> + * @dev_priv: i915 device
> + * @cdclk_state: new CD
== Series Details ==
Series: drm/i915: Ensure minimum CDCLK requirement for audio
URL : https://patchwork.freedesktop.org/series/58132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5767 -> Patchwork_12498
Summary
---
On Mon, Mar 18, 2019 at 04:13:57PM +0100, Maarten Lankhorst wrote:
> Op 18-03-2019 om 15:18 schreef Ville Syrjälä:
> > On Mon, Mar 18, 2019 at 03:07:18PM +0100, Maarten Lankhorst wrote:
> >> Signed-off-by: Maarten Lankhorst
> >> ---
> >> drivers/gpu/drm/i915/intel_sprite.c | 29 ++
On 3/15/19 1:50 PM, Chris Wilson wrote:
Quoting Daniele Ceraolo Spurio (2019-03-13 23:13:16)
This will allow futher simplifications in the uncore handling.
RFC: if we want to keep the pointer logically separate from the uncore,
we could also move both the regs pointer and the uncore struct
in
Am Freitag, 1. März 2019, 13:56:23 CET schrieb Maarten Lankhorst:
> Convert rockchip to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding
> destroy_state(), call it directly for freeing the old state.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Sa
== Series Details ==
Series: drm/i915: Ensure minimum CDCLK requirement for audio
URL : https://patchwork.freedesktop.org/series/58132/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled
== Series Details ==
Series: drm/i915: Ensure minimum CDCLK requirement for audio
URL : https://patchwork.freedesktop.org/series/58132/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f5ea7a63eeb3 drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is
enabled
-:60: CHECK:
== Series Details ==
Series: drm/i915: Handle YUV subpixel support better
URL : https://patchwork.freedesktop.org/series/58130/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5767 -> Patchwork_12497
Summary
---
**SUCC
== Series Details ==
Series: drm/i915: Handle YUV subpixel support better
URL : https://patchwork.freedesktop.org/series/58130/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Handle YUV subpixel support better
+drivers/gpu/drm/i915/intel_spri
== Series Details ==
Series: drm/i915: Handle YUV subpixel support better
URL : https://patchwork.freedesktop.org/series/58130/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
383e00c03163 drm/i915: Handle YUV subpixel support better
-:7: WARNING:COMMIT_MESSAGE: Missing commit de
== Series Details ==
Series: series starting with [01/22] drm/i915: Flush pages on acquisition
URL : https://patchwork.freedesktop.org/series/58122/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5767 -> Patchwork_12496
Summ
== Series Details ==
Series: series starting with [01/22] drm/i915: Flush pages on acquisition
URL : https://patchwork.freedesktop.org/series/58122/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Flush pages on acquisition
-drivers/gpu/drm/i9
== Series Details ==
Series: series starting with [01/22] drm/i915: Flush pages on acquisition
URL : https://patchwork.freedesktop.org/series/58122/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
db0c17ac314c drm/i915: Flush pages on acquisition
2f0c66c9e084 drm/i915: Move intel
From: Ville Syrjälä
The current gen2 DPLL readout code:
* assumes i845/i865 have LVDS which is not true
* assumes only pipe B can drive LVDS (true, but makes
the code appear a bit magical)
* hard to parse in general
Clean it up by checking for i85x (the only gen2 platform
with LVDS) and reusin
From: Ville Syrjälä
We want to allow the desktop PNV to not have .is_mobile set. To
that end let's add a small helper to determine if the platform
has the ASLE interrupt (or equivalent). Supposdely both PNV
variants have it.
Cc: Tvrtko Ursulin
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/
From: Ville Syrjälä
To allow unsetting .is_mobile for the desktop variant
of PNV fix up the cdclk code to select the mobile HPLLVCO register
for both PNV variants.
Cc: Tvrtko Ursulin
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_cdclk.c | 3 ++-
1 file changed, 2 insertions(+),
From: Ville Syrjälä
Add a small helper to determine if we have the panel power
sequencer or not. We'll make PNV an exceptional case so
that we can unset .is_mobile for the desktop variant.
Cc: Tvrtko Ursulin
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 10 +-
From: Ville Syrjälä
g33/i964g/g45 are the exceptional cases when it comes to
the swizzle detectiong. Let's reorder the code to handle
them first and let everything else be handled by the
else branch. This allows us to unset .is_mobile for the
desktop PNV variant (which supposedly must follow the
From: Ville Syrjälä
Make the code self-documenting by introducing i9xx_has_pfit().
Also make PNV an exceptional case so that we can unset
.is_mobile for the desktop variant.
Cc: Tvrtko Ursulin
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file chan
On Fri, Mar 15, 2019 at 04:05:12PM -0700, Vanshidhar Konda wrote:
> On Fri, Mar 15, 2019 at 02:43:46PM -0700, Rodrigo Vivi wrote:
> > On Fri, Mar 15, 2019 at 02:39:25PM -0700, Rodrigo Vivi wrote:
> > > On Fri, Mar 15, 2019 at 02:31:40PM -0700, Rodrigo Vivi wrote:
> > > > On Fri, Mar 15, 2019 at 01:
Hi list,
driver version used: 2.99.917+git8674.25c9a2fcc-2.1
Xorg: 1.20.4
Is there a reason why the "intel" Xorg driver uses DRI2
by default instead of DRI3 ? If you want DRI3 you need to use
Option "DRI" "3".
Using DRI2 cause problems with compositors such as compton, in partocular
is causes
On 18/03/2019 16:32, Chris Wilson wrote:
Quoting Chris Wilson (2019-03-18 16:30:58)
Quoting Tvrtko Ursulin (2019-03-18 16:22:12)
On 18/03/2019 09:51, Chris Wilson wrote:
+static int gem_context_register(struct i915_gem_context *ctx,
+ struct drm_i915_file_private
On 18/03/2019 16:35, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-03-18 16:28:35)
On 18/03/2019 09:51, Chris Wilson wrote:
Define a mutex for the exclusive use of interacting with the per-file
context-idr, that was previously guarded by struct_mutex. This allows us
to reduce the coverage
Quoting Tvrtko Ursulin (2019-03-18 16:28:35)
>
> On 18/03/2019 09:51, Chris Wilson wrote:
> > Define a mutex for the exclusive use of interacting with the per-file
> > context-idr, that was previously guarded by struct_mutex. This allows us
> > to reduce the coverage of struct_mutex, with a view t
Quoting Chris Wilson (2019-03-18 16:30:58)
> Quoting Tvrtko Ursulin (2019-03-18 16:22:12)
> >
> > On 18/03/2019 09:51, Chris Wilson wrote:
> > > +static int gem_context_register(struct i915_gem_context *ctx,
> > > + struct drm_i915_file_private *fpriv)
> > > +{
> > > +
Quoting Tvrtko Ursulin (2019-03-18 16:22:12)
>
> On 18/03/2019 09:51, Chris Wilson wrote:
> > +static int gem_context_register(struct i915_gem_context *ctx,
> > + struct drm_i915_file_private *fpriv)
> > +{
> > + int ret;
> > +
>
> Assert struct mutex for now? With
On 18/03/2019 09:51, Chris Wilson wrote:
Define a mutex for the exclusive use of interacting with the per-file
context-idr, that was previously guarded by struct_mutex. This allows us
to reduce the coverage of struct_mutex, with a view to removing the last
bits coordinating GEM context later. (I
On Fri, 15 Mar 2019 10:57:11 -0700
Rodrigo Vivi wrote:
> From: Anusha Srivatsa
>
> EHL uses the same firmware as ICL.
Reviewed-by: Bob Paauwe
>
> Cc: Bob Paauwe
> Signed-off-by: Anusha Srivatsa
> Signed-off-by: Rodrigo Vivi
> Reviewed-by: Lucas De Marchi
> Link:
> https://patchwork.fre
On 18/03/2019 09:51, Chris Wilson wrote:
In later patches, it became apparent that userspace can see a partially
constructed GEM context and begin using it before it was ready, to much
hilarity. Close this window of opportunity by lifting the registration of
the context with userspace (the inser
On Fri, 15 Mar 2019 12:32:22 -0700
"Souza, Jose" wrote:
> On Fri, 2019-03-15 at 12:19 -0700, Rodrigo Vivi wrote:
> > From: James Ausmus
> >
> > Add known EHL PCI IDs.
> >
> > v2 (Rodrigo): Removed x86 early quirk. To be sent in a separated
> > patch cc'ing the appropriated list and m
From: Ville Syrjälä
Provide a separate .color_check() for BDW+ where we currently
provide the split gamma mode etc.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_color.c | 39 ++
1 file changed, 39 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel
From: Ville Syrjälä
We now bypass the legacy LUT when it's not needed, so
no point in filling it up with a linear LUT.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_color.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/
From: Ville Syrjälä
With everything else moved out of the way only ilk+
remains using _intel_color_check(). Streamline the logic
into ilk_color_check().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_color.c | 70 --
1 file changed, 27 insertions(+), 43
From: Ville Syrjälä
Don't load the linear degamma LUT on ICL. The hardware no longer
has any silly linkages between the CSC enable and degamma LUT
enable so the degamma LUT is only needed when it's actually
enabled.
Also add comments to explain the situation on GLK.
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
In prepartion for per-platform color_check() functions extract the
common code into a separate function.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_color.c | 68 ++
1 file changed, 40 insertions(+), 28 deletions(-)
diff --git a/
From: Ville Syrjälä
ICL is rather easy when it comes to .color_check() as it
finally provides us with a full color pipeline with
individual knobs for each stage.
We'll also start bypassing each LUT individually when
it is not needed.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel
From: Ville Syrjälä
intel_color_check() is mess. Blow it up into clean platform sized
chunks. Also eliminate some redundant linear LUT loads as a result.
Ville Syrjälä (10):
drm/i915: Extract check_luts()
drm/i915: Turn intel_color_check() into a vfunc
drm/i915: Extract i9xx_color_check()
From: Ville Syrjälä
The current intel_color_check() is a mess, and worse yet it is
in fact incorrect for several platforms. The hardware has
evolved quite a bit over the years, so let's just go for a clean
split between the platforms by turning this into a vfunc.
The actual work to split it up wi
From: Ville Syrjälä
Since CHV has the CGM unit we require a custom implementation
of .color_check().
This fixes the computation of gamma_enable as previously we
left it enabled even when were using the CGM gamma instead.
Now we turn off the legacy LUT unless it's actually required.
Signed-off-b
From: Ville Syrjälä
Apart from CHV the other gmch platforms don't currently
require much work in .color_check(). So let's start by
extracting i9xx_color_check().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_color.c | 33 +-
1 file changed, 28 insertio
1 - 100 of 184 matches
Mail list logo
